[{"id":3677966,"web_url":"http://patchwork.ozlabs.org/comment/3677966/","msgid":"","list_archive_url":null,"date":"2026-04-16T07:11:30","subject":"Re: [PATCH] ui/clipboard: clear deferred serial reset flag on resume","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"content":"On Thu, Apr 16, 2026 at 11:04 AM GuoHan Zhao wrote:\n>\n> cb_reset_serial_on_resume defers a clipboard serial reset until the\n> machine runs again. qemu_clipboard_change_state() performs that reset\n> on resume, but leaves the flag set.\n>\n> As a result, every later transition back to RUNNING triggers another\n> QEMU_CLIPBOARD_RESET_SERIAL notification even when no reset is pending.\n> That causes unnecessary reset handling in clipboard backends such as\n> vdagent and dbus.\n>\n> Clear the deferred flag before resetting so the reset is performed only\n> once for each deferred request.\n>\n> Fixes: c967ff606b99 (\"ui/clipboard: delay clipboard update when not running\")\n> Signed-off-by: GuoHan Zhao \n\nReviewed-by: Marc-André Lureau \n\n> ---\n> ui/clipboard.c | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/ui/clipboard.c b/ui/clipboard.c\n> index ec00a0b8ec75..e3d8a31ba9f7 100644\n> --- a/ui/clipboard.c\n> +++ b/ui/clipboard.c\n> @@ -47,6 +47,7 @@ static void qemu_clipboard_change_state(void *opaque, bool running, RunState sta\n> }\n>\n> if (cb_reset_serial_on_resume) {\n> + cb_reset_serial_on_resume = false;\n> qemu_clipboard_reset_serial();\n> }\n>\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=BonkCZaJ;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=SrCKpFeR;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx8NQ5NqVz1yCv\n\tfor ; Thu, 16 Apr 2026 17:12:37 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDGtG-0004Oa-Ma; Thu, 16 Apr 2026 03:11:54 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDGtE-0004O7-CC\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 03:11:52 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDGtB-0000td-5y\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 03:11:52 -0400","from mail-pf1-f198.google.com (mail-pf1-f198.google.com\n [209.85.210.198]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-230-dXF9Et4PM1CbBl3PdDnP6Q-1; Thu, 16 Apr 2026 03:11:45 -0400","by mail-pf1-f198.google.com with SMTP id\n d2e1a72fcca58-82f3eaf4b9aso2232821b3a.0\n for ; Thu, 16 Apr 2026 00:11:45 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776323507;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=fZ/T6GX2E5UZY8hVaSvcfGYVhoYfCP9I1IIWjM5tQYo=;\n b=BonkCZaJUnuPKFaF7/AUBCBJp8DeQUlIMDwMakJLuU6vUrS3zQNr6qR3bV2E7BvDLNbws0\n e4fNc466zF4jRPlG/iK4nwXDuHpg4wHl6xHiqlFgIQ3oXnl2zAvKKXTWfBndQN+f+txFht\n CeEaswLY+9iHdNXC/Xn102Yun1oU6aI=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776323504; x=1776928304; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=fZ/T6GX2E5UZY8hVaSvcfGYVhoYfCP9I1IIWjM5tQYo=;\n b=SrCKpFeRbgSc698uyqrMvfsBvEkq08weyzrUEjQaaZSRpZBVPxCi54f7AKob343/+n\n fcE1dnOiAC+nGWe184xVr9g9oVWs8lMD9tVI524z5wEXxPBwMC//e1tUxhSKY9vdub+s\n V9mNqfi9RR8y+DAhrEnd9Jwz6P39W8hkR7lLmrltFE0PklTWYkZFYul+2feKUTzNFbyV\n 7c7fVSZVaP0gBPtRfCn7ZXK98ASlEulcf+/7UInUbJL/9a42a4Chx2ukA89keYS7IrRc\n uRblDPzd+4T6eEy402Jihc14XVxBRNd439JHznDVnM9i3eWhDzEaGmXnGpv6TrLu8hNe\n XmMQ=="],"X-MC-Unique":"dXF9Et4PM1CbBl3PdDnP6Q-1","X-Mimecast-MFC-AGG-ID":"dXF9Et4PM1CbBl3PdDnP6Q_1776323504","ARC-Seal":"i=1; a=rsa-sha256; t=1776323504; cv=none;\n d=google.com; s=arc-20240605;\n b=LjpBoWRionBMTjZTKf37tV0xSoODr0iL1ovz8GbMGjQbnAyu7iGitAtUMm02daa07P\n AKLebBhuqU0vG9JP8r9wVr4BrdIaSShc7YswMbTIDQhl4+G4Qmx5GWyCOrFU2Ccsbj2s\n Wc7IwX2CGZrJIYMM/FnVTdsOyQY8miSBVna0LPFYbeG+UAWYqEHWVRRAPoGJHMPkObZW\n SOI/qD60U7Gt1iavtlt9MBbTOF0wQUKibOyURlhVUHaXnJ9MfapB764JjErcmb9db9Qa\n bDYEOeTERZNCrXoWk/T5U9JYxorpl0HUOHK1USzG+M5Ve5DGkj8c0toaXZj+OvS5D9yL\n Wm/A==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=fZ/T6GX2E5UZY8hVaSvcfGYVhoYfCP9I1IIWjM5tQYo=;\n fh=ckKiQtaduSoU7Do81eCOdreQ45xLs6uc450ueGmOpCM=;\n b=Wmwie3v97jIPPueQpe1oepPwxf1LXdv01yY9Bq+wO10PjX2femZEpi+0g4GfwIpYBE\n Du+bSMlXv6/ALhq08Aa0i/ndxEOFvMlEUFMbg1QyUE0fR7slGx8MwixTndJME1uLCnDv\n TqmYx5ZI13cVKirWO80yXVy3TqyhaABh7ShGHBNRILj5TvfLsN8ZYATkqL3P9PAL0e+1\n Y8hdzkSyr0W+vbKg2GorXx8/3g3aft9DC/vwTjResWm2D6T172lLSq4cC1jRWPrRCXNM\n XPN837Wtjuoj0toxGQSiFJFXHZiOf14qsc5FmBWXrKIFZnMkE5GuMdvI8u16XQi7xbuI\n 5HsA==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776323504; x=1776928304;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=fZ/T6GX2E5UZY8hVaSvcfGYVhoYfCP9I1IIWjM5tQYo=;\n b=GqpIa3XzQ+nivybnTYWWcYnOE7wqX7SouLViWvOTfzbbuEcZKvbruBGTKn4JBgvIVZ\n UpfbV9WN2e1egkE8kOoVHQZ+k0T5v7SJEhERx/bstUSjVTSOfbChbLTZCONGX0neKpVL\n xJN6hBNTOpfq+Q+ZsDhOUGnDWpO4kVdxU9zTZrImfrYvxIlfA9GeYKpy254vUCeQhwph\n YXAq9lFdEuw79xaWKTSa7lwLB8NE7SYQw5AWB9S6E5kOpPrhxLzqbj8L4or0tP6SwbF5\n fM2m9TSFZ4MxCRHk369e7x6uzoX3fOgR9OxEHeAjpWquJBZ/gSF9eJ8VmeZxGRSEoaEM\n EWGA==","X-Gm-Message-State":"AOJu0YxfZx26ckCsl9mcI1vV7fgUBnE3cR2ZGeSyVe8dUvSKYEdf0F1H\n XMPVT8W4CiXae/rcWTZ7dTO8ufMaj/nNYaGAHQ+PpNQe7qlP1912+FHLp64fQ+MxeQ7etIz8qt1\n jpgv2co7sgpHApwtLcTF5xhRma5yBdVmDp4IbKWaA7Qqwpw49wEnjmepztffNNt4pqbEKDqXCKt\n fCtPTJAcdB2dDUYKlzL8gTWBsEr/fNN4Ixf6PBKetJ1g==","X-Gm-Gg":"AeBDiesiqh7t9/re1/CSeSWs2y/YEruUbuNEXKhk5pD3zfyQY3vDeNpfDlWQNVVYUeu\n o8u+G3ui/GokbOa6qsUSr9xWasRXKnfMZXrtvWpuY5pGIJnt7qX/DjDZNHWKQ0H/3hG3OCGcnv4\n CajhIw1REZhwRCf6Hsi/TWDNFQxQiHNYyVDUJBY9LRz1qzRhPgfD6c5g6+p3NScncoGd60hSQEY\n p9EjK4QMEglvgkRRIqWMXZVv9Y/hX7z6wS1F5rq3tI1SJ43Hbb17yLrAOQIw3iuzddweT8jZdDj\n docQjm8G4iZZPbwnO/AORiE/Mxsn0l2Mm20=","X-Received":["by 2002:a05:6a00:2d81:b0:82f:6b94:99d6 with SMTP id\n d2e1a72fcca58-82f6b94e569mr4690632b3a.5.1776323503683;\n Thu, 16 Apr 2026 00:11:43 -0700 (PDT)","by 2002:a05:6a00:2d81:b0:82f:6b94:99d6 with SMTP id\n d2e1a72fcca58-82f6b94e569mr4690599b3a.5.1776323503117; Thu, 16 Apr 2026\n 00:11:43 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260416070403.1683648-1-zhaoguohan@kylinos.cn>","In-Reply-To":"<20260416070403.1683648-1-zhaoguohan@kylinos.cn>","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Thu, 16 Apr 2026 11:11:30 +0400","X-Gm-Features":"AQROBzCDbU1y7rhr7hDvN7PzWpxziO8nXWKptecsYI6haiDSTQZDcipAeXAUgqA","Message-ID":"\n ","Subject":"Re: [PATCH] ui/clipboard: clear deferred serial reset flag on resume","To":"GuoHan Zhao ","Cc":"qemu-devel@nongnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=mlureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]