[{"id":3677989,"web_url":"http://patchwork.ozlabs.org/comment/3677989/","msgid":"<20260416080257.4077-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-16T08:02:57","subject":"Re: [LTP] io_uring: Add test for READV and WRITEV operations","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Sachin,\n\nOn Thu, 16 Apr 2026, Sachin Sant wrote:\n> io_uring: Add test for READV and WRITEV operations\n\n> Additionally merge io_uring_init_buffer_pattern() into unified\n> init_iovec_buffers() function that supports both rotating and\n> simple character patterns\n\nThis mixes two logical changes in one commit. io_uring_init_buffer_pattern()\nwas unused by any existing test; its removal should be a separate preceding\ncommit, e.g. \"io_uring: remove unused io_uring_init_buffer_pattern()\".\n\n[...]\n\n> +static void setup(void)\n> +{\n> +\tio_uring_setup_supported_by_kernel();\n> +\tsigemptyset(&sig);\n> +\tmemset(&s, 0, sizeof(s));\n> +\tio_uring_setup_queue(&s, QUEUE_DEPTH, 0);\n> +\tinit_iovec_buffers(write_iovs, NUM_VECS, 'A', 1);\n> +\tclear_iovec_buffers(read_iovs, NUM_VECS);\n> +}\n\nread_iovs is modified by READV in run() but only cleared in setup(). With\n-i, the second iteration starts with stale data. Add\nclear_iovec_buffers(read_iovs, NUM_VECS) at the top of run().\n\n---\nNote:\n\nOur agent completed the review of the patch. The full review can be\nfound at: https://patchwork.ozlabs.org/project/ltp/list/?series=500082\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=iI2QhUUt;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx9Vg680Rz1yDF\n\tfor ; Thu, 16 Apr 2026 18:03:07 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 06EDA3E263D\n\tfor ; Thu, 16 Apr 2026 10:03:05 +0200 (CEST)","from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::5])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 6AA543CDBD8\n for ; Thu, 16 Apr 2026 10:03:00 +0200 (CEST)","from mail-qk1-x743.google.com (mail-qk1-x743.google.com\n [IPv6:2607:f8b0:4864:20::743])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 12055600160\n for ; Thu, 16 Apr 2026 10:03:00 +0200 (CEST)","by mail-qk1-x743.google.com with SMTP id\n af79cd13be357-8cfc5941028so1111136885a.1\n for ; Thu, 16 Apr 2026 01:03:00 -0700 (PDT)","from\n runnervm35a4x.bbtuyqy0xgnulbf4x1n5xyw1wf.ex.internal.cloudapp.net\n ([64.236.176.196]) by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8ae6cbbbb2fsm30863866d6.34.2026.04.16.01.02.58\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 16 Apr 2026 01:02:58 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776326579; x=1776931379; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=EpHru6QosnpeLX/UiUL1pzdyF1uKp0ihd/6olAW/jEU=;\n b=iI2QhUUtfE1SujepNzGXpuvsXuwJlv3ssZVxjRmPfWdeCv+aLiQo8wfPqAn0lnDvfh\n 0mP6BOBVBIDKD9VmiIy1Ss6Dz0l7TkuPZJNIKa3KFuRYIO2LvWaGd+GnOKy+6apXAPtN\n oczFHoKDPs5jgau49+aDM60FXr7KLtDe8ftj1gbaMg/1m2CT/8/4MOTHX2iYDGms4vOp\n buzYBoTX9CdSSbK7DyeB2zz4ryyR7gtVZEWI/O9UZUVTqr1zaAmu6f1JRnhQJSLw8bZo\n QH+VsXQtIHoAqDyvk57NA3MzyDPpQIY6VCFevMDEISceVzH0n1defiHNSgiQiejGJXVa\n K2iA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776326579; x=1776931379;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=EpHru6QosnpeLX/UiUL1pzdyF1uKp0ihd/6olAW/jEU=;\n b=FYMW+cl6J/HOmdQHovtBo3EEQjfaj9i4B12YFbA8vqk/LVLanA0/bwPMAasgbxfvzb\n uVMA2fHs0PSsfnLfimLBPPZQxyNenFPPRhOnqu9ArYTfqiYmqFsGD92uUuoNTPYS+pT6\n 6tMWlJAW808kOwAqFQlqGVN1ULNdK4k4JQaOB3e7+iBkYWdfV/5do9UEIpeY4BVEuVlN\n /c8n8bLQwgSSon6ZaW8T6gYiSIWijYLa4cIOprSVHf7DDkSuRPUuX9Go4ImWlPJhYqmg\n K45rc2NMDBl9gTC8AILG/FKaN/55LFkjYiRjomO56FpRqPUAnLoMTGBg9LJcVdH1etdB\n AHDQ==","X-Gm-Message-State":"AOJu0Yy7iRA2hVGz8hT6tUo0BCM+bhxhATw9AVgK+vYEom3VYQ/QXDq5\n WKN/WtbgLH8/G4B+me+aqCcGjxP86B80RdhahF3CjxSZ+EnCDe3TmMTy","X-Gm-Gg":"AeBDieuqT4WhOrA5Ao9a4cy6v0DmVfUhxJuFWHErwiE/BMoG7rTBKk8LUzncPo/hW2d\n PMrUec6omrdyFKmFKzUGbESTLYe3O7heBnn4BDKch6ba6T+bZsLoW/7MN2nAmSuKFV0Z5d0YwzO\n 3pSi07GdVfNt3gXmKwXe7uaRb2/FVb8FUYLtaS1Vo4ixChtMuB07CzqBx0RpP961iK59i73crhR\n CIdWoD1PyKU0oF/5wGwE/hw5F7phuaAqcKXmGu6X7ZlmQHeVrLyVZpnnO3im7LUdLf3t9v+kjoU\n X0KQiQZYDu0HVKW/Jex2Db3SRSVwWWs/DNFPvpxzQ9ez7IyxokuHlo7NYlBCY8FO66QQtZ4tSrG\n zX+fc0+hpLFYO7URiP+FQHwe2IyYEmmN5J4WBzYEISnsmRWUpZtKNAMNiCEjCEABdftlOvUm+XO\n +eFE9i5ZuQPYZOuNh9K5mga3yDz6VwtRzuqkzPtPSSrYOLiBZX0XDRpTtKwye7Fp8HwAUI64nfk\n pNCRpqusxv5W6ZZ/sD3gRnbywI+LMpnvzmPSveU3vQuFc6KvvQ=","X-Received":"by 2002:a05:6214:2122:b0:8ac:af6d:6934 with SMTP id\n 6a1803df08f44-8acaf6d70bemr237900536d6.13.1776326578778;\n Thu, 16 Apr 2026 01:02:58 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Sachin Sant ","Date":"Thu, 16 Apr 2026 08:02:57 +0000","Message-ID":"<20260416080257.4077-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260416062302.15804-1-sachinp@linux.ibm.com>","References":"<20260416062302.15804-1-sachinp@linux.ibm.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-5.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-5.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] io_uring: Add test for READV and WRITEV operations","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]