[{"id":3678495,"web_url":"http://patchwork.ozlabs.org/comment/3678495/","msgid":"<9a2468f0-f734-4dca-8fda-56d173da0db3@linaro.org>","list_archive_url":null,"date":"2026-04-17T06:14:35","subject":"Re: [PATCH v3 10/17] hw/usb/hcd-ehci: Implement 64-bit qTD descriptor\n addressing","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 16/4/26 03:49, Jamin Lin wrote:\n> EHCI supports 64-bit addressing when the 64-bit Addressing Capability\n> bit in HCCPARAMS is set. In that mode, the CTRLDSSEGMENT register\n> provides the upper 32 bits that are concatenated with 32-bit link\n> pointer values to form 64-bit control data structure addresses\n> (EHCI 1.0, section 2.3.5 and Appendix B).\n> \n> qTD link pointers (current_qtd/next_qtd/altnext_qtd and qTD.next)\n> are stored as 32-bit values in the data structures and must be\n> expanded to full 64-bit descriptor addresses when 64-bit mode is\n> enabled. Update the qTD traversal paths to use ehci_get_desc_addr()\n> when following link pointers.\n> \n> Appendix B also defines high dword fields for qTD buffer pointers.\n> Add bufptr_hi[5] to EHCIqtd and extend qTD fetch and QH overlay\n> handling to load and propagate the high buffer pointer fields.\n> \n> When 64-bit capability is disabled, descriptor and buffer addresses\n> remain 32-bit and existing behaviour is unchanged.\n> \n> Signed-off-by: Jamin Lin \n> ---\n> hw/usb/hcd-ehci.h | 1 +\n> hw/usb/hcd-ehci.c | 19 ++++++++++++-------\n> 2 files changed, 13 insertions(+), 7 deletions(-)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=XvduoXwH;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxl3W30Dzz1yDF\n\tfor ; Fri, 17 Apr 2026 16:15:01 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDcTS-0004Pp-8e; Fri, 17 Apr 2026 02:14:43 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wDcTQ-0004Od-1b\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 02:14:40 -0400","from mail-wm1-x334.google.com ([2a00:1450:4864:20::334])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wDcTO-0004Oz-Fp\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 02:14:39 -0400","by mail-wm1-x334.google.com with SMTP id\n 5b1f17b1804b1-488b150559bso2378575e9.1\n for ; Thu, 16 Apr 2026 23:14:37 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4cc0d51sm1990950f8f.10.2026.04.16.23.14.35\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 16 Apr 2026 23:14:36 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776406477; x=1777011277; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=ewTG4PtM2cdjHGXZfHm//ggROs3DZ3LP1qNXA0Mzgb4=;\n b=XvduoXwHiKTmS1mgF+hdIvSqMamLSn6NyGh2rlfjwY5kETni4ZXUmDJZwK9rhVLq1a\n 3NcyiQpgzQCKrKj7kK09rWpZ/Pg3rl2Zu6P4ecvDtWmIge0zm7lCCwAT6lawRrQbUwO5\n F2GVH65CU42VUw30YrlPlm8BMUTLTxkrkEEdNVRLRzcZQWY/v3Q58oH9vpPsNfTq5XLa\n A4+/MCDDYC5XOLJmMpk7jyk/AgJ/AQ68sSOz/h79Dcq3j39KbFI6sgDNRvHR1RmHWDyU\n T4a67l/O+p6gB7Q2RzcYAoDJ1aeRMRNfSYlX96coWvv9Lzg5CZiIYy/kK82hOsnrXiMt\n Bjlw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776406477; x=1777011277;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=ewTG4PtM2cdjHGXZfHm//ggROs3DZ3LP1qNXA0Mzgb4=;\n b=MlTT5isDpLlojSXEjuzP2qV+tO+irWJwXiRDxX/xCJvDRqUcGpSOvDS9TTT32Y7ZoU\n YNoCpPitbGR0DmqwXyez/Q4vbwmtTWcX5aFbCmXU9Ch387Lzi4ai37cMJFx2BRT3Fq7o\n FPR7G4LFCWO7PYW81iRiZqDfgt1JttFrAjJEU8SBAQauFipt6E8y7/Ux4PGRf7VKaVIc\n j5uEWEqjhiHERlZX+YSIrXQKPehNwX4Fnlc+XXTUOcDpPownu+ZfOM3LVBiqWY9mrQzS\n i+11XLXWut3B80+tbSSYGwe3FoRg1lT9vGGtN4b34Yg1/rpArChG4WlXtY08f9ai8AQo\n eusg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/ahCdvlfdKDn5N/k8EiBROXJbURTSgwRzvnppSRCTe85qLBGi43U+XlqRPMo+jA9Qz9268GvNz/gk/@nongnu.org","X-Gm-Message-State":"AOJu0YxR78gZj6sirMASN8C+0Dkbiu6Y+LNKA4uW5VdCH+G96L1MfSQY\n A2MK5Q/63AI5+RfKeGEkK+5ZZcRvkHMVmdW8BWaLRUOEchTvdrM6I++iQw91sbwgyPk=","X-Gm-Gg":"AeBDiet7eGKc/7BdsbElPY7HhFsgbqBfa8V/P/+SQPKk0FegPksooYn6nFafucM29O0\n f72FOuE+3rA7d4qXxjlZmbxUPnG7w1hdoxKHB7u98DlL1oTNTt7JzHrq9/VYAzI/oK7NS0IepKn\n AQdFN6JE2b2VxLXEsBzf/qjwpLhHNQ/F9u2kBcg5mq79PLhiW7R+vT4CQNMRS+05Heajra8D8OP\n DitS0tF0IMwh4I4OuQs9eqzoMxy7nv8W7GdHoiJzYUqKg+AAOpW74DopS7XNnsKuvxK1x+YgnKv\n YlXIUDgp05eQD0BE9tiYzWr1uWElbc2QgPHfWiPtEXagVyEuQ4+BSU0Jg9oJiifvdJBubNanW5f\n 8UNopF9PGy9jNNyMJ5f4ZXhIf4j1emITF6IWsSEHQu2jNn6KDuzv0HRc/AUHKSQnRrs/S0g0WBc\n IcGCcRwe31DFJBPZJdbcUgsr1HVxWPCspZb6XuR1pymBk8v3wWqdiXFKbcQzr/TOlN/CRqm2B2R\n X5xvBnVJXDH4Js=","X-Received":"by 2002:adf:f8ca:0:b0:43f:e41d:85f2 with SMTP id\n ffacd0b85a97d-43fe41d8657mr1277830f8f.2.1776406476730;\n Thu, 16 Apr 2026 23:14:36 -0700 (PDT)","Message-ID":"<9a2468f0-f734-4dca-8fda-56d173da0db3@linaro.org>","Date":"Fri, 17 Apr 2026 08:14:35 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 10/17] hw/usb/hcd-ehci: Implement 64-bit qTD descriptor\n addressing","Content-Language":"en-US","To":"Jamin Lin ,\n =?utf-8?q?C=C3=A9dric_Le_Goater?= ,\n Peter Maydell ,\n Steven Lee , Troy Lee ,\n Kane Chen ,\n Andrew Jeffery , Joel Stanley ,\n \"open list:ASPEED BMCs\" ,\n \"open list:All patches CC here\" ","Cc":"Troy Lee , \"flwu@google.com\" ,\n \"nabihestefan@google.com\" ","References":"<20260416014928.1279360-1-jamin_lin@aspeedtech.com>\n <20260416014928.1279360-11-jamin_lin@aspeedtech.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260416014928.1279360-11-jamin_lin@aspeedtech.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::334;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]