[{"id":3678497,"web_url":"http://patchwork.ozlabs.org/comment/3678497/","msgid":"","list_archive_url":null,"date":"2026-04-17T06:15:10","subject":"Re: [PATCH v3 11/17] hw/usb/hcd-ehci: Implement 64-bit iTD descriptor\n addressing","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 16/4/26 03:49, Jamin Lin wrote:\n> EHCI supports 64-bit control data structure addressing when the\n> 64-bit Addressing Capability bit in HCCPARAMS is set. In that mode,\n> the CTRLDSSEGMENT register provides the upper 32 bits that are\n> concatenated with 32-bit link pointer values to form full 64-bit\n> descriptor addresses (EHCI 1.0, section 2.3.5 and Appendix B).\n> \n> iTD link pointers are stored as 32-bit values and must be expanded\n> to full 64-bit descriptor addresses when 64-bit mode is enabled.\n> Update the iTD traversal path to use ehci_get_desc_addr() when\n> following link pointers.\n> \n> Appendix B also defines high dword fields for iTD buffer pointers.\n> Add bufptr_hi[7] to EHCIitd and use ehci_get_buf_addr() to construct\n> full 64-bit buffer addresses from bufptr[] and bufptr_hi[] fields\n> when processing isochronous transfers. This allows buffers above\n> 4GB to be handled correctly.\n> \n> When 64-bit capability is disabled, descriptor and buffer addresses\n> remain 32-bit and existing behaviour is unchanged.\n> \n> Signed-off-by: Jamin Lin \n> ---\n> hw/usb/hcd-ehci.h | 1 +\n> hw/usb/hcd-ehci.c | 9 ++++++---\n> 2 files changed, 7 insertions(+), 3 deletions(-)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=MBJnYiSd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxl44543xz1yD3\n\tfor ; Fri, 17 Apr 2026 16:15:32 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDcU1-0005ED-O0; Fri, 17 Apr 2026 02:15:17 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wDcU0-0005DB-GZ\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 02:15:16 -0400","from mail-wm1-x331.google.com ([2a00:1450:4864:20::331])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wDcTy-0004co-Lh\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 02:15:16 -0400","by mail-wm1-x331.google.com with SMTP id\n 5b1f17b1804b1-488e1a8ac40so3751215e9.2\n for ; Thu, 16 Apr 2026 23:15:13 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fb6e16b3sm12758585e9.0.2026.04.16.23.15.11\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 16 Apr 2026 23:15:11 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776406512; x=1777011312; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=GukCC62Ain8Ts8PFPTvU58zWf7+hRlJKZxr9+ckB/+4=;\n b=MBJnYiSd1cz33Ar0hO+jZ0VhwLqvTB8mKnOCANXKEX7ZUjEfCzB4M6vSWwuqqs9zxb\n RL59+XuITwQZ3LVyz7B/cgUFhB6nEgGicdZXM8arY5EzGq8pbvt2QYjlEfMHwpYpL+g2\n MnP1e8w1YM7Pj+NiIp9S2a5oTnBKq+Yr77cqc14kz7FRHTa5oqLabTonaCfTmaRCUBrT\n y/BwY6wfUNY6IAAx9egqmxpJSC66S2yPBPTVRIXHUkUR01csu2hM8ObwfuBGfg7rrUji\n vLvwAWq8OAi55lSVILQOYHdiRRsQ9JcrbWIT0cQIzZzmL4HpsJj8ta7tOUH5i8BPuU1K\n Cx/g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776406512; x=1777011312;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=GukCC62Ain8Ts8PFPTvU58zWf7+hRlJKZxr9+ckB/+4=;\n b=kKfL8ByqesaiizdIFcZuGrEGj3rRUg3HFvxqmQPBnRXAb+m7t3RD6tJvN92/km4Cf3\n swhwL5tFMD2jZCh+SzmPxmwQ4dOv2iXFJ6q4IltjjboL25/1m8M8qS9ogFZ0sdYu6kkG\n EmAd3u9vmNYiQDPO5qJc9lccclZAYKT8elf7FLFrUIQ33LLajtkjESalNUrz9uiEA6yE\n IM5Q+9PVIo4j2Rt1zhdxJUkwTh3mCaMUw8p7fidGCNDswgYKRaxb+8GQixabiSaJELbO\n 1qz8NXzhFwSklF6CB3pvQndBh2UyfyNm/ONLXCj4FHlbIxWYqY6ySmnbqOfAZVBwm92u\n PAzg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8P9keQ4wNV4t8R6ky5HrEbrFtnCfKhITqGNanypZpDp1E0rp0XzjLLjLaUwNJQ+KTXCKtwtKfSzadO@nongnu.org","X-Gm-Message-State":"AOJu0YykilxkQBZOVEYEJ0DgNnsv+IYbHg6wiHRxR3ByKl2J6mf1VRPW\n ROgsZzSiMLotdfm5HuWMIIFnIAKx522IuTKctPSsqnIcF2XnxorIJdjuq6zqfI6UVG8=","X-Gm-Gg":"AeBDiev8xGjA9QSP6wPNnOQ612IHrgA0T9kSiZ/bJXIe/oGLY/sO40mUP2UDc9PtR2E\n 9tzsKbLiyCcHEU1eUyn0z4wo8UWBc4WiU4avCJCGhWILc4qcBH24TNn+SNr3r38zYYXHDF8aUI+\n OvFnWJoQ9dp9j7Rap2S3stn29YssjnhDAdUhZxrvXoy4RjC5twa1mBKA3MIkpWbcHfob3PmJcu7\n LRgbSsNN3yhPDdIvSWu1Ib3j7nCScFr2nr7i39LQWuawN/nOY3CT9i2y8yAv9PrUfBgCIAwypT3\n RavkIb5ewa8CLEer7H3//1xmuaN2XWy1QK1VGunLz2OHzH3KUNompJHNyX6yXgOCb6z43zk6H2q\n EOaTOJXvzwlf8blSSFHvYgw7JNKy430vgKGLuN+ckx7wdjrrPd24JCNmNUH4/HnLNe2vf7Sk1Vg\n l55eREbddUVyj+dfsN1VI+5wn71T4VIM+K96gS1gRx7ZTy6sCiA/czR3F0YrQ9vruX0fcaYmgRS\n 4nOiuedd/0mmOM=","X-Received":"by 2002:a05:600c:c09c:b0:485:3423:727d with SMTP id\n 5b1f17b1804b1-488fb78c1efmr13889525e9.26.1776406512400;\n Thu, 16 Apr 2026 23:15:12 -0700 (PDT)","Message-ID":"","Date":"Fri, 17 Apr 2026 08:15:10 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 11/17] hw/usb/hcd-ehci: Implement 64-bit iTD descriptor\n addressing","Content-Language":"en-US","To":"Jamin Lin ,\n =?utf-8?q?C=C3=A9dric_Le_Goater?= ,\n Peter Maydell ,\n Steven Lee , Troy Lee ,\n Kane Chen ,\n Andrew Jeffery , Joel Stanley ,\n \"open list:ASPEED BMCs\" ,\n \"open list:All patches CC here\" ","Cc":"Troy Lee , \"flwu@google.com\" ,\n \"nabihestefan@google.com\" ","References":"<20260416014928.1279360-1-jamin_lin@aspeedtech.com>\n <20260416014928.1279360-12-jamin_lin@aspeedtech.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260416014928.1279360-12-jamin_lin@aspeedtech.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::331;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]