[{"id":3678123,"web_url":"http://patchwork.ozlabs.org/comment/3678123/","msgid":"","list_archive_url":null,"date":"2026-04-16T12:09:16","subject":"Re: [PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n structure\n and dead code","submitter":{"id":16148,"url":"http://patchwork.ozlabs.org/api/people/16148/","name":"BALATON Zoltan","email":"balaton@eik.bme.hu"},"content":"On Thu, 16 Apr 2026, Jamin Lin wrote:\n> The EHCIfstn structure, defined according to EHCI spec section 3.7,\n> is currently unused in the EHCI implementation. Remove it to reduce\n> unused code and improve maintainability.\n>\n> Additionally, drop a block of disabled (#if 0) code in\n> ehci_state_advqueue() that was never implemented. This code path\n> is incomplete and has no functional impact.\n>\n> No functional change.\n>\n> Signed-off-by: Jamin Lin \n> ---\n> hw/usb/hcd-ehci.h | 7 -------\n> hw/usb/hcd-ehci.c | 11 -----------\n> 2 files changed, 18 deletions(-)\n>\n> diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h\n> index 0ae8c06331..3aec0e047c 100644\n> --- a/hw/usb/hcd-ehci.h\n> +++ b/hw/usb/hcd-ehci.h\n> @@ -202,13 +202,6 @@ typedef struct EHCIqh {\n> #define BUFPTR_SBYTES_SH 5\n> } EHCIqh;\n> \n> -/* EHCI spec version 1.0 Section 3.7\n> - */\n> -typedef struct EHCIfstn {\n> - uint32_t next; /* Standard next link pointer */\n> - uint32_t backptr; /* Standard next link pointer */\n> -} EHCIfstn;\n> -\n> enum async_state {\n> EHCI_ASYNC_NONE = 0,\n> EHCI_ASYNC_INITIALIZED,\n> diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c\n> index 57f930b099..5ea8461f70 100644\n> --- a/hw/usb/hcd-ehci.c\n> +++ b/hw/usb/hcd-ehci.c\n> @@ -1756,17 +1756,6 @@ static int ehci_state_fetchsitd(EHCIState *ehci, int async)\n> /* Section 4.10.2 - paragraph 3 */\n> static int ehci_state_advqueue(EHCIQueue *q)\n> {\n> -#if 0\n> - /* TO-DO: 4.10.2 - paragraph 2\n> - * if I-bit is set to 1 and QH is not active\n> - * go to horizontal QH\n> - */\n\nIs it worth to keep the comment in case it's still valid to remind we have \nsomething missing here?\n\nRegards,\nBALATON Zoltan\n\n> - if (I-bit set) {\n> - ehci_set_state(ehci, async, EST_HORIZONTALQH);\n> - goto out;\n> - }\n> -#endif\n> -\n> /*\n> * want data and alt-next qTD is valid\n> */\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxGzr2pY5z1yCv\n\tfor ; Thu, 16 Apr 2026 22:10:16 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDLXe-0007hr-II; Thu, 16 Apr 2026 08:09:59 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDLXV-0007gk-HB; Thu, 16 Apr 2026 08:09:46 -0400","from zero.eik.bme.hu ([2001:738:2001:2001::2001])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDLX9-0001u9-P8; Thu, 16 Apr 2026 08:09:45 -0400","from localhost (localhost [127.0.0.1])\n by zero.eik.bme.hu (Postfix) with ESMTP id D85FE596EA1;\n Thu, 16 Apr 2026 14:09:18 +0200 (CEST)","from zero.eik.bme.hu ([127.0.0.1])\n by localhost (zero.eik.bme.hu [127.0.0.1]) (amavis, port 10028) with ESMTP\n id 7xbrzfO7odFa; Thu, 16 Apr 2026 14:09:16 +0200 (CEST)","by zero.eik.bme.hu (Postfix, from userid 432)\n id 3BB245969F6; Thu, 16 Apr 2026 14:09:16 +0200 (CEST)","from localhost (localhost [127.0.0.1])\n by zero.eik.bme.hu (Postfix) with ESMTP id 398205969EC;\n Thu, 16 Apr 2026 14:09:16 +0200 (CEST)"],"X-Virus-Scanned":"amavis at eik.bme.hu","Date":"Thu, 16 Apr 2026 14:09:16 +0200 (CEST)","From":"BALATON Zoltan ","To":"Jamin Lin ","cc":"\"philmd@linaro.org\" , =?iso-8859-15?q?C=E9dric_Le_Goa?=\n\t=?iso-8859-15?q?ter?= ,\n Peter Maydell ,\n Steven Lee , Troy Lee ,\n Kane Chen ,\n Andrew Jeffery ,\n Joel Stanley ,\n \"open list:ASPEED BMCs\" ,\n \"open list:All patches CC here\" ,\n Troy Lee , \"flwu@google.com\" ,\n \"nabihestefan@google.com\" ","Subject":"Re: [PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n structure\n and dead code","In-Reply-To":"<20260416014928.1279360-2-jamin_lin@aspeedtech.com>","Message-ID":"","References":"<20260416014928.1279360-1-jamin_lin@aspeedtech.com>\n <20260416014928.1279360-2-jamin_lin@aspeedtech.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII; format=flowed","Received-SPF":"pass client-ip=2001:738:2001:2001::2001;\n envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu","X-Spam_score_int":"-18","X-Spam_score":"-1.9","X-Spam_bar":"-","X-Spam_report":"(-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3678446,"web_url":"http://patchwork.ozlabs.org/comment/3678446/","msgid":"","list_archive_url":null,"date":"2026-04-17T01:16:05","subject":"RE: [PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n structure and dead code","submitter":{"id":81768,"url":"http://patchwork.ozlabs.org/api/people/81768/","name":"Jamin Lin","email":"jamin_lin@aspeedtech.com"},"content":"Hi all, \n\n> Subject: Re: [PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n> structure and dead code\n> \n> On Thu, 16 Apr 2026, Jamin Lin wrote:\n> > The EHCIfstn structure, defined according to EHCI spec section 3.7, is\n> > currently unused in the EHCI implementation. Remove it to reduce\n> > unused code and improve maintainability.\n> >\n> > Additionally, drop a block of disabled (#if 0) code in\n> > ehci_state_advqueue() that was never implemented. This code path is\n> > incomplete and has no functional impact.\n> >\n> > No functional change.\n> >\n> > Signed-off-by: Jamin Lin \n> > ---\n> > hw/usb/hcd-ehci.h | 7 -------\n> > hw/usb/hcd-ehci.c | 11 -----------\n> > 2 files changed, 18 deletions(-)\n> >\n> > diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h index\n> > 0ae8c06331..3aec0e047c 100644\n> > --- a/hw/usb/hcd-ehci.h\n> > +++ b/hw/usb/hcd-ehci.h\n> > @@ -202,13 +202,6 @@ typedef struct EHCIqh {\n> > #define BUFPTR_SBYTES_SH 5\n> > } EHCIqh;\n> >\n> > -/* EHCI spec version 1.0 Section 3.7\n> > - */\n> > -typedef struct EHCIfstn {\n> > - uint32_t next; /* Standard next link pointer */\n> > - uint32_t backptr; /* Standard next link pointer */\n> > -} EHCIfstn;\n> > -\n> > enum async_state {\n> > EHCI_ASYNC_NONE = 0,\n> > EHCI_ASYNC_INITIALIZED,\n> > diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index\n> > 57f930b099..5ea8461f70 100644\n> > --- a/hw/usb/hcd-ehci.c\n> > +++ b/hw/usb/hcd-ehci.c\n> > @@ -1756,17 +1756,6 @@ static int ehci_state_fetchsitd(EHCIState\n> > *ehci, int async)\n> > /* Section 4.10.2 - paragraph 3 */\n> > static int ehci_state_advqueue(EHCIQueue *q) { -#if 0\n> > - /* TO-DO: 4.10.2 - paragraph 2\n> > - * if I-bit is set to 1 and QH is not active\n> > - * go to horizontal QH\n> > - */\n> \n> Is it worth to keep the comment in case it's still valid to remind we have\n> something missing here?\n> \n> Regards,\n> BALATON Zoltan\n> \n\nIf we decide to keep these comments as reminders for unimplemented parts,\nplease let me know. I will resend the patch series and drop this patch.\n\nThanks,\nJamin\n\n> > - if (I-bit set) {\n> > - ehci_set_state(ehci, async, EST_HORIZONTALQH);\n> > - goto out;\n> > - }\n> > -#endif\n> > -\n> > /*\n> > * want data and alt-next qTD is valid\n> > */\n> > --\n> > 2.43.0\n> >","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=HFMNNxCy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxcRx4S0Cz1yD3\n\tfor ; Fri, 17 Apr 2026 11:17:16 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDXog-0005cn-Pq; Thu, 16 Apr 2026 21:16:18 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDXoe-0005cC-S2; Thu, 16 Apr 2026 21:16:16 -0400","from mail-japaneastazlp170120005.outbound.protection.outlook.com\n ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDXob-00053T-N2; Thu, 16 Apr 2026 21:16:16 -0400","from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19)\n by TYUPR06MB5927.apcprd06.prod.outlook.com (2603:1096:400:350::12)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.25; Fri, 17 Apr\n 2026 01:16:05 +0000","from TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9818.023; Fri, 17 Apr 2026\n 01:16:05 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=Ou94RaDpTzh7R+br4GeCYJuq6ghCJWacGdkHZd1Qw08a00BNGlKsENHNzsqL5SYPMM28iGNzbT2QFUSoYiNEd6XNWbJL+16Rsk21KJr34dmFukTdQ7QuaagQmKBBKylRGuiXvV5EHi44TwmJPE2wAfIFnvOm9gmE7DouxW9tYutO2x0sIxP9+pmVnZq0AE+iESazC8LQhEdu4Ev9HaWkkOmK02j3MKN5YQYZR9qzd4IpfP1whUWybSBkghqfLU8JoVwPbeAgu8aGaLhiRSQXCmwEdG6v5tPpnurxXYKAQtMYLb5NWU5S6Hu1s8WlDwng8FJFFELqF+e66dm4xEWNFA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=uKvmDcLafk3RPtCFjX+esrM/9ByXS03vIblNKwniRu8=;\n b=WfHCuOlGIAN9zvoin7eTN0WdMFmPG75cYXbdaukY57ucxgSdJcaaIfuPPYkyx/9fYUDk2TxR0M2MvRUCxcD0ylotOEqnjbu5EmsJOXCdMuDc+E1EuBGOTGL6kardkpwZMQ/rx4XlaB3NtULk5+Qlmr/rHxONrK5t9P70HCGSP/sZO/uEC0UN7G9WZbJplXkC8I8iQLU+0OHyx0ClX5spGmcJM/JEInGGwATImrnPzJvsqFnuCsCnSkuXygZXZ+1Z5NoJtF6k0iY6QZO1mFZ2e2+OtH8cnWj8eR4j2ucf6II+eLkPLz+BXE/eEnqbrOzNlaezRnTfgJwvChrLUTlhnQ==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=aspeedtech.com; dmarc=pass action=none\n header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=uKvmDcLafk3RPtCFjX+esrM/9ByXS03vIblNKwniRu8=;\n b=HFMNNxCywKFggi67keZwQ5VfOGyyIu7AgjgDBOj9QD2OrpvcVjDvLHF7JTK5tsboEEr0EK/PK44G9N3I+HJeMLHams0LGemuu1wqmIDfGL84DiYd42ZjHGT0K51M6HZprrOr5lrjD3g8rMxWfzbMJqy2mdziR8bmj333TQhVwxBcUEzOvemQHqr+utWJ20zVYw1gBKS5x1Upy8+32n546Iim0+LCrGdOI2fkhmNaVabDTaZw8yrfYvhPgrLTE6e/PLAi9ywP6ZXsRVz7lfLa+LNJV/dHL644a5af38LJ8jk+g0mrc7Bu3wDSyGFUuxoUYsBcYVEQTgg7loQNKUGVfg==","From":"Jamin Lin ","To":"BALATON Zoltan ","CC":"\"philmd@linaro.org\" , =?iso-8859-1?q?C=E9dric_Le_Goat?=\n\t=?iso-8859-1?q?er?= , Peter Maydell ,\n Steven Lee , Troy Lee ,\n Kane Chen ,\n Andrew Jeffery , Joel Stanley ,\n \"open list:ASPEED BMCs\" ,\n \"open list:All patches CC here\" ,\n Troy Lee , \"flwu@google.com\" ,\n \"nabihestefan@google.com\" ","Subject":"RE: [PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n structure and dead code","Thread-Topic":"[PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n structure and dead code","Thread-Index":"AQHczUNFhK5MCMsaPESXZcYoH3r+fLXhmSoAgADa5RA=","Date":"Fri, 17 Apr 2026 01:16:05 +0000","Message-ID":"\n ","References":"<20260416014928.1279360-1-jamin_lin@aspeedtech.com>\n <20260416014928.1279360-2-jamin_lin@aspeedtech.com>\n ","In-Reply-To":"","Accept-Language":"zh-TW, en-US","Content-Language":"zh-TW","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=HFMNNxCy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;"],"x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"TYPPR06MB8206:EE_|TYUPR06MB5927:EE_","x-ms-office365-filtering-correlation-id":"2edae423-abd4-4bb2-8e8a-08de9c1ee5db","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|7416014|366016|376014|1800799024|18002099003|22082099003|56012099003|38070700021;","x-microsoft-antispam-message-info":"\n qh2B4G5FOskhDS/cQ5QBZkzPM06GktQ1jAhpsaKFdhro9b9w9ZP2kNLod8ALb6P17HMIcfHcYotEtd0Zmn3O73Yu/3xlkQbSmUeOndhkXVPoIKklOSlHTXcasINJv2YAQUoP1bzDIwYIBX6HFMUvl8G7dVQUiCT9kDYImbHZ3HXxt0lohWJZtlNALWSlzKmUqQjsf6ix+LDAOJ8jGuF6GL5oN9eVaGcA0BgCH6GwoeWQX0RxVzxQW6GFv6sWTa90EITY/etCEvEv8zLa6ZEG7bbEibGcpqBGoH2NF4OWbbD3cDSm6bVZu5MftK9Ei1cqc8L9SZx0DNcC5/54D/Cmy31jeYbqmxDgTZMnJucdiTMaNrXY7xyqyqCLhjXfnM6lPnasFTFj/0ua8FaIiTbgj70jPzJRtkxblrvSmYiPtLtXUnltJNcjQuFmhYWZE9zXoLouyxZo2pjE+O3HNEg6N2ovG6fZvwn/HIaOUHthuG2M5hkU+wc/pNaHehxf6srN2bVyXY+XOnTG03f18/WkWqTFMo7IkzBG4YrkTTMMxZ44bUHUeFFO8K+sL34IlvUMq/wuMYs1sv3EX3zcQwNktqH2c/nTEN7YLXxWI+bIFWtV4ZRbtaxfd2x3e/6Bs9U9LKKstX2csk7YX1+LeFESIG0F2kqa0z0V45rfq57QHyJYuTYL0RE2aplPvFjQzMzfx10gRYhH0spsxuCIe1MwJsMal5mxBbzYlnoYOICGoIxs6JU2hCqx/3fEf/czcICPSvm5YOpQnrxZzelDhk6L+Fu9zEMmTaJeKXe9vKxgjGM=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:zh-tw; SCL:1;\n SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:;\n CAT:NONE;\n SFS:(13230040)(7416014)(366016)(376014)(1800799024)(18002099003)(22082099003)(56012099003)(38070700021);\n DIR:OUT; SFP:1102;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"=?iso-8859-1?q?HFMXT3M3YTE1ui99TGpfeno?=\n\t=?iso-8859-1?q?174zf5hu8wW2ZZ9EnhJ7uww0mLGYVtDOMWzEizKn/4o+6QIy660lw1asNL+v?=\n\t=?iso-8859-1?q?KVnLlnFxLonoTk2bsUL2zE5AJP0LtWKuDQ42t2H2vGHHQltlRO1yflw2aVVb?=\n\t=?iso-8859-1?q?Z9VDCjqrNK3Ud3k3DafxtyTtC9rexdISIq4DkT13XWDsVBiBupluUDGDEUcx?=\n\t=?iso-8859-1?q?TJxe5pN4PqeBajFdP9smZ/dvGyvDz7o1n9KJdG/4njJBYntK6NdKpJDCLifQ?=\n\t=?iso-8859-1?q?9+I0AjWbpqDqjqT2EmLZETcX/KetTBFzu73GLPUB+2raBjFX/ALQigSgMihC?=\n\t=?iso-8859-1?q?JP2e6GG6GL6aIoP7phoOylFTh6kG4cOIJv3nrtidPztLcxLVvTHT8mELbEdL?=\n\t=?iso-8859-1?q?ZcvNNQ7aPgq0VTy9LGAyLFZY2S2tNwskdX2mXRvtFzWzVArkSgV+WMMiNSfg?=\n\t=?iso-8859-1?q?tDMRym7aBvp60ofXhCywWLcmo1X9voERfC0DC1iouZ2b6T/VdPLZl70Oa+AJ?=\n\t=?iso-8859-1?q?ebLTekUrPFhRKEHhgt+LDQHqdT3j7FvBkgQTKfCBAA8NwR/UHE34p8UKGVU0?=\n\t=?iso-8859-1?q?cGmUgmMqRkaPx/3up2dGe0DgiRcrpL0EhDzaYAPK8vRhYLIXk8Mv4ev6flEu?=\n\t=?iso-8859-1?q?prvMmOmttm/NHSgx3p8ae0tMDEBX5eXEoidrSKrxKDK/VzyogF59y8ivYJkr?=\n\t=?iso-8859-1?q?R/8DlrwwEkZUj4i9UTaYFi3bq8Cy1I+f/N/J7Wqg2qR8mBAk1PlnrHFlURbw?=\n\t=?iso-8859-1?q?FDYg1KpplmIWLrPYKfslf1uKff909H1tb22lokeg6lWdd7ONkkpk+N+9Gyko?=\n\t=?iso-8859-1?q?okBJRd78szHawQwlJ5p3/nBGTPLEIRcDsTh5MCLIS8/gArH9YaImOqzQc+P1?=\n\t=?iso-8859-1?q?GupNekeARmcrcUl9TIpDSJJXfTIDvN1aVXBcc0OWmyemLT9b8chjtOEQnV9c?=\n\t=?iso-8859-1?q?1qdPX565cQkijwlY30LS03obVxASq/Z+gi4F3IwRWCp6Eq0G9YyUTcaGVMdz?=\n\t=?iso-8859-1?q?QCa4HlM0NVFxpFgqDroINsDe7UYkrpUD0sr+mJ+ljFJ+8MauOkNmUudukuxG?=\n\t=?iso-8859-1?q?oFJ7BuakswQa2lopNG+q5cjhDgw3oyh2H4fuyLwGAuCPuIHdjndx559NPJsZ?=\n\t=?iso-8859-1?q?4AXJYILSjz/mOzrMfH/Sd51A/IvCi+IlzfM1pimSk6+19eXFGtnW9BHz1n2D?=\n\t=?iso-8859-1?q?PGncIqmf27Eqn3IKMBWuYMRv21Zex/LvwpTAIBQGEipXvU0mMp4hrTtdFrEV?=\n\t=?iso-8859-1?q?tV3oa6I5ipRbFPKdk08aLObpBpj/Qt5tJ9oKtu4P0F3a46hhBo5yOB9caSJa?=\n\t=?iso-8859-1?q?DTlBNKBCAmN0I/9ytoCkmHpb7JtLlcx0j2DDH6DOXkSvNAOTQ1d44AbsdixB?=\n\t=?iso-8859-1?q?j9zeB/xPxe5hj/k5nfuhM+qfosJm2MuE9DXM9a3pJiPfTE2GBahlyyPdfMQ4?=\n\t=?iso-8859-1?q?mel/yIiLlnI3UNN7849c+e1UQ2RXO2o+9W6mFjYMKjF3eNrfLOY90sZ2KvJX?=\n\t=?iso-8859-1?q?dQ/vzj6+fQNERdlEIrDLKjoPIcnxQyPDEaZhtmi46MgjHV3P5nsIefZRZMzH?=\n\t=?iso-8859-1?q?unvXVVqC4H+UAEPkDhoX+9thcvMPna4dSBB070lw+MgcGFhMXnR2G+UEGWvm?=\n\t=?iso-8859-1?q?+QvGWo01F138MNrb29hLuQLyEa2jL+4w3+vE7yeNoE1YzplgeO948SIUcdVz?=\n\t=?iso-8859-1?q?n6lgZ9KCek1anjf/3UrtKsvtrK3VZ+OyrTekVISdaPCP5xEb8UfjP7RgxrFg?=\n\t=?iso-8859-1?q?0TfJ5N6hUIdb8EymEundWHITCjKkpPfvIph3hebgSK7PERA=3D=3D?=","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-Exchange-RoutingPolicyChecked":"\n ITxCW/8rjMuScqufhpuT4YwNQGcfCdEfW4KDIrHWvRuso2jSlfyrcRDIIYyQbXF9zXX3D126WBfaVrbmwwj9/D4c4RVC6FdWjCP8RtoGvL7tOejNjYZFaH5aUIZGHLSx6yBhmRxxl0hYNwDPLOf2kSa/haStmoIa52HTEA5+IQlFo/49HK3dDBq4B74UO7EeracLuCz55Q6UFidxMBQphie0lQFhhJb2IKLtqeDZahGXw2udDkkBUWr+k0KYGMvB1rEjKtdvQ/fth+G8T/22fab0mHdyascdJyLJWTVKEKi6+jERXV0wm9xCzgZNT8/eSEP+itL/mTYl/Qk5hmnbnw==","X-OriginatorOrg":"aspeedtech.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"TYPPR06MB8206.apcprd06.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 2edae423-abd4-4bb2-8e8a-08de9c1ee5db","X-MS-Exchange-CrossTenant-originalarrivaltime":"17 Apr 2026 01:16:05.2039 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"43d4aa98-e35b-4575-8939-080e90d5a249","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n /GnpYTeindyDANcPhxcwhhI9U2QD3Z9Xc+iXCNloJA1nWuyRnPkfiV7PuIx5jn4S5EVo/ylbO0V3xckuwenVRSq0QBrln0gSHD3nrMVBlyI=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"TYUPR06MB5927","Received-SPF":"pass client-ip=2a01:111:f403:c405::5;\n envelope-from=jamin_lin@aspeedtech.com;\n helo=TYPPR03CU001.outbound.protection.outlook.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3678455,"web_url":"http://patchwork.ozlabs.org/comment/3678455/","msgid":"","list_archive_url":null,"date":"2026-04-17T02:25:15","subject":"RE: [PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n structure and dead code","submitter":{"id":81768,"url":"http://patchwork.ozlabs.org/api/people/81768/","name":"Jamin Lin","email":"jamin_lin@aspeedtech.com"},"content":"Hi all, \n\n> Subject: RE: [PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n> structure and dead code\n> \n> Hi all,\n> \n> > Subject: Re: [PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n> > structure and dead code\n> >\n> > On Thu, 16 Apr 2026, Jamin Lin wrote:\n> > > The EHCIfstn structure, defined according to EHCI spec section 3.7,\n> > > is currently unused in the EHCI implementation. Remove it to reduce\n> > > unused code and improve maintainability.\n> > >\n> > > Additionally, drop a block of disabled (#if 0) code in\n> > > ehci_state_advqueue() that was never implemented. This code path is\n> > > incomplete and has no functional impact.\n> > >\n> > > No functional change.\n> > >\n> > > Signed-off-by: Jamin Lin \n> > > ---\n> > > hw/usb/hcd-ehci.h | 7 -------\n> > > hw/usb/hcd-ehci.c | 11 -----------\n> > > 2 files changed, 18 deletions(-)\n> > >\n> > > diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h index\n> > > 0ae8c06331..3aec0e047c 100644\n> > > --- a/hw/usb/hcd-ehci.h\n> > > +++ b/hw/usb/hcd-ehci.h\n> > > @@ -202,13 +202,6 @@ typedef struct EHCIqh {\n> > > #define BUFPTR_SBYTES_SH 5\n> > > } EHCIqh;\n> > >\n> > > -/* EHCI spec version 1.0 Section 3.7\n> > > - */\n> > > -typedef struct EHCIfstn {\n> > > - uint32_t next; /* Standard next link pointer\n> */\n> > > - uint32_t backptr; /* Standard next link pointer */\n> > > -} EHCIfstn;\n> > > -\n> > > enum async_state {\n> > > EHCI_ASYNC_NONE = 0,\n> > > EHCI_ASYNC_INITIALIZED,\n> > > diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index\n> > > 57f930b099..5ea8461f70 100644\n> > > --- a/hw/usb/hcd-ehci.c\n> > > +++ b/hw/usb/hcd-ehci.c\n> > > @@ -1756,17 +1756,6 @@ static int ehci_state_fetchsitd(EHCIState\n> > > *ehci, int async)\n> > > /* Section 4.10.2 - paragraph 3 */\n> > > static int ehci_state_advqueue(EHCIQueue *q) { -#if 0\n> > > - /* TO-DO: 4.10.2 - paragraph 2\n> > > - * if I-bit is set to 1 and QH is not active\n> > > - * go to horizontal QH\n> > > - */\n> >\n> > Is it worth to keep the comment in case it's still valid to remind we\n> > have something missing here?\n> >\n> > Regards,\n> > BALATON Zoltan\n> >\n> \n> If we decide to keep these comments as reminders for unimplemented parts,\n> please let me know. I will resend the patch series and drop this patch.\n> \n> Thanks,\n> Jamin\n> \n\nAnother approach:\nWe can remove the #if 0 dead code and keep only the comments as a reminder that this part is not yet implemented.\n\nEx:\n--- a/hw/usb/hcd-ehci.c\n+++ b/hw/usb/hcd-ehci.c\n@@ -1756,16 +1756,10 @@ static int ehci_state_fetchsitd(EHCIState *ehci, int async)\n /* Section 4.10.2 - paragraph 3 */\n static int ehci_state_advqueue(EHCIQueue *q)\n {\n-#if 0\n /* TO-DO: 4.10.2 - paragraph 2\n * if I-bit is set to 1 and QH is not active\n * go to horizontal QH\n */\n- if (I-bit set) {\n- ehci_set_state(ehci, async, EST_HORIZONTALQH);\n- goto out;\n- }\n\nThanks,\nJamin\n\n> > > - if (I-bit set) {\n> > > - ehci_set_state(ehci, async, EST_HORIZONTALQH);\n> > > - goto out;\n> > > - }\n> > > -#endif\n> > > -\n> > > /*\n> > > * want data and alt-next qTD is valid\n> > > */\n> > > --\n> > > 2.43.0\n> > >","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=GxcyGyHb;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxdzZ3zxPz1yDF\n\tfor ; Fri, 17 Apr 2026 12:26:17 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDYth-0003WW-KO; Thu, 16 Apr 2026 22:25:33 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDYtf-0003VQ-1F; Thu, 16 Apr 2026 22:25:31 -0400","from mail-koreacentralazlp170130006.outbound.protection.outlook.com\n ([2a01:111:f403:c40f::6] helo=SEYPR02CU001.outbound.protection.outlook.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDYtc-0002Sl-Mf; Thu, 16 Apr 2026 22:25:30 -0400","from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19)\n by SE2PPF4A956A907.apcprd06.prod.outlook.com (2603:1096:108:1::7d0)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Fri, 17 Apr\n 2026 02:25:15 +0000","from TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9818.023; Fri, 17 Apr 2026\n 02:25:15 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=IW5DJUO1hVf8fawe4KWicfyo6nTmsvwAI2pL3hRzXIhGFq7ma4bsJBieAn+FkDhN+659KNSfCKWT7Yz8kgd+lcZWAYk7mFSfOXeD17lCTCSNYchMdEfWsiRdzyDcFlbK7BMeTYGEhojJoyTC4ukuLQA2VCX5I+Dk1pvgxkch+Xo9XR5QXOSK0xC3u2/ooIEiJpIahlJoZH6S/lc+H0pREiemsL7kXC3BaTDVQuvd/I/irFY6bU92CxJvaORFDVYMzrZurdRi/63kQZg5pPsFm2fm0Lw2ide9RxxgC3AUjXYSo+HpaIP3AiVXrJwaUXBYUgUOUmz4UCs88AOsRGT6Ag==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=4idSE6k5B2woOnRSpjuqvz5gS7QKlRm9+i589rliH20=;\n b=fviOnE46aE809fcF2TuRTvLkMcodJQTu7+0eqRdL8ZnsOIlPd13Or0WtqHi8WQXVVu5VfXlH11SK2uJPxYzOM6wVmj/tsERyh0vbkMmM/6WrUVMYMxFhxWFATDpkLK8tI8+58DSCCMmqdCLV38TMfzbc97jRz6JpSEdyvRPHgfzh/mDFilj0yzBofEXJgs+vtyHwy/gPb+FBDn3ZFgG/HdrunYpKy3bp4dRzBycS1AyXOxPJUicCU8gszN2svhOfwAUBhHe5xF7O123hsMjhf4vS1pKm7fcdZWXoiWRvOWQUoKdUH6VjwNKt04HyLJIhGsKkvklhLVLpTPtOZ5RGiA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=aspeedtech.com; dmarc=pass action=none\n header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=4idSE6k5B2woOnRSpjuqvz5gS7QKlRm9+i589rliH20=;\n b=GxcyGyHbjzOrZdshDY8k5FueFsnKJ6oDjxQKXLAUQTtMgwVNClOCimEJbJ5hEacERP0efCFEtgOQwlhK/oBmCWtU0CcExd7wUJ5NugKDvmKoMWSQSDVatb/O1HnbnpURgfBxsiz3WO2qTiF1vHmGo98cU5m3MNG2ecpCPk2NtiMXiO3iCFSK3/ShEecs7xJ+T+4eCaI3Gz/ycyCOvJ5sBaRiSUuVGaAhbCtG5OiT/3gCcN3PoHWOdsuMw6Q4mHQWgsW8CVpkNTMJdDnrR87Nz7CT5h6paQAEji6xnMj6ctF5NFC4ZiCyUOGl+kx//SBRN0gDel0k2EzukfnJ/aeB7g==","From":"Jamin Lin ","To":"BALATON Zoltan ","CC":"\"philmd@linaro.org\" , =?iso-8859-1?q?C=E9dric_Le_Goat?=\n\t=?iso-8859-1?q?er?= , Peter Maydell ,\n Steven Lee , Troy Lee ,\n Kane Chen ,\n Andrew Jeffery , Joel Stanley ,\n \"open list:ASPEED BMCs\" ,\n \"open list:All patches CC here\" ,\n Troy Lee , \"flwu@google.com\" ,\n \"nabihestefan@google.com\" ","Subject":"RE: [PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n structure and dead code","Thread-Topic":"[PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n structure and dead code","Thread-Index":"AQHczUNFhK5MCMsaPESXZcYoH3r+fLXhmSoAgADa5RCAABGycA==","Date":"Fri, 17 Apr 2026 02:25:15 +0000","Message-ID":"\n ","References":"<20260416014928.1279360-1-jamin_lin@aspeedtech.com>\n <20260416014928.1279360-2-jamin_lin@aspeedtech.com>\n \n ","In-Reply-To":"\n ","Accept-Language":"zh-TW, en-US","Content-Language":"zh-TW","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=GxcyGyHb;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;"],"x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"TYPPR06MB8206:EE_|SE2PPF4A956A907:EE_","x-ms-office365-filtering-correlation-id":"0b5f5542-0ca6-42ee-e8b3-08de9c288f9d","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|1800799024|7416014|376014|366016|22082099003|56012099003|38070700021|18002099003;","x-microsoft-antispam-message-info":"\n is78LDYidyKuT6rVGVHfXlCdJIRzI60Bl4IRJN9dm3AKPQTbAXVaDd7kVt9l+XJ1aTkmDMVLoW7bMSZJQSzzzNGuoL/TZ89XOWKoQOGg7kxF9oQ9ldmCc0fsstvCNwvVunWF+8ca4t3HKl4Mv/OZnZ5Q8vExE4mb5cIH/+PsBOyLZ6lH/hknx85SO72L0++3dvGmFIsxf/UoLT+++EspuqTNZ9Wjc6V9kxEtUb2YKtDCbFHC6hRQBzqELBIuzrnZmBlRR5kGZR7schW3zgcNwylXf16gQ34j41UKGSwa0120CZ5a3pgI2b1J+7NQesPGFAv9czEvRjQwNCjH+dY/5Gb5TJ9TcLiVCZH4ZsY6g4nH6ogd6fGyEd6D2gPvkECJzrIydZ5dMsU6pq2Aa+SUeybAMFEG58+GnUjSTkJ3B+8Esas7RHNsIC+v1+pCM2T2SVU/hlYVI4DcFiU8a/eHSY17u/SXiymVG5cAKawRiEhO7lhr44C/owSfupg+9CoTxUIfQ0mimwISEmB4VUPLQdhgkOF4qtWLPAEQESj1+Sq3k9dahjRnDEnz7+XDd5zc8dJG/fqfFF0dGHVWs5sTz2HyaF5LbmOXwFgpu7D13JYMPP2X74ZwoOGuPAxJdIQbnjtTxo7CcuLTQvYvgevxySRqs4wU4W6xS1xfJd01B6jTam/Fb1dHKbNJpfA4JBh5fl5qfLeVxD87x/uAMxsVAJoyqCA4/iA+e9fghwKW3CrpUyrDps2AEPgoVBeqgZT3IZfoU9dg2WZ5IG6T17RTICSJbJvvgT6QTB4QPO/JhZE=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:zh-tw; SCL:1;\n SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:;\n CAT:NONE;\n SFS:(13230040)(1800799024)(7416014)(376014)(366016)(22082099003)(56012099003)(38070700021)(18002099003);\n DIR:OUT; SFP:1102;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"=?iso-8859-1?q?HnVG5SsTV7af53Q3EruX5EA?=\n\t=?iso-8859-1?q?qvYuX7ypYAvRhh62mlXKK26lCoMqVd08k51lTxRmI30DzNGxl7Ax9zm0zj74?=\n\t=?iso-8859-1?q?PNXZ3/K+HQwlKlygU3ySXP6ghtZU9/HU7dfFxGnjqC5WmHJ2FJcKb4Xb1KUV?=\n\t=?iso-8859-1?q?MYU7WIOzna0aRl/bTls8vTfw/NO/y5oV6MwhXYcphcl3GpRNkTSzbGVejDx9?=\n\t=?iso-8859-1?q?mn6LNbQxXMaxQY3O8k7PKNuxOkFYgfxQjH9UXuSGn8UJTHZMs1RqL04qKMDW?=\n\t=?iso-8859-1?q?7C+MhI6HZJnKwvTOHmwP32Xz7Ecnl9b+pcn3WKCbXsuwwGDhg1XwA1fEu3Lq?=\n\t=?iso-8859-1?q?Ab9nm2QzvGCmnFVPJbXMQJ/9GP6wK9iwS19wbSHgh3PU5Td/BmPOSDWpagm6?=\n\t=?iso-8859-1?q?T9feHx+XtStczmqrpfWSutKxVOK5R8vYjZ0btfjkRWQBGlutWQIreHKu+1I3?=\n\t=?iso-8859-1?q?lZxtqY4WlgiRetzuUZu+JQgWPp7kDw0VxiZ7t0+AuAYxYAe+6cRX4GELBmnn?=\n\t=?iso-8859-1?q?AqsnoM/kEYWsXgHQ0ypJoKLJmBZU8+eYQjNRI49RAvAsZZt9yA2QVsw1cDTC?=\n\t=?iso-8859-1?q?fp5UNT3kRN7YMD97Ua0O+SFicN2c7IjYq0+zct5DKIdhO6BGQZ7nkgVeaAj3?=\n\t=?iso-8859-1?q?xXMxnYZCWCaBYJmTadmUozlrJYnv6DOjJARiVVxP0XjM0xHGEmwGra2VTKjK?=\n\t=?iso-8859-1?q?2kYcoD6/2jF3RVgv+eymhCyrFZGO4DX7Bqs1HakOcCtSwI/qqxVf+t2XwrJS?=\n\t=?iso-8859-1?q?sKdfXVP6p0Nx0ZobUfKSxpV0ruePC4qiZa+oUSjtKMeObJiMph0bl3L7VcvT?=\n\t=?iso-8859-1?q?Qv+kPXyRLpQqgppxp7gk6828Pk+pLQWNpuaxeuUvpQ/MSmRgOq+oZQ5TF+ed?=\n\t=?iso-8859-1?q?eCevOWwWQxvz1PwC8yqrPbMGXafJSDSwdGuLkqqgXwvTyqTDHe2uNkJ40HZL?=\n\t=?iso-8859-1?q?Q3N9YzHcchF3L/HiPZ4hGY6uly4lg27jUszEatfaUylmAbUm7JeJnctr6Wiv?=\n\t=?iso-8859-1?q?whlKlgNWfoaqnATzRFx/YBZbJOFWOJAdA+XfO7R4Ls7SAddRAdHZP1JYkXse?=\n\t=?iso-8859-1?q?6ALgz1Y//e5KjClgRiQuQmfpcTBTjVS+YxatWYqHv/wpc/XM5Hm5WXHqTl+7?=\n\t=?iso-8859-1?q?re99/5Br4dQfqU04aV9GF7Bx3bJZO2HkKejIami8+kfzTiQzpPkIPjgmsptS?=\n\t=?iso-8859-1?q?gNNEeu1zVkTLdte5SKmOD0R3Quho1wvS/6a735uSaeyMveixQmKtv0OpBlVp?=\n\t=?iso-8859-1?q?MzV2KO49rrOiKuVDLk3P8P8clugsRLElQJ3pdPc+ps0z+q9Pu7FuxxJHnTgE?=\n\t=?iso-8859-1?q?2ijRC77xPFLJrUprpmyO2zZYMLVqaT274kWYZFj5cFCV8gHVV5S+ZjGMqpto?=\n\t=?iso-8859-1?q?JfDkeWCsONf3ai89YsUvPMs+uiXIVR/H1CriDgrn8D7irXRvNwhhQthjDQpS?=\n\t=?iso-8859-1?q?ZLdKSgcg510G5RSqO3SiyBszZIjwjVaQ238zti7ym7qYKj+lAoM6kXfVIiMV?=\n\t=?iso-8859-1?q?Iw4gDtvAg0f/RKwJWO2FoH1KHv8wEKEQJS8iZKcryQcYQ5xKV9YNJ88+VHjd?=\n\t=?iso-8859-1?q?c9XR1L39Rxk/uWXmAQnzlNT2q8F/MpMHjz7Vsy/+Qi6gs5hohUMccVXraJmj?=\n\t=?iso-8859-1?q?4orLi3+5CytP567bbwqrxCqlMwIrNvwh6MyDIvG7wAESd2dk7+KFNFKlp+fs?=\n\t=?iso-8859-1?q?lxXR7DTS4AUvpjurBYOhNCv6C+DfVa3AQISzEUZ1yi+h3L/nxUdpqgHe5DC1?=\n\t=?iso-8859-1?q?xJ2cGFC8JVqqiWkHyPr9XOuh/kUnavbETX5AtNEAebIUP+A=3D=3D?=","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-Exchange-RoutingPolicyChecked":"\n wnZye3EmTD+MgA66R272rPpaRtAeGXH13YgHEJaEUs67uPlPCPsfF7rzegBQVx9/rhASsaInCqlVnmnBax64wCVGwrzJnMb/X1WKPgjjY31+S2O5RQhG0DFH4WtYZaEAYtwT+ykC9yk7AbqE2wfg7F8nzZj+UMXLNe8gqNsYo1cd6xej/Uvanywo8QoRA/QRhfDjtglJ5lR108pQaXXjydFETmccxtd1iz4HowL0nmGbOBDDTqf/frs6vf+k+etvUDKdZToUo37c0TfC30RW/AYbWBqt4V8ltQ7VsUdjugQXlZlxB8f8kh5F7jfAfwjXEC+2izFo7t0Lpg3IiW2mmA==","X-OriginatorOrg":"aspeedtech.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"TYPPR06MB8206.apcprd06.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 0b5f5542-0ca6-42ee-e8b3-08de9c288f9d","X-MS-Exchange-CrossTenant-originalarrivaltime":"17 Apr 2026 02:25:15.5021 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"43d4aa98-e35b-4575-8939-080e90d5a249","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n THcYI6fDJ9lDRUwfKxKcT+M+nr1E7IaZ6hEO62XXlz7QT4+X2xUvHWr2B5lyblWimhhsfr2yrkYxBj61xaqt8EMJWRFzJDlNPNekgtl9WXY=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"SE2PPF4A956A907","Received-SPF":"pass client-ip=2a01:111:f403:c40f::6;\n envelope-from=jamin_lin@aspeedtech.com;\n helo=SEYPR02CU001.outbound.protection.outlook.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3678508,"web_url":"http://patchwork.ozlabs.org/comment/3678508/","msgid":"","list_archive_url":null,"date":"2026-04-17T06:30:59","subject":"Re: [PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n structure and dead code","submitter":{"id":68548,"url":"http://patchwork.ozlabs.org/api/people/68548/","name":"Cédric Le Goater","email":"clg@kaod.org"},"content":"On 4/16/26 03:49, Jamin Lin wrote:\n> The EHCIfstn structure, defined according to EHCI spec section 3.7,\n> is currently unused in the EHCI implementation. Remove it to reduce\n> unused code and improve maintainability.\n> \n> Additionally, drop a block of disabled (#if 0) code in\n> ehci_state_advqueue() that was never implemented. This code path\n> is incomplete and has no functional impact.\n> \n> No functional change.\n> \n> Signed-off-by: Jamin Lin \n\n\nReviewed-by: Cédric Le Goater \n\nThanks,\n\nC.\n\n\n\n> ---\n> hw/usb/hcd-ehci.h | 7 -------\n> hw/usb/hcd-ehci.c | 11 -----------\n> 2 files changed, 18 deletions(-)\n> \n> diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h\n> index 0ae8c06331..3aec0e047c 100644\n> --- a/hw/usb/hcd-ehci.h\n> +++ b/hw/usb/hcd-ehci.h\n> @@ -202,13 +202,6 @@ typedef struct EHCIqh {\n> #define BUFPTR_SBYTES_SH 5\n> } EHCIqh;\n> \n> -/* EHCI spec version 1.0 Section 3.7\n> - */\n> -typedef struct EHCIfstn {\n> - uint32_t next; /* Standard next link pointer */\n> - uint32_t backptr; /* Standard next link pointer */\n> -} EHCIfstn;\n> -\n> enum async_state {\n> EHCI_ASYNC_NONE = 0,\n> EHCI_ASYNC_INITIALIZED,\n> diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c\n> index 57f930b099..5ea8461f70 100644\n> --- a/hw/usb/hcd-ehci.c\n> +++ b/hw/usb/hcd-ehci.c\n> @@ -1756,17 +1756,6 @@ static int ehci_state_fetchsitd(EHCIState *ehci, int async)\n> /* Section 4.10.2 - paragraph 3 */\n> static int ehci_state_advqueue(EHCIQueue *q)\n> {\n> -#if 0\n> - /* TO-DO: 4.10.2 - paragraph 2\n> - * if I-bit is set to 1 and QH is not active\n> - * go to horizontal QH\n> - */\n> - if (I-bit set) {\n> - ehci_set_state(ehci, async, EST_HORIZONTALQH);\n> - goto out;\n> - }\n> -#endif\n> -\n> /*\n> * want data and alt-next qTD is valid\n> */","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kaod.org header.i=@kaod.org header.a=rsa-sha256\n header.s=ovhmo393970-selector1 header.b=pDQ6wQCq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","garm.ovh; auth=pass\n (GARM-104R0057930a16d-5abb-417a-a2a2-b6c40814d36b,\n AF90ED76F5B1EEBCDFB51C8C68949B04E112CC0D) smtp.auth=clg@kaod.org"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxlRW1dy0z1yD3\n\tfor ; Fri, 17 Apr 2026 16:32:23 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDcjk-0003oQ-S9; Fri, 17 Apr 2026 02:31:32 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wDcjZ-0003nT-0R\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 02:31:25 -0400","from smtpout4.mo533.mail-out.ovh.net ([46.105.32.238])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wDcjQ-0007Wq-Lo\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 02:31:19 -0400","from director5.derp.mail-out.ovh.net\n (director5.derp.mail-out.ovh.net [51.68.94.138])\n by mo533.mail-out.ovh.net (Postfix) with ESMTPS id 4fxlPy4xrWz5xQf;\n Fri, 17 Apr 2026 06:31:02 +0000 (UTC)","from director5.derp.mail-out.ovh.net\n (director5.derp.mail-out.ovh.net. [127.0.0.1])\n by director5.derp.mail-out.ovh.net (inspect_sender_mail_agent) with SMTP\n for ; Fri, 17 Apr 2026 06:31:01 +0000 (UTC)","from mta7.priv.ovhmail-u2.ea.mail.ovh.net (unknown [10.110.43.232])\n by director5.derp.mail-out.ovh.net (Postfix) with ESMTPS id\n 4fxlPx4jsYz7tqK; Fri, 17 Apr 2026 06:31:01 +0000 (UTC)","from kaod.org (unknown [10.1.6.6])\n (Authenticated sender: clg@kaod.org)\n by mta7.priv.ovhmail-u2.ea.mail.ovh.net (Postfix) with ESMTPSA id\n B74CA2039DC;\n Fri, 17 Apr 2026 06:30:59 +0000 (UTC)"],"X-OVh-ClientIp":"82.64.250.170","Message-ID":"","Date":"Fri, 17 Apr 2026 08:30:59 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n structure and dead code","To":"Jamin Lin ,\n \"philmd@linaro.org\" ,\n Peter Maydell ,\n Steven Lee , Troy Lee ,\n Kane Chen ,\n Andrew Jeffery , Joel Stanley ,\n \"open list:ASPEED BMCs\" ,\n \"open list:All patches CC here\" ","Cc":"Troy Lee , \"flwu@google.com\" ,\n \"nabihestefan@google.com\" ","References":"<20260416014928.1279360-1-jamin_lin@aspeedtech.com>\n <20260416014928.1279360-2-jamin_lin@aspeedtech.com>","Content-Language":"en-US, fr","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Autocrypt":"addr=clg@kaod.org; keydata=\n xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo\n 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t\n yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj\n 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0\n ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV\n RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+\n gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia\n 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS\n Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS\n tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSBDw6lkcmljIExl\n IEdvYXRlciA8Y2xnQGthb2Qub3JnPsLBeAQTAQIAIgUCW7yjdQIbAwYLCQgHAwIGFQgCCQoL\n BBYCAwECHgECF4AACgkQUaNDx8/77KGRSxAAuMJJMhJdj7acTcFtwof7CDSfoVX0owE2FJdd\n M43hNeTwPWlV5oLCj1BOQo0MVilIpSd9Qu5wqRD8KnN2Bv/rllKPqK2+i8CXymi9hsuzF56m\n 76wiPwbsX54jhv/VYY9Al7NBknh6iLYJiC/pgacRCHtSj/wofemSCM48s61s1OleSPSSvJE/\n jYRa0jMXP98N5IEn8rEbkPua/yrm9ynHqi4dKEBCq/F7WDQ+FfUaFQb4ey47A/aSHstzpgsl\n TSDTJDD+Ms8y9x2X5EPKXnI3GRLaCKXVNNtrvbUd9LsKymK3WSbADaX7i0gvMFq7j51P/8yj\n neaUSKSkktHauJAtBNXHMghWm/xJXIVAW8xX5aEiSK7DNp5AM478rDXn9NZFUdLTAScVf7LZ\n VzMFKR0jAVG786b/O5vbxklsww+YXJGvCUvHuysEsz5EEzThTJ6AC5JM2iBn9/63PKiS3ptJ\n QAqzasT6KkZ9fKLdK3qtc6yPaSm22C5ROM3GS+yLy6iWBkJ/nEYh/L/du+TLw7YNbKejBr/J\n ml+V3qZLfuhDjW0GbeJVPzsENuxiNiBbyzlSnAvKlzda/sBDvxmvWhC+nMRQCf47mFr8Xx3w\n WtDSQavnz3zTa0XuEucpwfBuVdk4RlPzNPri6p2KTBhPEvRBdC9wNOdRBtsP9rAPjd52d73O\n wU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhWpOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNL\n SoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZKXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVU\n cP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwpbV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+\n S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc\n 9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFUCSLB2AE4wXQkJbApye48qnZ09zc929df5gU6\n hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iSYBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616d\n tb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6gLxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/\n t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1c\n OY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0SdujWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475\n KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/JxIqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8\n o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoX\n ywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjKyKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0\n IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9jhQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Ta\n d2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yops302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it\n +OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/pLHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1n\n HzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBUwYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVIS\n l73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lUXOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY\n 3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfAHQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4Pls\n ZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQizDiU6iOrUzBThaMhZO3i927SG2DwWDVzZlt\n KrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gDuVKe8BVz4atMOoktmt0GWTOC8P4=","In-Reply-To":"<20260416014928.1279360-2-jamin_lin@aspeedtech.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","x-ovh-tracer-id":"15250595715011030027","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"\n dmFkZTF8/wYOW5ASfvGwmMIsdD6HFAmrHglRViQ8jg2iKIivFFUR3Sh7qlpO5cXaesIxs0iRi48vPd5F+2K9V+HbgTgYRzZYyscjdrD4t7qhyd8ZvSj+dLLgKT8NBvvgMFuDWLOB2OZf9SpHdsMueEPLqTJcJr+0l3m9400H7pkJqVA/gj43P1NnZKIaYIdJmsDvIL4RxH6zXu3+iCJghNlun1sD5+1yw53qR9Ez7zXQKcKln9MeF6UpcZyfXI5JiUDMz31nq2svSN1Bq3YhxBVzCFmtZIaHzhfLWhnnT2+d7i8X26tbY5ABw5gA3WglCxIOn50ODhd5SsOAp70QiFnwWFovLXXNlke+qG29Wck/0MwWHKNFEi5zd4lw1Si+OlhjXHouI2lkIKpoEgwWLBYAaFmW1hYzkzv7CMGVIQskEjxEExBOD2s/uMHk2dHKtNL2Gif6nZXNAKE54mEjIohQfh2yvbkNbF+S6vdHQLzgdJrMYRhxYURVj+zdyJKLUlWCil6Y3nOptokD5MxvZAKdyIIodzNQjDHFVEuUPljQuskgQQ+Q8tQ5dL6mNVJUHrUTZoTS2xYD+dF86WEYi2MebziTRftwhkSkPVRw2AiCkQmV7oBLVIH/zc7TFT3ymvql7OyP8WGh1X7+ORcn7014teammhRvDiZBe4yzwqZlJnG6hw","DKIM-Signature":"a=rsa-sha256; bh=nUlI2iiyWIkynkOUgDgpKUlulD6M484JS3wG4cjidSY=;\n c=relaxed/relaxed; d=kaod.org; h=From; s=ovhmo393970-selector1;\n t=1776407464; v=1;\n b=pDQ6wQCqCphznMiXwm1SEQE6KG2XDx+k1yB/mR7u+RMwWieOnl64NdL/cNx0D/9RaBkJi5gN\n BRF6nPMfVONrjTcCNj0d5zAPD4OXxH80vV9F9jDYdoXCjFPjjMCOGLQy8p7DegqgD8vtpE/Sr88\n MHY3ho9D/SNsU58i7KSv378Kso8SNxqH+Fh2QMHaI/YAE18qVWqJyCZPlcdnT/sBs6IF7sfZqd0\n nOVXWnzI8GmsOeH8ZG5vBHrBNWXuljFZF4HI5SCyd8asf9xsoKdz30USDuHEokMj317fcfB5Jx9\n Y3RXfPXx/dbmtLU4i3bjOEPJ+t+xbAAUYqShXgFffFNbA==","Received-SPF":"pass client-ip=46.105.32.238; envelope-from=clg@kaod.org;\n helo=smtpout4.mo533.mail-out.ovh.net","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3678617,"web_url":"http://patchwork.ozlabs.org/comment/3678617/","msgid":"","list_archive_url":null,"date":"2026-04-17T09:47:32","subject":"RE: [PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n structure\n and dead code","submitter":{"id":16148,"url":"http://patchwork.ozlabs.org/api/people/16148/","name":"BALATON Zoltan","email":"balaton@eik.bme.hu"},"content":"On Fri, 17 Apr 2026, Jamin Lin wrote:\n> Hi all,\n>\n>> Subject: RE: [PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n>> structure and dead code\n>>\n>> Hi all,\n>>\n>>> Subject: Re: [PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n>>> structure and dead code\n>>>\n>>> On Thu, 16 Apr 2026, Jamin Lin wrote:\n>>>> The EHCIfstn structure, defined according to EHCI spec section 3.7,\n>>>> is currently unused in the EHCI implementation. Remove it to reduce\n>>>> unused code and improve maintainability.\n>>>>\n>>>> Additionally, drop a block of disabled (#if 0) code in\n>>>> ehci_state_advqueue() that was never implemented. This code path is\n>>>> incomplete and has no functional impact.\n>>>>\n>>>> No functional change.\n>>>>\n>>>> Signed-off-by: Jamin Lin \n>>>> ---\n>>>> hw/usb/hcd-ehci.h | 7 -------\n>>>> hw/usb/hcd-ehci.c | 11 -----------\n>>>> 2 files changed, 18 deletions(-)\n>>>>\n>>>> diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h index\n>>>> 0ae8c06331..3aec0e047c 100644\n>>>> --- a/hw/usb/hcd-ehci.h\n>>>> +++ b/hw/usb/hcd-ehci.h\n>>>> @@ -202,13 +202,6 @@ typedef struct EHCIqh {\n>>>> #define BUFPTR_SBYTES_SH 5\n>>>> } EHCIqh;\n>>>>\n>>>> -/* EHCI spec version 1.0 Section 3.7\n>>>> - */\n>>>> -typedef struct EHCIfstn {\n>>>> - uint32_t next; /* Standard next link pointer\n>> */\n>>>> - uint32_t backptr; /* Standard next link pointer */\n>>>> -} EHCIfstn;\n>>>> -\n>>>> enum async_state {\n>>>> EHCI_ASYNC_NONE = 0,\n>>>> EHCI_ASYNC_INITIALIZED,\n>>>> diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index\n>>>> 57f930b099..5ea8461f70 100644\n>>>> --- a/hw/usb/hcd-ehci.c\n>>>> +++ b/hw/usb/hcd-ehci.c\n>>>> @@ -1756,17 +1756,6 @@ static int ehci_state_fetchsitd(EHCIState\n>>>> *ehci, int async)\n>>>> /* Section 4.10.2 - paragraph 3 */\n>>>> static int ehci_state_advqueue(EHCIQueue *q) { -#if 0\n>>>> - /* TO-DO: 4.10.2 - paragraph 2\n>>>> - * if I-bit is set to 1 and QH is not active\n>>>> - * go to horizontal QH\n>>>> - */\n>>>\n>>> Is it worth to keep the comment in case it's still valid to remind we\n>>> have something missing here?\n>>>\n>>> Regards,\n>>> BALATON Zoltan\n>>>\n>>\n>> If we decide to keep these comments as reminders for unimplemented parts,\n>> please let me know. I will resend the patch series and drop this patch.\n>>\n>> Thanks,\n>> Jamin\n>>\n>\n> Another approach:\n> We can remove the #if 0 dead code and keep only the comments as a reminder that this part is not yet implemented.\n>\n> Ex:\n> --- a/hw/usb/hcd-ehci.c\n> +++ b/hw/usb/hcd-ehci.c\n> @@ -1756,16 +1756,10 @@ static int ehci_state_fetchsitd(EHCIState *ehci, int async)\n> /* Section 4.10.2 - paragraph 3 */\n> static int ehci_state_advqueue(EHCIQueue *q)\n> {\n> -#if 0\n> /* TO-DO: 4.10.2 - paragraph 2\n> * if I-bit is set to 1 and QH is not active\n> * go to horizontal QH\n> */\n> - if (I-bit set) {\n> - ehci_set_state(ehci, async, EST_HORIZONTALQH);\n> - goto out;\n> - }\n>\n> Thanks,\n> Jamin\n\nThat's what I meant to leave the comment but OK the remove ineffective \ncode.\n\nRegards,\nBALATON Zoltan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxqn03dbvz1yD3\n\tfor ; Fri, 17 Apr 2026 19:47:48 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDfnd-0008MG-Oi; Fri, 17 Apr 2026 05:47:45 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDfna-0008LU-Mk; Fri, 17 Apr 2026 05:47:42 -0400","from zero.eik.bme.hu ([2001:738:2001:2001::2001])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDfnY-0007K1-18; Fri, 17 Apr 2026 05:47:42 -0400","from localhost (localhost [127.0.0.1])\n by zero.eik.bme.hu (Postfix) with ESMTP id B5A8D596958;\n Fri, 17 Apr 2026 11:47:34 +0200 (CEST)","from zero.eik.bme.hu ([127.0.0.1])\n by localhost (zero.eik.bme.hu [127.0.0.1]) (amavis, port 10028) with ESMTP\n id vp9EOE1QEoKD; Fri, 17 Apr 2026 11:47:32 +0200 (CEST)","by zero.eik.bme.hu (Postfix, from userid 432)\n id 27782596957; Fri, 17 Apr 2026 11:47:32 +0200 (CEST)","from localhost (localhost [127.0.0.1])\n by zero.eik.bme.hu (Postfix) with ESMTP id 25224596954;\n Fri, 17 Apr 2026 11:47:32 +0200 (CEST)"],"X-Virus-Scanned":"amavis at eik.bme.hu","Date":"Fri, 17 Apr 2026 11:47:32 +0200 (CEST)","From":"BALATON Zoltan ","To":"Jamin Lin ","cc":"\"philmd@linaro.org\" , =?iso-8859-15?q?C=E9dric_Le_Goa?=\n\t=?iso-8859-15?q?ter?= ,\n Peter Maydell ,\n Steven Lee , Troy Lee ,\n Kane Chen ,\n Andrew Jeffery ,\n Joel Stanley ,\n \"open list:ASPEED BMCs\" ,\n \"open list:All patches CC here\" ,\n Troy Lee , \"flwu@google.com\" ,\n \"nabihestefan@google.com\" ","Subject":"RE: [PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n structure\n and dead code","In-Reply-To":"\n ","Message-ID":"","References":"<20260416014928.1279360-1-jamin_lin@aspeedtech.com>\n <20260416014928.1279360-2-jamin_lin@aspeedtech.com>\n \n \n ","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII; format=flowed","Received-SPF":"pass client-ip=2001:738:2001:2001::2001;\n envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu","X-Spam_score_int":"-18","X-Spam_score":"-1.9","X-Spam_bar":"-","X-Spam_report":"(-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3679205,"web_url":"http://patchwork.ozlabs.org/comment/3679205/","msgid":"","list_archive_url":null,"date":"2026-04-20T03:46:16","subject":"RE: [PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n structure and dead code","submitter":{"id":81768,"url":"http://patchwork.ozlabs.org/api/people/81768/","name":"Jamin Lin","email":"jamin_lin@aspeedtech.com"},"content":"Hi BALATON\n\n>\n> Subject: RE: [PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n> structure and dead code\n> \n> On Fri, 17 Apr 2026, Jamin Lin wrote:\n> > Hi all,\n> >\n> >> Subject: RE: [PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n> >> structure and dead code\n> >>\n> >> Hi all,\n> >>\n> >>> Subject: Re: [PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused\n> >>> EHCIfstn structure and dead code\n> >>>\n> >>> On Thu, 16 Apr 2026, Jamin Lin wrote:\n> >>>> The EHCIfstn structure, defined according to EHCI spec section 3.7,\n> >>>> is currently unused in the EHCI implementation. Remove it to reduce\n> >>>> unused code and improve maintainability.\n> >>>>\n> >>>> Additionally, drop a block of disabled (#if 0) code in\n> >>>> ehci_state_advqueue() that was never implemented. This code path is\n> >>>> incomplete and has no functional impact.\n> >>>>\n> >>>> No functional change.\n> >>>>\n> >>>> Signed-off-by: Jamin Lin \n> >>>> ---\n> >>>> hw/usb/hcd-ehci.h | 7 -------\n> >>>> hw/usb/hcd-ehci.c | 11 -----------\n> >>>> 2 files changed, 18 deletions(-)\n> >>>>\n> >>>> diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h index\n> >>>> 0ae8c06331..3aec0e047c 100644\n> >>>> --- a/hw/usb/hcd-ehci.h\n> >>>> +++ b/hw/usb/hcd-ehci.h\n> >>>> @@ -202,13 +202,6 @@ typedef struct EHCIqh {\n> >>>> #define BUFPTR_SBYTES_SH 5\n> >>>> } EHCIqh;\n> >>>>\n> >>>> -/* EHCI spec version 1.0 Section 3.7\n> >>>> - */\n> >>>> -typedef struct EHCIfstn {\n> >>>> - uint32_t next; /* Standard next link pointer\n> >> */\n> >>>> - uint32_t backptr; /* Standard next link pointer\n> */\n> >>>> -} EHCIfstn;\n> >>>> -\n> >>>> enum async_state {\n> >>>> EHCI_ASYNC_NONE = 0,\n> >>>> EHCI_ASYNC_INITIALIZED,\n> >>>> diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index\n> >>>> 57f930b099..5ea8461f70 100644\n> >>>> --- a/hw/usb/hcd-ehci.c\n> >>>> +++ b/hw/usb/hcd-ehci.c\n> >>>> @@ -1756,17 +1756,6 @@ static int ehci_state_fetchsitd(EHCIState\n> >>>> *ehci, int async)\n> >>>> /* Section 4.10.2 - paragraph 3 */\n> >>>> static int ehci_state_advqueue(EHCIQueue *q) { -#if 0\n> >>>> - /* TO-DO: 4.10.2 - paragraph 2\n> >>>> - * if I-bit is set to 1 and QH is not active\n> >>>> - * go to horizontal QH\n> >>>> - */\n> >>>\n> >>> Is it worth to keep the comment in case it's still valid to remind\n> >>> we have something missing here?\n> >>>\n> >>> Regards,\n> >>> BALATON Zoltan\n> >>>\n> >>\n> >> If we decide to keep these comments as reminders for unimplemented\n> >> parts, please let me know. I will resend the patch series and drop this patch.\n> >>\n> >> Thanks,\n> >> Jamin\n> >>\n> >\n> > Another approach:\n> > We can remove the #if 0 dead code and keep only the comments as a\n> reminder that this part is not yet implemented.\n> >\n> > Ex:\n> > --- a/hw/usb/hcd-ehci.c\n> > +++ b/hw/usb/hcd-ehci.c\n> > @@ -1756,16 +1756,10 @@ static int ehci_state_fetchsitd(EHCIState\n> > *ehci, int async)\n> > /* Section 4.10.2 - paragraph 3 */\n> > static int ehci_state_advqueue(EHCIQueue *q) { -#if 0\n> > /* TO-DO: 4.10.2 - paragraph 2\n> > * if I-bit is set to 1 and QH is not active\n> > * go to horizontal QH\n> > */\n> > - if (I-bit set) {\n> > - ehci_set_state(ehci, async, EST_HORIZONTALQH);\n> > - goto out;\n> > - }\n> >\n> > Thanks,\n> > Jamin\n> \n> That's what I meant to leave the comment but OK the remove ineffective code.\nThanks for the suggestion.\nWill do.\nJamin\n> \n> Regards,\n> BALATON Zoltan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=MwXmIPVD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzWdk0dpvz1yGs\n\tfor ; Mon, 20 Apr 2026 13:47:20 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wEfap-0005wc-Vp; Sun, 19 Apr 2026 23:46:43 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wEfah-0005vx-EO; Sun, 19 Apr 2026 23:46:32 -0400","from mail-koreacentralazlp170130006.outbound.protection.outlook.com\n ([2a01:111:f403:c40f::6] helo=SEYPR02CU001.outbound.protection.outlook.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wEfaf-0002Bl-90; Sun, 19 Apr 2026 23:46:31 -0400","from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19)\n by TYPPR06MB7972.apcprd06.prod.outlook.com (2603:1096:405:2c0::11)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.32; Mon, 20 Apr\n 2026 03:46:16 +0000","from TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9818.032; Mon, 20 Apr 2026\n 03:46:16 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=cF8MsbkvaIakp87eL7AdzGxigk6nl4jn8dMgDRJjmMKW82Wil92nsfOgPT2eVeR46YKEKpHD6sXg5AFf0Q250ResGGayIBSIlzz9zkjspZgsWVzfc21A0wPhql6niDs8UMvBpp0pUm9JqBis6CLwgzXmGTKrPc+X7uP4266wHmKJvuDRhkfuqbJ+LWWwdqy3LRWyA9DFrswStA3d8EuVTkFNVTJrwcCf0u9XDVzwWsNbzbaOCon+aiwnYoWfxiLthFfuiBlWLPWXC6/e/PTh/d6oWiUJK0ErxjNfGYNJNAHYytA25jNGewsiJR4ix0Ai22x+g3OnA8zKwsmWNk44DQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=LWZw+YdUnonxfkq6uEmXY72LLG0nxoV8NSogM7hgWPE=;\n b=ih9t1st/72hNO5BwlqnYsD2rf5vJUsAbNnC7VQIHuE47egMeLD1p9LwKGAU6UunBJaCG4xDPcY8CKA3H1AaUHcNR7fo4RuXu2eV/oUuHydSiiXSlz9H2mMvPrLZdsaC1epRRy8RlRLZV3OLRm/SEfsFhdWLAL7FgyVeKrWmJRt3aFyaWhVa0hCPecsx3GsBNIm6gLtIhDNvQbl3ofEGkinuwuHLrTbwuvloKiEZPUuYVUId6qTTSA3LJMVMTCeAzt4AYWNbGXoZrw0YxZ4iubOMv35uXC82kgVz4pnYxtxuVT4gEDGKtv4S23MmXPtLuvRuiYFRT7mKpZtii0io2+w==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=aspeedtech.com; dmarc=pass action=none\n header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=LWZw+YdUnonxfkq6uEmXY72LLG0nxoV8NSogM7hgWPE=;\n b=MwXmIPVDSAklyYBQBWC2fY6q9d3sqASmkrbCCsijdgPjlO8wKAC2ikGwCg7XKag+J+rcxIIYeucuozHW/euR1hR19Gwe++DyCmJJpzvx76IYMSUrxYCSFSatL/o9/UfxDsOQalg6d8P/rNi+ZlUd3JOCb7PtwvA0bOCSeSRqk3gR1x+bPPf+yDOGRepjfWzEmwD3i8rhKF4kyEnLTQ+WRryFNifyjV8rknuEKjQVYFXkDv12K/neVXXV4h5EpHbSS7BmgwjMuNsUiukcBWzFjk3RwU3hIwc+AlPOlX661exmsTcmWAime5reoKfDZPKPeO1Vj6YTiVCXBoNattGucQ==","From":"Jamin Lin ","To":"BALATON Zoltan ","CC":"\"philmd@linaro.org\" , =?iso-8859-1?q?C=E9dric_Le_Goat?=\n\t=?iso-8859-1?q?er?= , Peter Maydell ,\n Steven Lee , Troy Lee ,\n Kane Chen ,\n Andrew Jeffery , Joel Stanley ,\n \"open list:ASPEED BMCs\" ,\n \"open list:All patches CC here\" ,\n Troy Lee , \"flwu@google.com\" ,\n \"nabihestefan@google.com\" ","Subject":"RE: [PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n structure and dead code","Thread-Topic":"[PATCH v3 01/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n structure and dead code","Thread-Index":"AQHczUNFhK5MCMsaPESXZcYoH3r+fLXhmSoAgADa5RCAABGycIAAfiQAgARRziA=","Date":"Mon, 20 Apr 2026 03:46:16 +0000","Message-ID":"\n ","References":"<20260416014928.1279360-1-jamin_lin@aspeedtech.com>\n <20260416014928.1279360-2-jamin_lin@aspeedtech.com>\n \n \n \n ","In-Reply-To":"","Accept-Language":"zh-TW, en-US","Content-Language":"zh-TW","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=MwXmIPVD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;"],"x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"TYPPR06MB8206:EE_|TYPPR06MB7972:EE_","x-ms-office365-filtering-correlation-id":"62c34e2d-6bfe-47a0-ac2d-08de9e8f6002","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|1800799024|366016|376014|7416014|38070700021|56012099003|18002099003|22082099003;","x-microsoft-antispam-message-info":"\n rRBcy4P3L+K2GfjoeZIJdZ6TZLjEYvYjLR/TOMwdLK0gqzTbDNk6eKew3VseOM7/63TtVlLD7rovzZNV/iVH57PO7O+Bt3Ddu5qyEurvc2zGu1lVBSpziKu8xfZmR4/ukVURrDbbQvF1pjYxGxaw+sLD1yvavlCRTZnd0z35BKouCmtHAyNXvbV549HAUpZiaPg1zqsbXxXArhI79l1gD4Y3Kb0A0vGgbCKEIc53D3U8BZu0TvuYKvjtVDnh0Fb6Z027zQhCE6BrlYADSRBQJFZXjHj4/MiYs/tuglLu5qXtg9dBOCgfoxQs4LtINPWmDxXu1OgjSQcnG8QbN8kQayXmVgBiXoHjPl7xpLowWp5sKYYEBcOws+/S4Qd8VHICFUYoXk8poZ7HQ5wDFQvJRz5aqHh0xkCmkSX2oRizI9cZWoh9Z/Rr1E+hwjzZLkucnwrDOUcWVZBOktbaLmkrzqD0CFT+9gd/u1b6aaYd5TCiYfBz4/mwaiG7DaMqrZ4aNNQ/N6hfrHjG9NiouAz3DA5FecKaru4OXAi+/gOBIvzWqRLaOz7aum5tPcO139CkZyzwIVSL7rvmzAytXBn1zLnvaN+Y9LFcTf5i/D37BWOYysYGerBGkqz6+uXyPEp04dvqo+UqoWavpWYFYwgC87yQCOxqHEuk5+vWF0eV/sLcYVgokeCo9gWZ4J8BqbZTqnc6zZTqWuXHaiWD6by5+b8983Htvxj74DkHMns4QhXs3FYfsTNBuLP/Mx720je3n4sTV/VkmqefPrjLa4Oi0kKvo5E3vQIzdDfr7Ai20KU=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:zh-tw; SCL:1;\n SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:;\n CAT:NONE;\n SFS:(13230040)(1800799024)(366016)(376014)(7416014)(38070700021)(56012099003)(18002099003)(22082099003);\n DIR:OUT; SFP:1102;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"=?iso-8859-1?q?5Do81KxJxMn57iEGr+2kZPv?=\n\t=?iso-8859-1?q?Ngl2VI+bT/se42IzIFskx6P+7nmDsBDredrPrYBDDFrUa3Tlonq1FJlfglP/?=\n\t=?iso-8859-1?q?47oLteMhxQhZkte/1anVZYfLIQrbGBBpygwWvq3e6tYuyzI2alFYPSSfxira?=\n\t=?iso-8859-1?q?3u2sayP7LYqmtc1ivJhVJNVOQjH1JB2I3f8F9WROudR/gWmQqv3CxcAWOFle?=\n\t=?iso-8859-1?q?T9uafha05MhFi5qOmvXInr5cxaP6eenCtfmAGrkxVxHUYpvcqY4rUtTdty44?=\n\t=?iso-8859-1?q?Nvi+PagS2uADcBmhfsX47UTr5o+jtJsZR3oGJYCT/BAnpFRVbg4M1GCFwQmR?=\n\t=?iso-8859-1?q?JZF/JXCWGGKrvV2HAqAHMBMkKz6zsA0eATblELZ2Ua5RQYv4FOPkU3BrLlG6?=\n\t=?iso-8859-1?q?woVZWfSaAOlg0Ju3vksLJIrR/E/lufOcspc6axNY5kCC2sOLOY3GvZ2BKwEj?=\n\t=?iso-8859-1?q?3rBEU85+IdEpeUoD+u5xb6qZEvY4sfH1s0U8s6jXnHL/TYlyVGODxzGdQfpw?=\n\t=?iso-8859-1?q?w1L7MUrVmHigqeLAGU2/k0zcPHHlaal3oa3IWEs2fo8lJUg4oE8fki5msvfB?=\n\t=?iso-8859-1?q?S2Rx9PlzKhDrjvUJRSIIShlVeYBQL8fi+cf4Chn429UkdgU3kC3dU3F1sm/x?=\n\t=?iso-8859-1?q?DP4JEqfn6BYoORQCR6L5bBq/r+5rZHQTykuMOBDaLHKxeOG69m+ahi5wygoj?=\n\t=?iso-8859-1?q?XGMya8Fw21aEDjHPTxOc3V5BW9TMF/MZuSOjEmkU5OVRxKdXQ+6KohWWu6N1?=\n\t=?iso-8859-1?q?MXiEJqZuwVALCYWfRoNKT+FlzXiQhWDL3ZrhUfXdZq1igyhgs0+i3PssR4NF?=\n\t=?iso-8859-1?q?0b81ZoO0syXta3c/zxC2N+HOscs/FJ4C32E6NkBqF+ivwGKZ+sAJAnrUaDdK?=\n\t=?iso-8859-1?q?3JcwiPaBvW4ESAJCIuAYolYo/A8aYujuYyyOCwIFA6/lmnPLcgp1qTWypgLT?=\n\t=?iso-8859-1?q?kOKXMhugq3R136gRuyXU3UQbBjiZCFlFYROBO48aJs7Ch61SxC7dw9F3gKxW?=\n\t=?iso-8859-1?q?GZJ94qYCtEYJbL71krAqwOoBr2vH/QjLsMZecB8zWPCXinklFkmdOgHaZXFI?=\n\t=?iso-8859-1?q?pexDoTFOUepYdM/yByyT4BhHv0FHWuUHoktg9ynDyurR/Udf80IDRsnkz9D0?=\n\t=?iso-8859-1?q?KiokZVjYk1IpqBSnORx/BjguZgvBeXW14fXhzCzFd/RskOsntRC5kSDr21d3?=\n\t=?iso-8859-1?q?WGvn2QJkudwO2t+Op3dYtFJw1n+Hwqq+uGgvxBLv6AwRIPlP+e7dzOhmzbYU?=\n\t=?iso-8859-1?q?Xp8XdGSjTHfHb+sfIoiV+V/S4xRF4H9+CoewJuOMJkTLH3JDAE9QA0afQCBz?=\n\t=?iso-8859-1?q?yoniG42N4JtNBxji6w46nLbKb/xaBxWgTWenyNbo6ihvxIRnoRmkePgp4oNy?=\n\t=?iso-8859-1?q?EFCN47w76EBIF/fnwsQQkK6qaAmdPkfU4oTGd4Vlds9yvkXLV55YbX5BWJ7r?=\n\t=?iso-8859-1?q?YkXB83UCldBcSeMOnzQorroVqu7aMJ00JZYrWBp58mxdJUxm/oXdEDvchoRn?=\n\t=?iso-8859-1?q?bQekf38leCaLUtDb8OIi8GcCNUCxnB7lm0yOwZuf8ZdtQnM/H98eQ2nWhRaq?=\n\t=?iso-8859-1?q?hY4CSkZZEyh4NW6QyzDqApOYA/9Du0G2n/3eeOh0EGrmdhbEhtsKFXtegKO4?=\n\t=?iso-8859-1?q?Gm5MhPwgXjdTrz4GFVTMR1uY1IirGvjmX7tg1qevM3KYeC5jWknkuEw+GpLn?=\n\t=?iso-8859-1?q?K4vznvdTdTgGqQYRmvRltw90Di7kXe7srOqaHwPu9Uc7frB/vSkMz5o3nGR/?=\n\t=?iso-8859-1?q?Iid63v/QJmigk+LZMGC7iH17+p62nJ+x81dVk7STrF0T8yA=3D=3D?=","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-Exchange-RoutingPolicyChecked":"\n ustCPxoUMypyIWSq4ibKNB3FlHrgCRBNxWMfpMaGqzGTAminPIIP/0oX+AGqXb4HlztiqRwhmtll6tK+sNS/8aOCWPspf6S3NPFo1kogEB4fE+/TKxTMktcjbhpIeqIPGMmb2ImQSQrRqzYG5K7Gy3TvxOm6kMydi6ps5oJ24/QmA+6NFL4871wLLkvbaDawysw194IX4016x2yhg3OEsJwiI0ofnV31LyYokNcnY8QUO8+L/pStvnznj1YD/RlswzQb4jvmRBlXaBMejiglKMinVcPTde75FKRXHjNMNat8L804uqnCV4gAmFiGQZucLgDbgLCIuBsTmTLW6Hu2xg==","X-OriginatorOrg":"aspeedtech.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"TYPPR06MB8206.apcprd06.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 62c34e2d-6bfe-47a0-ac2d-08de9e8f6002","X-MS-Exchange-CrossTenant-originalarrivaltime":"20 Apr 2026 03:46:16.1100 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"43d4aa98-e35b-4575-8939-080e90d5a249","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n GGlnX1dk2yOb8FQ+9SkJW1xO8VTKDWsafXWI6sTlSsaHaRmIWJaFlbSGQWIwErEb+chddU+hM1iHMyBEenYfINSqSoNNz1V5KYWus9lS/Tc=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"TYPPR06MB7972","Received-SPF":"pass client-ip=2a01:111:f403:c40f::6;\n envelope-from=jamin_lin@aspeedtech.com;\n helo=SEYPR02CU001.outbound.protection.outlook.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]