[{"id":3678341,"web_url":"http://patchwork.ozlabs.org/comment/3678341/","msgid":"<CAFLszThhPE9SPOHhjcukPUDsg4Yf+GtPhVWeHdsnKCQE1ysOSg@mail.gmail.com>","list_archive_url":null,"date":"2026-04-16T19:36:17","subject":"Re: [PATCH v2 7/7] test: py: add mkimage dm-verity round-trip test","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Daniel,\n\nOn 2026-04-16T01:46:15, Daniel Golle <daniel@makrotopia.org> wrote:\n> test: py: add mkimage dm-verity round-trip test\n>\n> Add test/py/tests/test_fit_verity.py with two tests.\n>\n> Both tests are skipped if veritysetup is not installed on the host.\n>\n> Signed-off-by: Daniel Golle <daniel@makrotopia.org>\n>\n> test/py/tests/test_fit_verity.py | 153 +++++++++++++++++++++++++++++++++++++++\n>  1 file changed, 153 insertions(+)\n\n> diff --git a/test/py/tests/test_fit_verity.py b/test/py/tests/test_fit_verity.py\n> @@ -0,0 +1,153 @@\n> +import struct\n\nThe struct import seems to be unused.\n\n> diff --git a/test/py/tests/test_fit_verity.py b/test/py/tests/test_fit_verity.py\n> @@ -0,0 +1,153 @@\n> +def have_veritysetup():\n> +    return shutil.which('veritysetup') is not None\n> +\n> +\n> +@pytest.mark.requiredtool('dtc')\n> +@pytest.mark.requiredtool('fdtget')\n> +@pytest.mark.skipif(not have_veritysetup(),\n> +                    reason='veritysetup not installed')\n> +def test_mkimage_verity(ubman):\n\nThe test infrastructure supports\n@pytest.mark.requiredtool('veritysetup') which handles the skip\nmessage consistently. That also means you can drop the\nhave_veritysetup() helper.\n\nRegards,\nSimon","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=ZXm+dHuw;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"ZXm+dHuw\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxSv01PkNz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 05:36:44 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8015283EEF;\n\tThu, 16 Apr 2026 21:36:35 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 6C252841F2; Thu, 16 Apr 2026 21:36:34 +0200 (CEST)","from mail-ed1-x535.google.com (mail-ed1-x535.google.com\n [IPv6:2a00:1450:4864:20::535])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 6025280086\n for <u-boot@lists.denx.de>; Thu, 16 Apr 2026 21:36:32 +0200 (CEST)","by mail-ed1-x535.google.com with SMTP id\n 4fb4d7f45d1cf-672bd7d00bdso172658a12.1\n for <u-boot@lists.denx.de>; Thu, 16 Apr 2026 12:36:32 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776368192; cv=none;\n d=google.com; s=arc-20240605;\n b=Q4FTjN1vQsRZJ4c5odlT7dvUwu6Rq4lCZofnW8cbnW++uv6dDY0NCUnxNMminO1A0f\n LXbHsyay40DaNhukQeqsFKJYWhVhY1I30a3WG+IN+0EtStYMmaO+agPBDQToq54XgMZP\n uk8pDCs1r1+HaTeKto/qELeJdIUeFoPK78Ulc/blTIUfhwDITYD2QneIzXf0eAG2EKpO\n eT1EmiQvoIMtdib7amUHzmUGxSt+AIdD0GVvQb/Oetv6z+et+P1CNLA0nPar4CLPQtax\n RW/SqQSEMVG6AzdGqGk1NFNsXh/xZLtetxqyLSGjduwhE2E+iS9n/3/lPrClSG8a2lKa\n j7Lw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=Z3NhqLS/9XedvHvU4LSaUDbGntd933Usjc4Mky+SIRQ=;\n fh=1GDjmpAREd9sK9zDNvgAAkWKiaYXwy/vI7ZDvQ2JZvk=;\n b=NAlDf5vo/Zm4XTKrGvNfAmOMTx1VH4znaOmpxVUmPEjAy8cHjCYS7JpIp95vyy2s3J\n wu7w8cFL1yqwHjB+z9l+2HpqfBbL+k5KpjtOlrwwYH6takW/cxQUZwsCFrdrsete3sDi\n uIjNpF91QHnhb3Oqrc9TUPkohDd/XrcJ+9fbUj8RS2I72sIZzvrOWmSz3MkDFlAAZAZL\n a+avS3Rofo9bVDakJMNwVrH1E1GILFjXTrTCDzwg3UmqLRBlwj59zl04NQbj1DUPod4R\n 5ZcQ2z26IeUQhj4iim4BKezQTKaq5uM4oSQ/TDXJ2LMfjiG0SNGVqgM72DfJq/Lcr5FX\n wB0Q==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776368192; x=1776972992; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=Z3NhqLS/9XedvHvU4LSaUDbGntd933Usjc4Mky+SIRQ=;\n b=ZXm+dHuwlI+abKujN22+bKpopcx1e0yAv9dMC0KIsV28UdD2oBQZTLvns3Iw5yMFQE\n 1NqrU084Fq/BUrlNjGyLT8OOhREgEWxhnEAEDO3ChB300v8t700hnFbNqiR7Fghfez2B\n w8TotrCPz0UxdjNAmCuAfoLRgO5jWxG2hWZHY=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776368192; x=1776972992;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Z3NhqLS/9XedvHvU4LSaUDbGntd933Usjc4Mky+SIRQ=;\n b=VgF/bFWe4QXCB+QT3ofhVVpDoCNYpMnc4TgySQILmDhzng3dtnOgRpTrMqHUvHTq7p\n ldtKdY3v2onX2pY/9BkRPCgkgJSSiPRR1mz2tDlALMG/1QMmdhyP9weXs+ubT2ySXXHq\n 5U/a6wpPv9rRRMDGn3oZM1g3UPEXLn3JfPtYDJkayl+s6OK9RCOsk4kWYgchbyUfQWjW\n GObtCJ02hIyolj0w/uFt8Fd+eAV4pguCU1HVgdpZMo41kr71YLWNFBKY7tBs9+xCHBHz\n RZq5oRWpuWQDn4Clj3UTKtQUgerV5u7aQvvDJJqrwo0Yx2m8fOXWz6OggGZUXEK61XNY\n 6Uzg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+kiTWdg+Lvk8TdRgSZB+wMIenSarMhgAjSZHo3zFhNBi6hvRLHW8GwCvuryk+lJ+NP7H9wDjY=@lists.denx.de","X-Gm-Message-State":"AOJu0YzJp4uif+HNCq7VWq5+tDOnmEueXHtUc5zRTbDI/3/1XVd6xZxu\n CuVcW7FMZTq0S98z2m56NqnRwgcRsjJLKBEzszXoYwDgQWkzrVE+eLRqsVd++uYn1MAKgxd/TTd\n pju6om04Y5xCpNDdU1ZyWDwwqTteQ2vVvZJOePAKE","X-Gm-Gg":"AeBDiet75x51ZdFhnck53X5hSefIA61fD76epmOCK70av0G4VHIRI8EXLBGfUmzxacC\n BPkPrZHwg0hz88RcMLPnULClomWXCpycBCsVXdd/NJTY/gtqeu+JqZ30riBIvGefBaPFYb+M0we\n eNQjP/CKQPPTEFaFzPQ8c8jpLA1Oy+0gPdlMtRvr7sd2qSAQjngEbwbaqn9a7uAj78byIQRb3Vb\n Z+e4v7TINSHyq1aaPOGiZHa8K/sqopTsFjvfLHa8eGJ6Y70dKzsTJ1i+sCyUBueZjepiC5NtOiD\n B5czcAvZfeg+9rwXgCX5","X-Received":"by 2002:a17:907:ca1e:b0:b9c:7ba2:4168 with SMTP id\n a640c23a62f3a-ba3dbfa3b3cmr33226566b.22.1776368191667; Thu, 16 Apr 2026\n 12:36:31 -0700 (PDT)","MIME-Version":"1.0","References":"<cover.1776302805.git.daniel@makrotopia.org>\n <9ceb70fcad4dec6efae1b03297f38665926b6c9f.1776302806.git.daniel@makrotopia.org>","In-Reply-To":"\n <9ceb70fcad4dec6efae1b03297f38665926b6c9f.1776302806.git.daniel@makrotopia.org>","From":"Simon Glass <sjg@chromium.org>","Date":"Fri, 17 Apr 2026 07:36:17 +1200","X-Gm-Features":"AQROBzBLcMlOH__2jB2VZTYEujRwuc5PY9q9rEdG_RVXaimb2WqKNV9q7NcBDuI","Message-ID":"\n <CAFLszThhPE9SPOHhjcukPUDsg4Yf+GtPhVWeHdsnKCQE1ysOSg@mail.gmail.com>","Subject":"Re: [PATCH v2 7/7] test: py: add mkimage dm-verity round-trip test","To":"daniel@makrotopia.org","Cc":"Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,\n Quentin Schulz <quentin.schulz@cherry.de>,\n Kory Maincent <kory.maincent@bootlin.com>,\n Mattijs Korpershoek <mkorpershoek@kernel.org>, Peng Fan <peng.fan@nxp.com>,\n Heinrich Schuchardt <xypron.glpk@gmx.de>, Martin Schwan <m.schwan@phytec.de>,\n Anshul Dalal <anshuld@ti.com>,\n Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Sughosh Ganu <sughosh.ganu@arm.com>,\n Aristo Chen <jj251510319013@gmail.com>,\n Ludwig Nussel <ludwig.nussel@siemens.com>,\n Benjamin ROBIN <dev@benjarobin.fr>,\n Marek Vasut <marek.vasut+renesas@mailbox.org>,\n James Hilliard <james.hilliard1@gmail.com>,\n Wolfgang Wallner <wolfgang.wallner@at.abb.com>,\n Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,\n David Lechner <dlechner@baylibre.com>,\n Neil Armstrong <neil.armstrong@linaro.org>,\n Mayuresh Chitale <mchitale@ventanamicro.com>,\n Jonas Karlman <jonas@kwiboo.se>, Shiji Yang <yangshiji66@outlook.com>,\n Rasmus Villemoes <ravi@prevas.dk>, Francois Berder <fberder@outlook.fr>,\n u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3678419,"web_url":"http://patchwork.ozlabs.org/comment/3678419/","msgid":"<aeFppbCsfKNDTWuC@makrotopia.org>","list_archive_url":null,"date":"2026-04-16T22:58:45","subject":"Re: [PATCH v2 7/7] test: py: add mkimage dm-verity round-trip test","submitter":{"id":64091,"url":"http://patchwork.ozlabs.org/api/people/64091/","name":"Daniel Golle","email":"daniel@makrotopia.org"},"content":"On Fri, Apr 17, 2026 at 07:36:17AM +1200, Simon Glass wrote:\n> Hi Daniel,\n> \n> On 2026-04-16T01:46:15, Daniel Golle <daniel@makrotopia.org> wrote:\n> > test: py: add mkimage dm-verity round-trip test\n> >\n> > Add test/py/tests/test_fit_verity.py with two tests.\n> >\n> > Both tests are skipped if veritysetup is not installed on the host.\n> >\n> > Signed-off-by: Daniel Golle <daniel@makrotopia.org>\n> >\n> > test/py/tests/test_fit_verity.py | 153 +++++++++++++++++++++++++++++++++++++++\n> >  1 file changed, 153 insertions(+)\n> \n> > diff --git a/test/py/tests/test_fit_verity.py b/test/py/tests/test_fit_verity.py\n> > @@ -0,0 +1,153 @@\n> > +import struct\n> \n> The struct import seems to be unused.\n> \n> > diff --git a/test/py/tests/test_fit_verity.py b/test/py/tests/test_fit_verity.py\n> > @@ -0,0 +1,153 @@\n> > +def have_veritysetup():\n> > +    return shutil.which('veritysetup') is not None\n> > +\n> > +\n> > +@pytest.mark.requiredtool('dtc')\n> > +@pytest.mark.requiredtool('fdtget')\n> > +@pytest.mark.skipif(not have_veritysetup(),\n> > +                    reason='veritysetup not installed')\n> > +def test_mkimage_verity(ubman):\n> \n> The test infrastructure supports\n> @pytest.mark.requiredtool('veritysetup') which handles the skip\n> message consistently. That also means you can drop the\n> have_veritysetup() helper.\n\nI have to admit that Python is not one of my strengths...\nI'll try to figure it out and address this in v3.","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=makrotopia.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de; dmarc=none (p=none dis=none)\n header.from=makrotopia.org","phobos.denx.de;\n spf=pass smtp.mailfrom=daniel@makrotopia.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxYNy3PX9z1yGt\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 08:59:30 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 09B9B83FC0;\n\tFri, 17 Apr 2026 00:59:21 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 9AD6B8407E; Fri, 17 Apr 2026 00:59:19 +0200 (CEST)","from pidgin.makrotopia.org (pidgin.makrotopia.org\n [IPv6:2a07:2ec0:3002::65])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 5130183EEF\n for <u-boot@lists.denx.de>; Fri, 17 Apr 2026 00:59:17 +0200 (CEST)","from local\n by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256)\n (Exim 4.99) (envelope-from <daniel@makrotopia.org>)\n id 1wDVfc-000000006lY-3AeT; Thu, 16 Apr 2026 22:58:48 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","Date":"Thu, 16 Apr 2026 23:58:45 +0100","From":"Daniel Golle <daniel@makrotopia.org>","To":"Simon Glass <sjg@chromium.org>","Cc":"Tom Rini <trini@konsulko.com>, Quentin Schulz <quentin.schulz@cherry.de>,\n Kory Maincent <kory.maincent@bootlin.com>,\n Mattijs Korpershoek <mkorpershoek@kernel.org>, Peng Fan <peng.fan@nxp.com>,\n Heinrich Schuchardt <xypron.glpk@gmx.de>,\n Martin Schwan <m.schwan@phytec.de>, Anshul Dalal <anshuld@ti.com>,\n Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Sughosh Ganu <sughosh.ganu@arm.com>,\n Aristo Chen <jj251510319013@gmail.com>,\n Ludwig Nussel <ludwig.nussel@siemens.com>,\n Benjamin ROBIN <dev@benjarobin.fr>,\n Marek Vasut <marek.vasut+renesas@mailbox.org>,\n James Hilliard <james.hilliard1@gmail.com>,\n Wolfgang Wallner <wolfgang.wallner@at.abb.com>,\n Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,\n David Lechner <dlechner@baylibre.com>,\n Neil Armstrong <neil.armstrong@linaro.org>,\n Mayuresh Chitale <mchitale@ventanamicro.com>,\n Jonas Karlman <jonas@kwiboo.se>, Shiji Yang <yangshiji66@outlook.com>,\n Rasmus Villemoes <ravi@prevas.dk>,\n Francois Berder <fberder@outlook.fr>, u-boot@lists.denx.de","Subject":"Re: [PATCH v2 7/7] test: py: add mkimage dm-verity round-trip test","Message-ID":"<aeFppbCsfKNDTWuC@makrotopia.org>","References":"<cover.1776302805.git.daniel@makrotopia.org>\n <9ceb70fcad4dec6efae1b03297f38665926b6c9f.1776302806.git.daniel@makrotopia.org>\n <CAFLszThhPE9SPOHhjcukPUDsg4Yf+GtPhVWeHdsnKCQE1ysOSg@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"\n <CAFLszThhPE9SPOHhjcukPUDsg4Yf+GtPhVWeHdsnKCQE1ysOSg@mail.gmail.com>","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3678438,"web_url":"http://patchwork.ozlabs.org/comment/3678438/","msgid":"<CAFLszTgSKdVA7BynWJ3cGxZiCQbBaq2cwLTAm9hRpj4gHs1uyQ@mail.gmail.com>","list_archive_url":null,"date":"2026-04-16T23:59:54","subject":"Re: [PATCH v2 7/7] test: py: add mkimage dm-verity round-trip test","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Daniel,\n\nOn Fri, 17 Apr 2026 at 10:58, Daniel Golle <daniel@makrotopia.org> wrote:\n>\n> On Fri, Apr 17, 2026 at 07:36:17AM +1200, Simon Glass wrote:\n> > Hi Daniel,\n> >\n> > On 2026-04-16T01:46:15, Daniel Golle <daniel@makrotopia.org> wrote:\n> > > test: py: add mkimage dm-verity round-trip test\n> > >\n> > > Add test/py/tests/test_fit_verity.py with two tests.\n> > >\n> > > Both tests are skipped if veritysetup is not installed on the host.\n> > >\n> > > Signed-off-by: Daniel Golle <daniel@makrotopia.org>\n> > >\n> > > test/py/tests/test_fit_verity.py | 153 +++++++++++++++++++++++++++++++++++++++\n> > >  1 file changed, 153 insertions(+)\n> >\n> > > diff --git a/test/py/tests/test_fit_verity.py b/test/py/tests/test_fit_verity.py\n> > > @@ -0,0 +1,153 @@\n> > > +import struct\n> >\n> > The struct import seems to be unused.\n> >\n> > > diff --git a/test/py/tests/test_fit_verity.py b/test/py/tests/test_fit_verity.py\n> > > @@ -0,0 +1,153 @@\n> > > +def have_veritysetup():\n> > > +    return shutil.which('veritysetup') is not None\n> > > +\n> > > +\n> > > +@pytest.mark.requiredtool('dtc')\n> > > +@pytest.mark.requiredtool('fdtget')\n> > > +@pytest.mark.skipif(not have_veritysetup(),\n> > > +                    reason='veritysetup not installed')\n> > > +def test_mkimage_verity(ubman):\n> >\n> > The test infrastructure supports\n> > @pytest.mark.requiredtool('veritysetup') which handles the skip\n> > message consistently. That also means you can drop the\n> > have_veritysetup() helper.\n>\n> I have to admit that Python is not one of my strengths...\n> I'll try to figure it out and address this in v3.\n\nMe neither, despite having written quite a bit of it. Let me know if\nyou need help with any of it.\n\nRegards,\nSimon","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=gq+Fog6F;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"gq+Fog6F\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxZlC3V8Lz1yD3\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 10:00:23 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 4EC6C841C8;\n\tFri, 17 Apr 2026 02:00:18 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 6586883EEF; Fri, 17 Apr 2026 02:00:15 +0200 (CEST)","from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com\n [IPv6:2a00:1450:4864:20::62a])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id D713D841C8\n for <u-boot@lists.denx.de>; Fri, 17 Apr 2026 02:00:09 +0200 (CEST)","by mail-ej1-x62a.google.com with SMTP id\n a640c23a62f3a-b9c603ec2dfso18638466b.1\n for <u-boot@lists.denx.de>; Thu, 16 Apr 2026 17:00:09 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776384009; cv=none;\n d=google.com; s=arc-20240605;\n b=N+wfGLSCPdG3FJaWPy+T6B1Yz5CXFsj4FZBAEhtw0tvAqMKz6blKgPRcscwZzfXtFG\n lVROrnACvdJCL7fjWtCqVxfE/gnOEY9sbIhH5C1uxGYOWGuG1SOkQCBpnbNzYLBGRU+X\n Oayl1qoI+8Y2yMRSPtmB/k7Ftwwc9rLm+GK4iCXhxDsLaMfo1yvzBRzg/0rxeyEwEESL\n F99hz1bu+tVdlm3a0NgQvg4UB2yuhgYJVjkxAfGdeqBewQ1YaAjvLwNW4LRSg5wa8Uq3\n TbiCHtiG0oTY3J8136lDjkATqAfAYWJ95M6ZIwI4Mocx1J/aH0NU2eMcs/DUtXZ4Dlds\n aYeQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=Rnt0WZthPmdMDULykt2Ki8VRtuLJgwW+AD4ooRdQANg=;\n fh=l/TNieQ0pgOAlCvjziz5ptgBYiorGf6L+HzRHNcZRV4=;\n b=B2dqgJfdm8Eo6brHxvTINEKC9nXhLNfHrmn1ZIlCKh2DNT63O5G1+buOgXC5jJPOrt\n LgO3xyLrxA0Lp6dREc8gsR4Un0PLv9x+LvWPqMhWQ3kAPqhkhEU8uV9dsF3hFOViDgvz\n 3CeSxAs0PkZhQx4l17rA7U3HiU47/bpta+BKExYkJ1mb/Bd/1nEWSs74+RimXmPihawi\n A4SJMB4kM6WkV/Tu5rJchr/obNbo0VrrPpKs+4LVJO2ayMLjsNLS74GsT9KCfc0WdukL\n qWnskfWlO3Edlogbd1N+aSp1yBzUPBS25cgGRq9OzNHNApSLqZBrbJqx/TL10ndLFLHw\n APGg==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776384009; x=1776988809; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=Rnt0WZthPmdMDULykt2Ki8VRtuLJgwW+AD4ooRdQANg=;\n b=gq+Fog6FATj2kEXwr7k9CPEf0g0z2Na6kVyG1gJTxLGs1XVotQWgJBBTKDi36pr1rJ\n sk9ZXqk6U58DvsUL5J+XKBMU6HSNdJpW/3zQ0BaVhB7RXqnT6aWP3MJNoztPGh+pAKra\n zseR8uBvZ23apHrZkxJUpwHDbqGdxDHK2bRI0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776384009; x=1776988809;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Rnt0WZthPmdMDULykt2Ki8VRtuLJgwW+AD4ooRdQANg=;\n b=DG6Vhi3rvvZh+FK53vMfd3vTGVEkzq6fwRjKKSLSv6YNsYNonW7CWoI5CoIulqs8q/\n F4S0tnvPxoGsw96uXpFNHVsnuyW4+zGtipCuH7q2XdL1eK1tHmHdLeFARX9umzQNmGLM\n 1torG4f1zUmdtp4kozz+swFtqBGXLB3OfP29BK9rmNekW/Z0CeezIdQqZQZ0tmbGqk09\n OqCdH14CkTWxWMvvT9qjG0LnIbaZ7jeRJpBROKyoqILunDD5/RFBNfT4Okbkc1bL3jER\n GCdejvbQW2IkCGBkIA2UUdnRm6oxT/W+mf283WgpQupYB5mP6OYwtyWy9jUM14kAE188\n F/FA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+5/HORTQ978ojzB3w4Z+b+K7mpSHEo7VNMn+fBxfc+/wwgGfGGPgYpeerbjv/slFQQggy2Zy4=@lists.denx.de","X-Gm-Message-State":"AOJu0YxPl+ejVMH+HdfcpfmIB4Sz/vMjV2oT7w95tSsKsPqclRnoSi/S\n 4zjLy3QjZ924iMaI54mW17bhmK35Y0BtjJJf2kA6IoZSpqfPblaI7bVbxttv4sbbtZfW0ZWFFcm\n kOyV7agnul5AJei6VIZduhJSuMFcmINtBO+sAojo4","X-Gm-Gg":"AeBDiet9JBh4pVkB/+4nTGHr6xDv4C/tX/qsWMikiJhMeFNTGoED3MQLAh6nHocyBu+\n on6h3EOrR1w8QzqC8bC2VqnIlwC94MJfqaENMqJUJ4uQcVqEAV3q+3m39eGB7RiIE3pZHZMD5+o\n hZMGEi04LoG97f1WEDgrIkWQAlJp7BTow7Ed7FMFYuouN59ntd5AaRJCRRaqY0V8qKPxSmM9hk4\n 2h+H5hXrEK6f22yQlB5A+zdqUe6t3egBkMR+efWOhyJj6ZXFRcKc3rZozMseOR/Oo0310sxHdmq\n JvyiJL61AC79Y/5n1eJP","X-Received":"by 2002:a17:906:dc89:b0:ba2:da52:66a5 with SMTP id\n a640c23a62f3a-ba418b7e6d7mr28195466b.18.1776384009143; Thu, 16 Apr 2026\n 17:00:09 -0700 (PDT)","MIME-Version":"1.0","References":"<cover.1776302805.git.daniel@makrotopia.org>\n <9ceb70fcad4dec6efae1b03297f38665926b6c9f.1776302806.git.daniel@makrotopia.org>\n <CAFLszThhPE9SPOHhjcukPUDsg4Yf+GtPhVWeHdsnKCQE1ysOSg@mail.gmail.com>\n <aeFppbCsfKNDTWuC@makrotopia.org>","In-Reply-To":"<aeFppbCsfKNDTWuC@makrotopia.org>","From":"Simon Glass <sjg@chromium.org>","Date":"Fri, 17 Apr 2026 11:59:54 +1200","X-Gm-Features":"AQROBzCKKm56WLFx6hFz3iVkJNnOgTGf6-V3mS96lDMUsZqyc9wNHszwl116p8A","Message-ID":"\n <CAFLszTgSKdVA7BynWJ3cGxZiCQbBaq2cwLTAm9hRpj4gHs1uyQ@mail.gmail.com>","Subject":"Re: [PATCH v2 7/7] test: py: add mkimage dm-verity round-trip test","To":"Daniel Golle <daniel@makrotopia.org>","Cc":"Tom Rini <trini@konsulko.com>, Quentin Schulz <quentin.schulz@cherry.de>,\n Kory Maincent <kory.maincent@bootlin.com>,\n Mattijs Korpershoek <mkorpershoek@kernel.org>,\n Peng Fan <peng.fan@nxp.com>, Heinrich Schuchardt <xypron.glpk@gmx.de>,\n Martin Schwan <m.schwan@phytec.de>, Anshul Dalal <anshuld@ti.com>,\n Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Sughosh Ganu <sughosh.ganu@arm.com>,\n Aristo Chen <jj251510319013@gmail.com>,\n Ludwig Nussel <ludwig.nussel@siemens.com>,\n Benjamin ROBIN <dev@benjarobin.fr>,\n Marek Vasut <marek.vasut+renesas@mailbox.org>,\n James Hilliard <james.hilliard1@gmail.com>,\n Wolfgang Wallner <wolfgang.wallner@at.abb.com>,\n Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,\n David Lechner <dlechner@baylibre.com>,\n Neil Armstrong <neil.armstrong@linaro.org>,\n Mayuresh Chitale <mchitale@ventanamicro.com>,\n Jonas Karlman <jonas@kwiboo.se>, Shiji Yang <yangshiji66@outlook.com>,\n Rasmus Villemoes <ravi@prevas.dk>, Francois Berder <fberder@outlook.fr>,\n u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]