[{"id":3678343,"web_url":"http://patchwork.ozlabs.org/comment/3678343/","msgid":"<CAFLszTgazuTSYbidfn7Q1gEiE1RG2YVkj2Vz9L6fN49QE0bdUA@mail.gmail.com>","list_archive_url":null,"date":"2026-04-16T19:36:37","subject":"Re: [PATCH v2 6/7] test: boot: add runtime unit test for\n fit_verity_build_cmdline()","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Daniel,\n\nOn 2026-04-16T01:46:15, Daniel Golle <daniel@makrotopia.org> wrote:\n> test: boot: add runtime unit test for fit_verity_build_cmdline()\n>\n> Add test/boot/fit_verity.c with four tests that construct FIT blobs\n> in memory and exercise fit_verity_build_cmdline().\n>\n> Signed-off-by: Daniel Golle <daniel@makrotopia.org>\n>\n> test/boot/Makefile     |   1 +\n>  test/boot/fit_verity.c | 302 +++++++++++++++++++++++++++++++++++++++++++++++++\n>  test/cmd_ut.c          |   2 +\n>  3 files changed, 305 insertions(+)\n\n> diff --git a/test/boot/fit_verity.c b/test/boot/fit_verity.c\n> @@ -0,0 +1,302 @@\n> +             ret = fdt_setprop_string(buf, verity_node, \"algo\", \"sha256\");\n> +             val = cpu_to_fdt32(4096);\n> +             ret = fdt_setprop(buf, verity_node, \"data-block-size\",\n\nPlease can you use the FIT_VERITY_*_PROP constants from\ninclude/image.h instead of literal strings? See test/image/spl_load.c\nfor an example.\n\nRegards,\nSimon","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=QIdlC6rI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"QIdlC6rI\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxSvN1MBdz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 05:37:04 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 78EEF84277;\n\tThu, 16 Apr 2026 21:36:59 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id AA53D80086; Thu, 16 Apr 2026 21:36:56 +0200 (CEST)","from mail-ej1-x633.google.com (mail-ej1-x633.google.com\n [IPv6:2a00:1450:4864:20::633])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E18A484222\n for <u-boot@lists.denx.de>; Thu, 16 Apr 2026 21:36:51 +0200 (CEST)","by mail-ej1-x633.google.com with SMTP id\n a640c23a62f3a-ba23b5bcbd5so291111166b.2\n for <u-boot@lists.denx.de>; Thu, 16 Apr 2026 12:36:51 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776368211; cv=none;\n d=google.com; s=arc-20240605;\n b=lAn3QKgRq6CaJnwKfCzHmlnX8K68Q+KtpkY4ReV6C72CDSimXkDK22LZPe5qk5AQap\n 825r5lE7o+D1aL1ePtCvJ4ZtwkQlGcxjquihaWxKZVvS6Heqc+hgQVqxZxuC8lga1RkC\n sA6ozNX5M9/sYttpNDxLO07vJTDFjuB2rV/UTXhrKH3LxJgHYsBTwl6j9lqwBpYAbwOf\n pkWBmaFz8+AMyV3Px/hwa25u4ZjN6fO61yRUYM5Rz6oJwpQc/YpofaDD1/O3pwACTbyN\n TCAh9iNKCZFtUg+GQIdsRidpeFkfkRYRORxIPg86Z+OQd0xvCsMUdiX/Ltp0rsSXt7fI\n AqcQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=AfzZTDzVt+L5jeWILjk3Ph+bvsjKKs5pThvcK/YLNo4=;\n fh=Y+YA09imsVFHetIR3lhgrzGXd19XK8H0XNKJcOHXZQE=;\n b=UE+V+5WJrC5Hp7syjjHfk+VrNuCiZADQcc0MRm7BavmwW0GlEvmqSDZY6kbyt0liVF\n FERAEWWpsUaaiz45Hz3k/3K2CP1gFOyijQ2P0c7NMLmllNVdwNfBfwrj+DrcYYgjCGQX\n VxyueX1BLoSJzeLET4H4XNijfhee8EJVEK4LXPkeRWKeypU1V5Ep7c+rTEmy8ck2zf/w\n KQuu40OyWnq4rJQlJT0WwRm9g1nEsJq4d+2qszvfT1gXXRW0XRcpO90vVoGGXYZcDBfH\n HzDpqbB6i57uxBiRcEDROU4ktxI0U7/CmZtt8gTo51c88tcK5C5VmHmlAQLSQWoFj/Hu\n zerw==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776368211; x=1776973011; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=AfzZTDzVt+L5jeWILjk3Ph+bvsjKKs5pThvcK/YLNo4=;\n b=QIdlC6rIU+ygXsYBwAikmmk0lcfHedG04GLY4b7gX/G3/D6N3vlOeJONjCv+gM2ApR\n NDAMzfQ0Qy93Sis6ggyxRI8+TnPF7Uew+3+X/OZqNPmpw1wz6BkuzkP38jI0tGVc1XNz\n 9RWbhOZAi+xt062QoKReoiKkrJ3ulOqO4w9S0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776368211; x=1776973011;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=AfzZTDzVt+L5jeWILjk3Ph+bvsjKKs5pThvcK/YLNo4=;\n b=ro/skqeUYiRodWoXH6m8uoxfFA7S5PiWLX5haYyABpGiNRBvqaU/HheoLBZ3mcD6q4\n vikGt7eCAIoh/N2SUTHhBbf+GYfAuyX00hnG+PcETG6G3OyoDjoqedgBvJNG1NikOMQN\n kpSiGsJQfuzlqln09+p6Wc3NnX5QA4ydYhOx5Gia/ky5d83OlYVCyQ8uzLzu4dw5v0Rd\n GCDSnCAodtnbP8FlwQ7nBvBZK9iptV57rKUu2+MTmPO7+O/W6Cg2wJiFe0OG5yK1WYSv\n +VBAEeMJpPggRy+puZ6zmvKrlJiVQcgbgqAby1fYxE8fdb3J3uEtZ/jlwGBOV6tIYFje\n EpxA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9fEyVLWCwwF8j9ksWDKsnj+Tfmpr+OgEvDO5XtozD3TBdTrQyfmQ8oqy8dyz4rKqFVY0ZE2Vw=@lists.denx.de","X-Gm-Message-State":"AOJu0Yy0opowKymOkm73cCbdN7j/1UV+44iqDEt1fycwSAOpkFGNpeY3\n vgBNW2oWpjHnqg5h7M5pK+D2bQLV1jNErRVm0rzYg+vvhNnc4fKHlN9I5ZlrhuuUppMVqWeBNGU\n D2xxkk6lBxlOJ7V4tSv2tf3wvjDj6SJtzj838r+RA","X-Gm-Gg":"AeBDievl6gpJTGowTBRVphFb7euSuk6DTIPzgJseMzRE8bKKklmb/C+is4YoDM3Nl9Z\n dwqjDws0WCnuyQ0s8skLlSbTqf5PMIRd3qfeWKjkxGr7szlh40QERqdvAjP4AYmQ9fztHPvuPC4\n rSASHIRUhvySYUgLgRjJr7gRvwB1sfd4n3tjtKw/o74HY2ud1/EnL5a1sP5ZeA5ZSehx5ZP4hWS\n w9AtlwQgjJtLJuNnOxxeP0VbuSxO8uCfHlqCI5oy6FHPE8X5r0aPlPp0cYIeIJGibBVKpJeZwTg\n aYc3RvRTbZp28yFtFzGv","X-Received":"by 2002:a17:906:9350:b0:b9c:6ef1:ed13 with SMTP id\n a640c23a62f3a-ba3dd6b2d2amr30124966b.31.1776368211084; Thu, 16 Apr 2026\n 12:36:51 -0700 (PDT)","MIME-Version":"1.0","References":"<cover.1776302805.git.daniel@makrotopia.org>\n <97e38b81f2e8f54ec819940d360849e4cf61b875.1776302806.git.daniel@makrotopia.org>","In-Reply-To":"\n <97e38b81f2e8f54ec819940d360849e4cf61b875.1776302806.git.daniel@makrotopia.org>","From":"Simon Glass <sjg@chromium.org>","Date":"Fri, 17 Apr 2026 07:36:37 +1200","X-Gm-Features":"AQROBzDvJUtYvv4Vy0eakB8Ie3RzsuwRZwuW9C-hVNjhZpcmekfFlRVHeywIhSs","Message-ID":"\n <CAFLszTgazuTSYbidfn7Q1gEiE1RG2YVkj2Vz9L6fN49QE0bdUA@mail.gmail.com>","Subject":"Re: [PATCH v2 6/7] test: boot: add runtime unit test for\n fit_verity_build_cmdline()","To":"daniel@makrotopia.org","Cc":"Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,\n Quentin Schulz <quentin.schulz@cherry.de>,\n Kory Maincent <kory.maincent@bootlin.com>,\n Mattijs Korpershoek <mkorpershoek@kernel.org>, Peng Fan <peng.fan@nxp.com>,\n Heinrich Schuchardt <xypron.glpk@gmx.de>, Martin Schwan <m.schwan@phytec.de>,\n Anshul Dalal <anshuld@ti.com>,\n Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Sughosh Ganu <sughosh.ganu@arm.com>,\n Aristo Chen <jj251510319013@gmail.com>,\n Ludwig Nussel <ludwig.nussel@siemens.com>,\n Benjamin ROBIN <dev@benjarobin.fr>,\n Marek Vasut <marek.vasut+renesas@mailbox.org>,\n James Hilliard <james.hilliard1@gmail.com>,\n Wolfgang Wallner <wolfgang.wallner@at.abb.com>,\n Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,\n David Lechner <dlechner@baylibre.com>,\n Neil Armstrong <neil.armstrong@linaro.org>,\n Mayuresh Chitale <mchitale@ventanamicro.com>,\n Jonas Karlman <jonas@kwiboo.se>, Shiji Yang <yangshiji66@outlook.com>,\n Rasmus Villemoes <ravi@prevas.dk>, Francois Berder <fberder@outlook.fr>,\n u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3678433,"web_url":"http://patchwork.ozlabs.org/comment/3678433/","msgid":"<aeFv-xm5MZ44W3Yn@makrotopia.org>","list_archive_url":null,"date":"2026-04-16T23:25:47","subject":"Re: [PATCH v2 6/7] test: boot: add runtime unit test for\n fit_verity_build_cmdline()","submitter":{"id":64091,"url":"http://patchwork.ozlabs.org/api/people/64091/","name":"Daniel Golle","email":"daniel@makrotopia.org"},"content":"On Fri, Apr 17, 2026 at 07:36:37AM +1200, Simon Glass wrote:\n> Hi Daniel,\n> \n> On 2026-04-16T01:46:15, Daniel Golle <daniel@makrotopia.org> wrote:\n> > test: boot: add runtime unit test for fit_verity_build_cmdline()\n> >\n> > Add test/boot/fit_verity.c with four tests that construct FIT blobs\n> > in memory and exercise fit_verity_build_cmdline().\n> >\n> > Signed-off-by: Daniel Golle <daniel@makrotopia.org>\n> >\n> > test/boot/Makefile     |   1 +\n> >  test/boot/fit_verity.c | 302 +++++++++++++++++++++++++++++++++++++++++++++++++\n> >  test/cmd_ut.c          |   2 +\n> >  3 files changed, 305 insertions(+)\n> \n> > diff --git a/test/boot/fit_verity.c b/test/boot/fit_verity.c\n> > @@ -0,0 +1,302 @@\n> > +             ret = fdt_setprop_string(buf, verity_node, \"algo\", \"sha256\");\n> > +             val = cpu_to_fdt32(4096);\n> > +             ret = fdt_setprop(buf, verity_node, \"data-block-size\",\n> \n> Please can you use the FIT_VERITY_*_PROP constants from\n> include/image.h instead of literal strings? See test/image/spl_load.c\n> for an example.\n\nSure, I'll change that.\n\nI was deliberately not doing it so the test code is as self-contained\nas possible.","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=makrotopia.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de; dmarc=none (p=none dis=none)\n header.from=makrotopia.org","phobos.denx.de;\n spf=pass smtp.mailfrom=daniel@makrotopia.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxYzv4SMQz1yGt\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 09:26:19 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 51B3F83FC0;\n\tFri, 17 Apr 2026 01:26:15 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id A520F8407E; Fri, 17 Apr 2026 01:26:13 +0200 (CEST)","from pidgin.makrotopia.org (pidgin.makrotopia.org\n [IPv6:2a07:2ec0:3002::65])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 47B2D83EEF\n for <u-boot@lists.denx.de>; Fri, 17 Apr 2026 01:26:11 +0200 (CEST)","from local\n by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256)\n (Exim 4.99) (envelope-from <daniel@makrotopia.org>)\n id 1wDW5n-000000006tD-2pI3; Thu, 16 Apr 2026 23:25:51 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","Date":"Fri, 17 Apr 2026 00:25:47 +0100","From":"Daniel Golle <daniel@makrotopia.org>","To":"Simon Glass <sjg@chromium.org>","Cc":"Tom Rini <trini@konsulko.com>, Quentin Schulz <quentin.schulz@cherry.de>,\n Kory Maincent <kory.maincent@bootlin.com>,\n Mattijs Korpershoek <mkorpershoek@kernel.org>, Peng Fan <peng.fan@nxp.com>,\n Heinrich Schuchardt <xypron.glpk@gmx.de>,\n Martin Schwan <m.schwan@phytec.de>, Anshul Dalal <anshuld@ti.com>,\n Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Sughosh Ganu <sughosh.ganu@arm.com>,\n Aristo Chen <jj251510319013@gmail.com>,\n Ludwig Nussel <ludwig.nussel@siemens.com>,\n Benjamin ROBIN <dev@benjarobin.fr>,\n Marek Vasut <marek.vasut+renesas@mailbox.org>,\n James Hilliard <james.hilliard1@gmail.com>,\n Wolfgang Wallner <wolfgang.wallner@at.abb.com>,\n Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,\n David Lechner <dlechner@baylibre.com>,\n Neil Armstrong <neil.armstrong@linaro.org>,\n Mayuresh Chitale <mchitale@ventanamicro.com>,\n Jonas Karlman <jonas@kwiboo.se>, Shiji Yang <yangshiji66@outlook.com>,\n Rasmus Villemoes <ravi@prevas.dk>,\n Francois Berder <fberder@outlook.fr>, u-boot@lists.denx.de","Subject":"Re: [PATCH v2 6/7] test: boot: add runtime unit test for\n fit_verity_build_cmdline()","Message-ID":"<aeFv-xm5MZ44W3Yn@makrotopia.org>","References":"<cover.1776302805.git.daniel@makrotopia.org>\n <97e38b81f2e8f54ec819940d360849e4cf61b875.1776302806.git.daniel@makrotopia.org>\n <CAFLszTgazuTSYbidfn7Q1gEiE1RG2YVkj2Vz9L6fN49QE0bdUA@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"\n <CAFLszTgazuTSYbidfn7Q1gEiE1RG2YVkj2Vz9L6fN49QE0bdUA@mail.gmail.com>","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3678437,"web_url":"http://patchwork.ozlabs.org/comment/3678437/","msgid":"<CAFLszTh3RD86+wkBv=wOm_-ghQssQuymhrnhPMpXsfY8=dnMeg@mail.gmail.com>","list_archive_url":null,"date":"2026-04-16T23:59:48","subject":"Re: [PATCH v2 6/7] test: boot: add runtime unit test for\n fit_verity_build_cmdline()","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Daniel,\n\nOn Fri, 17 Apr 2026 at 11:25, Daniel Golle <daniel@makrotopia.org> wrote:\n>\n> On Fri, Apr 17, 2026 at 07:36:37AM +1200, Simon Glass wrote:\n> > Hi Daniel,\n> >\n> > On 2026-04-16T01:46:15, Daniel Golle <daniel@makrotopia.org> wrote:\n> > > test: boot: add runtime unit test for fit_verity_build_cmdline()\n> > >\n> > > Add test/boot/fit_verity.c with four tests that construct FIT blobs\n> > > in memory and exercise fit_verity_build_cmdline().\n> > >\n> > > Signed-off-by: Daniel Golle <daniel@makrotopia.org>\n> > >\n> > > test/boot/Makefile     |   1 +\n> > >  test/boot/fit_verity.c | 302 +++++++++++++++++++++++++++++++++++++++++++++++++\n> > >  test/cmd_ut.c          |   2 +\n> > >  3 files changed, 305 insertions(+)\n> >\n> > > diff --git a/test/boot/fit_verity.c b/test/boot/fit_verity.c\n> > > @@ -0,0 +1,302 @@\n> > > +             ret = fdt_setprop_string(buf, verity_node, \"algo\", \"sha256\");\n> > > +             val = cpu_to_fdt32(4096);\n> > > +             ret = fdt_setprop(buf, verity_node, \"data-block-size\",\n> >\n> > Please can you use the FIT_VERITY_*_PROP constants from\n> > include/image.h instead of literal strings? See test/image/spl_load.c\n> > for an example.\n>\n> Sure, I'll change that.\n>\n> I was deliberately not doing it so the test code is as self-contained\n> as possible.\n\nThat is a good goal in general, yes, but I would hope that no one\nwould be silly enough to change the constant :-)\n\nRegards,\nSimon","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=aRB65Hpg;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"aRB65Hpg\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxZl95NkSz1yD3\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 10:00:21 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 2F3BF83FC0;\n\tFri, 17 Apr 2026 02:00:11 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id EB80A8407E; Fri, 17 Apr 2026 02:00:09 +0200 (CEST)","from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com\n [IPv6:2a00:1450:4864:20::62c])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 8C45C83EEF\n for <u-boot@lists.denx.de>; Fri, 17 Apr 2026 02:00:01 +0200 (CEST)","by mail-ej1-x62c.google.com with SMTP id\n a640c23a62f3a-b9c755b2cdeso19934266b.2\n for <u-boot@lists.denx.de>; Thu, 16 Apr 2026 17:00:01 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776384001; cv=none;\n d=google.com; s=arc-20240605;\n b=YiH6BcbFVpyy3AuWxdlgYMj0l31oUs22uupJ4WzBdnvH949Y79CRjmIwyTY7MJovgQ\n WzAEHb/9D6f4LTAsSGnGIdQm6NA0Jnj5litO/arNW4kkXXx+HIvJj+6BZmCk/kj2VGa/\n Fg92jPvu0YMv45FlgKh/QR3hs7hmp8UbcMCrR3TorjqIJUIARyfMcxdXDsiDshAGXGHI\n 484DlXUVJasaKjSppKq06oS3F6C654NYZYLthhTkQFY2JHB/+73cu2BdguzezUykHyNi\n TnugaUlV+k7225xB6zMt7+kjOM3qrC0nXJxZNGFk+CI1CN2qIc/UWUQs86+UEDpLZEOw\n fpcw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=TT5yf1nbaOpW+KnNXd5fLiEBCUUKgHBYh1jMeLbvfCc=;\n fh=yjaNGXPU9vnhuaIfRNRT42k/Y9Z8QC/U5cdfj7g1S8M=;\n b=Ut+iJlJHUGhoC9IfsZ8uC34ZhJWowAhvg93u7GF7R2trHr7FtfswzPLTYbuthODwa8\n ownZHwYzp+ryBIwK1XaxrCb1TOhCZOeZzqg9ay8BgYNixe3X23qhzS72ZayVWGAF/jx5\n HgtX+DWAc4JtPrc92sbCXnx7qSDZappXMuY6l8ehZIbjM+7Za++IpsP6JllOo47xsNnq\n kg/UeuRWGDAt95qBg8XTvAHxgd4LgF9Fgtm1/h6SlaV1PpHA6VANCRjI+GAEMKRnH3Lr\n I6CG0XuewFF0lgPtSEdYBgdzGOJauAhJyufXB92KW/Rbhbe7l2QaJM5trsu6CSPG0Ghx\n xi4g==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776384001; x=1776988801; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=TT5yf1nbaOpW+KnNXd5fLiEBCUUKgHBYh1jMeLbvfCc=;\n b=aRB65HpgnSVn2VXe96gFxnVg8MQm7t4MKGLPwoLOBRLPXNIv6W1Wd4NXm4EQz1l+Bq\n AQRWVNrrU/GUGIWE8keRs3R9JfzlPNe5Wco/bam2lt64E8lcdc5rjRf69X9AWA6oBDgk\n 6KtGcx2OJYw09egCEGA7/lqHSz/TejNjvUA3c=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776384001; x=1776988801;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=TT5yf1nbaOpW+KnNXd5fLiEBCUUKgHBYh1jMeLbvfCc=;\n b=sFVuXEPZNqFdMOCDu53sD6Y9R24gpHljTDOY+atB0WE7lDEPVPqXRam5AZ7Pt8sNjB\n GnwBiM16d5vIqi9Tv1D8NeJgFylX4dWb/Ei8/036If5oejp1q0h52yO4M4PWMi5jU/N/\n dI0hrQ1OArnYn+tN3W61vluva5ETb+y4+w1Zaagh376YubpcSHBuu9Fw9MK6Qr+Srv8r\n 73UgznsCC2XFF4AM3APMMoC6ktuZdQmkdgDYvysALEfuuUQHUCU32YsbCJGiofYmoM8B\n nExBwt+2NZXKprGVxqah/BBK35g48QmJ89sEMFfHavwOkyMaq6x1WTZFaKWHVPS0C+ay\n RtOA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/b8O/cSukkBtKo4BtfjnjzEiZqjUChEzRXAvpYiLritFo2QAc3YM1ZKlaDpt0ICxekRU+WFW0=@lists.denx.de","X-Gm-Message-State":"AOJu0YwEFTp/6qWHjWi5DRJDImfGbYnq0EOEa+bcmySX++9q/AZYNrbA\n vXjQWkHzoxlJHGuWo3SnUTahinHgEaEEBBnTJ97Mjr2gCyq33GUngfyXz6CLxCICx+Laiuo0DAQ\n IGPmKX+kvzp/WkMr2TusP9tj8LiOMTfv6Ocsdge7r","X-Gm-Gg":"AeBDietP1SwvEnsV34ej79c0/bb/7WEyJOdgvfRCsG6Fd2qhU9Jpx3nSqBRZA1ICGEr\n eVjCSIM/7kPHSlr+L3DmDn1kfF0G1suUQ4db+nOzM+B+x14WblKEDDixVQKQrYdIPvvOMo0pPQB\n sg/xYzOj0Y/xBIZ/JGbSjM2luIoGGvuQ/XlXEpTibqYe2+yUHJ5uAjdrLTgZte+EUa/PYnMPJo6\n dr08TIM4RqQES+U3H524SDHAN41C+lmrmDwW1gMqx6pxZmy8EDLdRU5kPcCpvrnI6HaEUdt5vD8\n aQTTZ6j2cx5NNPaKa70O","X-Received":"by 2002:a17:906:dc89:b0:b98:6926:13cb with SMTP id\n a640c23a62f3a-ba418b7e13cmr29906366b.9.1776384000645; Thu, 16 Apr 2026\n 17:00:00 -0700 (PDT)","MIME-Version":"1.0","References":"<cover.1776302805.git.daniel@makrotopia.org>\n <97e38b81f2e8f54ec819940d360849e4cf61b875.1776302806.git.daniel@makrotopia.org>\n <CAFLszTgazuTSYbidfn7Q1gEiE1RG2YVkj2Vz9L6fN49QE0bdUA@mail.gmail.com>\n <aeFv-xm5MZ44W3Yn@makrotopia.org>","In-Reply-To":"<aeFv-xm5MZ44W3Yn@makrotopia.org>","From":"Simon Glass <sjg@chromium.org>","Date":"Fri, 17 Apr 2026 11:59:48 +1200","X-Gm-Features":"AQROBzD-mT_vwW25qddApvNGxIZJ4io5jI96sHGc4G5BszXnTly4Nc9ShbglbnM","Message-ID":"\n <CAFLszTh3RD86+wkBv=wOm_-ghQssQuymhrnhPMpXsfY8=dnMeg@mail.gmail.com>","Subject":"Re: [PATCH v2 6/7] test: boot: add runtime unit test for\n fit_verity_build_cmdline()","To":"Daniel Golle <daniel@makrotopia.org>","Cc":"Tom Rini <trini@konsulko.com>, Quentin Schulz <quentin.schulz@cherry.de>,\n Kory Maincent <kory.maincent@bootlin.com>,\n Mattijs Korpershoek <mkorpershoek@kernel.org>,\n Peng Fan <peng.fan@nxp.com>, Heinrich Schuchardt <xypron.glpk@gmx.de>,\n Martin Schwan <m.schwan@phytec.de>, Anshul Dalal <anshuld@ti.com>,\n Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Sughosh Ganu <sughosh.ganu@arm.com>,\n Aristo Chen <jj251510319013@gmail.com>,\n Ludwig Nussel <ludwig.nussel@siemens.com>,\n Benjamin ROBIN <dev@benjarobin.fr>,\n Marek Vasut <marek.vasut+renesas@mailbox.org>,\n James Hilliard <james.hilliard1@gmail.com>,\n Wolfgang Wallner <wolfgang.wallner@at.abb.com>,\n Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,\n David Lechner <dlechner@baylibre.com>,\n Neil Armstrong <neil.armstrong@linaro.org>,\n Mayuresh Chitale <mchitale@ventanamicro.com>,\n Jonas Karlman <jonas@kwiboo.se>, Shiji Yang <yangshiji66@outlook.com>,\n Rasmus Villemoes <ravi@prevas.dk>, Francois Berder <fberder@outlook.fr>,\n u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]