[{"id":3678346,"web_url":"http://patchwork.ozlabs.org/comment/3678346/","msgid":"","list_archive_url":null,"date":"2026-04-16T19:38:28","subject":"Re: [PATCH v2 5/7] doc: fit: add dm-verity boot parameter\n documentation","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Daniel,\n\nOn 2026-04-16T01:46:15, Daniel Golle wrote:\n> doc: fit: add dm-verity boot parameter documentation\n>\n> Add documentation for CONFIG_FIT_VERITY which allows U-Boot to\n> construct dm-mod.create= and dm-mod.waitfor= kernel command-line\n> parameters from dm-verity metadata embedded in FIT filesystem\n> sub-images.\n>\n> The new document covers the relationship between FIT loadable indices\n> and the /dev/fitN block devices that the Linux uImage.FIT block driver\n> creates, provides a complete .its example with a dm-verity-protected\n> SquashFS root filesystem, describes all required and optional dm-verity\n> subnode properties and explains how mkimage generates the verity\n> metadata automatically.\n>\n> dm-verity is only supported for external-data FIT images (mkimage -E);\n> mkimage aborts with an error if the flag is omitted.\n>\n> Signed-off-by: Daniel Golle \n>\n> doc/usage/fit/dm-verity.rst | 282 ++++++++++++++++++++++++++++++++++++++++++++\n> doc/usage/fit/index.rst | 1 +\n> 2 files changed, 283 insertions(+)\n\n> diff --git a/doc/usage/fit/dm-verity.rst b/doc/usage/fit/dm-verity.rst\n> @@ -0,0 +1,282 @@\n> +.. note::\n> +\n> + `veritysetup format is invoked with --no-superblock, so no\n> + on-disk superblock is written between the data and hash regions.\n> + The Merkle hash tree is appended directly to the image data within\n> + the FIT external data section. Consequently hash-start-block\n> + equals num-data-blocks`.\n\nThis is only true when data-block-size equals hash-block-size -- in\nthe general case hash-start-block = data_size / hash_block_size versus\nnum-data-blocks = data_size / data_block_size\n\nSo can you update the comment?\n\nReviewed-by: Simon Glass \n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=RjgmiFhS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"RjgmiFhS\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxSxN0F0rz1yCv\n\tfor ; Fri, 17 Apr 2026 05:38:48 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id C359B84227;\n\tThu, 16 Apr 2026 21:38:45 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id B735F8423F; Thu, 16 Apr 2026 21:38:44 +0200 (CEST)","from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com\n [IPv6:2a00:1450:4864:20::62a])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id C64C580086\n for ; Thu, 16 Apr 2026 21:38:42 +0200 (CEST)","by mail-ej1-x62a.google.com with SMTP id\n a640c23a62f3a-b941762394aso1058961366b.1\n for ; Thu, 16 Apr 2026 12:38:42 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776368322; cv=none;\n d=google.com; s=arc-20240605;\n b=XNyYN7pGGd1kN9RzhL4Cui5nu5Y1Ioqj23vVTx0xjNFqCjtGmUebrh93hvosICmVKq\n sTZhoHPO9Pcv7B/b4VW4GhHRRAi+sCX1nZ/MCgUaIKNMbtKs8l9DNxYI33e0GUCXiQy3\n 5q8t0YXN95StKpiHrClw+JFJMVA70GWUpZrkC4kvVKdzEnImiRt+9BBQY1s1WMUTVRcV\n BwIfMmGDzULbcqUH0qI464pfmM3U2JVgQV4oIRNrEKLLlZW237ncYRo5rSlnOxa3Fecf\n 5g3mKMOEVY60JmZr9keKmiUOXeESgpxtwUdHHoy+fPLk0x4/ElOBUFAvr3sFnU+Mnho/\n zEBw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=ZI4YaW1FDpypP7++v1u1/vLNWWSe/BSsd5Qshu7EdxA=;\n fh=yvfB1FrUWTal8ddGB2brur50jnNN6dhwkVnrDw0x1us=;\n b=lPD4T6gzsHc03mlrRSrbhvyA0GgmiVRsa53OSLpF2yX9qDdMLtj8mc1dSRudAYAXtI\n L7vRrjRJizdcWLhbmqSVKU81TRA0n3SL5Em0jHZHyaBG54EgBb53rtu9IbKSJjdt7kBm\n SNlGuSq1dqsl6Lf5gxUb0ujfy4Ikdi5DZ63l3m1y8Ez65eg9f4upMoAnbDvTbFdl2Voo\n mYFEzDdqkaDRhB8IhRmIyi7jH7HfKySE0lm/jZ1CMl3MKxZ71xkRP0/wPjEGpbjpONmN\n 9G4clAZWLnChZDf66x/hCmufOpTb/In+6DCTWzGfiQNp82dbKKXQnGASoGmmUoMQ9zBz\n TLcw==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776368322; x=1776973122; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=ZI4YaW1FDpypP7++v1u1/vLNWWSe/BSsd5Qshu7EdxA=;\n b=RjgmiFhSoKSX8lAXy/HBR+bm3dP7WkFqgKyvrMXRJJJpoEXbyzNoK6rr+VW29pr0+9\n FlDoNJ+qv33Osc/0Jl09fq2yQQ7AQ26dGpEklT7YOM78Ah3V7eAllXLRC7J90QHVZsxA\n 3gk7Ldc4IQSJZmwsgpb43XsJQOyDM3AbqCMgc=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776368322; x=1776973122;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ZI4YaW1FDpypP7++v1u1/vLNWWSe/BSsd5Qshu7EdxA=;\n b=UiAANppK0hPo+1ZBliDwzerNGrcYOs0mVlXPltZ6uoQHb2Vs1laA2SXbRCGl3HBTZN\n vjHIg3TNkVq8OWp9JsiHZI94IKxBuhI1SrhTdx2Y004XuIwayoPjF9GpHZNQtWHNnYKH\n bsepuIW80mbmQJuBCxcfXDdMBSG3JS7VBQ3X9rPVonZLoLzIu/bidVtvGp9sWQgBvIzx\n MbspjByTY1Jk/zatr67Tf9h0o/ji4gBnvAGyPWW0EdjsjS1AqtL4L7ln1AvRhty6PxZB\n BXqk4cQHTxnYya0lDLAHEfs/0TO3gWnV9Av6h6TXZSao/35VLOTaycMSHh4Qsdx0ndvt\n cJpg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9T7kVJ9r0VV/sIUvZjUWCA6xcT2aIzOlN2mWnENpuMH4i0eRiZ4q25lqJENEDX+0QYV5lme/4=@lists.denx.de","X-Gm-Message-State":"AOJu0YzVHECBBgv3SqyxWtoAFiEretUsk70qHGKSkuA9T2/eDCrN2rsc\n kGHYXQRrVVjc7Np7PG+FSKin93/pGIJYWybCZF/iKBfOGloDDeO7Y9kH9wCj0yBG1IGvcYz3fxc\n KeYssG6srDTRLOvP7VAWAEcq4EIbqAB0tZAeyIwI4","X-Gm-Gg":"AeBDieu0YXUYO0XRNhAc1ii9e5fy7WtaIU4Yr5iNEzw9Htz8LxiDAjfCbdP0IY8mnnd\n +V+kPMpaSIcpCDB9CX6wmdQXdKA/I46ldLOIRujwvpnSMjTU91ZBdMZJ7OyeDqKeecwqoMzSQoe\n +JYZSThGOP1bLLBbJiwnI92DY5kkM3hpl9j+d+twe8iguBdhZt7XqgDH3yRaL7Qfla+KqWUHaD8\n mnu4YgD0mYS31/LDu/fCh37fS4RcR30xc8sYUYiBSYRquynZteIQY1QjCOW/v+llWhGYm86txuI\n EG5DdvMaqrAbjtiQbiSl","X-Received":"by 2002:a17:906:4790:b0:b9e:98c:bd29 with SMTP id\n a640c23a62f3a-ba3dbfa8f05mr43352666b.18.1776368322107; Thu, 16 Apr 2026\n 12:38:42 -0700 (PDT)","MIME-Version":"1.0","References":"\n ","In-Reply-To":"\n ","From":"Simon Glass ","Date":"Fri, 17 Apr 2026 07:38:28 +1200","X-Gm-Features":"AQROBzBaZVEFg6RBBVyMzyBOgfoUWor_mYCh5BbZvqiNRmz2h1FvWWkVk4dKXok","Message-ID":"\n ","Subject":"Re: [PATCH v2 5/7] doc: fit: add dm-verity boot parameter\n documentation","To":"daniel@makrotopia.org","Cc":"Tom Rini , Simon Glass ,\n Quentin Schulz ,\n Kory Maincent ,\n Mattijs Korpershoek , Peng Fan ,\n Heinrich Schuchardt , Martin Schwan ,\n Anshul Dalal ,\n Ilias Apalodimas ,\n Sughosh Ganu ,\n Aristo Chen ,\n Ludwig Nussel ,\n Benjamin ROBIN ,\n Marek Vasut ,\n James Hilliard ,\n Wolfgang Wallner ,\n Kunihiko Hayashi ,\n David Lechner ,\n Neil Armstrong ,\n Mayuresh Chitale ,\n Jonas Karlman , Shiji Yang ,\n Rasmus Villemoes , Francois Berder ,\n u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]