[{"id":3677907,"web_url":"http://patchwork.ozlabs.org/comment/3677907/","msgid":"<20260416024324.4039-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-16T02:43:24","subject":"Re: [LTP] lib: New library function tst_get_free_uid","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Wei,\n\nOn Thu, 16 Apr 2026 00:55:23 +0000, Wei Gao via ltp wrote:\n> [PATCH 2/2] open16: allow restricted O_CREAT of FIFOs and regular files\n>\n> This commit adds test cases to verify the security restrictions for opening\n> FIFOs and regular files in world-writable sticky directories.\n\nThe body only describes what the test does, not why it is being added.\nState the motivation explicitly, e.g. \"Add LTP coverage for kernel commit\n30aba6656f61 (Linux 4.19), which introduced protection against spoofing\nattacks via O_CREAT of FIFOs and regular files in world-writable sticky\ndirectories.\"\n\n[...]\n\nRegards,\nLTP AI Reviewer\n\n---\nNote:\n\nOur agent completed the review of the patch.\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Fql+/Mxz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx2Pz4tF6z1yCv\n\tfor ; Thu, 16 Apr 2026 12:43:33 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 07EA73D0284\n\tfor ; Thu, 16 Apr 2026 04:43:31 +0200 (CEST)","from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::5])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 998213CDC78\n for ; Thu, 16 Apr 2026 04:43:27 +0200 (CEST)","from mail-qk1-x742.google.com (mail-qk1-x742.google.com\n [IPv6:2607:f8b0:4864:20::742])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 2F76D600809\n for ; Thu, 16 Apr 2026 04:43:27 +0200 (CEST)","by mail-qk1-x742.google.com with SMTP id\n af79cd13be357-8d68f702851so1140823785a.0\n for ; Wed, 15 Apr 2026 19:43:27 -0700 (PDT)","from\n runnervm35a4x.abeklq3pcfkunev5g5yv1x5cva.ex.internal.cloudapp.net\n ([135.232.232.49]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8e4eed6ee47sm264496385a.10.2026.04.15.19.43.25\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 15 Apr 2026 19:43:25 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776307406; x=1776912206; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=7yZYVQbA3RbOGzDAh5KQnXfn8VESCjq9bf/kOuDXvvo=;\n b=Fql+/MxzFwKBx8pJqYSu8dc9ZALMZmqA8YEnNk10vAcFSJonDBgFr5c+15R444fPxo\n U4Qv/EQnkEccVGnFAzYcW5OTzAbPh3lOevbAGZXD4Mm5+frQy5Uz0fAr1u0G/lNp8Xcz\n WpB41J5QfYd8nqEAXq2x9nF+P6pYO5F1goQwVSbS/DuuYlpJLNCRpcoCI0AaEMSRYX7e\n ui+WOD2LEiYUNWli+HsP2yhAxcApR0yA2uRY+i5l1TEn6GtP6/uW2tDDoKVyjZ/jBFrk\n 15Vi+H2TM+ErDbj9V6lXFQPVfUvyZuq7sh5k6h3/CKckcseog4pmyrvw7nXfV/nXkfpv\n dvyQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776307406; x=1776912206;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=7yZYVQbA3RbOGzDAh5KQnXfn8VESCjq9bf/kOuDXvvo=;\n b=dKtFX2pq8tqJxOKPJzZhzwiCaSNm2xRFwgXLp59OiZmD7DciJfXJswv7nS1L0BU7Q9\n +2Y/TaXT9MrD8zLGx6+5DFVpYUqhSb1a4IuPA0z4LGNDvTudpXBPG1MEe+h6hijue0ZH\n tXPEpP0SMnuaUyiegREbYlKBgYH4Ass1IhjvdSNRLLgvBA/hGpix4bcrUcp//hGJEXpv\n hYy1GzeRWft6R8QEmI0prb4daeuWELcH3bOJyNArptE7ydBB1TTisQ+/BHqhHrl/sCuP\n QqmiN8RmJZ+hldA0GVVIjD2oOR07md7Zi21n1AMUvBZttVm+jMyD7izjZCyurSgL8rby\n 5p2g==","X-Gm-Message-State":"AOJu0YwMRxiPlG2SFk44/zvBvc25CcrSAsM82dD2v+d0cEj8qdP/vG67\n hDeGG3sMwVjaPrNv8lTjYClyK9jeBihJzynIuo6UgRUmcVwLDJdUvFB0","X-Gm-Gg":"AeBDietRMkdprKi11iOh6/uP5+JfHFoiQF712sXkn4Degb0Xh5nDYCrNOum/mWZRyM3\n vseZKVoSxTJ0IAqOG5lt+bc9yq3nwDK4UqGmAneqreCU8wNpMVNU2o7TLkp8VI4aHtEfuZdmnOC\n h17JT8Ka5XtD9RO64U95x3iPfJemblZSUX9qBVYwnXSiX4Pm2OK7RQMoWtwVPxJ4NQBNeMICHgi\n 9GH0iQf2+4T7uE7OFzso4SNG0WQbGce6CwheLbERARvPv7LGwOjJUXS+GcD2M0ohdU9XnDXyPj0\n f8uwtTgpHlpaEMuD7tuPcI2+NxP7B/gsLHglSPm1xb1xdvQbSAzUMTYubI5xn1h9BIsdJCvzZvO\n rBWnKnxIiVPtEFvS78Joax6ioLZpcelMOu39jXUjej4O5I12zDqjBFb7FFV04XxXztShc9ENlMG\n hndDwClStvPI7tsVb3VmH2s9kBmtv2doJfLv6ig7DHG1+VRPLk9GZe+XVK7grJMEIIHJabUSqtQ\n MJfoYKZgHvNcKpZQDKGTZk6jUlOvkZCvWHl/YDt","X-Received":"by 2002:a05:620a:472a:b0:8cf:d516:8451 with SMTP id\n af79cd13be357-8ddd0696085mr3712840985a.62.1776307405935;\n Wed, 15 Apr 2026 19:43:25 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Wei Gao ","Date":"Thu, 16 Apr 2026 02:43:24 +0000","Message-ID":"<20260416024324.4039-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260416005603.22427-2-wegao@suse.com>","References":"<20260416005603.22427-2-wegao@suse.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-5.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-5.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] lib: New library function tst_get_free_uid","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3677926,"web_url":"http://patchwork.ozlabs.org/comment/3677926/","msgid":"","list_archive_url":null,"date":"2026-04-16T04:15:27","subject":"Re: [LTP] lib: New library function tst_get_free_uid","submitter":{"id":85577,"url":"http://patchwork.ozlabs.org/api/people/85577/","name":"Wei Gao","email":"wegao@suse.com"},"content":"On Thu, Apr 16, 2026 at 02:43:24AM +0000, linuxtestproject.agent@gmail.com wrote:\n> Hi Wei,\n> \n> On Thu, 16 Apr 2026 00:55:23 +0000, Wei Gao via ltp wrote:\n> > [PATCH 2/2] open16: allow restricted O_CREAT of FIFOs and regular files\n> >\n> > This commit adds test cases to verify the security restrictions for opening\n> > FIFOs and regular files in world-writable sticky directories.\n> \n> The body only describes what the test does, not why it is being added.\n> State the motivation explicitly, e.g. \"Add LTP coverage for kernel commit\n> 30aba6656f61 (Linux 4.19), which introduced protection against spoofing\n> attacks via O_CREAT of FIFOs and regular files in world-writable sticky\n> directories.\"\nPatchset cover letter and the tags within the test code (which already reference\nlinux-git 30aba6656f61) clearly established the purpose\n> \n> [...]\n> \n> Regards,\n> LTP AI Reviewer\n> \n> ---\n> Note:\n> \n> Our agent completed the review of the patch.\n> \n> The agent can sometimes produce false positives although often its\n> findings are genuine. If you find issues with the review, please\n> comment this email or ignore the suggestions.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lists.linux.it header.i=@lists.linux.it\n header.a=rsa-sha256 header.s=picard header.b=VhduVZff;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256\n header.s=google header.b=WMMys7zV;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx4SD5qszz1yG9\n\tfor ; Thu, 16 Apr 2026 14:15:39 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 854FF3E5DF8\n\tfor ; Thu, 16 Apr 2026 06:15:35 +0200 (CEST)","from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [217.194.8.5])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 310E83C6FD7\n for ; Thu, 16 Apr 2026 06:15:30 +0200 (CEST)","from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n [IPv6:2a00:1450:4864:20::32b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 6087D600708\n for ; Thu, 16 Apr 2026 06:15:30 +0200 (CEST)","by mail-wm1-x32b.google.com with SMTP id\n 5b1f17b1804b1-488ba840146so73826935e9.1\n for ; Wed, 15 Apr 2026 21:15:30 -0700 (PDT)","from autotest-wegao.qe.prg2.suse.org\n ([2a07:de40:b240:0:2ad6:ed42:2ad6:ed42])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488f581b9fbsm20839395e9.5.2026.04.15.21.15.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 15 Apr 2026 21:15:29 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=lists.linux.it;\n i=@lists.linux.it; q=dns/txt; s=picard; t=1776312935; h=date : to :\n message-id : references : mime-version : in-reply-to : subject :\n list-id : list-unsubscribe : list-archive : list-post : list-help :\n list-subscribe : from : reply-to : cc : content-type :\n content-transfer-encoding : sender : from;\n bh=lQpMiFJu3Djn7En1z9CNmEXD4da7dCpeos8yqmbaHlQ=;\n b=VhduVZff9oB4+Zrgky/+bYqp70SLZn2LUz6Afmt+BembEZe9IiMBq4Gqu65Bd1cRAYrsA\n KAKUVx96ZvnTkHuJXb4g0oQaM5GHXu0E+8Abx3KTK2zZ/VsYOLfvmBrPFLIUHwxmvS4+aoW\n mlOSevtr1AQXA1yYzJLR51BMiv4eYco=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=suse.com; s=google; t=1776312930; x=1776917730; darn=lists.linux.it;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=8q44evWtTri6+8R14EiHngj8x2AyDffWx+Xb2SC1edI=;\n b=WMMys7zVSrHt5aoWjYSWE8sImRSqkf5VPKYkkuW19D+uMXUjit4+a7CZgHzxD2+eof\n T2beuAIHCafeX0xPrlr1rupLMfi3eBrj/efQG1SvLmhLdHouIo7ynsatn+RjP6rxGTiD\n jRalvHpcmfGFfREc4AMbYbSthfSKRq2z00lAPjtOZQDNHwvBtmbqWq6kzQuXENLEmZlN\n V6o0L+Edm/+Yk731pby09+w5/+GwCKo9fSNNrLyuldfxmI6/GrdsTXdBKsZLRFtAY+Tq\n r3B4rk1Y2d2HcPhwqoez3+MnGYjxGBj90+1tqrZmuhELfa3OW/Gwbdjs1/viFT+DHD0r\n Eyyw=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776312930; x=1776917730;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=8q44evWtTri6+8R14EiHngj8x2AyDffWx+Xb2SC1edI=;\n b=i6SeoYNmXq1ZMRnHsM6ZHouH7/sqlFToC9Akvk/loy48NX4pElG/+Oa7U8onbpWVwT\n Enpjc4TSN/zSBVd6t43ZKpNRqHZaSohvjFJzfrFyiiThuq/hWT3UR+ZNuGrkHiN6s65X\n yfIH4qvwNBejPemho9KnCKS93yksgFsVHElH+7X7USXuXhYiR0vpO+i7SaQrdGhP5ifr\n zdFZBhgF5fBIIbOwDSyzsZvWJoSzl6ElCMrzK3qntGsf69VnhOnswCNZCXB2EFrxW22W\n LRLckM+FqebQnv/VtoOmhp5B3v9eLwUcW1HCCUXU+yM+wtBRmMRPBSAV8g1Ax8jQ/6JO\n WDFg==","X-Gm-Message-State":"AOJu0Yy996Mwn6+7dqfYZ84Z1DgJIR94bkyxnw2UP5J9dnuSPMY/3NCN\n Tl+VGM4SQ5/vLQsavLKI1ySAp4pIjEre8Ne9ZYLp3SQ2VMkFRrNTKrNhsoIZTKzGdg==","X-Gm-Gg":"AeBDieuj3SAAB71wrPOOY/zgOgtRIvoDlVGLLgDQe5IPj8qVFLcWYJpPdWrAB8onXnO\n MvfQoox6Z7LD0JfOlcePwHjtyRW7dFSB0cQXpXjH5B4EbAR3/8mSdDyksuVsxr99M3HNLMxCS8D\n IychtJC1O6whGa0fzJXe5iuZAJKuqo6b6B1hx+mSlsqr7WQnQ0/TPNydCaSe+tkLZ8owWN0A8TW\n cR0ZyDDjpxw0iiZ9qhOkBFZZ777IqXLH8rf6xKtUR7IRyuwvgiJYW02P7CbM4tlY2mgtpmv6e+A\n o875kXTR5Rltse6fhhpEEXGwPZ1sb3Hm7QMBw/MV2jOoDS3EcPPMlLdOhUjegFtHvLxeC3kRFmG\n cTBYdNSaBkV4rIojQRrdDzMA3a+XTomd8vHyMPMeczowOoki7W52R9n5QduQCnJn1jEXalKkkuK\n iETkrIwwUL9kG3cPfsXs78I7MpBalNfjlLG86kXSAT","X-Received":"by 2002:a05:600c:c091:b0:488:a977:8d6 with SMTP id\n 5b1f17b1804b1-488d683662cmr240351205e9.19.1776312929685;\n Wed, 15 Apr 2026 21:15:29 -0700 (PDT)","Date":"Thu, 16 Apr 2026 04:15:27 +0000","To":"linuxtestproject.agent@gmail.com","Message-ID":"","References":"<20260416005603.22427-2-wegao@suse.com>\n <20260416024324.4039-1-linuxtestproject.agent@gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20260416024324.4039-1-linuxtestproject.agent@gmail.com>","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-5.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-5.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] lib: New library function tst_get_free_uid","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Wei Gao via ltp ","Reply-To":"Wei Gao ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]