[{"id":3677873,"web_url":"http://patchwork.ozlabs.org/comment/3677873/","msgid":"","list_archive_url":null,"date":"2026-04-16T00:11:38","subject":"Re: [RFC PATCH v5 3/6] target/mips: Convert MSA LD/ST.H (Halfword\n Vector)","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/16/26 06:20, Philippe Mathieu-Daudé wrote:\n> @@ -813,6 +824,15 @@ static bool trans_msa_ldst(DisasContext *ctx, arg_msa_i *a, bool is_load)\n> tcg_gen_extr_i128_i64(d0, d1, t16);\n> }\n> \n> + if (mo_endian(ctx) != MO_LE) {\n> + switch (a->df) {\n> + case 1:\n> + gen_bswap16x4_i64(d0, d0);\n> + gen_bswap16x4_i64(d1, d1);\n> + break;\n> + }\n> + }\n> +\n> if (!is_load) {\n> tcg_gen_concat_i64_i128(t16, d0, d1);\n> tcg_gen_qemu_st_i128(t16, addr, ctx->mem_idx, mop);\n\nYou've just bswaped the architectural registers.\nYou need new temporaries here.\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=L9KtyEpR;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwz3G4yqVz1yCv\n\tfor ; Thu, 16 Apr 2026 10:12:10 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDAKj-0001ok-QS; Wed, 15 Apr 2026 20:11:49 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDAKj-0001oa-0v\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 20:11:49 -0400","from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wDAKh-0000tW-DR\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 20:11:48 -0400","by mail-pj1-x1033.google.com with SMTP id\n 98e67ed59e1d1-3585ec417f6so28261a91.1\n for ; Wed, 15 Apr 2026 17:11:46 -0700 (PDT)","from ?IPV6:2401:d002:dc0f:2100:31f2:aa94:4389:37f8?\n (bg30dhzr9yyk68wp6s9g.ip6.superloop.au.\n [2401:d002:dc0f:2100:31f2:aa94:4389:37f8])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b4780ef41esm42660205ad.6.2026.04.15.17.11.41\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 15 Apr 2026 17:11:44 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776298305; x=1776903105; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=8lAjj0P5dQkTvz4hRuiYe6p8xpnhcy//4+/EqexHIxY=;\n b=L9KtyEpRf8ph+JmpdrKD/6mwgB6kXUVhHlWwA8yXxuMEEkqb95BXqr7zfEageNf2bP\n O0pXMQ60BKTZTDOzde4zBKqKzR4FdKec979sLU053FIc3uM1o8baHV2Nen8PWixgcW6H\n nBzvMEEOewTVF3dmSOU3J0SMsXwV5jaxyFdmTswet8Us5RKZ79OEPsL0Yimp4RoW/Z5e\n JY8dd+C/RdbU4xcyJsG+nSDz6T8Sd8fDT4vsa37fFKzSHzDZclapEHlkUicoTK2BagkV\n YVsPcVO9ivktdAsj6yj7bAF33zs0pGUzrBABl8B3350nU1dO8qfhBsC11mahwTqKVYDf\n eGOw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776298305; x=1776903105;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=8lAjj0P5dQkTvz4hRuiYe6p8xpnhcy//4+/EqexHIxY=;\n b=hZaz5lSsiyG0Exc5mPGowI+gl9AuV3+TxSthJW8cf9FVoRQvqwJ4lph+hrQEjRPgBa\n 50ZWMZOYTxKXs7wEcuvedls6hAdneBjnlEI06yQ3kkD++FhvMUaBU3Ug44Uutw8sNttt\n KOzgXpMPjpj1knz/r+nIU4IjOWiOQinbvqRDoDtibY5ROUuWFXuPHx/MQ3eQ3Q1sNhvm\n LY0cPRzEYOaezlE89tfAbJY8/SHnO8qGUOqCLRsqmC5U/qPfOV2F08HeSIRZ7ZxMCqRL\n jWXojoWP2GZl1xTYx0Ho1o6Jb7DrMgAPmrjrt3b/9lcd3OQNejwIuegDxuCYwbRYAcwG\n tJ/Q==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8N95Gu043y6ir97e9o+YbHIDYs2RQMPaZU3nstVdZixNxb5erY9iBBuq6m7OjFPVg6U2+2oAFwW2Jy@nongnu.org","X-Gm-Message-State":"AOJu0YxmfhiFEE+2vWJQyqguIDdNa2yyJW1zltIyqVMWij3mFLZ79W2U\n /hh5gdOk275Xkz6/IqWSQm6GZYFcL+2y6JEkozattR+ETfWxLXfOhtIsS8fTpHZ7hZU=","X-Gm-Gg":"AeBDiesYLilP8f6cCA2CY7lgvrj7jNw5+xDfaJJMWx+RxhH1e55C1zTRmBIjB4i/QNf\n aMv/YGzTidandDXwE+Np9oi9j9D+Cve6fRrgoz5H/osWt5qw0e7yjEjVPzdCW8/qYooGPlxv5tw\n tfaPPSt+LOVVNwulm4P5uaKDb+8bYuT+UePpqFI+UOxmFjTvnx/l1IUtVrn3xhQJkOzO5kQyLFW\n w42DZbW5HgOL33+cfnE8zcp/iVE8TqbxpYj6o440vbjrwNP1UfRxf8SxhOtaOCgvSELZqlnjY7K\n 9LvQWfdpCx03W5sCzZM5yGEOg+f/Woj2zp2auNsLxeidoSirT2TCcV7qC1dGsO/mIdElWX50YWV\n ReqE9yr9HJabjHadZEfwO6TSC+t6UuU07RzkouJQ6lEV2HCxrol33f0fuqSSk/alD38q3oriJb5\n fNDye+AgTm7L5yvNWjm6SiXJBGi98QbbROdMgj325FAadh4pb/q8JpRiovmEoqrCY5tOYKNMTY5\n 7gJ9H4XB38MOsvam1ixYH109vfVBvMfCgRCi1+t2kC5PCEmZP3Vrfv4ptzw9uDud7VUeFjKdbZY","X-Received":"by 2002:a17:90a:d60d:b0:35f:c6bf:2bba with SMTP id\n 98e67ed59e1d1-3612f326a3bmr1259662a91.11.1776298305162;\n Wed, 15 Apr 2026 17:11:45 -0700 (PDT)","Message-ID":"","Date":"Thu, 16 Apr 2026 10:11:38 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [RFC PATCH v5 3/6] target/mips: Convert MSA LD/ST.H (Halfword\n Vector)","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"Jiaxun Yang ,\n Aleksandar Rikalo , Aurelien Jarno ","References":"<20260415202027.83008-1-philmd@linaro.org>\n <20260415202027.83008-4-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260415202027.83008-4-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::1033;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1033.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3677874,"web_url":"http://patchwork.ozlabs.org/comment/3677874/","msgid":"<78385610-428c-4315-b99e-711ddfe8b01c@linaro.org>","list_archive_url":null,"date":"2026-04-16T00:12:38","subject":"Re: [RFC PATCH v5 3/6] target/mips: Convert MSA LD/ST.H (Halfword\n Vector)","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/16/26 10:11, Richard Henderson wrote:\n> On 4/16/26 06:20, Philippe Mathieu-Daudé wrote:\n>> @@ -813,6 +824,15 @@ static bool trans_msa_ldst(DisasContext *ctx, arg_msa_i *a, bool \n>> is_load)\n>>           tcg_gen_extr_i128_i64(d0, d1, t16);\n>>       }\n>> +    if (mo_endian(ctx) != MO_LE) {\n>> +        switch (a->df) {\n>> +        case 1:\n>> +            gen_bswap16x4_i64(d0, d0);\n>> +            gen_bswap16x4_i64(d1, d1);\n>> +            break;\n>> +        }\n>> +    }\n>> +\n>>       if (!is_load) {\n>>           tcg_gen_concat_i64_i128(t16, d0, d1);\n>>           tcg_gen_qemu_st_i128(t16, addr, ctx->mem_idx, mop);\n> \n> You've just bswaped the architectural registers.\n> You need new temporaries here...\n\n... for stores.\n\nHit send too soon. :-)\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=HFOrJ4/r;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwz4J64ynz1yCv\n\tfor ; Thu, 16 Apr 2026 10:13:04 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDALk-0002Dg-GH; Wed, 15 Apr 2026 20:12:52 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDALj-0002D8-2Z\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 20:12:51 -0400","from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wDALh-0001MA-J2\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 20:12:50 -0400","by mail-pf1-x42e.google.com with SMTP id\n d2e1a72fcca58-824c9da9928so5029119b3a.3\n for ; Wed, 15 Apr 2026 17:12:48 -0700 (PDT)","from ?IPV6:2401:d002:dc0f:2100:31f2:aa94:4389:37f8?\n ([2401:d002:dc0f:2100:31f2:aa94:4389:37f8])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82f6728d5d3sm3295571b3a.25.2026.04.15.17.12.42\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 15 Apr 2026 17:12:45 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776298367; x=1776903167; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:references\n :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to\n :cc:subject:date:message-id:reply-to;\n bh=wMgAftakz2omrM8BeDe7Pp1M+j/gpq6X/8IIrlphNO0=;\n b=HFOrJ4/rP9qtgLeIvgNaka7zsbKlMvJJLB1yuOD1E8qhI6MB6cBRWPTfg439WI75aw\n HQAZUZqgO1b6warwU7PnbCjwvTgT0Uy6X9pgZAfGUM8VcG7Ry/sEYLlB7uMmYLLPkZse\n N5WhOC/WIjbsDWZZ1b9KJ+FUy5vaazA2HX7XW3HsLbNwi0wHTfmyV+3beHIsUlNGuHJm\n sqoJg4/1jMOv9X9YEVszmSg165PdKyK7Ot6kVnW9daIweBwsLkeKZoU9NbkOLkzDSZMi\n 4V/aUdEYVaL6PJ6YR+/Go1txeCODd48htcGGMhSuaUATWLf0SLb8x2yLaRaaz14ExhkX\n BKDw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776298367; x=1776903167;\n h=content-transfer-encoding:in-reply-to:content-language:references\n :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=wMgAftakz2omrM8BeDe7Pp1M+j/gpq6X/8IIrlphNO0=;\n b=Ve4Opp2jeO7x+lyFpjL+F7AYt7hfxci0hP3+Akmv+B7NIMSdXpy35x1Uc/E3/3kp1s\n mb/wrufTBSiIAHeWKkWDzoRclCfV9+/1FHji0Kh4tScd11AokGWuBSX++XdvUEootyTr\n ZFUo7Ua9pQAZO/yLPFMG9sBkHjOuPF1sjnlA5Rv7BmiuQT8T4YT9ao+kfjBdhVpOR2v8\n Qf3tbI7M4RDQLNF45p9ZzCOfiH3xCktR6yJ0euHQy5Sh7pmvsBiVteMVzYOlDeRe3bh+\n cKvRW2xOMlv6fPIDNZ5VKAEXLk2UDaKIfrLv4nR2IXQPybTiky+waFf3T80RdZcbsy64\n Uj+Q==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+uUIsoboxqr/6SSbsXuByAKMG+BFNdxYDFdlwwkSPS+6y6bqZ3hHPqNiJqZs8FIMPl/V4h3emp9dvW@nongnu.org","X-Gm-Message-State":"AOJu0Yw3Wuhxh7XjxyZUi+WSBbVJC9wn2+zboXs0wTcrNIvvitJi/L4J\n 0F4i+PALCJTp6nChx5KzGO0VOMThMddbxl+X/QJWdkvRq75h9S4HO/4QR329ghnQIYo=","X-Gm-Gg":"AeBDievdt4J2tLGlAux6kVdw0pnf8Jt9aWq6HPVVYwcSZu3gtOCgOw0SgiXHSipylTV\n BwGSQqm6dcgjXwEGKAywAqONfogsApZAOXuqTttuDhWD9moABd6+Skaq/yrzkFkR1UuttVuBRiW\n fXuULiJ/45d/M9avkGy/w656fpiff3Q4E6Tkv9TZqL/m1wR5o1BBm4DgHkfCkigiSxLWK8CMFSl\n uhIlxCUyEC8+GCtZPD6/DyJpg6fB9S+CRnOKEwdOR+LVmCJVmIss+Lq8SjmZSYxBpUVdmti6PUz\n W86S71KrurP1U+8h9y1AnzD1v9TknYWbhvUtS2JjM+GpIBEJOeIoSMNcYyExWoaVilNOBTYt3sY\n 4yxv8HntsErbxNYxwGRbSW7LbN9j6Ew/cjMjl9ECYIz4GZV5ZmKSVCRGBzIWMSa/THtpcZok2UM\n OLRHRFRt2XVohnFzuNbW5qFJRiNX/mPFSqGu18drQs6vXwCFfSFkYXSMyFfAOJgoSsBn99Sjkmy\n uqUOSy1q5RFePbaQemhZt56","X-Received":"by 2002:a05:6a00:1805:b0:82f:7703:2ca5 with SMTP id\n d2e1a72fcca58-82f770339bemr1186423b3a.52.1776298365874;\n Wed, 15 Apr 2026 17:12:45 -0700 (PDT)","Message-ID":"<78385610-428c-4315-b99e-711ddfe8b01c@linaro.org>","Date":"Thu, 16 Apr 2026 10:12:38 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [RFC PATCH v5 3/6] target/mips: Convert MSA LD/ST.H (Halfword\n Vector)","From":"Richard Henderson ","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"Jiaxun Yang ,\n Aleksandar Rikalo , Aurelien Jarno ","References":"<20260415202027.83008-1-philmd@linaro.org>\n <20260415202027.83008-4-philmd@linaro.org>\n ","Content-Language":"en-US","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::42e;\n envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]