[{"id":3677868,"web_url":"http://patchwork.ozlabs.org/comment/3677868/","msgid":"","list_archive_url":null,"date":"2026-04-16T00:04:44","subject":"Re: [RFC PATCH v5 1/6] target/mips: Expand TRANS_DF_iv() macro for\n MSA Load/Store","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/16/26 06:20, Philippe Mathieu-Daudé wrote:\n> In order to ease the conversion of MSA Load/Store runtime\n> helpers to translated code, expand the TRANS_DF_iv() macro.\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> target/mips/tcg/msa_translate.c | 59 ++++++++++++++++++++++++++-------\n> 1 file changed, 47 insertions(+), 12 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~\n\n> \n> diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translate.c\n> index 82b149922fa..2e1a769e032 100644\n> --- a/target/mips/tcg/msa_translate.c\n> +++ b/target/mips/tcg/msa_translate.c\n> @@ -164,7 +164,6 @@ static inline bool check_msa_enabled(DisasContext *ctx)\n> return true;\n> }\n> \n> -typedef void gen_helper_piv(TCGv_ptr, TCGv_i32, TCGv);\n> typedef void gen_helper_pii(TCGv_ptr, TCGv_i32, TCGv_i32);\n> typedef void gen_helper_piii(TCGv_ptr, TCGv_i32, TCGv_i32, TCGv_i32);\n> typedef void gen_helper_piiii(TCGv_ptr, TCGv_i32, TCGv_i32, TCGv_i32, TCGv_i32);\n> @@ -175,9 +174,6 @@ typedef void gen_helper_piiii(TCGv_ptr, TCGv_i32, TCGv_i32, TCGv_i32, TCGv_i32);\n> }; \\\n> TRANS(NAME, trans_func, NAME##_tab[a->df])\n> \n> -#define TRANS_DF_iv(NAME, trans_func, gen_func) \\\n> - TRANS_DF_x(iv, NAME, trans_func, gen_func)\n> -\n> #define TRANS_DF_ii(NAME, trans_func, gen_func) \\\n> TRANS_DF_x(ii, NAME, trans_func, gen_func)\n> \n> @@ -758,25 +754,64 @@ TRANS(FTINT_U, trans_msa_2rf, gen_helper_msa_ftint_u_df);\n> TRANS(FFINT_S, trans_msa_2rf, gen_helper_msa_ffint_s_df);\n> TRANS(FFINT_U, trans_msa_2rf, gen_helper_msa_ffint_u_df);\n> \n> -static bool trans_msa_ldst(DisasContext *ctx, arg_msa_i *a,\n> - gen_helper_piv *gen_msa_ldst)\n> +static bool trans_msa_ldst(DisasContext *ctx, arg_msa_i *a, bool is_load)\n> {\n> - TCGv taddr;\n> + TCGv_i32 wd;\n> + TCGv_va addr;\n> \n> if (!check_msa_enabled(ctx)) {\n> return true;\n> }\n> \n> - taddr = tcg_temp_new();\n> + addr = tcgv_va_temp_new();\n> + gen_base_offset_addr(ctx, addr, a->ws, a->sa << a->df);\n> \n> - gen_base_offset_addr(ctx, taddr, a->ws, a->sa << a->df);\n> - gen_msa_ldst(tcg_env, tcg_constant_i32(a->wd), taddr);\n> + wd = tcg_constant_i32(a->wd);\n> +\n> + if (is_load) {\n> + switch (a->df) {\n> + case 0:\n> + gen_helper_msa_ld_b(tcg_env, wd, addr);\n> + return true;\n> + case 1:\n> + gen_helper_msa_ld_h(tcg_env, wd, addr);\n> + return true;\n> + case 2:\n> + gen_helper_msa_ld_w(tcg_env, wd, addr);\n> + return true;\n> + case 3:\n> + gen_helper_msa_ld_d(tcg_env, wd, addr);\n> + return true;\n> + }\n> + } else {\n> + switch (a->df) {\n> + case 0:\n> + gen_helper_msa_st_b(tcg_env, wd, addr);\n> + return true;\n> + case 1:\n> + gen_helper_msa_st_h(tcg_env, wd, addr);\n> + return true;\n> + case 2:\n> + gen_helper_msa_st_w(tcg_env, wd, addr);\n> + return true;\n> + case 3:\n> + gen_helper_msa_st_d(tcg_env, wd, addr);\n> + return true;\n> + }\n> + }\n> \n> return true;\n> }\n> \n> -TRANS_DF_iv(LD, trans_msa_ldst, gen_helper_msa_ld);\n> -TRANS_DF_iv(ST, trans_msa_ldst, gen_helper_msa_st);\n> +static bool trans_LD(DisasContext *ctx, arg_msa_i *a)\n> +{\n> + return trans_msa_ldst(ctx, a, true);\n> +}\n> +\n> +static bool trans_ST(DisasContext *ctx, arg_msa_i *a)\n> +{\n> + return trans_msa_ldst(ctx, a, false);\n> +}\n> \n> static bool trans_LSA(DisasContext *ctx, arg_r *a)\n> {","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=MQ7gGXti;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwyvj6QwZz1yHP\n\tfor ; Thu, 16 Apr 2026 10:05:37 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDAE5-0008Rg-OI; Wed, 15 Apr 2026 20:04:57 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDAE3-0008RQ-Sf\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 20:04:55 -0400","from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wDAE1-0005v1-Ss\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 20:04:55 -0400","by mail-pj1-x1030.google.com with SMTP id\n 98e67ed59e1d1-35fc0d7c310so2114097a91.1\n for ; Wed, 15 Apr 2026 17:04:53 -0700 (PDT)","from ?IPV6:2401:d002:dc0f:2100:31f2:aa94:4389:37f8?\n ([2401:d002:dc0f:2100:31f2:aa94:4389:37f8])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-36132d0157bsm194535a91.15.2026.04.15.17.04.48\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 15 Apr 2026 17:04:51 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776297892; x=1776902692; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=dXNuO8b4QLN2kjc/aihzSjn++hkaps0Hdvi3LAgHxXk=;\n b=MQ7gGXtiT4BcuALr/iIdbABsoXJyPi/3VXNmPlVgxynf4Dnn7horX+XMZaWU4LZ81B\n kanzMN6v8TakslhOYhp5ZYed49zkRFGJO9TVqFUAAicmnCRVBCjkhI71dcjrIrGfEakT\n vJMxdRP66To8/cvAGTKUwkk2bt1kmt5pJtuLE7ne6T18xHbpIeFWdMZFsfORdSRMaGqq\n tdtHBDOp2nASKWBWvyffVtReVXmIy6A91mSaMcoKbz6Fy1Xe/tHQsv4fN9R9iYv6y51A\n AUxFSeTnINoqhWJHThqOqPMYHmB3VVf+q6MBpp4aIvynZq2lblNrjvJLYCSQy8ibkc/6\n 6qMg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776297892; x=1776902692;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=dXNuO8b4QLN2kjc/aihzSjn++hkaps0Hdvi3LAgHxXk=;\n b=DE9pxdmWF0touIcJ/pD37OQvIx0GLdWV+LtAvQI11jWyoX0lsgFI8Bxc5w3hJS7hGr\n qMSQ6UyChI5Lvvz0/pC8FEbcVypYmg8u5lNpriaVmvLFkfXZiMLrba9sw5czsgQkz+je\n 7AzgGsxj41Z6oq5lV5NwCPBLL+rPMuIgMzwYOAqVZZm4ibm36j4d3fsJRDZ2R3u/rBDG\n mNn08rbR04PvRLcGK3z3DBQ7jSnaqelmQ1V9c0gRSXIlwqou/alMhahRTvHk+imbxikg\n 0bBUhnVN9j0kKFZFiSLpZvk6UlQ2zplHo/Eb2WMaUDGmWwBh4DB4SbnqYCmYy77mLwrf\n wvIg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+nP4ilI6LPFx5F+P2sUCF4vKrvLjBxQ2LgNUDGtoVPrIXNXqgNSdTZUhvEg+cCoQbIL4OdXH8Fyuq3@nongnu.org","X-Gm-Message-State":"AOJu0YwAsxhtob/wv6+l/8wLB4Vl0o0XOL8CfyEE0Rh6zqsbN/BdCF8Z\n KboDuyHPTiA4k8ClsImhqzKWqsUKHDmqMhHUqfwUcMc43F+gMdBMXk28oEIy4Ayrz+A=","X-Gm-Gg":"AeBDiesNyOGBnv4xshWmImfWBnadz3/iErVdwt44MQzAe2WSjQtX6TQ16ZPHy+KDdi3\n 8woQTo28tvj2lv/f9wqAXsFWDQpGXYVqmjLy6+dhSyUfK0mytsAuh6IVhbj4q7wu7OLrEwRndwy\n 65Lqut+jxbN5e9y5kNu597lhnXBWE2Czb3BhUA+MhKiakTy8tP8vXiLvmSuZrZDs77NsDpKHu2l\n z770SpdIs2yvj8tbGEQU32OCtBGF8w5j0GKLgYL01xMixVom6pdL9EkUO1uA3Id1fGFHbeWYrMv\n ih7ZPgmisLTy0jMYolWDXTgYC3hRIbXeZxKEwOTw1iEYPav5+5P6ju+671qlU0fNkreil6kqQfW\n Oc+YRJ7I0LT2Kq8OoSwNOlQUcDajmH+00CvBv2Ku3z7H4jM4JA2e4Rj/H0gG3qCjM+vbJbD8hT6\n yVk+htR9GZtV/FL9jh3uwQvdxgj5hKl982u/EQD+ww+Y7CLwc5xojCIJJ7KePwXKFaNuYMAtfYw\n CfbOLWWDQLR7FAW9Az+BWXU","X-Received":"by 2002:a17:90b:4ac5:b0:359:fdc0:4621 with SMTP id\n 98e67ed59e1d1-35e42786883mr26217354a91.11.1776297891704;\n Wed, 15 Apr 2026 17:04:51 -0700 (PDT)","Message-ID":"","Date":"Thu, 16 Apr 2026 10:04:44 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [RFC PATCH v5 1/6] target/mips: Expand TRANS_DF_iv() macro for\n MSA Load/Store","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"Jiaxun Yang ,\n Aleksandar Rikalo , Aurelien Jarno ","References":"<20260415202027.83008-1-philmd@linaro.org>\n <20260415202027.83008-2-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260415202027.83008-2-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::1030;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1030.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]