[{"id":3678321,"web_url":"http://patchwork.ozlabs.org/comment/3678321/","msgid":"","list_archive_url":null,"date":"2026-04-16T18:51:05","subject":"Re: [PATCH v3 3/7] test: cmd: add unit tests for part command","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Dario,\n\nOn 2026-04-15T18:31:27, Dario Binacchi\n wrote:\n> test: cmd: add unit tests for part command\n>\n> Add unit tests for the 'part' command, specifically for the 'number',\n> 'start', and 'size' subcommands.\n>\n> These tests establish a baseline for the current partition lookup\n> functionality by name. This foundation will be used by subsequent\n> patches to extend the command, ensuring consistent behavior as new\n> features are introduced.\n>\n> Signed-off-by: Dario Binacchi \n>\n> test/cmd/Makefile | 1 +\n> test/cmd/part.c | 161 ++++++++++++++++++++++++++++++++++++++++++++++++++++++\n> 2 files changed, 162 insertions(+)\n\n> diff --git a/test/cmd/part.c b/test/cmd/part.c\n> @@ -0,0 +1,161 @@\n> +#include \n> +#include \n> +#include \n> +#include \n> +#include \n\nPlease include and use CMD_TEST() instead of DM_TEST().\nThis places the tests in the cmd suite rather than the dm suite. See\ntest/cmd/hash.c for an example.\n\n> diff --git a/test/cmd/part.c b/test/cmd/part.c\n> @@ -0,0 +1,161 @@\n> +static int dm_test_cmd_part_number(struct unit_test_state *uts)\n\nWith the change to CMD_TEST() please rename the test functions\naccordingly, e.g. cmd_test_part_number().\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=MVIhZxH5;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"MVIhZxH5\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxRtz1BPkz1yCv\n\tfor ; Fri, 17 Apr 2026 04:51:39 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 3678984228;\n\tThu, 16 Apr 2026 20:51:36 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 175128423F; Thu, 16 Apr 2026 20:51:35 +0200 (CEST)","from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com\n [IPv6:2607:f8b0:4864:20::1029])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 92DE184223\n for ; Thu, 16 Apr 2026 20:51:32 +0200 (CEST)","by mail-pj1-x1029.google.com with SMTP id\n 98e67ed59e1d1-35fb166b0c6so544433a91.0\n for ; Thu, 16 Apr 2026 11:51:32 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776365491; cv=none;\n d=google.com; s=arc-20240605;\n b=L3kYlNTOb8+CLw+vttwNpXLknHTR46xdLhqLEoVuY2brZruzcnVn2XUBcWkWDubbHY\n PXoVoCbGAjV6E/MUmnR5Qdrp5r8/MwYSsHqDhmu+CuFIjVjhu/yx4hAiBzY2wVdWFMWp\n sEnGiT8dm6ptLZHLYGH6fHu9gWwU20+uWi4OuaMp85xpoCFyTX7Z6OjLnsesuHrEWtjO\n cewJgqHfm1ec7GBggvxVYpKyaucqdtFAZ++mcqzzGvdW8ZQiZPPbl/f6SpxcTbbMcKyC\n Wyw0p5pMC89gnFoBCfBJuypsWxTvI6pHvB5EsxVgbvohJ3exvDbmCFbLlDBxwtgRBaPv\n wyyg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=78kCEmVn4JPYRAoPo2yqphjtySONlr++xa0fR6PjN7c=;\n fh=s9Lt3w64TAkHKFDbt+9kT1Eei+RajGoFuxA1RXbRw0E=;\n b=Uhf9YqW6pWkmKgCIbrzh0roLg66DYkljeRyEXi9kRFxJ3/f0LPpBONTgC7qxmFgeAn\n cgoBtd2XeN2T4KiO2ir1TJ7C2WA9cgp13/wC/379mrcuNay3YSebWgzhG3HqSIKHlQIK\n dqzymjJXcFnSBRKG/s/tZrDloxaYIsZZtUgWFEMFdrNFHLgA2DUoPmct2/iT7dT/jrFb\n hPT5/fOXr4R0xBnGkQ+icvyufBpjuhKJFZVlpm0dmQEsCUbvMnolbxNQXiSCKDfgsPW/\n ZJ4GIzZode5XENrB26r9FQprDOS0OUkZGSUkKnwMYOcqiFRHRw0c6FUpaqQI/v2ZjuEP\n gerw==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776365491; x=1776970291; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=78kCEmVn4JPYRAoPo2yqphjtySONlr++xa0fR6PjN7c=;\n b=MVIhZxH5XQ6gbSe363xD2+M2Bdwy2NHsby0sTeUy6uUC5yXeWxx2HGlX2pmUVf/MHS\n J6/vHbsyc0QbphjMV89SlIzfoMUP6ofENCHqdmA6tZz+R+qYZQw/ALYZkt7YuGDDd8eN\n /qKHcWIwcy9UkMSzbp4b3maiqv8If+bxjSH+4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776365491; x=1776970291;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=78kCEmVn4JPYRAoPo2yqphjtySONlr++xa0fR6PjN7c=;\n b=YjLv0zW/6il+dJMVKqWbk6pkmP4kNJJK62GFw142q3GrmPFctBZrtesuiy7CU/adgg\n yQFRTfroXOkbfDXdG/OSkA2d70Y/rF+CFPKMlXvuMI03QAyntLP7Xj4pFzu/4VvgxgaX\n LfPrB4JV48iqzTrs/TtzcoLGWRj3tF2hlu/XXy7epedVMfwq1+AO/A18x7Rnm6MdQTla\n In0m+Fftf7jwSvTzbSrTiDhA3luRzStj7A2tS81DxouGJ1+WMOOiguoalazw2rYrHbiH\n mFyHmm2ep3d04jiQCBPRTH4/UY8BK3pUdtheKIYMtl8Ry9Du4tUJCK7HrSo38TGNhbKa\n HfGA==","X-Gm-Message-State":"AOJu0Yxo465Sc48+NmIIcmhJRGP7EYj2X/ua/dJjjoRTg7gWx+KULV0x\n ialGfY3RVn+M3pW1PzV8ID3vZvAIfJs2mce0EhIVrsKF+Fsc+G88qzLybHX3/c8Yn4JL2Ftq3xT\n WnqawtaaOVZtstnyGIu0ejYM8LJiIvWRhi0wjheLl","X-Gm-Gg":"AeBDieuxzgfm/SMVhCU4WxImAMZHMrC2jdQeav4jwBHjcE1ZRGWJOLkdNLLvRdjEcVG\n +xgYQ+5f8SF5yDCtJdIJQYg2rzalrn9HtdLB+Odbem4CrNm+1rS4pQD48IB1+f9kgJEIMoNiLYC\n doKvD5U7OeG+HBtniKu89JymlCZbeocDjEa37RN4uaclqraLm4+U1LeA9kIFtsxBLjjsYm+s21+\n ChM+64Jsy5DddhhSUXilq95OcXlMU/PrguEpy1k202yUDQ2f/e4jUsJ+WpXRODn2s8GDHN6AaiK\n Vm0i6/15CRvHCslAbL4y","X-Received":"by 2002:a17:90b:390b:b0:35d:aa02:d776 with SMTP id\n 98e67ed59e1d1-3613e212386mr354480a91.2.1776365490788; Thu, 16 Apr 2026\n 11:51:30 -0700 (PDT)","MIME-Version":"1.0","References":"<20260415183250.3031030-1-dario.binacchi@amarulasolutions.com>\n <20260415183250.3031030-4-dario.binacchi@amarulasolutions.com>","In-Reply-To":"<20260415183250.3031030-4-dario.binacchi@amarulasolutions.com>","From":"Simon Glass ","Date":"Fri, 17 Apr 2026 06:51:05 +1200","X-Gm-Features":"AQROBzC2NKQq66PN5C2-EwMXMJ9Ve3cfdJ1-1C1T9KGV3PzE1BtuIfu0n_zavFs","Message-ID":"\n ","Subject":"Re: [PATCH v3 3/7] test: cmd: add unit tests for part command","To":"dario.binacchi@amarulasolutions.com","Cc":"u-boot@lists.denx.de, linux-amarula@amarulasolutions.com,\n Dinesh Maniyam ,\n Heinrich Schuchardt ,\n Marek Vasut ,\n Simon Glass ,\n Tom Rini ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]