[{"id":3678349,"web_url":"http://patchwork.ozlabs.org/comment/3678349/","msgid":"<20260416194234.GA258343@fedora>","list_archive_url":null,"date":"2026-04-16T19:42:34","subject":"Re: [PATCH v4] hw/nvme: add namespace hotplug support","submitter":{"id":17227,"url":"http://patchwork.ozlabs.org/api/people/17227/","name":"Stefan Hajnoczi","email":"stefanha@redhat.com"},"content":"On Wed, Apr 15, 2026 at 07:38:52PM +0200, mr-083 wrote:\n> Add hotplug support for nvme-ns devices on the NvmeBus. This enables\n> NVMe namespace-level hot-add and hot-remove via device_add and\n> device_del with proper Asynchronous Event Notification (AEN), so the\n> guest kernel can react to namespace topology changes.\n> \n> Mark nvme-ns devices as hotpluggable and register the NvmeBus as a\n> hotplug handler with proper plug and unplug callbacks:\n> \n> - plug: attach namespace to all started controllers and send an\n> Asynchronous Event Notification (AEN) with NS_ATTR_CHANGED so\n> the guest kernel rescans namespaces and adds the block device\n> - unplug: drain in-flight I/O, detach from all controllers, send\n> AEN, then unrealize the device. The guest kernel rescans and\n> removes the block device.\n> \n> The plug handler skips controllers that haven't started yet\n> (qs_created == false) to avoid interfering with boot-time namespace\n> attachment in nvme_start_ctrl().\n> \n> The unplug handler drains in-flight I/O via nvme_ns_drain() before\n> detaching the namespace from controllers, so pending requests can\n> complete normally without touching freed state.\n> \n> For symmetry with nvme_ns_realize() which sets subsys->namespaces[nsid],\n> nvme_ns_unrealize() now clears that slot too making the namespace\n> lifecycle complete.\n> \n> Both the controller bus and subsystem bus are configured as hotplug\n> handlers via qbus_set_bus_hotplug_handler() since nvme-ns devices\n> may reparent to the subsystem bus during realize.\n> \n> Example hot-swap sequence using the NVMe subsystem model:\n> \n> # Boot with: -device nvme-subsys,id=subsys0\n> # -device nvme,id=ctrl0,subsys=subsys0\n> # -device nvme-ns,id=ns0,drive=drv0,bus=ctrl0,nsid=1\n> \n> device_del ns0 # guest receives AEN, removes /dev/nvme0n1\n> drive_del drv0\n> drive_add 0 file=disk.qcow2,format=qcow2,id=drv0,if=none\n> device_add nvme-ns,id=ns0,drive=drv0,bus=ctrl0,nsid=1\n> # guest receives AEN, adds /dev/nvme0n1\n> \n> Tested with Linux 6.1 guest (NVMe driver processes AEN and rescans\n> namespace list automatically).\n> \n> Signed-off-by: Matthieu \n> ---\n> hw/nvme/ctrl.c | 88 ++++++++++++++++++++++++++++++++++++++++++++++++\n> hw/nvme/ns.c | 8 +++++\n> hw/nvme/subsys.c | 2 ++\n> 3 files changed, 98 insertions(+)\n\nThis is useful functionality because PCI hotplug is cumbersome as it\nrequires preallocating PCIe root ports at guest creation time. Users may\nnot know how many devices they will eventually hotplug, and so it's\nconvenient to hotplug multiple namespaces onto an existing NVMe PCI\ncontroller.\n\nReviewed-by: Stefan Hajnoczi ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=LwvoaqSm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxT352hkpz1yG9\n\tfor ; Fri, 17 Apr 2026 05:43:43 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDSc1-0001rS-LX; Thu, 16 Apr 2026 15:42:53 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDSbx-0001q5-6c\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 15:42:50 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDSbv-0002CS-A3\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 15:42:48 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-190-lRMp6mmvM3aN3CL-ak-xKw-1; Thu,\n 16 Apr 2026 15:42:40 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id C22701956056; Thu, 16 Apr 2026 19:42:38 +0000 (UTC)","from localhost (unknown [10.44.48.32])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 7471830001A4; Thu, 16 Apr 2026 19:42:37 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776368565;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=KuYKXzY/dT1prCAUF+XAZfKm+aQRp9FKDF6kurzfCYk=;\n b=LwvoaqSmQii0V1TgJHMfJQJp6vEIQSBRFydR7X0mexUwChe/EwOsKSw4adHfgYKGjv24Wa\n LPSVXu1/S5e0H2Vmqw9eTHrSIGwN2IjXC13Jf60VNkBZAcuLh2vis/p8m8gg+kTdeGjBi7\n TUyaf5HMrCT9Mqr9BCy3yJQZiewmvSU=","X-MC-Unique":"lRMp6mmvM3aN3CL-ak-xKw-1","X-Mimecast-MFC-AGG-ID":"lRMp6mmvM3aN3CL-ak-xKw_1776368559","Date":"Thu, 16 Apr 2026 15:42:34 -0400","From":"Stefan Hajnoczi ","To":"mr-083 ","Cc":"qemu-devel@nongnu.org, qemu-block@nongnu.org, its@irrelevant.dk,\n kbusch@kernel.org, mr-083 ","Subject":"Re: [PATCH v4] hw/nvme: add namespace hotplug support","Message-ID":"<20260416194234.GA258343@fedora>","References":"<20260409060155.94704-1-matthieu@min.io>\n <20260415173852.71135-1-matthieu@min.io>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n protocol=\"application/pgp-signature\"; boundary=\"XICr/xxE8Ini9PdR\"","Content-Disposition":"inline","In-Reply-To":"<20260415173852.71135-1-matthieu@min.io>","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=stefanha@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"7","X-Spam_score":"0.7","X-Spam_bar":"/","X-Spam_report":"(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3678603,"web_url":"http://patchwork.ozlabs.org/comment/3678603/","msgid":"","list_archive_url":null,"date":"2026-04-17T09:29:04","subject":"Re: [PATCH v4] hw/nvme: add namespace hotplug support","submitter":{"id":77636,"url":"http://patchwork.ozlabs.org/api/people/77636/","name":"Klaus Jensen","email":"its@irrelevant.dk"},"content":"On Apr 15 19:38, mr-083 wrote:\n> Add hotplug support for nvme-ns devices on the NvmeBus. This enables\n> NVMe namespace-level hot-add and hot-remove via device_add and\n> device_del with proper Asynchronous Event Notification (AEN), so the\n> guest kernel can react to namespace topology changes.\n> \n> Mark nvme-ns devices as hotpluggable and register the NvmeBus as a\n> hotplug handler with proper plug and unplug callbacks:\n> \n> - plug: attach namespace to all started controllers and send an\n> Asynchronous Event Notification (AEN) with NS_ATTR_CHANGED so\n> the guest kernel rescans namespaces and adds the block device\n> - unplug: drain in-flight I/O, detach from all controllers, send\n> AEN, then unrealize the device. The guest kernel rescans and\n> removes the block device.\n> \n> The plug handler skips controllers that haven't started yet\n> (qs_created == false) to avoid interfering with boot-time namespace\n> attachment in nvme_start_ctrl().\n> \n> The unplug handler drains in-flight I/O via nvme_ns_drain() before\n> detaching the namespace from controllers, so pending requests can\n> complete normally without touching freed state.\n> \n> For symmetry with nvme_ns_realize() which sets subsys->namespaces[nsid],\n> nvme_ns_unrealize() now clears that slot too making the namespace\n> lifecycle complete.\n> \n> Both the controller bus and subsystem bus are configured as hotplug\n> handlers via qbus_set_bus_hotplug_handler() since nvme-ns devices\n> may reparent to the subsystem bus during realize.\n> \n> Example hot-swap sequence using the NVMe subsystem model:\n> \n> # Boot with: -device nvme-subsys,id=subsys0\n> # -device nvme,id=ctrl0,subsys=subsys0\n> # -device nvme-ns,id=ns0,drive=drv0,bus=ctrl0,nsid=1\n> \n> device_del ns0 # guest receives AEN, removes /dev/nvme0n1\n> drive_del drv0\n> drive_add 0 file=disk.qcow2,format=qcow2,id=drv0,if=none\n> device_add nvme-ns,id=ns0,drive=drv0,bus=ctrl0,nsid=1\n> # guest receives AEN, adds /dev/nvme0n1\n> \n> Tested with Linux 6.1 guest (NVMe driver processes AEN and rescans\n> namespace list automatically).\n> \n> Signed-off-by: Matthieu \n> ---\n> hw/nvme/ctrl.c | 88 ++++++++++++++++++++++++++++++++++++++++++++++++\n> hw/nvme/ns.c | 8 +++++\n> hw/nvme/subsys.c | 2 ++\n> 3 files changed, 98 insertions(+)\n> \n> diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c\n> index be6c7028cb..2024b0ff75 100644\n> --- a/hw/nvme/ctrl.c\n> +++ b/hw/nvme/ctrl.c\n> @@ -206,6 +206,7 @@\n> #include \"system/hostmem.h\"\n> #include \"hw/pci/msix.h\"\n> #include \"hw/pci/pcie_sriov.h\"\n> +#include \"hw/core/qdev.h\"\n> #include \"system/spdm-socket.h\"\n> #include \"migration/vmstate.h\"\n> \n> @@ -9293,6 +9294,7 @@ static void nvme_realize(PCIDevice *pci_dev, Error **errp)\n> }\n> \n> qbus_init(&n->bus, sizeof(NvmeBus), TYPE_NVME_BUS, dev, dev->id);\n> + qbus_set_bus_hotplug_handler(BUS(&n->bus));\n> \n> if (nvme_init_subsys(n, errp)) {\n> return;\n> @@ -9553,10 +9555,96 @@ static const TypeInfo nvme_info = {\n> },\n> };\n> \n> +static void nvme_ns_hot_plug(HotplugHandler *hotplug_dev, DeviceState *dev,\n> + Error **errp)\n> +{\n> + NvmeNamespace *ns = NVME_NS(dev);\n> + NvmeSubsystem *subsys = ns->subsys;\n> + uint32_t nsid = ns->params.nsid;\n> + int i;\n> +\n> + /*\n> + * Attach to all started controllers and notify via AEN.\n> + * Skip controllers that haven't started yet (boot-time realize) —\n> + * nvme_start_ctrl() will attach namespaces during controller init.\n> + */\n> + for (i = 0; i < NVME_MAX_CONTROLLERS; i++) {\n> + NvmeCtrl *ctrl = nvme_subsys_ctrl(subsys, i);\n> + if (!ctrl || !ctrl->qs_created) {\n> + continue;\n> + }\n> +\n> + if (nvme_csi_supported(ctrl, ns->csi) && !ns->params.detached) {\n> + nvme_attach_ns(ctrl, ns);\n> + nvme_update_dsm_limits(ctrl, ns);\n> +\n> + if (!test_and_set_bit(nsid, ctrl->changed_nsids)) {\n> + nvme_enqueue_event(ctrl, NVME_AER_TYPE_NOTICE,\n> + NVME_AER_INFO_NOTICE_NS_ATTR_CHANGED,\n> + NVME_LOG_CHANGED_NSLIST);\n> + }\n> + }\n> + }\n> +}\n> +\n> +static void nvme_ns_hot_unplug(HotplugHandler *hotplug_dev, DeviceState *dev,\n> + Error **errp)\n> +{\n> + NvmeNamespace *ns = NVME_NS(dev);\n> + NvmeSubsystem *subsys = ns->subsys;\n> + uint32_t nsid = ns->params.nsid;\n> + int i;\n> +\n> + /*\n> + * Drain in-flight I/O before tearing down the namespace.\n> + * This must happen while the namespace is still attached to the\n> + * controllers so any pending requests can complete normally.\n> + */\n> + nvme_ns_drain(ns);\n> +\n> + /*\n> + * Detach from all controllers and notify the guest via AEN.\n> + * The guest kernel will rescan namespaces and remove the block device.\n> + */\n> + for (i = 0; i < NVME_MAX_CONTROLLERS; i++) {\n> + NvmeCtrl *ctrl = nvme_subsys_ctrl(subsys, i);\n> + if (!ctrl || !nvme_ns(ctrl, nsid)) {\n> + continue;\n> + }\n> +\n> + nvme_detach_ns(ctrl, ns);\n> + nvme_update_dsm_limits(ctrl, NULL);\n> +\n> + if (!test_and_set_bit(nsid, ctrl->changed_nsids)) {\n> + nvme_enqueue_event(ctrl, NVME_AER_TYPE_NOTICE,\n> + NVME_AER_INFO_NOTICE_NS_ATTR_CHANGED,\n> + NVME_LOG_CHANGED_NSLIST);\n> + }\n> + }\n> +\n> + /*\n> + * Unrealize: removes from subsystem (in nvme_ns_unrealize), flushes,\n> + * cleans up structures, and removes from QOM.\n> + */\n> + qdev_unrealize(dev);\n> +}\n> +\n> +static void nvme_bus_class_init(ObjectClass *klass, const void *data)\n> +{\n> + HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(klass);\n> + hc->plug = nvme_ns_hot_plug;\n> + hc->unplug = nvme_ns_hot_unplug;\n> +}\n> +\n> static const TypeInfo nvme_bus_info = {\n> .name = TYPE_NVME_BUS,\n> .parent = TYPE_BUS,\n> .instance_size = sizeof(NvmeBus),\n> + .class_init = nvme_bus_class_init,\n> + .interfaces = (const InterfaceInfo[]) {\n> + { TYPE_HOTPLUG_HANDLER },\n> + { }\n> + },\n> };\n> \n> static void nvme_register_types(void)\n> diff --git a/hw/nvme/ns.c b/hw/nvme/ns.c\n> index b0106eaa5c..f4f755c6fc 100644\n> --- a/hw/nvme/ns.c\n> +++ b/hw/nvme/ns.c\n> @@ -719,10 +719,17 @@ void nvme_ns_cleanup(NvmeNamespace *ns)\n> static void nvme_ns_unrealize(DeviceState *dev)\n> {\n> NvmeNamespace *ns = NVME_NS(dev);\n> + NvmeSubsystem *subsys = ns->subsys;\n> + uint32_t nsid = ns->params.nsid;\n> \n> nvme_ns_drain(ns);\n> nvme_ns_shutdown(ns);\n> nvme_ns_cleanup(ns);\n> +\n> + /* Symmetric with nvme_ns_realize() which sets subsys->namespaces[nsid]. */\n> + if (subsys && nsid && subsys->namespaces[nsid] == ns) {\n> + subsys->namespaces[nsid] = NULL;\n> + }\n> }\n> \n> void nvme_ns_atomic_configure_boundary(bool dn, uint16_t nabsn,\n> @@ -937,6 +944,7 @@ static void nvme_ns_class_init(ObjectClass *oc, const void *data)\n> dc->bus_type = TYPE_NVME_BUS;\n> dc->realize = nvme_ns_realize;\n> dc->unrealize = nvme_ns_unrealize;\n> + dc->hotpluggable = true;\n> device_class_set_props(dc, nvme_ns_props);\n> dc->desc = \"Virtual NVMe namespace\";\n> }\n> diff --git a/hw/nvme/subsys.c b/hw/nvme/subsys.c\n> index 777e1c620f..fa35055d3c 100644\n> --- a/hw/nvme/subsys.c\n> +++ b/hw/nvme/subsys.c\n> @@ -9,6 +9,7 @@\n> #include \"qemu/osdep.h\"\n> #include \"qemu/units.h\"\n> #include \"qapi/error.h\"\n> +#include \"hw/core/qdev.h\"\n> \n> #include \"nvme.h\"\n> \n> @@ -205,6 +206,7 @@ static void nvme_subsys_realize(DeviceState *dev, Error **errp)\n> NvmeSubsystem *subsys = NVME_SUBSYS(dev);\n> \n> qbus_init(&subsys->bus, sizeof(NvmeBus), TYPE_NVME_BUS, dev, dev->id);\n> + qbus_set_bus_hotplug_handler(BUS(&subsys->bus));\n> \n> nvme_subsys_setup(subsys, errp);\n> }\n> -- \n> 2.53.0\n> \n> \n\nAs an out-of-band mechanism to hot-plug namespaces, this looks good.\n\nReviewed-by: Klaus Jensen \n\nI'll pick it up for 11.1. Thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=irrelevant.dk header.i=@irrelevant.dk\n header.a=rsa-sha256 header.s=fm1 header.b=PgibdKu8;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=messagingengine.com header.i=@messagingengine.com\n header.a=rsa-sha256 header.s=fm2 header.b=N/SEL9Ag;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxqNn4Mrkz1yD3\n\tfor ; Fri, 17 Apr 2026 19:30:16 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDfVk-0002na-7g; Fri, 17 Apr 2026 05:29:16 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDfVh-0002nI-CH; Fri, 17 Apr 2026 05:29:13 -0400","from fhigh-a5-smtp.messagingengine.com ([103.168.172.156])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDfVe-000379-VG; Fri, 17 Apr 2026 05:29:13 -0400","from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41])\n by mailfhigh.phl.internal (Postfix) with ESMTP id 75FB714000E2;\n Fri, 17 Apr 2026 05:29:07 -0400 (EDT)","from phl-frontend-03 ([10.202.2.162])\n by phl-compute-01.internal (MEProxy); Fri, 17 Apr 2026 05:29:07 -0400","by mail.messagingengine.com (Postfix) with ESMTPA; Fri,\n 17 Apr 2026 05:29:06 -0400 (EDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk;\n h=cc:cc:content-type:content-type:date:date:from:from\n :in-reply-to:in-reply-to:message-id:mime-version:references\n :reply-to:subject:subject:to:to; s=fm1; t=1776418147; x=\n 1776504547; bh=b4jX4ABbMpc4EjQ6DVEqZTqMVunKofDlQkZIIMRWS0I=; b=P\n gibdKu8yYWRgW2C1lI//Rwr0EyOOdzIJswszkySPxk90QGmbe/TWHVJVhQoB0InU\n /OWBg8oT6N1ZyNZVIzqaWa//psTMy9Hhzc0Yt4B+zrOisFZIPlhnDIFLwFjuQwdj\n ztEQR0tLLyJYs6Cn2ZoB1lIShHX3O/sa7M7E4qhJK8N1akQPdeEO4CHA6bkz87Iq\n 1LiphwRneJi5gC6J5JGJx3RTnFKyzNokoYHN+fwiOaK7IrEmFaGC8MC2y6GF0Vzy\n QDrt9lsc8T7arKn2U7pdeagoZBjHnCc7HZRDSraclMCUVLE6crKadj2LzVxWPY6O\n MW2dBo3F1BCJbFeUx4mgw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:cc:content-type:content-type:date:date\n :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to\n :message-id:mime-version:references:reply-to:subject:subject:to\n :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=\n 1776418147; x=1776504547; bh=b4jX4ABbMpc4EjQ6DVEqZTqMVunKofDlQkZ\n IIMRWS0I=; b=N/SEL9AgZAq7s+zjpaw9b8DsbFWBYW7iCnCrsZOkQyKGDtbu4ba\n XIWL4WWPqFl9k7Q6V4T/aQF1f0fgIjv59IJEAXouVRTCoH8xjRx1MKqJ3sLJP/Bs\n 16ZIDCVkrUf4QcrOW42VeH55pQfM9pK5xvAsgycPWHJt6da4mND5rFeBzsWItHG4\n gJGyAicX8QP+3c6747G3DCq38Vkf0KTvP84iV9UKE3LCf7Qa1fkKRBrgYMfUc9An\n B7gEYeWAoLdVVeNJufJquVFpZs5JXrOn0/xlAHd66yOZIbgvWSXKt1GuuA4IX9wR\n RCXs3wG/b3Jx1vtYpvRwjYYVgsT1Sk34HiQ=="],"X-ME-Sender":"\n ","X-ME-Received":"\n ","X-ME-Proxy-Cause":"\n gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdegleehvdcutefuodetggdotefrod\n ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr\n ihhlohhuthemuceftddtnecunecujfgurhepfffhvfevuffkfhggtggujgesghdtreertd\n dtjeenucfhrhhomhepmfhlrghushculfgvnhhsvghnuceoihhtshesihhrrhgvlhgvvhgr\n nhhtrdgukheqnecuggftrfgrthhtvghrnhepjefgjeefffdvuefhieefhffggfeuleehud\n ekveejvedtuddugeeigeetffffjeevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr\n rghmpehmrghilhhfrhhomhepihhtshesihhrrhgvlhgvvhgrnhhtrdgukhdpnhgspghrtg\n hpthhtohepjedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepmhgrthhthhhivghu\n sehmihhnihhordhiohdprhgtphhtthhopehqvghmuhdquggvvhgvlhesnhhonhhgnhhurd\n horhhgpdhrtghpthhtohepqhgvmhhuqdgslhhotghksehnohhnghhnuhdrohhrghdprhgt\n phhtthhopehksghushgthheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepshhtvghfrg\n hnhhgrsehrvgguhhgrthdrtghomhdprhgtphhtthhopehmrghtthhhihgvuhesmhhinhdr\n ihhopdhrtghpthhtohepihhtshesihhrrhgvlhgvvhgrnhhtrdgukh","X-ME-Proxy":"\n \n \n \n ","Feedback-ID":"idc91472f:Fastmail","Date":"Fri, 17 Apr 2026 11:29:04 +0200","From":"Klaus Jensen ","To":"mr-083 ","Cc":"qemu-devel@nongnu.org, qemu-block@nongnu.org, kbusch@kernel.org,\n stefanha@redhat.com, mr-083 ","Subject":"Re: [PATCH v4] hw/nvme: add namespace hotplug support","Message-ID":"","References":"<20260409060155.94704-1-matthieu@min.io>\n <20260415173852.71135-1-matthieu@min.io>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n protocol=\"application/pgp-signature\"; boundary=\"hONpm4qRd4O57Z9u\"","Content-Disposition":"inline","In-Reply-To":"<20260415173852.71135-1-matthieu@min.io>","Received-SPF":"pass client-ip=103.168.172.156; envelope-from=its@irrelevant.dk;\n helo=fhigh-a5-smtp.messagingengine.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3678614,"web_url":"http://patchwork.ozlabs.org/comment/3678614/","msgid":"<9474C609-F00D-4ADF-9F5C-3103388C9434@minio.io>","list_archive_url":null,"date":"2026-04-17T09:45:54","subject":"Re: [PATCH v4] hw/nvme: add namespace hotplug support","submitter":{"id":93098,"url":"http://patchwork.ozlabs.org/api/people/93098/","name":"Matthieu Rolla","email":"matthieu@minio.io"},"content":"Hello Klaus,\n\nThank you for your feedback. I also created https://lists.nongnu.org/archive/html/qemu-devel/2026-04/msg02613.html if you are interested. \n\nBR,\n\n\t.\t\nMatthieu\nwww.min.io <>\nmatthieu@min.io <> \n\n> On Apr 17, 2026, at 11:29 AM, Klaus Jensen wrote:\n> \n> On Apr 15 19:38, mr-083 wrote:\n>> Add hotplug support for nvme-ns devices on the NvmeBus. This enables\n>> NVMe namespace-level hot-add and hot-remove via device_add and\n>> device_del with proper Asynchronous Event Notification (AEN), so the\n>> guest kernel can react to namespace topology changes.\n>> \n>> Mark nvme-ns devices as hotpluggable and register the NvmeBus as a\n>> hotplug handler with proper plug and unplug callbacks:\n>> \n>> - plug: attach namespace to all started controllers and send an\n>> Asynchronous Event Notification (AEN) with NS_ATTR_CHANGED so\n>> the guest kernel rescans namespaces and adds the block device\n>> - unplug: drain in-flight I/O, detach from all controllers, send\n>> AEN, then unrealize the device. The guest kernel rescans and\n>> removes the block device.\n>> \n>> The plug handler skips controllers that haven't started yet\n>> (qs_created == false) to avoid interfering with boot-time namespace\n>> attachment in nvme_start_ctrl().\n>> \n>> The unplug handler drains in-flight I/O via nvme_ns_drain() before\n>> detaching the namespace from controllers, so pending requests can\n>> complete normally without touching freed state.\n>> \n>> For symmetry with nvme_ns_realize() which sets subsys->namespaces[nsid],\n>> nvme_ns_unrealize() now clears that slot too making the namespace\n>> lifecycle complete.\n>> \n>> Both the controller bus and subsystem bus are configured as hotplug\n>> handlers via qbus_set_bus_hotplug_handler() since nvme-ns devices\n>> may reparent to the subsystem bus during realize.\n>> \n>> Example hot-swap sequence using the NVMe subsystem model:\n>> \n>> # Boot with: -device nvme-subsys,id=subsys0\n>> # -device nvme,id=ctrl0,subsys=subsys0\n>> # -device nvme-ns,id=ns0,drive=drv0,bus=ctrl0,nsid=1\n>> \n>> device_del ns0 # guest receives AEN, removes /dev/nvme0n1\n>> drive_del drv0\n>> drive_add 0 file=disk.qcow2,format=qcow2,id=drv0,if=none\n>> device_add nvme-ns,id=ns0,drive=drv0,bus=ctrl0,nsid=1\n>> # guest receives AEN, adds /dev/nvme0n1\n>> \n>> Tested with Linux 6.1 guest (NVMe driver processes AEN and rescans\n>> namespace list automatically).\n>> \n>> Signed-off-by: Matthieu \n>> ---\n>> hw/nvme/ctrl.c | 88 ++++++++++++++++++++++++++++++++++++++++++++++++\n>> hw/nvme/ns.c | 8 +++++\n>> hw/nvme/subsys.c | 2 ++\n>> 3 files changed, 98 insertions(+)\n>> \n>> diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c\n>> index be6c7028cb..2024b0ff75 100644\n>> --- a/hw/nvme/ctrl.c\n>> +++ b/hw/nvme/ctrl.c\n>> @@ -206,6 +206,7 @@\n>> #include \"system/hostmem.h\"\n>> #include \"hw/pci/msix.h\"\n>> #include \"hw/pci/pcie_sriov.h\"\n>> +#include \"hw/core/qdev.h\"\n>> #include \"system/spdm-socket.h\"\n>> #include \"migration/vmstate.h\"\n>> \n>> @@ -9293,6 +9294,7 @@ static void nvme_realize(PCIDevice *pci_dev, Error **errp)\n>> }\n>> \n>> qbus_init(&n->bus, sizeof(NvmeBus), TYPE_NVME_BUS, dev, dev->id);\n>> + qbus_set_bus_hotplug_handler(BUS(&n->bus));\n>> \n>> if (nvme_init_subsys(n, errp)) {\n>> return;\n>> @@ -9553,10 +9555,96 @@ static const TypeInfo nvme_info = {\n>> },\n>> };\n>> \n>> +static void nvme_ns_hot_plug(HotplugHandler *hotplug_dev, DeviceState *dev,\n>> + Error **errp)\n>> +{\n>> + NvmeNamespace *ns = NVME_NS(dev);\n>> + NvmeSubsystem *subsys = ns->subsys;\n>> + uint32_t nsid = ns->params.nsid;\n>> + int i;\n>> +\n>> + /*\n>> + * Attach to all started controllers and notify via AEN.\n>> + * Skip controllers that haven't started yet (boot-time realize) —\n>> + * nvme_start_ctrl() will attach namespaces during controller init.\n>> + */\n>> + for (i = 0; i < NVME_MAX_CONTROLLERS; i++) {\n>> + NvmeCtrl *ctrl = nvme_subsys_ctrl(subsys, i);\n>> + if (!ctrl || !ctrl->qs_created) {\n>> + continue;\n>> + }\n>> +\n>> + if (nvme_csi_supported(ctrl, ns->csi) && !ns->params.detached) {\n>> + nvme_attach_ns(ctrl, ns);\n>> + nvme_update_dsm_limits(ctrl, ns);\n>> +\n>> + if (!test_and_set_bit(nsid, ctrl->changed_nsids)) {\n>> + nvme_enqueue_event(ctrl, NVME_AER_TYPE_NOTICE,\n>> + NVME_AER_INFO_NOTICE_NS_ATTR_CHANGED,\n>> + NVME_LOG_CHANGED_NSLIST);\n>> + }\n>> + }\n>> + }\n>> +}\n>> +\n>> +static void nvme_ns_hot_unplug(HotplugHandler *hotplug_dev, DeviceState *dev,\n>> + Error **errp)\n>> +{\n>> + NvmeNamespace *ns = NVME_NS(dev);\n>> + NvmeSubsystem *subsys = ns->subsys;\n>> + uint32_t nsid = ns->params.nsid;\n>> + int i;\n>> +\n>> + /*\n>> + * Drain in-flight I/O before tearing down the namespace.\n>> + * This must happen while the namespace is still attached to the\n>> + * controllers so any pending requests can complete normally.\n>> + */\n>> + nvme_ns_drain(ns);\n>> +\n>> + /*\n>> + * Detach from all controllers and notify the guest via AEN.\n>> + * The guest kernel will rescan namespaces and remove the block device.\n>> + */\n>> + for (i = 0; i < NVME_MAX_CONTROLLERS; i++) {\n>> + NvmeCtrl *ctrl = nvme_subsys_ctrl(subsys, i);\n>> + if (!ctrl || !nvme_ns(ctrl, nsid)) {\n>> + continue;\n>> + }\n>> +\n>> + nvme_detach_ns(ctrl, ns);\n>> + nvme_update_dsm_limits(ctrl, NULL);\n>> +\n>> + if (!test_and_set_bit(nsid, ctrl->changed_nsids)) {\n>> + nvme_enqueue_event(ctrl, NVME_AER_TYPE_NOTICE,\n>> + NVME_AER_INFO_NOTICE_NS_ATTR_CHANGED,\n>> + NVME_LOG_CHANGED_NSLIST);\n>> + }\n>> + }\n>> +\n>> + /*\n>> + * Unrealize: removes from subsystem (in nvme_ns_unrealize), flushes,\n>> + * cleans up structures, and removes from QOM.\n>> + */\n>> + qdev_unrealize(dev);\n>> +}\n>> +\n>> +static void nvme_bus_class_init(ObjectClass *klass, const void *data)\n>> +{\n>> + HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(klass);\n>> + hc->plug = nvme_ns_hot_plug;\n>> + hc->unplug = nvme_ns_hot_unplug;\n>> +}\n>> +\n>> static const TypeInfo nvme_bus_info = {\n>> .name = TYPE_NVME_BUS,\n>> .parent = TYPE_BUS,\n>> .instance_size = sizeof(NvmeBus),\n>> + .class_init = nvme_bus_class_init,\n>> + .interfaces = (const InterfaceInfo[]) {\n>> + { TYPE_HOTPLUG_HANDLER },\n>> + { }\n>> + },\n>> };\n>> \n>> static void nvme_register_types(void)\n>> diff --git a/hw/nvme/ns.c b/hw/nvme/ns.c\n>> index b0106eaa5c..f4f755c6fc 100644\n>> --- a/hw/nvme/ns.c\n>> +++ b/hw/nvme/ns.c\n>> @@ -719,10 +719,17 @@ void nvme_ns_cleanup(NvmeNamespace *ns)\n>> static void nvme_ns_unrealize(DeviceState *dev)\n>> {\n>> NvmeNamespace *ns = NVME_NS(dev);\n>> + NvmeSubsystem *subsys = ns->subsys;\n>> + uint32_t nsid = ns->params.nsid;\n>> \n>> nvme_ns_drain(ns);\n>> nvme_ns_shutdown(ns);\n>> nvme_ns_cleanup(ns);\n>> +\n>> + /* Symmetric with nvme_ns_realize() which sets subsys->namespaces[nsid]. */\n>> + if (subsys && nsid && subsys->namespaces[nsid] == ns) {\n>> + subsys->namespaces[nsid] = NULL;\n>> + }\n>> }\n>> \n>> void nvme_ns_atomic_configure_boundary(bool dn, uint16_t nabsn,\n>> @@ -937,6 +944,7 @@ static void nvme_ns_class_init(ObjectClass *oc, const void *data)\n>> dc->bus_type = TYPE_NVME_BUS;\n>> dc->realize = nvme_ns_realize;\n>> dc->unrealize = nvme_ns_unrealize;\n>> + dc->hotpluggable = true;\n>> device_class_set_props(dc, nvme_ns_props);\n>> dc->desc = \"Virtual NVMe namespace\";\n>> }\n>> diff --git a/hw/nvme/subsys.c b/hw/nvme/subsys.c\n>> index 777e1c620f..fa35055d3c 100644\n>> --- a/hw/nvme/subsys.c\n>> +++ b/hw/nvme/subsys.c\n>> @@ -9,6 +9,7 @@\n>> #include \"qemu/osdep.h\"\n>> #include \"qemu/units.h\"\n>> #include \"qapi/error.h\"\n>> +#include \"hw/core/qdev.h\"\n>> \n>> #include \"nvme.h\"\n>> \n>> @@ -205,6 +206,7 @@ static void nvme_subsys_realize(DeviceState *dev, Error **errp)\n>> NvmeSubsystem *subsys = NVME_SUBSYS(dev);\n>> \n>> qbus_init(&subsys->bus, sizeof(NvmeBus), TYPE_NVME_BUS, dev, dev->id);\n>> + qbus_set_bus_hotplug_handler(BUS(&subsys->bus));\n>> \n>> nvme_subsys_setup(subsys, errp);\n>> }\n>> -- \n>> 2.53.0\n>> \n>> \n> \n> As an out-of-band mechanism to hot-plug namespaces, this looks good.\n> \n> Reviewed-by: Klaus Jensen \n> \n> I'll pick it up for 11.1. Thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=minio.io header.i=@minio.io header.a=rsa-sha256\n header.s=minio header.b=FiwEvuJo;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxqlr6zwKz1yD3\n\tfor ; Fri, 17 Apr 2026 19:46:48 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDfmP-0006q0-Px; Fri, 17 Apr 2026 05:46:29 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wDflu-0006gS-Tr\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 05:46:08 -0400","from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wDfls-00078b-5u\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 05:45:58 -0400","by mail-wm1-x32e.google.com with SMTP id\n 5b1f17b1804b1-4852a9c6309so4126175e9.0\n for ; Fri, 17 Apr 2026 02:45:55 -0700 (PDT)","from smtpclient.apple\n (2a01cb001411480048dbebc40db84a7b.ipv6.abo.wanadoo.fr.\n [2a01:cb00:1411:4800:48db:ebc4:db8:4a7b])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fc16f784sm27612495e9.1.2026.04.17.02.45.53\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Fri, 17 Apr 2026 02:45:53 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=minio.io; s=minio; t=1776419154; x=1777023954; darn=nongnu.org;\n h=references:to:cc:in-reply-to:date:subject:mime-version:message-id\n :from:from:to:cc:subject:date:message-id:reply-to;\n bh=+rG1tA44kts1GfLhbQcUoT5U71ff49S492gxbzoowUY=;\n b=FiwEvuJoxkZk5Vvfyb4m7XLPXiKmo/EhHMFDLNP57g+YyskFypNkAR3YhKY8sdkyfg\n vhjudswIQXZF9Rutcct8XUp1r36ctIAgVSRNT3eV6Mbkh1Nt5gbHJnpjJR7/IFFckAlN\n fNbmDdQgUIikKVorYt8RrcezgMfZiaYaf2DwrUmMM6lsfumSNV80vpVMAXKwaUAYZhhY\n xR8zYeeP7PZY5D3kobV78qdTZ9ZK11s2IuKYYGnZqknRPctst6ybX9lhCKtlLF9m+Ir1\n oq/R1F4FunJOz/jELVLUZ1AFYHs2uxjekmVp0P7DbWZwEW0DXxoOSHY1m4ZYYyChFUaw\n 3LIQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776419154; x=1777023954;\n h=references:to:cc:in-reply-to:date:subject:mime-version:message-id\n :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=+rG1tA44kts1GfLhbQcUoT5U71ff49S492gxbzoowUY=;\n b=Y5eCTUdK+h/7EwBuBX7sOTK0OYUBx20nmG8w0yfN3CgXuenI16cP0fpxtOGmJq7D29\n YAQkWTgh6aquzr8QlrtCeE3iEawjEDlp1FSlQP879Df2w2Lmn7A8O0FoLzbaH0vZAzdU\n lQjymehuoq/Qvnaq+rGdRoMtk1fJFMhN0xKw459o8ASZFrdWWhDlxo/Pigk/XSQqG8+r\n 7qGHykXL6LO+iKwr7yIkZ4ceRvqzVrSWShEY+wqQ35E0g1GzVznhgcyX2XbmzPkKKdUD\n 8H1cvbNFSPMRMzbtEJM4ow6QWZKLUOi6DDm12y6z2n6cwL4BOrf35OvvABE7jGWP3jJc\n Qu8A==","X-Gm-Message-State":"AOJu0Yw+FUoOGlUjQYHtHnnFp23UMPbYXQIDGK7TosQlO+1gPfZiipvJ\n xo/lq1z0CHUHwIAxm4JbhP+0hOWpsJABYRa4P80O1p+nrK9vZBIHWTXFQfAOdyrNbS0=","X-Gm-Gg":"AeBDietT1kiID0ov6sQMW2tNuc0g0VmjEEvoOwSloOOS6qR6UJxxJkWZRspBGMsV6K0\n ZyKFULoE8D+uJvEL/LK9OsTxhK0WwOuHOznH2YxCzXqXSsMi6kf3OC+fPvxpGmwLyA8nhO7xwUT\n P0QpJwWhs/vNnYOPYKWQ9JeFZc4j2fsBIw/mIyHBNnCRd+PQb1zU3/3CDSRZn2lOLYIZoSrLtRV\n CnFaD2D/sUfqEXWws0aqZo4dTHbYydMF3fGj2raLcRhppD69/fd1w6VvhLMU9hyNQuaXpWfD74P\n Dvy8CCstWduNABK+blE9RKhXuPaMgFnipQsd2ZYxHaNyVFM9xoHjFwrWwls1DNsVYdXQAfthQXB\n QCiFVyJyr4aH7UjCiizRvG10oxcVsxT9mUtsVH3uYeDI3SW25v8xGwkEg14gN2QwG3XBno+sS6i\n WbqVuRfE10rlIvyStN9DbVi1Q/aS1LEJ1EbExk6I+8XPHQoIGCf5BomRPL94FXhGxHBRzzdfHsH\n 2PsR+J7F3s+zEg4QMIrsbtiL/qrEUK6M+Un/absx7aYWnryshEbUkWYfTDfDD6jHgQFdHN/1mte\n paUoesc=","X-Received":"by 2002:a05:600c:1389:b0:485:9a50:338d with SMTP id\n 5b1f17b1804b1-488fb739d3amr31022795e9.3.1776419154237;\n Fri, 17 Apr 2026 02:45:54 -0700 (PDT)","From":"Matthieu Rolla ","Message-Id":"<9474C609-F00D-4ADF-9F5C-3103388C9434@minio.io>","Content-Type":"multipart/alternative;\n boundary=\"Apple-Mail=_15B4B559-EF24-4AEC-9D0B-4541285F1D3C\"","Mime-Version":"1.0 (Mac OS X Mail 16.0 \\(3864.400.21\\))","Subject":"Re: [PATCH v4] hw/nvme: add namespace hotplug support","Date":"Fri, 17 Apr 2026 11:45:54 +0200","In-Reply-To":"","Cc":"qemu-devel@nongnu.org, qemu-block@nongnu.org, kbusch@kernel.org,\n stefanha@redhat.com, mr-083 ","To":"Klaus Jensen ","References":"<20260409060155.94704-1-matthieu@min.io>\n <20260415173852.71135-1-matthieu@min.io>\n ","X-Mailer":"Apple Mail (2.3864.400.21)","Received-SPF":"pass client-ip=2a00:1450:4864:20::32e;\n envelope-from=matthieu@minio.io; helo=mail-wm1-x32e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n HTML_FONT_LOW_CONTRAST=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]