[{"id":3681868,"web_url":"http://patchwork.ozlabs.org/comment/3681868/","msgid":"","list_archive_url":null,"date":"2026-04-24T08:22:50","subject":"Re: [PATCH] mtd: maps: physmap: fix reference leak on failed device\n registration","submitter":{"id":91722,"url":"http://patchwork.ozlabs.org/api/people/91722/","name":"Guangshuo Li","email":"lgs201920130244@gmail.com"},"content":"Hi,\n\nPlease disregard this patch.\n\nOn Thu, 16 Apr 2026 at 01:00, Guangshuo Li wrote:\n>\n> When platform_device_register() fails in physmap_init(), the embedded\n> struct device in physmap_flash has already been initialized by\n> device_initialize(), but the failure path only unregisters the platform\n> driver and does not drop the device reference for the current platform\n> device:\n>\n> physmap_init()\n> -> platform_device_register(&physmap_flash)\n> -> device_initialize(&physmap_flash.dev)\n> -> setup_pdev_dma_masks(&physmap_flash)\n> -> platform_device_add(&physmap_flash)\n>\n> This leads to a reference leak when platform_device_register() fails.\n> Fix this by calling platform_device_put() before unregistering the\n> platform driver.\n>\n> The issue was identified by a static analysis tool I developed and\n> confirmed by manual review.\n>\n> Fixes: 1ca5d2f0196cf (\"mtd/maps/physmap: catch failure to register MTD_PHYSMAP_COMPAT device\")\n> Cc: stable@vger.kernel.org\n> Signed-off-by: Guangshuo Li \n> ---\n> drivers/mtd/maps/physmap-core.c | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n>\n> diff --git a/drivers/mtd/maps/physmap-core.c b/drivers/mtd/maps/physmap-core.c\n> index 0dcc25b7ff98..6299a741e65b 100644\n> --- a/drivers/mtd/maps/physmap-core.c\n> +++ b/drivers/mtd/maps/physmap-core.c\n> @@ -659,8 +659,10 @@ static int __init physmap_init(void)\n> #ifdef CONFIG_MTD_PHYSMAP_COMPAT\n> if (err == 0) {\n> err = platform_device_register(&physmap_flash);\n> - if (err)\n> + if (err) {\n> + platform_device_put(&physmap_flash);\n> platform_driver_unregister(&physmap_flash_driver);\n> + }\n> }\n> #endif\n>\n> --\n> 2.43.0\n>\n\nAfter re-checking it, physmap_flash is a static platform_device and it\ndoes not provide a dev.release callback. Therefore calling\nplatform_device_put() on the platform_device_register() failure path is\nnot appropriate here and can trigger the missing release callback\nwarning.\n\nThis falls into the same static platform_device pattern pointed out in\nthe other reviews, so I will drop this patch.\n\nSorry for the noise.\n\nBest regards,\nGuangshuo Li","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=XCC53uUN;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=l6AQWZV3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g25ZR2vl0z1yD5\n\tfor ; Fri, 24 Apr 2026 18:23:21 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wGBoa-0000000CrdI-2XDG;\n\tFri, 24 Apr 2026 08:23:08 +0000","from mail-yx1-xb12e.google.com ([2607:f8b0:4864:20::b12e])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wGBoY-0000000CrcR-06Bo\n\tfor linux-mtd@lists.infradead.org;\n\tFri, 24 Apr 2026 08:23:07 +0000","by mail-yx1-xb12e.google.com with SMTP id\n 956f58d0204a3-656d749109cso113276d50.3\n for ;\n Fri, 24 Apr 2026 01:23:05 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tIn-Reply-To:References:MIME-Version:Reply-To:Cc:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=S/Ki9PRlkf9ftYe7UL5zee1/YAIZKwnFZtMZDo4pJTo=; b=XCC53uUNW4g5PG5X2iaTh4Piei\n\tckbroGOvZt6ey9tZG2RdgHQbNo+HYNMbphSa5OCfqvQCtZWPzQZGEwdKiwGw2H96chWN4TUdluANF\n\tmF/OTGi8gqDYFWzJBXXelmFVNWGNxAgjqC1Fog+MS7tcNEhxRPwNynsmVtjS6bVtFn2i0tky8nAuJ\n\tcorbjn1Yi6teAIItgs0WYn/PFK+XQkbmSbyfUrWod3CRYYP1Vath23dPccXyzcRRwqlRBjo8zrKRK\n\tqFLYnjJtm3ug0KROU1kiqg2R3OOEy1EnvqSzm6Ur1oCQQAv/UtbQCJVayxusf/pfzASq8Ccou5I43\n\tAvI+kK3g==;","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777018985; x=1777623785;\n darn=lists.infradead.org;\n h=to:subject:message-id:date:from:in-reply-to:references:mime-version\n :from:to:cc:subject:date:message-id:reply-to;\n bh=SQN0rO9Tzj/+DQYMhwmCTBXrpKo+uLTC66u0nAEI/Ls=;\n b=l6AQWZV3yTpwX4y3g6J7cZL5vp3H1jZC1rfqsGMBc7XNCe0R6aBM6yHJuhlKtEPmOl\n mXD33QAkxAPZ3HxjKe1IvS/xYeNs30BmulkgPDn6dyLGn13IRGsedLw6HSMwhgpP18Mb\n swv0ik/5E75bZFQxUJ+14y+LyhR5oGw1OoPTMM+ibf3p5n71ywCzn9QesygrIkzgZ3yH\n a3A0+v4p/smpuCyaootAsArRm1J+ceTnnfEYgh9HpjJ/7+OXvK14Eou+DyZZ8tXEJAMv\n ZCHMSIvhJegZldtAn2TEMHFbtjD2nbhfBivbIfonbIijToZBncvMZAuEEQ+9+cluhcEa\n yHBg=="],"ARC-Seal":"i=1; a=rsa-sha256; t=1777018985; cv=none;\n d=google.com; s=arc-20240605;\n b=SWWIT3HsaipaeCelFh3Hm/EW7xU3Cihk4tCaHHFMmscg8KffzxRZCvxj7/BsJMojbU\n Vj/wy15n5c9i64aC56+tws4BElSUex41cpGeJx02IBNi0RrL33g5w4QFBDMQjJmwsBL+\n XRw42lcfz8VrAwc9NaTzJU/0nO0mX1d4AGVfCoIFruaEe6sojrsrq+qO7xC3UTt6epv3\n BIEfyJT7lReB5mcLGdEYfe2NVaU4HaJG5P9djJYmM9VfVrX5ZslBrL7Nk36BIO6T/0uV\n mEKki7mf3U5vufrpn47ez1tSR915QEa0y41R8h+ydfHpUP2yy5HQU453JX1rW/BDXnin\n 7WYQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=to:subject:message-id:date:from:in-reply-to:references:mime-version\n :dkim-signature;\n bh=SQN0rO9Tzj/+DQYMhwmCTBXrpKo+uLTC66u0nAEI/Ls=;\n fh=B2sv4aDQE/6dppkmvbUu0hs7tNVm5T0bk3Vz6Jl4JNM=;\n b=ksEi/y8oCyo/dmkZBIF8OmQcj5PXqt0KSskSKLmFLmSTxOVnsQPsWSeWujWg7CICI9\n dKxuHHx7wL1OIHEwgn7sORLbawxrdrU8+j5a9M2gVeTBOzamGcjgpU0Irw2HNyMLNY3G\n iBKLwdFsx9gda37qT3H2EU/UI9RJfK8C4G6bTE2SrmAQq7YF6r2L00kMCAe8/Atm86U3\n RjBQIjkVkcZsnEZ9+00n8cmTN7PkNCWXzVN+ZrlsOlsIN6sSHFFne8M/b0s99otJGu44\n O4J5OR43Tetw8dvZOxIbROyLCIrQHe5dVET6z4CkOPZO9SJr8sGKlZolOQn5G/Yszy27\n +bQA==;\n darn=lists.infradead.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777018985; x=1777623785;\n h=to:subject:message-id:date:from:in-reply-to:references:mime-version\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=SQN0rO9Tzj/+DQYMhwmCTBXrpKo+uLTC66u0nAEI/Ls=;\n b=fesHnS/Krm43tmNt7UvSyjDQ5Fvkd+2/B5TmEQFsUsRzY9HH492tDumt9oRvT1ARwn\n HlXXNDjHomsWWg/TdDEKIC1YUxD7v5tagIUQ0bL+JXoNuP9nEmRVsU6+Bfqcl16/CiiZ\n BFsGUc+p0M+jxrCV1ltlU0Guw9lEAo5ZShxNUtG7Xa+ggLVspAe/BhbkIdkrN7LEPFsA\n TY1fbGicwfxf2L6BnGoNWPzHM3fKU5lIY/PbelE+fJF/Qpi0NvbqTjZmmu+hZ+sqgE0I\n o9E50JvkDgrg9k1SSCpNIsF8Zz1INu38sl1Vb+CsUK4NqkCIvu3BnE3+uq6q87EzR3yq\n ouXA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+y9jdYcKxLoEfn7nG0/6rI0tZjx7nEMrES54TWN2Gkiq0zYVio51D3oraLaVOhPOM5DL6bBkjpzms=@lists.infradead.org","X-Gm-Message-State":"AOJu0YyaTWprhlne9W6efSgxbrtrgdWBgRVhsMZajmEK/Nnx75Mx6m7e\n\twG1d9J5PKeykSYvsHTJm4rXyqRJvta5QedEli8ixOCNtPhXQTJfaowxzzMDCN9VkZwvRPhHjtXk\n\tOnFhkieaLCd/xiAM/HmIxRv8v1y9P/dk=","X-Gm-Gg":"AeBDieuDpxHdyft3k8bu9tnZP5K9ftkAQEZ6cCy2HtN330k9I9sJt0Jc1D38ZcnV4LW\n\tkEjRSER85F1mGbKBl5ZbxSCNDIqfxIbD1Z56QtZVM811IavPw9pbfXFoIYCrQ1R0jdIMsekP5Ag\n\tZxt8EFm/gQJAGb+HdvUywwp5oV5TDZ0xpnX2nfD8KKX5IlePUI1lkEHyknDRIff5ED6+aDN8mbJ\n\t/WH0+yKjL0Qwc4qkxAD2Rntc7bnZn2e29Pcdlq1iNN67YLHzosQvJQTJzz4i7cTH6k5nK+gb19A\n\tBT1Sfc6FAdbpmCDS+Wfs","X-Received":"by 2002:a53:be4f:0:b0:651:c047:f094 with SMTP id\n 956f58d0204a3-653109f9e03mr18571404d50.31.1777018984720; Fri, 24 Apr 2026\n 01:23:04 -0700 (PDT)","MIME-Version":"1.0","References":"<20260415170027.3593563-1-lgs201920130244@gmail.com>","In-Reply-To":"<20260415170027.3593563-1-lgs201920130244@gmail.com>","From":"Guangshuo Li ","Date":"Fri, 24 Apr 2026 16:22:50 +0800","X-Gm-Features":"AQROBzDfZ4s3BN-usOWWRgDfUEb5esPbBRcp_sA4SKBzHYX6HgFuKOUBLqO0Nnc","Message-ID":"\n ","Subject":"Re: [PATCH] mtd: maps: physmap: fix reference leak on failed device\n registration","To":"Miquel Raynal ,\n Richard Weinberger ,\n\tVignesh Raghavendra , Linus Walleij ,\n\tGuangshuo Li ,\n David Woodhouse ,\n\tH Hartley Sweeten ,\n linux-mtd@lists.infradead.org,\n\tlinux-kernel@vger.kernel.org","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260424_012306_068687_1312A1CE ","X-CRM114-Status":"GOOD ( 25.91 )","X-Spam-Score":"-1.8 (-)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: Hi, Please disregard this patch. On Thu,\n 16 Apr 2026 at 01:00,\n Guangshuo Li wrote: > > When platform_device_register() fails in\n physmap_init(),\n the embedded > struct device in physmap_flash has already been initialized\n by > device_ [...]\n Content analysis details: (-1.8 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no\n trust\n [2607:f8b0:4864:20:0:0:0:b12e listed in]\n [list.dnswl.org]\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n 0.0 FROM_LOCAL_HEX From: localpart has long hexadecimal sequence\n 0.0 FROM_LOCAL_DIGITS From: localpart has long digit sequence\n 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in\n digit\n [lgs201920130244(at)gmail.com]\n 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n provider\n [lgs201920130244(at)gmail.com]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]