[{"id":3683437,"web_url":"http://patchwork.ozlabs.org/comment/3683437/","msgid":"<87340fdzcm.fsf@bootlin.com>","list_archive_url":null,"date":"2026-04-28T12:49:13","subject":"Re: [PATCH v2] mtd: spinand: fmsh: add support for FM25G{01,02}B","submitter":{"id":73368,"url":"http://patchwork.ozlabs.org/api/people/73368/","name":"Miquel Raynal","email":"miquel.raynal@bootlin.com"},"content":"Hello Ziyang,\n\nOn 15/04/2026 at 23:31:41 +08, Ziyang Huang wrote:\n\n> FM25G01B: https://www.fmsh.com/nvm/FM25G01B_ds_eng.pdf\n> FM25G02B: https://www.fmsh.com/nvm/FM25G02B_ds_eng.pdf\n\nBefore giving the links, the commit could be slightly more verbose, such\nas \"Add support for...\".\n\n> Signed-off-by: Ziyang Huang \n> ---\n> Changes since v1:\n> Fix copy-paste issue. (Correct FM25G01B size.)\n>\n> drivers/mtd/nand/spi/fmsh.c | 101 ++++++++++++++++++++++++++++++++++++\n> 1 file changed, 101 insertions(+)\n>\n> diff --git a/drivers/mtd/nand/spi/fmsh.c b/drivers/mtd/nand/spi/fmsh.c\n> index f417955f7d1c..a9b219ae6c29 100644\n> --- a/drivers/mtd/nand/spi/fmsh.c\n> +++ b/drivers/mtd/nand/spi/fmsh.c\n> @@ -9,6 +9,16 @@\n> #include \n> #include \n> \n> +#define FM25G01B_STATUS_ECC_MASK\t\t(7 << 4)\n> +\t#define FM25G01B_STATUS_ECC_NO_BITFLIPS\t\t(0 << 4)\n> +\t#define FM25G01B_STATUS_ECC_1_3_BITFLIPS\t(1 << 4)\n> +\t#define FM25G01B_STATUS_ECC_4_BITFLIPS\t\t(2 << 4)\n> +\t#define FM25G01B_STATUS_ECC_5_BITFLIPS\t\t(3 << 4)\n> +\t#define FM25G01B_STATUS_ECC_6_BITFLIPS\t\t(4 << 4)\n> +\t#define FM25G01B_STATUS_ECC_7_BITFLIPS\t\t(5 << 4)\n> +\t#define FM25G01B_STATUS_ECC_8_BITFLIPS\t\t(6 << 4)\n> +\t#define FM25G01B_STATUS_ECC_UNCOR_ERROR\t\t(7 << 4)\n> +\n> #define FM25S01BI3_STATUS_ECC_MASK\t\t(7 << 4)\n> \t#define FM25S01BI3_STATUS_ECC_NO_BITFLIPS\t(0 << 4)\n> \t#define FM25S01BI3_STATUS_ECC_1_3_BITFLIPS\t(1 << 4)\n> @@ -34,6 +44,72 @@ static SPINAND_OP_VARIANTS(update_cache_variants,\n> \t\tSPINAND_PROG_LOAD_1S_1S_4S_OP(false, 0, NULL, 0),\n> \t\tSPINAND_PROG_LOAD_1S_1S_1S_OP(false, 0, NULL, 0));\n> \n> +\n> +static int fm25g01b_ooblayout_ecc(struct mtd_info *mtd, int section,\n> +\t\t\t\t struct mtd_oob_region *region)\n> +{\n> +\tif (section)\n> +\t\treturn -ERANGE;\n> +\n> +\tregion->offset = 64;\n> +\tregion->length = 64;\n> +\n> +\treturn 0;\n> +}\n> +\n> +static int fm25g01b_ooblayout_free(struct mtd_info *mtd, int section,\n> +\t\t\t\t struct mtd_oob_region *region)\n> +{\n> +\tif (section > 3)\n> +\t\treturn -ERANGE;\n> +\n> +\tif (section == 0) {\n> +\t\t/* reserve 2 bytes for the BBM */\n> +\t\tregion->offset = 2;\n> +\t\tregion->length = 14;\n> +\t} else {\n> +\t\tregion->offset = section * 16;\n> +\t\tregion->length = 16;\n> +\t}\n\nIsn't that just one big 62 bytes section starting at 2?\n\n> +\n> +\treturn 0;\n> +}\n\nRest lgtm.\n\nThanks,\nMiquèl","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=QXMW/fVa;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=cYcbr1ND;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4gHV1SkJz1yHv\n\tfor ; Tue, 28 Apr 2026 22:49:26 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHhsN-00000001SvD-3wvp;\n\tTue, 28 Apr 2026 12:49:19 +0000","from smtpout-03.galae.net ([185.246.85.4])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHhsK-00000001Sut-2paQ\n\tfor linux-mtd@lists.infradead.org;\n\tTue, 28 Apr 2026 12:49:19 +0000","from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n\tby smtpout-03.galae.net (Postfix) with ESMTPS id B65394E40CD7;\n\tTue, 28 Apr 2026 12:49:14 +0000 (UTC)","from mail.galae.net (mail.galae.net [212.83.136.155])\n\tby smtpout-01.galae.net (Postfix) with ESMTPS id 873AA601D0;\n\tTue, 28 Apr 2026 12:49:14 +0000 (UTC)","from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id BF50910728B37;\n\tTue, 28 Apr 2026 14:49:11 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References\n\t:In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=UH9LBoL9lHVude9abQmk+tIoPAPsx3av/iTNQJ7TBIc=; b=QXMW/fVaq/sluQ\n\t8t3IXyuJXfxIANZdSEzbaZmceFkgW+/5zPTWHoN04n07SCzDerqv1dCv6kTKa0UEQhX0ksPxVtc51\n\tpO1vR3T+PYyG15efp+gvDjBbbptssoJ4sOxdmuyssMHgghbkHwnyReZgIdmTWUexCv8iObdj+/wnH\n\tQ0Ee5AutLOmRI0Ia60GIz7S8ntj++GUFqXn/IU7XMAlReaTudABfKSfWfmUPajNSRcji12XetSKgH\n\tWCTjzk3L3VuOXS7DYbTpvZqwgYmVbj484G06s/8efVC2heO5DVuFQKtADRyFkyG0m/VOZtmSTxiZI\n\tYWdL5jIQyzZF/5x36iRA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n\tt=1777380553; h=from:subject:date:message-id:to:cc:mime-version:content-type:\n\t content-transfer-encoding:in-reply-to:references;\n\tbh=532MLBDCbnndBAIaErrkgKirNydKSHsihOL9UW9nCJ4=;\n\tb=cYcbr1ND0whWLj3zVzBWCIug7yqiXzeivf5pRXHgRP4JAbVBWFF9kh+LV+LBnMl5I+FdDe\n\tVwQcSlXbvsZuvcCHJiRQN7zpZ49CCh7ziBcT/HOy1lgM9p07RcVzUPTBjxT0c1pArqjbNp\n\th9yph/jKsZBQpJqQpEsPO2+CeAFYmQCZIoD9Ip2bnlI7AAFdX1tjj3KjppaqmgN2DKE65y\n\t23JRvpo4955zN/0aVubps3/jtxaWLCJ24qX6U7Lc1niIP0fcff9ji6WrJSt7Bn2zu+Sids\n\tmr0fpQqlE37hqN5ppWSz79Oj6NmPnEn4svoYX0cnsHIMsLOgSF9DpcvmsYHGXQ=="],"From":"Miquel Raynal ","To":"Ziyang Huang ","Cc":"richard@nod.at, vigneshr@ti.com, cnsztl@gmail.com,\n csharper2005@gmail.com, mikhail.kshevetskiy@iopsys.eu,\n linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH v2] mtd: spinand: fmsh: add support for FM25G{01,02}B","In-Reply-To":"\n \n\t(Ziyang Huang's message of \"Wed, 15 Apr 2026 23:31:41 +0800\")","References":"\n \n\t","User-Agent":"mu4e 1.12.7; emacs 30.2","Date":"Tue, 28 Apr 2026 14:49:13 +0200","Message-ID":"<87340fdzcm.fsf@bootlin.com>","MIME-Version":"1.0","X-Last-TLS-Session-Version":"TLSv1.3","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260428_054916_867428_CE81CDC9 ","X-CRM114-Status":"GOOD ( 14.16 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: Hello Ziyang, On 15/04/2026 at 23:31:41 +08, Ziyang Huang\n wrote: > FM25G01B:\n https://www.fmsh.com/nvm/FM25G01B_ds_eng.pdf\n > FM25G02B: https://www.fmsh.com/nvm/FM25G02B_ds_eng.pdf\n Content analysis details: (-2.0 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n 0.1 URIBL_SBL_A Contains URL's A record listed in the Spamhaus\n SBL\n blocklist\n [URI: ns14.xincache.com/112.80.181.111]\n [URI: ns13.xincache.com/112.80.181.45]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]