[{"id":3681858,"web_url":"http://patchwork.ozlabs.org/comment/3681858/","msgid":"","date":"2026-04-24T08:14:56","subject":"Re: [PATCH] macintosh: windfarm_core: fix reference leak on failed\n device registration","submitter":{"id":91722,"url":"http://patchwork.ozlabs.org/api/people/91722/","name":"Guangshuo Li","email":"lgs201920130244@gmail.com"},"content":"Hi,\n\nPlease disregard this patch.\n\nOn Wed, 15 Apr 2026 at 22:46, Guangshuo Li wrote:\n>\n> When platform_device_register() fails in windfarm_core_init(), the\n> embedded struct device in wf_platform_device has already been\n> initialized by device_initialize(), but the failure path does not drop\n> the device reference for the current platform device:\n>\n> windfarm_core_init()\n> platform_device_register(&wf_platform_device)\n> device_initialize(&wf_platform_device.dev)\n> setup_pdev_dma_masks(&wf_platform_device)\n> return platform_device_add(&wf_platform_device)\n>\n> This leads to a reference leak when platform_device_register() fails.\n> Fix this by checking the return value and calling platform_device_put().\n>\n> The issue was identified by a static analysis tool I developed and\n> confirmed by manual review.\n>\n> Fixes: 75722d3992f57 (\"[PATCH] ppc64: Thermal control for SMU based machines\")\n> Cc: stable@vger.kernel.org\n> Signed-off-by: Guangshuo Li \n> ---\n> drivers/macintosh/windfarm_core.c | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n>\n> diff --git a/drivers/macintosh/windfarm_core.c b/drivers/macintosh/windfarm_core.c\n> index 5307b1e34261..4003e72f3a57 100644\n> --- a/drivers/macintosh/windfarm_core.c\n> +++ b/drivers/macintosh/windfarm_core.c\n> @@ -436,9 +436,14 @@ EXPORT_SYMBOL_GPL(wf_clear_overtemp);\n>\n> static int __init windfarm_core_init(void)\n> {\n> + int err;\n> +\n> DBG(\"wf: core loaded\\n\");\n>\n> - platform_device_register(&wf_platform_device);\n> + err = platform_device_register(&wf_platform_device);\n> + if (err)\n> + platform_device_put(&wf_platform_device);\n> +\n> return 0;\n> }\n>\n> --\n> 2.43.0\n>\n\nAfter re-checking it, wf_platform_device is a static platform_device and\nit does not provide a dev.release callback. Therefore calling\nplatform_device_put() on the platform_device_register() failure path is\nnot appropriate here and can trigger the missing release callback\nwarning.\n\nThis falls into the same static platform_device pattern pointed out in\nthe other reviews, so I will drop this patch.\n\nSorry for the noise.\n\nBest regards,\nGuangshuo Li","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=NApUXd2r;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20049-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=pass smtp.remote-ip=\"2607:f8b0:4864:20::b131\" arc.chain=google.com","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=NApUXd2r;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com\n (client-ip=2607:f8b0:4864:20::b131; helo=mail-yx1-xb131.google.com;\n envelope-from=lgs201920130244@gmail.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g25P53mHZz1yDD\n\tfor ; Fri, 24 Apr 2026 18:15:21 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g25P45Ks5z2yFm;\n\tFri, 24 Apr 2026 18:15:20 +1000 (AEST)","from mail-yx1-xb131.google.com (mail-yx1-xb131.google.com\n [IPv6:2607:f8b0:4864:20::b131])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g25Nx6J8Pz2xly\n\tfor ; Fri, 24 Apr 2026 18:15:13 +1000 (AEST)","by mail-yx1-xb131.google.com with SMTP id\n 956f58d0204a3-651b4d09141so10204790d50.1\n for ;\n Fri, 24 Apr 2026 01:15:13 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777018520;\n\tcv=pass;\n b=aH1Kn+t+/JaMUrjqw5xLHTJbve/39+v1T/AXID4WVDCe0F8eu6EwmYpivbsJpKD/s8QzuByzT7cK+96RClco5BEhO/XG2i5jDM09BFD/oH4L4CUekuJoRIekoHapNimp3mPSZBb40IKbzhUfcqpXG/nQ0FOE2HrHMJcffCIYafbGGjiV4Kw21hDddo35fYYk4eYxYoNbOj/pyog2RFo0GszD+sPPfNlUlykO2dEFULOpIF4ZslAjYw0OS/Ge6X0cxXR0xuQ178vJsoj6lBxuGwqVCMUILqiZ7RwTuleG9nFE1+YHPLYuX4exVdkxuQ74ALt2HTv46XD/j6gYGms55Q==","i=1; a=rsa-sha256; t=1777018511; cv=none;\n d=google.com; s=arc-20240605;\n b=JXQnkMWrSZy4GME0p3LBD1/AAtvEZycnXhqvWW1plPZDdAsoMbvYCeVRXT4Wat484Y\n iKCn9ZgYReh6aI2S436a6wy6/7ULsOA4YIgt64tsSgNxTz3zv1SxVNMs8gPIQgZEt1iB\n 8GMT00DyvAXUDLqE8v74QAdesB+9uJoZvlqhnzvfccjsAH3bO+SSgB/nBkDePmJxJfgq\n hteJVh9GfsQ1FWFJJaI4QZB0ZXDX2a3phN9azxszMjc3dGL5RlTwfFipOv6GrfSz1j9+\n tah83gAOR/HzI2ikGbwli7vpA+6zc4bLyagf+xLDm4caVae6m95b3833vE4JPWL2yQ1X\n x6Cg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777018520; c=relaxed/relaxed;\n\tbh=XoTQ4s/qNuwga1dSku+5JUJ8IacqDxrPAbEtqeudZ8E=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=L9/W7KqkGbx7RMLgMagiZVubcnVl8MRUQVJmh6llJw7y4hbg2rvLaUk7O1i60sa/6byzx8ifz3tO/Ux1u+Eo145FlpXJb9YLnC6dWGm42YwX+GmjmNqfXIfEP8f1zHkfeVWHZDxoxCBpTClkibiKHtHkQDNgsUE+fqaE0UhOLpkobp3xlGK/tw4Bckg63QSMMWD6nztAMiQHdErb7C+JIZfufbRHCqxZ83/VfNCaWoFE5Z8yR3WsX//EoWJZPRTC1pD+0bN7yrNb7z/YM9/CBuU8jtYcTSn/zhfwfVsgNtDOivhAPz2bUXKbrSyTz/CllZUcY5Z1Qfikqrbs5+/TZQ==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=XoTQ4s/qNuwga1dSku+5JUJ8IacqDxrPAbEtqeudZ8E=;\n fh=5+XltSyDGWNj6OF8HXrDD+zIqHHS09zgcRlbGGJF1eU=;\n b=gPlEfUntZb3+mQt8IXKFvfA/6kc7e+Pt1KO2eUi3fs0DfqyvMfhJHkeYRHNHtxQUhp\n KHnv79utN9UrLVmJ0OtTpn1cSne7HeQboFHRN2zVxu4otfMA0LKxwcuxBMNAIeNMoeP0\n Rq2V5ebrcTPx4QjsVRsymuug20v+W3m9CuDYsz3nZ9soKTzgFX5YKN5JimlOFM9eUSZK\n 4QlrHvjQ7iUyjLBDSVZ0blfqTntN4/iY6C+dz3PrfY1bB5GqXAs2qxoC8c5XNBVivQGk\n C5wBl36wuLugaXp5TdlrWYcVlrVlmxsI587Mc1ncEQlHT02qAklNAxGHGyeTPHazBgQm\n zgfg==;\n darn=lists.ozlabs.org"],"ARC-Authentication-Results":["i=2; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=NApUXd2r; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::b131; helo=mail-yx1-xb131.google.com;\n envelope-from=lgs201920130244@gmail.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777018511; x=1777623311;\n darn=lists.ozlabs.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=XoTQ4s/qNuwga1dSku+5JUJ8IacqDxrPAbEtqeudZ8E=;\n b=NApUXd2rhM6k7sTGFUxkYhIZw/ktop0DGXp1xBiKYi5boZ1vk8S3BuLQRvwOXrPjdh\n wWU62vG9Z8EZHVE4p4ZRgKqmQTCLRicoycMd8zobLGvCgZnPohSAprGbeFE4RThfq1EA\n Pzhc9SwP5gjC7nMuOdrDTk07kGOBAZFmCW4qDrgoDGPOXg9cncnA8sDO3ZU5u7/LNf5O\n EKZVAE17DWBnWkCr9OlGHcikdKbpEcUoflih4nskYiyI5+xXYSUVPKfXq+NRpJOff/Kl\n psNw/xlfWYXNKM+UE3vpNw6mwE9awoWo0C7Z5xaxQrx4WvKScs47vtHLsvBNGMXTBhe7\n Dl/g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777018511; x=1777623311;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=XoTQ4s/qNuwga1dSku+5JUJ8IacqDxrPAbEtqeudZ8E=;\n b=DzvoKqldrxJ+4NgeXaBYuD2CCcAps2zJNEj01QtdE9u8nGU4sIP43qKVARQJxKR7je\n ivsmV3MSPjXYBr3iEdk0yqGz/KxmZhw2E1MnkMuNO9rzjglkF8OEzMVEYG1TLPtOmx1g\n IJdoYTnb3Qwo3/jJKbL59QV492F9eMf0xzAv+rhOr+OBvXLzMAx7lFJRLrj6O7cI8H7r\n S63fHCNrObYgZ241azq+K2edjHN6fh9icP3jl+LFOe0NUtJB3upFQSm3DqhlZbA0AqUg\n h+jF9DJIu/HnI8Wf+CivLKFm6qX84mV1lJhyC9tCM+agbzJ8/PtzDt5IirkVhArn7CxU\n L1rA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9hREmxJ5nXVSnWBYL41Qj22xMQjTDniYA+mwYNfmX0Weuv80q+dBzKwyeIg4RA8hu1yX1cymFaggGUa1o=@lists.ozlabs.org","X-Gm-Message-State":"AOJu0YxJ38cT2nQrxAugJPh3VVh+RZq6VcNvR+XmYLWEx//u6Z+4Slde\n\tWJ5R3hBWtKYv+VQMRQb8qZ6d+RA4uP7Yy7SO8UqkrO922W0p4UGzjWp6PdqdL6uARHnttnK3NXN\n\tgKMffbJj1iSDtIPPfKoH4NgQKNfGrU/Zfcxzp/ZY=","X-Gm-Gg":"AeBDieunITEa+5eWP3MJ5iKVd5HvYocMmdqA6O3+7MqNT4L58dZXik78+CaNwqHQhGQ\n\tkJ3nnC40HWXJQFeSOadH6iFNb5hFASo8Gwx8V1ggYOnH9pcl8nHOFUurp9LCbJMIoR79dQKBZ8G\n\tsJj287JAvg1nPgI++qK+/BCL0gpxroela+/s6CN9kzlt7Sq1j0hOGmMP1iRxNIY/I3ltefelrGV\n\to74/Vti5ywiTb7zyt/H1fC5GlI9QggZEyt7ski1hHqiDn40x27nqLXPy7TbpJ7AupdcsADbNk2n\n\t3h0UZqB7u6abMF8lNwOa","X-Received":"by 2002:a05:690e:2486:b0:654:3fca:3515 with SMTP id\n 956f58d0204a3-6543fca3bcdmr7674478d50.30.1777018511504; Fri, 24 Apr 2026\n 01:15:11 -0700 (PDT)","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","References":"<20260415144635.3318697-1-lgs201920130244@gmail.com>","In-Reply-To":"<20260415144635.3318697-1-lgs201920130244@gmail.com>","From":"Guangshuo Li ","Date":"Fri, 24 Apr 2026 16:14:56 +0800","X-Gm-Features":"AQROBzAFZKMpsNmPGDIOC_UCfbe-Rxj_nU9Bws4LOoucZmHnDsWY6cx-wzEa2m8","Message-ID":"\n ","Subject":"Re: [PATCH] macintosh: windfarm_core: fix reference leak on failed\n device registration","To":"Guangshuo Li ,\n Paul Mackerras ,\n\tBenjamin Herrenschmidt ,\n linuxppc-dev@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org","Cc":"stable@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-Spam-Status":"No, score=0.4 required=3.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n\tFREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,FROM_LOCAL_DIGITS,\n\tFROM_LOCAL_HEX,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]