[{"id":3678049,"web_url":"http://patchwork.ozlabs.org/comment/3678049/","msgid":"","list_archive_url":null,"date":"2026-04-16T09:26:14","subject":"Re: [ovs-dev] [PATCH ovn v2 2/5] pinctrl: Fix garp_rarp waking up\n pinctrl thread too often.","submitter":{"id":82231,"url":"http://patchwork.ozlabs.org/api/people/82231/","name":"Xavier Simonart","email":"xsimonar@redhat.com"},"content":"Hi\n\nA multinode test (\"18: HA: Check for missing garp on leader when BFD goes\nback up\") is sometimes failing when\napplying this patch.\nWhile it requires further investigation, it looks like pinctrl does not\nproperly wake up in some cases, resulting in\nmissing garps.\nI'll continue investigation and send v3.\n\nThanks\nXavier\n\nOn Wed, Apr 15, 2026 at 2:37 PM Xavier Simonart wrote:\n\n> Avoid garp_rarp waking up pinctrl when no change.\n> As, with this patch, pinctrl is only waken up by garp_rarp when there are\n> garp_rarp changes, add a peridic wake up for pinctrl for syncing\n> coverage counters. Without this, pinctrl might sleep for a long time\n> if no event such as packet_in, and recently updated counters might\n> not be sync'ed and hence not updated in appctl coverage/show.\n>\n> Fixes: 05527bd6ccdb (\"controller: Extract garp_rarp to engine node.\")\n> Signed-off-by: Xavier Simonart \n>\n> ---\n> -v2: Fix coverage counter issue reported by\n> \"dns lookup : 1 HV, 2 LS, 2 LSPs/LS\" and by Ales.\n> ---\n> controller/garp_rarp.c | 2 +-\n> controller/pinctrl.c | 2 ++\n> 2 files changed, 3 insertions(+), 1 deletion(-)\n>\n> diff --git a/controller/garp_rarp.c b/controller/garp_rarp.c\n> index 9d0c2c2e4..162fa0446 100644\n> --- a/controller/garp_rarp.c\n> +++ b/controller/garp_rarp.c\n> @@ -565,7 +565,7 @@ garp_rarp_get_data(void)\n> bool\n> garp_rarp_data_changed(void) {\n> bool ret = garp_rarp_data_has_changed;\n> - garp_rarp_data_has_changed = true;\n> + garp_rarp_data_has_changed = false;\n> return ret;\n> }\n>\n> diff --git a/controller/pinctrl.c b/controller/pinctrl.c\n> index f62022361..1ad058f2b 100644\n> --- a/controller/pinctrl.c\n> +++ b/controller/pinctrl.c\n> @@ -4048,6 +4048,8 @@ pinctrl_handler(void *arg_)\n> latch_wait(&pctrl->pinctrl_thread_exit);\n>\n> ovsrcu_quiesce_start();\n> + /* Wake-up periodicaly for coverage counters sync.*/\n> + poll_timer_wait(1000);\n> poll_block();\n> }\n>\n> --\n> 2.47.1\n>\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KA+dwbAy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::133; helo=smtp2.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp2.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KA+dwbAy","smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp4.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=KA+dwbAy"],"Received":["from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxCM03KJ5z1yCv\n\tfor ; Thu, 16 Apr 2026 19:26:36 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp2.osuosl.org (Postfix) with ESMTP id 983DF401E1;\n\tThu, 16 Apr 2026 09:26:34 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id qIpnWC8Vw7LT; Thu, 16 Apr 2026 09:26:33 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp2.osuosl.org (Postfix) with ESMTPS id 9A90940090;\n\tThu, 16 Apr 2026 09:26:33 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 80427C054A;\n\tThu, 16 Apr 2026 09:26:33 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists.linuxfoundation.org (Postfix) with ESMTP id DA13FC0549\n for ; Thu, 16 Apr 2026 09:26:31 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id BD1D74084F\n for ; Thu, 16 Apr 2026 09:26:31 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id hRJIPJ9EXHt1 for ;\n Thu, 16 Apr 2026 09:26:30 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 9EF8D4084E\n for ; Thu, 16 Apr 2026 09:26:29 +0000 (UTC)","from mail-qt1-f197.google.com (mail-qt1-f197.google.com\n [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-503-33vE3BHlPs-PE92cVymAOg-1; Thu, 16 Apr 2026 05:26:27 -0400","by mail-qt1-f197.google.com with SMTP id\n d75a77b69052e-50b31cff27fso38022931cf.3\n for ; Thu, 16 Apr 2026 02:26:27 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp2.osuosl.org 9A90940090","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9EF8D4084E"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=xsimonar@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 9EF8D4084E","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776331588;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=uLBg77TifLWeTFN2zhfKEmBjUkC7KN5pumevbC0xtwg=;\n b=KA+dwbAy83FDf9SSGm4hBRXKt/EesoDxXC1eW7qkzs6XANli94ze+gy7VN7OESRe7Plmgz\n T4box23tBdaS98FYRP5rwbBwCZFywVYyXP1WQYpEZaBDAOrvi7tJdjY53nRPtise1SOdQH\n YL69fPeK9TeK3Y0XLSythMVO9JV5Lw8=","X-MC-Unique":"33vE3BHlPs-PE92cVymAOg-1","X-Mimecast-MFC-AGG-ID":"33vE3BHlPs-PE92cVymAOg_1776331586","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776331586; x=1776936386;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=uLBg77TifLWeTFN2zhfKEmBjUkC7KN5pumevbC0xtwg=;\n b=T7ugHuevHoswY+qTIThij3CEWygTCmbHdHYvffIaJoO0btoZj8RB94q5Fm5MGVNe0L\n exXxxluxNyxpcLSbuMe8BHCG9kq2C0zNJ0gWo6mxgsvl7hEgrpfBK2RMdCryCw7nqO+f\n sXf6QV968XkpJ1p8n+eZnl/TrzeQEFDnws10j68mluQSkm6aOOIZytvFM5yMKzpe92N2\n 3xMpolDDRVW9txlH+JdNrpI3INgyVrT7uAcKk8lCdmWKZBpDj62ByAeP79CG+AWPRJqS\n aU1cld2xJP6zzrCD7w0+/EAcsnghRjK1mox37D5FA6Hh4ywsT7nAM9E3UeO4CUV0I3yz\n FMiA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+fXeHJRG2c/HYhk+igbszyEqvSguCJkZepusdtOwxDYmPpUkQt8i5scdj6rzlOB+OWEpQ=@openvswitch.org","X-Gm-Message-State":"AOJu0Yzqo142hKd0+rdX+EgT+vceS3FrDTgdfTiFpjK61X6yUd7wxryn\n y3SwRfPIom1Rxk2qpHLXOSiyKZcBWnHl0Zgsv36zUB+6P94WYSKi61jQ2AtC13YGaxl5qA4aNE4\n xcd8j8CxsYzjBTx8a1z02xQinuaZJ20g1K1n0GJRCeIs0baLyXcc/Dol/2BPKw1MRnudl62KKlX\n HKkXZW56j6MnL6Dz6ZU4/pvtNhj3sW","X-Gm-Gg":"AeBDieuPpeV0K+SeSfqiRMmSXSpil/8YvVZrnEm22IRo+WEYrXYP2XvzNrWTT0yN1np\n G4+krR44HHQH+P4V3/j+UYaVSheHz9+nlDSsgVdXAbTIGD1Xf4ahG28CgLPYbWOGYK8YHFcjn3F\n 62qvlOgSJr33wn3H6X8/kJakdeGuwO021IFtkSCANjnSiFpoGmW+z7mwC7MfbBqbp3j+dDhRTKu\n V3sqOI=","X-Received":["by 2002:a05:622a:1493:b0:501:1466:8419 with SMTP id\n d75a77b69052e-50dd5b9aab6mr362908171cf.29.1776331586597;\n Thu, 16 Apr 2026 02:26:26 -0700 (PDT)","by 2002:a05:622a:1493:b0:501:1466:8419 with SMTP id\n d75a77b69052e-50dd5b9aab6mr362907931cf.29.1776331586103; Thu, 16 Apr 2026\n 02:26:26 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260414152254.991243-5-xsimonar@redhat.com>\n <20260415123716.1084463-1-xsimonar@redhat.com>\n <20260415123716.1084463-2-xsimonar@redhat.com>","In-Reply-To":"<20260415123716.1084463-2-xsimonar@redhat.com>","Date":"Thu, 16 Apr 2026 11:26:14 +0200","X-Gm-Features":"AQROBzARnYjeIITjD89wJqDLMzbNT3AkbPcZrYAFOer92oDukrPZuS_gAdekkEI","Message-ID":"\n ","To":"xsimonar@redhat.com, dev@openvswitch.org","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"H7LAgCd_1g_iai5w7ceF3q3XJ3UVdGxMF7V--rMAmzs_1776331586","X-Mimecast-Originator":"redhat.com","X-Content-Filtered-By":"Mailman/MimeDel 2.1.30","Subject":"Re: [ovs-dev] [PATCH ovn v2 2/5] pinctrl: Fix garp_rarp waking up\n pinctrl thread too often.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Xavier Simonart via dev ","Reply-To":"Xavier Simonart ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "}}]