[{"id":3678137,"web_url":"http://patchwork.ozlabs.org/comment/3678137/","msgid":"<8c887680-fd28-4ffa-a1f4-41c1af1bd8b9@nvidia.com>","list_archive_url":null,"date":"2026-04-16T12:29:51","subject":"Re: [ovs-dev] [PATCH v3] tests: Rework DPDK offload tests to use a\n simpler interface argument.","submitter":{"id":79848,"url":"http://patchwork.ozlabs.org/api/people/79848/","name":"Eli Britstein","email":"elibr@nvidia.com"},"content":"On 15/04/2026 14:42, Eelco Chaudron wrote:\n> External email: Use caution opening links or attachments\n>\n>\n> This patch refactors the DPDK offload test infrastructure to simplify\n> the interface configuration. Instead of using OVS_DPDK_VF_PCI_ADDRS\n> with a space-separated list of PCI addresses and VF indices (e.g.,\n> \"0000:17:00.0,0 0000:17:00.0,1\"), the tests now use OVS_PF_PCI\n> with a single PF address (e.g., \"0000:17:00.0\") and derive VF\n> information from sysfs.\n>\n> Signed-off-by: Eelco Chaudron \n> ---\n> Changes to v3:\n> - Fixed documentation.\n> - Changed test macro names from xxxx_netdev() to xxx_port().\n> - Use local variables in shell macros.\n> Changes to v2:\n> - Use PCI address rather than port name, so other blades might\n> be supported.\n> - Moved/renamed shell helpers.\n> - Updated documentation.\n> ---\n> Documentation/topics/testing.rst | 24 +++---\n> tests/system-common-macros.at | 90 ++++++++++++++++++++++\n> tests/system-dpdk-offloads-macros.at | 108 ++++-----------------------\n> 3 files changed, 120 insertions(+), 102 deletions(-)\n\nHi Eelco,\n\nThe macros still has some references to \"netdev\" instead of \"port\" (see \nbelow). Other than that LGTM.\n\nThose are only comments there, so I'm fine also with keeping it.\n\nIf you prefer to keep:\n\nAcked-by: Eli Britstein \n\n>\n...\n> +# ovs_get_vf_port(, )\n> +#\n> +# This function tries to find the VF's netdev for the given PF's VF index.\ns/netdev/port\n> +#\n> +ovs_get_vf_port() {\n> + local PF_PCI=$1\n> + local VF_IDX=$2\n> +\n> + local vf_net_dir=\"/sys/bus/pci/devices/$PF_PCI/virtfn$VF_IDX/net\"\n> + if test ! -d \"$vf_net_dir\"; then\n> + return 1\n> + fi\n> +\n> + local vf_name=$(ls \"$vf_net_dir\" 2>/dev/null | head -1)\n> + if test -z \"$vf_name\"; then\n> + return 2\n> + fi\n> +\n> + echo \"$vf_name\"\n> + return 0\n> +}\n> +\n> +# ovs_get_representor_port(, )\n> +#\n> +# This function tries to find the representor's netdev for the given PF's VF\ns/netdev/port\n> +# index.\n> +#\n> +ovs_get_representor_port() {\n> + local PF_PCI=$1\n> + local VF_IDX=$2\n> +\n> + local representor=$(grep -l \"vf$VF_IDX$\" \\\n> + /sys/bus/pci/devices/$PF_PCI/net/*/phys_port_name \\\n> + 2>/dev/null | head -1)\n> + if test -z \"$representor\"; then\n> + return 2\n> + fi\n> +\n> + basename $(dirname \"$representor\")\n> + return 0\n> +}\n> +\n> +# ovs_verify_pf_cfg()\n> +#\n> +# Verify that the given PF port exists and that the required VFs are properly\n> +# configured, i.e. have representor ports.\n> +#\n> +ovs_verify_pf_cfg() {\n> + local PF_PCI=$1\n> + local VF_NAMES=()\n> + local REPRESENTOR_NAMES=()\n> + local PCI_REGEX=[[0-9a-fA-F]]{4}:[[0-9a-fA-F]]{2}:[[0-9a-fA-F]]{2}\\.[[0-7]]\n> + local vf_net_dir vf_name representor i\n> +\n> + echo \"$PF_PCI\" | grep -E -q \"^$PCI_REGEX$\" || return 1\n> +\n> + for i in {0..5}; do\n> + # Get VF netdev using PCI path\ns/netdev/port\n> + vf_net_dir=\"/sys/bus/pci/devices/$PF_PCI/virtfn$i/net\"\n...","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=ipuhS1LI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp4.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key,\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=ipuhS1LI","smtp4.osuosl.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxHQg0GL6z1yG9\n\tfor ; Thu, 16 Apr 2026 22:30:03 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 2C2E340283;\n\tThu, 16 Apr 2026 12:30:01 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id v0s6Wgr887gP; Thu, 16 Apr 2026 12:30:00 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp4.osuosl.org (Postfix) with ESMTPS id E55CC4016A;\n\tThu, 16 Apr 2026 12:29:59 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id BE9F6C054A;\n\tThu, 16 Apr 2026 12:29:59 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 601C8C0549\n for ; Thu, 16 Apr 2026 12:29:58 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 4C5784018A\n for ; Thu, 16 Apr 2026 12:29:58 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id nPpYBOHKyW-0 for ;\n Thu, 16 Apr 2026 12:29:57 +0000 (UTC)","from CY7PR03CU001.outbound.protection.outlook.com\n (mail-westcentralusazlp170100005.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c112::5])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 882A04016A\n for ; Thu, 16 Apr 2026 12:29:57 +0000 (UTC)","from DS0PR12MB7727.namprd12.prod.outlook.com (2603:10b6:8:135::5) by\n IA1PR12MB6554.namprd12.prod.outlook.com (2603:10b6:208:3a2::15) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.21; Thu, 16 Apr\n 2026 12:29:53 +0000","from DS0PR12MB7727.namprd12.prod.outlook.com\n ([fe80::7314:dd8a:a3fe:a835]) by DS0PR12MB7727.namprd12.prod.outlook.com\n ([fe80::7314:dd8a:a3fe:a835%4]) with mapi id 15.20.9818.023; Thu, 16 Apr 2026\n 12:29:53 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org E55CC4016A","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 882A04016A"],"Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2a01:111:f403:c112::5;\n helo=cy7pr03cu001.outbound.protection.outlook.com;\n envelope-from=elibr@nvidia.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 882A04016A","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=BDZZGiMW/jUYW6rpw2JkbQe119l5VxuZIz+uwAjPFjYjX/jzbtKo3QQ/naBl3pjTWTi2OpJHw+CgqKZj9rgXtuwnC0/fNp220newHilyl64/SBUP10Il4SGW7pP84wA2vjtYDS4ezTGCHiiEjFPZa2uwrq0G54rSXdZRmdilwOIeM7JsS0FKoflXnh+9uhyiO43StGx3HREIDE9B9DUARcBR2PtN6c7yzhz7jaZV86OmedEckpzIpvAbMwuIv/hNE12YxpYaiH9DaipPsaRaTNCKS2gfEw4bsUX21aq/TYd/lSDGjzRgGqWq9swPgMloMy5mBWqdj34woZFrA1FGqg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=5/58qV3N0guL5ILFnMPEr5wlv3qa9gkNEv422YROYe4=;\n b=DeB1DCe/lJbdder9pcvkysF483ildPQImGGpUfnQ1c9E2ytEdlOv0BSxNd1gMb1VDrfNEsn1gx4Ud/FGNcfGTsAp8FJBfyZZTGcaX0avnfY2nwN64wm8x+OGgkHbjgH2t7B+O3+u1wMB2iDOktkRGKPrD8YdhtVmmZ3ipXMsEML4fF63QEUjxvlHVkr+4YGdtzORWYfZI1ZeNotNLwYaShpm2bcar9HfOV4dhmPqJUx1iSiJJLlAsR7Zkl/3Uf+hxu5AgAMHISUo9QF+KV5I/JcijsFxxind2NciLYYtQtxE7ObUDagbJETAgX1OCGCB4qwPWf0PExoKF57RzdyRAw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=5/58qV3N0guL5ILFnMPEr5wlv3qa9gkNEv422YROYe4=;\n b=ipuhS1LIdkRzRlVRDBA93h+ka2bjhxN5jCxbcjsqtNKSC/lR05voDQ+Indp1u84v8SMh8FwaRuiRQlgVh3rKiaVf4d8WdxDurTu/s00GM3SC6R+Td9aWIq7Wk+NX0eehJbHSPO2UJM6jbJvnBmc1sYyVraSMHbLLJgE/ybIBf7VXv1k4wMOc84ug/Y15aDlez1aZs2yJ0Bbc/G2R0FRUUvYKgmLjj39o5XgwVP/IcyUSWNOdF5zN4Fb/SHK14SLCESOajG93eH+1IO5bM6/NXZ4KwGARFsHhYN9coHFus/aUt59ON3toMjpMB/oZ49vN8Ci+2nmeCrPukHXjsMXTog==","Message-ID":"<8c887680-fd28-4ffa-a1f4-41c1af1bd8b9@nvidia.com>","Date":"Thu, 16 Apr 2026 15:29:51 +0300","User-Agent":"Mozilla Thunderbird","To":"Eelco Chaudron , dev@openvswitch.org","References":"\n ","Content-Language":"en-US","In-Reply-To":"\n ","X-ClientProxiedBy":"FR4P281CA0106.DEUP281.PROD.OUTLOOK.COM\n (2603:10a6:d10:bb::10) To DS0PR12MB7727.namprd12.prod.outlook.com\n (2603:10b6:8:135::5)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS0PR12MB7727:EE_|IA1PR12MB6554:EE_","X-MS-Office365-Filtering-Correlation-Id":"51023993-7125-4498-6ce2-08de9bb3dc69","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|366016|1800799024|376014|56012099003|22082099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n xLpoql41uuyw1KG5cEibjTeZMMj+IqQTOeztGkKmOWbCxNiXY/uETOp8Wduq16ubFvyQhfqlPYJaEAgH5c5t8iVabjIrsSawEauNU7IGxp9GeIrTrfWqNaN2NZtX8BS/JVjj8WGg1Pf+M4ptrV/0lKVzjhSKjBjwrCix6TrMPlBI9Rf3/I0S2taVlKQ9JSOgTW0Nt1xselwVjiM1c/dhu3a9q/NVaEVcWsOp7cDZQ2Er6u28NmmQ+CYlktJ3wj9ZTtNjDCzgqSkkxBtaJ+IfitNvaKqlifQvwZM6rNJqvbalViufEeLZ6CcwnYi8Jb5xZ3RF3T3GQDxeEApmdXAtSaE6d0XGkhP8zKxbUKuZ+jD3v2BTOC6Q3JdlpvAl6ygfYSgrbbEobMxS35aaizLuVXulYG4Gd7B6w7rE41bQCfl4KNGfVH8rreugg5JiKeuwjJk2DcMD0RW/ZH+RMdrXtfhqv9dxBnWSdH7wDkDxWeNYacDY5qtHijKuNwTweUQ8i17GUC2VJr4pHNAAJtYu2olpT3lt3KyVx6mGe644IYCed3aFMbgGJDaSoHzPZXk+19Y4/Blgw/ffb65DdtT/vdolb5k3qCAjiaSfsA/sM7cJd+iUTzvqZ0NB+/4dGxfnb+7bHdVSekCVu5HCohSFfYvPn/hUeO//TBH+2IExhT9ha+gJ9hpkWocR3mpFtJKbqxOuShZ9If6LveAOOMnAyovGPLXNSknSoKMumf8LLDc=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DS0PR12MB7727.namprd12.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(366016)(1800799024)(376014)(56012099003)(22082099003)(18002099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?cLR3//gT+3AiiGtiRh8uAk9LDWWP?=\n\t=?utf-8?q?WleM0UCvJtdJq+/bYIx8elCKGJSYwH46Gap35LWDF7YvCX8cmKmG9MtLiSrAMfz2B?=\n\t=?utf-8?q?PYhGKw5flrwwhdryHD6AEptteV4KGE0t1fWbs5Yr+Wh67eYEISs7HKMf2OeV2eOh0?=\n\t=?utf-8?q?+3Eluev+IufmjQJZ/GbK3gpjZpsAfLtEdyGKDQBrsPX+6H+D9716WAuU1YFwOTtvt?=\n\t=?utf-8?q?p26G0kZIuxIuVqJ6AZkHUEscFtHKqaF3k/UJlD6ScpSsLm24/24dYrnZfc+Yi9eOy?=\n\t=?utf-8?q?y4la6JXhiNy6fl+YcGdiNoTZuN0rPm5yUaPKwog8pKcW3WMDXhwj9+NmDx2yumFiV?=\n\t=?utf-8?q?V60z2Dt5eU4zSX3W1PgBZeXzzn26DRzeJy1bdA0E5hXH4+3V0K9BnG0KYILhjCKNQ?=\n\t=?utf-8?q?dEu9b/b2N/CNKEZwEB+xMS5OPp4Zx+oNACh413CC+w7X+pRcAlndLCVtxHiF/Lf7+?=\n\t=?utf-8?q?VdF7CtXUWzz1cNdUjdE3+eeYSdwOVDsxSRAiZAiuVjwmLBgl2FQatANO4HE5WvsTj?=\n\t=?utf-8?q?s6bduJ5ZU3/z0XPsVEcHd467oWOPRSL4pwUel88L0qwu96vwZBWUpqHkqzc0pO2XE?=\n\t=?utf-8?q?GUFOWsdSyWovbteodCMAWKuZfx5Oe+jeXyaQqvNi5o0nobw8IVa0zQ1ZlOhRCiJWS?=\n\t=?utf-8?q?krDHyiXjJ+7exvgMrCY1xedsvgM4qSxz+gyE9ty2wstcYIslJBQKBvausQbFutOOS?=\n\t=?utf-8?q?eYY8F0JVsSWseFedvX1Lgkbw8XL2xzI+0ZEf15g4XDS/OxeFv+KhUMxcJmXafDHTU?=\n\t=?utf-8?q?kKUM7pJBXdS/twN3UT7QU+ha7FxY4vFVhNZqIyRsWW6xGoUH4QFRTqxte8wctCcJW?=\n\t=?utf-8?q?KGZprUAUSww7em4+OoEpykr8UgvwkBYWdzJE3ZIXpf+LihijAMMyAgQ5bHwtP+0pn?=\n\t=?utf-8?q?lobmqe9bG5H/Ovbb1RHM1rarO+3iqiluhynl60AePvuRdUuCuF3RYUFL8/oSp1fGC?=\n\t=?utf-8?q?emy1wuP9dnigAPpL5ofAiPK5CjvzSqlbc7/43vjD9bav9n6IfrIiquMofSffSnUyz?=\n\t=?utf-8?q?dYjmv8bjKivSO5SlWD2WRKSAl6jXPHw+epxcINh/fP9XJ96rGjsqJg33sUi0H0Its?=\n\t=?utf-8?q?NFmtIKMlbEZRegU6ndX9QZByM7kNMZvR4hYjlfeOCCwlaTjeB4WA49rHKKBObpcgs?=\n\t=?utf-8?q?ImMrXX7AgROP7U7jhei+mnvOhkpv8i9Usmdap7ax7+LfyrFJlSRbmBvi4ycfGIpaI?=\n\t=?utf-8?q?Ekx35x8PTPSwLi0u0g4xFZC3UOkgyyANbzswbHt2Jes3GCka+wcwJNfwuVc3qOO1B?=\n\t=?utf-8?q?Ai4Dcapj+hF9wEhVy3oJgaobtpqTOfl7eUkvVVpBuvRsp+Ql1+qMfeylsi9MgahYK?=\n\t=?utf-8?q?huhVWQkS6f0AXAg6xInE2jJcyIS0/KUG2WcW56yYj3bQKb5m9iT9uJr6lrMani5RS?=\n\t=?utf-8?q?UyBmm4Hp4CpPR4LG1HcXGvGRFRrK5cJgjhqMY6DNqw5F1+jheJR/g0+WXLgBO3k0m?=\n\t=?utf-8?q?+jtXFFwgApICuRLZ7tE4iJZzcH4d8gEwdc3DaqK4c1rYSAXs4AmwQ3jWH6YV3iPO4?=\n\t=?utf-8?q?hTGbp1Be8wqnEasOkqZ1FMvKfX7p2M87R6K9tjGluw047pdi3fQ0JN3OApdL+NNTP?=\n\t=?utf-8?q?i6g94oGwfXVOfBu8V6ZBJoUTFeIKm4y7TBK0k1nTHBpglxc7Q9k2oktUpe9Qa5gZo?=\n\t=?utf-8?q?qM6FYjr75HQ5pOXBHI7RfR4bKZWgu/hw=3D=3D?=","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 51023993-7125-4498-6ce2-08de9bb3dc69","X-MS-Exchange-CrossTenant-AuthSource":"DS0PR12MB7727.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"16 Apr 2026 12:29:53.5197 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n ye2L83CQZSA60AEqRtGLMhxi5cCFZ8hJVL8KdhHskdObK6y2NsNJEvv6h+0Z+eSjiALkkhJxqmgu+XMhkB/w4g==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"IA1PR12MB6554","Subject":"Re: [ovs-dev] [PATCH v3] tests: Rework DPDK offload tests to use a\n simpler interface argument.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Eli Britstein via dev ","Reply-To":"Eli Britstein ","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "}},{"id":3683382,"web_url":"http://patchwork.ozlabs.org/comment/3683382/","msgid":"","list_archive_url":null,"date":"2026-04-28T11:08:20","subject":"Re: [ovs-dev] [PATCH v3] tests: Rework DPDK offload tests to use a\n simpler interface argument.","submitter":{"id":70613,"url":"http://patchwork.ozlabs.org/api/people/70613/","name":"Eelco Chaudron","email":"echaudro@redhat.com"},"content":"On 16 Apr 2026, at 14:29, Eli Britstein wrote:\n\n> On 15/04/2026 14:42, Eelco Chaudron wrote:\n>> External email: Use caution opening links or attachments\n>>\n>>\n>> This patch refactors the DPDK offload test infrastructure to simplify\n>> the interface configuration. Instead of using OVS_DPDK_VF_PCI_ADDRS\n>> with a space-separated list of PCI addresses and VF indices (e.g.,\n>> \"0000:17:00.0,0 0000:17:00.0,1\"), the tests now use OVS_PF_PCI\n>> with a single PF address (e.g., \"0000:17:00.0\") and derive VF\n>> information from sysfs.\n>>\n>> Signed-off-by: Eelco Chaudron \n>> ---\n>> Changes to v3:\n>> - Fixed documentation.\n>> - Changed test macro names from xxxx_netdev() to xxx_port().\n>> - Use local variables in shell macros.\n>> Changes to v2:\n>> - Use PCI address rather than port name, so other blades might\n>> be supported.\n>> - Moved/renamed shell helpers.\n>> - Updated documentation.\n>> ---\n>> Documentation/topics/testing.rst | 24 +++---\n>> tests/system-common-macros.at | 90 ++++++++++++++++++++++\n>> tests/system-dpdk-offloads-macros.at | 108 ++++-----------------------\n>> 3 files changed, 120 insertions(+), 102 deletions(-)\n>\n> Hi Eelco,\n>\n> The macros still has some references to \"netdev\" instead of \"port\" (see below). Other than that LGTM.\n>\n> Those are only comments there, so I'm fine also with keeping it.\n>\n> If you prefer to keep:\n>\n> Acked-by: Eli Britstein \n\nI changed the API as we use ports in the test cases. For the description, I kept netdev as these are what they are from a Linux perspective.\n\nOnce again thanks for your review, and I applied these changes to main!\n\n//Eelco\n\n[...]","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=PRa/5xeQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp4.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=PRa/5xeQ","smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp3.osuosl.org; dkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=PRa/5xeQ"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4d372505z1yHv\n\tfor ; Tue, 28 Apr 2026 21:08:34 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 26469412EE;\n\tTue, 28 Apr 2026 11:08:33 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id bnpY1loTuv6r; Tue, 28 Apr 2026 11:08:32 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp4.osuosl.org (Postfix) with ESMTPS id 4CA9440BF4;\n\tTue, 28 Apr 2026 11:08:32 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 0E2A0C04FB;\n\tTue, 28 Apr 2026 11:08:32 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists.linuxfoundation.org (Postfix) with ESMTP id B9E95C04FA\n for ; Tue, 28 Apr 2026 11:08:30 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 995AB60FFF\n for ; Tue, 28 Apr 2026 11:08:30 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id QzTEBBBkCsOS for ;\n Tue, 28 Apr 2026 11:08:29 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 80F7460FFC\n for ; Tue, 28 Apr 2026 11:08:28 +0000 (UTC)","from mail-ej1-f72.google.com (mail-ej1-f72.google.com\n [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-553-st0hBx3pNp6Pg-HwpRDa4w-1; Tue, 28 Apr 2026 07:08:25 -0400","by mail-ej1-f72.google.com with SMTP id\n a640c23a62f3a-b8f848ebcbbso868214666b.0\n for ; Tue, 28 Apr 2026 04:08:25 -0700 (PDT)","from [10.44.49.209] (5920ab7b.static.cust.trined.nl.\n [89.32.171.123])\n by smtp.gmail.com with ESMTPSA id\n 4fb4d7f45d1cf-679b67ccc30sm625807a12.1.2026.04.28.04.08.22\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Tue, 28 Apr 2026 04:08:22 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4CA9440BF4","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 80F7460FFC"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=echaudro@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 80F7460FFC","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777374507;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=4g70eX/gZt1VK9kIeNN3X2xYlVQjbsx5wJK1UFcJXU8=;\n b=PRa/5xeQgxamMkq9QqlpOANpMNelajVkCXFtZM/vpZoLhkkNN8LQZxpBI4KCraiAoo2JHt\n m2L7Ik09whq7lANz7hiqDxhYroV/ESQjYQXs+Vji4MlVMCdn8rBLnPx53c6H756CUvSXi1\n lioWi2lcp8A88UUS/n+yde9ECPW6IR4=","X-MC-Unique":"st0hBx3pNp6Pg-HwpRDa4w-1","X-Mimecast-MFC-AGG-ID":"st0hBx3pNp6Pg-HwpRDa4w_1777374505","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777374504; x=1777979304;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Ia/XVsr6Fj/YWHeHVhyZmAEDamXAMBQo3QUNykR3t2Y=;\n b=ZWLyyUy5zzlG8KxK78qe09041bjC1QC4TPgf4ia5rBGy8is+slVBMXoeCZ/8UfiJbp\n JCLWxk/qsSmg+gRi14ROQjyFjN3rXOLMef0FVyHYGt6l3U2jpgwET9QloqQuk5bK7k6J\n Ss2sgWxJgzNiJZ0jWb7VAHQ4U9yLvbceduy3Y2udikAMNdgVf/oEDEA83VW3OlFanaYI\n SVuxu2AUDbQOLMSu7In29RhMa1jpQFnXERoJYrx2P9hM7cXxmeZE/iMEdXofAQFRwaIy\n eVwIx1pqyRMUfJ7MicVin1xXJr7jPBnfr4NngMI8hymKyfrdRvf/GdbudIir8AAddPy0\n B1Xw==","X-Gm-Message-State":"AOJu0YwkhHTt3eo26ZDYUZpJZ/FNC6ptPoExLhsvoQY8HK8ZZJON5Gxw\n Nh86YGrnF9jgqaxMUeAY4bK4Y8x8zcyLD2bJbPBV9lIniJSaGqaf3PGL9bLqPOAjuct9a6NQzjG\n bp55zskWBezQopaQpXT6beZ8Ebw3g86Sg4P8aoGT6G1dbZyQe346V2w==","X-Gm-Gg":"AeBDieuiJWBEbkpHhXwAWMlwFvfYx+xF6B3Vg9zjrbApil37xLKzed89+5whgRz/jVJ\n KpKyCotI2aDfzB1F7gb70wpAlMq3hZSWsj8rMNbVMIiYqWr+3YYL+L6bHaRyHtGgv2j+15Yi3gm\n g4pScty7zHCoOaOfWOFrMPwvIJRqJmsuhLsJPK/4E3RSjp7d1SDgGoS8uOczyscGlO32QTRs0lI\n rLJcEFxdUt/wGYvNe+VDsBFLUUaPXkjNrh+TjobKnGNFihTsJuDOwKeruCh7cDjn458NJiT1hE6\n hshuFT4KJbQYGQqubywR5nIMGsyzQwNllf5D8qKC2VlLuBqdTgAmPjNfYcZD55dX9ik/8cj7pbZ\n n9j0mALrElHu1mg+HZtECLV92cK/yierblMS8kR06x6b63BMN7wn3kLIpyAOfCQDaRZ0G63MDkP\n Qw2jGFYA==","X-Received":["by 2002:a17:907:c007:b0:bb7:eb68:514e with SMTP id\n a640c23a62f3a-bb804a2b545mr156392866b.36.1777374504404;\n Tue, 28 Apr 2026 04:08:24 -0700 (PDT)","by 2002:a17:907:c007:b0:bb7:eb68:514e with SMTP id\n a640c23a62f3a-bb804a2b545mr156391366b.36.1777374503867;\n Tue, 28 Apr 2026 04:08:23 -0700 (PDT)"],"To":"Eli Britstein ","Cc":"dev@openvswitch.org","Date":"Tue, 28 Apr 2026 13:08:20 +0200","X-Mailer":"MailMate (2.0r6292)","Message-ID":"","In-Reply-To":"<8c887680-fd28-4ffa-a1f4-41c1af1bd8b9@nvidia.com>","References":"\n \n <8c887680-fd28-4ffa-a1f4-41c1af1bd8b9@nvidia.com>","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"rFNeHlqFr7bs9eq3VO1D3MzjdeaJSr7vqAFYHmXprdo_1777374505","X-Mimecast-Originator":"redhat.com","Subject":"Re: [ovs-dev] [PATCH v3] tests: Rework DPDK offload tests to use a\n simpler interface argument.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Eelco Chaudron via dev ","Reply-To":"Eelco Chaudron ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "}}]