[{"id":3677718,"web_url":"http://patchwork.ozlabs.org/comment/3677718/","msgid":"<20260415-rectal-visible-a8ccb534a176@spud>","list_archive_url":null,"date":"2026-04-15T15:01:03","subject":"Re: [PATCH v2 2/3] dt-bindings: gpio: Add EIO GPIO compatible to\n gpio-zynq","submitter":{"id":84372,"url":"http://patchwork.ozlabs.org/api/people/84372/","name":"Conor Dooley","email":"conor@kernel.org"},"content":"On Wed, Apr 15, 2026 at 04:26:27PM +0530, Shubhrajyoti Datta wrote:\n> EIO (Extended IO) is a GPIO block found on xa2ve3288 silicon..\n\n\nWhy does the compatible have a \"1.0\" when it is in silicon?\nWhy doesn't the compatible contain \"xa2ve3288\"?\nWhy is this device not compatible with existing ones, since\ngpio-lines-names appears to be the sole difference?\n\n> \n> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>\n> ---\n> \n> Changes in v2:\n> - Add description of EIO block in the dt-bindings patch\n> \n>  .../devicetree/bindings/gpio/gpio-zynq.yaml        | 14 +++++++++++++-\n>  1 file changed, 13 insertions(+), 1 deletion(-)\n> \n> diff --git a/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml b/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml\n> index 30a7f836c341..1ca067217509 100644\n> --- a/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml\n> +++ b/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml\n> @@ -12,6 +12,7 @@ maintainers:\n>  properties:\n>    compatible:\n>      enum:\n> +      - xlnx,eio-gpio-1.0\n>        - xlnx,pmc-gpio-1.0\n>        - xlnx,versal-gpio-1.0\n>        - xlnx,zynq-gpio-1.0\n> @@ -30,7 +31,7 @@ properties:\n>  \n>    gpio-line-names:\n>      description: strings describing the names of each gpio line\n> -    minItems: 58\n> +    minItems: 52\n>      maxItems: 174\n>  \n>    interrupt-controller: true\n> @@ -89,6 +90,17 @@ allOf:\n>            minItems: 116\n>            maxItems: 116\n>  \n> +  - if:\n> +      properties:\n> +        compatible:\n> +          enum:\n> +            - xlnx,eio-gpio-1.0\n> +    then:\n> +      properties:\n> +        gpio-line-names:\n> +          minItems: 52\n> +          maxItems: 52\n> +\n>  required:\n>    - compatible\n>    - reg\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"\n <linux-gpio+bounces-35173-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=I2icnaHq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35173-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"I2icnaHq\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwkqY6GPhz1yHM\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 01:01:13 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 1003B300D1CD\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 15 Apr 2026 15:01:10 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D309D37B03F;\n\tWed, 15 Apr 2026 15:01:08 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 95C202EDD62;\n\tWed, 15 Apr 2026 15:01:08 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 7E383C19424;\n\tWed, 15 Apr 2026 15:01:05 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776265268; cv=none;\n b=dzA44ZOEV/swDYYl+OQk0/ohzerAZ073xU0Tac+UD8CEPc8gqty5UXBEXd9yqzCxrGcUrAMauJ/NdSQz20xrQaZVYuhH5X9rKWDNzO69YEfj+VFO4djgr3EZEQny65fvxQbgA5NwDWjqiiSFQu1lTh9CdqSnrlKaMC9brVxpJVk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776265268; c=relaxed/simple;\n\tbh=BkVPFcAIuT9ItmchTe1dNaR4kZ/g7siiF/QjERIMqmo=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=jkbJTm3Y1A/NEtp/4MN2LFCV51lNwE30OieE/Wznj2MeS8Z9BoYUVmKvx+dKappag/iDTEI80cacjXqI+987wqMmKRFmp7i43HuaiRH/Nnoo0WESh46e6s3EtlDu6viamY/eeUhaJXUZL1/gN2XjwRhNaduI4dCWS3zkTfwDv9I=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=I2icnaHq; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776265268;\n\tbh=BkVPFcAIuT9ItmchTe1dNaR4kZ/g7siiF/QjERIMqmo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=I2icnaHqjp0xdrxXzB5xuSUu42KVP25gMmFYjCNm3a7Il6RLNqqR4teE4IRbeTWux\n\t R2QKNaX3I8+yq0oAALvxJCB0wo4K+CdctFhzDSXAWdva6SV5s8ZaEd0+3SvBvqAn7D\n\t HOOSpuVOmo6/c12itOJBTlTK1Bhib/A2tKFd3C4Lg0lowNiZAFKYXj/gcTuZRs1VL2\n\t 7VH0ORDi9Q46fIAGgVuwnHQLYcjI0QVgWfvUuKLRQUMa01TSqXnPlvblNLU6WEZY/a\n\t lgi+8CB/ZhGhP/cq25p/cbCWKuDfbO9yLbixAlYx13lcjovMcPV+AORNGI7vt8z9p3\n\t L1oZZqzol+J8A==","Date":"Wed, 15 Apr 2026 16:01:03 +0100","From":"Conor Dooley <conor@kernel.org>","To":"Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>","Cc":"linux-kernel@vger.kernel.org, git@amd.com, shubhrajyoti.datta@gmail.com,\n\tSrinivas Neeli <srinivas.neeli@amd.com>,\n\tMichal Simek <michal.simek@amd.com>,\n\tLinus Walleij <linusw@kernel.org>,\n\tBartosz Golaszewski <brgl@kernel.org>,\n\tRob Herring <robh@kernel.org>,\n\tKrzysztof Kozlowski <krzk+dt@kernel.org>,\n\tConor Dooley <conor+dt@kernel.org>, linux-gpio@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org","Subject":"Re: [PATCH v2 2/3] dt-bindings: gpio: Add EIO GPIO compatible to\n gpio-zynq","Message-ID":"<20260415-rectal-visible-a8ccb534a176@spud>","References":"<20260415105628.957689-1-shubhrajyoti.datta@amd.com>\n <20260415105628.957689-3-shubhrajyoti.datta@amd.com>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"<linux-gpio.vger.kernel.org>","List-Subscribe":"<mailto:linux-gpio+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-gpio+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"fmNPlvI7e/DqiZwD\"","Content-Disposition":"inline","In-Reply-To":"<20260415105628.957689-3-shubhrajyoti.datta@amd.com>"}}]