[{"id":3677721,"web_url":"http://patchwork.ozlabs.org/comment/3677721/","msgid":"<20260415-reacquire-handstand-d1923af82c9d@spud>","list_archive_url":null,"date":"2026-04-15T15:09:49","subject":"Re: [PATCH v4 1/2] dt-bindings: pwm: dwc: add reset optional","submitter":{"id":84372,"url":"http://patchwork.ozlabs.org/api/people/84372/","name":"Conor Dooley","email":"conor@kernel.org"},"content":"On Wed, Apr 15, 2026 at 05:50:20PM +0800, dongxuyang@eswincomputing.com wrote:\n> From: Xuyang Dong <dongxuyang@eswincomputing.com>\n> \n> The DesignWare PWM includes separate reset signals dedicated to each clock\n> domain:\n> The presetn signal resets logic in pclk domain.\n> The timer_N_resetn signal resets logic in the timer_N_clk domain.\n> The resets are active-low.\n> \n> Signed-off-by: Xuyang Dong <dongxuyang@eswincomputing.com>\n\nThis commit implies that your hardware differs from existing devices,\nI think you should add a device-specific compatible.\n\n> ---\n>  .../devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml       | 3 +++\n>  1 file changed, 3 insertions(+)\n> \n> diff --git a/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml b/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml\n> index 7523a89a1773..a8bbad0360f8 100644\n> --- a/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml\n> +++ b/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml\n> @@ -43,6 +43,9 @@ properties:\n>        - const: bus\n>        - const: timer\n>  \n> +  resets:\n> +    maxItems: 2\n> +\n>    snps,pwm-number:\n>      $ref: /schemas/types.yaml#/definitions/uint32\n>      description: The number of PWM channels configured for this instance\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"\n <linux-pwm+bounces-8592-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pwm@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=oh15y+Iq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-pwm+bounces-8592-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"oh15y+Iq\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwl5P5KSJz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 01:13:13 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 5F68B3023F85\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 15 Apr 2026 15:10:46 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B46A83DBD4D;\n\tWed, 15 Apr 2026 15:09:54 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 903112F1FFC;\n\tWed, 15 Apr 2026 15:09:54 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 2B31AC2BCB4;\n\tWed, 15 Apr 2026 15:09:51 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776265794; cv=none;\n b=iwhSNi4Bmr1Q5gnytnRfbU/saAic+ZEvh1ImZmfC5bzUk6ZT+9ZgZJl1v7GGBkRWTv+LiV2eKfJnDyprjnh5iFOALSIP4or1KSW4ElGrrt3b5d6/iNl79ln1v2uqal+HWtcib0IBGYOAOQAAds/FxacnFe/jE/j0PQPXcKqyDGQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776265794; c=relaxed/simple;\n\tbh=KCG8cdPVc9jRDsdzNql7/57RznYdhKNf91J2Z2mqsh8=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=TLn+DiCy0Jb8IKwmeeZA+ywQtPp1nmn5dFgnrVMDnxA6qnbTXy+o+mtrlLg5FPWjkmvjl2Sn3cisz9kwMbqm27PPOnWCFrPxxl5Cvinpcdi+8zEdOKg5zLLTHySPo0Jzr/dXNY2KCkM+uDm3EFdx+lN0uhA06wa64ClbvK5TvUE=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=oh15y+Iq; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776265794;\n\tbh=KCG8cdPVc9jRDsdzNql7/57RznYdhKNf91J2Z2mqsh8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=oh15y+Iq+fXE/Fa3dXgFXNh21sPDrUGip6cCiu2raR12q2phTTC+sT8cvj8W/CDJv\n\t IXmfgmuJF5fyf40Y37ng8nO8lpggv4maxk9JWDx/poECPuzsxf5uC4vVryl0ESm0A8\n\t uBRLnR5uosqFiPxV2VTzE9R0r+6ipmITo2u2REU6skbRbRQQGi2UtyJU+lPYKNx/yW\n\t ziWxyyCcOv22ak6bInHEeamVDAxzaERIK+iuk240UWAFAkuT3yPeafWU0jczxxXybA\n\t K9Hg5j0an5ct1WqgF6nEVuWLDiN8fKKsgfUOBaZ41LoEVTK1lrYIjoILxKHcZGYE0n\n\t zKPj45SSx86Lg==","Date":"Wed, 15 Apr 2026 16:09:49 +0100","From":"Conor Dooley <conor@kernel.org>","To":"dongxuyang@eswincomputing.com","Cc":"ukleinek@kernel.org, robh@kernel.org, krzk+dt@kernel.org,\n\tconor+dt@kernel.org, ben-linux@fluff.org, ben.dooks@codethink.co.uk,\n\tp.zabel@pengutronix.de, linux-pwm@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tningyu@eswincomputing.com, linmin@eswincomputing.com,\n\txuxiang@eswincomputing.com, wangguosheng@eswincomputing.com,\n\tpinkesh.vaghela@einfochips.com","Subject":"Re: [PATCH v4 1/2] dt-bindings: pwm: dwc: add reset optional","Message-ID":"<20260415-reacquire-handstand-d1923af82c9d@spud>","References":"<20260415094908.1539-1-dongxuyang@eswincomputing.com>\n <20260415095020.1597-1-dongxuyang@eswincomputing.com>","Precedence":"bulk","X-Mailing-List":"linux-pwm@vger.kernel.org","List-Id":"<linux-pwm.vger.kernel.org>","List-Subscribe":"<mailto:linux-pwm+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pwm+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"PLShwbF4Er3TfYyf\"","Content-Disposition":"inline","In-Reply-To":"<20260415095020.1597-1-dongxuyang@eswincomputing.com>"}},{"id":3677996,"web_url":"http://patchwork.ozlabs.org/comment/3677996/","msgid":"<20260416-wandering-solemn-uakari-083ae7@quoll>","list_archive_url":null,"date":"2026-04-16T08:24:29","subject":"Re: [PATCH v4 1/2] dt-bindings: pwm: dwc: add reset optional","submitter":{"id":68952,"url":"http://patchwork.ozlabs.org/api/people/68952/","name":"Krzysztof Kozlowski","email":"krzk@kernel.org"},"content":"On Wed, Apr 15, 2026 at 04:09:49PM +0100, Conor Dooley wrote:\n> On Wed, Apr 15, 2026 at 05:50:20PM +0800, dongxuyang@eswincomputing.com wrote:\n> > From: Xuyang Dong <dongxuyang@eswincomputing.com>\n> > \n> > The DesignWare PWM includes separate reset signals dedicated to each clock\n> > domain:\n> > The presetn signal resets logic in pclk domain.\n> > The timer_N_resetn signal resets logic in the timer_N_clk domain.\n> > The resets are active-low.\n> > \n> > Signed-off-by: Xuyang Dong <dongxuyang@eswincomputing.com>\n> \n> This commit implies that your hardware differs from existing devices,\n> I think you should add a device-specific compatible.\n> \n> > ---\n> >  .../devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml       | 3 +++\n> >  1 file changed, 3 insertions(+)\n> > \n> > diff --git a/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml b/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml\n> > index 7523a89a1773..a8bbad0360f8 100644\n> > --- a/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml\n> > +++ b/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml\n> > @@ -43,6 +43,9 @@ properties:\n> >        - const: bus\n> >        - const: timer\n> >  \n> > +  resets:\n> > +    maxItems: 2\n\nAnd this should really be listed with description, because order is\nfixed.\n\nBest regards,\nKrzysztof","headers":{"Return-Path":"\n <linux-pwm+bounces-8598-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pwm@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=YbNL1BW3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-pwm+bounces-8598-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"YbNL1BW3\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx9zg3PKzz1yG9\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 18:24:47 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 29EFD3012A91\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 08:24:34 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E3A87391513;\n\tThu, 16 Apr 2026 08:24:32 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C01283890E1;\n\tThu, 16 Apr 2026 08:24:32 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id D5EF9C2BCAF;\n\tThu, 16 Apr 2026 08:24:31 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776327872; cv=none;\n b=SD8UTzIRmH3itul7eo3n49f2XphMA/edz9tlG01sJ4KOaMlEXsXzk6NHzy9tPSHLGSlvBkPUbEzVXdnCjR2w0a+REuQXacp+eBhL3gnYNy+LIH6Y/IuuEbrWZerWZCTd7Dlob89Ju6Bv3aEB0GWjBI1JWCL5CMblePc2JXBBi5Q=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776327872; c=relaxed/simple;\n\tbh=B9NrsopThAdQy1pEQQhGyJ5Ca9nA0GaI99bu8QZCq8Y=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=d1UjcSU1OxYLiyXQMKaF1qqDL2dNi+NRajJBwvvq56TJ5A2ke4bu0012orp6h+FHwC3FktUa+EN6Lf5wT2JM2Uve9PQ6FQmJlQMvYdKOIVKOgLhNS2VpH9yXKYdJdAkTTX3J3GVcahrLPdj+PpTJ1gWoJWK3o6i9yPPszh19H8I=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=YbNL1BW3; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776327872;\n\tbh=B9NrsopThAdQy1pEQQhGyJ5Ca9nA0GaI99bu8QZCq8Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YbNL1BW3G8VlKFztm99hsxG+cOBPjXewViZlBi3YoKDSwQLw2yLg2c8yyK3RsU+Yh\n\t m8fFDq1MlwINhFR1WLz4evtFK6L2TB1nho7dIKILjppndigNqNMPHFV0EQJdD/uilj\n\t /K67bOuESDM49cdejT+yk3LwSOuLFZngL4Er7C/4r05q3SWsiDJyyK8msJNNyoH8Rs\n\t HBVzb0ajlqlKWeNjxRiSJyxQt2TeQMucQEc7VlcHP+wmspY/JkxQpQVVu5GtVWX97g\n\t kz4NJOUHdgDMhBy26A+paEhHICR6EaD5lMlEkCwqinhUmia0L0iSyOVKnumRFJa7Rp\n\t wygwQsu/31pJA==","Date":"Thu, 16 Apr 2026 10:24:29 +0200","From":"Krzysztof Kozlowski <krzk@kernel.org>","To":"Conor Dooley <conor@kernel.org>","Cc":"dongxuyang@eswincomputing.com, ukleinek@kernel.org, robh@kernel.org,\n\tkrzk+dt@kernel.org, conor+dt@kernel.org, ben-linux@fluff.org,\n\tben.dooks@codethink.co.uk, p.zabel@pengutronix.de, linux-pwm@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n ningyu@eswincomputing.com,\n\tlinmin@eswincomputing.com, xuxiang@eswincomputing.com,\n wangguosheng@eswincomputing.com,\n\tpinkesh.vaghela@einfochips.com","Subject":"Re: [PATCH v4 1/2] dt-bindings: pwm: dwc: add reset optional","Message-ID":"<20260416-wandering-solemn-uakari-083ae7@quoll>","References":"<20260415094908.1539-1-dongxuyang@eswincomputing.com>\n <20260415095020.1597-1-dongxuyang@eswincomputing.com>\n <20260415-reacquire-handstand-d1923af82c9d@spud>","Precedence":"bulk","X-Mailing-List":"linux-pwm@vger.kernel.org","List-Id":"<linux-pwm.vger.kernel.org>","List-Subscribe":"<mailto:linux-pwm+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pwm+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260415-reacquire-handstand-d1923af82c9d@spud>"}},{"id":3678062,"web_url":"http://patchwork.ozlabs.org/comment/3678062/","msgid":"<281f7aa3.5575.19d95a879f8.Coremail.dongxuyang@eswincomputing.com>","list_archive_url":null,"date":"2026-04-16T09:38:59","subject":"Re: Re: [PATCH v4 1/2] dt-bindings: pwm: dwc: add reset optional","submitter":{"id":90849,"url":"http://patchwork.ozlabs.org/api/people/90849/","name":"Xuyang Dong","email":"dongxuyang@eswincomputing.com"},"content":"> > > \n> > > The DesignWare PWM includes separate reset signals dedicated to each clock\n> > > domain:\n> > > The presetn signal resets logic in pclk domain.\n> > > The timer_N_resetn signal resets logic in the timer_N_clk domain.\n> > > The resets are active-low.\n> > > \n> > > Signed-off-by: Xuyang Dong <dongxuyang@eswincomputing.com>\n> > \n> > This commit implies that your hardware differs from existing devices,\n> > I think you should add a device-specific compatible.\n> > \n\nHi Conor and Krzysztof,\n\nThe DesignWare PWM Databook for 2.13a says: \"The DW_apb_timers includes \nseparate reset signals dedicated to each clock domain\". They are:\nThe presetn signal resets logic in pclk domain (i.e., the bus clock in DT).\nThe timer_N_resetn signal resets logic in the timer_N_clk domain (i.e.,\nthe timer clock in DT).\n\nThese reset signals are optional; it is up to the designer's \nimplementation.\n\nAccording to [1], the applied YAML is also based on 2.13a, so our \nhardware is the same as the existing devices. It's just that these two \nreset signals were missing from the original YAML binding.\n\n[1] https://lore.kernel.org/linux-pwm/8bb5103d-803e-90d2-fd93-132bb2aac2d6@sifive.com/\n\n> > > ---\n> > >  .../devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml       | 3 +++\n> > >  1 file changed, 3 insertions(+)\n> > > \n> > > diff --git a/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml b/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml\n> > > index 7523a89a1773..a8bbad0360f8 100644\n> > > --- a/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml\n> > > +++ b/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml\n> > > @@ -43,6 +43,9 @@ properties:\n> > >        - const: bus\n> > >        - const: timer\n> > >  \n> > > +  resets:\n> > > +    maxItems: 2\n> \n> And this should really be listed with description, because order is\n> fixed.\n> \n\nThe description of resets will be listed in next version.\n\nBest regards,\nXuyang Dong","headers":{"Return-Path":"\n <linux-pwm+bounces-8606-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pwm@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-pwm+bounces-8606-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=162.243.161.220","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=eswincomputing.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=eswincomputing.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxCdw6jrFz1yG9\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 19:39:32 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 782243004618\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 09:39:31 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 549ED39A077;\n\tThu, 16 Apr 2026 09:39:30 +0000 (UTC)","from zg8tmtyylji0my4xnjeumjiw.icoremail.net\n (zg8tmtyylji0my4xnjeumjiw.icoremail.net [162.243.161.220])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id BB0CF394789;\n\tThu, 16 Apr 2026 09:39:26 +0000 (UTC)","from dongxuyang$eswincomputing.com ( [10.12.96.41] ) by\n ajax-webmail-app2 (Coremail) ; Thu, 16 Apr 2026 17:38:59 +0800 (GMT+08:00)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776332370; cv=none;\n b=SnnPILzjCyBoa7IZtM7GlAJzkXzlqjtqvzVrg6U95Ps6osUFzZ6f9MKTDKCMjCblufA6NSecy9WvrL7G9Cyt2TsQ+PO4M4QjcU+h3Vw3qDHmQRixA8VfKRtPJHeeG5q7uP92q2AspOY1Ji3+VxSkdJAhglTELumxE2nZvq5mZCM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776332370; c=relaxed/simple;\n\tbh=T7CoLB2p6sG/di7D5Nmfq3bgVGiqmIyvmGldLZWNe50=;\n\th=Date:From:To:Cc:Subject:In-Reply-To:References:Content-Type:\n\t MIME-Version:Message-ID;\n b=M9qq3iM5dkIMjQokcsHcEpoh4ewjmu7eQeYwVhh4nHJ7WfRMb6bO+8CX5VPY0QIpiZLM1YNgWxfzMH6eu5mp0K1NGbVPZyp41gAz3y/6Vf87m8fIapfYt4XDoPcpBWfozIdc/c5ODdWxzU0rzW+Xnr5g+7MMqVhkHQ6XBkdtmtw=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=eswincomputing.com;\n spf=pass smtp.mailfrom=eswincomputing.com;\n arc=none smtp.client-ip=162.243.161.220","Date":"Thu, 16 Apr 2026 17:38:59 +0800 (GMT+08:00)","X-CM-HeaderCharset":"UTF-8","From":"\"Xuyang Dong\" <dongxuyang@eswincomputing.com>","To":"\"Krzysztof Kozlowski\" <krzk@kernel.org>,\n\t\"Conor Dooley\" <conor@kernel.org>","Cc":"ukleinek@kernel.org, robh@kernel.org, krzk+dt@kernel.org,\n\tconor+dt@kernel.org, ben-linux@fluff.org, ben.dooks@codethink.co.uk,\n\tp.zabel@pengutronix.de, linux-pwm@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tningyu@eswincomputing.com, linmin@eswincomputing.com,\n\txuxiang@eswincomputing.com, wangguosheng@eswincomputing.com,\n\tpinkesh.vaghela@einfochips.com","Subject":"Re: Re: [PATCH v4 1/2] dt-bindings: pwm: dwc: add reset optional","X-Priority":"3","X-Mailer":"Coremail Webmail Server Version 2024.2-cmXT6 build\n 20241203(6b039d88) Copyright (c) 2002-2026 www.mailtech.cn\n mispb-72143050-eaf5-4703-89e0-86624513b4ce-eswincomputing.com","In-Reply-To":"<20260416-wandering-solemn-uakari-083ae7@quoll>","References":"<20260415094908.1539-1-dongxuyang@eswincomputing.com>\n <20260415095020.1597-1-dongxuyang@eswincomputing.com>\n <20260415-reacquire-handstand-d1923af82c9d@spud>\n <20260416-wandering-solemn-uakari-083ae7@quoll>","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=UTF-8","Precedence":"bulk","X-Mailing-List":"linux-pwm@vger.kernel.org","List-Id":"<linux-pwm.vger.kernel.org>","List-Subscribe":"<mailto:linux-pwm+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pwm+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Message-ID":"<281f7aa3.5575.19d95a879f8.Coremail.dongxuyang@eswincomputing.com>","X-Coremail-Locale":"zh_CN","X-CM-TRANSID":"TQJkCgA3TJ8zruBp7yYSAA--.2351W","X-CM-SenderInfo":"pgrqw5xx1d0w46hv4xpqfrz1xxwl0woofrz/1tbiAgETAmnfvg1VQ\n\tQAAsD","X-Coremail-Antispam":"1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWxJw\n\tCS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI\n\tdaVFxhVjvjDU="}},{"id":3678255,"web_url":"http://patchwork.ozlabs.org/comment/3678255/","msgid":"<20260416-flashcard-shadily-a0ddd2f12ff8@spud>","list_archive_url":null,"date":"2026-04-16T15:29:29","subject":"Re: Re: [PATCH v4 1/2] dt-bindings: pwm: dwc: add reset optional","submitter":{"id":84372,"url":"http://patchwork.ozlabs.org/api/people/84372/","name":"Conor Dooley","email":"conor@kernel.org"},"content":"On Thu, Apr 16, 2026 at 05:38:59PM +0800, Xuyang Dong wrote:\n> > > > \n> > > > The DesignWare PWM includes separate reset signals dedicated to each clock\n> > > > domain:\n> > > > The presetn signal resets logic in pclk domain.\n> > > > The timer_N_resetn signal resets logic in the timer_N_clk domain.\n> > > > The resets are active-low.\n> > > > \n> > > > Signed-off-by: Xuyang Dong <dongxuyang@eswincomputing.com>\n> > > \n> > > This commit implies that your hardware differs from existing devices,\n> > > I think you should add a device-specific compatible.\n> > > \n> \n> Hi Conor and Krzysztof,\n> \n> The DesignWare PWM Databook for 2.13a says: \"The DW_apb_timers includes \n> separate reset signals dedicated to each clock domain\". They are:\n> The presetn signal resets logic in pclk domain (i.e., the bus clock in DT).\n> The timer_N_resetn signal resets logic in the timer_N_clk domain (i.e.,\n> the timer clock in DT).\n> \n> These reset signals are optional; it is up to the designer's \n> implementation.\n\nRight, and it's that \"designer's implementation\" that warrants a\ndevice-specific compatible.\n\n> \n> According to [1], the applied YAML is also based on 2.13a, so our \n> hardware is the same as the existing devices. It's just that these two \n> reset signals were missing from the original YAML binding.\n> \n> [1] https://lore.kernel.org/linux-pwm/8bb5103d-803e-90d2-fd93-132bb2aac2d6@sifive.com/\n> \n> > > > ---\n> > > >  .../devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml       | 3 +++\n> > > >  1 file changed, 3 insertions(+)\n> > > > \n> > > > diff --git a/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml b/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml\n> > > > index 7523a89a1773..a8bbad0360f8 100644\n> > > > --- a/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml\n> > > > +++ b/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml\n> > > > @@ -43,6 +43,9 @@ properties:\n> > > >        - const: bus\n> > > >        - const: timer\n> > > >  \n> > > > +  resets:\n> > > > +    maxItems: 2\n> > \n> > And this should really be listed with description, because order is\n> > fixed.\n> > \n> \n> The description of resets will be listed in next version.\n> \n> Best regards,\n> Xuyang Dong","headers":{"Return-Path":"\n <linux-pwm+bounces-8623-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pwm@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Wxe8kejo;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pwm+bounces-8623-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"Wxe8kejo\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxMSM0PCmz1yG9\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 01:31:47 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 007DF300A8DE\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 15:29:36 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 9C1FD3B27D8;\n\tThu, 16 Apr 2026 15:29:35 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 78D8623C4FA;\n\tThu, 16 Apr 2026 15:29:35 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 34593C2BCAF;\n\tThu, 16 Apr 2026 15:29:32 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776353375; cv=none;\n b=kVdAL8PYO3otktyg0UFp5dQfqxQ8tTuEN2tsOI7zvn1iaMTBfntUR1FUVpmB+SpY4mL+piy7GKhr0PCszL3QN1DpZBGvCE2aKoGMSRVJDpIp6FeDz07ZFGDsL2K5mIgTgs1tThupyeQbvxTyji9TaOZsxxCcGEFDJ7eTi+GDEW4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776353375; c=relaxed/simple;\n\tbh=KY4Bx/l3iKmDgcH/fhZjq79tdaDCI3sKsHPqUEI+wy4=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=aRF/lywwjfj907vzEsdQWpJxZaqyXMFaBRwAxI/nfFho+T6AQYe+rQAN7P4rD4QBRZRgf+FIsZPjmyB7O3SYMlwzUvz/HFgxOBSe4UXbJ+IDoEqrfKCdEfCaqW2XFDvycB8n6N8GLd6xkyguXjXt3QAae/WNtajowtbWjIZN62U=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=Wxe8kejo; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776353375;\n\tbh=KY4Bx/l3iKmDgcH/fhZjq79tdaDCI3sKsHPqUEI+wy4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Wxe8kejoTyo7nHF1BFDTIzznaeW2QSyjLWCA4tPleInUMD2qm/anG92Ifbo5tHBWV\n\t S9TphCxYYJldyQjGPhTO6KdZORTIHzJt0vG2+o1nXU4KkyDPMWU8k7fr8g4wJ2q4N+\n\t F9vctPAlsMgrMTaKOhSlqbD0KKsmODnO3+N0Ra0IzhCS0Fbi7/cgoe5zgYas5NX7m5\n\t uoMzTx7ZujLJxeQETk34HXonjrT3tNfCYrbpm7j401lY8P+JXyc06ogwqibuNiLFfq\n\t n2q1hBkdtK2WFIr60LCRIcvpYkvFyfKsW+scLevQhFKkxD71uBr4nw+1JAg4+Drq2S\n\t R5zmfLwYSPcmA==","Date":"Thu, 16 Apr 2026 16:29:29 +0100","From":"Conor Dooley <conor@kernel.org>","To":"Xuyang Dong <dongxuyang@eswincomputing.com>","Cc":"Krzysztof Kozlowski <krzk@kernel.org>, ukleinek@kernel.org,\n\trobh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,\n\tben-linux@fluff.org, ben.dooks@codethink.co.uk,\n\tp.zabel@pengutronix.de, linux-pwm@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tningyu@eswincomputing.com, linmin@eswincomputing.com,\n\txuxiang@eswincomputing.com, wangguosheng@eswincomputing.com,\n\tpinkesh.vaghela@einfochips.com","Subject":"Re: Re: [PATCH v4 1/2] dt-bindings: pwm: dwc: add reset optional","Message-ID":"<20260416-flashcard-shadily-a0ddd2f12ff8@spud>","References":"<20260415094908.1539-1-dongxuyang@eswincomputing.com>\n <20260415095020.1597-1-dongxuyang@eswincomputing.com>\n <20260415-reacquire-handstand-d1923af82c9d@spud>\n <20260416-wandering-solemn-uakari-083ae7@quoll>\n <281f7aa3.5575.19d95a879f8.Coremail.dongxuyang@eswincomputing.com>","Precedence":"bulk","X-Mailing-List":"linux-pwm@vger.kernel.org","List-Id":"<linux-pwm.vger.kernel.org>","List-Subscribe":"<mailto:linux-pwm+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pwm+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"RT0aWT33ZuoPw3Hs\"","Content-Disposition":"inline","In-Reply-To":"\n <281f7aa3.5575.19d95a879f8.Coremail.dongxuyang@eswincomputing.com>"}},{"id":3678359,"web_url":"http://patchwork.ozlabs.org/comment/3678359/","msgid":"<aeE-D5vC453uqtm6@monoceros>","list_archive_url":null,"date":"2026-04-16T19:53:56","subject":"Re: [PATCH v4 1/2] dt-bindings: pwm: dwc: add reset optional","submitter":{"id":88416,"url":"http://patchwork.ozlabs.org/api/people/88416/","name":"Uwe Kleine-König","email":"ukleinek@kernel.org"},"content":"Hello,\n\nI suggest\n\n\tdt-bindings: pwm: dwc: Add optional reset\n\nas shortlog.\n\nBest regards\nUwe","headers":{"Return-Path":"\n <linux-pwm+bounces-8624-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pwm@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=cDb2lX/u;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-pwm+bounces-8624-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"cDb2lX/u\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxTNN2Nshz1yG9\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 05:58:44 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id AC420302CD0A\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 19:54:03 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 962523ED135;\n\tThu, 16 Apr 2026 19:54:01 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 755423ED5C8;\n\tThu, 16 Apr 2026 19:54:00 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 3DDB8C2BCAF;\n\tThu, 16 Apr 2026 19:53:59 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776369240; cv=none;\n b=uGmirUFfhAN9w+LgVK4GPbi0WW+2+sbzjS7KyfKwqute8ypuu1AWQkcti91voEZ7dMKI66LEeoCTXRU8ftHSVQ7jSGQc3jOcn6yhEdpVUMoOoLKpq36z0ueMclU6TGcUbfNvVi07T+MgUf2P6PadiluNfsF7UNy2x3wMnj1fKd0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776369240; c=relaxed/simple;\n\tbh=bdrgUpLv4Yx4lHu+3+pqe3aRgMPAEQa18wcoOo5mqdQ=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=JKhbOgwcZRxXvN0tJ6tM0UkltoM6uPQl4j2uEjPzJBau1jov04FvQN2x7einqFwL4PaRfEwIVlbgwoDIGzWQPVRyAHy8b5JuUwbkf11sXNTSZ9ZK86CHr8AqTq0lrDsQaUSdQ6os1pTBj4qvjiwRX7rLR4GzOV3+/HHwgCiXSPc=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=cDb2lX/u; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776369239;\n\tbh=bdrgUpLv4Yx4lHu+3+pqe3aRgMPAEQa18wcoOo5mqdQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cDb2lX/uFXCvwNxzod7p5xxzzlPzlI6GJPbjQ9VuMatEJgbgQ8W92/0k5/7laym6N\n\t UVqQxGSGvm+48oztB/vFEEtE+wHXtsn5L9ZMjYQa1ohA0lreOPL8kYPlblbolLvJsR\n\t BoD7dA/aaXbmT3A/aoMtgS3Xpou+zd0T3prlp1sNoi+DTGiME12azA8zC6kihZ9IaO\n\t aKI7tyG47G0PE6cRU4YPv/ePg5NKhDlcQ/ibGbp2nYebURtEP+QWr05oF06FNmg2HY\n\t JyR3VzqlbO1FUpTczew4I3VSZSqguukFutPNB8G0MWnmSekA2muh5udpLuMbY3PvRh\n\t XKv976WY4vLwA==","Date":"Thu, 16 Apr 2026 21:53:56 +0200","From":"Uwe =?utf-8?q?Kleine-K=C3=B6nig?= <ukleinek@kernel.org>","To":"dongxuyang@eswincomputing.com","Cc":"robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,\n\tben-linux@fluff.org, ben.dooks@codethink.co.uk, p.zabel@pengutronix.de,\n\tlinux-pwm@vger.kernel.org, devicetree@vger.kernel.org,\n linux-kernel@vger.kernel.org,\n\tningyu@eswincomputing.com, linmin@eswincomputing.com,\n xuxiang@eswincomputing.com,\n\twangguosheng@eswincomputing.com, pinkesh.vaghela@einfochips.com","Subject":"Re: [PATCH v4 1/2] dt-bindings: pwm: dwc: add reset optional","Message-ID":"<aeE-D5vC453uqtm6@monoceros>","References":"<20260415094908.1539-1-dongxuyang@eswincomputing.com>\n <20260415095020.1597-1-dongxuyang@eswincomputing.com>","Precedence":"bulk","X-Mailing-List":"linux-pwm@vger.kernel.org","List-Id":"<linux-pwm.vger.kernel.org>","List-Subscribe":"<mailto:linux-pwm+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pwm+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"2u45m4lertypw5tb\"","Content-Disposition":"inline","In-Reply-To":"<20260415095020.1597-1-dongxuyang@eswincomputing.com>"}},{"id":3678462,"web_url":"http://patchwork.ozlabs.org/comment/3678462/","msgid":"<3b2e80d5.55a5.19d996c6821.Coremail.dongxuyang@eswincomputing.com>","list_archive_url":null,"date":"2026-04-17T03:11:51","subject":"Re: Re: Re: [PATCH v4 1/2] dt-bindings: pwm: dwc: add reset\n optional","submitter":{"id":90849,"url":"http://patchwork.ozlabs.org/api/people/90849/","name":"Xuyang Dong","email":"dongxuyang@eswincomputing.com"},"content":"> > > > > \n> > > > > The DesignWare PWM includes separate reset signals dedicated to each clock\n> > > > > domain:\n> > > > > The presetn signal resets logic in pclk domain.\n> > > > > The timer_N_resetn signal resets logic in the timer_N_clk domain.\n> > > > > The resets are active-low.\n> > > > > \n> > > > > Signed-off-by: Xuyang Dong <dongxuyang@eswincomputing.com>\n> > > > \n> > > > This commit implies that your hardware differs from existing devices,\n> > > > I think you should add a device-specific compatible.\n> > > > \n> > \n> > Hi Conor and Krzysztof,\n> > \n> > The DesignWare PWM Databook for 2.13a says: \"The DW_apb_timers includes \n> > separate reset signals dedicated to each clock domain\". They are:\n> > The presetn signal resets logic in pclk domain (i.e., the bus clock in DT).\n> > The timer_N_resetn signal resets logic in the timer_N_clk domain (i.e.,\n> > the timer clock in DT).\n> > \n> > These reset signals are optional; it is up to the designer's \n> > implementation.\n> \n> Right, and it's that \"designer's implementation\" that warrants a\n> device-specific compatible.\n> \n\nHi Conor,\n\nThe YAML update for the new device-specific compatible is as follows:\n\nproperties:\n  compatible:\n    oneOf:\n      - const: snps,dw-apb-timers-pwm2\n      - items:\n          - enum:\n              - snps,dw-apb-timers-pwm-2.13a\n          - const: snps,dw-apb-timers-pwm2\n\n  reg:\n    maxItems: 1\n\n  \"#pwm-cells\":\n    const: 3\n\n  clocks:\n    items:\n      - description: Interface bus clock\n      - description: PWM reference clock\n\n  clock-names:\n    items:\n      - const: bus\n      - const: timer\n\n  resets:\n    items:\n      - description: Interface bus reset\n      - description: PWM timer logic reset\n\n  snps,pwm-number:\n    $ref: /schemas/types.yaml#/definitions/uint32\n    description: The number of PWM channels configured for this instance\n    enum: [1, 2, 3, 4, 5, 6, 7, 8]\n\nrequired:\n  - compatible\n  - reg\n  - clocks\n  - clock-names\n\nallOf:\n  - $ref: pwm.yaml#\n\n  - if:\n      properties:\n        compatible:\n          contains:\n            const: snps,dw-apb-timers-pwm-2.13a\n\n    then:\n      required:\n        - resets\n\nIn your opinion, is this modification accurate?\n\nBest regards,\nXuyang Dong\n\n> > \n> > According to [1], the applied YAML is also based on 2.13a, so our \n> > hardware is the same as the existing devices. It's just that these two \n> > reset signals were missing from the original YAML binding.\n> > \n> > [1] https://lore.kernel.org/linux-pwm/8bb5103d-803e-90d2-fd93-132bb2aac2d6@sifive.com/\n> > \n> > > > > ---\n> > > > >  .../devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml       | 3 +++\n> > > > >  1 file changed, 3 insertions(+)\n> > > > > \n> > > > > diff --git a/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml b/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml\n> > > > > index 7523a89a1773..a8bbad0360f8 100644\n> > > > > --- a/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml\n> > > > > +++ b/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml\n> > > > > @@ -43,6 +43,9 @@ properties:\n> > > > >        - const: bus\n> > > > >        - const: timer\n> > > > >  \n> > > > > +  resets:\n> > > > > +    maxItems: 2\n> > > \n> > > And this should really be listed with description, because order is\n> > > fixed.\n> > > \n> > \n> > The description of resets will be listed in next version.\n> > \n> > Best regards,\n> > Xuyang Dong","headers":{"Return-Path":"\n <linux-pwm+bounces-8625-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pwm@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pwm+bounces-8625-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=4.193.249.245","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=eswincomputing.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=eswincomputing.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxg0r1RT9z1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 13:12:28 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 61E46301980C\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 03:12:25 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id C644630B502;\n\tFri, 17 Apr 2026 03:12:23 +0000 (UTC)","from azure-sdnproxy.icoremail.net (azure-sdnproxy.icoremail.net\n [4.193.249.245])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id F109C3B2AA;\n\tFri, 17 Apr 2026 03:12:19 +0000 (UTC)","from dongxuyang$eswincomputing.com ( [10.12.96.41] ) by\n ajax-webmail-app2 (Coremail) ; Fri, 17 Apr 2026 11:11:51 +0800 (GMT+08:00)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776395543; cv=none;\n b=h/QtHG/CW1VsHYW9wqaAhe7qttY5Y3hwdTWMAKza8yvkDxmxIvvTfEXMiTpWDEBVnPE8wnCwDPmPnGz+A/51k5NNYNBIvrpvKv7ssr/eI3CqSPOyi2cA4iigsZwdiz/BeVXUdcp4L1obAjZOrw9iP9r1psIeHwZGiT1GChfc1dE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776395543; c=relaxed/simple;\n\tbh=kqBVNGwxpKB1stgn4t21+OlgFdmZqmq8qQ6qKFQWzNY=;\n\th=Date:From:To:Cc:Subject:In-Reply-To:References:Content-Type:\n\t MIME-Version:Message-ID;\n b=tz53W+ER2jWS8OnPzCLipwYbKAy3FToqGTZXDdXE7DNs3toBOFxIlBk54N+a+r5iaq8CTEiz6ipmvE7hizwFHQNv6agEleV78PgBvw/RQwfkEFrjljS3lYxBH91qU4R7LfkWoTvzfEc17Q3+kY/4cH3D+eQ8Q9i9xKjNeczjFfg=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=eswincomputing.com;\n spf=pass smtp.mailfrom=eswincomputing.com;\n arc=none smtp.client-ip=4.193.249.245","Date":"Fri, 17 Apr 2026 11:11:51 +0800 (GMT+08:00)","X-CM-HeaderCharset":"UTF-8","From":"\"Xuyang Dong\" <dongxuyang@eswincomputing.com>","To":"\"Conor Dooley\" <conor@kernel.org>","Cc":"\"Krzysztof Kozlowski\" <krzk@kernel.org>, ukleinek@kernel.org,\n\trobh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,\n\tben-linux@fluff.org, ben.dooks@codethink.co.uk,\n\tp.zabel@pengutronix.de, linux-pwm@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tningyu@eswincomputing.com, linmin@eswincomputing.com,\n\txuxiang@eswincomputing.com, wangguosheng@eswincomputing.com,\n\tpinkesh.vaghela@einfochips.com","Subject":"Re: Re: Re: [PATCH v4 1/2] dt-bindings: pwm: dwc: add reset\n optional","X-Priority":"3","X-Mailer":"Coremail Webmail Server Version 2024.2-cmXT6 build\n 20241203(6b039d88) Copyright (c) 2002-2026 www.mailtech.cn\n mispb-72143050-eaf5-4703-89e0-86624513b4ce-eswincomputing.com","In-Reply-To":"<20260416-flashcard-shadily-a0ddd2f12ff8@spud>","References":"<20260415094908.1539-1-dongxuyang@eswincomputing.com>\n <20260415095020.1597-1-dongxuyang@eswincomputing.com>\n <20260415-reacquire-handstand-d1923af82c9d@spud>\n <20260416-wandering-solemn-uakari-083ae7@quoll>\n <281f7aa3.5575.19d95a879f8.Coremail.dongxuyang@eswincomputing.com>\n <20260416-flashcard-shadily-a0ddd2f12ff8@spud>","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=UTF-8","Precedence":"bulk","X-Mailing-List":"linux-pwm@vger.kernel.org","List-Id":"<linux-pwm.vger.kernel.org>","List-Subscribe":"<mailto:linux-pwm+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pwm+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Message-ID":"<3b2e80d5.55a5.19d996c6821.Coremail.dongxuyang@eswincomputing.com>","X-Coremail-Locale":"zh_CN","X-CM-TRANSID":"TQJkCgA3TJ_3pOFp21YSAA--.2378W","X-CM-SenderInfo":"pgrqw5xx1d0w46hv4xpqfrz1xxwl0woofrz/1tbiAgEAAmnhD40Rb\n\tQAAs3","X-Coremail-Antispam":"1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWxJw\n\tCS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI\n\tdaVFxhVjvjDU="}},{"id":3678464,"web_url":"http://patchwork.ozlabs.org/comment/3678464/","msgid":"<65568985.55a7.19d996e40c9.Coremail.dongxuyang@eswincomputing.com>","list_archive_url":null,"date":"2026-04-17T03:13:52","subject":"Re: Re: [PATCH v4 1/2] dt-bindings: pwm: dwc: add reset optional","submitter":{"id":90849,"url":"http://patchwork.ozlabs.org/api/people/90849/","name":"Xuyang Dong","email":"dongxuyang@eswincomputing.com"},"content":"> \n> Hello,\n> \n> I suggest\n> \n> \tdt-bindings: pwm: dwc: Add optional reset\n> \n> as shortlog.\n> \n\nHi Uwe,\n\nThanks, I'll address this in the next version.\n\nBest regards,\nXuyang Dong","headers":{"Return-Path":"\n <linux-pwm+bounces-8626-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pwm@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-pwm+bounces-8626-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=4.193.249.245","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=eswincomputing.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=eswincomputing.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxg2q4cxNz1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 13:14:11 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 8014E304CEBB\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 03:14:07 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 870B72EA48F;\n\tFri, 17 Apr 2026 03:14:06 +0000 (UTC)","from azure-sdnproxy.icoremail.net (azure-sdnproxy.icoremail.net\n [4.193.249.245])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 534BD199D8;\n\tFri, 17 Apr 2026 03:14:02 +0000 (UTC)","from dongxuyang$eswincomputing.com ( [10.12.96.41] ) by\n ajax-webmail-app2 (Coremail) ; Fri, 17 Apr 2026 11:13:52 +0800 (GMT+08:00)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776395646; cv=none;\n b=sPxKXvjj5x2zwedxp1arwjdZ3xNmtbQahCYw30V3oJYRcPIYn8BLj8yZwNNrjw2oYwb+r3UOr4wL0vJhUt33rE4AaTbdq/4+R7yxy7If5IDzfc5+LnDZQ51bwR8Q3HjRe8Qv2DSPv+CmZChrYE4QCswg+CwZ6iOj+cUowG4w3DA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776395646; c=relaxed/simple;\n\tbh=XlKAvBAxYI1INKbsNGmDVyjKLC/0zmoT5vwxHS3s6O0=;\n\th=Date:From:To:Cc:Subject:In-Reply-To:References:Content-Type:\n\t MIME-Version:Message-ID;\n b=knZKfmll9PIXFHnSde5wyP/v4FsnFPUgF2qbDXnYsYB11tdvPINoIJ3Qau73znImO/QK1gUimIHzLbOvazjEG8PJDIyGicofxzyc9QpeaoZOtRBT3EIPOURKDIzjheknTKBGxd9w+DhV8YC1NIfCPE+e+z3sePFeO2qirKCDscc=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=eswincomputing.com;\n spf=pass smtp.mailfrom=eswincomputing.com;\n arc=none smtp.client-ip=4.193.249.245","Date":"Fri, 17 Apr 2026 11:13:52 +0800 (GMT+08:00)","X-CM-HeaderCharset":"UTF-8","From":"\"Xuyang Dong\" <dongxuyang@eswincomputing.com>","To":"=?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <ukleinek@kernel.org>","Cc":"robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,\n\tben-linux@fluff.org, ben.dooks@codethink.co.uk,\n\tp.zabel@pengutronix.de, linux-pwm@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tningyu@eswincomputing.com, linmin@eswincomputing.com,\n\txuxiang@eswincomputing.com, wangguosheng@eswincomputing.com,\n\tpinkesh.vaghela@einfochips.com","Subject":"Re: Re: [PATCH v4 1/2] dt-bindings: pwm: dwc: add reset optional","X-Priority":"3","X-Mailer":"Coremail Webmail Server Version 2024.2-cmXT6 build\n 20241203(6b039d88) Copyright (c) 2002-2026 www.mailtech.cn\n mispb-72143050-eaf5-4703-89e0-86624513b4ce-eswincomputing.com","In-Reply-To":"<aeE-D5vC453uqtm6@monoceros>","References":"<20260415094908.1539-1-dongxuyang@eswincomputing.com>\n <20260415095020.1597-1-dongxuyang@eswincomputing.com>\n <aeE-D5vC453uqtm6@monoceros>","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=UTF-8","Precedence":"bulk","X-Mailing-List":"linux-pwm@vger.kernel.org","List-Id":"<linux-pwm.vger.kernel.org>","List-Subscribe":"<mailto:linux-pwm+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pwm+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Message-ID":"<65568985.55a7.19d996e40c9.Coremail.dongxuyang@eswincomputing.com>","X-Coremail-Locale":"zh_CN","X-CM-TRANSID":"TQJkCgAnPqFwpeFp31YSAA--.4352W","X-CM-SenderInfo":"pgrqw5xx1d0w46hv4xpqfrz1xxwl0woofrz/1tbiAgEAAmnhD40Rb\n\tQABs2","X-Coremail-Antispam":"1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWUCw\n\tCS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI\n\tdaVFxhVjvjDU="}}]