[{"id":3678669,"web_url":"http://patchwork.ozlabs.org/comment/3678669/","msgid":"","date":"2026-04-17T11:03:59","subject":"Re: [PATCH v2 1/3] ASoC: dapm: Fix widget lookup with prefixed names\n across DAPM contexts","submitter":{"id":68011,"url":"http://patchwork.ozlabs.org/api/people/68011/","name":"Frank Li","email":"Frank.Li@nxp.com"},"content":"On Wed, Apr 15, 2026 at 05:19:40PM +0900, Chancel Liu wrote:\n\nsubject suggest change to\n\nASoC: dapm: Use snd_soc_dapm_widget_name_cmp() to fix widget lookup failures\n\nFrank\n> Currently dapm_find_widget() manually constructs a prefixed widget name\n> based on the provided DAPM context and compares it using strcmp(). This\n> happens to work in most cases because callers usually know which DAPM\n> context the target widget belongs to and pass in the matching DAPM\n> context.\n>\n> However, this assumption breaks when search_other_contexts is enabled.\n> In such cases, callers may intentionally pass a different DAPM context,\n> while searching for a widget that actually belongs to another DAPM\n> context.\n>\n> For example, when searching for a \"DAC\" widget, the widget belongs to\n> the codec DAPM and be registered with a codec prefix, while the caller\n> passes card->dapm and intends to search across all DAPM contexts. The\n> current implementation incorrectly applies the caller card DAPM causing\n> the lookup to fail even though the widget exists on the card.\n>\n> Use snd_soc_dapm_widget_name_cmp() instead, which compares widget names\n> using the widget's own DAPM context and prefix. It fixes widget lookup\n> failures when searching across different DAPM contexts on the card.\n>\n> Fixes: ae4fc532244b (\"ASoC: dapm: use component prefix when checking widget names\")\n> Signed-off-by: Chancel Liu \n> Assisted-by: Cody:Claude-3.5-Sonnet\n> ---\n> sound/soc/soc-dapm.c | 13 +------------\n> 1 file changed, 1 insertion(+), 12 deletions(-)\n>\n> diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c\n> index d6192204e613..c5b80d9ed64b 100644\n> --- a/sound/soc/soc-dapm.c\n> +++ b/sound/soc/soc-dapm.c\n> @@ -2906,20 +2906,9 @@ static struct snd_soc_dapm_widget *dapm_find_widget(\n> {\n> \tstruct snd_soc_dapm_widget *w;\n> \tstruct snd_soc_dapm_widget *fallback = NULL;\n> -\tchar prefixed_pin[80];\n> -\tconst char *pin_name;\n> -\tconst char *prefix = dapm_prefix(dapm);\n> -\n> -\tif (prefix) {\n> -\t\tsnprintf(prefixed_pin, sizeof(prefixed_pin), \"%s %s\",\n> -\t\t\t prefix, pin);\n> -\t\tpin_name = prefixed_pin;\n> -\t} else {\n> -\t\tpin_name = pin;\n> -\t}\n>\n> \tfor_each_card_widgets(dapm->card, w) {\n> -\t\tif (!strcmp(w->name, pin_name)) {\n> +\t\tif (!snd_soc_dapm_widget_name_cmp(w, pin)) {\n> \t\t\tif (w->dapm == dapm)\n> \t\t\t\treturn w;\n> \t\t\telse\n> --\n> 2.50.1\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256\n header.s=selector1 header.b=gH6w9Pql;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19831-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=pass smtp.remote-ip=\"2a01:111:f403:c207::3\" arc.chain=microsoft.com","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=nxp.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256\n header.s=selector1 header.b=gH6w9Pql;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=permerror (SPF Permanent Error: Void lookup limit of 2 exceeded)\n smtp.mailfrom=nxp.com (client-ip=2a01:111:f403:c207::3;\n helo=mrwpr03cu001.outbound.protection.outlook.com;\n envelope-from=frank.li@nxp.com; receiver=lists.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nxp.com;"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxsTg5LQ6z1yCv\n\tfor ; Fri, 17 Apr 2026 21:04:38 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fxsTd6V3mz2yfs;\n\tFri, 17 Apr 2026 21:04:37 +1000 (AEST)","from MRWPR03CU001.outbound.protection.outlook.com\n (mail-francesouthazlp170110003.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c207::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange secp256r1 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fxsTb2qK7z2xfX\n\tfor ; Fri, 17 Apr 2026 21:04:34 +1000 (AEST)","from PA4PR04MB9366.eurprd04.prod.outlook.com (2603:10a6:102:2a9::8)\n by AS8PR04MB8484.eurprd04.prod.outlook.com (2603:10a6:20b:34c::12) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.25; Fri, 17 Apr\n 2026 11:04:06 +0000","from PA4PR04MB9366.eurprd04.prod.outlook.com\n ([fe80::75e4:8143:ddbc:6588]) by PA4PR04MB9366.eurprd04.prod.outlook.com\n ([fe80::75e4:8143:ddbc:6588%6]) with mapi id 15.20.9818.023; Fri, 17 Apr 2026\n 11:04:06 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776423877;\n\tcv=pass;\n b=O30H3Kg0kNUmAFD/TaFgLPGOCdVMnQJgaoEnYA0DdQvGDNqJ9dJvKYbtH6WGbUL9NPQnG73dit6y/6wcrX1m3ZifhTR5cYjsavfoorc8nuJCwzLsfMchxt8wNf9Hnn/Nk6tK3mPf+0WgQBdCmbnSK4MPg8aQGttWnBB36HPMah32WMj8nqV/uUCdUWtoG0ObeB0W8+s4yZkQCkaggBQCoJaT022WRlbhLM2J0rfPs42SgCs2iRVpDlyawcUEfucIfEFcO3+0AiMfkpPzupoZEUlKDwFFi0E8B3/40/YCcoyKE7ZHYTro1mK4ftxD6tHcJynl1RbAYAg4w3LrQVXIwQ==","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=Tr5i9IlbKHlg3GY8ZG4ey+lfE8wxz2tzUitK2IBZFXSwHzUMUuSOS4uI1YBs0p1uSmQmrhYWr6PPita7xuMW19gFn4pzG2P97cUEwq8A3dh6XVkBEX1fm9r0H8P4Z1sXQJHThJ6ypJh+TMV05+rCy3pFYMdp9kq492v8pPtxMSIwqsxwTHLcy/Dr2DBfa6yI1jkbK764xGmxZCj+/4IZha+myiUIV1W6ht9BUuNq/tUB1eKkILKw8wO2Fl0LS8s3Lc+w0JQ7DRXkLLgF80QZyR0ik5T0FDhWMIj5hbqd6vIF29vf5N4WRl+On7FJJdB3UJbbw2d9uzRcP3jCoCm20g=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776423877; c=relaxed/relaxed;\n\tbh=72hmBQUvpLc/UbycA1q7D42OYX5f5EfjgKhmTPW/TLQ=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:Content-Type:\n\t Content-Disposition:In-Reply-To:MIME-Version;\n b=UvnsGwk5J4XRWhpQ/cX5Qj/9iDgkS8riHT6pvIbEFvb9fpv17GxMbFPYzVVfI4QTUi7yVBkDVmbunVBiHKdHSGwQLs0qZxTltrv6Ij3YxLTJ9WpvLou1ShEnvyPGv4VByl1G6YKdAFwgNpduqVIPv2s5daFqTu5nUotbluOzLo6K4/EZeMaNWoSdu1o7dbmK4dJWA6SkljMXYY2Y7aLvc6MYXh8eWQmScWGEMD4/8aw2O5T96AHGA5qB6XpDKmi2QRcgUMCkzKRXekKRSSKpGjPv0corv3MVMTjP7Sa7NtrsClYT7UzQpqhLsgIQe0rT6l7zbAqRC7rNXCzz1+UIBg==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=72hmBQUvpLc/UbycA1q7D42OYX5f5EfjgKhmTPW/TLQ=;\n b=nLhuEbgCaanPrcisdbHa7UIaXIXIZlsP8c6m7w4z/Xq9S3+J6gcPDr65VF7lpPmgboWRJhcAQHYfMDvAV9PO7NONRX7KzY+5+f6NpEIJvrPwb0Pfo4+XUVqLVit4HBcv4XyLx9/MAvkC5aWL3N5IbwIDA6sRWx+QOZ80WDksG3wXnXPIsXSAeeEMKBd0LJGlepHJ0ZZtO12EeFhMulTzcfYtO0OM3e2msATCwL3Mmea4j4I5qk7KhX1iZCC2lcGKbNED44Ln0VPjMGPtIGSJ6Y9kdD6yTVbocruxSXvodFwGQWiFP/d6W6jA4oAtefti3gwIxcTF9k+gUMCIu03y0A=="],"ARC-Authentication-Results":["i=2; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=nxp.com; dkim=pass (2048-bit key;\n unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256\n header.s=selector1 header.b=gH6w9Pql; dkim-atps=neutral;\n spf=permerror (client-ip=2a01:111:f403:c207::3;\n helo=mrwpr03cu001.outbound.protection.outlook.com;\n envelope-from=frank.li@nxp.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=nxp.com","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass\n header.d=nxp.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=72hmBQUvpLc/UbycA1q7D42OYX5f5EfjgKhmTPW/TLQ=;\n b=gH6w9Pql4r+qYsUtYpb8jLg9wqc1CLIM9VsB5ShKjsQuMx0Ht6g1UQfa9TDabwKFDkuObVNoFYON6bQDZgLXMJHw+IhwPQhA4kosgowX5a+xROK0LNGVROYHom2rMakDLmwLfltX9tNoGq2g0UswUd/CEVd2xIkA7vwgK9cTevM1Vn4uH/gzCXgvI7QuyzyY9KcaJgWg4qiD3Adr2ZJWNWWseIb2zfFaQbRvSoau/R5MF/jD+zvSe6zd1bI2h9s6SHxo0ybLgXgbGcMjYd61cOPWyCZGCWCt/ccnQvM9PaEGqgUTR49cqEC7WjyMf/RdWmiCaxBoBwSRAOT/7uoExA==","Date":"Fri, 17 Apr 2026 07:03:59 -0400","From":"Frank Li ","To":"Chancel Liu ","Cc":"lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com,\n\tshengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com,\n\tnicoleotsuka@gmail.com, s.hauer@pengutronix.de,\n\tkernel@pengutronix.de, shumingf@realtek.com,\n\trander.wang@linux.intel.com, pierre-louis.bossart@linux.dev,\n\tlinux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev,\n\tlinux-arm-kernel@lists.infradead.org","Subject":"Re: [PATCH v2 1/3] ASoC: dapm: Fix widget lookup with prefixed names\n across DAPM contexts","Message-ID":"","References":"<20260415081942.4183108-1-chancel.liu@nxp.com>\n <20260415081942.4183108-2-chancel.liu@nxp.com>","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260415081942.4183108-2-chancel.liu@nxp.com>","X-ClientProxiedBy":"SN7PR04CA0219.namprd04.prod.outlook.com\n (2603:10b6:806:127::14) To PA4PR04MB9366.eurprd04.prod.outlook.com\n (2603:10a6:102:2a9::8)","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"PA4PR04MB9366:EE_|AS8PR04MB8484:EE_","X-MS-Office365-Filtering-Correlation-Id":"0ff3868b-4e8d-495f-8e1d-08de9c710adb","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|366016|19092799006|7416014|376014|52116014|1800799024|38350700014|22082099003|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n\t0ssAlu9w3CgRa99ztBuc7stTW4FqLCIN1eyGBYUa1lSvA+kV7AeIXSsIpFTVTeKhM+ktfsKblrnTff+dZ3E0p0noExLraVwYoO8fRBufheHmEkK9S8/CXz0fUDtz8wmd/+GgbGrRojt4bEw5p57qxMtq6weGeCeH9Nc1gAYn5BXDSOqz+yZzrKVFNvuLrbqMwT0BaAam6WgkZaWpOdiJtFjA0KVlHV7TQ1EyxrTjz0fYrokLZZzna9smYY04XXtqPH1zLXQGklWJofzEm/3/biaPAleGYn4Dd/Vw2ZF0tuKg5+fsZyyCN8CFLfPeK7Dn/3FUyUovDJkkKbo0kPA0DYF21vcsXzb/XMfIx5HojDmH+gXn6hzToZ4DGqrgYMym6yLLN5IQTMJ2wEQ0xU5zVq1XgvYALJyd3qZuPTpR9PqMpGmsNKAK4sjTLM9oXMVObVEECyUnHBt6J2CmOSr4zpSkrwYxSgqmC9u+Er/WVY4iGsetczbjh4xPo8ungA0C8ULoGweRbXKjJA6OAZ1ZuR1L4pj8PwSimn8g0v+f8owXmNFh3T996uRduxWr3qF8nZP/wo/pJKdFMXZKGTmBkV7ptwQDazIgxJD8GefyDPfsxWWXagvXTwwZcBj8N9uZyNue2b11/FfwGMW1QGTQ4QTIelixsQXbwSb8yNz1+gywR7BQc6D2fIHbtyzmFiMc0wFz3gC+wgbMQVa7p6QTo2D8qySo6SI6Qdz/5Y+NQgF/6LdXoHaA8sAgqxQ4n2k44CXYxvcgO5yPgKM6lQQX1/f4ElkC12x2Ez021CUaGB0=","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR04MB9366.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(19092799006)(7416014)(376014)(52116014)(1800799024)(38350700014)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n Ti0d7fqaL2GqBbjfCpg1T2zpgKPbdbpIGZaJ0tKOLc872GdZkSyDylaa9yuBLddE4i5uuYcO+u0xzImQg26xdm12OTGJ4l4U9fzKUpAZIwRI/7JYgTbIjDfQMgU+SX4RGhxWD29FnOo7GDjGp7TGUBwHTAStMIByPlP4hPYYJMjbsfHIXFzhIXia+i80MBC6/LrQ6z7IajfYsg+teAuxyAOp90et+cR9iv8ELlcC9+BNZDbNwds+pcjFwT/d+ZoZTWGK+ByIPAf0HS35EgWJJfZdC58ZP+fkMyg9B2mUM0m7da2ELKRedL9CegJB50/FjTrsMNcutSwAomoLW776Op770jJ8epBZc/9/qNBJkafiVeqc9Wi/NLMbfDYmREq7tg+MxgAiYpZ8AVWUZ343/sryJ54lnpJNH3KrhnQKnM7+pMYBMAi2UuXJyx89QKNiGmOkl6XRyFUFDY4vxZV5bxlbsOkzmVsPCI+KW5S1Tk8n8tpt60Bacbviq2uLoqOuaTagCYu0thR23cJN9Zc4ERngP1UiqLteN4q4sdtWQJDEfAtRAjZFgQ5GdpguLLxEU0WOin0OjF0F3kNHL86FLySHcC7+loZ34Uj3h+x2HiXqGYpvKDpgyX9W3eGhr8d7oeAhNuddXpB01sEA9t7zxVodl1ij9NXG2w2jU3+jn110vYVGuf0HMLKbP0UGxEagyoBdX/4hkE2HQ2aEsyXGx5P7hIdCC11L6zDxXF/hbrB7cn57XygMpeDMtVCDzYuM64XHIfhMAKzKt2Gq2Z9sBOLTB8cdnQJ7U8Z5GZT2/z/wq+D0e+2eC4I9K8/8gmhaPnYym2Jpp8laDDeek51Lyq0wXqMJhSASgr0h3J/4e7FIMfjp5T3hTi63Gvqy7qvO6k/C2a5Yq8o6+iWdOVjhADAxrafVTMaDjTi2b2/fbkYUlJhH83AsVe4jsfbfAvMUSH3DO2kILc0Gxd+dS2zY8syjJiRAGJTPCxHh1vfJ7DmXI4XIcWXtQlSOeSgBbu2oJgsy4Ij8u9wubCQ2eInYppRhAi7iWNzhQ0dGQx9PJDS4nLJSpiIUQ2QfU30W0sparAfvcZfQMHdrQ0TAIeAcQS4xkHCHord+6mrsEWfNSmoigPYxX6/7kwCSHeM24N72erJpHUzgv12/H5wDYsZuUECoRurH2JZ+JHIfK1u/S8TYox//wpoh/SLPEYl0YcQRBLvFDmELd9xby5lYvs8OXsrTSRrC4ot3lvc2gHmMVN25XJblMZEZYKzI2DI6MvClLHVR65YZzYpidqIqbUNx5j1VdWfWxz9meRij0nP57LfP83+QLnsFOaiV89U3M4Ei7X5OEhGgDkzR4l2wxHA+P6HusUJSsDXNLhuJh7VdkB0qP61IRKDYv5D2xhIZJzecV7ltxdAhTGKd3G8IBTJrm5spMRDXlTPTqgtJ9obz/JKhVfs04QAVCvMHfTy2PPAuah0RfWlSp7Rw+DiFQX75oNw0zZRliJkzSH1Bj02t7XPJSL1ibf2RPFO0xxhfhbyaJNXXO3RBYn0sLzTF/x7+54B+70KgiADRVQGbPVZ7uKYDXINxa1pdStcqcoT90SIyKy5mjzPU/lSZTBsvkM0z71dIDKb2U/AncpKBdcv8MXShyM1kPpBs665L7hv5oP4qQBvgKdkVpvCJ5oG38QmMOBOUKf+kihKojDyiyl6AjtZFC5q7AtLfqjeWvRDvFGb/NUWDnaNBCoaF9HC6M6K2QA==","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 0ff3868b-4e8d-495f-8e1d-08de9c710adb","X-MS-Exchange-CrossTenant-AuthSource":"PA4PR04MB9366.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"17 Apr 2026 11:04:06.2975\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n V6DUupttLbV4xsB8lS4+C+/1AbvW23io4ZeiVbVu226/i2ZFgK4jLRCRulgm3Xre2FTVITJ1ibaac+i01gamEw==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AS8PR04MB8484","X-Spam-Status":"No, score=0.8 required=3.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,\n\tSPF_HELO_PASS,T_SPF_PERMERROR autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]