[{"id":3677919,"web_url":"http://patchwork.ozlabs.org/comment/3677919/","msgid":"<976f75c0-66a0-fc03-345e-3da0c1c5afea@huawei.com>","list_archive_url":null,"date":"2026-04-16T03:37:30","subject":"Re: [PATCH v5 2/3] ubifs: use strscpy() and kmemdup_nul() where\n appropriate","submitter":{"id":76854,"url":"http://patchwork.ozlabs.org/api/people/76854/","name":"Zhihao Cheng","email":"chengzhihao1@huawei.com"},"content":"在 2026/4/15 15:18, Dmitry Antipov 写道:\n> Go closer to the modern kernel API and use 'strscpy()' and 'kmemdup_nul()'\n> over an ad-hoc ensure-to-have-'\\0' quirks where appropriate.\n> \n> Signed-off-by: Dmitry Antipov \n> ---\n> v5: switch to fname_len() + 1 to specify strscpy() target buffer size\n> v4: once again to not forget a filesystem-native (little) to CPU endian swap\n> v3: fix strscpy() usage as noticed by Zhihao\n> v2: initial version to join the series\n> ---\n> fs/ubifs/journal.c | 18 ++++++------------\n> fs/ubifs/replay.c | 3 +--\n> fs/ubifs/super.c | 8 ++------\n> 3 files changed, 9 insertions(+), 20 deletions(-)\n> \n> diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c\n> index 40a95a2fad50..8d7f0843d353 100644\n> --- a/fs/ubifs/journal.c\n> +++ b/fs/ubifs/journal.c\n> @@ -729,8 +729,7 @@ int ubifs_jnl_update(struct ubifs_info *c, const struct inode *dir,\n> \tdent->inum = deletion ? 0 : cpu_to_le64(inode->i_ino);\n> \tdent->type = get_dent_type(inode->i_mode);\n> \tdent->nlen = cpu_to_le16(fname_len(nm));\n> -\tmemcpy(dent->name, fname_name(nm), fname_len(nm));\n> -\tdent->name[fname_len(nm)] = '\\0';\n> +\tstrscpy(dent->name, fname_name(nm), fname_len(nm) + 1);\n\nHi Dmitry,\nI notice that some architectures can accelerate the implementation of \nmemcpy(), and the length of dentry name could be 255, I suggest to keep \nthe orignal implementation.\n> \tset_dent_cookie(c, dent);\n> \n> \tzero_dent_node_unused(dent);\n> @@ -1232,8 +1231,7 @@ int ubifs_jnl_xrename(struct ubifs_info *c, const struct inode *fst_dir,\n> \tdent1->inum = cpu_to_le64(fst_inode->i_ino);\n> \tdent1->type = get_dent_type(fst_inode->i_mode);\n> \tdent1->nlen = cpu_to_le16(fname_len(snd_nm));\n> -\tmemcpy(dent1->name, fname_name(snd_nm), fname_len(snd_nm));\n> -\tdent1->name[fname_len(snd_nm)] = '\\0';\n> +\tstrscpy(dent1->name, fname_name(snd_nm), fname_len(snd_nm) + 1);\n> \tset_dent_cookie(c, dent1);\n> \tzero_dent_node_unused(dent1);\n> \tubifs_prep_grp_node(c, dent1, dlen1, 0);\n> @@ -1248,8 +1246,7 @@ int ubifs_jnl_xrename(struct ubifs_info *c, const struct inode *fst_dir,\n> \tdent2->inum = cpu_to_le64(snd_inode->i_ino);\n> \tdent2->type = get_dent_type(snd_inode->i_mode);\n> \tdent2->nlen = cpu_to_le16(fname_len(fst_nm));\n> -\tmemcpy(dent2->name, fname_name(fst_nm), fname_len(fst_nm));\n> -\tdent2->name[fname_len(fst_nm)] = '\\0';\n> +\tstrscpy(dent2->name, fname_name(fst_nm), fname_len(fst_nm) + 1);\n> \tset_dent_cookie(c, dent2);\n> \tzero_dent_node_unused(dent2);\n> \tubifs_prep_grp_node(c, dent2, dlen2, 0);\n> @@ -1424,8 +1421,7 @@ int ubifs_jnl_rename(struct ubifs_info *c, const struct inode *old_dir,\n> \tdent->inum = cpu_to_le64(old_inode->i_ino);\n> \tdent->type = get_dent_type(old_inode->i_mode);\n> \tdent->nlen = cpu_to_le16(fname_len(new_nm));\n> -\tmemcpy(dent->name, fname_name(new_nm), fname_len(new_nm));\n> -\tdent->name[fname_len(new_nm)] = '\\0';\n> +\tstrscpy(dent->name, fname_name(new_nm), fname_len(new_nm) + 1);\n> \tset_dent_cookie(c, dent);\n> \tzero_dent_node_unused(dent);\n> \tubifs_prep_grp_node(c, dent, dlen1, 0);\n> @@ -1446,8 +1442,7 @@ int ubifs_jnl_rename(struct ubifs_info *c, const struct inode *old_dir,\n> \t\tdent2->type = DT_UNKNOWN;\n> \t}\n> \tdent2->nlen = cpu_to_le16(fname_len(old_nm));\n> -\tmemcpy(dent2->name, fname_name(old_nm), fname_len(old_nm));\n> -\tdent2->name[fname_len(old_nm)] = '\\0';\n> +\tstrscpy(dent2->name, fname_name(old_nm), fname_len(old_nm) + 1);\n> \tset_dent_cookie(c, dent2);\n> \tzero_dent_node_unused(dent2);\n> \tubifs_prep_grp_node(c, dent2, dlen2, 0);\n> @@ -1897,8 +1892,7 @@ int ubifs_jnl_delete_xattr(struct ubifs_info *c, const struct inode *host,\n> \txent->inum = 0;\n> \txent->type = get_dent_type(inode->i_mode);\n> \txent->nlen = cpu_to_le16(fname_len(nm));\n> -\tmemcpy(xent->name, fname_name(nm), fname_len(nm));\n> -\txent->name[fname_len(nm)] = '\\0';\n> +\tstrscpy(xent->name, fname_name(nm), fname_len(nm) + 1);\n> \tzero_dent_node_unused(xent);\n> \tubifs_prep_grp_node(c, xent, xlen, 0);\n> \n> diff --git a/fs/ubifs/replay.c b/fs/ubifs/replay.c\n> index a9a568f4a868..ef6ae63792d1 100644\n> --- a/fs/ubifs/replay.c\n> +++ b/fs/ubifs/replay.c\n> @@ -463,8 +463,7 @@ static int insert_dent(struct ubifs_info *c, int lnum, int offs, int len,\n> \tr->sqnum = sqnum;\n> \tkey_copy(c, key, &r->key);\n> \tfname_len(&r->nm) = nlen;\n> -\tmemcpy(nbuf, name, nlen);\n> -\tnbuf[nlen] = '\\0';\n> +\tstrscpy(nbuf, name, nlen + 1);\n> \tfname_name(&r->nm) = nbuf;\n> \n> \tlist_add_tail(&r->list, &c->replay_list);\n> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c\n> index 9a77d8b64ffa..048c21271db1 100644\n> --- a/fs/ubifs/super.c\n> +++ b/fs/ubifs/super.c\n> @@ -168,13 +168,11 @@ struct inode *ubifs_iget(struct super_block *sb, unsigned long inum)\n> \t\tinode->i_op = &ubifs_file_inode_operations;\n> \t\tinode->i_fop = &ubifs_file_operations;\n> \t\tif (ui->xattr) {\n> -\t\t\tui->data = kmalloc(ui->data_len + 1, GFP_NOFS);\n> +\t\t\tui->data = kmemdup_nul(ino->data, ui->data_len, GFP_NOFS);\n> \t\t\tif (!ui->data) {\n> \t\t\t\terr = -ENOMEM;\n> \t\t\t\tgoto out_ino;\n> \t\t\t}\n> -\t\t\tmemcpy(ui->data, ino->data, ui->data_len);\n> -\t\t\t((char *)ui->data)[ui->data_len] = '\\0';\n> \t\t} else if (ui->data_len != 0) {\n> \t\t\terr = 10;\n> \t\t\tgoto out_invalid;\n> @@ -194,13 +192,11 @@ struct inode *ubifs_iget(struct super_block *sb, unsigned long inum)\n> \t\t\terr = 12;\n> \t\t\tgoto out_invalid;\n> \t\t}\n> -\t\tui->data = kmalloc(ui->data_len + 1, GFP_NOFS);\n> +\t\tui->data = kmemdup_nul(ino->data, ui->data_len, GFP_NOFS);\n> \t\tif (!ui->data) {\n> \t\t\terr = -ENOMEM;\n> \t\t\tgoto out_ino;\n> \t\t}\n> -\t\tmemcpy(ui->data, ino->data, ui->data_len);\n> -\t\t((char *)ui->data)[ui->data_len] = '\\0';\n> \t\tbreak;\n> \tcase S_IFBLK:\n> \tcase S_IFCHR:\n>","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=xWIVUq78;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=huawei.com header.i=@huawei.com header.a=rsa-sha256\n header.s=dkim header.b=0VnCs+2j;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx3ct3gtTz1yDF\n\tfor ; Thu, 16 Apr 2026 13:38:06 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wDDYE-00000001vzP-2MkN;\n\tThu, 16 Apr 2026 03:37:58 +0000","from canpmsgout07.his.huawei.com ([113.46.200.222])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wDDYA-00000001vyv-20zc\n\tfor linux-mtd@lists.infradead.org;\n\tThu, 16 Apr 2026 03:37:57 +0000","from mail.maildlp.com (unknown [172.19.163.15])\n\tby canpmsgout07.his.huawei.com (SkyGuard) with ESMTPS id 4fx3T76nnBzLlVQ;\n\tThu, 16 Apr 2026 11:31:23 +0800 (CST)","from kwepemk500005.china.huawei.com (unknown [7.202.194.90])\n\tby mail.maildlp.com (Postfix) with ESMTPS id 008D940539;\n\tThu, 16 Apr 2026 11:37:42 +0800 (CST)","from [10.174.178.46] (10.174.178.46) by\n kwepemk500005.china.huawei.com (7.202.194.90) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1544.11; Thu, 16 Apr 2026 11:37:41 +0800"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:\n\tReferences:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=YoleshoaLHJih/hFVqsLoT3PbJOOO8c0kaf/4saZCxU=; b=xWIVUq78xUcz7FtY7TvsU0b0ja\n\tVDcUNuZkbDEn7VKZFO7S/J8+nUurkmLnC+HaYU1KD//rnxahNdlPxToXq9ZXEP+Ciy29hU8EGlJ6W\n\t0j/6fwDX5sALcwAlUPoTyvg1F8BrUjyAIDyym4lLEpU8ffjDFjB/C7F74+QEr9gPUjuZm4IntDfbe\n\tWLRkmsehmYdT1aKUNh8+GYZPlOiuA+fi9V3KcQGRBESzTci3yOlg2h2me46sntZNxHyXa06zpgnqh\n\tmpYKNMnMlCe1SB/2hzHCi+S3FqDYffEtXu+dMT6u+ARDn16u08thi8HZnMY2FJ/mNzkYSPFpQUeN4\n\tPsSKnp2Q==;","v=1; a=rsa-sha256; d=huawei.com; s=dkim;\n\tc=relaxed/relaxed; q=dns/txt;\n\th=From;\n\tbh=fka9Ktu5399cRaYIohzEKuA7MGCtIfPp3htFl3h8QDE=;\n\tb=0VnCs+2jo1AXcvl9DTIPz4P3wsRLkeNanF0uDbxab2DTKubxYDZVRTcVLBUGNCVhRnuiTqdTJ\n\tligM0/HNmmzDSowddVVtO4HgmWqIoWcDMvSoDKnrtK9Ph0E/0MKc6jSUGcJLvzSw/uTvvIn3mAc\n\txkMqmvPVPGngsT1xcjnz1lQ="],"dkim-signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:\n\tReferences:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=YoleshoaLHJih/hFVqsLoT3PbJOOO8c0kaf/4saZCxU=; b=xWIVUq78xUcz7FtY7TvsU0b0ja\n\tVDcUNuZkbDEn7VKZFO7S/J8+nUurkmLnC+HaYU1KD//rnxahNdlPxToXq9ZXEP+Ciy29hU8EGlJ6W\n\t0j/6fwDX5sALcwAlUPoTyvg1F8BrUjyAIDyym4lLEpU8ffjDFjB/C7F74+QEr9gPUjuZm4IntDfbe\n\tWLRkmsehmYdT1aKUNh8+GYZPlOiuA+fi9V3KcQGRBESzTci3yOlg2h2me46sntZNxHyXa06zpgnqh\n\tmpYKNMnMlCe1SB/2hzHCi+S3FqDYffEtXu+dMT6u+ARDn16u08thi8HZnMY2FJ/mNzkYSPFpQUeN4\n\tPsSKnp2Q==;","v=1; a=rsa-sha256; d=huawei.com; s=dkim;\n\tc=relaxed/relaxed; q=dns/txt;\n\th=From;\n\tbh=fka9Ktu5399cRaYIohzEKuA7MGCtIfPp3htFl3h8QDE=;\n\tb=0VnCs+2jo1AXcvl9DTIPz4P3wsRLkeNanF0uDbxab2DTKubxYDZVRTcVLBUGNCVhRnuiTqdTJ\n\tligM0/HNmmzDSowddVVtO4HgmWqIoWcDMvSoDKnrtK9Ph0E/0MKc6jSUGcJLvzSw/uTvvIn3mAc\n\txkMqmvPVPGngsT1xcjnz1lQ="],"Subject":"Re: [PATCH v5 2/3] ubifs: use strscpy() and kmemdup_nul() where\n appropriate","To":"Dmitry Antipov , Richard Weinberger ","CC":"","References":"<20260415071812.1139054-1-dmantipov@yandex.ru>\n <20260415071812.1139054-2-dmantipov@yandex.ru>","From":"Zhihao Cheng ","Message-ID":"<976f75c0-66a0-fc03-345e-3da0c1c5afea@huawei.com>","Date":"Thu, 16 Apr 2026 11:37:30 +0800","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101\n Thunderbird/68.5.0","MIME-Version":"1.0","In-Reply-To":"<20260415071812.1139054-2-dmantipov@yandex.ru>","X-Originating-IP":"[10.174.178.46]","X-ClientProxiedBy":"kwepems500002.china.huawei.com (7.221.188.17) To\n kwepemk500005.china.huawei.com (7.202.194.90)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260415_203755_194564_3DDB3EB4 ","X-CRM114-Status":"GOOD ( 17.09 )","X-Spam-Score":"-5.2 (-----)","X-Spam-Report":"=?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?=\n\t=?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?=\n\t=?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?=\n\t=?unknown-8bit?q?ginal?=\n\t=?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?=\n\t=?unknown-8bit?q?bel?=\n\t=?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?=\n\t=?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?b?IENvbnRlbnQgcHJldmlldzogIOWcqCAyMDI2LzQvMTUgMTU6MTgsIERt?=\n\t=?unknown-8bit?b?aXRyeSBBbnRpcG92IOWGmemBkzogPiBHbyBjbG9zZXIgdG8=?=\n\t=?unknown-8bit?q?_the_modern_kernel_API_and_use_=27strscpy=28=29=27_and_=27k?=\n\t=?unknown-8bit?q?memdup=5Fnul=28=29=27_=3E_over_an_ad-hoc?=\n\t=?unknown-8bit?q?_ensure-to-have-=27=5C0=27_quirks_where_appropriate=2E_=3E_?=\n\t=?unknown-8bit?q?=3E_Signed-off-b_=5B=2E=2E=2E=5D_?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_Content_analysis_details=3A___=28-5=2E2_points=2C_5=2E0_re?=\n\t=?unknown-8bit?q?quired=29?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_pts_rule_name______________description?=\n\t=?unknown-8bit?q?_----_----------------------_------------------------------?=\n\t=?unknown-8bit?q?--------------------?=\n\t=?unknown-8bit?q?_0=2E0_RCVD=5FIN=5FVALIDITY=5FSAFE=5FBLOCKED_RBL=3A_ADMINIS?=\n\t=?unknown-8bit?q?TRATOR_NOTICE=3A_The_query_to?=\n\t=?unknown-8bit?q?_Validity_was_blocked=2E__See?=\n\t=?unknown-8bit?q?_https=3A//knowledge=2Evalidity=2Ecom/hc/en-us/articles/209?=\n\t=?unknown-8bit?q?61730681243?=\n\t=?unknown-8bit?q?_for_more_information=2E?=\n\t=?unknown-8bit?q?_=5B113=2E46=2E200=2E222_listed_in_sa-accredit=2Ehabeas=2Ec?=\n\t=?unknown-8bit?q?om=5D?=\n\t=?unknown-8bit?q?_0=2E0_RCVD=5FIN=5FVALIDITY=5FCERTIFIED=5FBLOCKED_RBL=3A_AD?=\n\t=?unknown-8bit?q?MINISTRATOR_NOTICE=3A_The?=\n\t=?unknown-8bit?q?_query_to_Validity_was_blocked=2E__See?=\n\t=?unknown-8bit?q?_https=3A//knowledge=2Evalidity=2Ecom/hc/en-us/articles/209?=\n\t=?unknown-8bit?q?61730681243?=\n\t=?unknown-8bit?q?_for_more_information=2E?=\n\t=?unknown-8bit?q?_=5B113=2E46=2E200=2E222_listed_in_sa-trusted=2Ebondedsende?=\n\t=?unknown-8bit?q?r=2Eorg=5D?=\n\t=?unknown-8bit?q?_0=2E0_RCVD=5FIN=5FVALIDITY=5FRPBL=5FBLOCKED_RBL=3A_ADMINIS?=\n\t=?unknown-8bit?q?TRATOR_NOTICE=3A_The_query_to?=\n\t=?unknown-8bit?q?_Validity_was_blocked=2E__See?=\n\t=?unknown-8bit?q?_https=3A//knowledge=2Evalidity=2Ecom/hc/en-us/articles/209?=\n\t=?unknown-8bit?q?61730681243?=\n\t=?unknown-8bit?q?_for_more_information=2E?=\n\t=?unknown-8bit?q?_=5B113=2E46=2E200=2E222_listed_in_bl=2Escore=2Esenderscore?=\n\t=?unknown-8bit?q?=2Ecom=5D?=\n\t=?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?=\n\t=?unknown-8bit?q?record?=\n\t=?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?=\n\t=?unknown-8bit?q?ish_an_SPF_Record?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FEF__________Message_has_a_valid_DKIM?=\n\t=?unknown-8bit?q?_or_DK_signature_from?=\n\t=?unknown-8bit?q?_envelope-from_domain?=\n\t=?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?=\n\t=?unknown-8bit?q?gnature=2C_not_necessarily_valid?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FAU__________Message_has_a_valid_DKIM?=\n\t=?unknown-8bit?q?_or_DK_signature_from_author=27s?=\n\t=?unknown-8bit?q?_domain?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?=\n\t=?unknown-8bit?q?alid_DKIM_or_DK_signature?=\n\t=?unknown-8bit?q?_-1=2E9_BAYES=5F00_______________BODY=3A_Bayes_spam_probabi?=\n\t=?unknown-8bit?q?lity_is_0_to_1=25?=\n\t=?unknown-8bit?q?_=5Bscore=3A_0=2E0000=5D?=\n\t=?unknown-8bit?q?_-3=2E1_NICE=5FREPLY=5FA___________Looks_like_a_legit_reply?=\n\t=?unknown-8bit?q?_=28A=29?=","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"gbk\"; Format=\"flowed\"","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":3677939,"web_url":"http://patchwork.ozlabs.org/comment/3677939/","msgid":"<2f909ac5b916008033db7fd12804cf3e2a499e27.camel@yandex.ru>","list_archive_url":null,"date":"2026-04-16T05:09:12","subject":"Re: [PATCH v5 2/3] ubifs: use strscpy() and kmemdup_nul() where\n appropriate","submitter":{"id":87610,"url":"http://patchwork.ozlabs.org/api/people/87610/","name":"Dmitry Antipov","email":"dmantipov@yandex.ru"},"content":"On Thu, 2026-04-16 at 11:37 +0800, Zhihao Cheng wrote:\n\n> > -\tmemcpy(dent->name, fname_name(nm), fname_len(nm));\n> > -\tdent->name[fname_len(nm)] = '\\0';\n> > +\tstrscpy(dent->name, fname_name(nm), fname_len(nm) + 1);\n> \n> Hi Dmitry,\n> I notice that some architectures can accelerate the implementation of \n> memcpy(), and the length of dentry name could be 255, I suggest to keep \n> the orignal implementation.\n\nWhat about\n\nmemcpy_and_pad(dent->name, fname_len(nm) + 1, fname_name(nm), fname_len(nm), 0)?\n\nI have a strong suspicion that all of the '\\0' things should be left to\nlibrary functions. So this is not a style but rather an overall design point -\nif you're inserting '\\0' at your own, most likely you're doing something\nwrong, at least because you're duplicating something which is already\nimplemented in a library function.\n\nDmitry","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Ct9qqKoH;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=yandex.ru header.i=@yandex.ru header.a=rsa-sha256\n header.s=mail header.b=HvrEjysU;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)","\n mail-nwsmtp-smtp-production-main-94.klg.yp-c.yandex.net;\n dkim=pass header.i=@yandex.ru"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx5fh4n6mz1yDF\n\tfor ; Thu, 16 Apr 2026 15:09:44 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wDEyl-00000001yX4-0so4;\n\tThu, 16 Apr 2026 05:09:27 +0000","from forward502d.mail.yandex.net\n ([2a02:6b8:c41:1300:1:45:d181:d502])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wDEyh-00000001yWU-0Ol6\n\tfor linux-mtd@lists.infradead.org;\n\tThu, 16 Apr 2026 05:09:25 +0000","from mail-nwsmtp-smtp-production-main-94.klg.yp-c.yandex.net\n (mail-nwsmtp-smtp-production-main-94.klg.yp-c.yandex.net\n [IPv6:2a02:6b8:c42:2646:0:640:add0:0])\n\tby forward502d.mail.yandex.net (Yandex) with ESMTPS id CC093C1A26;\n\tThu, 16 Apr 2026 08:09:14 +0300 (MSK)","by mail-nwsmtp-smtp-production-main-94.klg.yp-c.yandex.net\n (smtp/Yandex) with ESMTPSA id C9FRBhOSsmI0-c1GfcxIZ;\n\tThu, 16 Apr 2026 08:09:14 +0300"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tDate:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=H4KOmUB9NzT3EmPwzAaGteN20jCf94WrKF32U8X5pw0=; b=Ct9qqKoHFOkXa8\n\tkGGyJEzXiJ3wM2tObhwV6z/N8QP85cVYIQYi5kGN1DVjg+3Fc8ayxDHfGhOsldkoh0qRViKjhPPY5\n\tRTGYKbCSe0P9L78ut4rAhn7Bbq9oSZQjay21Z7fKFyIEWhYOiu7qTPww7irX7PPjvPeGe2A8ObX9w\n\tfxDVx+O/sVsFdUj8ZF7vE7iaoFrHEISm5cpgTSqBOOTPQwjZPoL4hNLl9soqp7Pz0mq7xH50ehXWG\n\tXWeHEvumIBizVXAJ+i7vG8Zkxh0bywq75xZHfDtOqpwJERtuwINm9AAJHjFhuG3BhDGRPKF5pnu9G\n\tUsm/GGqZGyUU7EMK/VSw==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail;\n\tt=1776316154; bh=Tl+erE2uF1yR7VwzPTRIY/2Fja1UYKMSfEt+6vxNRaw=;\n\th=References:Date:In-Reply-To:Cc:To:From:Subject:Message-ID;\n\tb=HvrEjysUuzw2t3jRDYqO95o2PYXFmvfUH6ZAaC8PHeUgWaZhm7lyJ0Xards87LHE6\n\t zPHE0EtwPHKTMHUCmohw2Kp/pfrk/uhGFS4ZWg7/QosG207gzfFJpQ6fL0OSMQdBTH\n\t vkH6crULGec3jlCa4r+MpoiuHXPJXN2SEIJMw51E="],"X-Yandex-Fwd":"1","Message-ID":"<2f909ac5b916008033db7fd12804cf3e2a499e27.camel@yandex.ru>","Subject":"Re: [PATCH v5 2/3] ubifs: use strscpy() and kmemdup_nul() where\n appropriate","From":"Dmitry Antipov ","To":"Zhihao Cheng , Richard Weinberger\n ","Cc":"linux-mtd@lists.infradead.org","Date":"Thu, 16 Apr 2026 08:09:12 +0300","In-Reply-To":"<976f75c0-66a0-fc03-345e-3da0c1c5afea@huawei.com>","References":"<20260415071812.1139054-1-dmantipov@yandex.ru>\n\t <20260415071812.1139054-2-dmantipov@yandex.ru>\n\t <976f75c0-66a0-fc03-345e-3da0c1c5afea@huawei.com>","User-Agent":"Evolution 3.58.3 (3.58.3-1.fc43) ","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260415_220923_686994_7347E227 ","X-CRM114-Status":"UNSURE ( 8.58 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.8 (--)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: On Thu, 2026-04-16 at 11:37 +0800, Zhihao Cheng wrote: > >\n - memcpy(dent->name, fname_name(nm), fname_len(nm));\n > > - dent->name[fname_len(nm)]\n = '\\0'; > > + strscpy(dent->name, fname_name(nm), fname_len(nm) + 1); > >\n Hi Dmitry, > I notice that some archi [...]\n Content analysis details: (-2.8 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low\n trust\n [2a02:6b8:c41:1300:1:45:d181:d502 listed in]\n [list.dnswl.org]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n provider\n [dmantipov(at)yandex.ru]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":3677956,"web_url":"http://patchwork.ozlabs.org/comment/3677956/","msgid":"","list_archive_url":null,"date":"2026-04-16T06:41:59","subject":"Re: [PATCH v5 2/3] ubifs: use strscpy() and kmemdup_nul() where\n appropriate","submitter":{"id":76854,"url":"http://patchwork.ozlabs.org/api/people/76854/","name":"Zhihao Cheng","email":"chengzhihao1@huawei.com"},"content":"在 2026/4/16 13:09, Dmitry Antipov 写道:\n> On Thu, 2026-04-16 at 11:37 +0800, Zhihao Cheng wrote:\n> \n>>> -\tmemcpy(dent->name, fname_name(nm), fname_len(nm));\n>>> -\tdent->name[fname_len(nm)] = '\\0';\n>>> +\tstrscpy(dent->name, fname_name(nm), fname_len(nm) + 1);\n>>\n>> Hi Dmitry,\n>> I notice that some architectures can accelerate the implementation of\n>> memcpy(), and the length of dentry name could be 255, I suggest to keep\n>> the orignal implementation.\n> \n> What about\n> \n> memcpy_and_pad(dent->name, fname_len(nm) + 1, fname_name(nm), fname_len(nm), 0)?\n\nI weakly accept memcpy_and_pad().\n> \n> I have a strong suspicion that all of the '\\0' things should be left to\n> library functions. So this is not a style but rather an overall design point -\n> if you're inserting '\\0' at your own, most likely you're doing something\n> wrong, at least because you're duplicating something which is already\n> implemented in a library function.\n\nWell, kernel developers, of course, need to understand when and how to \nset the trailing '\\0'. There are many other places setting trailing \n'\\0'(eg. xfs_init_local_fork, xfs_symlink_remote_read, \next4_xattr_move_to_block, etc.). I don't think there's a problem with \nthis; the developers know what they're doing.\n> \n> Dmitry\n> .\n>","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=cL6haahZ;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=huawei.com header.i=@huawei.com header.a=rsa-sha256\n header.s=dkim header.b=mX6NxOIp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx7jV6fLKz1yCv\n\tfor ; Thu, 16 Apr 2026 16:42:22 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wDGQY-000000023xK-0bMR;\n\tThu, 16 Apr 2026 06:42:14 +0000","from canpmsgout07.his.huawei.com ([113.46.200.222])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wDGQV-000000023wU-1Piv\n\tfor linux-mtd@lists.infradead.org;\n\tThu, 16 Apr 2026 06:42:13 +0000","from mail.maildlp.com (unknown [172.19.163.200])\n\tby canpmsgout07.his.huawei.com (SkyGuard) with ESMTPS id 4fx7Yr0XtrzLlZ6;\n\tThu, 16 Apr 2026 14:35:44 +0800 (CST)","from kwepemk500005.china.huawei.com (unknown [7.202.194.90])\n\tby mail.maildlp.com (Postfix) with ESMTPS id 304A940563;\n\tThu, 16 Apr 2026 14:42:02 +0800 (CST)","from [10.174.178.46] (10.174.178.46) by\n kwepemk500005.china.huawei.com (7.202.194.90) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1544.11; Thu, 16 Apr 2026 14:42:01 +0800"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:\n\tReferences:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=qfnvws+IOKJp/as8em5t0LkCiWMShQx5A0fLfpzRqQs=; b=cL6haahZG70cMys7TfRUEEc3wg\n\tbQcMVPhG7hDUztca4tZefj9BDSld+yh3xdWG5FJ+El5T4DqXfopsa2Jmw/WlZpJkaIDb94XPtbdLq\n\tqzBQakMM8aLdP1l3vhwscOitL2slJihvqs/JvHVYqaG0vIOursCMMIL2ykJ9hx8fDXSyGWOKnAwte\n\t9Kz0CB41VLiWl52sK2R6A9MfoWz5Rf2R55ocOyXVFSCQM2uk25Anqi/vsFogqg1BLWJzp5QnEVyJN\n\tyNfKUFguL0+zMEhE/dG5Sveb82op4b+fN69e4HGBPFMKupTcz5NJV0oQwP3yNJQPcPXP+ifxrWcMV\n\ty0ZOWFdQ==;","v=1; a=rsa-sha256; d=huawei.com; s=dkim;\n\tc=relaxed/relaxed; q=dns/txt;\n\th=From;\n\tbh=l12czzoWsjjRYj0jY049KLT3AamUUuzitRn+iLM94oo=;\n\tb=mX6NxOIpNJsy5G++xuGY0pPJSJpYH4NBqSSfpnFlQyi0+lcF6SbrvJ+Nxbzbyif7XxjQDBePf\n\t1b4qXoc4CcIc+w4g7H4/+k7g+VsvqGzd0MaIa2atnQvbmlkCqgWmdUXyXNmW8f2Czmp87bq5XEW\n\tcKM1VQdj2XDhsvfvw/JSdjQ="],"dkim-signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:\n\tReferences:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=qfnvws+IOKJp/as8em5t0LkCiWMShQx5A0fLfpzRqQs=; b=cL6haahZG70cMys7TfRUEEc3wg\n\tbQcMVPhG7hDUztca4tZefj9BDSld+yh3xdWG5FJ+El5T4DqXfopsa2Jmw/WlZpJkaIDb94XPtbdLq\n\tqzBQakMM8aLdP1l3vhwscOitL2slJihvqs/JvHVYqaG0vIOursCMMIL2ykJ9hx8fDXSyGWOKnAwte\n\t9Kz0CB41VLiWl52sK2R6A9MfoWz5Rf2R55ocOyXVFSCQM2uk25Anqi/vsFogqg1BLWJzp5QnEVyJN\n\tyNfKUFguL0+zMEhE/dG5Sveb82op4b+fN69e4HGBPFMKupTcz5NJV0oQwP3yNJQPcPXP+ifxrWcMV\n\ty0ZOWFdQ==;","v=1; a=rsa-sha256; d=huawei.com; s=dkim;\n\tc=relaxed/relaxed; q=dns/txt;\n\th=From;\n\tbh=l12czzoWsjjRYj0jY049KLT3AamUUuzitRn+iLM94oo=;\n\tb=mX6NxOIpNJsy5G++xuGY0pPJSJpYH4NBqSSfpnFlQyi0+lcF6SbrvJ+Nxbzbyif7XxjQDBePf\n\t1b4qXoc4CcIc+w4g7H4/+k7g+VsvqGzd0MaIa2atnQvbmlkCqgWmdUXyXNmW8f2Czmp87bq5XEW\n\tcKM1VQdj2XDhsvfvw/JSdjQ="],"Subject":"Re: [PATCH v5 2/3] ubifs: use strscpy() and kmemdup_nul() where\n appropriate","To":"Dmitry Antipov , Richard Weinberger ","CC":"","References":"<20260415071812.1139054-1-dmantipov@yandex.ru>\n <20260415071812.1139054-2-dmantipov@yandex.ru>\n <976f75c0-66a0-fc03-345e-3da0c1c5afea@huawei.com>\n <2f909ac5b916008033db7fd12804cf3e2a499e27.camel@yandex.ru>","From":"Zhihao Cheng ","Message-ID":"","Date":"Thu, 16 Apr 2026 14:41:59 +0800","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101\n Thunderbird/68.5.0","MIME-Version":"1.0","In-Reply-To":"<2f909ac5b916008033db7fd12804cf3e2a499e27.camel@yandex.ru>","X-Originating-IP":"[10.174.178.46]","X-ClientProxiedBy":"kwepems500001.china.huawei.com (7.221.188.70) To\n kwepemk500005.china.huawei.com (7.202.194.90)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260415_234211_853125_080C2FAE ","X-CRM114-Status":"GOOD ( 13.58 )","X-Spam-Score":"-5.2 (-----)","X-Spam-Report":"=?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?=\n\t=?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?=\n\t=?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?=\n\t=?unknown-8bit?q?ginal?=\n\t=?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?=\n\t=?unknown-8bit?q?bel?=\n\t=?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?=\n\t=?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?b?IENvbnRlbnQgcHJldmlldzogIOWcqCAyMDI2LzQvMTYgMTM6MDksIERt?=\n\t=?unknown-8bit?b?aXRyeSBBbnRpcG92IOWGmemBkzogPiBPbiBUaHUsIDIwMjYtMDQtMTY=?=\n\t=?unknown-8bit?q?_at_11=3A37_+0800=2C_Zhihao_Cheng_wrote=3A_=3E_=3E=3E=3E_-_?=\n\t=?unknown-8bit?q?memcpy=28dent-=3Ename=2C_fname=5Fname=28nm=29=2C?=\n\t=?unknown-8bit?b?IGZuYW1lX2xlbihubSkpOyA+Pj4gLSBkZW50LT5uYW1lW2ZuYW1lX2xl?=\n\t=?unknown-8bit?b?bihubSldID0gJ1wwJzsgWy4uLl0g?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_Content_analysis_details=3A___=28-5=2E2_points=2C_5=2E0_re?=\n\t=?unknown-8bit?q?quired=29?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_pts_rule_name______________description?=\n\t=?unknown-8bit?q?_----_----------------------_------------------------------?=\n\t=?unknown-8bit?q?--------------------?=\n\t=?unknown-8bit?q?_0=2E0_RCVD=5FIN=5FVALIDITY=5FSAFE=5FBLOCKED_RBL=3A_ADMINIS?=\n\t=?unknown-8bit?q?TRATOR_NOTICE=3A_The_query_to?=\n\t=?unknown-8bit?q?_Validity_was_blocked=2E__See?=\n\t=?unknown-8bit?q?_https=3A//knowledge=2Evalidity=2Ecom/hc/en-us/articles/209?=\n\t=?unknown-8bit?q?61730681243?=\n\t=?unknown-8bit?q?_for_more_information=2E?=\n\t=?unknown-8bit?q?_=5B113=2E46=2E200=2E222_listed_in_sa-accredit=2Ehabeas=2Ec?=\n\t=?unknown-8bit?q?om=5D?=\n\t=?unknown-8bit?q?_0=2E0_RCVD=5FIN=5FVALIDITY=5FCERTIFIED=5FBLOCKED_RBL=3A_AD?=\n\t=?unknown-8bit?q?MINISTRATOR_NOTICE=3A_The?=\n\t=?unknown-8bit?q?_query_to_Validity_was_blocked=2E__See?=\n\t=?unknown-8bit?q?_https=3A//knowledge=2Evalidity=2Ecom/hc/en-us/articles/209?=\n\t=?unknown-8bit?q?61730681243?=\n\t=?unknown-8bit?q?_for_more_information=2E?=\n\t=?unknown-8bit?q?_=5B113=2E46=2E200=2E222_listed_in_sa-trusted=2Ebondedsende?=\n\t=?unknown-8bit?q?r=2Eorg=5D?=\n\t=?unknown-8bit?q?_0=2E0_RCVD=5FIN=5FVALIDITY=5FRPBL=5FBLOCKED_RBL=3A_ADMINIS?=\n\t=?unknown-8bit?q?TRATOR_NOTICE=3A_The_query_to?=\n\t=?unknown-8bit?q?_Validity_was_blocked=2E__See?=\n\t=?unknown-8bit?q?_https=3A//knowledge=2Evalidity=2Ecom/hc/en-us/articles/209?=\n\t=?unknown-8bit?q?61730681243?=\n\t=?unknown-8bit?q?_for_more_information=2E?=\n\t=?unknown-8bit?q?_=5B113=2E46=2E200=2E222_listed_in_bl=2Escore=2Esenderscore?=\n\t=?unknown-8bit?q?=2Ecom=5D?=\n\t=?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?=\n\t=?unknown-8bit?q?record?=\n\t=?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?=\n\t=?unknown-8bit?q?ish_an_SPF_Record?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FEF__________Message_has_a_valid_DKIM?=\n\t=?unknown-8bit?q?_or_DK_signature_from?=\n\t=?unknown-8bit?q?_envelope-from_domain?=\n\t=?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?=\n\t=?unknown-8bit?q?gnature=2C_not_necessarily_valid?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FAU__________Message_has_a_valid_DKIM?=\n\t=?unknown-8bit?q?_or_DK_signature_from_author=27s?=\n\t=?unknown-8bit?q?_domain?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?=\n\t=?unknown-8bit?q?alid_DKIM_or_DK_signature?=\n\t=?unknown-8bit?q?_-1=2E9_BAYES=5F00_______________BODY=3A_Bayes_spam_probabi?=\n\t=?unknown-8bit?q?lity_is_0_to_1=25?=\n\t=?unknown-8bit?q?_=5Bscore=3A_0=2E0000=5D?=\n\t=?unknown-8bit?q?_-3=2E1_NICE=5FREPLY=5FA___________Looks_like_a_legit_reply?=\n\t=?unknown-8bit?q?_=28A=29?=","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]