[{"id":3677853,"web_url":"http://patchwork.ozlabs.org/comment/3677853/","msgid":"","list_archive_url":null,"date":"2026-04-15T23:50:17","subject":"Re: [PATCH v2 3/4] hw/riscv/boot: Warn if a ELF format file is loaded\n as a binary","submitter":{"id":64571,"url":"http://patchwork.ozlabs.org/api/people/64571/","name":"Alistair Francis","email":"alistair23@gmail.com"},"content":"On Wed, Apr 15, 2026 at 4:50 PM Joel Stanley wrote:\n>\n> From: Nicholas Piggin \n>\n> It is possible that an ELF file can not be loaded, in that\n> case the loader falls back to loading the file as a binary\n> blob. Print a warning in this case because it is likely that\n> it is not intended.\n>\n> Signed-off-by: Nicholas Piggin \n> Reviewed-by: Daniel Henrique Barboza \n> Signed-off-by: Joel Stanley \n\nReviewed-by: Alistair Francis \n\nAlistair\n\n> ---\n> hw/riscv/boot.c | 23 +++++++++++++++++++----\n> 1 file changed, 19 insertions(+), 4 deletions(-)\n>\n> diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c\n> index f3857e984240..3ea95c175c14 100644\n> --- a/hw/riscv/boot.c\n> +++ b/hw/riscv/boot.c\n> @@ -179,13 +179,27 @@ hwaddr riscv_load_firmware(MachineState *machine,\n>\n> g_assert(firmware_filename != NULL);\n>\n> - if (load_elf_ram_sym(firmware_filename, NULL, NULL, NULL,\n> - &firmware_entry, NULL, &firmware_end, NULL,\n> - 0, EM_RISCV, 1, 0, NULL, true, sym_cb) > 0) {\n> + firmware_size = load_elf_ram_sym(firmware_filename, NULL, NULL, NULL,\n> + &firmware_entry, NULL, &firmware_end,\n> + NULL, 0, EM_RISCV, 1, 0, NULL, false,\n> + sym_cb);\n> + if (firmware_size > 0) {\n> *firmware_load_addr = firmware_entry;\n> return firmware_end;\n> }\n>\n> + if (firmware_size != ELF_LOAD_NOT_ELF) {\n> + /*\n> + * If the user specified an ELF format firmware that could not be\n> + * loaded as an ELF, it's possible that loading it as a binary is\n> + * not what was intended.\n> + */\n> + warn_report(\"could not load ELF format firmware '%s' (%s). \"\n> + \"Attempting to load as binary.\",\n> + firmware_filename,\n> + load_elf_strerror(firmware_size));\n> + }\n> +\n> firmware_size = load_image_targphys_as(firmware_filename,\n> *firmware_load_addr,\n> mem_size, NULL,\n> @@ -195,7 +209,8 @@ hwaddr riscv_load_firmware(MachineState *machine,\n> return *firmware_load_addr + firmware_size;\n> }\n>\n> - error_report(\"could not load firmware '%s'\", firmware_filename);\n> + error_report(\"could not load firmware '%s': %s\", firmware_filename,\n> + load_elf_strerror(firmware_size));\n> exit(1);\n> }\n>\n> --\n> 2.47.3\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=L/69uU3t;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwybk4FVJz1yHP\n\tfor ; Thu, 16 Apr 2026 09:51:44 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDA0Q-0006Pc-0g; Wed, 15 Apr 2026 19:50:50 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDA0O-0006PK-8x\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 19:50:48 -0400","from mail-yx1-xb133.google.com ([2607:f8b0:4864:20::b133])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wDA0M-0000rE-Ix\n for qemu-devel@nongnu.org; Wed, 15 Apr 2026 19:50:47 -0400","by mail-yx1-xb133.google.com with SMTP id\n 956f58d0204a3-651c5d525f6so4174977d50.3\n for ; Wed, 15 Apr 2026 16:50:46 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1776297045; cv=none;\n d=google.com; s=arc-20240605;\n b=HSqWvCwkK0PVH7H0dEloGoSlia8qOY0Pd827M1aGGjhqkIzQmO+8oXCvFcdk+PJw0s\n M9HQqe0PxJ61QQxY1JfYHoi3SEGLKrFlyC/5L79g2F4GwxxAz/qTdagspCydKoFtFvxI\n FmElFTU6QMjFR02X2Kgi9mt3CaEW5TJwB2esxnJXQlEHOlJ2BVJFZ8JDxu4d9vWQeKoy\n Gr3qs9qDg5Qh4jHHrEKIQK7TBWwTA9CtFsp9NI4IkSV6v9H6Zn6zfgirSIAe9jqhKG8w\n 5N/F3meANcMfKrvmWl1I9sWGqA7joPFGfq+AewCz9F5yTZObG/TjFglr/4LYqZJYDhsh\n Yrxw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=/B7AJ0oXGJ94EUmuCAKA9MH347wZ16W29PTMRxEV2hg=;\n fh=Y7awTd27tr334JwSiN65+A/N5KCPEXhaOH9gk8oiOGI=;\n b=JgB4ShBqV08BhQ2XLqenaIcuCZeIG2mCTJCVK46zFqILNyfJI3u9D51iU342gKbKYx\n m4iQ0wqzmWLNicaKLDbM6kcfbtcLNrzDQw26kcTECjSph0SqaR7L/BvIAuNk7gw50Dpw\n WemWCT2GtRuUWz3PD4QWxipqshU4AiwsxhFObf1uhPFOolnY+7fMZoFGxdgAMEA8uXnD\n 430bZCFECBysHTJp0YNB0WldmOG5Y9gOcvWu2auaX90P3a5YnTxC65yH6CCzv4xVlQBy\n IKdCBVIy6i8RzyBv28bohtik8NORWYVRopw6KgqzN2GKMGGt9WY/3D4D5qIkmS+riz0r\n neTg==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776297045; x=1776901845; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=/B7AJ0oXGJ94EUmuCAKA9MH347wZ16W29PTMRxEV2hg=;\n b=L/69uU3tEsUul7hkJd9jCNYtoaxC1nI5S8y5oErt3eSeFoOT7QZMyUSs/KhBQUH8XT\n 8LTpEEXe0sPGg2tVg3K10zkvcvy8XDVA8SE780mYdD3Ho39Nty8RdS5HYQEf0GzLsbrp\n i+RLJAu8b0KXQffUUDeC30vBnG5+3edioRwPtX6/hVxbxeqlYXdZIx3eh8Mkn0itdm1b\n o/SsP49DhLTAzkzqYve0vrPfoNs1BiYwdTkIEIZyTgO73Uxz3ekqyi/3G9plSNFI5Pwo\n 4UWP/c8WAkpqS8vRmKSmMycdEeqL1lTBlVyeX61NJuaowumH5X9ixpG47Ug787UpQaRM\n E+Iw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776297045; x=1776901845;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=/B7AJ0oXGJ94EUmuCAKA9MH347wZ16W29PTMRxEV2hg=;\n b=b41jeqCmEBVICO5mfGNATMmu2a2TWyb19liq0SQeb1J6T5889g9OlRFfKUi4aSFKqr\n ZS6sm2n+I6fYH2VKGurgb56JYEfna3HRIbbvDeb7V2b7nrweq1yZ5F2gwuZyXr3xS/sO\n uf8PET2uRawDINNyuprdgJoadGOsz3ZYe6Zp0VA/VIkum5lRBpSByiTVOcxznHsiVafQ\n 0HqyB0hDD8tPvPeNkJvOKaBMCWPyoGnbYRQz4z81wt9Uf2OOyQLYb2G7WMoDUU2qoGhZ\n p9cC/LKKT4j9eTveWT55RxcUfFZGfo4z4y+cpEPtK9jUIObX/Pcb/VaVcT0rWjsm+W8s\n Lkhg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8XU5UUAnMF1yKzh94d4ukR4i9ervfiZHJgH4cNHBJgaTCot0SvgiZpminIZ6xptdHlEB8w1cxdfVml@nongnu.org","X-Gm-Message-State":"AOJu0YwlS3a8mnq+MDpQwnqeNLN42ab4vyF/WyB8OjUdYHh8XuWcc+s1\n zAuNv2HeK2LY//jxkCgng2/pABqk3g2TPYQB2zGczFg4ctUoFFw02Ugp9tuIwnKq3gMZdTak00d\n rv8tjioTfpniRAN49lJiu8/fZLAt/AHc=","X-Gm-Gg":"AeBDietIf/AqqcHRPnzogbWFWQigA1jBGNcOF9igMbvir6boTsKtdv1dWs2jc+3B6TJ\n WxpKF/gnyM3VtM8kuOJSBDH4Bq89+UrZrI6xyDxUDSstJmZJoiOqWC3A5bAKv9mbrvQeVHptJZi\n b/fmAnk76wtUL4hrlx9CVyGniSDgQLbZHiPJtDqM2z/51yI3wauBQnKb/cH8pTWIzeyYLPVkHLv\n vuRgProjBpIxdemdfd2KKOAmxO9wcN4yVLHu2PP8V0/5jFb9lXzsK6t+jvFNJpUGFUb0umIIMyF\n bOxhf5tIk1gTFM65Q06AvV1uEUtdN3sknl4zQA==","X-Received":"by 2002:a53:d009:0:b0:651:bcbc:6e2d with SMTP id\n 956f58d0204a3-651da59aafamr9349019d50.65.1776297045081; Wed, 15 Apr 2026\n 16:50:45 -0700 (PDT)","MIME-Version":"1.0","References":"<20260415064838.652297-1-joel@jms.id.au>\n <20260415064838.652297-4-joel@jms.id.au>","In-Reply-To":"<20260415064838.652297-4-joel@jms.id.au>","From":"Alistair Francis ","Date":"Thu, 16 Apr 2026 09:50:17 +1000","X-Gm-Features":"AQROBzAFJT7V62D4L9yMoyMZBcFAdbjRcRFN8pPw5QV7F8ugBQHoADrgyy_7Mu0","Message-ID":"\n ","Subject":"Re: [PATCH v2 3/4] hw/riscv/boot: Warn if a ELF format file is loaded\n as a binary","To":"Joel Stanley ","Cc":"Alistair Francis ,\n Daniel Henrique Barboza ,\n qemu-devel@nongnu.org,\n Nicholas Piggin , Weiwei Li ,\n Michael Ellerman ,\n Joel Stanley ,\n Nick Piggin ,\n Anirudh Srinivasan , qemu-riscv@nongnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=2607:f8b0:4864:20::b133;\n envelope-from=alistair23@gmail.com; helo=mail-yx1-xb133.google.com","X-Spam_score_int":"-17","X-Spam_score":"-1.8","X-Spam_bar":"-","X-Spam_report":"(-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]