[{"id":3677521,"web_url":"http://patchwork.ozlabs.org/comment/3677521/","msgid":"<20260415075440.4000-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-15T07:54:40","subject":"Re: [LTP] lib: New library function tst_get_free_uid","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Wei,\n\n--- [PATCH 1/2] ---\n\nOn Wed, 15 Apr 2026 06:07:16 +0000, Wei Gao wrote:\n> [PATCH 1/2] lib: New library function tst_get_free_uid\n\nThe commit body is empty. Add at least one sentence explaining why\nthis helper is needed — e.g. that open16 requires two distinct\nunprivileged UIDs and that this extends the existing tst_get_free_gid\npattern to UIDs.\n\n--- [PATCH 2/2] ---\n\nOn Wed, 15 Apr 2026 06:07:17 +0000, Wei Gao wrote:\n> [PATCH 2/2] open16: allow restricted O_CREAT of FIFOs and regular files\n\nSame issue — no commit body. Describe what kernel feature is under\ntest (protected_regular/protected_fifos, kernel commit 30aba6656f61)\nand why a dedicated test was needed.\n\n> +/*\\\n> + * Verify disallows open of FIFOs or regular files not owned by the user in world\n> + * writable sticky directories\n> + */\n\nIncomplete. The test also verifies the positive case (protection=0\nallows access) and level 2 protection (group-writable sticky\ndirectories via SAFE_CHMOD(DIR, 0020|S_ISVTX)). Update the doc\ncomment to cover all three scenarios.\n\n---\nNote:\n\nOur agent completed the review of the patch. The full review can be\nfound at: https://github.com/linux-test-project/ltp-agent/actions/runs/24442661607\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=ONCoU7p2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwYMZ2HRyz1yDF\n\tfor ; Wed, 15 Apr 2026 17:54:49 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id A0AE23E292F\n\tfor ; Wed, 15 Apr 2026 09:54:46 +0200 (CEST)","from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::5])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 53C473C6FF9\n for ; Wed, 15 Apr 2026 09:54:43 +0200 (CEST)","from mail-qk1-x743.google.com (mail-qk1-x743.google.com\n [IPv6:2607:f8b0:4864:20::743])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-5.smtp.seeweb.it (Postfix) with ESMTPS id CC6646005F6\n for ; Wed, 15 Apr 2026 09:54:42 +0200 (CEST)","by mail-qk1-x743.google.com with SMTP id\n af79cd13be357-8d7e7f48499so633593685a.1\n for ; Wed, 15 Apr 2026 00:54:42 -0700 (PDT)","from\n runnervm35a4x.yaenpszya1ne1izvz2uykgmlyh.cx.internal.cloudapp.net\n ([20.109.38.244]) by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8ae6ceb80f6sm5751426d6.46.2026.04.15.00.54.40\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 15 Apr 2026 00:54:41 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776239681; x=1776844481; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=fOOY8W+fN3kJ1qy8oay8sJSYDi3oZkgpd8Id9s64kK0=;\n b=ONCoU7p2/tjgOU5eTHbIXV+n22AURQIo5OfDY/Bqu8ZgyXpuqvBU2A3fvQ1Gchaggt\n ZvhE40Ewyg6nUijgEVVlBHodwQVDSE6bz/7+RTwXNAB6IIcbiN9YbRIu67YRAmwWSo9y\n Sjzynhl3pEPx6LLn0tyAeI3sLjKtFxRLvWvuWBSaJveVGA68ZeZ9mG6z0ROZmBWvsVzH\n 1cCEam5Ii3r55xNs94Z61/U1wGg7WtdKehWqX19+26H7idqw8VfhbX0HL8C57fK9ASP8\n sxVDwlwxRdUpwU80EgSyPPDSZRUTWNLbYZMpQungx4Dj0ur6Xix9UJ91TflwfRVgaAM6\n JVow==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776239681; x=1776844481;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=fOOY8W+fN3kJ1qy8oay8sJSYDi3oZkgpd8Id9s64kK0=;\n b=WzDgOcn6jcBn6aZot9xGaMDaPwcX8/t6JoNZ+DDCpjNQ9xQ0uhuTRhKkpoWXPMUzYb\n Z5jOb3TUSpOz5/hoxsi5M6st+VHNeVSldHbxNXnPA0QQkGRZCGpiX7mHU4xwJrhR/YVO\n MnZjqbZmfxv4tmcAl8Z2nmTnwNembTX4WjLKJiUp/05suRM7l8pkrMvseU9YIyhh26Vd\n 9ec/Nx9e1Q4F6QPbZLKHka1fP7VaZiLdRJ1zQ+gbfIt4/Aa5UNNjjNHObkp9Ft/dxSLc\n aFI2wPt0UjB1LvmuPtd88swsOynjN2rm3yR3mGRWSUPfYfc0Pn42/hL9pRp2xoaxXnzT\n iX8A==","X-Gm-Message-State":"AOJu0Yw+dVlYm2lqZPIorPK69HQ8AfhM/UpnrO1Tipwax5JZBTbVJSre\n A/TnS13ASFTqH0w44jY1ew3jj6mLB2CyAJzusRQXBJaQnpWFQwNJwDm9","X-Gm-Gg":"AeBDieuKaKrcLVHPC2yrQinW6XJ/TDh7mbpWR6VWNh1FKe2NhdgAULf3s65LB6E20Im\n t47jb+2FcKk5yqbQN2lIXdNzOwuu7LKO1j2um25H3w1Y1/M5rvlNHgAiZ6bQ28d3npgT5mQv7zW\n +X75y7QuZVZ7kmbMEHr9sxSxo+3uha0CUGfFeT0Xk5u50GgtQG9JWzvX3DUTqNX5xYlqMhS/DfJ\n TTYMUvYu8NOk6MPgy/hR90ZUd7VDegDoXB9saMZ1crcJ0EHJcI42giIpgByDCB7MadrEU69zEgQ\n kQ1TOqZ71SAwf5ljnilR4kL7pRmesf6FJftKf2JTBUISoSDLmj2JDRrrsiE8PaIE+KjJOaxrfYC\n b5l9CV38PeDQoz7ijgwgZc+8FhjwDrpJOWW0aLIR6wL6CGBxXsnXvzwY+oNv4krGF6E+2rQdMo4\n 2iZgEMzZVQLxzTZ/9lQNtfNNdOeCyfz3YR6lPyMd/ZdIBC9vI7ucuhPgCzu7fc6rUlplY0MmXfl\n kbi5EmceveIDPtMDw9+Gj5LY5SQXpBVasHiOT4=","X-Received":"by 2002:a05:6214:4905:b0:89a:1364:1027 with SMTP id\n 6a1803df08f44-8ac8617efafmr328604106d6.14.1776239681368;\n Wed, 15 Apr 2026 00:54:41 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Wei Gao ","Date":"Wed, 15 Apr 2026 07:54:40 +0000","Message-ID":"<20260415075440.4000-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260415060728.21662-2-wegao@suse.com>","References":"<20260415060728.21662-2-wegao@suse.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-5.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-5.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] lib: New library function tst_get_free_uid","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]