[{"id":3677466,"web_url":"http://patchwork.ozlabs.org/comment/3677466/","msgid":"<20260415052917.3944-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-15T05:29:17","subject":"Re: [LTP] ima_kexec.sh: Use %s in printf to prevent evaluating\n cmdline backslashes","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Avinesh,\n\nOn Wed, 15 Apr 2026 06:46:36 +0200, Avinesh Kumar wrote:\n> ima_kexec.sh: Use %s in printf to prevent evaluating cmdline backslashes\n\n> - printf \"$cmdline\" > file1\n> + printf \"%s\" \"$cmdline\" > file1\n\nFix is correct. Please add a Fixes: tag pointing to the commit that\nintroduced `printf \"$cmdline\"`.\n\n---\nNote:\n\nOur agent completed the review of the patch. The full review can be\nfound at: https://github.com/linux-test-project/ltp-agent/actions/runs/24437929854\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=JcE8pEEe;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwV7r1nnTz1yHM\n\tfor ; Wed, 15 Apr 2026 15:29:28 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 9DF483E20EA\n\tfor ; Wed, 15 Apr 2026 07:29:25 +0200 (CEST)","from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id CED873CC619\n for ; Wed, 15 Apr 2026 07:29:21 +0200 (CEST)","from mail-dy1-x1344.google.com (mail-dy1-x1344.google.com\n [IPv6:2607:f8b0:4864:20::1344])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 445A86009EC\n for ; Wed, 15 Apr 2026 07:29:21 +0200 (CEST)","by mail-dy1-x1344.google.com with SMTP id\n 5a478bee46e88-2bd9a485bd6so12862230eec.1\n for ; Tue, 14 Apr 2026 22:29:21 -0700 (PDT)","from\n runnervm35a4x.ul30hyp0irqepaj0su5chck4eg.yx.internal.cloudapp.net\n ([172.215.217.99]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2de8c10ad3dsm1299030eec.3.2026.04.14.22.29.18\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 14 Apr 2026 22:29:19 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776230959; x=1776835759; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=EDNOPAWf5qtfnlBhiayDnAGT5lpOhwzdVd2iAwktsz8=;\n b=JcE8pEEeBWISk3yXgmL0Byd/4+X7BFmuCPX0akjFHEJ8WciTKKkrF2I/EU3+to16OU\n OthrEbQZLFTKSpGx3bnlYkVIJTpQMJrGr/cq4hY4eoOY9izLH/hWNsLxa7araMxZshdr\n JIza/vGfxYHdQ/GnQ+s9qhCBV9dcLE1eq7MgToLOZewj8V1NObfB0h0mUDe5MurNXyHt\n I6fyN9J/UGtXW21C7GAHZBzCPxYJfUlW+StIH9j5p26KUh5QHnQQAL2Vkx9MpjGZ5H/s\n X/oRIO+EGNLNronDMmhp0i+OMjeeeZuPXGGnc6IYy/RtyhjDbOxjW97NofAZPkHcGuGn\n ot6A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776230959; x=1776835759;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=EDNOPAWf5qtfnlBhiayDnAGT5lpOhwzdVd2iAwktsz8=;\n b=Et/3kB9LBN7iVCtCcht4QBilnK1Xpa1cp6RIYrRS2nmDnCOFpTJtiPterXjqjwuc0I\n H5tf+hpiUwyKtCZrzEdONoWVzmVd7OFmbgrKn/jqfEAPw5dYHw+mPUUHyMweYBcphXWw\n ZHBwi6b2+juAMJGqfFonLKG+yIOPexyVcCAnt9bbKYKJVZOrUraKceuXOfLUo4FRL8tr\n bTXRc4YnNsUu2lJl9hvUS4bDET9GzSwjaJBBytbrXi/+1Gmco6bHQ8pJo7yIgnvTGNF0\n S1zm0iU/9MbSvUqB66umbUDGD8JK8TSPAdc+FEufoaxYQcOhwLv3dilsUM9Rw0REKNCd\n Uf/w==","X-Gm-Message-State":"AOJu0Yyf9d2H6Bzr3HWzwlT4lNds9S92O604JY6KRFhgg3jwh1tSjZSY\n V80+Rrj+O5r4LtZy0yriMVvQN6m51Hwi5BSgz7w26eBgLicMtVDj5GZp","X-Gm-Gg":"AeBDievmRuhAdi4PIUEXoVL2EKpQem7T/oQYU8Od9hEwwvUp+tTnpiVRGjTcJOKzLZ+\n E+rTDhHU7m8GqB4Egjd9R8c7iK6EvDsT9oaX4oPBX1AV15imaVdOwnsZYk5nOy4zPLG7Z+r03Tf\n weEkZyTCuwHDPtMglVrRHDeilN/ynHbGrEKwpXyPg/4h6HsaOGodB7H+0fP60hkCFjZewPAsWU1\n OM1SpTokfeLyKtFtRp3z5biz++zL5R4iksFZaOh11PsfHGdUW3nNS1d8gmmQrWR6FBZZPsdCneU\n 1xXz+LXdgrOmqNGinfinmXxLjDlvQgLpvI/DsPPIKoyEb4p9NvJmkDfi5ok86mtU+LMuptMyAxj\n 3YQaan4iZj8DyO8ezRYLYmLcVqAWumoVGMCcCEnHxPcg1uIwji4I+oBNHz0V5qx2dqyVzuRi1MY\n zXc2KdKWVfjeE7lfqOMWgUR4IhpiccgwGgyxStub1D4nfJC11sLBJyuJBOc4U8ZzooUgOdkQfn3\n Ly5iYJJ1joiM3c6OVGM8f9AxQ==","X-Received":"by 2002:a05:7300:320a:b0:2c8:6361:ab2e with SMTP id\n 5a478bee46e88-2d5877a7b8fmr13794416eec.8.1776230959443;\n Tue, 14 Apr 2026 22:29:19 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Avinesh Kumar ","Date":"Wed, 15 Apr 2026 05:29:17 +0000","Message-ID":"<20260415052917.3944-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260415044641.97806-1-avinesh.kumar@suse.com>","References":"<20260415044641.97806-1-avinesh.kumar@suse.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,FREEMAIL_FROM,SPF_HELO_NONE,\n SPF_PASS shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-2.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-2.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] ima_kexec.sh: Use %s in printf to prevent evaluating\n cmdline backslashes","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]