[{"id":3677230,"web_url":"http://patchwork.ozlabs.org/comment/3677230/","msgid":"","list_archive_url":null,"date":"2026-04-14T14:17:35","subject":"Re: [PATCH] testsuite: add missing override to member function","submitter":{"id":24465,"url":"http://patchwork.ozlabs.org/api/people/24465/","name":"David Malcolm","email":"dmalcolm@redhat.com"},"content":"On Tue, 2026-04-14 at 15:14 +0200, Torbjörn SVENSSON wrote:\n> Ok for trunk?\n\nThanks; LGTM\n\nDave\n\n> \n> --\n> \n> Without this patch, this ends up in the logs with llvm as the default\n> compiler for the host:\n> \n> /build/gcc_src/gcc/testsuite/gcc.dg/plugin/analyzer_known_fns_plugin.\n> cc:122:8: warning: 'matches_call_types_p' overrides a member function\n> but is not marked 'override' [-Winconsistent-missing-override]\n>   122 |   bool matches_call_types_p (const call_details &cd) const\n>       |        ^\n> /build/r16-8473-g5cc0ead3625fe6/bin/../lib/gcc/arm-none-\n> eabi/16.0.1/plugin/include/analyzer/common.h:301:16: note: overridden\n> virtual function is here\n>   301 |   virtual bool matches_call_types_p (const call_details &cd)\n> const = 0;\n>       |                ^\n> 1 warning generated.\n> \n> gcc/testsuite/ChangeLog:\n> \n> \t* gcc.dg/plugin/analyzer_known_fns_plugin.cc: Add missing\n> \toverride to member function.\n> \n> Signed-off-by: Torbjörn SVENSSON \n> ---\n>  gcc/testsuite/gcc.dg/plugin/analyzer_known_fns_plugin.cc | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/gcc/testsuite/gcc.dg/plugin/analyzer_known_fns_plugin.cc\n> b/gcc/testsuite/gcc.dg/plugin/analyzer_known_fns_plugin.cc\n> index 7080fe3b984..15821d5c3e4 100644\n> --- a/gcc/testsuite/gcc.dg/plugin/analyzer_known_fns_plugin.cc\n> +++ b/gcc/testsuite/gcc.dg/plugin/analyzer_known_fns_plugin.cc\n> @@ -119,7 +119,7 @@ public:\n>      }\n>    };\n>  \n> -  bool matches_call_types_p (const call_details &cd) const\n> +  bool matches_call_types_p (const call_details &cd) const override\n>    {\n>      return cd.num_args () == 3;\n>    }","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=LeTOCb17;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=LeTOCb17","sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","sourceware.org; spf=pass smtp.mailfrom=redhat.com","server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.133.124"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw5wv2CHHz1yDF\n\tfor ; Wed, 15 Apr 2026 00:18:39 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 4C7604BA23CE\n\tfor ; Tue, 14 Apr 2026 14:18:37 +0000 (GMT)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by sourceware.org (Postfix) with ESMTP id 16C444BA23DB\n for ; Tue, 14 Apr 2026 14:17:45 +0000 (GMT)","from mail-qk1-f198.google.com (mail-qk1-f198.google.com\n [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-66-awOoLomDMTC8gRtwW0Jsww-1; Tue, 14 Apr 2026 10:17:41 -0400","by mail-qk1-f198.google.com with SMTP id\n af79cd13be357-8d5b5d607d1so1094234085a.3\n for ; Tue, 14 Apr 2026 07:17:38 -0700 (PDT)","from t14s.localdomain (c-73-38-242-98.hsd1.nh.comcast.net.\n [73.38.242.98]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8ddb5f89ccdsm1048176585a.5.2026.04.14.07.17.36\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 14 Apr 2026 07:17:36 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 4C7604BA23CE","OpenDKIM Filter v2.11.0 sourceware.org 16C444BA23DB"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 16C444BA23DB","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 16C444BA23DB","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776176265; cv=none;\n b=QpFbae2cMDGM0y4Il2QNZy39jXyQe/mmiEhPQ2OIddpXnSW8L82j+7OTWnUYof7ndQZdEsDAlmo+3qkDsyn4WwE5AEopZOkw9q8Kif40r0Fu/XJaJ+q9OjrWOlYhnYJ4VPwG9wBioucwduhSqHtYQg4h0+FldQno/vnAMXsONdI=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776176265; c=relaxed/simple;\n bh=AW6m9COq6nQebTJ49/NKG9bnyY+M3X7fABmkQxRYoD0=;\n h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version;\n b=Bt4xGWCadgKp5cpRyFwvgSpTd7d2KTyI5uhyakKcyXti2hIhGLHRgBcNhZFOA+660WulPoVDly5/0YHTJgUtDSOrGyMcUIQPLHSRnBvz6k6qGp2D8ng+leHENRxcgFRcKVUP+PU9y6ZFGuIFhMfgHXb1Vcoy4gg7dzjNwBGz0eY=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776176264;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=AW6m9COq6nQebTJ49/NKG9bnyY+M3X7fABmkQxRYoD0=;\n b=LeTOCb170RejIjtWWYd+3xzsul4aMBwUNaXHAjaShRQo9L7TGhWnQxIYraqjPoVT3OHIfi\n pzR28B41DUZoMxdUC6yUCbEQKUg7bhKjf2EvcrsqTm77C+Nm0nOWN5Zteg1uD/8A0mDGTs\n OdsxAQxPaCCMbYKHBNBGY6Y5OwQeDfQ=","X-MC-Unique":"awOoLomDMTC8gRtwW0Jsww-1","X-Mimecast-MFC-AGG-ID":"awOoLomDMTC8gRtwW0Jsww_1776176258","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776176258; x=1776781058;\n h=mime-version:user-agent:content-transfer-encoding:references\n :in-reply-to:date:to:from:subject:message-id:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=QAhBaPo5mGPYGawDQD8Ml5/WEqF9ZircwtmBfkLd5UA=;\n b=CFeT75XnU/Sij660JllgDurHR8JeH4FmtBFPZhFkwRGb5yH62py+GO29u9Mf3K9Tw7\n xVf/8AWbRw3tK2p5rzdz2jM7dPPWLnEtX6+FThXVhEGvLb3FtPl5hnuFjGTD8+9xcUC4\n qQT/Hl3p3Xj6fK64Zzy3UGQeFAVbP2r9xX9yirMimoU1UIJq8b2iQDCFt7ujtHrpDavk\n 56hmaIc7DVcrVtIFD8JPIHVeorncgxa6rqbbtz3AVxjNSqG6LF1Pexk0ycF2G9syX1RL\n hSQFkIj0+9D9GNHWmEXI4F088Xa4wjwPjRouA7i9TTqjKkhZrQfnPL3EPLOpYTGvY1Yl\n pRug==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/dDeOxHiyBIRoN1K+wUL1kFdlGyyHkZrwmlkUKYrL4FGuoSFVLKzHxUKb4GuFi5kfPYt0Em2Xk7y0uPA==@gcc.gnu.org","X-Gm-Message-State":"AOJu0YwZjkceDpKfNNojId9vWBuHlXOwyACJkR69FhK8o6MQMEEB2UIK\n QQZ+PJrClRWoqZatf0tdDl0DQKpyLNMaunvRBhYo7OKQHUR16tFpv7FcHIblc7y7Yc40PtVkYCw\n I9TqhjtUmea27J7Xzh8n3Cn39bkQSdzPZcXET6N8XhDmqjCLx7S7WfCF408w=","X-Gm-Gg":"AeBDievPhva+F5zp4vd2Y1aLw+sVoEJNTqBeO0fgTlAyPSnXOGECbO/m2G8HoT6SUA9\n 7P8ltgAHg50rzumoU/GCC7MZE4I6cHgpUbI4DilAOfYOryd4J6BTcckKG4U8jbq0ch8GPayzgsK\n K5PFn7VxJJP8PSaPbsPQK5ESDyiPAuBeqFUVGTpUjeEVWBYnXBl3YJRLSmWYoQTvngQKeyTrKzz\n 2sZYVgT2YIXCsHb+yn/BqasXpBfz6DRvhPeCiAxo6IRCUf9R9MA9OArk/aM3Pv3rsUi2FauYojD\n RXXfuexrgANYdSl3d3sOtjzX7Os7tXPQevUrcFdnAiPhZHDGXSsrSZh7QcXRfAhdkYBS0ELebbT\n wnvUDtapcsIDlD9OMy5eGviuvQhM/a6popbE3SWDthT/tFk5yAwk0en9k0nn61g==","X-Received":["by 2002:a05:620a:44d2:b0:8d5:26e2:661f with SMTP id\n af79cd13be357-8ddcf2b0ffdmr2572952585a.42.1776176257547;\n Tue, 14 Apr 2026 07:17:37 -0700 (PDT)","by 2002:a05:620a:44d2:b0:8d5:26e2:661f with SMTP id\n af79cd13be357-8ddcf2b0ffdmr2572947485a.42.1776176257056;\n Tue, 14 Apr 2026 07:17:37 -0700 (PDT)"],"Message-ID":"","Subject":"Re: [PATCH] testsuite: add missing override to member function","From":"David Malcolm ","To":"=?iso-8859-1?q?Torbj=F6rn?= SVENSSON ,\n gcc-patches@gcc.gnu.org, ro@CeBiTec.Uni-Bielefeld.DE","Date":"Tue, 14 Apr 2026 10:17:35 -0400","In-Reply-To":"<20260414131514.942431-1-torbjorn.svensson@foss.st.com>","References":"<20260414131514.942431-1-torbjorn.svensson@foss.st.com>","User-Agent":"Evolution 3.54.3 (3.54.3-1.fc41)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"gpmZrPZMB1paBuhgGbpJf7GgqMZmPO-7UWSybDYgYEc_1776176258","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]