[{"id":3677201,"web_url":"http://patchwork.ozlabs.org/comment/3677201/","msgid":"<7be383bc-40f1-4da2-96c7-241946e6e52d@linaro.org>","list_archive_url":null,"date":"2026-04-14T13:23:53","subject":"Re: [PATCH v2] accel/hvf: fix double hv_vcpu_destroy() causing\n teardown error on ARM","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 14/4/26 15:11, Matheus Tavares Bernardino wrote:\n> The following callstack causes hv_vcpu_destroy() to be called twice,\n> producing HV_BAD_ARGUMENT on the already-destroyed handler:\n> \n> hvf_vcpu_destroy\n> |\n> |_ hv_vcpu_destroy\n> |\n> |_ hvf_arch_vcpu_destroy\n> |\n> |_ hv_vcpu_destroy\n> \n> The first hv_vcpu_destroy call covers both x86 and arm. Let's remove the\n> second one, as it is redundant.\n> \n> Signed-off-by: Matheus Tavares Bernardino \n> ---\n> v1: https://lore.kernel.org/qemu-devel/70cca2a5cdde3e6531e5c8f1e399e0b584d51ad6.1776096073.git.matheus.bernardino@oss.qualcomm.com/\n> \n> Changed in v2: removed second call instead of first one to avoid\n> breaking x86 (thanks Philippe!)\n> \n> target/arm/hvf/hvf.c | 4 ----\n> 1 file changed, 4 deletions(-)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Me6I1l2A;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw4kF3xyPz1y2d\n\tfor ; Tue, 14 Apr 2026 23:24:21 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCdkF-0003qb-RT; Tue, 14 Apr 2026 09:23:59 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wCdkE-0003qM-Jv\n for qemu-devel@nongnu.org; Tue, 14 Apr 2026 09:23:58 -0400","from mail-wm1-x335.google.com ([2a00:1450:4864:20::335])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wCdkC-0001HK-VN\n for qemu-devel@nongnu.org; Tue, 14 Apr 2026 09:23:58 -0400","by mail-wm1-x335.google.com with SMTP id\n 5b1f17b1804b1-488a29e6110so60859245e9.3\n for ; Tue, 14 Apr 2026 06:23:56 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488d5d78cfdsm123676355e9.4.2026.04.14.06.23.53\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 14 Apr 2026 06:23:54 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776173035; x=1776777835; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=fFGBXNObjmSGSFnpuHSqIcNQxPNr0H1Q6j6ng522NCY=;\n b=Me6I1l2AMOUZcORtZaS7J8AGx9sKY3sVevoTJszHqdw/3HfLK/m32B9A6+sTUk8A2K\n 1IxPa6HQ2u6x5TDJfN0RWOBTRlA3br1whpNOEZRx1TOMS5nL0OyTGq1e1MjEpr0Uv7XE\n b1YCFuQdgejlOQ1zptvqvydexIT2urEMe1OcCO+5bhS12tdU8Vhcdlivkrp09jMktcTN\n fc4tp0z36GkxwEdlD4HOS2YiAJKT4p57MXq7DBrkB9cdkce/MjQjmC7H2SctRD79gTEh\n r+qdbVtPRomCUFjv8v4vP2nIJKKTwbGpfQyNT+MJWeOOSdPMIq/0Q4vkuK9Rz7bwSAcZ\n qtkQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776173035; x=1776777835;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=fFGBXNObjmSGSFnpuHSqIcNQxPNr0H1Q6j6ng522NCY=;\n b=AUCexCYVJSn1E53U3ApH2sZlZXsE/lkNDkkxhgISAugo2WyJyVSyvbctSJLjDSSdjL\n fWzAAt7LjX39Y8NDmbOiWhYWjJvWZrO7m9mx2jWeGsJvXQI5hxIrYSnjvMN94SC3QKoQ\n OUF1vQAvZbnosIxtvZVWhj32/Uy1r4fE4jBxAUW/iyUtQMOGPUT+9QQNuvgTLHdEdO8c\n X0FjrxT5i0ZClhNHc8STZbR5gVPjIo5fkupzQo5Qhz3ybji3t8xjMiRYSG4qOHEHmk9S\n U9P6ZaVqxp+5kxXhCCCYD/gumfBj7jPl5X/9kLUsLMc8Hvm6af2YayJ+bCGG79k5zDeD\n 9Y4Q==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/igdhzl5sdP9+HVaSkOmfzUlTKVRWP8E2VrDQq84p/VKylXrWB7j7svZTvCRx4f3P8nE1E4uF1Bkc8@nongnu.org","X-Gm-Message-State":"AOJu0YyvsJiUQjdpHtl0odod/mOuGFtmG3muqrUDGSL/xbkeQ8LhR2Yn\n UlOaGDens7BA0G/5MA81Dxl+E8jHpEG/PDau/cV55OnQKWYirvdBZPHUrihDkNfqXN0jAWY6LsY\n JNdT8ZzU=","X-Gm-Gg":"AeBDieuyqBc3elpn5lMV7A7gZceta3gRhDQ4CUhNkHy9ijno+tWaHXTb42eMQ1HRE31\n nl5xU2tyG/rkqfUgyGQr/o6DSJULKndezyWKXu+FNNrEJCHxEXq1T7pVm9XY8nruQS7cSt4Yo7q\n 1qSSpewUjKQb+gWnImK1De7waMiO/OvvxSFxM/VbicUqdl11qrQY5QmXviE58pRGMT7VhKsn35p\n rcFTjwwNaz29kKz6oFUigRXbFqSLzGtAYQpuULfd0moUw6BkitvoxQfkk9ES9+rAxX5thHEzyNG\n R+ylsyrcQfkx5Z9SR8K+JqJR9np9d7MrrIbRBawoxSm6deiCI8LTniSLeEqDqYmIU3x4vlnYOF9\n BlgRE9P0pY0PBwKh8X/Vxu+6dYDm4thNNRvo4989GIeHfeHpLdnQErQQnIgGvZkh309rKDIMNxk\n JBm2w5XGtmjJvcmYJ3W4l+GPBn22o+gEdmOehJ32MAWdJ8Fb3/yiQwOGE/IHwo1MUDBQ==","X-Received":"by 2002:a05:600c:a11c:b0:488:af14:f1da with SMTP id\n 5b1f17b1804b1-488d67f9a25mr173887085e9.7.1776173035112;\n Tue, 14 Apr 2026 06:23:55 -0700 (PDT)","Message-ID":"<7be383bc-40f1-4da2-96c7-241946e6e52d@linaro.org>","Date":"Tue, 14 Apr 2026 15:23:53 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2] accel/hvf: fix double hv_vcpu_destroy() causing\n teardown error on ARM","To":"Matheus Tavares Bernardino ,\n qemu-devel@nongnu.org","Cc":"agraf@csgraf.de, slp@redhat.com, peter.maydell@linaro.org,\n richard.henderson@linaro.org, mads@ynddal.dk, brian.cain@oss.qualcomm.com,\n mburton@qti.qualcomm.com, \"open list:ARM TCG CPUs\" ","References":"\n ","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Content-Language":"en-US","In-Reply-To":"\n ","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::335;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]