[{"id":3677145,"web_url":"http://patchwork.ozlabs.org/comment/3677145/","msgid":"","list_archive_url":null,"date":"2026-04-14T11:38:43","subject":"Re: [PATCH v2 nf] netfilter: nf_flow_table_ip: Introduce\n nf_flow_vlan_push()","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/people/1315/","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"content":"On Tue, Apr 14, 2026 at 01:21:20PM +0200, Eric Woudstra wrote:\n> Calling skb_reset_mac_header() before calling skb_vlan_push() does\n> remove the error:\n> \n> \"skb_vlan_push got skb with skb->data not at mac header (offset 18)\"\n> \n> But the inner vlan tag is still not inserted correctly.\n> \n> skb_vlan_push() uses __vlan_insert_inner_tag() to insert the tag\n> at offset ETH_HLEN. But the inner tag should only be pushed, without\n> offset, similar to nf_flow_pppoe_push().\n\nIt is doubled-tagged-vlan that is broken, right? I observed this once\nbut I have been burdened into a few things.\n\n> Fixes: c653d5a78f34 (\"netfilter: flowtable: inline vlan encapsulation in xmit path\")\n> Fixes: a3aca98aec9a (\"netfilter: nf_flow_table_ip: reset mac header before vlan push\")\n> Signed-off-by: Eric Woudstra \n> \n> ---\n> \n> net/netfilter/nf_flow_table_ip.c | 25 ++++++++++++++++++++++---\n> 1 file changed, 22 insertions(+), 3 deletions(-)\n> \n> diff --git a/net/netfilter/nf_flow_table_ip.c b/net/netfilter/nf_flow_table_ip.c\n> index fd56d663cb5b..0086f8a1a0d6 100644\n> --- a/net/netfilter/nf_flow_table_ip.c\n> +++ b/net/netfilter/nf_flow_table_ip.c\n> @@ -544,6 +544,26 @@ static int nf_flow_offload_forward(struct nf_flowtable_ctx *ctx,\n> \treturn 1;\n> }\n> \n> +static int nf_flow_vlan_push(struct sk_buff *skb, __be16 proto, u16 id)\n> +{\n> +\tif (skb_vlan_tag_present(skb)) {\n> +\t\tstruct vlan_hdr *vhdr;\n> +\n> +\t\tif (skb_cow_head(skb, VLAN_HLEN))\n> +\t\t\treturn -1;\n> +\n> +\t\t__skb_push(skb, VLAN_HLEN);\n> +\t\tskb_reset_network_header(skb);\n> +\t\tvhdr = (struct vlan_hdr *)(skb->data);\n> +\t\tvhdr->h_vlan_TCI = htons(id);\n> +\t\tvhdr->h_vlan_encapsulated_proto = skb->protocol;\n> +\t\tskb->protocol = proto;\n> +\t} else {\n> +\t\t__vlan_hwaccel_put_tag(skb, proto, id);\n> +\t}\n> +\treturn 0;\n> +}\n> +\n> static int nf_flow_pppoe_push(struct sk_buff *skb, u16 id)\n> {\n> \tint data_len = skb->len + sizeof(__be16);\n> @@ -738,9 +758,8 @@ static int nf_flow_encap_push(struct sk_buff *skb,\n> \t\tswitch (tuple->encap[i].proto) {\n> \t\tcase htons(ETH_P_8021Q):\n> \t\tcase htons(ETH_P_8021AD):\n> -\t\t\tskb_reset_mac_header(skb);\n> -\t\t\tif (skb_vlan_push(skb, tuple->encap[i].proto,\n> -\t\t\t\t\t tuple->encap[i].id) < 0)\n> +\t\t\tif (nf_flow_vlan_push(skb, tuple->encap[i].proto,\n> +\t\t\t\t\t tuple->encap[i].id) < 0)\n> \t\t\t\treturn -1;\n> \t\t\tbreak;\n> \t\tcase htons(ETH_P_PPP_SES):\n> -- \n> 2.53.0\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=netfilter.org header.i=@netfilter.org\n header.a=rsa-sha256 header.s=2025 header.b=eqBfu3eJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11874-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=\"eqBfu3eJ\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=217.70.190.124","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=netfilter.org"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw2TQ5N9Jz1xtJ\n\tfor ; Tue, 14 Apr 2026 21:43:06 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 7C0A93054B89\n\tfor ; Tue, 14 Apr 2026 11:38:55 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 9599B3D9DB2;\n\tTue, 14 Apr 2026 11:38:51 +0000 (UTC)","from mail.netfilter.org (mail.netfilter.org [217.70.190.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FBCC3DDDDC;\n\tTue, 14 Apr 2026 11:38:48 +0000 (UTC)","from netfilter.org (mail-agni [217.70.190.124])\n\tby mail.netfilter.org (Postfix) with UTF8SMTPSA id 7E42060178;\n\tTue, 14 Apr 2026 13:38:46 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776166730; cv=none;\n b=YHb9PJFsaFm9Z16inKcm/KmJ2k4cL6D5xsWSrzYjQMJvnxd2DizpJbzWvVhsMWohA6UEdn7p88zYJPLFvRnTc4cKm4M1oaG4AXM9SEDur9EobaPOfjFF4yjX5r1NLT2mC8xb/40W0Wbj/Pa3gxAzHJHY9oT4ZvUCMur59jC3BH0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776166730; c=relaxed/simple;\n\tbh=vCVZ+zoZqp6gSO0rlh0JkfvkZttK9T2KZQPt5CRzo08=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=N9xvbZRAgYiVIYGG2S2Ls+MadjkDpifVLq8AyR4ovzfebvXjDl5WJWlUVs1HhrR9ukwd9wT/rGW6h8+1T3wgAL1amAdXH2ju4yqBljV8ddkcjBcM4tphMQeaaEgxbHCC4vBGOgSnGLyKCOwshMTcGaKxLGl+WJHzHr2KeXd9gIc=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org;\n spf=pass smtp.mailfrom=netfilter.org;\n dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=eqBfu3eJ; arc=none smtp.client-ip=217.70.190.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org;\n\ts=2025; t=1776166726;\n\tbh=PWRJlL0OVFizlyMCQKPwkDnirKlbpiCXOQ5Rhc5nwV8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=eqBfu3eJekn02WH2Cjycm1MtG9kVy7FUZsSGWkyYNSjCJKYZ4/dEPs+pFhR9FbH9M\n\t g+odOVG5STPI0jfMmLY7Dvk2KwfAppFlLf9Cy6ukoh3HLDFVmndNUnfROrnD786adt\n\t s2fn7mV8SooVT59lVcRALbWGCYBTZBhfCXy8NSwDM/Lhcb/0PBvQM5O+zm+cclZnEM\n\t 5rb4G19TjkCw/noTdinqR6k0VG+OWn3EsulHKUiyzoBKZDzMsAWvF/qdASuislnP0v\n\t F0pD1N8Tv4iTRTARlYhsJcwcfE3wLh6vASHff5UyYRMxf3zxQ7/mOCOUkUyXDF8T03\n\t SvbBQARsKW8Sw==","Date":"Tue, 14 Apr 2026 13:38:43 +0200","From":"Pablo Neira Ayuso ","To":"Eric Woudstra ","Cc":"Florian Westphal , Phil Sutter ,\n\t\"David S. Miller\" ,\n\tEric Dumazet ,\n\tJakub Kicinski , Paolo Abeni ,\n\tSimon Horman , netfilter-devel@vger.kernel.org,\n\tnetdev@vger.kernel.org","Subject":"Re: [PATCH v2 nf] netfilter: nf_flow_table_ip: Introduce\n nf_flow_vlan_push()","Message-ID":"","References":"<20260414112120.248744-1-ericwouds@gmail.com>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260414112120.248744-1-ericwouds@gmail.com>"}},{"id":3677159,"web_url":"http://patchwork.ozlabs.org/comment/3677159/","msgid":"<0f0f217e-a32b-4c9a-ab65-1cac5c86c76f@gmail.com>","list_archive_url":null,"date":"2026-04-14T12:00:57","subject":"Re: [PATCH v2 nf] netfilter: nf_flow_table_ip: Introduce\n nf_flow_vlan_push()","submitter":{"id":87708,"url":"http://patchwork.ozlabs.org/api/people/87708/","name":"Eric Woudstra","email":"ericwouds@gmail.com"},"content":"On 4/14/26 1:38 PM, Pablo Neira Ayuso wrote:\n> On Tue, Apr 14, 2026 at 01:21:20PM +0200, Eric Woudstra wrote:\n>> Calling skb_reset_mac_header() before calling skb_vlan_push() does\n>> remove the error:\n>>\n>> \"skb_vlan_push got skb with skb->data not at mac header (offset 18)\"\n>>\n>> But the inner vlan tag is still not inserted correctly.\n>>\n>> skb_vlan_push() uses __vlan_insert_inner_tag() to insert the tag\n>> at offset ETH_HLEN. But the inner tag should only be pushed, without\n>> offset, similar to nf_flow_pppoe_push().\n> \n> It is doubled-tagged-vlan that is broken, right? I observed this once\n> but I have been burdened into a few things.\n\nThat is correct, both q-in-q and q-in-ad (that may not be the correct\nterms, but I think it is clear).\n\n>> Fixes: c653d5a78f34 (\"netfilter: flowtable: inline vlan encapsulation in xmit path\")\n>> Fixes: a3aca98aec9a (\"netfilter: nf_flow_table_ip: reset mac header before vlan push\")\n>> Signed-off-by: Eric Woudstra \n>>\n>> ---\n>>\n>> net/netfilter/nf_flow_table_ip.c | 25 ++++++++++++++++++++++---\n>> 1 file changed, 22 insertions(+), 3 deletions(-)\n>>\n>> diff --git a/net/netfilter/nf_flow_table_ip.c b/net/netfilter/nf_flow_table_ip.c\n>> index fd56d663cb5b..0086f8a1a0d6 100644\n>> --- a/net/netfilter/nf_flow_table_ip.c\n>> +++ b/net/netfilter/nf_flow_table_ip.c\n>> @@ -544,6 +544,26 @@ static int nf_flow_offload_forward(struct nf_flowtable_ctx *ctx,\n>> \treturn 1;\n>> }\n>> \n>> +static int nf_flow_vlan_push(struct sk_buff *skb, __be16 proto, u16 id)\n>> +{\n>> +\tif (skb_vlan_tag_present(skb)) {\n>> +\t\tstruct vlan_hdr *vhdr;\n>> +\n>> +\t\tif (skb_cow_head(skb, VLAN_HLEN))\n>> +\t\t\treturn -1;\n>> +\n>> +\t\t__skb_push(skb, VLAN_HLEN);\n>> +\t\tskb_reset_network_header(skb);\n>> +\t\tvhdr = (struct vlan_hdr *)(skb->data);\n>> +\t\tvhdr->h_vlan_TCI = htons(id);\n>> +\t\tvhdr->h_vlan_encapsulated_proto = skb->protocol;\n>> +\t\tskb->protocol = proto;\n>> +\t} else {\n>> +\t\t__vlan_hwaccel_put_tag(skb, proto, id);\n>> +\t}\n>> +\treturn 0;\n>> +}\n>> +\n>> static int nf_flow_pppoe_push(struct sk_buff *skb, u16 id)\n>> {\n>> \tint data_len = skb->len + sizeof(__be16);\n>> @@ -738,9 +758,8 @@ static int nf_flow_encap_push(struct sk_buff *skb,\n>> \t\tswitch (tuple->encap[i].proto) {\n>> \t\tcase htons(ETH_P_8021Q):\n>> \t\tcase htons(ETH_P_8021AD):\n>> -\t\t\tskb_reset_mac_header(skb);\n>> -\t\t\tif (skb_vlan_push(skb, tuple->encap[i].proto,\n>> -\t\t\t\t\t tuple->encap[i].id) < 0)\n>> +\t\t\tif (nf_flow_vlan_push(skb, tuple->encap[i].proto,\n>> +\t\t\t\t\t tuple->encap[i].id) < 0)\n>> \t\t\t\treturn -1;\n>> \t\t\tbreak;\n>> \t\tcase htons(ETH_P_PPP_SES):\n>> -- \n>> 2.53.0\n>>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=iHnPXdgh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11878-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"iHnPXdgh\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.208.46","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw2z122NYz1y2d\n\tfor ; Tue, 14 Apr 2026 22:05:17 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id A39CC306EFC0\n\tfor ; Tue, 14 Apr 2026 12:01:13 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id C78C33E6383;\n\tTue, 14 Apr 2026 12:01:06 +0000 (UTC)","from mail-ed1-f46.google.com (mail-ed1-f46.google.com\n [209.85.208.46])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 313D03E5ECB\n\tfor ; Tue, 14 Apr 2026 12:01:01 +0000 (UTC)","by mail-ed1-f46.google.com with SMTP id\n 4fb4d7f45d1cf-6708cc2d6f6so6086186a12.0\n for ;\n Tue, 14 Apr 2026 05:01:01 -0700 (PDT)","from ?IPV6:2001:1c00:20d:1300:1b1c:4449:176a:89ea?\n (2001-1c00-020d-1300-1b1c-4449-176a-89ea.cable.dynamic.v6.ziggo.nl.\n [2001:1c00:20d:1300:1b1c:4449:176a:89ea])\n by smtp.gmail.com with ESMTPSA id\n 4fb4d7f45d1cf-671a15577f9sm967915a12.17.2026.04.14.05.00.58\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 14 Apr 2026 05:00:59 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776168065; cv=none;\n b=FsXljagQZ//AwONxWBcJPBsa0f+K3IpKsxUW6h/byvm9wc8sHDfWPTOjcea2Kb2heHJWAYNLYMYSv8ooAR1iDyMgK3XPAZLdjIeRGsL4DCBa+Jd7fyWlowLWDG4b/t6LpYUqVHDxSfteL4U7NK9Vxq9A0RVP743xbqntQt4HARI=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776168065; c=relaxed/simple;\n\tbh=HXU24dwSM6A1AxV04g/pB5XxRZxXiy1LoONcd+loM3Y=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=bH5TIeL7RmQ/AW8UGf9LO/A6vtwKEEOL3T0BhtTSBecZdm20nKxe14lESCv08SJUoJXn344xr+iMVUrt32FTb3Wa7FD+ujXjPOXFDyMY/SlD8ARGUZ+7zkPDQhkwSxfIhrZxRTlSAj7R7MYSySwFnImCv+afCITPVsXZ9RUcAUU=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=iHnPXdgh; arc=none smtp.client-ip=209.85.208.46","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776168060; x=1776772860;\n darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=2d7SDP4tYVNHF5RjK6Z4XWLo0StG4PwjgZJsw7TAjok=;\n b=iHnPXdghhNhZxQbXGPpMQAy/WghyKP2lAqDKIiIHKVP2ztJFDYMq53D48MDqEdRDO7\n 6ViTDklUvBoUzzELRjXzMFeGMW8aH2tAUofR8+0D2flzvi0k0sDcF21Jla/JfFWLMGtC\n N19iii2ppBH+JXZsnOC1V/mfn/ZV0kgJPE0lBmm9z1tbJDqzqZ8DCML/yT1YGNrfYDpj\n cXQbZx8uP+MydG2v+QhdZ0+p3ACbAJcEwok93FL5OHndXiDkxBE9dzLDMbjzE46wgv2J\n anz+RbGttUpBQ21ZTv3zNiRyhk5CMV1NfSOpV8Hka03hd+MF61Kg1gT5bqQItvRRFtRv\n 2MIQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776168060; x=1776772860;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=2d7SDP4tYVNHF5RjK6Z4XWLo0StG4PwjgZJsw7TAjok=;\n b=Yo75DiTvKvHd9GYmi8qT+TTZCaNWlpNdJzdZLBfytg3BIDFVbkqUFs+X+S30V5gSlB\n +Eo6XhzS+q08zuk5uWupKucR7PNQaJOdh3jvjsudy0/jyhW910LoVUHrW0iWwWqqE/yO\n tLMmZmV5nkJI80rLGaOOO3kzycZZWK1T1+o2TsMTGQAqv3J6jx7ubeMc+0Lnud+kqf7h\n KcNGayBoy+Ymq7FJqd8p7PafS67ZHAb9WY1zcPd0lR/+SBNUgUqqorjRDwZoJqMRmk76\n 3GfTUwXsj+2TwcwTtKGog1GIOONX2fiGPoHFCTivJzljApIuMfNqYDs1ITYHv0VWlq9N\n QOeQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+8M9n42kthP9fm5gz+FdlQIRyc7LmmFYKk4/tLUS+EPcHE9jUI7FiYimVwK4DqPSgGHzqZnc3HfRSfbtp9bAI=@vger.kernel.org","X-Gm-Message-State":"AOJu0YylsvgbgjO2z2/kDg4GR7i37ftHPA6djpx0rnRhXWKjjmAouK97\n\t9tItIScpQEhQlJGmT+hZgAaUHJ3IK96FH5kafsFxOHcYZlTk5Yqsq0vp","X-Gm-Gg":"AeBDiesT3Rowcmx9eYxbB+csuvANO1/dHL8vbqXigmO+o7MDQU4Pn5AKszTD2KOsRKO\n\tqjMUi25bQQWLjFxf3Rzjgp3uW/BISBZ4RsOjmua8ZKAYFgjMLHPyQ0aT5nKXgsxEjidB6jHYngs\n\tq5KjuSoIMT6LJhu4ndxMX1WAZZDE0sV/rTGFMbmImo9fQIRiuEwYFYPqC244NvlraQ4qteFP/eq\n\tfnSPCfkGHE0XqfbMHqk52BSjHP3tcWMnyDY9EXCXFRmu/WxSsgFs9vTVzA1GoPtsBPkyS2b+zwR\n\t58rAPBGVPxczflZYJPiHZL4xVTeoS2W/jDCn2rHcbO1BHmVSnHwbLrXbdlKckWMMxIO49PlfZfC\n\tJ52iS7E2lAg4mS2udcM6fxz05lonhSMuzF/DeTY2DBHQDI0EKdwIUM0eEGn1tgOEroHHv64xaeU\n\tCHZ8lyJeivfDjP7rb2rjPfPnkpbRS/m9FA1bnl/Kv3XnZMBM6y/Ts8RRXu8EkzSRaKMBqifrUug\n\tBXkOUqDIBD5A7Z680QctXWOuENcAlvzZJHe6bclOWWsI0ZvO4AKrCjEW5e5qOPO6k/ZXinC59o9\n\tNmS7xjIZRZGOgW8wfhlQW8tOc8XOXCdA2w==","X-Received":"by 2002:a05:6402:1cc5:b0:66d:d0c1:f87b with SMTP id\n 4fb4d7f45d1cf-67079508c00mr8427873a12.10.1776168059477;\n Tue, 14 Apr 2026 05:00:59 -0700 (PDT)","Message-ID":"<0f0f217e-a32b-4c9a-ab65-1cac5c86c76f@gmail.com>","Date":"Tue, 14 Apr 2026 14:00:57 +0200","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 nf] netfilter: nf_flow_table_ip: Introduce\n nf_flow_vlan_push()","To":"Pablo Neira Ayuso ","Cc":"Florian Westphal , Phil Sutter ,\n \"David S. Miller\" , Eric Dumazet ,\n Jakub Kicinski , Paolo Abeni ,\n Simon Horman , netfilter-devel@vger.kernel.org,\n netdev@vger.kernel.org","References":"<20260414112120.248744-1-ericwouds@gmail.com>\n ","From":"Eric Woudstra ","Content-Language":"en-US","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit"}}]