[{"id":3677120,"web_url":"http://patchwork.ozlabs.org/comment/3677120/","msgid":"<449f5a8e-10d5-4fdf-86d5-e50ce017b686@kernel.org>","list_archive_url":null,"date":"2026-04-14T10:33:54","subject":"Re: [PATCH] nfc: s3fwrn5: switch to GPIO descriptor API","submitter":{"id":68952,"url":"http://patchwork.ozlabs.org/api/people/68952/","name":"Krzysztof Kozlowski","email":"krzk@kernel.org"},"content":"On 14/04/2026 12:22, deep@crimson.net.eu.org wrote:\n> From: Kenet Jovan Sokoli \n> \n> I am working on cleaning up some legacy GPIO usage in the NFC subsystem.\n> This patch converts the s3fwrn5 driver to use the modern descriptor based\n> GPIO API instead of the old integer based one.\n> \n> Specifically:\n> - I changed the gpio_en and gpio_fw_wake types to struct gpio_desc.\n> - Replaced the manual DT parsing with devm_gpiod_get() in the probe\n> functions.\n> - Updated the calls in phy_common.c to use gpiod_set_value().\n> \n> This also allowed me to remove the s3fwrn5_i2c_parse_dt and\n> s3fwrn82_uart_parse_dt functions as they are no longer needed with the\n> new API.\n> \n> Signed-off-by: Kenet Jovan Sokoli \n> ---\n> I have verified that this patch builds successfully with \"make M=drivers/nfc/s3fwrn5\"\n> \"scripts/checkpatch.pl\" with no errors or warnings.\n> This is very complicated stuff, but I am learning a lot by doing these cleanup works.\n> I really hope I can contribute as much as possible to this environment, little by little.\n> ---\n\n\nPlease do not duplicate existing work needlessly.\n\nhttps://lore.kernel.org/all/?q=dfn%3Adrivers%2Fnfc%2Fs3fwrn5%2Fi2c.c\n\nBest regards,\nKrzysztof","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=QeUOL0We;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35142-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"QeUOL0We\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw1504zVGz1xtJ\n\tfor ; Tue, 14 Apr 2026 20:40:20 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id CECE730A5076\n\tfor ; Tue, 14 Apr 2026 10:34:35 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 1AB563D9DC2;\n\tTue, 14 Apr 2026 10:34:05 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 9289B3D6CA0;\n\tTue, 14 Apr 2026 10:34:00 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 56ED8C2BCB0;\n\tTue, 14 Apr 2026 10:33:56 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776162840; cv=none;\n b=gEQYwfo+eBFsNL+Ft56O9auMQvvZi8n5h6t7R3iIGSi6/fvVj0vUIvYsK3ZUSucEkkqHCf4ZsaDrprt34quY+C23OVfXHTudHYpIhD64rhVs0b7hen9xUW3rQCU4jG8fLKof1iOA5tH1WN+cOOyKmowoF0hJJWxbFsTCMX+GQL4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776162840; c=relaxed/simple;\n\tbh=8bYs1EDtajhxH4ZJRPhlMDdBPTiKITg4xxo54E72XFk=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=RDX5SfafEG1Aw7fnsimnhU1kcXZYOZsLDwN48WO2KcJak6qeYYr+a6VwMs1fcq9m7Pqpv+VH9LDm3ArVBhAZYwzAlp5Eh6glFKqSjt7PIvOjspgXH4ODEXtzMSazCOri4K6FgcWf03TIZnwhLQgGa11V3i+igxjJz3wiWUgDxTY=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=QeUOL0We; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776162838;\n\tbh=8bYs1EDtajhxH4ZJRPhlMDdBPTiKITg4xxo54E72XFk=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=QeUOL0WeAMaOP8Zw2Xl+hrSozJQCHEK78wAshVbuLp0Rd5R9HS6yzeyNAlhxM8Ifx\n\t r6SXiF/aAK/ShHucSUfiMw2bMY+TiLWd8gTMJTjgnEyiVoSOkZ9Ri8bVrRpJ/B/uu8\n\t 8l19yOZGreLsM4U1yEvGKhjvijNZ/0Htdm7Y4JYFKv0NAi9Z8+TTMcNQeI2Tcc7TkB\n\t Pxq9OnrsXfSKRb8uLMJT6lHioT8kuWyA+8hoplyp2VwzEJSEJkNdnVbExx6qD17ehM\n\t 6HuUoYZSsdmTcwmYR5/YbV/tXxSjR4acTvP/jJ/r/Frual4qHMK0h3LJfyXULP+XR2\n\t w4Gh6f5U2ts1Q==","Message-ID":"<449f5a8e-10d5-4fdf-86d5-e50ce017b686@kernel.org>","Date":"Tue, 14 Apr 2026 12:33:54 +0200","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] nfc: s3fwrn5: switch to GPIO descriptor API","To":"deep@crimson.net.eu.org","Cc":"Linus Walleij , Bartosz Golaszewski ,\n netdev@vger.kernel.org, linux-nfc@lists.01.org,\n linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org","References":"<20260414102257.365421-1-deep@crimson.net.eu.org>","From":"Krzysztof Kozlowski ","Content-Language":"en-US","Autocrypt":"addr=krzk@kernel.org; keydata=\n xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79\n cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu\n JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH\n gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE\n J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj\n NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS\n BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU\n vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM\n Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD\n TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg\n S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE\n FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307\n QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp\n +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl\n ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy\n 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN\n hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi\n tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL\n 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn\n naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd\n hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k\n whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3\n Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue\n MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei\n OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA\n GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA\n 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9\n YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt\n 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU\n BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/\n JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu\n 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB\n YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v\n qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5\n RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg\n Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2\n H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB\n dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT\n AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu\n jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2\n zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw\n XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A=","In-Reply-To":"<20260414102257.365421-1-deep@crimson.net.eu.org>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit"}}]