[{"id":3677105,"web_url":"http://patchwork.ozlabs.org/comment/3677105/","msgid":"<6d5cc24a-f8c6-4daa-9e27-399dbb916fac@163.com>","list_archive_url":null,"date":"2026-04-14T10:07:09","subject":"Re: [PATCH v1] ext4: add mb_stats_clear for mballoc statistics","submitter":{"id":89479,"url":"http://patchwork.ozlabs.org/api/people/89479/","name":"liubaolin","email":"liubaolin12138@163.com"},"content":"> Dear all,                                                                                                                                                                                                                           \n>   I have sent a small ext4 patch to add a manual reset capability for the mballoc statistics, and I would like to add some background on the motivation.\n> \n>   The idea came mainly from XFS stats_clear.\n>   ext4 already exports mballoc runtime statistics through /proc/fs/ext4/<dev>/mb_stats, \n>   but these counters keep accumulating from mount time, which makes it inconvenient when trying to observe allocator behavior for a single test run.\n>                                                                                    \n>   This patch adds a write-only sysfs node, /sys/fs/ext4/<dev>/mb_stats_clear, so that writing 1 to it resets the ext4 mballoc runtime statistics.\n>   It also adds sbi->s_bal_allocated to /proc/fs/ext4/<dev>/mb_stats, \n>   so that the proc output matches the mballoc summary printed at unmount time and the set of counters covered by mb_stats_clear is more complete. \n>   \n>   The main goal is to make it easier to observe allocator activity for a specific test run instead of relying on counters accumulated since mount. \n>   With this in place, the counters can be cleared before starting a test, and the resulting mb_stats output reflects only the activity generated by that test.\n>   \n>   The counters being cleared are runtime mballoc statistics used for /proc/fs/ext4/<dev>/mb_stats reporting and for the mballoc summary printed at unmount time. \n>   I did not find any cases where these fields are read back to drive ext4 behavior, so the reset only affects statistics reporting.\n> \n>   For validation, /sys/fs/ext4/<dev>/mb_stats can be enabled first, \n>   then a file operation test can be run so that the relevant values in /proc/fs/ext4/<dev>/mb_stats become non-zero. \n>   After writing 1 to /sys/fs/ext4/<dev>/mb_stats_clear, those values should return to 0. \n>   Running another file operation test afterward should make those values increase again.\n> \n>   Best regards,\n>   Baolin Liu\n\n\n\n\n\n在 2026/4/14 18:02, Baolin Liu 写道:\n> From: Baolin Liu <liubaolin@kylinos.cn>\n> \n> Add a write-only mb_stats_clear sysfs knob to reset ext4 mballoc\n> runtime statistics.This makes it easier to inspect allocator\n> activity for a specific workload instead of using counters\n> accumulated since mount.\n> \n> Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>\n> ---\n>   fs/ext4/ext4.h    |  1 +\n>   fs/ext4/mballoc.c | 31 +++++++++++++++++++++++++++++++\n>   fs/ext4/sysfs.c   | 24 ++++++++++++++++++++++++\n>   3 files changed, 56 insertions(+)\n> \n> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h\n> index 7617e2d454ea..3a32e1a515dd 100644\n> --- a/fs/ext4/ext4.h\n> +++ b/fs/ext4/ext4.h\n> @@ -2995,6 +2995,7 @@ int ext4_fc_record_regions(struct super_block *sb, int ino,\n>   extern const struct seq_operations ext4_mb_seq_groups_ops;\n>   extern const struct seq_operations ext4_mb_seq_structs_summary_ops;\n>   extern int ext4_seq_mb_stats_show(struct seq_file *seq, void *offset);\n> +extern void ext4_mb_stats_clear(struct ext4_sb_info *sbi);\n>   extern int ext4_mb_init(struct super_block *);\n>   extern void ext4_mb_release(struct super_block *);\n>   extern ext4_fsblk_t ext4_mb_new_blocks(handle_t *,\n> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c\n> index bb58eafb87bc..382c91586b26 100644\n> --- a/fs/ext4/mballoc.c\n> +++ b/fs/ext4/mballoc.c\n> @@ -3219,6 +3219,8 @@ int ext4_seq_mb_stats_show(struct seq_file *seq, void *offset)\n>   \t}\n>   \tseq_printf(seq, \"\\treqs: %u\\n\", atomic_read(&sbi->s_bal_reqs));\n>   \tseq_printf(seq, \"\\tsuccess: %u\\n\", atomic_read(&sbi->s_bal_success));\n> +\tseq_printf(seq, \"\\tblocks_allocated: %u\\n\",\n> +\t\t   atomic_read(&sbi->s_bal_allocated));\n>   \n>   \tseq_printf(seq, \"\\tgroups_scanned: %u\\n\",\n>   \t\t   atomic_read(&sbi->s_bal_groups_scanned));\n> @@ -4721,6 +4723,35 @@ static void ext4_mb_collect_stats(struct ext4_allocation_context *ac)\n>   \t\ttrace_ext4_mballoc_prealloc(ac);\n>   }\n>   \n> +void ext4_mb_stats_clear(struct ext4_sb_info *sbi)\n> +{\n> +\tint i;\n> +\n> +\tatomic_set(&sbi->s_bal_reqs, 0);\n> +\tatomic_set(&sbi->s_bal_success, 0);\n> +\tatomic_set(&sbi->s_bal_allocated, 0);\n> +\tatomic_set(&sbi->s_bal_groups_scanned, 0);\n> +\n> +\tfor (i = 0; i < EXT4_MB_NUM_CRS; i++) {\n> +\t\tatomic64_set(&sbi->s_bal_cX_hits[i], 0);\n> +\t\tatomic64_set(&sbi->s_bal_cX_groups_considered[i], 0);\n> +\t\tatomic_set(&sbi->s_bal_cX_ex_scanned[i], 0);\n> +\t\tatomic64_set(&sbi->s_bal_cX_failed[i], 0);\n> +\t}\n> +\n> +\tatomic_set(&sbi->s_bal_ex_scanned, 0);\n> +\tatomic_set(&sbi->s_bal_goals, 0);\n> +\tatomic_set(&sbi->s_bal_stream_goals, 0);\n> +\tatomic_set(&sbi->s_bal_len_goals, 0);\n> +\tatomic_set(&sbi->s_bal_2orders, 0);\n> +\tatomic_set(&sbi->s_bal_breaks, 0);\n> +\tatomic_set(&sbi->s_mb_lost_chunks, 0);\n> +\tatomic_set(&sbi->s_mb_buddies_generated, 0);\n> +\tatomic64_set(&sbi->s_mb_generation_time, 0);\n> +\tatomic_set(&sbi->s_mb_preallocated, 0);\n> +\tatomic_set(&sbi->s_mb_discarded, 0);\n> +}\n> +\n>   /*\n>    * Called on failure; free up any blocks from the inode PA for this\n>    * context.  We don't need this for MB_GROUP_PA because we only change\n> diff --git a/fs/ext4/sysfs.c b/fs/ext4/sysfs.c\n> index 923b375e017f..a5bd88a99f22 100644\n> --- a/fs/ext4/sysfs.c\n> +++ b/fs/ext4/sysfs.c\n> @@ -41,6 +41,7 @@ typedef enum {\n>   \tattr_pointer_atomic,\n>   \tattr_journal_task,\n>   \tattr_err_report_sec,\n> +\tattr_mb_stats_clear,\n>   } attr_id_t;\n>   \n>   typedef enum {\n> @@ -161,6 +162,25 @@ static ssize_t err_report_sec_store(struct ext4_sb_info *sbi,\n>   \treturn count;\n>   }\n>   \n> +static ssize_t mb_stats_clear_store(struct ext4_sb_info *sbi,\n> +\t\t\t\t    const char *buf, size_t count)\n> +{\n> +\tint val;\n> +\tint ret;\n> +\n> +\tif (!capable(CAP_SYS_ADMIN))\n> +\t\treturn -EPERM;\n> +\n> +\tret = kstrtoint(skip_spaces(buf), 0, &val);\n> +\tif (ret)\n> +\t\treturn ret;\n> +\tif (val != 1)\n> +\t\treturn -EINVAL;\n> +\n> +\text4_mb_stats_clear(sbi);\n> +\treturn count;\n> +}\n> +\n>   static ssize_t journal_task_show(struct ext4_sb_info *sbi, char *buf)\n>   {\n>   \tif (!sbi->s_journal)\n> @@ -251,6 +271,7 @@ EXT4_ATTR_OFFSET(mb_best_avail_max_trim_order, 0644, mb_order,\n>   EXT4_ATTR_OFFSET(err_report_sec, 0644, err_report_sec, ext4_sb_info, s_err_report_sec);\n>   EXT4_RW_ATTR_SBI_UI(inode_goal, s_inode_goal);\n>   EXT4_RW_ATTR_SBI_UI(mb_stats, s_mb_stats);\n> +EXT4_ATTR(mb_stats_clear, 0200, mb_stats_clear);\n>   EXT4_RW_ATTR_SBI_UI(mb_max_to_scan, s_mb_max_to_scan);\n>   EXT4_RW_ATTR_SBI_UI(mb_min_to_scan, s_mb_min_to_scan);\n>   EXT4_RW_ATTR_SBI_UI(mb_order2_req, s_mb_order2_reqs);\n> @@ -301,6 +322,7 @@ static struct attribute *ext4_attrs[] = {\n>   \tATTR_LIST(inode_readahead_blks),\n>   \tATTR_LIST(inode_goal),\n>   \tATTR_LIST(mb_stats),\n> +\tATTR_LIST(mb_stats_clear),\n>   \tATTR_LIST(mb_max_to_scan),\n>   \tATTR_LIST(mb_min_to_scan),\n>   \tATTR_LIST(mb_order2_req),\n> @@ -561,6 +583,8 @@ static ssize_t ext4_attr_store(struct kobject *kobj,\n>   \t\treturn trigger_test_error(sbi, buf, len);\n>   \tcase attr_err_report_sec:\n>   \t\treturn err_report_sec_store(sbi, buf, len);\n> +\tcase attr_mb_stats_clear:\n> +\t\treturn mb_stats_clear_store(sbi, buf, len);\n>   \tdefault:\n>   \t\treturn ext4_generic_attr_store(a, sbi, buf, len);\n>   \t}","headers":{"Return-Path":"\n <SRS0=Ry+f=CN=vger.kernel.org=linux-ext4+bounces-15830-patchwork-incoming=ozlabs.org@ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=f92Z1q+Z;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=ry+f=cn=vger.kernel.org=linux-ext4+bounces-15830-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=104.64.211.4 arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=163.com","gandalf.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=f92Z1q+Z;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15830-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=\"f92Z1q+Z\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=220.197.31.2","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=163.com"],"Received":["from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw0XX2Xgvz1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 20:15:40 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fw0XX1wtqz4wHl\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 20:15:40 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4fw0XX1Yqlz4wJ7; Tue, 14 Apr 2026 20:15:40 +1000 (AEST)","from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fw0XR4cfvz4wHl\n\tfor <patchwork-incoming@ozlabs.org>; Tue, 14 Apr 2026 20:15:35 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 86956304895A\n\tfor <patchwork-incoming@ozlabs.org>; Tue, 14 Apr 2026 10:08:58 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 25DFA3CC9FD;\n\tTue, 14 Apr 2026 10:07:45 +0000 (UTC)","from m16.mail.163.com (m16.mail.163.com [220.197.31.2])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id B3FF23CFF52;\n\tTue, 14 Apr 2026 10:07:40 +0000 (UTC)","from [192.168.117.68] (unknown [])\n\tby gzga-smtp-mtada-g0-2 (Coremail) with SMTP id\n _____wCHaz_NEd5p25gyFA--.63943S2;\n\tTue, 14 Apr 2026 18:07:17 +0800 (CST)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1776161740; cv=pass;\n\tb=ackmPzJrUbg9x1MzHMM5ofCkmE4Uoib5Yt1fFtlr+DnaWcMs/kv71kvq9YdoauNOJmANAtULfQgU6KfNctTMineEV6i5XubTGPMFPEltGChvgv+Re1jeNwb5ZD1yNRX/qDD6NjoCMr2kQe6iEqCLOQSpZGJKB2qplwRUjQTXqL1hGW7U1lNCrPL9pyqcJ0c7mwuOfpnET9GgTt9r+ggFd02Mv91pbIEr2+L+puJs5ltocJy8pKyKtt6TM2tdOTKXkKllTdEdxydK1RBqn1VLbe8Y6kZuOAYwoVMt4Wgv023KO0HxpEtwyM+vauNSkW+DdxIjX6TQfMh7ACysCWXtZQ==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776161264; cv=none;\n b=RHUQMPVWvCeEby/uJ7HC3nvuBLGf2Rf+Ghm0FeQFKU3PUIiVVeUx98iG7dzfx1cImAunxZn4hjJydHOxAoJFQ8B9ImA2Zyj0LcQs1PNAcMG4vduYK92LuqUdG59TkpJO6nU7FKZZ2sndam+Ao5ViN4RC4DsBQBgranujSybuvAg="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1776161740; c=relaxed/relaxed;\n\tbh=lup6srYEtbGICHvpjOCwe+dkqmObgV/oaPKqztT9RFA=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=deGS4bi7cbyKDPvwaJsBMyMD4auMu7rDC2aYR38tfnTRnWo+xZZ6ZlTGM+OgEzbSeX1s+QtvFPhjp3OXtV5QhpeN5snVHCWONWNlMc4s2zuKdpLErA+Bj83wGOWfU1WWa8L3c37GPNEn80g4Qc9CtKnRoGI6ktJzf88M1XHP2cLpfNFlmr3yc2uKS7cIGZB/wKgxgdqVK8/jCHyt6HL4KejygBrrTSUomXB1S6PU1wbAheWSUxTUKNmjkGvMMFn/BqqbgCKaEFRigOuXA25swV7WO5sPEe2au8w5nfQg6fk8asmxx6CsE4+H99/ipX6BlTFxxlr8vMIo2SD+qVVhOQ==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776161264; c=relaxed/simple;\n\tbh=Zn0g9IPBQL+09Gkm+uRMG6m58nNCqJy4167dncxBd5E=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=vAzKhV3zJWSY8hs+SSsGWmzUysgxtpLnFYddkG0zGSNYW1gxSQ+eTBAxip4CnpCOYnHWtz3FeeaPpG5uj+3c7mYEnQ92R3kT9wrRLznPKGq3VMWSRFXv6ntRsjmRbnJiGKOva2xSGOZx61T0c07+tDDwhbF0F+AFbEKTsQDpRaM="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=163.com; dkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=f92Z1q+Z; dkim-atps=neutral;\n spf=pass (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15830-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com;\n spf=pass smtp.mailfrom=163.com;\n dkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=f92Z1q+Z; arc=none smtp.client-ip=220.197.31.2"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n\ts=s110527; h=Message-ID:Date:MIME-Version:Subject:To:From:\n\tContent-Type; bh=lup6srYEtbGICHvpjOCwe+dkqmObgV/oaPKqztT9RFA=;\n\tb=f92Z1q+ZKzYVvP/sbM0wn5KKv1yHxxTVgHuIQb9dLqWB18YRTnV/Bc4v6CDABe\n\tOVuNGbhtTaTEQrtgwmA9K5jDwEDvqW8TtzbEPcbisDQC7uBAsAj+YQ+gNQUkJdO3\n\tkgT/J6tG90LEtUMQEIZWwjgJ8f9wTrydF1re0r1Dw8wqQ=","Message-ID":"<6d5cc24a-f8c6-4daa-9e27-399dbb916fac@163.com>","Date":"Tue, 14 Apr 2026 18:07:09 +0800","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"<linux-ext4.vger.kernel.org>","List-Subscribe":"<mailto:linux-ext4+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-ext4+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] ext4: add mb_stats_clear for mballoc statistics","To":"tytso@mit.edu, adilger.kernel@dilger.ca","Cc":"linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,\n wangguanyu@vivo.com, Baolin Liu <liubaolin@kylinos.cn>","References":"<20260414100212.95209-1-liubaolin12138@163.com>","From":"liubaolin <liubaolin12138@163.com>","In-Reply-To":"<20260414100212.95209-1-liubaolin12138@163.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-CM-TRANSID":"_____wCHaz_NEd5p25gyFA--.63943S2","X-Coremail-Antispam":"1Uf129KBjvJXoW3GFWDWr1UCw13JFy5WryDWrg_yoWxtFWUpF\n\tsxXa4UAF4UZ3Wxurs7Wa18WwnYvw40k3yUWrnIvw1F9FZIqryftFySqryjvFy5ArW8X3W8\n\tXa1Yv3yDGrWj937anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07Uza0QUUUUU=","X-CM-SenderInfo":"xolxutxrol0iasrtmqqrwthudrp/xtbC6RaLVmneEdYjDQAA38","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tFREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}},{"id":3677799,"web_url":"http://patchwork.ozlabs.org/comment/3677799/","msgid":"<ad_mguIqaOT-pEmh@li-dc0c254c-257c-11b2-a85c-98b6c1322444.ibm.com>","list_archive_url":null,"date":"2026-04-15T19:26:58","subject":"Re: [PATCH v1] ext4: add mb_stats_clear for mballoc statistics","submitter":{"id":83422,"url":"http://patchwork.ozlabs.org/api/people/83422/","name":"Ojaswin Mujoo","email":"ojaswin@linux.ibm.com"},"content":"On Tue, Apr 14, 2026 at 06:02:11PM +0800, Baolin Liu wrote:\n> From: Baolin Liu <liubaolin@kylinos.cn>\n> \n> Add a write-only mb_stats_clear sysfs knob to reset ext4 mballoc\n> runtime statistics.This makes it easier to inspect allocator\n> activity for a specific workload instead of using counters\n> accumulated since mount.\n> \n> Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>\n\nThe patch looks good to me Baolin. We just need to add documentation of\nthis to the Documentation/ABI/testing/sysfs-fs-ext4 file so that the\nusers know what it is and the fact that the only value we allow to write\nis 1. \n\nRegards,\nojaswin","headers":{"Return-Path":"\n <SRS0=SuQO=CO=vger.kernel.org=linux-ext4+bounces-15850-patchwork-incoming=ozlabs.org@ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=NTJkmXv9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=150.107.74.76; helo=mail.ozlabs.org;\n envelope-from=srs0=suqo=co=vger.kernel.org=linux-ext4+bounces-15850-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c04:e001:36c::12fc:5321\"\n arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=NTJkmXv9;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15850-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=\"NTJkmXv9\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=148.163.156.1","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.ibm.com"],"Received":["from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwrkg6mS9z1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 05:27:23 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fwrkg08j0z4wSY\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 05:27:23 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4fwrkg03HFz4x0R; Thu, 16 Apr 2026 05:27:23 +1000 (AEST)","from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fwrkb3KBXz4wSY\n\tfor <patchwork-incoming@ozlabs.org>; Thu, 16 Apr 2026 05:27:19 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 75A00301CC6D\n\tfor <patchwork-incoming@ozlabs.org>; Wed, 15 Apr 2026 19:27:17 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id EC000384248;\n\tWed, 15 Apr 2026 19:27:15 +0000 (UTC)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A70B83624C5;\n\tWed, 15 Apr 2026 19:27:14 +0000 (UTC)","from pps.filterd (m0360083.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63FGSEjh2130606;\n\tWed, 15 Apr 2026 19:27:07 GMT","from ppma23.wdc07v.mail.ibm.com\n (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dh89nhyk4-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tWed, 15 Apr 2026 19:27:07 +0000 (GMT)","from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])\n\tby ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 63FHQ0A5004180;\n\tWed, 15 Apr 2026 19:27:05 GMT","from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226])\n\tby ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dg24kfngx-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tWed, 15 Apr 2026 19:27:05 +0000","from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com\n [10.20.54.101])\n\tby smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63FJR3G353543168\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tWed, 15 Apr 2026 19:27:03 GMT","from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id C523D20043;\n\tWed, 15 Apr 2026 19:27:03 +0000 (GMT)","from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id D1F3320040;\n\tWed, 15 Apr 2026 19:27:01 +0000 (GMT)","from li-dc0c254c-257c-11b2-a85c-98b6c1322444.ibm.com (unknown\n [9.39.25.126])\n\tby smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS;\n\tWed, 15 Apr 2026 19:27:01 +0000 (GMT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1776281242; cv=pass;\n\tb=uzyR5yJJZcV8YPrMFtnFR4OlrLU/8AB+Z+8ddd/DGVSVBjUnxMl9c+GL0BzT7iHmJhmWcLXF0DPASPemVDqsd1XFie2f/8HeZ/0yw2ebiz8a3q2+kLudiZtP3C4EGvJweHqppPcRyB+8lBHtFueD3urTO7GdjRlywAxB6mOmvpg4k4nIBzERMqpTH/gQuNjL8ekMq7fmofUAd2JP79IQoCwODBiS4AOfgWIsX/PkQ1eqMc52Ev1ppmzzI+a6qW9dqC83tAqoehuHY5lv3GvD8zzJl3kQgYjhe1yutxlk5YxcM5CdipPddtq6XnwUoYYn2vtoide7JzTRZUMsLqD58Q==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776281235; cv=none;\n b=mNozs/qb7GUDoUJbCfdrPrIwcWQt5QoalVWYf9DVkVKm6ooQrf27VQas+SHl7sSgiEbT6oyllC4FY4I/Oy8na4/TTU31WeIC9RYpJOxBxnri5RoQlThcjXuvtyoWpr0NnGaUnZFrFnCSnHsdlmXjqzMpySF5zi+WDIIBuNEBqIU="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1776281242; c=relaxed/relaxed;\n\tbh=pD2x7FXOAxiphqSY+v80d5AjwEMu7EDZZfNdxbrxpQg=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=WC+dHZ6wHUjolBdXe9Q9y/n9vSkdJ0wJo5JQuyhlZvDed3Op4V/Dsl+DrmKrXEMlwrsOBKbpLaMvMeQVBSgUx58Zw3kQVrdJlZXhiWZTkrSRPCyru+PpBvMzu6sysM4mOp+fF7hiUAqqiG/XnjlOiRfENJGaTpjZGG0mr5Tn/1qyLBwst/A9gNGOhOZ8emNfhKaWrZ5/GuCPuLKxfStx9SJHWhm/dMMZn/23xy5R/qeuh2D7VdJPBgncdv6YXiek/ahLbLtmY1hdas80HeO9SNM0++vLiMrVmqOOhXN416zFrbVv7+yUGt2G8NkIDXfKv8rOhsdmZwMHzmDg1UbrPw==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776281235; c=relaxed/simple;\n\tbh=Z3Qm2qGbMju+0Js4ijjp8rqnx80EzyxC7cBFc2dicfE=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=tZx1MuH2mGb2UzNzQNfbo8H+fJArY0xobxfFw7Ki8y7SDBXivg7RdAWqz3l07TWkgSvd9Bzk33GS8J6BX7PHOM/m7lC//LE/Ky4qFFiyqZsthJrwJQ224BG8rEZYRTl34A2C3pHTFy2tRC1oUBs0139IV1OH2zayFWXNlTR4f2o="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=NTJkmXv9; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15850-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n spf=pass smtp.mailfrom=linux.ibm.com;\n dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=NTJkmXv9; arc=none smtp.client-ip=148.163.156.1"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-type:date:from:in-reply-to:message-id:mime-version\n\t:references:subject:to; s=pp1; bh=pD2x7FXOAxiphqSY+v80d5AjwEMu7E\n\tDZZfNdxbrxpQg=; b=NTJkmXv9Gtbtbuld0aUR0LOeGkXec9oyRWqqcZDmil4oJR\n\t6cpOs80dzYfbuKDqWlWvqBVHBwb89pJOw5Bpkt4R0R7GYl94WMp0fo9z3efmeyuq\n\t/JhhUlJWglOXbjN0I7fcI9P0UX8cMYSroN9eUj9S9Aggb916OdwchrAwkfe7XZk9\n\tDJ+34ZTJtkjcSdKOYlZ5VKu2HWIMAnngWEi7FeS6C23zMsb8iYSK7tAqAyST7HHo\n\tG7/6Zc47MR6aHcy1DNjMcS55KDkU0ra2JweEK5IQ98hNPTiwKv316Yom903eBEf4\n\t0LbwLHyt0yzW4dGzKiPv5JXzPMsD0uxn2lQucXHQ==","Date":"Thu, 16 Apr 2026 00:56:58 +0530","From":"Ojaswin Mujoo <ojaswin@linux.ibm.com>","To":"Baolin Liu <liubaolin12138@163.com>","Cc":"tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,\n        linux-kernel@vger.kernel.org, wangguanyu@vivo.com,\n        Baolin Liu <liubaolin@kylinos.cn>","Subject":"Re: [PATCH v1] ext4: add mb_stats_clear for mballoc statistics","Message-ID":"<ad_mguIqaOT-pEmh@li-dc0c254c-257c-11b2-a85c-98b6c1322444.ibm.com>","References":"<20260414100212.95209-1-liubaolin12138@163.com>","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"<linux-ext4.vger.kernel.org>","List-Subscribe":"<mailto:linux-ext4+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-ext4+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260414100212.95209-1-liubaolin12138@163.com>","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Proofpoint-GUID":"ix5iUEyB-wPr_UgVJeh11OHM2xRKuNql","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDE1MDE4MCBTYWx0ZWRfX8suWA81L5td0\n 2zCNQo5IsIkOLhxo7ec7bnh6ysEelF4mtIcJ/YwxXSQlkGxuSVZVK2PNF7TJ2SN1yurU1USzKAl\n T7NNngczUKntqFBNGXIUVO15sVmSnvnOS1EskQlpxuZQdy8Xf+qqSUhSNgdTwzl3BlwRjBE6Cjr\n I8uvgnuuVhpIZv0144XPZn6TIxANTBmRSLinRd6L7kOAEl4lFioyxSLrhJbBZS77HWDp75L2UvQ\n j4YAbLVNK7b6hDbalTmas3E6Q1urlIOqA4iN0XTx3xi5a3hyCco8l67jNTOP9ACL3/dmVEjLX+6\n 7BmWUwe2Jbra9j/UTQivtCfCIWXz4+c7Jm9WAUJNOLZbTWQw6G1uk8Kl5NytcuA6+OdQXxarZKn\n INpMn46PJRWIh4X68jv8BBslgdlYlpjSMpKR9KiXj02ISIGl6Ks+RYadThPSS+lBEjllUAbkcp+\n Uv0QPsEoOsGCs3U6Zcg==","X-Proofpoint-ORIG-GUID":"XrqOsl1uQFRV9dDDYmaToKkNXeqqTSOp","X-Authority-Analysis":"v=2.4 cv=FY4HAp+6 c=1 sm=1 tr=0 ts=69dfe68b cx=c_pps\n a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17\n a=kj9zAlcOel0A:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=KrRLzkSUTx881rGj9LEA:9\n a=CjuIK1q_8ugA:10","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-15_01,2026-04-13_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n adultscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 spamscore=0\n lowpriorityscore=0 suspectscore=0 clxscore=1011 malwarescore=0 phishscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604150180","X-Spam-Status":"No, score=-1.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DMARC_PASS,HEADER_FROM_DIFFERENT_DOMAINS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}},{"id":3677887,"web_url":"http://patchwork.ozlabs.org/comment/3677887/","msgid":"<C713AA9C-D640-4C5B-98BF-A5D88AE3B2A0@dilger.ca>","list_archive_url":null,"date":"2026-04-16T01:14:38","subject":"Re: [PATCH v1] ext4: add mb_stats_clear for mballoc statistics","submitter":{"id":4514,"url":"http://patchwork.ozlabs.org/api/people/4514/","name":"Andreas Dilger","email":"adilger@dilger.ca"},"content":"On Apr 14, 2026, at 04:02, Baolin Liu <liubaolin12138@163.com> wrote:\n> \n> From: Baolin Liu <liubaolin@kylinos.cn>\n> \n> Add a write-only mb_stats_clear sysfs knob to reset ext4 mballoc\n> runtime statistics. This makes it easier to inspect allocator\n> activity for a specific workload instead of using counters\n> accumulated since mount.\n\nRather than having a read-only \"mb_stats\" procfs file and a separate\nwrite-only \"mb_stats_clear\" sysfs file to clear \"mb_stats\", IMHO it\nwould be more obvious to write directly to \"/proc/fs/ext4/DEV/mb_stats\"\nfile to clear it.  Writing \"0\" would be logical to zero out the stats.\n\nCheers, Andreas\n\n> \n> Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>\n> ---\n> fs/ext4/ext4.h    |  1 +\n> fs/ext4/mballoc.c | 31 +++++++++++++++++++++++++++++++\n> fs/ext4/sysfs.c   | 24 ++++++++++++++++++++++++\n> 3 files changed, 56 insertions(+)\n> \n> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h\n> index 7617e2d454ea..3a32e1a515dd 100644\n> --- a/fs/ext4/ext4.h\n> +++ b/fs/ext4/ext4.h\n> @@ -2995,6 +2995,7 @@ int ext4_fc_record_regions(struct super_block *sb, int ino,\n> extern const struct seq_operations ext4_mb_seq_groups_ops;\n> extern const struct seq_operations ext4_mb_seq_structs_summary_ops;\n> extern int ext4_seq_mb_stats_show(struct seq_file *seq, void *offset);\n> +extern void ext4_mb_stats_clear(struct ext4_sb_info *sbi);\n> extern int ext4_mb_init(struct super_block *);\n> extern void ext4_mb_release(struct super_block *);\n> extern ext4_fsblk_t ext4_mb_new_blocks(handle_t *,\n> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c\n> index bb58eafb87bc..382c91586b26 100644\n> --- a/fs/ext4/mballoc.c\n> +++ b/fs/ext4/mballoc.c\n> @@ -3219,6 +3219,8 @@ int ext4_seq_mb_stats_show(struct seq_file *seq, void *offset)\n> }\n> seq_printf(seq, \"\\treqs: %u\\n\", atomic_read(&sbi->s_bal_reqs));\n> seq_printf(seq, \"\\tsuccess: %u\\n\", atomic_read(&sbi->s_bal_success));\n> + seq_printf(seq, \"\\tblocks_allocated: %u\\n\",\n> +   atomic_read(&sbi->s_bal_allocated));\n> \n> seq_printf(seq, \"\\tgroups_scanned: %u\\n\",\n>   atomic_read(&sbi->s_bal_groups_scanned));\n> @@ -4721,6 +4723,35 @@ static void ext4_mb_collect_stats(struct ext4_allocation_context *ac)\n> trace_ext4_mballoc_prealloc(ac);\n> }\n> \n> +void ext4_mb_stats_clear(struct ext4_sb_info *sbi)\n> +{\n> + int i;\n> +\n> + atomic_set(&sbi->s_bal_reqs, 0);\n> + atomic_set(&sbi->s_bal_success, 0);\n> + atomic_set(&sbi->s_bal_allocated, 0);\n> + atomic_set(&sbi->s_bal_groups_scanned, 0);\n> +\n> + for (i = 0; i < EXT4_MB_NUM_CRS; i++) {\n> + atomic64_set(&sbi->s_bal_cX_hits[i], 0);\n> + atomic64_set(&sbi->s_bal_cX_groups_considered[i], 0);\n> + atomic_set(&sbi->s_bal_cX_ex_scanned[i], 0);\n> + atomic64_set(&sbi->s_bal_cX_failed[i], 0);\n> + }\n> +\n> + atomic_set(&sbi->s_bal_ex_scanned, 0);\n> + atomic_set(&sbi->s_bal_goals, 0);\n> + atomic_set(&sbi->s_bal_stream_goals, 0);\n> + atomic_set(&sbi->s_bal_len_goals, 0);\n> + atomic_set(&sbi->s_bal_2orders, 0);\n> + atomic_set(&sbi->s_bal_breaks, 0);\n> + atomic_set(&sbi->s_mb_lost_chunks, 0);\n> + atomic_set(&sbi->s_mb_buddies_generated, 0);\n> + atomic64_set(&sbi->s_mb_generation_time, 0);\n> + atomic_set(&sbi->s_mb_preallocated, 0);\n> + atomic_set(&sbi->s_mb_discarded, 0);\n> +}\n> +\n> /*\n>  * Called on failure; free up any blocks from the inode PA for this\n>  * context.  We don't need this for MB_GROUP_PA because we only change\n> diff --git a/fs/ext4/sysfs.c b/fs/ext4/sysfs.c\n> index 923b375e017f..a5bd88a99f22 100644\n> --- a/fs/ext4/sysfs.c\n> +++ b/fs/ext4/sysfs.c\n> @@ -41,6 +41,7 @@ typedef enum {\n> attr_pointer_atomic,\n> attr_journal_task,\n> attr_err_report_sec,\n> + attr_mb_stats_clear,\n> } attr_id_t;\n> \n> typedef enum {\n> @@ -161,6 +162,25 @@ static ssize_t err_report_sec_store(struct ext4_sb_info *sbi,\n> return count;\n> }\n> \n> +static ssize_t mb_stats_clear_store(struct ext4_sb_info *sbi,\n> +    const char *buf, size_t count)\n> +{\n> + int val;\n> + int ret;\n> +\n> + if (!capable(CAP_SYS_ADMIN))\n> + return -EPERM;\n> +\n> + ret = kstrtoint(skip_spaces(buf), 0, &val);\n> + if (ret)\n> + return ret;\n> + if (val != 1)\n> + return -EINVAL;\n> +\n> + ext4_mb_stats_clear(sbi);\n> + return count;\n> +}\n> +\n> static ssize_t journal_task_show(struct ext4_sb_info *sbi, char *buf)\n> {\n> if (!sbi->s_journal)\n> @@ -251,6 +271,7 @@ EXT4_ATTR_OFFSET(mb_best_avail_max_trim_order, 0644, mb_order,\n> EXT4_ATTR_OFFSET(err_report_sec, 0644, err_report_sec, ext4_sb_info, s_err_report_sec);\n> EXT4_RW_ATTR_SBI_UI(inode_goal, s_inode_goal);\n> EXT4_RW_ATTR_SBI_UI(mb_stats, s_mb_stats);\n> +EXT4_ATTR(mb_stats_clear, 0200, mb_stats_clear);\n> EXT4_RW_ATTR_SBI_UI(mb_max_to_scan, s_mb_max_to_scan);\n> EXT4_RW_ATTR_SBI_UI(mb_min_to_scan, s_mb_min_to_scan);\n> EXT4_RW_ATTR_SBI_UI(mb_order2_req, s_mb_order2_reqs);\n> @@ -301,6 +322,7 @@ static struct attribute *ext4_attrs[] = {\n> ATTR_LIST(inode_readahead_blks),\n> ATTR_LIST(inode_goal),\n> ATTR_LIST(mb_stats),\n> + ATTR_LIST(mb_stats_clear),\n> ATTR_LIST(mb_max_to_scan),\n> ATTR_LIST(mb_min_to_scan),\n> ATTR_LIST(mb_order2_req),\n> @@ -561,6 +583,8 @@ static ssize_t ext4_attr_store(struct kobject *kobj,\n> return trigger_test_error(sbi, buf, len);\n> case attr_err_report_sec:\n> return err_report_sec_store(sbi, buf, len);\n> + case attr_mb_stats_clear:\n> + return mb_stats_clear_store(sbi, buf, len);\n> default:\n> return ext4_generic_attr_store(a, sbi, buf, len);\n> }\n> -- \n> 2.51.0\n> \n\n\nCheers, Andreas","headers":{"Return-Path":"\n <SRS0=5VpQ=CP=vger.kernel.org=linux-ext4+bounces-15852-patchwork-incoming=ozlabs.org@ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=dilger-ca.20251104.gappssmtp.com\n header.i=@dilger-ca.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=PyNJc5+S;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=5vpq=cp=vger.kernel.org=linux-ext4+bounces-15852-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=172.234.253.10 arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=dilger.ca","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=dilger-ca.20251104.gappssmtp.com\n header.i=@dilger-ca.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=PyNJc5+S;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15852-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=dilger-ca.20251104.gappssmtp.com\n header.i=@dilger-ca.20251104.gappssmtp.com header.b=\"PyNJc5+S\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.216.45","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=dilger.ca","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=dilger.ca"],"Received":["from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx0Ry4lLnz1yG9\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 11:15:10 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fx0Rr6vXFz4wTJ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 11:15:04 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4fx0Rr6fyDz4wJc; Thu, 16 Apr 2026 11:15:04 +1000 (AEST)","from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fx0Rn44TVz4wTJ\n\tfor <patchwork-incoming@ozlabs.org>; Thu, 16 Apr 2026 11:15:01 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 560CA3017242\n\tfor <patchwork-incoming@ozlabs.org>; Thu, 16 Apr 2026 01:14:54 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id C71251FBEA6;\n\tThu, 16 Apr 2026 01:14:52 +0000 (UTC)","from mail-pj1-f45.google.com (mail-pj1-f45.google.com\n [209.85.216.45])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id DF1551E9B3A\n\tfor <linux-ext4@vger.kernel.org>; Thu, 16 Apr 2026 01:14:50 +0000 (UTC)","by mail-pj1-f45.google.com with SMTP id\n 98e67ed59e1d1-35fb16e56efso2800566a91.2\n        for <linux-ext4@vger.kernel.org>;\n Wed, 15 Apr 2026 18:14:50 -0700 (PDT)","from smtpclient.apple (S01068c763f81ca4b.cg.shawcable.net.\n [70.77.200.158])\n        by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-36132c87817sm315519a91.2.2026.04.15.18.14.48\n        (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n        Wed, 15 Apr 2026 18:14:49 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1776302104; cv=pass;\n\tb=suTiW8UKWTwtypYLA1YBgDOp4O2H5Hppu5W+JAwawtlax00Evsso/u37kUkJcRm5gANnam+syzo5KngGev1XzzC6Y1rbK1OGzJZSWpopmpAZa9bQE+5hDKBy1EOl/TxXm5FMKkhwBKC85aHwqPGUwMNHDZAEA9GVRYSFQcwxQRJYSBJGr3V0/9hcXr9rP2/GXZr6/O1IbnJaJcRMnucuDCegPpa2vr3zD/xsBBKr6ZJP9Z8Yb4fmKL8+Y1PXlb+6EOO45CTDhGDXS/yoE8XNeINKq9uMCrQxRpQqfMYvMFFtmZn2xTZyNWPXg7sdaRLC/7j3DQa8Al1xAHhFJ1ochw==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776302092; cv=none;\n b=ak4vwsBboZmk3CdEeJ7lumD4cH7pIsQdu8+ScrLPzyPJf/r93vt3/Vp3rrxhda6F6iw9vjDNvpQCOXhESmqKyH7DZq0PVgxgJ+h5Iad3Q1nEt8AvXuk4Hui9G2SUl1wXVHKQNVfPqR5ytcBKPIPRFBI1wtkjQFpEK1TUh4zkZvU="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1776302104; c=relaxed/relaxed;\n\tbh=DtlTlsL6YYv4uiMFp8lCnKNg84sZfclP/UVzyqD0g5k=;\n\th=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:\n\t Message-Id:References:To;\n b=HeFM30iAbACF1pJWZfXrewz98wWRu2kmGSbgBynPsSNFGT3DJUFcnD5Fo5M9/tgL8u7w3oh8tnF68NSytN0Bu7LvrizzbvHtCEeL+LyApcNKpVRUfAJI/MkQDqx3dODsXxrcXnBL+63fqx+Eyw7LbIT1Pph14r+sowW8UGSrY8TvJ+RF2ayVx2f4xaNfOGI8KXcqV6vDq5EwGyqF4h6veSKBzzA1xvazeEy2chmRESPIBKoaFvBOkhAm+ijyvntjq3VXde1zBj2t47pDagSIEsuBJiYHuchI+bfJ+m0lWWPwW9ccsOUlLwUrt/HXjuzoMsD4cLpAwgTJpu6C0JtVjg==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776302092; c=relaxed/simple;\n\tbh=7nO/2Avl3a4tzNRmx1loA/73W4Xv1tpW8HPuY+vGN2s=;\n\th=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:\n\t Message-Id:References:To;\n b=qT+8XB5bA6wMnChbfKM/iWny172QybBvXfBxtsZoeXUVkEZGA/4oRelHIgYofKedOU1h6J8hL+C3FXDO/UprucOSiyLeYwvPe307sMDU3uvHc+SD9nZ606wIeSOZfOf2keDOs9bPhsyCPUpj9WkvnvnTKdTvlz3L4hjCjHw6eZw="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=dilger.ca; dkim=pass (2048-bit key;\n unprotected) header.d=dilger-ca.20251104.gappssmtp.com\n header.i=@dilger-ca.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=PyNJc5+S; dkim-atps=neutral;\n spf=pass (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15852-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=dilger.ca;\n spf=pass smtp.mailfrom=dilger.ca;\n dkim=pass (2048-bit key) header.d=dilger-ca.20251104.gappssmtp.com\n header.i=@dilger-ca.20251104.gappssmtp.com header.b=PyNJc5+S;\n arc=none smtp.client-ip=209.85.216.45"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=dilger-ca.20251104.gappssmtp.com; s=20251104; t=1776302090;\n x=1776906890; darn=vger.kernel.org;\n        h=to:references:message-id:content-transfer-encoding:cc:date\n         :in-reply-to:from:subject:mime-version:from:to:cc:subject:date\n         :message-id:reply-to;\n        bh=DtlTlsL6YYv4uiMFp8lCnKNg84sZfclP/UVzyqD0g5k=;\n        b=PyNJc5+SyuEIPCw7hhVQbdU4FcJGlGILgNDDGMucuBDcdTvXW70pDwoy9vjVmnmcnV\n         bzorNxZs67YKBedAe1dMdaGR+v4KXUiEuaJTt3jnZmGsmhe8Aebbk9NfzvcA5Rm+j38k\n         7VBCeUXXCUk3C3BYS4usam9Ngi77uvAtn9P19Tv3H1bjOW8t59ORqEgHB9suUWetiRvV\n         8+4l2SdVcXZE9e8DvYVjlNFw9RQCUwXEjq8O4GdmlmjFinT3pwIkgqD+cye7n2J3Aq2N\n         X7uZ+EfbwHPukHG1BAlHxlPqdWZmlJElxkvWVLCNEFqDqctmotdBiOQL51CvZ4hXdtVE\n         OLsQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1776302090; x=1776906890;\n        h=to:references:message-id:content-transfer-encoding:cc:date\n         :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state\n         :from:to:cc:subject:date:message-id:reply-to;\n        bh=DtlTlsL6YYv4uiMFp8lCnKNg84sZfclP/UVzyqD0g5k=;\n        b=EFq5bSYA+1VIte7RF9DxHvhD/T1nGMzw8nXrVQeA7Rigkqok6CNl1oD+J880JxyaCl\n         XZPpVhvZgtHNP06vWy3W1XpaJiuLTj64Fz8d9EW+kO+QGYnjaRsR41S2pA05XFfk28zy\n         2CCgyUMzglvF5T/yD8KPAoiq0kTqwB8+i4C3FnkCx3Ne1fOUrD3pPoUQ8MR8KrAACfNE\n         5+cDWUJxw1U9cw+yK6A7euMbwUZrRglbYHLJqG8xjgDhwn13uFo3yAeaxTcat9dJQLn1\n         eDwOiCq+blN3b8LM8ibaZjWr5CWP677pHyyUDeynqXjWOHQVetyLhetXEQwxAW5Suwbn\n         9Ngw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9/4MLt3OxRXQSZ0smJZ/UkvFVcq8AdJZVs+fRPHqV9ZpB2YtvJTzbT2BulITdzebS3NvNoNAXO1GfH@vger.kernel.org","X-Gm-Message-State":"AOJu0Yzz1sECEeGYLTVUi9ZBzKtonqIsFpi7yzdyTZxv+SPd+Y+hQ+7T\n\tJj0i7sV7LF7axUH5Y4CD9isK1//Pbkb8Bq35fauTT5qdks9svSHRVEAP83F1o5QRNhqAVPshdNm\n\tbVJMZsOg=","X-Gm-Gg":"AeBDieu51E56nD5V5BoeiTI8PShCFxxSIc/aQn/bF8/xcVni8opEt7E+abbLeLUXeR6\n\t3ghL04XejkUi5PzHbn2YjbwLM2qI3lK1pXPtrPQKlYtsL8EXP5jpyreVz27Ck/I2sOI4Gzp3GAa\n\tkk7X8ymJD3jR8hJMMzDd7+rfCWhUQl/sGamA7VywXLv3106G4ElfmGKbnWKPqH8gux7FQ3MWek4\n\teDJAe0JYuk4/AVTpZ5QF2N7FQxKgtA2x9/TJLNK9Z5mZEijMVALy0GQLWu5Ol+bnhh5BxvZJ/4Z\n\tb0hcvVeLLVsddcwsnr7cBizqL4b5V1qm1zFcZPWGcHkrNYKF0i6YlATJn63J7VlvhYCysfS8EAD\n\t5aHdI//ppcWFm2IdIbPeJ5DFUygc3PJ11hhceE9XNoynyVyGK6tk/1QLMyIIuFRFVb3EUbDuR3i\n\txwBuFo81SaHR9SCDd/8GnSV/rYTGcLL/NX6nkoe0+W2ykAoF35wviZEHphITSX3mQPISY07xJ1x\n\t9rtSLkWWa80XyOPuQ==","X-Received":"by 2002:a17:90b:2e0c:b0:35f:c729:de9b with SMTP id\n 98e67ed59e1d1-35fc729e0ffmr7982616a91.20.1776302090036;\n        Wed, 15 Apr 2026 18:14:50 -0700 (PDT)","Content-Type":"text/plain;\n\tcharset=us-ascii","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"<linux-ext4.vger.kernel.org>","List-Subscribe":"<mailto:linux-ext4+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-ext4+unsubscribe@vger.kernel.org>","Mime-Version":"1.0 (Mac OS X Mail 16.0 \\(3864.100.1.1.5\\))","Subject":"Re: [PATCH v1] ext4: add mb_stats_clear for mballoc statistics","From":"Andreas Dilger <adilger@dilger.ca>","In-Reply-To":"<20260414100212.95209-1-liubaolin12138@163.com>","Date":"Wed, 15 Apr 2026 19:14:38 -0600","Cc":"tytso@mit.edu,\n linux-ext4@vger.kernel.org,\n linux-kernel@vger.kernel.org,\n wangguanyu@vivo.com,\n Baolin Liu <liubaolin@kylinos.cn>","Content-Transfer-Encoding":"quoted-printable","Message-Id":"<C713AA9C-D640-4C5B-98BF-A5D88AE3B2A0@dilger.ca>","References":"<20260414100212.95209-1-liubaolin12138@163.com>","To":"Baolin Liu <liubaolin12138@163.com>","X-Mailer":"Apple Mail (2.3864.100.1.1.5)","X-Spam-Status":"No, score=-1.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DMARC_MISSING,HEADER_FROM_DIFFERENT_DOMAINS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}},{"id":3677900,"web_url":"http://patchwork.ozlabs.org/comment/3677900/","msgid":"<mrz3u1a4.ritesh.list@gmail.com>","list_archive_url":null,"date":"2026-04-16T01:44:35","subject":"Re: [PATCH v1] ext4: add mb_stats_clear for mballoc statistics","submitter":{"id":79126,"url":"http://patchwork.ozlabs.org/api/people/79126/","name":"Ritesh Harjani (IBM)","email":"ritesh.list@gmail.com"},"content":"Baolin Liu <liubaolin12138@163.com> writes:\n\n> From: Baolin Liu <liubaolin@kylinos.cn>\n>\n> Add a write-only mb_stats_clear sysfs knob to reset ext4 mballoc\n> runtime statistics.This makes it easier to inspect allocator\n> activity for a specific workload instead of using counters\n> accumulated since mount.\n>\n> Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>\n\nMake sense to me. The changes looks good and works fine at my end.\nSo please feel free to add:\n\nReviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>","headers":{"Return-Path":"\n <SRS0=6+1s=CP=vger.kernel.org=linux-ext4+bounces-15854-patchwork-incoming=ozlabs.org@ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=RXwyiKYz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=6+1s=cp=vger.kernel.org=linux-ext4+bounces-15854-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c09:e001:a7::12fc:5321\"\n arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=RXwyiKYz;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15854-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"RXwyiKYz\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.210.170","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx19G47Cnz1yG9\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 11:47:30 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fx19G3gRYz4wTr\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 11:47:30 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4fx19G3csYz4wTk; Thu, 16 Apr 2026 11:47:30 +1000 (AEST)","from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fx19B6p2xz4wTs\n\tfor <patchwork-incoming@ozlabs.org>; Thu, 16 Apr 2026 11:47:26 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 6B597301F3DB\n\tfor <patchwork-incoming@ozlabs.org>; Thu, 16 Apr 2026 01:47:24 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 05A8C19E98D;\n\tThu, 16 Apr 2026 01:47:23 +0000 (UTC)","from mail-pf1-f170.google.com (mail-pf1-f170.google.com\n [209.85.210.170])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B27F34CDD\n\tfor <linux-ext4@vger.kernel.org>; Thu, 16 Apr 2026 01:47:20 +0000 (UTC)","by mail-pf1-f170.google.com with SMTP id\n d2e1a72fcca58-827270d50d4so6558757b3a.3\n        for <linux-ext4@vger.kernel.org>;\n Wed, 15 Apr 2026 18:47:20 -0700 (PDT)","from pve-server ([49.205.216.49])\n        by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82f6702f936sm3328250b3a.6.2026.04.15.18.47.16\n        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n        Wed, 15 Apr 2026 18:47:19 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1776304050; cv=pass;\n\tb=F+qrOvyPbUra+DP6EjxFeAsKw0Y6UkRIV6AqIc5fhzeZ7cwomLBkm6AdlFMl+MKhhOStsfIRp0ovdNN7al56y+9o2MR9EwXCLy60J4WgKZPk9pnmFyTjjsxXlGKxic4pmUy4szaDWrugercHaSWeK75tMBPGmRB7Dp1ejkfrobkfNImeRTnoKGwmHNYCEAiWC4Ie50j6l3QGbxniKFloreKWPmxQJ4E8Z+aV4VpgtPwhTNXnS05WnNuj8SZ7W2NUFOkg/Wckw6iqBCqc8/MchBTMoO6rxrW55tsvs9+FYYm+4saR5sJPxG/KZYOeBCxUIZVfFkaY6svD9g94FmZItw==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776304042; cv=none;\n b=kIlaL+e7zxNF4/lOqPVSm7rLPPSGg5UhnZPdWYvpploDuDyK0z9wFs5+bSjYdYulUUTE1pTzTQIvpHs4tP88LS2qos1Nr9DPqLkRtQ+oDCJojWsqP2RvSsreXxige+D1m1lY/1CXhH3gZq64w+q2olmt39JBkVqGa36FThkGGLM="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1776304050; c=relaxed/relaxed;\n\tbh=vTHWwUsHvnRBDOyumFAan44av2HSR/hlYH0i1THVPHs=;\n\th=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References;\n b=JpQhHWAbFLEo99SFf+oONHvPXhfFfQDbjZZLvaKIc60LNlywFo4HgyWYOWIjETaJB+O9ki24IBC+YxBZd3ggrjOYXnkt7xn7yRKd4hiMCsbzPzr/SxAbsErmauq7agLt0CG+Z36QJ/9e1ZxrezMTkdOCWlZ3++y/SNsr+nh9PZL5i1VO7GRzT/ueWC8HYZsHD5Re3KKGH4lCmMgvGzsRCJiHxxEwseRoZLwUTOHd8qD0WNgoJe6Uy+NzYfVUG9VVBnfry0+hUi8NRWIt88hTLve6Q/tuQFNN7HebcrMCXQzs85JtaaY43g8Imm0xmj/gXFmSsyj0AiLizaARqsNcfw==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776304042; c=relaxed/simple;\n\tbh=vTHWwUsHvnRBDOyumFAan44av2HSR/hlYH0i1THVPHs=;\n\th=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References;\n b=Uq9zT9ohbKE6GmUv+KOJguC+hqQNstZE9R9MjQDObthvhX+dAdPhhJX7tYIbS5I3Cu90KZlWpBTYdDt8vR3cldmxfZgZjH/zjeL2mZkr1DvtYWGp8dHF3VT7Xgvu8cLgAegJvrXxmz8k28aMytFiKD9h0c10XmrXCFqgZQUrQxw="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=RXwyiKYz; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15854-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=RXwyiKYz; arc=none smtp.client-ip=209.85.210.170"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=gmail.com; s=20251104; t=1776304040; x=1776908840;\n darn=vger.kernel.org;\n        h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to\n         :cc:subject:date:message-id:reply-to;\n        bh=vTHWwUsHvnRBDOyumFAan44av2HSR/hlYH0i1THVPHs=;\n        b=RXwyiKYzWn3OTKXhOHcjZBvslDMkVsmWFb5gXwz+sYYlYbQEoqkkO8y2y1wDfKdz5Z\n         kB+pAMHwHtgDEFCa0qjo8xjyT0DQNbnXXAxcFEOAdTCDtXMwchzRIBivxeGJH4nVNYRI\n         gSiN1WmLhLeGb7F9E3BW4DwwERJBn9n5YjniMI118TXg9PP9oExwDA4Aayu6fkKc6/Mt\n         ZGN+CkhY6ZxYMTxTIAGS9gUsoSDXjPIg0r5H9MlQZhQG03gsMnG7r4Qf0cTvz3gA3O09\n         jGIP2R/9iVQJz2G41ZRDR3cQJtzD/t1zwuvEsX5bSkJi64HrcrOm2hKYBFtbr8MaAXeL\n         W7XQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1776304040; x=1776908840;\n        h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg\n         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n        bh=vTHWwUsHvnRBDOyumFAan44av2HSR/hlYH0i1THVPHs=;\n        b=I8ftS+Z6DXseX1vzYtJi6eNX8XWD+UaDcue5CVEN7HRiseTOGMegCpIl4tWP+KzqMI\n         HKUrWTCYdzULpym9HEy9RzVskkQxBozNHF8afK1K7xy5r8oXSGOoJTlE6W6eugLlh/po\n         W3Ke7uuJcKX7cG7KC2cfiKL2BTOrQzBuvaRGklUjdnh6rMHY8oicHh075EIFcs10GNea\n         iCR8kGSuPaBjGn9FLUGV54MiJd+UJpmkokJ91b+feO0KMYqcFy+RPJs7QHMdUt1C8pyd\n         ke4uxBGXxAzAtU7tv5csImk0CM6LNd0jRMOOadetars54VYtJsm8zoK6JbCUe9g0I3gI\n         9rgQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ93jJDFMTvEDVNtjJXT5vh6eggYaVG/fXzGr8lifpKYbd3uGkgVPyN48ltiCrDjD39LnwFFOVqwdmXh@vger.kernel.org","X-Gm-Message-State":"AOJu0Yy30k+iRVWV7GYmhacNsd73turpUpNFSA2H753Hn0mLw2yM0grk\n\tGnZamnYdUOHJOM3FMKudHlBnENSrJcah2ggwvJa1e90CnD707YR6FBbJihaJaA==","X-Gm-Gg":"AeBDiet+dtSnMx40sbjr2XdIxgzY+hVBfttQVwAvNad0nz7GTFoOVwCxIiwfRLvJfqw\n\t6P6pU+yqYEQPMQ/3P+YCZOlEB7hM9oUg8khz54L4YeE8SbFjAi9iGKBK3PLWUQmAF4fbwkYGdvs\n\tHWja0IVXzaXwhS+k/OyH2babgFCWWHbSMxStNtWRM6Z/B9xY5tXHgkusrWzEI4BTSNv0sbbboHY\n\t24n3g+J8ISLwrTcbBE8+mUcy8o30vjFkOVm2fU+bO7hH4d4nUKu9c8OKvfUymFMLZY1Nrx8qTDS\n\tQfjBwJBdMHR2SlgUxU7ko0mCUTG2M7ahzCSkiJ/Bw5MXVCEAarj1wvPm94f8r5EDRBUXSiz8mG2\n\tS1VVdjNhNROE0aXCT1V8eu3ucmEggNz/SEqvuDGRfw7i35RFrZ/q/M46kD7IQvd4oXh5mypWE8J\n\tQYW6KHBFj/SiuoSxdhUnvFiiHyum2GbHq2","X-Received":"by 2002:a05:6a00:2d23:b0:82c:dfea:9e2a with SMTP id\n d2e1a72fcca58-82f0c2695eemr25107512b3a.2.1776304040028;\n        Wed, 15 Apr 2026 18:47:20 -0700 (PDT)","From":"Ritesh Harjani (IBM) <ritesh.list@gmail.com>","To":"Baolin Liu <liubaolin12138@163.com>, tytso@mit.edu,\n adilger.kernel@dilger.ca","Cc":"liubaolin12138@163.com, linux-ext4@vger.kernel.org,\n linux-kernel@vger.kernel.org, wangguanyu@vivo.com,\n Baolin Liu <liubaolin@kylinos.cn>","Subject":"Re: [PATCH v1] ext4: add mb_stats_clear for mballoc statistics","In-Reply-To":"<20260414100212.95209-1-liubaolin12138@163.com>","Date":"Thu, 16 Apr 2026 07:14:35 +0530","Message-ID":"<mrz3u1a4.ritesh.list@gmail.com>","References":"<20260414100212.95209-1-liubaolin12138@163.com>","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"<linux-ext4.vger.kernel.org>","List-Subscribe":"<mailto:linux-ext4+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-ext4+unsubscribe@vger.kernel.org>","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tFREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}},{"id":3677962,"web_url":"http://patchwork.ozlabs.org/comment/3677962/","msgid":"<d4d92271-4f46-4a38-86c9-94b2b8efa504@163.com>","list_archive_url":null,"date":"2026-04-16T07:07:28","subject":"Re: [PATCH v1] ext4: add mb_stats_clear for mballoc statistics","submitter":{"id":89479,"url":"http://patchwork.ozlabs.org/api/people/89479/","name":"liubaolin","email":"liubaolin12138@163.com"},"content":"> Dear ojaswin,\n>    Alright, thank you for your review. I will revise the patch according to Andreas's comments and submit a second version. \n>    When submitting the second version, I will also update the relevant files under the Documentation directory according to your suggestions to add explanations.\n> \n> Regards,\n> Baolin\n\n\n\n在 2026/4/16 3:26, Ojaswin Mujoo 写道:\n> On Tue, Apr 14, 2026 at 06:02:11PM +0800, Baolin Liu wrote:\n>> From: Baolin Liu <liubaolin@kylinos.cn>\n>>\n>> Add a write-only mb_stats_clear sysfs knob to reset ext4 mballoc\n>> runtime statistics.This makes it easier to inspect allocator\n>> activity for a specific workload instead of using counters\n>> accumulated since mount.\n>>\n>> Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>\n> \n> The patch looks good to me Baolin. We just need to add documentation of\n> this to the Documentation/ABI/testing/sysfs-fs-ext4 file so that the\n> users know what it is and the fact that the only value we allow to write\n> is 1.\n> \n> Regards,\n> ojaswin","headers":{"Return-Path":"\n <SRS0=C9XZ=CP=vger.kernel.org=linux-ext4+bounces-15859-patchwork-incoming=ozlabs.org@ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=ETXKgzWs;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=c9xz=cp=vger.kernel.org=linux-ext4+bounces-15859-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c09:e001:a7::12fc:5321\"\n arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=163.com","gandalf.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=ETXKgzWs;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15859-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=\"ETXKgzWs\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=220.197.31.3","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=163.com"],"Received":["from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx8HZ3r9Bz1yG9\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 17:08:25 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fx8HY44FRz4wSJ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 17:08:25 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4fx8HY40KGz4wTy; Thu, 16 Apr 2026 17:08:25 +1000 (AEST)","from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fx8HT2lNyz4wSJ\n\tfor <patchwork-incoming@ozlabs.org>; Thu, 16 Apr 2026 17:08:21 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 329DE3030860\n\tfor <patchwork-incoming@ozlabs.org>; Thu, 16 Apr 2026 07:08:18 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2CA1633D6FC;\n\tThu, 16 Apr 2026 07:08:14 +0000 (UTC)","from m16.mail.163.com (m16.mail.163.com [220.197.31.3])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E778379979;\n\tThu, 16 Apr 2026 07:08:09 +0000 (UTC)","from [192.168.52.68] (unknown [])\n\tby gzga-smtp-mtada-g1-3 (Coremail) with SMTP id\n _____wDHcf+4iuBpJw0iFg--.26284S2;\n\tThu, 16 Apr 2026 15:07:41 +0800 (CST)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1776323305; cv=pass;\n\tb=yWScV/QBOZbjegqvTmjTrSBVFTubfS7NegxpF7bQ5LrNTavLeBoMk17W3If1nOjVXWJYAKs+hfullBvgyoKPD4PEq3O4V0htQO5Limv795LXu4GglybnEYc9PXjND97vwsGkN+qnHXUQBlnwtwWlFaCUMi4keqsWJm8LEmdcclRSuSWWtE7VmhXy8yvErxd33gFPx8mLj+4qknXBZFmPyz5g9cRrH4fYsern+L4dFxbtSEMo76VF+NKF7gcDagIIshTAcwvQSCjePsPuIAn9todkZi1upfSm+iTDGwicUKy7K1Y0nurOLx4ILMLDRQN9wsnejYoqP7ZAoFEAV7r33A==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776323294; cv=none;\n b=oICJXEW2pLLHbWstEZrzKBjmfzv1jGxityGPot0F0KtMdmhqVXg2cephiUH8/rDqv0kcCNC/NIFBUCWel0e84k48CCZDfvNeqaqpDU2oiUVvvYJKQD+MbaOTaVu3GRoSXsEYCM+eVJtTgw/QwyRhUPYB0JKZKyNpuRIM+jgIEF0="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1776323305; c=relaxed/relaxed;\n\tbh=LFPNGPaENT/hBl+GocrWQH8+ip14PqtZctiPRBXxdLA=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=VyhPgsAUgCz2FWyRDA52XIUFLzQOBCkmheLft0xmZGEhUUTul8xGt0bJ33yq0tH6keIXBbjEt96XV1k0myrjqi+SHDJGUvQ8CspLjCN1M7XhSwsMWvXx5W1zdakoRdE/rO85k+OKnqWTkOmD+82Z4NF66weoyDN//yTgGlnISHd0/cktRBuXKMfzGmy2PAy3EH7+dj8p56AvODNSGoy8/o+iH2f9FQOMtmNp/kxtuG755SMe+pURCW2u27NpmLVxqPrDZJPxiiBH4+wW2Lz/e3PtTsJdwczS5YOb0D3M6+78YfR2qoRdgifg2rKhE6uV766BLu+I3i+lvfscaoW31Q==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776323294; c=relaxed/simple;\n\tbh=xvxoZZLTapK+XHwWro+HCK/dDhDP8DvRNWH7T7CeGM0=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=T+jN+4xLg4LqfgQotiY/5k1h1ehZXLP8u2JSjtoJBx1lLIB9eI+xfV5cC080le2ZwDzIwUaHcpsxGPRF3Jdw63JesUwhk6dYTT3kW+ZXXrdXiD1HYDnIQcIcyS1Pr1PjSQkdO6p2KTX0RXbdePNVO3+byTkymjr75kfLXNP3nqM="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=163.com; dkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=ETXKgzWs; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15859-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com;\n spf=pass smtp.mailfrom=163.com;\n dkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=ETXKgzWs; arc=none smtp.client-ip=220.197.31.3"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n\ts=s110527; h=Message-ID:Date:MIME-Version:Subject:To:From:\n\tContent-Type; bh=LFPNGPaENT/hBl+GocrWQH8+ip14PqtZctiPRBXxdLA=;\n\tb=ETXKgzWsGjk91qCDdd62axe4zVADUpTgnQ2eaCK5fo+zjTGCpDFTE/chXj7irv\n\tjhag5RqBbudJQb5QkTC8GdMgJgeCXfugpr9T5jasAwPiN3j+KTdnOfkBWh3Ifi46\n\tiXhzTCIKSa406Ik95GtggkheKgEv+NPgUv2KqeOgCushA=","Message-ID":"<d4d92271-4f46-4a38-86c9-94b2b8efa504@163.com>","Date":"Thu, 16 Apr 2026 15:07:28 +0800","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"<linux-ext4.vger.kernel.org>","List-Subscribe":"<mailto:linux-ext4+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-ext4+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] ext4: add mb_stats_clear for mballoc statistics","To":"Ojaswin Mujoo <ojaswin@linux.ibm.com>","Cc":"tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,\n linux-kernel@vger.kernel.org, wangguanyu@vivo.com,\n Baolin Liu <liubaolin@kylinos.cn>","References":"<20260414100212.95209-1-liubaolin12138@163.com>\n <ad_mguIqaOT-pEmh@li-dc0c254c-257c-11b2-a85c-98b6c1322444.ibm.com>","From":"liubaolin <liubaolin12138@163.com>","In-Reply-To":"\n <ad_mguIqaOT-pEmh@li-dc0c254c-257c-11b2-a85c-98b6c1322444.ibm.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-CM-TRANSID":"_____wDHcf+4iuBpJw0iFg--.26284S2","X-Coremail-Antispam":"1Uf129KBjvdXoW7Wr4xZF45uFWfuF15Ww4fAFb_yoWDWrgE9r\n\t18tFs7C3ZFqF1kJa1fCr18WFZY9FZ29ryDJwn5JFs3W34YvanYkrZ5WrZ0yF17WFW09rZ3\n\tWF4rXasxAFnFqjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT\n\t9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjtrcPUUUUU==","X-CM-SenderInfo":"xolxutxrol0iasrtmqqrwthudrp/xtbCwh1kL2ngir2GUAAA38","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tFREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}},{"id":3677965,"web_url":"http://patchwork.ozlabs.org/comment/3677965/","msgid":"<15dddf71-1f8c-45eb-9333-fb2e9174004d@163.com>","list_archive_url":null,"date":"2026-04-16T07:11:45","subject":"Re: [PATCH v1] ext4: add mb_stats_clear for mballoc statistics","submitter":{"id":89479,"url":"http://patchwork.ozlabs.org/api/people/89479/","name":"liubaolin","email":"liubaolin12138@163.com"},"content":"> Dear Andreas,\n>    Alright, thank you for your review. \n>    I will revise the patch according to your suggestions and submit a second version as soon as possible.\n> \n> Regards,\n> Baolin\n\n\n\n在 2026/4/16 9:14, Andreas Dilger 写道:\n> On Apr 14, 2026, at 04:02, Baolin Liu <liubaolin12138@163.com> wrote:\n>>\n>> From: Baolin Liu <liubaolin@kylinos.cn>\n>>\n>> Add a write-only mb_stats_clear sysfs knob to reset ext4 mballoc\n>> runtime statistics. This makes it easier to inspect allocator\n>> activity for a specific workload instead of using counters\n>> accumulated since mount.\n> \n> Rather than having a read-only \"mb_stats\" procfs file and a separate\n> write-only \"mb_stats_clear\" sysfs file to clear \"mb_stats\", IMHO it\n> would be more obvious to write directly to \"/proc/fs/ext4/DEV/mb_stats\"\n> file to clear it.  Writing \"0\" would be logical to zero out the stats.\n> \n> Cheers, Andreas\n> \n>>\n>> Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>\n>> ---\n>> fs/ext4/ext4.h    |  1 +\n>> fs/ext4/mballoc.c | 31 +++++++++++++++++++++++++++++++\n>> fs/ext4/sysfs.c   | 24 ++++++++++++++++++++++++\n>> 3 files changed, 56 insertions(+)\n>>\n>> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h\n>> index 7617e2d454ea..3a32e1a515dd 100644\n>> --- a/fs/ext4/ext4.h\n>> +++ b/fs/ext4/ext4.h\n>> @@ -2995,6 +2995,7 @@ int ext4_fc_record_regions(struct super_block *sb, int ino,\n>> extern const struct seq_operations ext4_mb_seq_groups_ops;\n>> extern const struct seq_operations ext4_mb_seq_structs_summary_ops;\n>> extern int ext4_seq_mb_stats_show(struct seq_file *seq, void *offset);\n>> +extern void ext4_mb_stats_clear(struct ext4_sb_info *sbi);\n>> extern int ext4_mb_init(struct super_block *);\n>> extern void ext4_mb_release(struct super_block *);\n>> extern ext4_fsblk_t ext4_mb_new_blocks(handle_t *,\n>> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c\n>> index bb58eafb87bc..382c91586b26 100644\n>> --- a/fs/ext4/mballoc.c\n>> +++ b/fs/ext4/mballoc.c\n>> @@ -3219,6 +3219,8 @@ int ext4_seq_mb_stats_show(struct seq_file *seq, void *offset)\n>> }\n>> seq_printf(seq, \"\\treqs: %u\\n\", atomic_read(&sbi->s_bal_reqs));\n>> seq_printf(seq, \"\\tsuccess: %u\\n\", atomic_read(&sbi->s_bal_success));\n>> + seq_printf(seq, \"\\tblocks_allocated: %u\\n\",\n>> +   atomic_read(&sbi->s_bal_allocated));\n>>\n>> seq_printf(seq, \"\\tgroups_scanned: %u\\n\",\n>>    atomic_read(&sbi->s_bal_groups_scanned));\n>> @@ -4721,6 +4723,35 @@ static void ext4_mb_collect_stats(struct ext4_allocation_context *ac)\n>> trace_ext4_mballoc_prealloc(ac);\n>> }\n>>\n>> +void ext4_mb_stats_clear(struct ext4_sb_info *sbi)\n>> +{\n>> + int i;\n>> +\n>> + atomic_set(&sbi->s_bal_reqs, 0);\n>> + atomic_set(&sbi->s_bal_success, 0);\n>> + atomic_set(&sbi->s_bal_allocated, 0);\n>> + atomic_set(&sbi->s_bal_groups_scanned, 0);\n>> +\n>> + for (i = 0; i < EXT4_MB_NUM_CRS; i++) {\n>> + atomic64_set(&sbi->s_bal_cX_hits[i], 0);\n>> + atomic64_set(&sbi->s_bal_cX_groups_considered[i], 0);\n>> + atomic_set(&sbi->s_bal_cX_ex_scanned[i], 0);\n>> + atomic64_set(&sbi->s_bal_cX_failed[i], 0);\n>> + }\n>> +\n>> + atomic_set(&sbi->s_bal_ex_scanned, 0);\n>> + atomic_set(&sbi->s_bal_goals, 0);\n>> + atomic_set(&sbi->s_bal_stream_goals, 0);\n>> + atomic_set(&sbi->s_bal_len_goals, 0);\n>> + atomic_set(&sbi->s_bal_2orders, 0);\n>> + atomic_set(&sbi->s_bal_breaks, 0);\n>> + atomic_set(&sbi->s_mb_lost_chunks, 0);\n>> + atomic_set(&sbi->s_mb_buddies_generated, 0);\n>> + atomic64_set(&sbi->s_mb_generation_time, 0);\n>> + atomic_set(&sbi->s_mb_preallocated, 0);\n>> + atomic_set(&sbi->s_mb_discarded, 0);\n>> +}\n>> +\n>> /*\n>>   * Called on failure; free up any blocks from the inode PA for this\n>>   * context.  We don't need this for MB_GROUP_PA because we only change\n>> diff --git a/fs/ext4/sysfs.c b/fs/ext4/sysfs.c\n>> index 923b375e017f..a5bd88a99f22 100644\n>> --- a/fs/ext4/sysfs.c\n>> +++ b/fs/ext4/sysfs.c\n>> @@ -41,6 +41,7 @@ typedef enum {\n>> attr_pointer_atomic,\n>> attr_journal_task,\n>> attr_err_report_sec,\n>> + attr_mb_stats_clear,\n>> } attr_id_t;\n>>\n>> typedef enum {\n>> @@ -161,6 +162,25 @@ static ssize_t err_report_sec_store(struct ext4_sb_info *sbi,\n>> return count;\n>> }\n>>\n>> +static ssize_t mb_stats_clear_store(struct ext4_sb_info *sbi,\n>> +    const char *buf, size_t count)\n>> +{\n>> + int val;\n>> + int ret;\n>> +\n>> + if (!capable(CAP_SYS_ADMIN))\n>> + return -EPERM;\n>> +\n>> + ret = kstrtoint(skip_spaces(buf), 0, &val);\n>> + if (ret)\n>> + return ret;\n>> + if (val != 1)\n>> + return -EINVAL;\n>> +\n>> + ext4_mb_stats_clear(sbi);\n>> + return count;\n>> +}\n>> +\n>> static ssize_t journal_task_show(struct ext4_sb_info *sbi, char *buf)\n>> {\n>> if (!sbi->s_journal)\n>> @@ -251,6 +271,7 @@ EXT4_ATTR_OFFSET(mb_best_avail_max_trim_order, 0644, mb_order,\n>> EXT4_ATTR_OFFSET(err_report_sec, 0644, err_report_sec, ext4_sb_info, s_err_report_sec);\n>> EXT4_RW_ATTR_SBI_UI(inode_goal, s_inode_goal);\n>> EXT4_RW_ATTR_SBI_UI(mb_stats, s_mb_stats);\n>> +EXT4_ATTR(mb_stats_clear, 0200, mb_stats_clear);\n>> EXT4_RW_ATTR_SBI_UI(mb_max_to_scan, s_mb_max_to_scan);\n>> EXT4_RW_ATTR_SBI_UI(mb_min_to_scan, s_mb_min_to_scan);\n>> EXT4_RW_ATTR_SBI_UI(mb_order2_req, s_mb_order2_reqs);\n>> @@ -301,6 +322,7 @@ static struct attribute *ext4_attrs[] = {\n>> ATTR_LIST(inode_readahead_blks),\n>> ATTR_LIST(inode_goal),\n>> ATTR_LIST(mb_stats),\n>> + ATTR_LIST(mb_stats_clear),\n>> ATTR_LIST(mb_max_to_scan),\n>> ATTR_LIST(mb_min_to_scan),\n>> ATTR_LIST(mb_order2_req),\n>> @@ -561,6 +583,8 @@ static ssize_t ext4_attr_store(struct kobject *kobj,\n>> return trigger_test_error(sbi, buf, len);\n>> case attr_err_report_sec:\n>> return err_report_sec_store(sbi, buf, len);\n>> + case attr_mb_stats_clear:\n>> + return mb_stats_clear_store(sbi, buf, len);\n>> default:\n>> return ext4_generic_attr_store(a, sbi, buf, len);\n>> }\n>> -- \n>> 2.51.0\n>>\n> \n> \n> Cheers, Andreas\n> \n> \n> \n>","headers":{"Return-Path":"\n <SRS0=EuNk=CP=vger.kernel.org=linux-ext4+bounces-15860-patchwork-incoming=ozlabs.org@ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=dDeQvWzY;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=eunk=cp=vger.kernel.org=linux-ext4+bounces-15860-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c04:e001:36c::12fc:5321\"\n arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=163.com","gandalf.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=dDeQvWzY;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15860-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=\"dDeQvWzY\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=220.197.31.3","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=163.com"],"Received":["from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx8NL15Fgz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 17:12:34 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fx8NL0tCcz4wKD\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 17:12:34 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4fx8NL0lPVz4wTs; Thu, 16 Apr 2026 17:12:34 +1000 (AEST)","from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fx8NG3X1Fz4wKD\n\tfor <patchwork-incoming@ozlabs.org>; Thu, 16 Apr 2026 17:12:30 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 1E5B130532E8\n\tfor <patchwork-incoming@ozlabs.org>; Thu, 16 Apr 2026 07:12:28 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A60ED381B0D;\n\tThu, 16 Apr 2026 07:12:23 +0000 (UTC)","from m16.mail.163.com (m16.mail.163.com [220.197.31.3])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 656B7381AF1;\n\tThu, 16 Apr 2026 07:12:17 +0000 (UTC)","from [192.168.52.68] (unknown [])\n\tby gzga-smtp-mtada-g1-1 (Coremail) with SMTP id\n _____wAXw4q4i+BpvvYOFQ--.32909S2;\n\tThu, 16 Apr 2026 15:11:59 +0800 (CST)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1776323554; cv=pass;\n\tb=Am8dt8WPyl5U0dmaHk7qeYziY2sVEzEL6amrDqlhbHQzJ4MXuPedjj2f0sGXNDWTkqcJa81EwI6TM/MTZSbs/YoovAMaMXGxBGQUO+hAbTJX8BjgRSc8DQP46GDwuzFyDTKvpAMia7XUDbJ4NbJ6+/J/chT0Fw75zS2XFLn5MUYBcfqpYkdDTlFT3MmPHus8/LUay0o463FXBlDhplRdn/97lxHJSI5WdcFBTZwnNRQVqdOD7ApNDvA5fG4FUuT73Ulk+JLnrvbn7Xpd+kcdc8PpUFvGCg7MrxZV6V7vhaqj+oP8q4WH1RYkQG14wZCvyO97EIQgoff8qwIaCHM3ew==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776323543; cv=none;\n b=HOlc4b9bS+iMsR2GcVAEqSIuE3toBnd/Vb0mpMdNc6wfIEh73kHqiN9vx1iDuwA7CAC7JIABZNFKg24JDIzIedHvwoa/HMBT9YOMhN1IzeEvnXgupCxVf6+pPBQkZMDpgRXHGtudn5IHbtD3XYfTo48iiBojXAmkvOvINQlLIsI="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1776323554; c=relaxed/relaxed;\n\tbh=cZeo+DgkpM2Uz3VzKKnxTjGAnhkF1Mug5sB/TxZ+JnM=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=c3jnsB1AFUdmeC0pV5Aa1ql0ZD+FeYdHh5Ks1Cp6n2mAXNb2E0Ri6yHW7x8u5pdGFpMVLxhiCkPvbVPuAc+213SZQ+1Th+HNHpjs/zUStVq9FynaVEv3kKKibdfaNpFgrjZZfKQgCYxMi9G/1rBrNSNyci2rphvC+ohZtiGQHfAcaQRGmT3AmyW2kEds2uI8tWzYjVPOJA6U6PkHUf0bithaXMV4ZoJSm72og1pEycDTkph0fzIOLFoPNK9PjhAYzHQD6DmRFQn9bP8e4A526I3YB421fiZ8xOprwGsywvnQtAhSUHWIORzZSgF15WrofdAe+bgpBn7wjIJ7p1TE5Q==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776323543; c=relaxed/simple;\n\tbh=EqlhrMN2mvo77sPC9guGSaHcnnnaUO5URwrK6o9rBAk=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=UJQyBgl5lao7Jc/VDntawbWWTd/o0g+zcIFwmYrKJz3MeVNclQk41hUHQN4eNWUQXs6J3RskKFdgvoD8RYjQmqfYfGVR8Zfy1wDd1bggcsMF8Wi9vQGZyCR0Cjxw7SrGmrNs5XgtE4K7rGIUQDtH89vF4stmZrV7xOmAH7aJdVs="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=163.com; dkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=dDeQvWzY; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15860-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com;\n spf=pass smtp.mailfrom=163.com;\n dkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=dDeQvWzY; arc=none smtp.client-ip=220.197.31.3"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n\ts=s110527; h=Message-ID:Date:MIME-Version:Subject:To:From:\n\tContent-Type; bh=cZeo+DgkpM2Uz3VzKKnxTjGAnhkF1Mug5sB/TxZ+JnM=;\n\tb=dDeQvWzYYzUB0GHDbMOhrftzdmglH3rFli/jU0PtzjlRaAT9nLkU75Twz1JxjQ\n\t8UZd0vL7dQ17cRfSnlaJPbhsViYCGsH3KrIYVoEni0aDgtfRc2tc5HOM3k8Jtkkj\n\tdRi3em4jQCEHVkq0ynArJtHuLqTIVxfuQGTmjv+AYNFdA=","Message-ID":"<15dddf71-1f8c-45eb-9333-fb2e9174004d@163.com>","Date":"Thu, 16 Apr 2026 15:11:45 +0800","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"<linux-ext4.vger.kernel.org>","List-Subscribe":"<mailto:linux-ext4+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-ext4+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] ext4: add mb_stats_clear for mballoc statistics","To":"Andreas Dilger <adilger@dilger.ca>","Cc":"tytso@mit.edu, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,\n wangguanyu@vivo.com, Baolin Liu <liubaolin@kylinos.cn>","References":"<20260414100212.95209-1-liubaolin12138@163.com>\n <C713AA9C-D640-4C5B-98BF-A5D88AE3B2A0@dilger.ca>","From":"liubaolin <liubaolin12138@163.com>","In-Reply-To":"<C713AA9C-D640-4C5B-98BF-A5D88AE3B2A0@dilger.ca>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-CM-TRANSID":"_____wAXw4q4i+BpvvYOFQ--.32909S2","X-Coremail-Antispam":"1Uf129KBjvJXoW3Gr4xZrWDJrWkAr1UZryfXrb_yoW7Kw48pa\n\tn8Jay5CF4UX3Wxurs7Wa18W3ZYyw40kFyUKr4Sy3WI9FZIvr9ayFyIgFy09Fy5ArWUC3Wv\n\tv3WjvrZrWr4Fga7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07Uca9-UUUUU=","X-CM-SenderInfo":"xolxutxrol0iasrtmqqrwthudrp/xtbC6QClcGngi8Dz5gAA3r","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tFREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}},{"id":3677967,"web_url":"http://patchwork.ozlabs.org/comment/3677967/","msgid":"<0e075abc-11f2-40f3-9dd3-566cd54a2bae@163.com>","list_archive_url":null,"date":"2026-04-16T07:16:08","subject":"Re: [PATCH v1] ext4: add mb_stats_clear for mballoc statistics","submitter":{"id":89479,"url":"http://patchwork.ozlabs.org/api/people/89479/","name":"liubaolin","email":"liubaolin12138@163.com"},"content":"> Dear Ritesh,\n> Thank you for your review. I will revise the patch according to Andreas's comments and submit a second version. \n> When the second version is submitted, you are welcome to review it. \n> Once the patch is finalized, the maintainer will add the Reviewed-by tag.\n> \n> Regards,\n> Baolin\n\n\n\n在 2026/4/16 9:44, Ritesh Harjani (IBM) 写道:\n> Baolin Liu <liubaolin12138@163.com> writes:\n> \n>> From: Baolin Liu <liubaolin@kylinos.cn>\n>>\n>> Add a write-only mb_stats_clear sysfs knob to reset ext4 mballoc\n>> runtime statistics.This makes it easier to inspect allocator\n>> activity for a specific workload instead of using counters\n>> accumulated since mount.\n>>\n>> Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>\n> \n> Make sense to me. The changes looks good and works fine at my end.\n> So please feel free to add:\n> \n> Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>","headers":{"Return-Path":"\n <SRS0=Ylsh=CP=vger.kernel.org=linux-ext4+bounces-15861-patchwork-incoming=ozlabs.org@ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=VMyj2cX0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=ylsh=cp=vger.kernel.org=linux-ext4+bounces-15861-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=172.105.105.114 arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=163.com","gandalf.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=VMyj2cX0;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15861-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=\"VMyj2cX0\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=220.197.31.2","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=163.com"],"Received":["from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx8Tq0PQxz1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 17:17:18 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fx8Tp6Qdtz4w2D\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 17:17:18 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4fx8Tp6HpTz4wTH; Thu, 16 Apr 2026 17:17:18 +1000 (AEST)","from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fx8Tk02V9z4w2D\n\tfor <patchwork-incoming@ozlabs.org>; Thu, 16 Apr 2026 17:17:13 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 87F6C306982E\n\tfor <patchwork-incoming@ozlabs.org>; Thu, 16 Apr 2026 07:17:11 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id EC710389100;\n\tThu, 16 Apr 2026 07:17:08 +0000 (UTC)","from m16.mail.163.com (m16.mail.163.com [220.197.31.2])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id DA99D3890F8;\n\tThu, 16 Apr 2026 07:17:02 +0000 (UTC)","from [192.168.52.68] (unknown [])\n\tby gzga-smtp-mtada-g0-4 (Coremail) with SMTP id\n _____wAnTjfAjOBpj93QFQ--.34787S2;\n\tThu, 16 Apr 2026 15:16:39 +0800 (CST)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1776323838; cv=pass;\n\tb=NKqASMq7nuELIHOxt8QdmOiab/E3d+RN0CeyQE9580wk2hGD1KsyUM+oXa2NxaVCAlVIW3iEHqf6Ek2mmEEv8vltytjK6ztHP9EOUtnRnJX+onZX71oUWCuj/RMbSmCYzwSJ/MK+V9xEdjgGr2amHEn5qzw3ivkA3luJFlE5rvQkUKBlFE6TXXaYaUwcGeLfcBQBiBAe2zunqMBwSOsGlJKrqzOXdTCxWO2g/6b4SP5WGqboQ1OWhnedw+LHGMATuHOtaxO6XjzwJSlT3RQEg8DD0qNKRX6P4y7CCo9hTTaaiZbS6sAWQHzk2gLIs8S3kY50fw2UQnhLUT7+9b9Rxw==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776323828; cv=none;\n b=Nqa11hWobEYDuUVGIEeg1MsjAVz8I+ncFnBhN4c0/izVJag2c/80E1lQ4yjC5/wS+pGCglRiQNjiwtV/S6YRZnQ8hIsZyIRiJhaaf11/feeG9dMT8Apo9HqkJYAq+BiXYQ9X0sUrVtWrQcmBXznWA00vVzcTMwou7dSM7+rlquw="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1776323838; c=relaxed/relaxed;\n\tbh=dpcMwWN6wfvZWsRzEglGoYfk3QQ0TAkfu5uyMy5pr98=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=UM09vSRlP7ZslsLSGMttRzEULSLiUMK9qCFiOxWZkZ4YX/GXRUmdnC4doVJaRg28l2Z79kRikhhTxUX7SDWxIGD+lxQdrB5aCWmJ1X6ao4isaTVmNo2oikY/e39TVtOOjAemF2+zKXM4/XLzRpfTcTYUxz/JyzIlnDsGQ9Es1w6vzfMyOAI/R7SxxsoeTIius/B+FQjFEmvUNwHjkKOPWiotK4PkQ1HidOtzV3nk1IuFgfqpz8wUpE04eSAVjx/2lyD65MU0iwzhng72zd3Ou/KV5vcgeXOnegVmpIi3JW1R7lsghjQ+NZRt1cqMOAMcLyEeHZMIVZw7Xw2xF0XSGg==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776323828; c=relaxed/simple;\n\tbh=NwfLGHYFdb5O5foi5Zj2yT0QzLf5LiM98srI8tmX5B4=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=HVKIyANLdlEVJFz7FUGgOBXgLE+StEOzCdaGEcCJTHeHPm4Sl8eJz9nw/kl6GWefyGRxgDGXKv5yd060g7wofLrraZsEEiWz33QsjUtUTS4pTXvdeCxp+j9pqok//GQ/HVagfVGSKeezwevy1bgzPHeASaM3115UM2ZcID60gzI="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=163.com; dkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=VMyj2cX0; dkim-atps=neutral;\n spf=pass (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15861-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com;\n spf=pass smtp.mailfrom=163.com;\n dkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=VMyj2cX0; arc=none smtp.client-ip=220.197.31.2"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n\ts=s110527; h=Message-ID:Date:MIME-Version:Subject:To:From:\n\tContent-Type; bh=dpcMwWN6wfvZWsRzEglGoYfk3QQ0TAkfu5uyMy5pr98=;\n\tb=VMyj2cX0gkEuhO9seCyGAjrkmP0BaJ3IfIc0WnyALVFuT3Mj67RKqhRDA5pEGX\n\tauLEUrDk1GMtl72esw7DKQh+DCs0bYOMQHmLeCzRBwr415zFRLwymHTflVAJuC4z\n\tYIhKhHowby34+LT3m3sfbjE9nXjBJysj4E5lEZ5QJfy8w=","Message-ID":"<0e075abc-11f2-40f3-9dd3-566cd54a2bae@163.com>","Date":"Thu, 16 Apr 2026 15:16:08 +0800","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"<linux-ext4.vger.kernel.org>","List-Subscribe":"<mailto:linux-ext4+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-ext4+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] ext4: add mb_stats_clear for mballoc statistics","To":"\"Ritesh Harjani (IBM)\" <ritesh.list@gmail.com>, tytso@mit.edu,\n adilger.kernel@dilger.ca","Cc":"linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,\n wangguanyu@vivo.com, Baolin Liu <liubaolin@kylinos.cn>","References":"<20260414100212.95209-1-liubaolin12138@163.com>\n <mrz3u1a4.ritesh.list@gmail.com>","From":"liubaolin <liubaolin12138@163.com>","In-Reply-To":"<mrz3u1a4.ritesh.list@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-CM-TRANSID":"_____wAnTjfAjOBpj93QFQ--.34787S2","X-Coremail-Antispam":"1Uf129KBjvdXoW7Wr4xJrWxZry3AF1kWw4fuFg_yoWfWFb_WF\n\tWYyrn7WF4UtF4xGan3Cr1xGrZY9Fy2vFs8t3s5Arn5Gas093ZYvF95WrsIvr18GF409Fs3\n\ttan7XF9ayFy7ujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT\n\t9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjJ5r3UUUUU==","X-CM-SenderInfo":"xolxutxrol0iasrtmqqrwthudrp/xtbC6hfqtWngjNcoKAAA3w","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tFREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}},{"id":3678023,"web_url":"http://patchwork.ozlabs.org/comment/3678023/","msgid":"<669739fd-688a-44e0-9ee7-1378960f1f65@huaweicloud.com>","list_archive_url":null,"date":"2026-04-16T08:53:46","subject":"Re: [PATCH v1] ext4: add mb_stats_clear for mballoc statistics","submitter":{"id":85428,"url":"http://patchwork.ozlabs.org/api/people/85428/","name":"Zhang Yi","email":"yi.zhang@huaweicloud.com"},"content":"On 4/14/2026 6:02 PM, Baolin Liu wrote:\n> From: Baolin Liu <liubaolin@kylinos.cn>\n> \n> Add a write-only mb_stats_clear sysfs knob to reset ext4 mballoc\n> runtime statistics.This makes it easier to inspect allocator\n> activity for a specific workload instead of using counters\n> accumulated since mount.\n> \n> Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>\n\nLooks good to me!\n\nReviewed-by: Zhang Yi <yi.zhang@huawei.com>\n\n> ---\n>  fs/ext4/ext4.h    |  1 +\n>  fs/ext4/mballoc.c | 31 +++++++++++++++++++++++++++++++\n>  fs/ext4/sysfs.c   | 24 ++++++++++++++++++++++++\n>  3 files changed, 56 insertions(+)\n> \n> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h\n> index 7617e2d454ea..3a32e1a515dd 100644\n> --- a/fs/ext4/ext4.h\n> +++ b/fs/ext4/ext4.h\n> @@ -2995,6 +2995,7 @@ int ext4_fc_record_regions(struct super_block *sb, int ino,\n>  extern const struct seq_operations ext4_mb_seq_groups_ops;\n>  extern const struct seq_operations ext4_mb_seq_structs_summary_ops;\n>  extern int ext4_seq_mb_stats_show(struct seq_file *seq, void *offset);\n> +extern void ext4_mb_stats_clear(struct ext4_sb_info *sbi);\n>  extern int ext4_mb_init(struct super_block *);\n>  extern void ext4_mb_release(struct super_block *);\n>  extern ext4_fsblk_t ext4_mb_new_blocks(handle_t *,\n> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c\n> index bb58eafb87bc..382c91586b26 100644\n> --- a/fs/ext4/mballoc.c\n> +++ b/fs/ext4/mballoc.c\n> @@ -3219,6 +3219,8 @@ int ext4_seq_mb_stats_show(struct seq_file *seq, void *offset)\n>  \t}\n>  \tseq_printf(seq, \"\\treqs: %u\\n\", atomic_read(&sbi->s_bal_reqs));\n>  \tseq_printf(seq, \"\\tsuccess: %u\\n\", atomic_read(&sbi->s_bal_success));\n> +\tseq_printf(seq, \"\\tblocks_allocated: %u\\n\",\n> +\t\t   atomic_read(&sbi->s_bal_allocated));\n>  \n>  \tseq_printf(seq, \"\\tgroups_scanned: %u\\n\",\n>  \t\t   atomic_read(&sbi->s_bal_groups_scanned));\n> @@ -4721,6 +4723,35 @@ static void ext4_mb_collect_stats(struct ext4_allocation_context *ac)\n>  \t\ttrace_ext4_mballoc_prealloc(ac);\n>  }\n>  \n> +void ext4_mb_stats_clear(struct ext4_sb_info *sbi)\n> +{\n> +\tint i;\n> +\n> +\tatomic_set(&sbi->s_bal_reqs, 0);\n> +\tatomic_set(&sbi->s_bal_success, 0);\n> +\tatomic_set(&sbi->s_bal_allocated, 0);\n> +\tatomic_set(&sbi->s_bal_groups_scanned, 0);\n> +\n> +\tfor (i = 0; i < EXT4_MB_NUM_CRS; i++) {\n> +\t\tatomic64_set(&sbi->s_bal_cX_hits[i], 0);\n> +\t\tatomic64_set(&sbi->s_bal_cX_groups_considered[i], 0);\n> +\t\tatomic_set(&sbi->s_bal_cX_ex_scanned[i], 0);\n> +\t\tatomic64_set(&sbi->s_bal_cX_failed[i], 0);\n> +\t}\n> +\n> +\tatomic_set(&sbi->s_bal_ex_scanned, 0);\n> +\tatomic_set(&sbi->s_bal_goals, 0);\n> +\tatomic_set(&sbi->s_bal_stream_goals, 0);\n> +\tatomic_set(&sbi->s_bal_len_goals, 0);\n> +\tatomic_set(&sbi->s_bal_2orders, 0);\n> +\tatomic_set(&sbi->s_bal_breaks, 0);\n> +\tatomic_set(&sbi->s_mb_lost_chunks, 0);\n> +\tatomic_set(&sbi->s_mb_buddies_generated, 0);\n> +\tatomic64_set(&sbi->s_mb_generation_time, 0);\n> +\tatomic_set(&sbi->s_mb_preallocated, 0);\n> +\tatomic_set(&sbi->s_mb_discarded, 0);\n> +}\n> +\n>  /*\n>   * Called on failure; free up any blocks from the inode PA for this\n>   * context.  We don't need this for MB_GROUP_PA because we only change\n> diff --git a/fs/ext4/sysfs.c b/fs/ext4/sysfs.c\n> index 923b375e017f..a5bd88a99f22 100644\n> --- a/fs/ext4/sysfs.c\n> +++ b/fs/ext4/sysfs.c\n> @@ -41,6 +41,7 @@ typedef enum {\n>  \tattr_pointer_atomic,\n>  \tattr_journal_task,\n>  \tattr_err_report_sec,\n> +\tattr_mb_stats_clear,\n>  } attr_id_t;\n>  \n>  typedef enum {\n> @@ -161,6 +162,25 @@ static ssize_t err_report_sec_store(struct ext4_sb_info *sbi,\n>  \treturn count;\n>  }\n>  \n> +static ssize_t mb_stats_clear_store(struct ext4_sb_info *sbi,\n> +\t\t\t\t    const char *buf, size_t count)\n> +{\n> +\tint val;\n> +\tint ret;\n> +\n> +\tif (!capable(CAP_SYS_ADMIN))\n> +\t\treturn -EPERM;\n> +\n> +\tret = kstrtoint(skip_spaces(buf), 0, &val);\n> +\tif (ret)\n> +\t\treturn ret;\n> +\tif (val != 1)\n> +\t\treturn -EINVAL;\n> +\n> +\text4_mb_stats_clear(sbi);\n> +\treturn count;\n> +}\n> +\n>  static ssize_t journal_task_show(struct ext4_sb_info *sbi, char *buf)\n>  {\n>  \tif (!sbi->s_journal)\n> @@ -251,6 +271,7 @@ EXT4_ATTR_OFFSET(mb_best_avail_max_trim_order, 0644, mb_order,\n>  EXT4_ATTR_OFFSET(err_report_sec, 0644, err_report_sec, ext4_sb_info, s_err_report_sec);\n>  EXT4_RW_ATTR_SBI_UI(inode_goal, s_inode_goal);\n>  EXT4_RW_ATTR_SBI_UI(mb_stats, s_mb_stats);\n> +EXT4_ATTR(mb_stats_clear, 0200, mb_stats_clear);\n>  EXT4_RW_ATTR_SBI_UI(mb_max_to_scan, s_mb_max_to_scan);\n>  EXT4_RW_ATTR_SBI_UI(mb_min_to_scan, s_mb_min_to_scan);\n>  EXT4_RW_ATTR_SBI_UI(mb_order2_req, s_mb_order2_reqs);\n> @@ -301,6 +322,7 @@ static struct attribute *ext4_attrs[] = {\n>  \tATTR_LIST(inode_readahead_blks),\n>  \tATTR_LIST(inode_goal),\n>  \tATTR_LIST(mb_stats),\n> +\tATTR_LIST(mb_stats_clear),\n>  \tATTR_LIST(mb_max_to_scan),\n>  \tATTR_LIST(mb_min_to_scan),\n>  \tATTR_LIST(mb_order2_req),\n> @@ -561,6 +583,8 @@ static ssize_t ext4_attr_store(struct kobject *kobj,\n>  \t\treturn trigger_test_error(sbi, buf, len);\n>  \tcase attr_err_report_sec:\n>  \t\treturn err_report_sec_store(sbi, buf, len);\n> +\tcase attr_mb_stats_clear:\n> +\t\treturn mb_stats_clear_store(sbi, buf, len);\n>  \tdefault:\n>  \t\treturn ext4_generic_attr_store(a, sbi, buf, len);\n>  \t}","headers":{"Return-Path":"\n <SRS0=Y3R3=CP=vger.kernel.org=linux-ext4+bounces-15862-patchwork-incoming=ozlabs.org@ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=y3r3=cp=vger.kernel.org=linux-ext4+bounces-15862-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c0a:e001:db::12fc:5321\"\n arc.chain=subspace.kernel.org","gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15862-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=45.249.212.56","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=huaweicloud.com"],"Received":["from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxBhM2cNJz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 18:56:34 +1000 (AEST)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fxBhF3t1Rz4wLZ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 18:56:29 +1000 (AEST)","by gandalf.ozlabs.org (Postfix)\n\tid 4fxBhF3nY1z4wTJ; Thu, 16 Apr 2026 18:56:29 +1000 (AEST)","from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fxBhB1978z4wLZ\n\tfor <patchwork-incoming@ozlabs.org>; Thu, 16 Apr 2026 18:56:26 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id B7CC4303A6CD\n\tfor <patchwork-incoming@ozlabs.org>; Thu, 16 Apr 2026 08:53:58 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 9B7283803E4;\n\tThu, 16 Apr 2026 08:53:56 +0000 (UTC)","from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com\n [45.249.212.56])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 778BE391E46;\n\tThu, 16 Apr 2026 08:53:51 +0000 (UTC)","from mail.maildlp.com (unknown [172.19.163.177])\n\tby dggsgout12.his.huawei.com (SkyGuard) with ESMTPS id 4fxBcx1zyZzKHMVq;\n\tThu, 16 Apr 2026 16:53:37 +0800 (CST)","from mail02.huawei.com (unknown [10.116.40.252])\n\tby mail.maildlp.com (Postfix) with ESMTP id 47FBF4058F;\n\tThu, 16 Apr 2026 16:53:48 +0800 (CST)","from [10.174.178.253] (unknown [10.174.178.253])\n\tby APP3 (Coremail) with SMTP id _Ch0CgBH9b6ao+BpkVljAg--.3631S3;\n\tThu, 16 Apr 2026 16:53:48 +0800 (CST)"],"ARC-Seal":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1776329789; cv=pass;\n\tb=r7tHdKAs00dCUQkm96MTuYWp9OOZmUMPB6eLReaGEsRNvM+KNzNdd1HOcUh1Y6/eQ4XF+lsnoEMBObwYOLb+3txtgvAbhQfnP7XvSgYi6uAxIw39nCIc3qD8JnkRtauhY9lvFd0+H3fR9nSoHdaUx9TJyb7nRhmuokcbPJT0mnGE43TIhO28KXUVoaVRvkQ6eNXlOMDI07jZHxnF5W4YD21Mbn8lpV+buYunfihmyHLxhoQuE+Vx/zWhUo7UCLiTmRFGh8q62LAtexVJnBqDf+kaQcVWpAmvZ8XQ+djZzuy6JL5hwtJhtn6Jr1a7SWRJl9y4+1bqjF2LukfHFsuRbQ==","i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776329635; cv=none;\n b=FjxZeg3LP0nm+8GWCht1jLNPRectXpCn6WW0JhWHGn6EtwCi38KaceQt5JYId7NWUhPhvF1dLEe+0ltTuBDGHU6Ug/pbPU1ZBrYmBl9gacGCVLE9QOaifZBjhjbOm2MkgtJsr+CeK5RM0lE8G7TBxT6AYMflw2htFb9nao2ioRU="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1776329789; c=relaxed/relaxed;\n\tbh=Ec1wJvaxm78/TAuz3qvt/f0+Mqu0PCKdX3nnWYxjNKc=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=Z1TTuXFIl6Ualf+GGFYtjBdERAIKpjp37RUwBTg8vbOimnZynY0unwMqxLiY/7g0xYHK9xTNIWQ+48ZEFZ8W7WWiWF+vJFX3tE/Ab5TqYJpQ5r7lqXdzbpz4+yw1UbJWmydBZukjSpyZER5uQsNzl+G2uXYl8uoBWN4yvCY/Lxe9NBhcvSKB7BEMvyzDJWvFbf/1R7n0Dohxr8ykrSq6tJNmYu8N5lf/Pp8MN5UYO6jr/S8CA5gq8BF3WVlS9w/JEKSpwvxxxApolUZGHy0PyzQ8Gmf0eJ3Lvb68Hv6mjG08Z3riMHDihfFvU7SeMX5XaAd+Lur28WAy5+tkv8UZgQ==","i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776329635; c=relaxed/simple;\n\tbh=OPVTPRZGR0iXXQJeWObQcKNhY7i2HwdtEW8TVPVEu/M=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=WSOYEN2zlbpqgenxZorgikFvnvX4M+ExHq1WepEvTyAlH8dwg+0wp8Ji/dx3S7s6G0ik0PYtfHkuEEW8EYUVN6EjQXJCunJq2Fcyqdo8sNw1CrgnTvDV0QjjA5NYox/7FeYlWCokgqKXPkTqkIyCFrr69FCF7B3y7h+FEGtr1EM="],"ARC-Authentication-Results":["i=2; gandalf.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com;\n spf=pass (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15862-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=huaweicloud.com;\n spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.56"],"Message-ID":"<669739fd-688a-44e0-9ee7-1378960f1f65@huaweicloud.com>","Date":"Thu, 16 Apr 2026 16:53:46 +0800","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"<linux-ext4.vger.kernel.org>","List-Subscribe":"<mailto:linux-ext4+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-ext4+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] ext4: add mb_stats_clear for mballoc statistics","To":"Baolin Liu <liubaolin12138@163.com>, tytso@mit.edu,\n adilger.kernel@dilger.ca","Cc":"linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,\n wangguanyu@vivo.com, Baolin Liu <liubaolin@kylinos.cn>","References":"<20260414100212.95209-1-liubaolin12138@163.com>","Content-Language":"en-US","From":"Zhang Yi <yi.zhang@huaweicloud.com>","In-Reply-To":"<20260414100212.95209-1-liubaolin12138@163.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-CM-TRANSID":"_Ch0CgBH9b6ao+BpkVljAg--.3631S3","X-Coremail-Antispam":"1UD129KBjvJXoW3GF48Kr1rtFyUKw4DJrWkJFb_yoW7Ar1rpF\n\tsxJa4UCF1UX3WxuFs3Wa18W3ZYvw40k3yUWr4avw1S9FZIqryftF92qFy0vFy5ArW8J3Wk\n\tX3WYv3yDGr40937anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDU0xBIdaVrnRJUUUymb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2\n\t6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4\n\tvEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7Cj\n\txVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I\n\t0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E\n\tx7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x\n\t0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7CjxVAaw2AFwI0_JF0_Jw1l42xK82IYc2Ij64vI\n\tr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8Gjc\n\txK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0\n\tcI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8V\n\tAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E\n\t14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07UK2NtUUUUU=","X-CM-SenderInfo":"d1lo6xhdqjqx5xdzvxpfor3voofrz/","X-Spam-Status":"No, score=-1.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDMARC_MISSING,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"}}]