[{"id":3677090,"web_url":"http://patchwork.ozlabs.org/comment/3677090/","msgid":"<7eb32749-dd83-48ea-94a4-41935cc90aca@linaro.org>","list_archive_url":null,"date":"2026-04-14T09:22:44","subject":"Re: [PATCH v2 06/17] hw/usb/hcd-ehci: Change descriptor addresses to\n 64-bit","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 14/4/26 10:00, Jamin Lin wrote:\n> Change internal EHCI descriptor addresses from uint32_t to uint64_t.\n> \n> The following fields are updated:\n> - EHCIPacket::qtdaddr\n> - EHCIQueue::{qhaddr, qtdaddr}\n> - EHCIState::{a_fetch_addr, p_fetch_addr}\n> \n> Update get_dwords() and put_dwords() to take 64-bit addresses and\n> propagate the type change through the descriptor traversal paths.\n> \n> Adjust NLPTR_GET() to operate on 64-bit values:\n> \n> #define NLPTR_GET(x) ((x) & ~0x1fULL)\n> \n> so that link pointer masking works correctly when descriptor\n> addresses exceed 32-bit space. The previous mask (0xffffffe0)\n> implicitly truncated addresses to 32 bits.\n> \n> This patch does not change the on-wire descriptor layout yet.\n> It only removes the internal 32-bit address limit and prepares\n> for later patches that will add full 64-bit QH/qTD/iTD/siTD support.\n> \n> Update the EHCI trace-events prototypes for QH, qTD, iTD, and siTD to\n> use uint64_t for the address argument and print it with PRIx64. This\n> ensures full 64-bit addresses are shown in trace output and improves\n> debugging of queue heads and transfer descriptors.\n> \n> Since the type of fetch_addr changes from 32-bit to 64-bit,\n> bump the VMState version.\n> \n> No functional change.\n> \n> Signed-off-by: Jamin Lin \n> ---\n> hw/usb/hcd-ehci.h | 12 ++++++----\n> hw/usb/hcd-ehci.c | 57 +++++++++++++++++++++++++++------------------\n> hw/usb/trace-events | 24 +++++++++----------\n> 3 files changed, 53 insertions(+), 40 deletions(-)\n\n\n> @@ -294,8 +294,10 @@ struct EHCIState {\n> EHCIQueueHead pqueues;\n> \n> /* which address to look at next */\n> - uint32_t a_fetch_addr;\n> - uint32_t p_fetch_addr;\n> + uint32_t a_fetch_addr_pre_v3;\n> + uint32_t p_fetch_addr_pre_v3;\n> + uint64_t a_fetch_addr;\n> + uint64_t p_fetch_addr;\n\n\n> @@ -2441,6 +2445,11 @@ static int usb_ehci_post_load(void *opaque, int version_id)\n> }\n> }\n> \n> + if (version_id < 3) {\n> + s->a_fetch_addr = s->a_fetch_addr_pre_v3;\n> + s->p_fetch_addr = s->p_fetch_addr_pre_v3;\n> + }\n> +\n> return 0;\n> }\n> \n> @@ -2472,7 +2481,7 @@ static void usb_ehci_vm_state_change(void *opaque, bool running, RunState state)\n> \n> const VMStateDescription vmstate_ehci = {\n> .name = \"ehci-core\",\n> - .version_id = 2,\n> + .version_id = 3,\n> .minimum_version_id = 1,\n> .pre_save = usb_ehci_pre_save,\n> .post_load = usb_ehci_post_load,\n> @@ -2501,8 +2510,10 @@ const VMStateDescription vmstate_ehci = {\n> /* schedule state */\n> VMSTATE_UINT32(astate, EHCIState),\n> VMSTATE_UINT32(pstate, EHCIState),\n> - VMSTATE_UINT32(a_fetch_addr, EHCIState),\n> - VMSTATE_UINT32(p_fetch_addr, EHCIState),\n> + VMSTATE_UINT32_V(a_fetch_addr_pre_v3, EHCIState, 2),\n> + VMSTATE_UINT32_V(p_fetch_addr_pre_v3, EHCIState, 2),\n\nIIUC we want VMSTATE_UINT32_TEST(..., 3) here, for \"<3\".\n\n> + VMSTATE_UINT64_V(a_fetch_addr, EHCIState, 3),\n> + VMSTATE_UINT64_V(p_fetch_addr, EHCIState, 3),\n\nThese ones are correct (\">=3\").\n\n> VMSTATE_END_OF_LIST()\n> }\n> };","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Ll9ECSPJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvzN93Tkdz1y2d\n\tfor ; Tue, 14 Apr 2026 19:23:19 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCZyt-0002sR-Po; Tue, 14 Apr 2026 05:22:51 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wCZys-0002ri-Jj\n for qemu-devel@nongnu.org; Tue, 14 Apr 2026 05:22:50 -0400","from mail-wm1-x334.google.com ([2a00:1450:4864:20::334])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wCZyq-0002go-MN\n for qemu-devel@nongnu.org; Tue, 14 Apr 2026 05:22:50 -0400","by mail-wm1-x334.google.com with SMTP id\n 5b1f17b1804b1-488b00ed86fso55442735e9.3\n for ; Tue, 14 Apr 2026 02:22:48 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488ee042ff9sm40765095e9.14.2026.04.14.02.22.44\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 14 Apr 2026 02:22:45 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776158567; x=1776763367; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=napVYKet5wfgKuxipXOGqoJX84ZK+ADDAP9uEoPAauw=;\n b=Ll9ECSPJxBE8ULWo2u2KPvXkHpWX7UBKFbAZTqppI1o6wQeZyCbSbtEYBkukhxjfzs\n Jv/m1v4m7pZYkyZMPbCQOJ0PbQk8P9a63sxKdlatm5/RsxRerrCSDPXbv1BI4Rznu0m2\n B2/YZhXGn5X16XVIQGlAuUy94wSfHosB54O5/Em0GBqRotPz3HMrm9/5gFCmN0naRjS4\n KldT03rIKnk9JH2wiZW9YtwtkSZFl0AlT3KwFvDUUlxsAKc5ERY2HQsTIGLlhJOUncc4\n bsiMTCRBvdlFOVnpyCjOFqqAxF0fhK9ySvqsbX6aAgo5GFJ2xamSUQqSg+QCRZudaM0s\n Ufug==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776158567; x=1776763367;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=napVYKet5wfgKuxipXOGqoJX84ZK+ADDAP9uEoPAauw=;\n b=eezmGzhGzD0DXtksN6RsaRs7Nv5EO4nZmW5aal9zwJx7YaaRsuPRzlDTY83CLXsmIs\n VpBPJ6vNgRkqDkpCV3+wrXw82MzRakBWfICI2XYVGevYEBAm5VlINYl4OfdwF0C/Au4p\n MquAOBcZgb0GF8xdNfI52L5e/3uewCXk1Wk28UTg5uehBaEHvMh3HLDohakRN1F6Cm1m\n Enhw4VskFpgy4ZgyF7ZN5qA/VtNJMq4QXKgBGzkUlsVeMf7qUZINrVEXiKMRGUWEf2yC\n LvOzRoY46pzioAiqh5yViBND4DK07g0+/ia21/TKtzHN07/R5FVjL9neuIbAOcGw/8fH\n 36DQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9B+2w8iYqULKl5IPcLb6qfHeCH5PNOxjpu021w7JaKvAT04iXvIMjXr0UCy/mBnuaBD/XPlf49xlQJ@nongnu.org","X-Gm-Message-State":"AOJu0YxtHSt57Br6GO2BUZHUkdSA7IGipvi6vTIhBxluhxIa7h9zvWVo\n e9+jgrzuFbVZo7a1bFDYYvfcS9SPbe/VaAlAUI9EfpoKiOFtf81gaoysZgUJfLR3gOA=","X-Gm-Gg":"AeBDieu+RwaNm8MyycsScdTuOfuX0cZh1FJ1lymeTXDgAsgJEcwpHvqQHsi5Bc46d+g\n U8VVITsmXRYl7zj/n7VoJNgVWtlh7GokRC1mVUwBv4DiK/X2DzZP/qR1X4baMyaM+bBoSKqiobL\n cdvvWy6o39NaNISqVCgUy/Ga+VAXlQNDTDhxQPbcnwmzPIcldVGbVD8KoH3PBfDvr1ctDxXsIyc\n VqgRg9V2QlXOhgEe6g0ILCnVmhf3ZyGqYp+PWxIeFXwtJ32r/q2mY1+vlcdekxTBtM1LS97fo6X\n v66n97SAVpvNPH5iGoSliaqebo6ulEDr+O/76WWehFSzZtsOLsQcDgFVdIg88BpZsc5C0zeJJlV\n M1vvXWbetgDesfsJlr2GY9iZjpiOFHihZ9BhqK4rsbrBDBzrfrJEjvuYe7sqT9a3KfgKXfuM1Tw\n pBfF8jRrjY9AjMPy1iOOEHebsAxu1YPipizvJXlSphSVXv+X7mZHwkEPiYSIPCFssjDg==","X-Received":"by 2002:a05:600c:4715:b0:488:9e54:94c0 with SMTP id\n 5b1f17b1804b1-488d67e7dd4mr245692415e9.8.1776158566868;\n Tue, 14 Apr 2026 02:22:46 -0700 (PDT)","Message-ID":"<7eb32749-dd83-48ea-94a4-41935cc90aca@linaro.org>","Date":"Tue, 14 Apr 2026 11:22:44 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 06/17] hw/usb/hcd-ehci: Change descriptor addresses to\n 64-bit","Content-Language":"en-US","To":"Jamin Lin ,\n =?utf-8?q?C=C3=A9dric_Le_Goater?= ,\n Peter Maydell ,\n Steven Lee , Troy Lee ,\n Kane Chen ,\n Andrew Jeffery , Joel Stanley ,\n \"open list:ASPEED BMCs\" ,\n \"open list:All patches CC here\" ","Cc":"Troy Lee , \"flwu@google.com\" ,\n \"nabihestefan@google.com\" ","References":"<20260414080025.3005916-1-jamin_lin@aspeedtech.com>\n <20260414080025.3005916-7-jamin_lin@aspeedtech.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260414080025.3005916-7-jamin_lin@aspeedtech.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::334;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3677433,"web_url":"http://patchwork.ozlabs.org/comment/3677433/","msgid":"","list_archive_url":null,"date":"2026-04-15T00:54:08","subject":"RE: [PATCH v2 06/17] hw/usb/hcd-ehci: Change descriptor addresses to\n 64-bit","submitter":{"id":81768,"url":"http://patchwork.ozlabs.org/api/people/81768/","name":"Jamin Lin","email":"jamin_lin@aspeedtech.com"},"content":"Hi Philippe\n\n> > const VMStateDescription vmstate_ehci = {\n> > .name = \"ehci-core\",\n> > - .version_id = 2,\n> > + .version_id = 3,\n> > .minimum_version_id = 1,\n> > .pre_save = usb_ehci_pre_save,\n> > .post_load = usb_ehci_post_load,\n> > @@ -2501,8 +2510,10 @@ const VMStateDescription vmstate_ehci = {\n> > /* schedule state */\n> > VMSTATE_UINT32(astate, EHCIState),\n> > VMSTATE_UINT32(pstate, EHCIState),\n> > - VMSTATE_UINT32(a_fetch_addr, EHCIState),\n> > - VMSTATE_UINT32(p_fetch_addr, EHCIState),\n> > + VMSTATE_UINT32_V(a_fetch_addr_pre_v3, EHCIState, 2),\n> > + VMSTATE_UINT32_V(p_fetch_addr_pre_v3, EHCIState, 2),\n> \n> IIUC we want VMSTATE_UINT32_TEST(..., 3) here, for \"<3\".\n> \n> > + VMSTATE_UINT64_V(a_fetch_addr, EHCIState, 3),\n> > + VMSTATE_UINT64_V(p_fetch_addr, EHCIState, 3),\n> \n> These ones are correct (\">=3\").\n> \n> > VMSTATE_END_OF_LIST()\n> > }\n> > };\n\nThanks for the review and suggestion.\nHow about the following changes?\nThanks-Jamin\n\n+static bool ehci_core_is_before_version_3(void *opaque, int version_id)\n+{\n+ return version_id < 3;\n+}\n+\n const VMStateDescription vmstate_ehci = {\n .name = \"ehci-core\",\n .version_id = 3,\n@@ -2510,8 +2515,10 @@ const VMStateDescription vmstate_ehci = {\n /* schedule state */\n VMSTATE_UINT32(astate, EHCIState),\n VMSTATE_UINT32(pstate, EHCIState),\n- VMSTATE_UINT32_V(a_fetch_addr_pre_v3, EHCIState, 2),\n- VMSTATE_UINT32_V(p_fetch_addr_pre_v3, EHCIState, 2),\n+ VMSTATE_UINT32_TEST(a_fetch_addr_pre_v3, EHCIState,\n+ ehci_core_is_before_version_3),\n+ VMSTATE_UINT32_TEST(p_fetch_addr_pre_v3, EHCIState,\n+ ehci_core_is_before_version_3),\n VMSTATE_UINT64_V(a_fetch_addr, EHCIState, 3),\n VMSTATE_UINT64_V(p_fetch_addr, EHCIState, 3),\n VMSTATE_END_OF_LIST()","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=OvQqnA4P;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwN2w1H26z1yHM\n\tfor ; Wed, 15 Apr 2026 10:54:48 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCoWI-0008DB-A5; Tue, 14 Apr 2026 20:54:18 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCoWG-0008CR-DI; Tue, 14 Apr 2026 20:54:16 -0400","from mail-japaneastazlp170120005.outbound.protection.outlook.com\n ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCoWE-0007oK-Vf; Tue, 14 Apr 2026 20:54:16 -0400","from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19)\n by TY0PR06MB5578.apcprd06.prod.outlook.com (2603:1096:400:328::11)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Wed, 15 Apr\n 2026 00:54:08 +0000","from TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9769.046; Wed, 15 Apr 2026\n 00:54:08 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=sMrgxx3Sou4hYSKHWPBxvr1PJbgbEP6RrhfH2HYqTVt8mCL/ltq/w53l7NRd55QG1pkt6ZYeeGc91utCk4OjNLILoWXQFZJMK3/bNnlpDf26Q9fI7zJJhkCR72O/Mu9MU4UWZpqEFZXeh9D1GluVCFpy/5oRX2jeZxdrKQeGYrIGGEGoK7KQus7ZRCoBMTuFptqoQbhhfiFkONPW8EPIcDbHVz+KiDEqBEl3eTfawhVgkUNGM79pUHyWKkWcqQZ+rgUGqdOZwXgpS0j4o+I8+NfDGKlZ8o3pLifvgAS3VNpP6GlivP+i3ociGhtO+vINUvQgtyy2lN/lSczx9HKhCg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=eT6iXaQc3RMthVr2sw0305P3eeirgYve/gKbMKpQ+Ko=;\n b=lxj3PTB0eKI4f+nXu82A0MOf3G+2wj8n0qdN0vpcqBmWHQHjcpHmQpdkXKPqfYXIN/Xmhbkpdm3A1kGoJGt0a2BimKme+DqerNMeO1SK9UAzXLIB2wKzcKmx4X4G0OLWEuL/P4ZhDjmHilHlGqNc5oTZZoGznQbzMmNnKT5xFZ/N84fwQ8dP9NR1GAWl9dpB989zGHwQznpIXIkvwSIcoBuLTKIP5aDMkfiSPbMCgtOXvLVRVlK3pRwx6+IoSnUIAzVBJBSiB/r9OS5rrwqGY/TfU3d0o2Z+yIvAITsbHxu4iaBeTUPrA1La3KROx+M/1zsjt8qzgQMVzPdYxA+sUw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=aspeedtech.com; dmarc=pass action=none\n header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=eT6iXaQc3RMthVr2sw0305P3eeirgYve/gKbMKpQ+Ko=;\n b=OvQqnA4Pk/SL3Nh8y3tFAB7ia1zSJn8IkrXUpDs0Ir71AI/QKXZE0iPysE3GX6oLUBMLtvu1ABxcv7KJqhXvsmA2MEnLN3TdPBZt78+SMWbbfinJ3qr6mbhMnOkMYD3mou3TegNErzQfmn578mo8vuSM9/9nerp7lfMKwJDg4120fvRXJ1xLvsCjjUpYJzND0cfkaj+xMoPBoq6i671qcSRvc8LDVDbLuqtPaH36O5T3m2NWXiIoheR+Y/7bopr8NplsIuSNHYz6o2daTHLUzbHNYs6ZgisgIjYOXlZ8MKkO7A4e7zHHub3i0S+8SGl6DNKj5JXlW1xaGdFyOlz60g==","From":"Jamin Lin ","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?C?=\n\t=?utf-8?q?=C3=A9dric_Le_Goater?= ,\n Peter Maydell ,\n Steven Lee , Troy Lee ,\n Kane Chen ,\n Andrew Jeffery , Joel Stanley ,\n \"open list:ASPEED BMCs\" ,\n \"open list:All patches CC here\" ","CC":"Troy Lee , \"flwu@google.com\" ,\n \"nabihestefan@google.com\" ","Subject":"RE: [PATCH v2 06/17] hw/usb/hcd-ehci: Change descriptor addresses to\n 64-bit","Thread-Topic":"[PATCH v2 06/17] hw/usb/hcd-ehci: Change descriptor addresses to\n 64-bit","Thread-Index":"AQHcy+TF38PfbBLNdk+9bahbf3ZsMbXeSLYAgAEDmxA=","Date":"Wed, 15 Apr 2026 00:54:08 +0000","Message-ID":"\n ","References":"<20260414080025.3005916-1-jamin_lin@aspeedtech.com>\n <20260414080025.3005916-7-jamin_lin@aspeedtech.com>\n <7eb32749-dd83-48ea-94a4-41935cc90aca@linaro.org>","In-Reply-To":"<7eb32749-dd83-48ea-94a4-41935cc90aca@linaro.org>","Accept-Language":"zh-TW, en-US","Content-Language":"zh-TW","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=OvQqnA4P;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;"],"x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"TYPPR06MB8206:EE_|TY0PR06MB5578:EE_","x-ms-office365-filtering-correlation-id":"03025f96-9133-4185-c7b0-08de9a898006","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|1800799024|366016|7416014|376014|921020|38070700021|56012099003|18002099003|22082099003;","x-microsoft-antispam-message-info":"\n H0XIlrdM3uVn7e/+qSpE9PuE4osbcLeCn+JABvijSfxJbkNG1O7yV+zxii1cdazeA0wVUpC8bAXWe/8ZqazrUS96NmHEi1JYz4+rUliiY7NvU4LFGP2UcxiIFsWahrxpj7QfpvoJCZ78TchKy4gYR3Y1YxI7vNDroIc52M9eP1olV4hE5K+Sm6qX5GKwQwmo9UpFiPeRvcBb/LWRQaOzw9aH7oEy9iMLRQ3z5O9gCU/n64I4I6gBUIct40CV7KRwcqo31Pj6jIJ0qzwgymHAbpskHc8HIFaFNE7OIIOYiyl/wRQ955VvOB0KzxIsWrTe2hQkzvw2jF8O+twJ9sJY0c526eyiefOC2pkZ46mBdID4w1Tgb4XNz4kKCXNeA/rskiFZhtzvTjCck0OEQffzjbAMBCHn2SnPxEx0/se/bgyMTsYUH1MM8Ji5IJAoA1A60udF1JMHIKhXnuEoBW1+B2skTcYTbeEohod5m+RcKW1AuuSxLFK23dZED4OEPRth9nDpS/VyuhxYNiBodEVNiHwvXF0T5zX47eG5vb+oFK8vmYqGgw781QFpnx+KmKyZh4T2u7EGrROiKJtaU/4yJ5R3dq1mKQ2sBuHyI82vK3m7W1c6z4DgJWv9bC+O34KEyYKjszCSCg+KwqCgswPO9PmoAeSgrWtnbIwtpOYlfPDX4RyBFGTZmDjQF98BQAcCNe2F1TPko4LeZknDposyJ396pdHjlZjIYZKgODCzGkb2YYdZIUc/clpYk9iSOp9ieC91pHn6BTZ90P9/3s9EeNr9F/aJ2bR37eA7mXPkkk7oWLYQ3WNWlO2wKsjHzeV8","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:zh-tw; SCL:1;\n SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:;\n CAT:NONE;\n SFS:(13230040)(1800799024)(366016)(7416014)(376014)(921020)(38070700021)(56012099003)(18002099003)(22082099003);\n DIR:OUT; SFP:1102;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"=?utf-8?q?QJ68h5Zt1HdPuD7GDQQYTkeDBssJ?=\n\t=?utf-8?q?xcrSctswBaWm8xE+fy5QnY4ldXszaOaPRYGxq6mi8BnvfAT8LytcKH93poI3B6Ik0?=\n\t=?utf-8?q?Nj9PBS225YkHYleP/dEE8w3LO2+fbxBeEIPRg3mog/PPCRt4+R2AnJ5LOcAUZU5dR?=\n\t=?utf-8?q?Miimf6c2KJtlxw6rkrOD0gANaLVP51UDSKEWh6NA5+guVu+5EyOasN5N+8nOVl12a?=\n\t=?utf-8?q?HH43DaMqlYIv+vnF6NYzaegWvmwK4tNQ3K5sdcd1lktJk3gx54fHTH5aQCm1tEH9r?=\n\t=?utf-8?q?pMQjMZBTnLWq7JnCLFPGoLl/FivN3PvpIFT9sqW3I0DzmiTyzKFhrSnX7bvpf7/Dc?=\n\t=?utf-8?q?99RklPWDy+AUbNQFcV4hdHZhuLxxYVee+ndqhll/BMWTaefBXNc0oJRajkg2CmxZU?=\n\t=?utf-8?q?8E7US+P95lBX6cL7qI3G1VW+2CGI1Hj2NzFeuZ4M2gx7ugKjqGqDzvFqo5xe6SJ/Q?=\n\t=?utf-8?q?QTLECliJ3Rpvpeghk70eKS1AaXKLjyb5eYw9YlhDECRFCv7uPfe4f4gpu6LLvWT4Y?=\n\t=?utf-8?q?81ZCiZxFn0CHvL1Y1hRd80G3pJPpxJSc+5DOCgoqjeq/kPUIVV3KKO3zsQ0C72DzO?=\n\t=?utf-8?q?/qE14AAay38J9XCttZF3K9DqHI4w3gorW6xVObKDU2wtMCmxndZEJDwkTQI+BJ/i0?=\n\t=?utf-8?q?xiBnTjjA2UfWeCGvMjrRexHGUhr8pYzFt9Gnuu00vBqMxWyQke8YHKO2R5WtFboJ3?=\n\t=?utf-8?q?pmaKtH0DOZq3Lky8CeCCE2nbRYZDH/GVLpQ+sz3LfyeJMhVw1RqQAirLgovtRDKAy?=\n\t=?utf-8?q?l7g8sLBsH+YZ1nclU0VLdlPBF+s2k6CMPWa1SfHzHy1lWcpurzgDxbzo9LfRJVC+U?=\n\t=?utf-8?q?XZQle+wumXWlasfBjeWd1LUghx+u5oy9b8LJWJwegTWxEkg1m6iWS+XjfW79ATsGj?=\n\t=?utf-8?q?bFoS2VIERJ/Ej+kZdzcrelcxFMIseDuAVjSdJ7O0Ht1fKugoGjf+lOhlASnEwZ5LX?=\n\t=?utf-8?q?5nolqkr5Bz1DbZjxP8nKfYYW16368VZo1eNRDkTxe4SUcvfqeFSPBaGeqpujISK8S?=\n\t=?utf-8?q?xgQlQxneq4xAYGDI3jJZXcyiQ+hFfRbQ0Ij+TT5WOtqsr4YAlGR6OCn0bBCYRDGB+?=\n\t=?utf-8?q?ilKOtvmPjEjvDGUnvn4OoPP7eDNcb8JQgWtZqIWmEgjEZ7KMeOSvDgvd1nLR2IWpK?=\n\t=?utf-8?q?8Zq9VVfyr/+lLuQIh6q66SBxFPnOj3piQolMEPunO52XayswmO3yGHIsjvm2RQlUr?=\n\t=?utf-8?q?EdGCWzWEN/IRFar6zOzUXwAVxqhYGhOzDeFBTQjwcnoTqtW76Xn0GgjLoOnNBdLeY?=\n\t=?utf-8?q?zNoDAgue9jDzaKD9osTayAftK+EDZasPYVNjMyER4KCnQ+JFi/bbHhZF6cBh+d+PH?=\n\t=?utf-8?q?hzFS9RajSvuhFY0Rwr0829zlQ/vvTKRebnepD1QYnR80vO7AQsqxhEUn1ZQbtM6O0?=\n\t=?utf-8?q?2YOo1C1/xJm2MrgaqpT6zZXfDWEASW20BA2JllmtHHxv+HR0vSDLbElyHpkTrPTRu?=\n\t=?utf-8?q?bXfFj0P71P7RvkUChlyEGm8lpwspGtdmYE7c/IL3i8UiweMEErGoD2GPiKtT2QOgS?=\n\t=?utf-8?q?wovcm+B5N95jm1IgMDcAXhJLxyiwBe7OYRs99LVWmx4GOOODQssdPTucSGgIXGA3Z?=\n\t=?utf-8?q?P2Q6xYCvE9hYGVi2LBz6mt3qCsntdUiDm9Q4cul6a2OMLPgQn21tuyG+ENFmXRhKM?=\n\t=?utf-8?q?3zJ+kiiWekod8Pf+sevA1mPqIyPjaGwg=3D=3D?=","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","MIME-Version":"1.0","X-Exchange-RoutingPolicyChecked":"\n CykWAbyQV3LnshDy2+hWIVhOAgGFcqz/RjJX6xnWK5Au4B6nrkEnJYus3o0v4QNXc7g6dxdmoxqg5LMqN/dcqPaozAbkXz6mBRXX50mWOJ/KTVajFGtzBQJgllFqTmpT9bmWRNdqiiyPKlcLxuGmuxXO1/sxUAsqQOWMEvdYv8vTYwazyHI5q6p6/UXt3VMe3Zpqo+NoZhlmuaeo/ELCxVcQo4V4+rcKMVVSA89kYsk2vbZjHhQ7pVJO1wKgldci9AqF02Ms5cVj68LHNxTdRwqwRfJj3LFY1JSN1E9PjLuBz/kCvsDZHix9NmpJkEyEixXShhbCVj7TakgQdvPK7Q==","X-OriginatorOrg":"aspeedtech.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"TYPPR06MB8206.apcprd06.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 03025f96-9133-4185-c7b0-08de9a898006","X-MS-Exchange-CrossTenant-originalarrivaltime":"15 Apr 2026 00:54:08.1817 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"43d4aa98-e35b-4575-8939-080e90d5a249","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n oMbHhz9LZh8e6k7jRjPXpL5ajWGKbJqbVujjKNjXqgJ2XuTlgM5fMFI1jZbw47Ikix2IyF1kBQMOr6BaLF6Jd2cB5l1To+OVtYjXByz82d4=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"TY0PR06MB5578","Received-SPF":"pass client-ip=2a01:111:f403:c405::5;\n envelope-from=jamin_lin@aspeedtech.com;\n helo=TYPPR03CU001.outbound.protection.outlook.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]