[{"id":3677044,"web_url":"http://patchwork.ozlabs.org/comment/3677044/","msgid":"","list_archive_url":null,"date":"2026-04-14T07:24:00","subject":"Re: [PATCH] bitintlower: Handle BIT_FIELD_REF load [PR124826]","submitter":{"id":91428,"url":"http://patchwork.ozlabs.org/api/people/91428/","name":"Andrew Pinski","email":"andrew.pinski@oss.qualcomm.com"},"content":"On Tue, Apr 14, 2026 at 12:19 AM Jakub Jelinek wrote:\n>\n> Hi!\n>\n> The following testcase ends up with a BIT_FIELD_REF from a VECTOR_TYPE union\n> member to _BitInt(256). gimple-lower-bitint.cc already contains code to\n> handle BIT_FIELD_REFs with SSA_NAME first operand to BITINT_TYPE (for\n> constant index limb access by adjusting the BIT_FIELD_REF to use different\n> bitsize and index, for variable index (huge _BitInt with limbs accessed in a loop)\n> by forcing the SSA_NAME into memory), but that doesn't trigger here, because\n> gimple_assign_load_p predicate is true on it and so it is handled as load\n> and not BIT_FIELD_REF. Anyway, the problem is that we end up with\n> _7 = VIEW_CONVERT_EXPR(BIT_FIELD_REF )[_2];\n> which tree-cfg.cc verifier doesn't like because BIT_FIELD_REF is not\n> toplevel reference in there. The following patch just strips the\n> BIT_FIELD_REF away if it has zero bit offset, that is the only case I've\n> managed to reproduce, and in that case we are still later on using VCE to\n> convert to array and using ARRAY_REF on that. If offset could be non-zero\n> but multiple of BITS_PER_UNIT, another approach would be to replace\n> BIT_FIELD_REF with a MEM_REF. Anyway, as I haven't managed to reproduce\n> it with anything but 0, the following patch is enough.\n>\n> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?\n\nOk.\n\n>\n> 2026-04-14 Jakub Jelinek \n>\n> PR tree-optimization/124826\n> * gimple-lower-bitint.cc (bitint_large_huge::handle_load): Look through\n> BIT_FIELD_REF with zero bit offset.\n>\n> * gcc.dg/bitint-128.c: New test.\n>\n> --- gcc/gimple-lower-bitint.cc.jj 2026-03-27 10:17:14.164330250 +0100\n> +++ gcc/gimple-lower-bitint.cc 2026-04-13 18:41:02.149286578 +0200\n> @@ -1985,6 +1985,10 @@ bitint_large_huge::handle_load (gimple *\n> edge eh_edge = NULL;\n> gimple *g;\n>\n> + if (TREE_CODE (rhs1) == BIT_FIELD_REF\n> + && integer_zerop (TREE_OPERAND (rhs1, 2)))\n> + rhs1 = TREE_OPERAND (rhs1, 0);\n> +\n> if (eh)\n> {\n> edge_iterator ei;\n> --- gcc/testsuite/gcc.dg/bitint-128.c.jj 2026-04-13 18:49:40.292517820 +0200\n> +++ gcc/testsuite/gcc.dg/bitint-128.c 2026-04-13 18:49:04.001131057 +0200\n> @@ -0,0 +1,27 @@\n> +/* PR tree-optimization/124826 */\n> +/* { dg-do compile { target bitint } } */\n> +/* { dg-options \"-O2\" } */\n> +\n> +typedef float V __attribute__((vector_size (16 * sizeof (float))));\n> +\n> +union {\n> +#if __BITINT_MAXWIDTH__ >= 256\n> + _BitInt(256) b;\n> +#endif\n> + V v;\n> +} u;\n> +\n> +void\n> +foo (int c)\n> +{\n> + u.v -= c ? 0.f : 1.f;\n> +#if __BITINT_MAXWIDTH__ >= 256\n> + u.b *= c;\n> +#endif\n> +}\n> +\n> +int\n> +main ()\n> +{\n> + foo (2);\n> +}\n>\n> Jakub\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=ptMhdygY;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=NLcF2pv/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=ptMhdygY;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=NLcF2pv/","sourceware.org; dmarc=none (p=none dis=none)\n header.from=oss.qualcomm.com","sourceware.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=205.220.168.131"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvwlN6zgNz1y2d\n\tfor ; Tue, 14 Apr 2026 17:24:47 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 6A0004BA2E13\n\tfor ; Tue, 14 Apr 2026 07:24:45 +0000 (GMT)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n [205.220.168.131])\n by sourceware.org (Postfix) with ESMTPS id 738A94BA2E0D\n for ; Tue, 14 Apr 2026 07:24:15 +0000 (GMT)","from pps.filterd (m0279865.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63E6CCLi3425588\n for ; Tue, 14 Apr 2026 07:24:13 GMT","from mail-dl1-f71.google.com (mail-dl1-f71.google.com\n [74.125.82.71])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dh87f9jev-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for ; Tue, 14 Apr 2026 07:24:13 +0000 (GMT)","by mail-dl1-f71.google.com with SMTP id\n a92af1059eb24-12c283a1212so17746901c88.1\n for ; Tue, 14 Apr 2026 00:24:13 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 6A0004BA2E13","OpenDKIM Filter v2.11.0 sourceware.org 738A94BA2E0D"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 738A94BA2E0D","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 738A94BA2E0D","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1776151455; cv=pass;\n b=tPTsKJDUjLm3TPOlK33KB60ZAAYcs1uUjzbjkhLVrv8rXOVZY5P6PhH3dyRrfP2hjpnMrX5zD80UJj9kzuC2A1MK+pr+gHb9eFquKmiFUb7abAZG1IZku7wfq0aWPswFzrQNRjCEOYojT+rCwxOaA3zpBf66qezCARqdQc0qdkQ=","i=1; a=rsa-sha256; t=1776151453; cv=none;\n d=google.com; s=arc-20240605;\n b=V093RffNO4LssnT0Fawz/GTMqYW7VFik2cnr2JvRpDqyeSP5VuOVeJbzI8CV/7100Q\n OVI1Q9zg6J8LvkmFymUGorJpXGJRLB5oJInFkcqLXfajdSQJ7Ipx4ho3g6LE+8lkBubp\n xor+0fSwNFdvKcMcgNl3aOTOuzvPihamTKZ6bB/QLf3AcMLXUGRy1cBEJZuTm7oyyUgt\n UhORLT5w9t6H7RPNUPpYRZmrZMCchpS6G+1sjrYI0SZLSIsNXaMGaVIVthumf7IT4iKB\n jWCX4LRhqjPoMjcLfmkJXyH1vPkEMTA6gi38JkLr1A7u9VWg+TZgkqbMnPlHrpYBLAwC\n xmQg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776151455; c=relaxed/simple;\n bh=mxr5cpLFBWRRCGRJYMlunMY44Hqg7stfyZ2vC2yzBv0=;\n h=DKIM-Signature:DKIM-Signature:MIME-Version:From:Date:Message-ID:\n Subject:To;\n b=OZwaA/0gVWrRj70Y8v2lbyt/BKVBBRQwd1rjoMBCh3+D63aWgMt0LEwGHl9GzRiJjjn/BbL/iakR299L26KN7+OW7GRqNNFUwDhQGGgF7iEuU6wVpLjeLO65MADx+o45NAJydkNEc4B9mA2zWMn8gFik4Cz4bGThCECtPGJgUZg=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=r2WzNBcKOhUzmSwfEbY7fwNJKQw+RutkKbC1ECaB43I=;\n fh=iugRpHu2iVKB3G9+YfIAoK/jVzl8fPWXAOBXX7lA+Dw=;\n b=FXvZ35+cxwskM0OvtBYPKQHgU/5irbftNC6PlZevxZAeJj1zC5alfHPVFg8b/tzEej\n jEARiPHs5S26BDPAHtugVqKBwDODkddP2cQGOltC99r48hE8Uo2P8vDlN6tuZfzlopVi\n pAZuqM0guku6rzih0rODpTuaH7qrSQfeUCXG+9D/s38VFE8iCcWZxgEG80apmirq5a1a\n FLff5RW19SjBgETicrcuHepXhdQs/JI404h+UDcq/wvsuw2lo0/fGdFOdZ2ykGAYOoj7\n kEEQLUc++gQUYC9/eGfJUCo9g4Y+G41vrBcswm7YKLwhHvKxproviOnyyygtvHsT+lXz\n Er5A==; darn=gcc.gnu.org"],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.google.com; arc=none"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n r2WzNBcKOhUzmSwfEbY7fwNJKQw+RutkKbC1ECaB43I=; b=ptMhdygYD07ehJNS\n 4pxXE/zrybnP0ctsM9f0qejUZX3cNmKUIjE0m4OTxXULXlFcowcPNMf9bIxpWdP6\n xLpJc2g61KomJ1O3hJNIuBoEllnLg54iCJKAZXWo8320RLFLh4jlTb5euQ4m84m5\n RoazTENe0TdF3rHGCDnSymFuqJptfytVzStqijAGpvT3Xy9PFRC2jpuwgLnEtld8\n 51PYXMzx9eSDpUig1N/IBQn0iTE50d0AIIRKZ2jlr3++sfM8IPJp2QmbAimlOrXs\n OS36vLDmolMlD54oJiAbjIyTQiL4aW33G6QVxD2U/q4V8SK+TkByOu8PqZXrDiV9\n F3/7Vw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1776151453; x=1776756253; darn=gcc.gnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=r2WzNBcKOhUzmSwfEbY7fwNJKQw+RutkKbC1ECaB43I=;\n b=NLcF2pv/C6b8js7O/hfxx90+LwkDuyGAZs4Nfc6tHO+bKEd92xxHuPa+UCZ7EzPAix\n haYZ5sVjeXB4BLiSyiV7wbHEYAE5SVzJ5Dre3FdKLi8AkPr8WMpgZveAt+zbPEWZXXUV\n 0WzNJ4qcf0bvtgxoFzuzlMMbHs0BKPomoNOJKU7qdVkSmklDL1CfDjm7iGmlLBpnY67Y\n F3PKnA2yatO3aEYRUJAEnTaPjZtkU5fCLDavh+OhVCqs+HrLZOeKIG49Rgl9ujStfIhD\n BFD1Aoj3RQ9R6Vh8eWnja41xTY2sK5h5HZwyeYCAnlLRPwfySHfThmFPXyn5moPzXt2t\n dZsw=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776151453; x=1776756253;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=r2WzNBcKOhUzmSwfEbY7fwNJKQw+RutkKbC1ECaB43I=;\n b=DYY2gdZM92Nw0cEInp1AC5NYBuRWTVqvE+R6wWo28/Kt6FgUX4EP3SYeD/yBDLhlyy\n r55Kk3L69k2DIGXDQ1uU5Qo82e1bkOWoUSWarimHLAL6MhMY/5I3O08YFvnRxMb1wsf9\n oooaS/X3b976+nFLawRfm/KDn8fRTdQmSCqz5vS63MVi3r9zg645AzQLCV6ATUZvhVyk\n zE/Xo9tv0bvmlxaosy82Bt5TKmXMSNmE6zwKW8noZtovA0THxelmYjAcIqe1EXbEXjTh\n DHMC9DKrHeAue9/VxLWHnmTFTzCaHxS4qw7pg9IC5uoLho6xct3zyO5SksycNW1rB2fJ\n b6gg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8s1tzE1XBgJbycOQqiiwz1wo/c9C+Qn1Z1BsbOxK4bDCa7JbMb23jHBzjZng5HuOwuuaSMh1E8Z0EfYw==@gcc.gnu.org","X-Gm-Message-State":"AOJu0Yw4f7VHd0h2gLGaeKh5Cq8T4LyHjKG4NMk+CnTusKmY+CqGpsQl\n FjXCdZMKGDcTmw5bHnQI3V4T8Fmx7dL9vwDLh12sJHDVd3YsFvwlJc3ITPqcLPNpt9yaWwVOJhe\n 0wSHz+nU9qP5Gn5MncxAmhShbF6XVnXM2wD8Md4tKhaEOP/DEXJVGznh93AFqPEjC5DfI31v4wf\n oIgDtNkyUtkE2W2cVmBwIUzSUFIxqWecghkGg=","X-Gm-Gg":"AeBDies27KMBrhEjkX+m95YZ3anOJm7rIfKWUoia2Hh15eHQfcIi1+I5ahuBgtimqZu\n leKl8spGLOm9XPlXCRVTPeddga1szDoqPdY7P+SaeimWYp40ESyktOWie9DiMd2hZ+0rxbMftyY\n z8Abg0s+K/2SNRjejjg2XrRJIEXb8r3/URGgCuTMx19U8tpOmCPFdJbXzqLXNZcxSSCxjYGwSlb\n efe","X-Received":["by 2002:a05:7022:2581:b0:12b:ec96:c936 with SMTP id\n a92af1059eb24-12c34eab249mr9791597c88.14.1776151452911;\n Tue, 14 Apr 2026 00:24:12 -0700 (PDT)","by 2002:a05:7022:2581:b0:12b:ec96:c936 with SMTP id\n a92af1059eb24-12c34eab249mr9791576c88.14.1776151452280; Tue, 14 Apr 2026\n 00:24:12 -0700 (PDT)"],"MIME-Version":"1.0","References":"","In-Reply-To":"","From":"Andrew Pinski ","Date":"Tue, 14 Apr 2026 00:24:00 -0700","X-Gm-Features":"AQROBzBTVA8kx--Pie11bpWVBIVsdq_jX0WB_7CW27Nba-AIHzgrtw7gPMQQ7h4","Message-ID":"\n ","Subject":"Re: [PATCH] bitintlower: Handle BIT_FIELD_REF load [PR124826]","To":"Jakub Jelinek ","Cc":"Richard Biener , gcc-patches@gcc.gnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDE0MDA2NiBTYWx0ZWRfX9SuUiWUeTfs6\n hA+cTKsM5N0ZHuyo9d/NoPbtMYKcYvcONccJvaAyQGYGh3TTJTcGVXHcqZTE+vg9CsFSaX67zCL\n yrCyiKZwY0CuDiE6imYUWJ8Tqxsip8+oggMs8v0P3G0xv0gHi+kBg1xpixHmv8EMFQbCJlnY0JN\n mo3CvbBdwR2sjHxQyTTsszm3/kf6a6twOGTruun5Q6V9/tCjcmyQmRhfwM/3XOlzc2LQvBrgv7F\n J2gAJtfVGF+NlgXg1b0KDOlpItW+EjwxIhPafafXXrmM6huOIzMPV8UwcJ1gs9NiQhp+mkfyhPp\n sljYI9LjPOycV18xcAtCjpJQWYko+HCRXeHbfBdwOaYNoR3jT9MtdIWNPrmww143dBJW6o/1/hh\n lj89o4/gzffQ0tcz3r8mgM1vfgKfWJuXUwZiaQRyCAgzKECYzwF8dk/zZ+5+nPh0NCIICk+ygtJ\n ZmH8wsr/SgB0Jeq/ZqQ==","X-Authority-Analysis":"v=2.4 cv=DaYnbPtW c=1 sm=1 tr=0 ts=69ddeb9d cx=c_pps\n a=JYo30EpNSr/tUYqK9jHPoA==:117 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10\n a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22\n a=Um2Pa8k9VHT-vaBCBUpS:22 a=20KFwNOVAAAA:8 a=PW3H7bOWHYLjv4ebEvgA:9\n a=QEXdDO2ut3YA:10 a=Fk4IpSoW4aLDllm1B1p-:22","X-Proofpoint-GUID":"AmvMxy6ZjAOaZwyzBzsrcHcfU4RH6Ia_","X-Proofpoint-ORIG-GUID":"AmvMxy6ZjAOaZwyzBzsrcHcfU4RH6Ia_","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-14_01,2026-04-13_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n impostorscore=0 suspectscore=0 malwarescore=0 phishscore=0 priorityscore=1501\n bulkscore=0 clxscore=1015 adultscore=0 spamscore=0 lowpriorityscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604140066","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]