[{"id":3677053,"web_url":"http://patchwork.ozlabs.org/comment/3677053/","msgid":"<177615350902.422580.9843903543628073938.robh@kernel.org>","list_archive_url":null,"date":"2026-04-14T07:58:29","subject":"Re: [PATCH v4 05/13] dt-bindings: mfd: s2mps11: add documentation\n for S2MU005 PMIC","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Tue, 14 Apr 2026 12:02:57 +0530, Kaustabh Chakraborty wrote:\n> Samsung's S2MU005 PMIC includes subdevices for a charger, an MUIC (Micro\n> USB Interface Controller), and flash and RGB LED controllers.\n> \n> Since regulators are not supported by this device, unmark this property\n> as required and instead set this in a per-device basis for ones which\n> need it.\n> \n> Add the compatible and documentation for the S2MU005 PMIC. Also, add an\n> example for nodes for supported sub-devices, i.e. charger, extcon,\n> flash, and rgb.\n> \n> Signed-off-by: Kaustabh Chakraborty \n> ---\n> .../devicetree/bindings/mfd/samsung,s2mps11.yaml | 121 ++++++++++++++++++++-\n> 1 file changed, 120 insertions(+), 1 deletion(-)\n> \n\nMy bot found errors running 'make dt_binding_check' on your patch:\n\nyamllint warnings/errors:\n\ndtschema/dtc warnings/errors:\nDocumentation/devicetree/bindings/mfd/samsung,s2mps11.example.dts:241.29-39: Warning (reg_format): /example-2/i2c/pmic@3d/extcon/port/endpoint@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)\nDocumentation/devicetree/bindings/mfd/samsung,s2mps11.example.dts:246.29-39: Warning (reg_format): /example-2/i2c/pmic@3d/extcon/port/endpoint@1:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)\nDocumentation/devicetree/bindings/mfd/samsung,s2mps11.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format'\nDocumentation/devicetree/bindings/mfd/samsung,s2mps11.example.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'\nDocumentation/devicetree/bindings/mfd/samsung,s2mps11.example.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format'\nDocumentation/devicetree/bindings/mfd/samsung,s2mps11.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'\nDocumentation/devicetree/bindings/mfd/samsung,s2mps11.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format'\nDocumentation/devicetree/bindings/mfd/samsung,s2mps11.example.dts:240.53-243.27: Warning (avoid_default_addr_size): /example-2/i2c/pmic@3d/extcon/port/endpoint@0: Relying on default #address-cells value\nDocumentation/devicetree/bindings/mfd/samsung,s2mps11.example.dts:240.53-243.27: Warning (avoid_default_addr_size): /example-2/i2c/pmic@3d/extcon/port/endpoint@0: Relying on default #size-cells value\nDocumentation/devicetree/bindings/mfd/samsung,s2mps11.example.dts:245.49-248.27: Warning (avoid_default_addr_size): /example-2/i2c/pmic@3d/extcon/port/endpoint@1: Relying on default #address-cells value\nDocumentation/devicetree/bindings/mfd/samsung,s2mps11.example.dts:245.49-248.27: Warning (avoid_default_addr_size): /example-2/i2c/pmic@3d/extcon/port/endpoint@1: Relying on default #size-cells value\nDocumentation/devicetree/bindings/mfd/samsung,s2mps11.example.dtb: Warning (unique_unit_address_if_enabled): Failed prerequisite 'avoid_default_addr_size'\nDocumentation/devicetree/bindings/mfd/samsung,s2mps11.example.dts:240.53-243.27: Warning (graph_endpoint): /example-2/i2c/pmic@3d/extcon/port/endpoint@0: graph node '#address-cells' is -1, must be 1\nDocumentation/devicetree/bindings/mfd/samsung,s2mps11.example.dts:240.53-243.27: Warning (graph_endpoint): /example-2/i2c/pmic@3d/extcon/port/endpoint@0: graph node '#size-cells' is -1, must be 0\nDocumentation/devicetree/bindings/mfd/samsung,s2mps11.example.dts:245.49-248.27: Warning (graph_endpoint): /example-2/i2c/pmic@3d/extcon/port/endpoint@1: graph node '#address-cells' is -1, must be 1\nDocumentation/devicetree/bindings/mfd/samsung,s2mps11.example.dts:245.49-248.27: Warning (graph_endpoint): /example-2/i2c/pmic@3d/extcon/port/endpoint@1: graph node '#size-cells' is -1, must be 0\n\ndoc reference errors (make refcheckdocs):\n\nSee https://patchwork.kernel.org/project/devicetree/patch/20260414-s2mu005-pmic-v4-5-7fe7480577e6@disroot.org\n\nThe base for the series is generally the latest rc1. A different dependency\nshould be noted in *this* patch.\n\nIf you already ran 'make dt_binding_check' and didn't see the above\nerror(s), then make sure 'yamllint' is installed and dt-schema is up to\ndate:\n\npip3 install dtschema --upgrade\n\nPlease check and re-submit after running the above command yourself. Note\nthat DT_SCHEMA_FILES can be set to your schema file to speed up checking\nyour schema. However, it must be unset to test all examples with your schema.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-rtc@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=s8RdcM1Q;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-rtc+bounces-6331-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"s8RdcM1Q\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvxXT6NVKz1yDF\n\tfor ; Tue, 14 Apr 2026 18:00:25 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 28AC930086CC\n\tfor ; Tue, 14 Apr 2026 07:58:32 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 8E038387569;\n\tTue, 14 Apr 2026 07:58:31 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 6758B382F00;\n\tTue, 14 Apr 2026 07:58:31 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id D90D0C19425;\n\tTue, 14 Apr 2026 07:58:30 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776153511; cv=none;\n b=bm0DMX2ZK2U4OwcoiXJQnzndSiFCKnyQZLTKvJrdVB+N4k7O/6DVMHJMcaP2Ww3GsKJjMDdjPqB6zObOuMfqDYQgAvg/RYriPIInJQ8s5KdkvixxhFLuiTIP73rLQj0ebowbW8Dldl4ow36oa4Ss6oqymUvVMuis5a/Aw/pUh44=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776153511; c=relaxed/simple;\n\tbh=GnyG5msXBP+YBGkuMAE1tNpBGQFgvLOi3k5F4gox66Q=;\n\th=Date:Content-Type:MIME-Version:From:Cc:To:In-Reply-To:References:\n\t Message-Id:Subject;\n b=U+97VmpOS19LMGZMXqTcpMric9yonWDsS3cdTPEdn/3rEhTYWp5r8no6DpJK//CGe/mk8zPOefF4UBnkSAU1E+DTIpYfCjzVz1Du4IhG5Fpg2nel8lxFQE/SG5jwZqN7AjjJnmpMhzlbjJpgrScqWpy4/CguY4yLwhllK87vF5E=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=s8RdcM1Q; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776153511;\n\tbh=GnyG5msXBP+YBGkuMAE1tNpBGQFgvLOi3k5F4gox66Q=;\n\th=Date:From:Cc:To:In-Reply-To:References:Subject:From;\n\tb=s8RdcM1Qay/Tt56OSH//nhypfv5U4TNTCJVbLdqBGAKCJ6urGmxk02GAezvxUr8Rb\n\t ZLCREz/03HdV9iidslkLRQZ1RF4LFlxcFdANPFaWVN2Cuq3nPthE5bemgHzFIhC2VX\n\t ULnKmnvR7ILxa/G1rGfBxowLyfpJxN9lLj4taNPmDktFIXNUSTM/lLMN3cPFD23ZcC\n\t N1eFLtrqINUhWcG0kZfqQ50hPulKskFiunX5ydZMTIaibFuJJsJOyFnAafxmItdJAN\n\t 7XIGeN25xVG+zpUziqje1TRQCpIVho1yDSGhoIu7zrpBrWEyCjr403WFpUKIQJi1KY\n\t XlNQi1UKH0OiQ==","Date":"Tue, 14 Apr 2026 02:58:29 -0500","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Precedence":"bulk","X-Mailing-List":"linux-rtc@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","From":"\"Rob Herring (Arm)\" ","Cc":"Conor Dooley ,\n Krzysztof Kozlowski , linux-rtc@vger.kernel.org,\n linux-leds@vger.kernel.org, Jonathan Corbet ,\n linux-pm@vger.kernel.org, devicetree@vger.kernel.org,\n Pavel Machek , Nam Tran ,\n linux-kernel@vger.kernel.org, Shuah Khan ,\n linux-doc@vger.kernel.org, MyungJoo Ham ,\n Alexandre Belloni , =?utf-8?b?xYF1a2FzeiBM?=\n\t=?utf-8?b?ZWJpZWR6acWEc2tp?= ,\n Chanwoo Choi , Lee Jones ,\n Krzysztof Kozlowski , Sebastian Reichel ,\n\t=?utf-8?q?Andr=C3=A9_Draszik?= ,\n linux-samsung-soc@vger.kernel.org","To":"Kaustabh Chakraborty ","In-Reply-To":"<20260414-s2mu005-pmic-v4-5-7fe7480577e6@disroot.org>","References":"<20260414-s2mu005-pmic-v4-0-7fe7480577e6@disroot.org>\n <20260414-s2mu005-pmic-v4-5-7fe7480577e6@disroot.org>","Message-Id":"<177615350902.422580.9843903543628073938.robh@kernel.org>","Subject":"Re: [PATCH v4 05/13] dt-bindings: mfd: s2mps11: add documentation\n for S2MU005 PMIC"}}]