[{"id":3677047,"web_url":"http://patchwork.ozlabs.org/comment/3677047/","msgid":"","list_archive_url":null,"date":"2026-04-14T07:25:20","subject":"Re: [PATCH v4 08/13] mfd: sec: resolve PMIC revision in S2MU005","submitter":{"id":88698,"url":"http://patchwork.ozlabs.org/api/people/88698/","name":"Kaustabh Chakraborty","email":"kauschluss@disroot.org"},"content":"On 2026-04-14 12:03 +05:30, Kaustabh Chakraborty wrote:\n> In devices other than S2MPG1X, the revision can be retrieved from the\n> first register of the PMIC regmap. In S2MU005 however, the location is\n> in offset 0x73. Introduce a switch-case block to allow selecting the\n> REG_ID register.\n>\n> S2MU005 also has a field mask for the revision. Apply it using\n> FIELD_GET() and get the extracted value.\n>\n> Signed-off-by: Kaustabh Chakraborty \n> ---\n> drivers/mfd/sec-common.c | 18 +++++++++++++-----\n> 1 file changed, 13 insertions(+), 5 deletions(-)\n>\n> diff --git a/drivers/mfd/sec-common.c b/drivers/mfd/sec-common.c\n> index 883e6d0aa3f06..43215605191e4 100644\n> --- a/drivers/mfd/sec-common.c\n> +++ b/drivers/mfd/sec-common.c\n> @@ -16,6 +16,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> #include \n> #include \n> @@ -119,20 +120,27 @@ static const struct mfd_cell s2mu005_devs[] = {\n> \n> static void sec_pmic_dump_rev(struct sec_pmic_dev *sec_pmic)\n> {\n> -\tunsigned int val;\n> +\tunsigned int reg, mask, val;\n> \n> -\t/* For s2mpg1x, the revision is in a different regmap */\n> \tswitch (sec_pmic->device_type) {\n> \tcase S2MPG10:\n> \tcase S2MPG11:\n> +\t\t/* For s2mpg1x, the revision is in a different regmap */\n> \t\treturn;\n> -\tdefault:\n> +\tcase S2MU005:\n> +\t\treg = S2MU005_REG_ID;\n> +\t\tmask = S2MU005_ID_MASK;\n> \t\tbreak;\n> +\tdefault:\n> +\t\t/* For other device types, REG_ID is always the first register. */\n> +\t\treg = S2MPS11_REG_ID;\n> +\t\tmask = ~0;\n> \t}\n> \n> -\t/* For each device type, the REG_ID is always the first register */\n> -\tif (!regmap_read(sec_pmic->regmap_pmic, S2MPS11_REG_ID, &val))\n> +\tif (!regmap_read(sec_pmic->regmap_pmic, reg, &val)) {\n> +\t\tval = FIELD_GET(S2MU005_ID_MASK, val);\n\nBug here! FIELD_GET(mask, val) should've been used.\n\n> \t\tdev_dbg(sec_pmic->dev, \"Revision: 0x%x\\n\", val);\n> +\t}\n> }\n> \n> static void sec_pmic_configure(struct sec_pmic_dev *sec_pmic)","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-rtc@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=disroot.org header.i=@disroot.org header.a=rsa-sha256\n header.s=mail header.b=WlSb8mJB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-rtc+bounces-6330-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org\n header.b=\"WlSb8mJB\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=178.21.23.139","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=disroot.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=disroot.org"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvwvB5Ppjz1yDF\n\tfor ; Tue, 14 Apr 2026 17:31:34 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id AD03D3026A8C\n\tfor ; Tue, 14 Apr 2026 07:25:38 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 343C437DEAD;\n\tTue, 14 Apr 2026 07:25:38 +0000 (UTC)","from layka.disroot.org (layka.disroot.org [178.21.23.139])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id D84D8370D62;\n\tTue, 14 Apr 2026 07:25:36 +0000 (UTC)","from [127.0.0.1] (localhost [127.0.0.1])\n\tby disroot.org (Postfix) with ESMTP id 784CF26F4F;\n\tTue, 14 Apr 2026 09:25:35 +0200 (CEST)","from layka.disroot.org ([127.0.0.1])\n by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id pQzWUVyRxP8u; Tue, 14 Apr 2026 09:25:34 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776151538; cv=none;\n b=Eotk2z/gLHNEjMnkjaRs+fb78zH9nfZwPar4KOLfNXBhwnB23R/nUyH+VzXjUhXQ7BQeKZJqE3tgFIopndllJT+jbwZm7k/bZK3RxopmDinn2etD4cUh2iRpYAC5nhnMFG3H8kVFmVj+rFETXDn90FcamhZgmOW+HQBpPFCG9Ws=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776151538; c=relaxed/simple;\n\tbh=K6l5bmd1+0GzCu/0w8RgYpx8yym1hNAtokH6NiQwEM8=;\n\th=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc:\n\t References:In-Reply-To;\n b=NMwI1iLmRa2Oe2geD5vZbgd5FXnIGAcpExn1BigqNJBKehV45MvJ+Hl32euFXJ2+dgNcq6acsjlyOoIRij/Mak0rgrePlEHlTlTeLzWDUhlzWaGe3LjyXmXMCSriufqa6TjVUZRjsrRh0Xq97GzPZCLToZ2UsLzgirh6Wr3xxAk=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=disroot.org;\n spf=pass smtp.mailfrom=disroot.org;\n dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org\n header.b=WlSb8mJB; arc=none smtp.client-ip=178.21.23.139","X-Virus-Scanned":"SPAM Filter at disroot.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;\n\tt=1776151534; bh=K6l5bmd1+0GzCu/0w8RgYpx8yym1hNAtokH6NiQwEM8=;\n\th=Date:Subject:From:To:Cc:References:In-Reply-To;\n\tb=WlSb8mJBT9fy/c/Cggy/1Ikrh/ZmnJ+BWZaZ7/QNIBwrHplRuZSQBCVZFsr0xESOo\n\t fpfmTlz/eoIGFaeK3bJP2XLqGhFDhdXaYoVYocBgycUWeKdraiWvDKo/vIBoHwQPkl\n\t EuaH0Lisp6eeQ+MLiFnK0let06wePJOLSrlA7SjsFVxUqsDb/RKiRT+LiXApAg0BHI\n\t FO6Pjn/PytoOvaAnjODO0wq+5ZFyfEsrdCSO1Jow9ngw0ulwm9HTEJngn4iQzTZgf9\n\t 7oOXgiYZxkjuK3cK2L4ZQ13NIAyxniItOqAist7M0LFMq3eKr5beiAwcjCeXtFXt90\n\t fLl903j8TrShw==","Precedence":"bulk","X-Mailing-List":"linux-rtc@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","Mime-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","Content-Type":"text/plain; charset=UTF-8","Date":"Tue, 14 Apr 2026 12:55:20 +0530","Message-Id":"","Subject":"Re: [PATCH v4 08/13] mfd: sec: resolve PMIC revision in S2MU005","From":"\"Kaustabh Chakraborty\" ","To":"\"Kaustabh Chakraborty\" ,\n \"Lee Jones\" , \"Pavel Machek\" ,\n \"Rob Herring\" , \"Krzysztof Kozlowski\" ,\n \"Conor Dooley\" ,\n \"MyungJoo Ham\" ,\n \"Chanwoo Choi\" , \"Sebastian Reichel\" ,\n \"Krzysztof Kozlowski\" ,\n =?utf-8?q?Andr=C3=A9_Draszik?= ,\n \"Alexandre Belloni\" ,\n \"Jonathan Corbet\" , \"Shuah Khan\" ,\n \"Nam Tran\" ,\n =?utf-8?b?xYF1a2FzeiBMZWJpZWR6acWEc2tp?= ","Cc":", ,\n , ,\n , ,\n ","References":"<20260414-s2mu005-pmic-v4-0-7fe7480577e6@disroot.org>\n <20260414-s2mu005-pmic-v4-8-7fe7480577e6@disroot.org>","In-Reply-To":"<20260414-s2mu005-pmic-v4-8-7fe7480577e6@disroot.org>"}}]