[{"id":3677130,"web_url":"http://patchwork.ozlabs.org/comment/3677130/","msgid":"","list_archive_url":null,"date":"2026-04-14T11:09:05","subject":"RE: [PATCH iwl-next v2 2/2] idpf: implement pci error handlers","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/people/75597/","name":"Loktionov, Aleksandr","email":"aleksandr.loktionov@intel.com"},"content":"> -----Original Message-----\n> From: Tantilov, Emil S \n> Sent: Tuesday, April 14, 2026 5:17 AM\n> To: intel-wired-lan@lists.osuosl.org\n> Cc: netdev@vger.kernel.org; Kitszel, Przemyslaw\n> ; Bhat, Jay ;\n> Barrera, Ivan D ; Loktionov, Aleksandr\n> ; Zaremba, Larysa\n> ; Nguyen, Anthony L\n> ; andrew+netdev@lunn.ch;\n> davem@davemloft.net; edumazet@google.com; kuba@kernel.org;\n> pabeni@redhat.com; Lobakin, Aleksander ;\n> linux-pci@vger.kernel.org; Chittim, Madhu ;\n> decot@google.com; willemb@google.com; sheenamo@google.com;\n> lukas@wunner.de\n> Subject: [PATCH iwl-next v2 2/2] idpf: implement pci error handlers\n> \n> Add callbacks to handle PCI errors and FLR reset. When preparing to\n> handle reset on the bus, the driver must stop all operations that can\n> lead to MMIO access in order to prevent HW errors. To accomplish this\n> introduce helper\n> idpf_reset_prepare() that gets called prior to FLR or when PCI error\n> is detected. Upon resume the recovery is done through the existing\n> reset path by starting the event task.\n> \n> The following callbacks are implemented:\n> .reset_prepare runs the first portion of the generic reset path\n> leading up to the part where we wait for the reset to complete.\n> .reset_done/resume runs the recovery part of the reset handling.\n> .error_detected is the callback dealing with PCI errors, similar to\n> the prepare call, we stop all operations, prior to attempting a\n> recovery.\n> .slot_reset is the callback attempting to restore the device, provided\n> a PCI reset was initiated by the AER driver.\n> \n> Whereas previously the init logic guaranteed netdevs during reset, the\n> addition of idpf_detach_and_close() to the PCI callbacks flow makes it\n> possible for the function to be called without netdevs. Add check to\n> avoid NULL pointer dereference in that case.\n> \n> Co-developed-by: Alan Brady \n> Signed-off-by: Alan Brady \n> Signed-off-by: Emil Tantilov \n> Reviewed-by: Jay Bhat \n> Reviewed-by: Madhu Chittim \n> ---\n> drivers/net/ethernet/intel/idpf/idpf.h | 3 +\n> drivers/net/ethernet/intel/idpf/idpf_lib.c | 13 ++-\n> drivers/net/ethernet/intel/idpf/idpf_main.c | 112 ++++++++++++++++++++\n> 3 files changed, 126 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/net/ethernet/intel/idpf/idpf.h\n> b/drivers/net/ethernet/intel/idpf/idpf.h\n> index 1d0e32e47e87..164d2f3e233a 100644\n> --- a/drivers/net/ethernet/intel/idpf/idpf.h\n> +++ b/drivers/net/ethernet/intel/idpf/idpf.h\n> @@ -88,6 +88,7 @@ enum idpf_state {\n> * @IDPF_REMOVE_IN_PROG: Driver remove in progress\n> * @IDPF_MB_INTR_MODE: Mailbox in interrupt mode\n> * @IDPF_VC_CORE_INIT: virtchnl core has been init\n> + * @IDPF_PCI_CB_RESET: Reset via the PCI callbacks\n> * @IDPF_FLAGS_NBITS: Must be last\n> */\n> enum idpf_flags {\n> @@ -97,6 +98,7 @@ enum idpf_flags {\n> \tIDPF_REMOVE_IN_PROG,\n> \tIDPF_MB_INTR_MODE,\n> \tIDPF_VC_CORE_INIT,\n\n...\n\n> +/**\n> + * idpf_pci_err_resume - Resume operations after PCI error recovery\n> + * @pdev: PCI device struct\n> + */\n> +static void idpf_pci_err_resume(struct pci_dev *pdev) {\n> +\tstruct idpf_adapter *adapter = pci_get_drvdata(pdev);\n> +\n> +\t/* Force a PFR when resuming from PCI error. */\n> +\tif (test_and_set_bit(IDPF_PCI_CB_RESET, adapter->flags))\n> +\t\tadapter->dev_ops.reg_ops.trigger_reset(adapter,\n> IDPF_HR_FUNC_RESET);\nYou say \"Force a PFR\", but PFR is only triggered on the AER path, not on the FLR path.\n\nEverything else looks fine\nReviewed-by: Aleksandr Loktionov \n\n> +\n> +\tqueue_delayed_work(adapter->vc_event_wq,\n> +\t\t\t &adapter->vc_event_task,\n> +\t\t\t msecs_to_jiffies(300));\n> +}\n\n...\n\n> };\n> module_pci_driver(idpf_driver);\n> --\n> 2.37.3","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=dT0BNrAt;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-pci+bounces-52485-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"dT0BNrAt\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=192.198.163.19","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=intel.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw1kL4Knlz1y2d\n\tfor ; Tue, 14 Apr 2026 21:09:14 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 80C7A3010713\n\tfor ; Tue, 14 Apr 2026 11:09:13 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 458303D8128;\n\tTue, 14 Apr 2026 11:09:12 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.19])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E0AD2472B6;\n\tTue, 14 Apr 2026 11:09:10 +0000 (UTC)","from fmviesa005.fm.intel.com ([10.60.135.145])\n by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Apr 2026 04:09:10 -0700","from fmsmsx903.amr.corp.intel.com ([10.18.126.92])\n by fmviesa005.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Apr 2026 04:09:10 -0700","from FMSMSX903.amr.corp.intel.com (10.18.126.92) by\n fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Tue, 14 Apr 2026 04:09:09 -0700","from fmsedg901.ED.cps.intel.com (10.1.192.143) by\n FMSMSX903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Tue, 14 Apr 2026 04:09:09 -0700","from BL2PR02CU003.outbound.protection.outlook.com (52.101.52.44) by\n edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Tue, 14 Apr 2026 04:09:09 -0700","from IA3PR11MB8986.namprd11.prod.outlook.com (2603:10b6:208:577::21)\n by PH7PR11MB8123.namprd11.prod.outlook.com (2603:10b6:510:236::5) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.20; Tue, 14 Apr\n 2026 11:09:05 +0000","from IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c]) by IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c%5]) with mapi id 15.20.9745.012; Tue, 14 Apr 2026\n 11:09:05 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776164952; cv=fail;\n b=gn5IGbsX0oZxHQgf2BxpYtZ8t7DonKD2l9KQyyqbAjJuqnNQtokBBCjUyZA4trDn0hhG/tLbyvfzO47ZEHwftoSN5Kh6uppFpUcCT6Yw8f+tch6MKHMxL62rkpG6FhWT3NfXUqojhuCZ50iC0ggqxpcXEYZmPJe3HGdlOgokXJM=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=BbakXGplvnOdNCkhNRogw7TNKkbH/X43iSBfswGs040M8+4oHYzKw8Nh0zex7AIeeOt+2/aRFJMK8iJbsg4Z/zcXsQF1/XmSVjZ0GBMc0YgE5mTqAwrhVVDerEM3nFHx9Vj7RJsRQTEOxCU3COrkFcRYmv1PY2faA1ZYl3sVZAw8AupRRq2rvGRWRqDwejSmNkYE7IGSUlXPnadpO/Dxw6YLfyzKYwNeMKKV4UjV666BpkwtM6cZzCZzXxJW91wMwUT0vN50pO/2nf4GqsUdD3Qh6Yse3uciPUgm8MWtgZIgwbfgXtSrXgcRxT3nX7C/ITohTqrW5Y2gBSsvLSZ7Sg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776164952; c=relaxed/simple;\n\tbh=ISE2+5eowPdsss7hRKR/xtzkZvbux11lSHcgQzp6fFY=;\n\th=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To:\n\t Content-Type:MIME-Version;\n b=cei+D9mEGssVM7822cY33Oo+0oZgEYXTSn1VSwjmoIhppceBGCMgAoe2ZLuEUq60Y5pKmPEeh9H701lWJc/0P3Rhw+ZXLeU5ezUXl4Mz9/ZLYXiFZyQ1h2zW6bYBafeEH7wSHQ5roPeVZVoN5yJt8/i4iqqFtwG+7u2pPNJ5ZGs=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=TQCpUU4Yj0UoxxGnLjWEAmvS5OgQJY5M0GYomfgoK68=;\n b=n2e8lGxHvcpzZRoGukC3IUfXYoBU0CVuYZv91EFJfJ1urR0abvxE6kxkPVNZswVgBQ2esl/zprup16wMdS8S6o7sh/id7RBcZsNvWo0TboQqvST1vtnDAQC7gPKQy8fCa41+H1OsZWwstJSi+JKhmucqrMQfh9YTE5+ZEG3TWnOWrwIi7DjirXvAYu4iPsFAKVA6Kpavl8R/oioDfhGP3FxL57DZm8Cac8VI5tMsaavaDi/FvJPm+waoKo5+XWUktfl2qSzxO/Oy5idorDKffN3MQEmXKUCeKsvPqjahOuetVDPv3tBTEfe/7aRMmtLzsIM/fCaNUsmfhKQ8WPY3Mg=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com;\n spf=pass smtp.mailfrom=intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=dT0BNrAt; arc=fail smtp.client-ip=192.198.163.19","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776164951; x=1807700951;\n h=from:to:cc:subject:date:message-id:references:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=ISE2+5eowPdsss7hRKR/xtzkZvbux11lSHcgQzp6fFY=;\n b=dT0BNrAtdct520/e68XyjNlORjb1TUugmqDfy1lUFNkF8E2DYZ0O19XX\n R2IEoW8Qk6NIcpmbcLvS0PSuihHfuYEYUA6l05KKlyEfbfTho+EhJOyb3\n gfGPYEXN8G5DhT3v/JTgrdRVpWbrMwNtxOgO2uhSF8sLePk3BOHIs9TzI\n N0gFizkBEpL3WFVgnMWoyP+xtoGkpDQkc1HSVFgHiqq8NOp/8carkHs/b\n Z6RsewW9e/Zo+BhHQFudzCGVeNqB+sl3bOrEmbybSVuq4eOtb4R60/4fD\n oooQwxSkumy52IlnzJzamvgxPYmhhJVRTT9zLDO517wLPlgKt+l7mMksk\n Q==;","X-CSE-ConnectionGUID":["TjZTWNSxSBah9nqKn8MLzA==","K9hDugYLSuCoZDLBJVLsjw=="],"X-CSE-MsgGUID":["mvBdKDoUTjGL3E9SGM0AkA==","r6oJsEdKRMuHJ2w1Lhvjkg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11758\"; a=\"76151100\"","E=Sophos;i=\"6.23,179,1770624000\";\n d=\"scan'208\";a=\"76151100\"","E=Sophos;i=\"6.23,179,1770624000\";\n d=\"scan'208\";a=\"234997356\""],"X-ExtLoop1":"1","From":"\"Loktionov, Aleksandr\" ","To":"\"Tantilov, Emil S\" ,\n\t\"intel-wired-lan@lists.osuosl.org\" ","CC":"\"netdev@vger.kernel.org\" , \"Kitszel, Przemyslaw\"\n\t, \"Bhat, Jay\" , \"Barrera,\n Ivan D\" , \"Zaremba, Larysa\"\n\t, \"Nguyen, Anthony L\" ,\n\t\"andrew+netdev@lunn.ch\" , \"davem@davemloft.net\"\n\t, \"edumazet@google.com\" ,\n\t\"kuba@kernel.org\" , \"pabeni@redhat.com\" ,\n\t\"Lobakin, Aleksander\" ,\n\t\"linux-pci@vger.kernel.org\" , \"Chittim, Madhu\"\n\t, \"decot@google.com\" ,\n\t\"willemb@google.com\" , \"sheenamo@google.com\"\n\t, \"lukas@wunner.de\" ","Subject":"RE: [PATCH iwl-next v2 2/2] idpf: implement pci error handlers","Thread-Topic":"[PATCH iwl-next v2 2/2] idpf: implement pci error handlers","Thread-Index":"AQHcy70clylJ6BBLYkyAicYeVjavabXeZlxg","Date":"Tue, 14 Apr 2026 11:09:05 +0000","Message-ID":"\n ","References":"<20260414031631.2107-1-emil.s.tantilov@intel.com>\n <20260414031631.2107-3-emil.s.tantilov@intel.com>","In-Reply-To":"<20260414031631.2107-3-emil.s.tantilov@intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=dT0BNrAt;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-pci+bounces-52485-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"dT0BNrAt\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=192.198.163.19","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=intel.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"IA3PR11MB8986:EE_|PH7PR11MB8123:EE_","x-ms-office365-filtering-correlation-id":"7fe1638d-c3f6-4ee5-957b-08de9a163e37","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"\n BCL:0;ARA:13230040|7416014|376014|1800799024|366016|18096099003|38070700021|22082099003|18002099003|56012099003;","x-microsoft-antispam-message-info":"\n 0wX77jYnKHziedv90cKNJFrHcUV20VdQ0qp9jMWnVzB/RV+DKrbEWAxtDDWpVRAJrn1FylMORFAGsv5TW7HRTeeKmwvH2sNeSpKKQ+LjbVtarXEzh7BiJt/l7+jxXd/wnR2fbPIh3QJuiSmAEjdFJyuIwxX18FMPZ73Wr9SGkQf7pmah6z5IMkxt4HLe2z2fSs9m9ttU1U7wg9Z5Uyv1mwDTsUP3yK+atVsLnfzzj8vyqqPZu3cx7GsyI4mFUvIdgd+uzWouDJuYDdE31rAQcIlIXAh9zFd/9SldpDlZn4484XXCA+tGRTiLYTnGoNyaTNb60u6kic3lIq8PUjax6DJbwLdJv1DAySIregKTCwE6+wvcEFFxjgmDCj3XapuCZ6OKn9mofBE+SVANJGDvf6WOdllrDjxtYlZPjGZ7g42mxiVE4HP7laFI6KX7RW+m2SshBjpgxMK+EvJmXgkZEyEPghXOmXTf3jvGjwUy9BYzWgzkNathL9OkDIfq9VlYTGZPOlPKFH+wrXYkmQccPsuZQ0Ujlo2G/6+fby2wCVWWjYwzz4G7yAfJVhYNRwNdpp1nrW0AloaojdCimWEesZR0Myi08ez0yARhVxOdADQCVDIm7QYzR+MPx8lxgWTqK8UcWGbzYFTztZjOn5+d/FJakxlRyfV0/zdC2ywGNpVe4TsYSNp9dS2Hk2Qqt/huUOllbZiI1nPFVAxJJCUd22DIumI5QvktYHNmqp1d6HKACKgLagz+xamaBTASyCil0r1S6qFUPpGsFJ6G5ml3go24PfHa34zDIOWzhiFPgnI=","x-forefront-antispam-report":"\n CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA3PR11MB8986.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(366016)(18096099003)(38070700021)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"\n j73izR0R0cLdj8wZb/k2W2l+uZQp2QLGbn7W+e4KV7PZ+OPf1jkXsSLZjK+KRM0g0lt8/rtvCi21FkKJqfG4NcBaEJCUub7fLyZ26m86X67pbqbtPCkKUKMDZse8k97yFPrqhmaTNuIfjcYhlEjE+k53PtAmd5eP1JXj6Wq2o9opF2oucLOUs6Jjn7Mm5HA0niH1D4asCw7Ii7rrb9GvCQZd3d9stWlwaa3wK3c6Eh4Amgl+0o8ki1+ZIZ0d7mRK/A9sBxxQZSMHGRRVelHG76GodLWxTElokOes32vtk50jYn1CQwqedGK/LdCPeTn2IJwfTOF3fzNDesp+UkcYYCHfGXs0+j2pz5IIAqdv1Ix6SLCtQMD2X/V/IkAJVYygSwSSjByP+9hhOxwCxaNF+AKTIF1opDyGvZp9EDc52UmQzGlERLdYvNrWuN3N3iM96HoNxI2Az3hcT7ammGIBbyINzVH5cGUk7WzF0VuGmfJnCSID6DHVqyqHTvr62BsYM5AxELL7Dvrxf/rVF+etk7MT5kwi6TIXPXZ+9vVz+cqb7/cOk5AqkrqRigae/mHzHKlobXL8oA5gWdBgMxXNV4wYMI8MH86iT1IjDnWPvdfbU1ohLWfeGzAWvhjhrBtnsxm2owsvo3BnYybQcPK93V1ZoNNZovb2+coIEmxDnmEg6hSSmKW5U4CgKjJsRdQ4tlPjndcEh5MFJv2Lr4EEnFnH5X4OFwKa7mgsciusN+UAaPNiimhcZkv1ZM/F2dtYlw/FA9B9vb3N3g2A3alF9WMctDVQ5HuKjZyjdNzqUs3WseZ+q8ys+SpyMuCYjZ7uYINCWzJwnw3di6fbC4kSO+47hYACNZ7YBKbG5RX/K5U09BwOivGJhnVyXgsXDl5qDoU9hFiqe9NBTO3EeJwM/rQAd802JvP0I9BqPDIqzWg7PrDDqV0hcEKnByn6lqZEIeD+q7tcsxxB7xDNW+BeueEQEF+0RICMdn4VxbuAo4yO7nKgGUTO5+bDXm7MFHtiLmjJbHZk+HlhBBMl054KKeq7cpIp/TKIIY4e/wFvpFKI1k/YYP5veMPY2sdpZGIvRDKjyxbDEemkjZJu7yAnTim7lR0sFFXWVrOqbS9UyZRqXq6oVbmAHCwrNEf4LYZ6FLxLbrYfqVnjG7tijOND9k7FYAw1bWaJA2umVEXNnfUOGFGXHTAGJ3LoXgAdRiqt7MJcg0/lZ59AqORTyy9HTA/1b0WWPJwwbwHHn+LwPkxBMmMHeaijzwU+BHhaZRgxK0Q0OKPkAJ9dlyfnqKtZv02itCtL2DLLGWvy3iaH47Gdc6+MfarIdWanG0nQWVZrtLYp2ZJRCtD3miaPOkjybYFAzvPw1YzjfFkWk+1I7ei6ABBjKdEkgtVU3R/qdUy/yah7Ik/9j7XHBI8sle3Lhlhcw9jbfDHcrgqdStFnB6pQmWJ573YGjDx/gorh9Id23eJUi+h1W7T7usbQtxLS0/TaUydzUs0ZjSSjjwkU6+Qc3s1zO9xQJSNtOT179Qtwt0x+VU6gitAhoV5q5Ogcl3EWgmqM/lKcusmq6sMQflsfUy0LsiUrLz78kFGQdSbKECBWyOXSzy6kZhQxKIpxuDapBCVP9SVW1OWYOWoQxuDT1zk8YrH/eAwDee86b3ffAaGRK2mzHEeir17hlIjeBM8zgiwBHjdr/Yxr7n9dxq+Bpplzik7OJBLprN0sw8/jG2g7Hujr8t0fXLq8f3pGSR4Eaol2cH/gEBeUfcQ0qsE=","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-Exchange-RoutingPolicyChecked":"\n W/O1birO3ltyvieHbUIwjwte42v+JNdRsY5Ao17Tt/rmb2ST0UVu+4dXToUcQRkhtrMeAaD523I16doKa2Y84PSLsoIQEp1/I1164tsrOpxbAkitIoceaytORQmHe5yMH7pnj5YhFhMefbtnB9ipykak+aTVG2paTm6W6hxN1/+8Q82LBKwxiWMimh/y10PyL4tYFVc9qivBPo1/OBqy72kKK4ORBEwOv7wyYlTrj71qjC4Ie9V0MXCnK82iWQ3wXal/1jzVIwoB6F8cocJEtOmCWNR0kEUp7gdpYiLf3z3yWQ4u4gyK4/Q354EaOHr7IEjO/6dIxHKE9Zz9vYllaw==","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"IA3PR11MB8986.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 7fe1638d-c3f6-4ee5-957b-08de9a163e37","X-MS-Exchange-CrossTenant-originalarrivaltime":"14 Apr 2026 11:09:05.6525\n (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n as5qwu2xerxpJvG2hZX1C28HfUP6X0kyFe4qESo+WDo1NWOiP/rqE5dNfO4/E1Y4ILfGZZKB3YBMgJNkPDuER2HFycRnYRid4ZGTX+xf7jo=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PH7PR11MB8123","X-OriginatorOrg":"intel.com"}},{"id":3677246,"web_url":"http://patchwork.ozlabs.org/comment/3677246/","msgid":"","list_archive_url":null,"date":"2026-04-14T15:01:04","subject":"Re: [PATCH iwl-next v2 2/2] idpf: implement pci error handlers","submitter":{"id":1670,"url":"http://patchwork.ozlabs.org/api/people/1670/","name":"Tantilov, Emil S","email":"emil.s.tantilov@intel.com"},"content":"On 4/14/2026 4:09 AM, Loktionov, Aleksandr wrote:\n> \n> \n>> -----Original Message-----\n>> From: Tantilov, Emil S \n>> Sent: Tuesday, April 14, 2026 5:17 AM\n>> To: intel-wired-lan@lists.osuosl.org\n>> Cc: netdev@vger.kernel.org; Kitszel, Przemyslaw\n>> ; Bhat, Jay ;\n>> Barrera, Ivan D ; Loktionov, Aleksandr\n>> ; Zaremba, Larysa\n>> ; Nguyen, Anthony L\n>> ; andrew+netdev@lunn.ch;\n>> davem@davemloft.net; edumazet@google.com; kuba@kernel.org;\n>> pabeni@redhat.com; Lobakin, Aleksander ;\n>> linux-pci@vger.kernel.org; Chittim, Madhu ;\n>> decot@google.com; willemb@google.com; sheenamo@google.com;\n>> lukas@wunner.de\n>> Subject: [PATCH iwl-next v2 2/2] idpf: implement pci error handlers\n>>\n>> Add callbacks to handle PCI errors and FLR reset. When preparing to\n>> handle reset on the bus, the driver must stop all operations that can\n>> lead to MMIO access in order to prevent HW errors. To accomplish this\n>> introduce helper\n>> idpf_reset_prepare() that gets called prior to FLR or when PCI error\n>> is detected. Upon resume the recovery is done through the existing\n>> reset path by starting the event task.\n>>\n>> The following callbacks are implemented:\n>> .reset_prepare runs the first portion of the generic reset path\n>> leading up to the part where we wait for the reset to complete.\n>> .reset_done/resume runs the recovery part of the reset handling.\n>> .error_detected is the callback dealing with PCI errors, similar to\n>> the prepare call, we stop all operations, prior to attempting a\n>> recovery.\n>> .slot_reset is the callback attempting to restore the device, provided\n>> a PCI reset was initiated by the AER driver.\n>>\n>> Whereas previously the init logic guaranteed netdevs during reset, the\n>> addition of idpf_detach_and_close() to the PCI callbacks flow makes it\n>> possible for the function to be called without netdevs. Add check to\n>> avoid NULL pointer dereference in that case.\n>>\n>> Co-developed-by: Alan Brady \n>> Signed-off-by: Alan Brady \n>> Signed-off-by: Emil Tantilov \n>> Reviewed-by: Jay Bhat \n>> Reviewed-by: Madhu Chittim \n>> ---\n>> drivers/net/ethernet/intel/idpf/idpf.h | 3 +\n>> drivers/net/ethernet/intel/idpf/idpf_lib.c | 13 ++-\n>> drivers/net/ethernet/intel/idpf/idpf_main.c | 112 ++++++++++++++++++++\n>> 3 files changed, 126 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/drivers/net/ethernet/intel/idpf/idpf.h\n>> b/drivers/net/ethernet/intel/idpf/idpf.h\n>> index 1d0e32e47e87..164d2f3e233a 100644\n>> --- a/drivers/net/ethernet/intel/idpf/idpf.h\n>> +++ b/drivers/net/ethernet/intel/idpf/idpf.h\n>> @@ -88,6 +88,7 @@ enum idpf_state {\n>> * @IDPF_REMOVE_IN_PROG: Driver remove in progress\n>> * @IDPF_MB_INTR_MODE: Mailbox in interrupt mode\n>> * @IDPF_VC_CORE_INIT: virtchnl core has been init\n>> + * @IDPF_PCI_CB_RESET: Reset via the PCI callbacks\n>> * @IDPF_FLAGS_NBITS: Must be last\n>> */\n>> enum idpf_flags {\n>> @@ -97,6 +98,7 @@ enum idpf_flags {\n>> \tIDPF_REMOVE_IN_PROG,\n>> \tIDPF_MB_INTR_MODE,\n>> \tIDPF_VC_CORE_INIT,\n> \n> ...\n> \n>> +/**\n>> + * idpf_pci_err_resume - Resume operations after PCI error recovery\n>> + * @pdev: PCI device struct\n>> + */\n>> +static void idpf_pci_err_resume(struct pci_dev *pdev) {\n>> +\tstruct idpf_adapter *adapter = pci_get_drvdata(pdev);\n>> +\n>> +\t/* Force a PFR when resuming from PCI error. */\n>> +\tif (test_and_set_bit(IDPF_PCI_CB_RESET, adapter->flags))\n>> +\t\tadapter->dev_ops.reg_ops.trigger_reset(adapter,\n>> IDPF_HR_FUNC_RESET);\n> You say \"Force a PFR\", but PFR is only triggered on the AER path, not on the FLR path.\n\nHence the \"force\" - the call to `trigger_reset` results in a PFR and is\nonly needed in the case of a PCI error. If this function was called\nbecause a user issued an FLR, the kernel will trigger it for us. This\nway we can reuse the reset handling path to restore the operation of the\nnetdevs.\n\nThough I may be misunderstanding - are you referring to the wording or\nthe logic?\n\nThanks,\nEmil\n\n> \n> Everything else looks fine\n> Reviewed-by: Aleksandr Loktionov \n> \n>> +\n>> +\tqueue_delayed_work(adapter->vc_event_wq,\n>> +\t\t\t &adapter->vc_event_task,\n>> +\t\t\t msecs_to_jiffies(300));\n>> +}\n> \n> ...\n> \n>> };\n>> module_pci_driver(idpf_driver);\n>> --\n>> 2.37.3\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=Rk3ERUKr;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-52502-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"Rk3ERUKr\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=192.198.163.15","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=intel.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw6vM1Wtpz1yCv\n\tfor ; Wed, 15 Apr 2026 01:02:23 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 671DF302A7EE\n\tfor ; Tue, 14 Apr 2026 15:01:25 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 5029627380A;\n\tTue, 14 Apr 2026 15:01:22 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.15])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C3CB940DFC3;\n\tTue, 14 Apr 2026 15:01:20 +0000 (UTC)","from fmviesa008.fm.intel.com ([10.60.135.148])\n by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Apr 2026 08:01:20 -0700","from orsmsx902.amr.corp.intel.com ([10.22.229.24])\n by fmviesa008.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Apr 2026 08:01:20 -0700","from ORSMSX901.amr.corp.intel.com (10.22.229.23) by\n ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Tue, 14 Apr 2026 08:01:19 -0700","from ORSEDG901.ED.cps.intel.com (10.7.248.11) by\n ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Tue, 14 Apr 2026 08:01:19 -0700","from PH8PR06CU001.outbound.protection.outlook.com (40.107.209.49) by\n edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Tue, 14 Apr 2026 08:01:14 -0700","from CH0PR11MB8168.namprd11.prod.outlook.com (2603:10b6:610:186::20)\n by SJ2PR11MB8369.namprd11.prod.outlook.com (2603:10b6:a03:53d::16) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.20; Tue, 14 Apr\n 2026 15:01:05 +0000","from CH0PR11MB8168.namprd11.prod.outlook.com\n ([fe80::9549:c8e9:6748:12ee]) by CH0PR11MB8168.namprd11.prod.outlook.com\n ([fe80::9549:c8e9:6748:12ee%5]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026\n 15:01:05 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776178882; cv=fail;\n b=sL4omHq3N6K/0lxaoxZnm600MlrNrOBzqdn0GLDY3zBe4nDykkdyYSgZe7Q9lp/kjNvrgbhl4LEr3VJqQPEh0FZ1AvWPpobT6sKIc6OdnhsV/SXWLDMKfjwFDOKS+7AW2MwfwENizR5MO5+1ht+nb2CLvqB54nKMsuO+6Vkw36M=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=Yv0JJolUt+ph7Omn0wU35UyRUjWL1vj/uhT878Ya1ZW6k3cLFkWA3thZ5zkD/3i4vXRZ8dlARMztCsDKf9Cy4AkvFFSJOt2yl32pO0lHbtKDMy63yl9Iyq/GHMFaH4SS33pdTptz6dACI7sr6wvN2pOLwpc2Ea31GAr6zBa87msXmMPa7NxqTVWjw4ewCLUCYsyrR/XlN1KTae3XsZkXQCFCh7sqGdjXsG2oS0EmVAnns+9JEK2Tlv3USRhwzXXmxDWkoJywe27o4lWPSWzTkLcaoETLLmi6TF8Eqp8HT/zX2O0RcXL6XlAMKO8LfJWcLxyhs1E6Z/D4kZ7GLhnuiw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776178882; c=relaxed/simple;\n\tbh=DXr3qFOiE2Em3S5HEDicDovuab/7S2PtjbD+ypdU3Lw=;\n\th=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To:\n\t Content-Type:MIME-Version;\n b=Az6LWYnvt1nhjI4+w3AIkKd2aHfco9VXZr3cXHKY2zEZCJmauLcO90QBwOODxEyWsnOHRsvEHplJ6MCivUE9/wV//AcRc+j4Upjc1IQG54t//5EqC3FHV/8CejQ3q/d9qHIK3SLBByR2/W3WfvIMUgCBwj1B0KKhrMDKB6v6H3g=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=SqizsChBozjdURrzEdpws76lnm3AshkI8fjXPAlg22E=;\n b=Jt+jRy5ynHuF0wlh/E68f2AL6Rg4gCV5bEGNgB5bCmW5m4VEuk3I4/0J0bXDHvH1CTeoU2s+Xb9XnLoOQEpS5t3D3BFRMgDKAa9ZDaaa8PYu7DfLOzHFBPFt3c/WjlGyb8bj/ox+53/0+Mhbsu9YC0cMJ/J8ZjwGVRJvFiz5B6cubyYf7Qt4d4pSasB2obi6EjIsX+LHgneW1jHIt0wqVwNaQTcHP7lWJIsZnoIxmfk9eUhfdjy0LoFDexLbjmvaugRqSWAwCK7Qf0YuHewmCk2t0Ka+M1jFBHoKXzmSa/Lv5Yt+vdLL5WjoLS5YsqTsPHfbESloKAQ39Jz/UiqXYA=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com;\n spf=pass smtp.mailfrom=intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=Rk3ERUKr; arc=fail smtp.client-ip=192.198.163.15","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776178881; x=1807714881;\n h=message-id:date:subject:to:cc:references:from:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=DXr3qFOiE2Em3S5HEDicDovuab/7S2PtjbD+ypdU3Lw=;\n b=Rk3ERUKrOIg/QnI4ncrsTrFev2Tt8fWxDxW0wY/t+DVB5xsVqT2vW+By\n HT1MpAVK4jBSujmJ/CDkJh7jNSYOr8jmD6+Fz+NaZa72F0W75LN4pqZq+\n fMfD03pun1QuIFiOwJQr9QrUBrw/GfRfmBomIVmFh2gFFWU+9mjiemHjK\n zoBKmEDnXjJkgT9bcjjqjpYRkYgsW1BleOXtlSwSZIOI7gpBjXT5paAYg\n u6fYhO9/bi32G8v0b5I5v/UbJYOpoh74cQoEAWARX9AMvp9W5Sez1zTAQ\n eUwP08ZvJinRrsvKHOsgwP+Q16nFNZ48JqyIUU5tajav+rQDULvWWI80U\n w==;","X-CSE-ConnectionGUID":["qqap6Gp/QqmcnxozC2jhNA==","S8PX/q2jQFqYZUf6sxuO3w=="],"X-CSE-MsgGUID":["r1iLVOGHSKCQLnTRfPqcSQ==","9YJdosDQSN6E7EsLEA/mJA=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11759\"; a=\"77248406\"","E=Sophos;i=\"6.23,179,1770624000\";\n d=\"scan'208\";a=\"77248406\"","E=Sophos;i=\"6.23,179,1770624000\";\n d=\"scan'208\";a=\"227470467\""],"X-ExtLoop1":"1","Message-ID":"","Date":"Tue, 14 Apr 2026 08:01:04 -0700","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH iwl-next v2 2/2] idpf: implement pci error handlers","To":"\"Loktionov, Aleksandr\" ,\n\t\"intel-wired-lan@lists.osuosl.org\" ","CC":"\"netdev@vger.kernel.org\" , \"Kitszel, Przemyslaw\"\n\t, \"Bhat, Jay\" , \"Barrera,\n Ivan D\" , \"Zaremba, Larysa\"\n\t, \"Nguyen, Anthony L\" ,\n\t\"andrew+netdev@lunn.ch\" , \"davem@davemloft.net\"\n\t, \"edumazet@google.com\" ,\n\t\"kuba@kernel.org\" , \"pabeni@redhat.com\" ,\n\t\"Lobakin, Aleksander\" ,\n\t\"linux-pci@vger.kernel.org\" , \"Chittim, Madhu\"\n\t, \"decot@google.com\" ,\n\t\"willemb@google.com\" , \"sheenamo@google.com\"\n\t, \"lukas@wunner.de\" ","References":"<20260414031631.2107-1-emil.s.tantilov@intel.com>\n <20260414031631.2107-3-emil.s.tantilov@intel.com>\n ","Content-Language":"en-US","From":"\"Tantilov, Emil S\" ","In-Reply-To":"\n ","Content-Type":"text/plain; charset=\"UTF-8\"; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"MW4PR04CA0090.namprd04.prod.outlook.com\n (2603:10b6:303:6b::35) To CH0PR11MB8168.namprd11.prod.outlook.com\n (2603:10b6:610:186::20)","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"CH0PR11MB8168:EE_|SJ2PR11MB8369:EE_","X-MS-Office365-Filtering-Correlation-Id":"dbf8030a-f28e-47a0-fdd1-08de9a36a6e2","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n BCL:0;ARA:13230040|1800799024|7416014|366016|376014|56012099003|18002099003|22082099003|18096099003;","X-Microsoft-Antispam-Message-Info":"\n lTpJKL1XEE4YPmOh2QOws3e4z9RFsVpMkTPYL19E0NJzEg1ulLptaYGzCR/qeZbJbzlM4IbzzQd3n3lR0HUXTLdmL3uMSbxWilbGrQW5qaQWg5ZM4ZuGF8pLH+x/2b+77R6CHzlO64uVG0A5hq/0Z7x4DLuBR/RRcQSem7S4AkEy12yQoodrDZ8HXNTCzJA6SEtpv/HWL9ILSv/fOSQ35Wkw+pdO8sKHlIYFT4bKp2QwVzE/8/bhtL64kcgYo+PAlxkJ7wAfxZH5i80080yZPkoM+RVGAxe4zH+g+jTiNN5eb0o8+2X1lP3fWszIT+VZ3z2kat8LTDAKWTkGjR3N4eYVuU/buXCxLDymiwNdIin2+3Pd/6Y54qVT0chaRv8znrh6S6GdvHtqgXSO1pOXO4eXVYcjg/3dWRcl0MqJjael65L9zMd5yyT0m2wlCV7dt4FCQ5A4fzRqRvW3W8YXwN/Op2M17GPBIfiZ2Wg/+aLRsaZIqxSqJq0sxkBFKKPFMpzvBIzOeVZiAFOzPl4ntL56U5h2R7ueVOKJKpBAmIex6mxWYKPqZpAalfPcwLALctDnKJq2unnmFyTHsAX4Jamdj1hOzfSrW6U3kCPhwwN1Zd23GynqFMDE7e2ceaJtpmhnK6gw/QC4R3YtOhJ7PYw0x6XOzjVX3+jUp2hV7PagYVXc3VnMT401nydvn6okXS9n5C4O6IE9Joy4cPsC4kjFG2t5nBEi4c9s8EntmDI=","X-Forefront-Antispam-Report":"\n CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH0PR11MB8168.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(366016)(376014)(56012099003)(18002099003)(22082099003)(18096099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?cqzqh+gTTpsc8YDn+SRImJ6ekovw?=\n\t=?utf-8?q?WxSQ7qvhhLpD17b3R34lDISd4HIKafrjboXc35XweQJDSy8qT6zX0Ck7cFt/KMSbt?=\n\t=?utf-8?q?qOWnaNMbvj/MjKbxWERzYDdA/0Y3wpln13maKkZ+c55DPKMZfevnbZSnMjDzshoEl?=\n\t=?utf-8?q?4pjNjle3YwMrG90/PXGfn9Xt+eE7QuUGJLO5XU8ZBt0KAIuXuRYoO95KZRdJXmYap?=\n\t=?utf-8?q?jjcqdY5hiS3kzTP+ljJgYLxUtaF0vSJj7lMjRgR+YdBuwDmwyM6oLYOfUI9Hq+dUZ?=\n\t=?utf-8?q?/TnoWG+s5EmAVMAxNDjSRDZoxjqoTGtr/+zIxN88E2NKDIkg7HufP7u4egDjbdvpz?=\n\t=?utf-8?q?1okdTPjk1nBlKX3gBlreQaNBHkhWq2D1u4mT10MuflOI+eRw4R0E15bEwIzVZPBa6?=\n\t=?utf-8?q?pPFUJBHW35WBB/E3YRyGEMHSsToxDvL0hzbSxA1jBZN/HQ1cUREE7sheq1iqXiuxR?=\n\t=?utf-8?q?0bwU+S0a0Ng0bzCBdPwCTXBk2PPfWHeo0ZYE5ITO681SA4+b0fqszPnAoY+dpjatt?=\n\t=?utf-8?q?vfCXcri99znafQRDmXb60kjeOtOFriKFCJiiaCGTRwK1kvglxSvuqVePG8S2/DK+j?=\n\t=?utf-8?q?OInvcuhaHK7ywUa6MpLC0DbaI6WSxHGbgjzAs/t76e8ofi9yK2eSlD1m1yLILbTxX?=\n\t=?utf-8?q?/rFZfOiu0EQn6gal+StbXVi6jlV9WNk8+mukVvfJgMsHDkMW8HTWhrFzwG9fBDmU3?=\n\t=?utf-8?q?434oycnnup1xJ0stKQ7ZTe6ItNBLny2lSIkmiq24JGogLu+CJ1Ske76YVYN8rVWwd?=\n\t=?utf-8?q?AjbzdGUMjYjLlpHVX90veJUuFSq8NX65Lg0/8bcB4qsUKKdYH0OXRhXTAzaO0pbwb?=\n\t=?utf-8?q?srz2W+paKd5cjfRTodJLozsd/ykKR4z2QkpGpEnQfegGUb2sVzjG8vTmefDwax8V1?=\n\t=?utf-8?q?drw2vibYgjzY24l7SET2zpHQhMmuA2bLrebhNlKOJvQ5wIaXjr0LmSOouS2Gqm3l4?=\n\t=?utf-8?q?NvQhQoWJcRQ/zPIN5fyyqcJd4b/agXwalGdFz7YACPYZgg8oR1IGmRLJOX4bLfBMu?=\n\t=?utf-8?q?TIR/Ua4cAv0V/8aNkyz4E36QpmxObNJoxTWb39DBkHZgN0ESWKNeHTNVpmFirREFY?=\n\t=?utf-8?q?9jDjSTfNC5eCcnDNQ55IYxCgJl9fcDNZxUkReZmwL4VS5oMwXCUh936gSd4a1rvqE?=\n\t=?utf-8?q?bavWyu1jt5ugRzEVHbGA6hyvPGtBdk0DYqHWak1wyvjMn6gRMcHoBDHyfMV/UrPdt?=\n\t=?utf-8?q?Mo5g4W165LXgwOJ3IsLmo/LqcV56bI45QHnkvIfuxRVxHTchswUd1+PRBJaAXKIv6?=\n\t=?utf-8?q?NVUC1f5fcveYSRlolr2muH92zT8g5hl9aWNo8uYHDxgOsIwj1UUrJ7BKrKSIOuPp8?=\n\t=?utf-8?q?S+VcIUO9Ov1Op59K48mQJc2mUXbVAcmeOKMefkHc/xH36zjzHvfQxQ2Awm1KC/k7Y?=\n\t=?utf-8?q?HqHYb8BdSy8QLzOEKGf1ELemMU3rdIgKS5YzGtyecgLV6YYkSUBrL3V9DlxLC7dDh?=\n\t=?utf-8?q?LcqqhtObdfv8rAzMNgZTARimkrN3SIJtNhVWDWccKk1lFFFsjlZm8nWzTTHxsUUF2?=\n\t=?utf-8?q?QPfbmbW+K42fzEM3/9F7+xZYRuHzIlBUH4OOFaf6t5wXChAdpS4HPOm2lcqvCapyv?=\n\t=?utf-8?q?2QrwpAqLbLqvqifU4V8W/L+WrClyZgMOrtcgoDMgAQrUww0BJocxeHuthDGPqcIkI?=\n\t=?utf-8?q?0qDo03DcEa1Q9lrTvOMdPYL7JLAApC5b11TcKJVk+xsaEUFS9Zt58=3D?=","X-Exchange-RoutingPolicyChecked":"\n vRZEiOkywEtGUT2A+EzCuEIa7ZY+WDW9vWVy8x2tx6IaAIgIP8VIK8BGrHvLTfB9dG8mDsmEACpizbdc96lihUefzozuLiH9ycCV8sqAm1SQBHR9D4Ua1n5tCMEVNtTF3s0Mhbsn3xClccH5a62+cNO2Jomo9F4MqUwtFKJLL6XoXGJXf+p422RW+3sG6FTLer8KweGrYJ2jNsemVM4NXRhW7VUpZfR7QmCQyFtdXKQ3SsgBwzdb6t+pRJ/GUfE+WaHBJbSKEdAtKWaqD9S0mkUEOwg5N/OoyvenxKvLg816tbhxItjBqOxQpBwQ/iu7hWm1/iDsNPHB+siDNlnwLA==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n dbf8030a-f28e-47a0-fdd1-08de9a36a6e2","X-MS-Exchange-CrossTenant-AuthSource":"CH0PR11MB8168.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"14 Apr 2026 15:01:05.4409\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n aRvsHfbjfiWqswDlhFBN4azVf9haFtKK4ATN0binfuxnuwJ6DJB+GaRv2VB6GFwzPzAxiBZsLOI4eCJLqc0amT1RQOSFTMCZmoZwJ1x7O28=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"SJ2PR11MB8369","X-OriginatorOrg":"intel.com"}},{"id":3677250,"web_url":"http://patchwork.ozlabs.org/comment/3677250/","msgid":"","list_archive_url":null,"date":"2026-04-14T15:10:50","subject":"Re: [PATCH iwl-next v2 2/2] idpf: implement pci error handlers","submitter":{"id":68499,"url":"http://patchwork.ozlabs.org/api/people/68499/","name":"Lukas Wunner","email":"lukas@wunner.de"},"content":"On Tue, Apr 14, 2026 at 11:09:05AM +0000, Loktionov, Aleksandr wrote:\n> > From: Tantilov, Emil S \n> > .slot_reset is the callback attempting to restore the device, provided\n> > a PCI reset was initiated by the AER driver.\n\nJust for clarity, those callbacks are invoked by PCI core error handling\ncode and are shared by EEH, AER, DPC as well as s390 error recovery flows.\nSo it's not only AER.\n\n> > +/**\n> > + * idpf_pci_err_resume - Resume operations after PCI error recovery\n> > + * @pdev: PCI device struct\n> > + */\n> > +static void idpf_pci_err_resume(struct pci_dev *pdev) {\n> > +\tstruct idpf_adapter *adapter = pci_get_drvdata(pdev);\n> > +\n> > +\t/* Force a PFR when resuming from PCI error. */\n> > +\tif (test_and_set_bit(IDPF_PCI_CB_RESET, adapter->flags))\n> > +\t\tadapter->dev_ops.reg_ops.trigger_reset(adapter,\n> > IDPF_HR_FUNC_RESET);\n> \n> You say \"Force a PFR\", but PFR is only triggered on the AER path,\n> not on the FLR path.\n\nAnd? idpf_pci_err_resume() is only invoked in the error recovery path\n(aka AER path), not FLR path AFAICS.\n\nThanks,\n\nLukas","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-52504-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=83.223.95.204","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=wunner.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=wunner.de"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw77f1GMhz1xtJ\n\tfor ; Wed, 15 Apr 2026 01:13:02 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id C35D7303431F\n\tfor ; Tue, 14 Apr 2026 15:11:04 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 9E49E3E92A6;\n\tTue, 14 Apr 2026 15:11:02 +0000 (UTC)","from mailout1.hostsharing.net (mailout1.hostsharing.net\n [83.223.95.204])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id BAC843E715C;\n\tTue, 14 Apr 2026 15:10:58 +0000 (UTC)","from h08.hostsharing.net (h08.hostsharing.net\n [IPv6:2a01:37:1000::53df:5f1c:0])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384\n\t client-signature ECDSA (secp384r1) client-digest SHA384)\n\t(Client CN \"*.hostsharing.net\",\n Issuer \"GlobalSign GCC R6 AlphaSSL CA 2025\" (verified OK))\n\tby mailout1.hostsharing.net (Postfix) with ESMTPS id E03F9383;\n\tTue, 14 Apr 2026 17:10:50 +0200 (CEST)","by h08.hostsharing.net (Postfix, from userid 100393)\n\tid C9EB86034192; Tue, 14 Apr 2026 17:10:50 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776179462; cv=none;\n b=AJBsLnAdkORmqNMbLmoH0G8s4MzYht9N2lRaWj179GDWL7/07ZD/6S6QN0xc9kH2AyjCXbqO1k5cFb9m46v9ToobJWcZ47oPsZM5NbRfLikmySf65zV/Rj/2C2keRrDAcVD0hQHRMW27cXr2l3XHa0Hz1EHzDJmykLv9EdrdEEI=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776179462; c=relaxed/simple;\n\tbh=vE8oY2+CFeERbpQcQgcuOZjFVLN/Cm8VzpD9mYKY/gM=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=La5+/MtS6vJOOc+K55y5rb1kFStqsZFo+pudoV8gPt0uMuXO+buTtwU7HlrAs7Yi5NyYpUsxFZ8A/eaYUJRktI0uWeSqPMOA5hcf/8Vy9BmTShT98vCXUczIaP5a6xJVQABQT1A1EPzDA3p71xw0PVGMDOyeg3+OtR975p+NFB0=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=wunner.de;\n spf=pass smtp.mailfrom=wunner.de; arc=none smtp.client-ip=83.223.95.204","Date":"Tue, 14 Apr 2026 17:10:50 +0200","From":"Lukas Wunner ","To":"\"Loktionov, Aleksandr\" ","Cc":"\"Tantilov, Emil S\" ,\n\t\"intel-wired-lan@lists.osuosl.org\" ,\n\t\"netdev@vger.kernel.org\" ,\n\t\"Kitszel, Przemyslaw\" ,\n\t\"Bhat, Jay\" ,\n\t\"Barrera, Ivan D\" ,\n\t\"Zaremba, Larysa\" ,\n\t\"Nguyen, Anthony L\" ,\n\t\"andrew+netdev@lunn.ch\" ,\n\t\"davem@davemloft.net\" ,\n\t\"edumazet@google.com\" ,\n\t\"kuba@kernel.org\" ,\n\t\"pabeni@redhat.com\" ,\n\t\"Lobakin, Aleksander\" ,\n\t\"linux-pci@vger.kernel.org\" ,\n\t\"Chittim, Madhu\" ,\n\t\"decot@google.com\" ,\n\t\"willemb@google.com\" ,\n\t\"sheenamo@google.com\" ","Subject":"Re: [PATCH iwl-next v2 2/2] idpf: implement pci error handlers","Message-ID":"","References":"<20260414031631.2107-1-emil.s.tantilov@intel.com>\n <20260414031631.2107-3-emil.s.tantilov@intel.com>\n ","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"\n "}},{"id":3677253,"web_url":"http://patchwork.ozlabs.org/comment/3677253/","msgid":"","list_archive_url":null,"date":"2026-04-14T15:13:36","subject":"Re: [PATCH iwl-next v2 2/2] idpf: implement pci error handlers","submitter":{"id":68499,"url":"http://patchwork.ozlabs.org/api/people/68499/","name":"Lukas Wunner","email":"lukas@wunner.de"},"content":"On Mon, Apr 13, 2026 at 08:16:31PM -0700, Emil Tantilov wrote:\n> +static pci_ers_result_t\n> +idpf_pci_err_slot_reset(struct pci_dev *pdev)\n> +{\n> +\tstruct idpf_adapter *adapter = pci_get_drvdata(pdev);\n> +\n> +\tpci_restore_state(pdev);\n> +\tpci_set_master(pdev);\n> +\tpci_wake_from_d3(pdev, false);\n> +\tif (readl(adapter->reset_reg.rstat) != 0xFFFFFFFF)\n> +\t\treturn PCI_ERS_RESULT_RECOVERED;\n\nFWIW, there's a PCI_POSSIBLE_ERROR() helper that you may find useful\nto check for an \"all ones\" MMIO read.\n\nThanks,\n\nLukas","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52506-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=83.223.78.233","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=wunner.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=wunner.de"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw79R2zzkz1xtJ\n\tfor ; Wed, 15 Apr 2026 01:14:35 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 8F370301FF98\n\tfor ; Tue, 14 Apr 2026 15:13:41 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 27B853D9DCD;\n\tTue, 14 Apr 2026 15:13:41 +0000 (UTC)","from mailout2.hostsharing.net (mailout2.hostsharing.net\n [83.223.78.233])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 491E23E9580;\n\tTue, 14 Apr 2026 15:13:39 +0000 (UTC)","from h08.hostsharing.net (h08.hostsharing.net\n [IPv6:2a01:37:1000::53df:5f1c:0])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384\n\t client-signature ECDSA (secp384r1) client-digest SHA384)\n\t(Client CN \"*.hostsharing.net\",\n Issuer \"GlobalSign GCC R6 AlphaSSL CA 2025\" (verified OK))\n\tby mailout2.hostsharing.net (Postfix) with ESMTPS id 8EB0410586;\n\tTue, 14 Apr 2026 17:13:36 +0200 (CEST)","by h08.hostsharing.net (Postfix, from userid 100393)\n\tid 6E6506034192; Tue, 14 Apr 2026 17:13:36 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776179621; cv=none;\n b=ar+6RoMMfne6Jq/mxP249oPH75HXWWviHHLviQPf3cWUgSWxIS72zxIISmibtfq4Qxl56J2llwTaF3ZKt11FbMqUPh9CxYF97Dpbw2zmJpylT8ezyMuV3ubugCnOba6RF/zYvgxLVdirr5TXf1EzgYps/TZT99inyCQmXydQlJI=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776179621; c=relaxed/simple;\n\tbh=SxMcvDSO1WH57hVUH3MEAHeEedBtt6pHuvvrisfSZ9Q=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=oVl1nUIsMwQZQwh6uTv/jc2CRR44kHVLHPW91wA/10v/3yszCztDznJhHcbarYLrar+WxQalo1c0hwC/EaOIpk5wEiU5kvxUbrybsF/JHz/7D2GRP2qWOoGbh/4+IeK19pxhNkjp0SmFKImD6p3twF2XS34VRRwZNBCN+NmaJe4=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=wunner.de;\n spf=pass smtp.mailfrom=wunner.de; arc=none smtp.client-ip=83.223.78.233","Date":"Tue, 14 Apr 2026 17:13:36 +0200","From":"Lukas Wunner ","To":"Emil Tantilov ","Cc":"intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n\tprzemyslaw.kitszel@intel.com, jay.bhat@intel.com,\n\tivan.d.barrera@intel.com, aleksandr.loktionov@intel.com,\n\tlarysa.zaremba@intel.com, anthony.l.nguyen@intel.com,\n\tandrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,\n\tkuba@kernel.org, pabeni@redhat.com, aleksander.lobakin@intel.com,\n\tlinux-pci@vger.kernel.org, madhu.chittim@intel.com,\n\tdecot@google.com, willemb@google.com, sheenamo@google.com","Subject":"Re: [PATCH iwl-next v2 2/2] idpf: implement pci error handlers","Message-ID":"","References":"<20260414031631.2107-1-emil.s.tantilov@intel.com>\n <20260414031631.2107-3-emil.s.tantilov@intel.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260414031631.2107-3-emil.s.tantilov@intel.com>"}},{"id":3677408,"web_url":"http://patchwork.ozlabs.org/comment/3677408/","msgid":"<904b95de-491b-41c1-b092-0da56ad4c349@intel.com>","list_archive_url":null,"date":"2026-04-14T21:42:50","subject":"Re: [PATCH iwl-next v2 2/2] idpf: implement pci error handlers","submitter":{"id":1670,"url":"http://patchwork.ozlabs.org/api/people/1670/","name":"Tantilov, Emil S","email":"emil.s.tantilov@intel.com"},"content":"On 4/14/2026 8:10 AM, Lukas Wunner wrote:\n> On Tue, Apr 14, 2026 at 11:09:05AM +0000, Loktionov, Aleksandr wrote:\n>>> From: Tantilov, Emil S \n>>> .slot_reset is the callback attempting to restore the device, provided\n>>> a PCI reset was initiated by the AER driver.\n> \n> Just for clarity, those callbacks are invoked by PCI core error handling\n> code and are shared by EEH, AER, DPC as well as s390 error recovery flows.\n> So it's not only AER.\n\nUnderstood. I can change the wording to be more generic.\n\n> \n>>> +/**\n>>> + * idpf_pci_err_resume - Resume operations after PCI error recovery\n>>> + * @pdev: PCI device struct\n>>> + */\n>>> +static void idpf_pci_err_resume(struct pci_dev *pdev) {\n>>> +\tstruct idpf_adapter *adapter = pci_get_drvdata(pdev);\n>>> +\n>>> +\t/* Force a PFR when resuming from PCI error. */\n>>> +\tif (test_and_set_bit(IDPF_PCI_CB_RESET, adapter->flags))\n>>> +\t\tadapter->dev_ops.reg_ops.trigger_reset(adapter,\n>>> IDPF_HR_FUNC_RESET);\n>>\n>> You say \"Force a PFR\", but PFR is only triggered on the AER path,\n>> not on the FLR path.\n> \n> And? idpf_pci_err_resume() is only invoked in the error recovery path\n> (aka AER path), not FLR path AFAICS.\n\nThe driver calls is in idpf_pci_err_reset_done():\n\n<...>-86378 [009] ..... 342752.746321: idpf_pci_err_reset_prepare \n<-pci_dev_save_and_disable\nbash-86378 [045] ..... 342756.748148: idpf_pci_err_reset_done \n<-pci_reset_function\nbash-86378 [045] ..... 342756.748272: idpf_pci_err_resume \n<-pci_reset_function\n\nThanks,\nEmil\n\n> \n> Thanks,\n> \n> Lukas","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=n8Shqeyh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-52522-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"n8Shqeyh\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=198.175.65.14","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=intel.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwHnn31j4z1yHM\n\tfor ; Wed, 15 Apr 2026 07:43:09 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 0F94930054C8\n\tfor ; Tue, 14 Apr 2026 21:43:06 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 9E8F4377EC3;\n\tTue, 14 Apr 2026 21:43:03 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.14])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 3403638657B;\n\tTue, 14 Apr 2026 21:43:01 +0000 (UTC)","from orviesa010.jf.intel.com ([10.64.159.150])\n by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Apr 2026 14:43:01 -0700","from orsmsx903.amr.corp.intel.com ([10.22.229.25])\n by orviesa010.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Apr 2026 14:42:59 -0700","from ORSMSX902.amr.corp.intel.com (10.22.229.24) by\n ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Tue, 14 Apr 2026 14:43:00 -0700","from ORSEDG901.ED.cps.intel.com (10.7.248.11) by\n ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Tue, 14 Apr 2026 14:43:00 -0700","from BL0PR03CU003.outbound.protection.outlook.com (52.101.53.55) by\n edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Tue, 14 Apr 2026 14:42:58 -0700","from CH0PR11MB8168.namprd11.prod.outlook.com (2603:10b6:610:186::20)\n by DM4PR11MB6504.namprd11.prod.outlook.com (2603:10b6:8:8d::5) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9818.20; Tue, 14 Apr 2026 21:42:54 +0000","from CH0PR11MB8168.namprd11.prod.outlook.com\n ([fe80::9549:c8e9:6748:12ee]) by CH0PR11MB8168.namprd11.prod.outlook.com\n ([fe80::9549:c8e9:6748:12ee%5]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026\n 21:42:53 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776202983; cv=fail;\n b=n3e0PlMiY68YwiVwLD0pDpX38l+kJrtrSJJgtvPqv9kzljlJAfkoEp03HG7mYWw/B9e1V3QAm4OcsyT5f+EDAnU7VCTOJisIKIHzPsrSmd8I0IgML+FZkJ2glkWoEOeLFx3vSU+PBT1kl7FoitFOSIjHwvrTYknCvc8AhzWuHfc=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=YS0eSymhHGPuvJCx41452qpW2iE5ofB9o+NL8bskAZDtUdtJa7FrEalBO3GPTNjpuTuP7FXssfY3GPCE47H7vqPS1aDoQ+tsLjTYfSWURRmYFMV/+slcuj8RJbxMYX/WPoM3Is0sgg0chYefA9Q7hShEcryBU/Y2tP4Goz3myGZub6g+gOS47m+HyvOW/Bf3yM3buu4dvc/PY/810GmCORA6Gu6GIa6mdWt43+801hZ5UHMlYqH/ypYwk8udf5l5xuQ/k9yXE6RqlC3HmOX65+Qds+sehKM78NTSEkNLMa0Pp072fA0Nytb+JJQkjLXYp6xnPL2IadsK+yV+6RtQYA=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776202983; c=relaxed/simple;\n\tbh=ODxTBvKhpcL77U8Io21DzdGdoIdjy64bGoHvhp4F77M=;\n\th=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To:\n\t Content-Type:MIME-Version;\n b=URHPekGlIoCSLi0ULFr5CBfXow919KXA7EPawWQvjOIfUNP3CA9FS+ASiyrTJqCN9sff+RDI4BksNqrCQHdO2MKNNXfnEzr9WF5vgsl5mQBjtDj8xeqadMh4M3wuBsVgd/RBvi2gm10oC+RmRp3mSmhq2w8JFjiJJU6fBcOsgoY=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=s31sKLGO7Fw7JHSvbYSwZdhWvnWAxR5tX4OHX2kAWvI=;\n b=bN5fQ+FCFRR86fb50Bxc/Me3NZ/62a6lvgnLMqBEhdbflb5g0wKRFRmTen2ztlYmICueiQc/u/tldcpRB4sF3XV6T3YIn4XMSMsAMP6r4NWHt3hiEAdJPTfq5fRFajjbi0zv/X9uJOI81yOwDqcd3DRD8wGOQOAMoNBafZU55wPiSlsxVesHSy+3uydZNPkVsuVkmFNbPbKfHxywghre865Bu+/xndlR/Iq3EMhcgKOZhce2Qq//zCCjlRhoz5MwY8yKdsSNOuTzMJA2EXq1o27e/FL/zr5ND4x00hUfWnOTc843+g7UMnTFU8oa8bMQdfmNzCUy8GgnKEkh+jsOHg=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com;\n spf=pass smtp.mailfrom=intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=n8Shqeyh; arc=fail smtp.client-ip=198.175.65.14","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776202981; x=1807738981;\n h=message-id:date:subject:to:cc:references:from:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=ODxTBvKhpcL77U8Io21DzdGdoIdjy64bGoHvhp4F77M=;\n b=n8ShqeyhFnKPGSF5l5cWsy5/p6gAKj4x2Go3w1WRRQw12+m4Ag3jhK/n\n XSJtJCiZtImhuK/4piwIImf+K3Bjdf5i1HzlHLD2TzUMSsdvOq5IHcLW/\n 6FRe0Xx0tg7gBC6/wexAfTtTBQV7nfRtOIY5+0hQozKryNfQUEzsBFOY0\n p+NeXrzgXIdOjz/K1ZY2C7ely5FeyNUdXcHXf0V+HRcv25K6VaWEUjxEL\n VtXoSuWbIpfMpHfrrCfq39yRHG2nrcNlVwifyVDfM+YnhhTfzbLnHtQ7U\n EZsdrrXTlYxdIuN1TknkERcJUDVj9x1Aepgyo5RMHbq9mTrNPadHhdt7A\n w==;","X-CSE-ConnectionGUID":["VAi/nobuSPqDeuQt5+/G1Q==","Dcuve0R1Qw+vLR2LU64HLA=="],"X-CSE-MsgGUID":["8ozU5wk/Tn6CU95T7N+Qog==","YTnrhhw8QF2FMfdwB7hFew=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11759\"; a=\"81036395\"","E=Sophos;i=\"6.23,179,1770624000\";\n d=\"scan'208\";a=\"81036395\"","E=Sophos;i=\"6.23,179,1770624000\";\n d=\"scan'208\";a=\"229351530\""],"X-ExtLoop1":"1","Message-ID":"<904b95de-491b-41c1-b092-0da56ad4c349@intel.com>","Date":"Tue, 14 Apr 2026 14:42:50 -0700","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH iwl-next v2 2/2] idpf: implement pci error handlers","To":"Lukas Wunner , \"Loktionov, Aleksandr\"\n\t","CC":"\"intel-wired-lan@lists.osuosl.org\" ,\n\t\"netdev@vger.kernel.org\" , \"Kitszel, Przemyslaw\"\n\t, \"Bhat, Jay\" , \"Barrera,\n Ivan D\" , \"Zaremba, Larysa\"\n\t, \"Nguyen, Anthony L\" ,\n\t\"andrew+netdev@lunn.ch\" , \"davem@davemloft.net\"\n\t, \"edumazet@google.com\" ,\n\t\"kuba@kernel.org\" , \"pabeni@redhat.com\" ,\n\t\"Lobakin, Aleksander\" ,\n\t\"linux-pci@vger.kernel.org\" , \"Chittim, Madhu\"\n\t, \"decot@google.com\" ,\n\t\"willemb@google.com\" , \"sheenamo@google.com\"\n\t","References":"<20260414031631.2107-1-emil.s.tantilov@intel.com>\n <20260414031631.2107-3-emil.s.tantilov@intel.com>\n \n ","Content-Language":"en-US","From":"\"Tantilov, Emil S\" ","In-Reply-To":"","Content-Type":"text/plain; charset=\"UTF-8\"; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"MW4P223CA0018.NAMP223.PROD.OUTLOOK.COM\n (2603:10b6:303:80::23) To CH0PR11MB8168.namprd11.prod.outlook.com\n (2603:10b6:610:186::20)","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"CH0PR11MB8168:EE_|DM4PR11MB6504:EE_","X-MS-Office365-Filtering-Correlation-Id":"ef2c34eb-77a6-42b5-d894-08de9a6ec88b","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n BCL:0;ARA:13230040|366016|1800799024|376014|7416014|22082099003|56012099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n U5MJ1HvNvkdIVvj6J9ettxkNiE25bAy/YlEv/0/zb2RANhZcl60ro1LNE69xTDJeTqj7898J8tJboJSdQm4Svy6BjapdMWfA0/8TiCbh6pdVW3AVKOXxQXSflME/k59XLNXdb+0I8WtNeXy4y+bzKzYv1OOb+aRUKU6SRH1/pHqMAw8S1izNqwCjFydqXw1B9uqOs27eNld6+b+iZpbhu4Vq7KZKBh00fZFxXgGn55UlmHvO8VxuwWdum0/fCoR85RMq/Ru/DeCtvmaKAcMgxyEhh6neSzbbr6/KJa/txBm8Z10H8hWuM67P8w5gRJzZmR0ebCq4MclSpfOt9ubiDUnUcy27uJ8VXApUfma9g0sRX68Hssdi0tmJrUZS81qBiiYp+P8trCKlwvF0YgT8m+g9eJGE2mlVh26lSlSeM5Gg1ZhvYH2WWBMoB+vbU9snjFzXUtqR+sU8eSFJ59cwSoUL9RGZgBrGW5cVlpDsscI0LEPZM2Y7qk46Qx3Sr4xu/V5oU0WYYDFloip4yDYVc1+qPtiQZHRXDPA46lwqb0IiXetLcOzeEL+ggm6QtU0TqojBsRPVVdmrvZPM1qWtlT8HV/2ydL8MszH/ZLcgrfa1U6SwuO17cUP/2C4tluCrDHZ/fHvwTAnbfBck5vYqmhSdJgkqeitzcSMeo5xZZQfeD459n4d+n8DXsEWoecPm7oIOS0DrXBwLTpnXf5N1e8h5W8CUBnSNftY9woqFDaI=","X-Forefront-Antispam-Report":"\n CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH0PR11MB8168.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?Vq0eiEGzLWScZ6WoeUpVeeZOVUYD?=\n\t=?utf-8?q?fBm0M31GvGf+2O+qAy5hBGpHygYYuGcDTZaUyc4/prqLYgFxwUppoMzpNP2X7gUkS?=\n\t=?utf-8?q?WGKYdS0TMrGio3E4dOcTf05SI6qFjYWGipXUzYoCwnfAwZhp/cMaXUU6PU5a/P79g?=\n\t=?utf-8?q?Cigr9A6KigxAj1m9Ah6r/lsU2/JuoUqZhHzRPlO28Cix+7uLEY5M+JOi4Bk3XmSb0?=\n\t=?utf-8?q?+dthsQQHyaYLdRHsBfqsoZ3C9k/aqsTAMULcAt1yGq9/G70SUhlccWkpwcdyY0U0G?=\n\t=?utf-8?q?DrFX+zqh9RJV3lyK9388tPisRl7nQtzxzuhz6zccU5J0BXWD8auE9LirMkydpcam9?=\n\t=?utf-8?q?r9qOyCqj1KsWLxgZTSDyd0l9tILh4PDWlvH8PFcQ5tRem+kPrWWmiXbBB4iZAx6aX?=\n\t=?utf-8?q?zPRZ3GsAQSxCJiiZ2tI1XaCPlAJfbGNQ3KUT+zwJoJWvqrU9Npz06+miOR74blo7Y?=\n\t=?utf-8?q?Kcg62nztQ32vxy/LHEIimb5XgseDsvnNbEpletYvbhrc/vSr3mULFwm3cs6UyzEKa?=\n\t=?utf-8?q?QK5HP4eRiDh++6Peto3CgbFe5AxRT5xD2P38JHQXPCmzRqYtKP0ZbhIlzyDV141rd?=\n\t=?utf-8?q?Pckv+11A5UeAle/CFasWsryr2jOEqYK7p0C73eqSH/CHtH6uA75yD0VgBPXri5lVJ?=\n\t=?utf-8?q?wXUfgJAoDJsZCDT8ZQJfeKGXNNeT3vhgvTE+JtCbmwoHRYZUUWl690RL48kJ2mBU1?=\n\t=?utf-8?q?hVW5wy1RkzwOm5ErvSct7jSHnjTbCVFtaDnDgHDwDzdJaJac6XxxS42uLIcL3oDyU?=\n\t=?utf-8?q?QVtme3z9T28h4T3R3Nj3N22jI7OjbLUjA/ylmb18NTffVa6YdfATdcJxarmBVy3W2?=\n\t=?utf-8?q?IBOQm+89zjGU/iOWrA0qwouDZjEXn2303Z4SxJTo0uO8x4OIy1SlxtBhVAVObEKRM?=\n\t=?utf-8?q?sDxsbz5cDWR/M1m1Dkrw1d1Dswm0230JtfXmCFVcwxBaPsqWqP+nf565itky/bBLw?=\n\t=?utf-8?q?ipqaM7sZ53s86dBb40QcY/dqfpoeyq3Gn+WCVvRCPLpY6c1XgSsjMvNEoPP+YrJcG?=\n\t=?utf-8?q?MGUQq4oNq/KwxcG3+9W834lGIaTvCsYpNrPBHAVQISTjWKXdFwZoBwOQHdQMw732M?=\n\t=?utf-8?q?1HNs3dN1mkm7j5o0Ul2nbrc7+wJWTt2gB/L2Mfsh2nGK84EwUA1v31CjW3/F7D+sa?=\n\t=?utf-8?q?eG96GAam3VS7v9SRpibWSWkWSbNlqYyChpsN7pZP0GstRPflQiG32kBvmHetKfsFT?=\n\t=?utf-8?q?csCp8wTpM5U4mJnSa2hFjGrNRsVWLLIew8QPaM1g/5e9fSIc5uP/9x91D7UzAbrQr?=\n\t=?utf-8?q?q4vZU7BGHtjI6w1j/3Wq2p6BstY2mXmMIHVO6jio35MScbLqnMj4XlU4ENdzPDWtT?=\n\t=?utf-8?q?bkUXsDTaGDB9ioRbk+l/kwey/4gvTcNvRH1y/I1gSeq+FX+mN1jSIn1EYZRyoaENb?=\n\t=?utf-8?q?RjBfmveaOFdORGENGQ1gXmp5D2cE9w0FpiC5xarY5/aZweIkPE1G3DfSwmaXDCYMj?=\n\t=?utf-8?q?a8817jrrLmlrDgoEgisZ70CdmaYqzU6aWWyojUqWzsVqiYk3Xvf7Rq6iOjSOvjN4O?=\n\t=?utf-8?q?J5M/R9kDAs531ymNqG1WuHWz3LIffIRagBvUhB5MwQug4/s2XiKjmc9hgb+AURtjw?=\n\t=?utf-8?q?xlfxMTLMzAYPEMq/d+JxP1q5oJlYSqKSqX2eSbRUpCw9CKlX3fc1uc7fLz9LXrqIk?=\n\t=?utf-8?q?rAgL90NohG+afS0wW2x98D32r+CJje5Q=3D=3D?=","X-Exchange-RoutingPolicyChecked":"\n AsAAU4MyC7vo0r8YN/4TIlSX4gssaAaXtuo3g4FuENtVDxVvhJwab6weKG2Vp65hpCfqxkQ4yHIfgeOpinQXmele1bdMoQ1yTAtqEs9/ESo8FyzAP6GVVUSPYoMw6Cme3hXlR+kuubk7FUyTNZk6OTgn4lZvjLTyjplBnSzxhvZYryZ6fO7UySg0d40g4drP5mkBOjLByFAZFoxZGXb7+Vzt41j+98sB0ZyJVIgAmVKUFn81yh+oX7SpqeWl19LM7Fw918LUacszvVOqY/0gucNhskf+56tGAPRriwWm7MlCdAM5JFpmUofZ8sGZOGWChZpsQLuRSEBn3uI5e7KT7Q==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n ef2c34eb-77a6-42b5-d894-08de9a6ec88b","X-MS-Exchange-CrossTenant-AuthSource":"CH0PR11MB8168.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"14 Apr 2026 21:42:53.6930\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n Q8Q61g5sxCd6QH+w4+Fs06xRerbWzivV6iNX5Gj5D0nC+JglCjuIYdKoAwGDwGmNRlPg2sP409TPLkVO47JBRtvxKWVLIKQHqZ0Diumr/FI=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DM4PR11MB6504","X-OriginatorOrg":"intel.com"}},{"id":3677410,"web_url":"http://patchwork.ozlabs.org/comment/3677410/","msgid":"","list_archive_url":null,"date":"2026-04-14T21:43:33","subject":"Re: [PATCH iwl-next v2 2/2] idpf: implement pci error handlers","submitter":{"id":1670,"url":"http://patchwork.ozlabs.org/api/people/1670/","name":"Tantilov, Emil S","email":"emil.s.tantilov@intel.com"},"content":"On 4/14/2026 8:13 AM, Lukas Wunner wrote:\n> On Mon, Apr 13, 2026 at 08:16:31PM -0700, Emil Tantilov wrote:\n>> +static pci_ers_result_t\n>> +idpf_pci_err_slot_reset(struct pci_dev *pdev)\n>> +{\n>> +\tstruct idpf_adapter *adapter = pci_get_drvdata(pdev);\n>> +\n>> +\tpci_restore_state(pdev);\n>> +\tpci_set_master(pdev);\n>> +\tpci_wake_from_d3(pdev, false);\n>> +\tif (readl(adapter->reset_reg.rstat) != 0xFFFFFFFF)\n>> +\t\treturn PCI_ERS_RESULT_RECOVERED;\n> \n> FWIW, there's a PCI_POSSIBLE_ERROR() helper that you may find useful\n> to check for an \"all ones\" MMIO read.\n\nWill check it out.\n\nThanks,\nEmil\n\n> \n> Thanks,\n> \n> Lukas","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=YGFcUVlG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52523-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"YGFcUVlG\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=198.175.65.16","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=intel.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwHqP5Z2Yz1yD5\n\tfor ; Wed, 15 Apr 2026 07:44:33 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 6D901305A8AD\n\tfor ; Tue, 14 Apr 2026 21:43:40 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E6F49386C0E;\n\tTue, 14 Apr 2026 21:43:39 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.16])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EED323E358;\n\tTue, 14 Apr 2026 21:43:38 +0000 (UTC)","from orviesa002.jf.intel.com ([10.64.159.142])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Apr 2026 14:43:38 -0700","from fmsmsx901.amr.corp.intel.com ([10.18.126.90])\n by orviesa002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Apr 2026 14:43:37 -0700","from FMSMSX901.amr.corp.intel.com (10.18.126.90) by\n fmsmsx901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Tue, 14 Apr 2026 14:43:37 -0700","from fmsedg901.ED.cps.intel.com (10.1.192.143) by\n FMSMSX901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Tue, 14 Apr 2026 14:43:37 -0700","from PH7PR06CU001.outbound.protection.outlook.com (52.101.201.53) by\n edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Tue, 14 Apr 2026 14:43:36 -0700","from CH0PR11MB8168.namprd11.prod.outlook.com (2603:10b6:610:186::20)\n by PH3PPFB9A266170.namprd11.prod.outlook.com (2603:10b6:518:1::d45) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.20; Tue, 14 Apr\n 2026 21:43:35 +0000","from CH0PR11MB8168.namprd11.prod.outlook.com\n ([fe80::9549:c8e9:6748:12ee]) by CH0PR11MB8168.namprd11.prod.outlook.com\n ([fe80::9549:c8e9:6748:12ee%5]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026\n 21:43:35 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776203019; cv=fail;\n b=VGvDk6iXmDz8g5d1SCgfDU4955dwkcxj0u6OI+dfcu8EI39qpjAoRCMDCQgynqAgvABRvxoSufuEYUobKUfiZYq0YRqT4yoaYo8tg86ld1FiF6owfpTmPppX8qvv4E8Zeqg9YooRg1rmkVHT9ghJRDxjhGkqSPN5Aw1MXHAd0RM=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=l24nCI3ZpN+CVeayl947WxWbx/jSANQLhJknoyttNFln+3gzd1ywgY1IucMSxR2SbCZQGsK19o6bKoPYmOsC/j/DjoVNtylN8jIPfvMATXkholDdvI8IUhnc6BQCxDtLdA+gvOVKXn1megmCx6lKyZb6GMY0oQhtp8dOGfF7ZLgWM/ASfXP+uQxAZeKTVXbB5FOa3XrSH4jdbgUZ59Xaz8tQ2+13vs/0dh48zNtgKFeYWcKYNw0EaGAEHUcIAWcUwmLbOlc6QmROBzn5SC0dpLM73iQFL3ugGBH2DIKGW4j7Ocjmy9JR37Nx0QIKhVXBZ/KfQZrappYCkj8lo5QNtg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776203019; c=relaxed/simple;\n\tbh=wdbyWgK8cBTx7AiEf5kG4Y/U/QSH+0GIm9brvmiaZf4=;\n\th=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To:\n\t Content-Type:MIME-Version;\n b=cxC/5M5xnqcdWvYTQLRZBxYpdQnM652hxFiOeE0va5naS/sis8nY1nBjoYOsr+dUTww7nasQAneUmK7aBdido5W8AWiUMFilTTVaxXO/aaI+DIqOMXDfPOGKnAtG8xQZNYx1x3wzHh/3159zKJ6PJYfrDBltn66Lf+9Gxeyphas=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=pOJS7qdn1Opi9/bjZyrtphFkdesWGHdW8piHcVaA1Ds=;\n b=ZJxQ6PQdSlaEFlqhdE388s7MUkq9q34AIskFvM/1YNhj6pCO61jpa+NTohzyP4OB0DjC1anXQm1FYNDDiB6rqk6JtkyNUvLfLlmf49zYgyCH/1BEnXZtpBHlj3g4k1eN7U4STtwckpJHwKL5Tk3O3R3a1SbgJ/TgaZBLLK8mFSo2XfjNTCgRDegOnuDYtmJ9tOOIk1a7Xz0PLL8TPA7szMNBpf7fklkEKYN3oKGSGFczSJyfx5HgwAGcyKw8J4tAbKTVi47uDWmFCgzuYWEq05TZ4DD9xahTEP3DVUsud1mt9yDB8mSDQms9H7ESNlv3Bfsd47HRNvtDr5QuPy/pVA=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com;\n spf=pass smtp.mailfrom=intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=YGFcUVlG; arc=fail smtp.client-ip=198.175.65.16","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776203018; x=1807739018;\n h=message-id:date:subject:to:cc:references:from:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=wdbyWgK8cBTx7AiEf5kG4Y/U/QSH+0GIm9brvmiaZf4=;\n b=YGFcUVlGMQ/vQM5WNg/VQoATvwtQCFN5gpf1jOS+MGOnPTUGj2NMAuZs\n jWf7uheTw9IunSGhvy4xi3hxRt60lffqII7gS0xKnETHGGxMTL2vuAiwQ\n uzJp1oO6kGKvRIOpyQhO+v2KNM11pMhFxeGGY/ZYnXb8twNFRg6eWw8NA\n a8R8js1uSPyM0U0EfAiondHvZSAIPy5TbpZhgq9axaLV0Xr4BOnmEZLFD\n +hL4TTQcYzLfrlQjXEQ05Cj0PTcG+JRIjJoDixhFnVkdGPRDtotn/fIpd\n feVRQc19ScFGJhPhEFs+HSBbniInTYdZz+MH2VDY4kdoKsjtoZD8RJYRj\n A==;","X-CSE-ConnectionGUID":["jUryykwXRPSDAGRg7gvtwA==","L7cQXSMQT/WmCOC24KRBpw=="],"X-CSE-MsgGUID":["fdAXEIzeS1qhZ34zjbvCsw==","o3S/1j5RQ7uPnEjwwBlkZQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11759\"; a=\"77353743\"","E=Sophos;i=\"6.23,179,1770624000\";\n d=\"scan'208\";a=\"77353743\"","E=Sophos;i=\"6.23,179,1770624000\";\n d=\"scan'208\";a=\"260641607\""],"X-ExtLoop1":"1","Message-ID":"","Date":"Tue, 14 Apr 2026 14:43:33 -0700","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH iwl-next v2 2/2] idpf: implement pci error handlers","To":"Lukas Wunner ","CC":", ,\n\t, ,\n\t, ,\n\t, ,\n\t, , ,\n\t, , ,\n\t, , ,\n\t, ","References":"<20260414031631.2107-1-emil.s.tantilov@intel.com>\n <20260414031631.2107-3-emil.s.tantilov@intel.com>\n ","Content-Language":"en-US","From":"\"Tantilov, Emil S\" ","In-Reply-To":"","Content-Type":"text/plain; charset=\"UTF-8\"; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"MW4P223CA0018.NAMP223.PROD.OUTLOOK.COM\n (2603:10b6:303:80::23) To CH0PR11MB8168.namprd11.prod.outlook.com\n (2603:10b6:610:186::20)","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"CH0PR11MB8168:EE_|PH3PPFB9A266170:EE_","X-MS-Office365-Filtering-Correlation-Id":"212e006c-a3ab-48be-5de2-08de9a6ee16a","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n BCL:0;ARA:13230040|366016|1800799024|7416014|376014|56012099003|22082099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n 02l4WUrvwOiwynD0eMnoeagxZ9tAwH1gXB6sdyp6zpGz69MsNJEv80MGo8UgD8kpWmQ08le8/W7LYk0LX6r/hArHs/WMvq4N+al/yiWKDF5L/olSMp9y8X/8DbBT1xyUIbNFQeqpgSoS3hgReNEEqybsQTv2dPLZ+5wi4k2g3YTP9yqQPBKJwJJjYvbHtodwBn+ryOGALQByv+EzPSIywEWJxh1DjL7HIvHGl2u6zKyf3nPTsGErJ5DmAU0oXv99RVyHRNklbS3KVH9BtRPQsWxzs/a5EZ4h10m7ZcXqAx1ZzsdGqdbSMXCLMZV1N/oD0LyI3EwhUFYsJXxF7GIyXAUyV6gZq7PeY3zzptQUHEXkspOnLv8AtDbAfNBzEBw82GUT+xK42TKe8790y1bU4AJogU3pK+l2D6LBcuwnxP+AN6qEALkuReu8gzuknh+ohz4/f7cg+NgLFP5XRuBEBqvGPbBer+kSciTHV5DytwLvTmOtYDsi8zcYHJEODY/wHVBjOtLF+RwwJlSVJuPzE15NeZsllmY0Eymf/f4AKF2lJBYM7NfldO1+kTOqhAysAOUocYrbrwc3A5ytdJULRsFF+XkhBm3B5iKY1IBY8JUTrcmSmAagC6QqGDfDCsb0/DHSZWXpanMLC0RS5gBnIsXHfDGjj3yN/rrhFiX+kl4YZ6pSnEqN9abBLK+6req0yjF/XONF/LP4NJFywt0x9nIVQMZLlWnDqEDZBOkVy7M=","X-Forefront-Antispam-Report":"\n CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH0PR11MB8168.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?bvR1oQSJilPhFIfkqISMVVa2M4lR?=\n\t=?utf-8?q?u0uYqLRW/FZZVCUDjeUXbdDONzqwdo1FeNXfRQAAX4hEZ+LT9ZYGNhRs/ESwrQwpw?=\n\t=?utf-8?q?99ypfQXweTIkJZL0QI69JiiQZm9YFxzAkdI6f+pJF2aQJV2IIVhEOPn5LlxteDT7r?=\n\t=?utf-8?q?k17RqtmViVDNS1Rv7S+XRMbOINYIwgw00u3NVgipm/qO04eji0zocmP+Dop0Vt5HO?=\n\t=?utf-8?q?Fdyf6lvHECoAna5IiZFgN+5pyVzw5EVrRgyuq1Y0MQg6c0fh+K/pDnkHxKAdobI77?=\n\t=?utf-8?q?tC3pspl2YEDxN503G0+HeYAJ3igUNFd/CAdUKQMHlFeKjntWlclnLKIAg064lEbWy?=\n\t=?utf-8?q?TupkV80EytaHNtBqOtDntydUoDJmfy+ottNpJutTmO1ua5qAtOgg3jgSQWvAqCfqE?=\n\t=?utf-8?q?PfreWlPJpSYkOUrOkBDK/gXszCrPJf3An2CYO7eWd81uppEay2mnTDSeM3ydIFi53?=\n\t=?utf-8?q?BQIydch1mprmONSMerHzFAFi3vR9wRVKQ9gjiV4dEji+NEG1DGl+xoJuuO1muh1Gs?=\n\t=?utf-8?q?UHVNS63gw0CR+9qNmKFNTRcsXI6hK38WXayej8aI8+ikNObUpDVsCjfnt6IQF9szg?=\n\t=?utf-8?q?aAmzpf4E4pJ9aCfyYtG96A70eQfJnOJmSrFXJfG2ZeQIeBzJHGoCeeR4GIeO5pHNw?=\n\t=?utf-8?q?NsKsHkEfRYL25r+T2E4gTEFYFBLBZL5DGABkWrssJjJ8g7lAERgOFf283J7LuMh8A?=\n\t=?utf-8?q?zB2PsoygjxIkPcBiudBgkkNr9bLlOGuXkNhbRpKkSkH3fGIw2RNyPK5vw+DPEGkEA?=\n\t=?utf-8?q?X054yxLFjQtYGqCQUNzsfLpudOSCBTrQ6cpI+L3CimfBPLAEFEK0orIVPfwcjhDYP?=\n\t=?utf-8?q?cNZeCTFAWDDtBEEYJoZMPEoZDILA8aht/fov60Pp+CE9vtYm5Ks2ctp/8RgiPu5uL?=\n\t=?utf-8?q?SvUiktwkX3F/tPtek+N1xj8vGD1ttiu4cHa5HryUifvo/rnnEuIEbtdZVRhIzBIMN?=\n\t=?utf-8?q?ZdpVQlUDjVmWqksjJIiiJFAYA+1G4lRSsNVe2Ps3ekYruTbCNT/te+I+wTEU0zHv5?=\n\t=?utf-8?q?N/QrMOGohw7H+YDzitBLHP2RiVI3JPTuGKVVkh4hhP+aun2hx0GOmYzCTJ84tC7e8?=\n\t=?utf-8?q?Mt3dYeAK0kfvYciT54E4BFDDymuwJ2P7rvzJfDUbvSWS5k3iZ8h7oGzlhMw3addFL?=\n\t=?utf-8?q?npU0LntyL1pEqlrxmgRQ1d5Vbcd8/N7QWqeGQ6bENLNoji8UAKdiI2ao9a5pA+4yc?=\n\t=?utf-8?q?j/h7nDF8nsbWsXEZNPcwiPLCCqV5PB8whVrmosBuR+YZbYhtO9qKX2gXf+ry+18Ch?=\n\t=?utf-8?q?JjDmOZgrFBE6Ix2+jEiHO/FtpVOQWkNgOqcyh3NHGfd2HyzkK2rF82q9PitrSTXHN?=\n\t=?utf-8?q?6OBQYOnoP5/VRgbFhdvYyIIhay3HfptYHhWKmOln7PNHjKuSln9ACn/1CBaJsvpSv?=\n\t=?utf-8?q?6MiV9g9AhzWOtwf0HYzIBBxMXyndRKvlDJDX4W0rqOFwVuYbOB/dJ2KnKCZKP9H+d?=\n\t=?utf-8?q?T7M84QFv93VKwxPnyaKjjedYCsyF/HazfTBLw0lcEs5KSdb7uro1XU4c/ETCl2zWp?=\n\t=?utf-8?q?/FzYXKMpykvQUTFZr52LpWxjcS3NwzW+ZWAg55aYhUL28k0vFeKDUuNq/17YvnyKH?=\n\t=?utf-8?q?CQTcUdcWWu3BW6iapuOqvNFRidcYccD8IsX+Vw6uokKaJ6aAlWuPxr4sSPw9urc+M?=\n\t=?utf-8?q?3s7xEbhLaJZXkYebOeQjOSjyZ/KUx77ORKp+IEbFmOUhmEMOOcM+I=3D?=","X-Exchange-RoutingPolicyChecked":"\n AKWyX0HuDWJOCpKX3ruasZna4pcHEhGEoHQFoIMU5vpK4dVGGJ3EeakqDAAO3U//ywI9UkHjTUGAnKtMjapT7YzyxsCalrNsia/pwu8bFnPBx0FepGs7QxK16XGZjmEwm5/5aXbMLA6q6dEmvJIRcgJ3ZkOCpCKYRDr8drD9mjo6BFjpoOcc4s6Nqd3h8s/mPTfAadst97MLUSPsHGahI82K3TFIsqtR8WwmjATFs2DejAQz/bUePKGL2HCUpyGy77NE7EZqMNqsO1hinRkuX/gjtzFMsb7jpO4CRZMnb4PkMuOpLP6Ze07PtB++P+pOH6xE8CjZSS/pJ1elSH8MxQ==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 212e006c-a3ab-48be-5de2-08de9a6ee16a","X-MS-Exchange-CrossTenant-AuthSource":"CH0PR11MB8168.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"14 Apr 2026 21:43:35.3047\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n DhksSAxrPrrZgUBbHROWnMSoD7gTMFGd2h9DKBSeejgWnDcsV/uv9QtFSAPaQyrJohqxDGbVb9e9k+e6bhbv2LhTPQNTkkW0ZQwhsSEqADY=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PH3PPFB9A266170","X-OriginatorOrg":"intel.com"}}]