[{"id":3676993,"web_url":"http://patchwork.ozlabs.org/comment/3676993/","msgid":"<3fc005b6-c4c6-47ec-944d-42b7d63e9d16@linaro.org>","list_archive_url":null,"date":"2026-04-14T00:48:12","subject":"Re: [PATCH v3 16/27] target/riscv: Register target_get_monitor_def in\n SysemuCPUOps","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/14/26 10:29, Philippe Mathieu-Daudé wrote:\n> Rename target_get_monitor_def() as riscv_monitor_get_register_legacy()\n> and register it as SysemuCPUOps::monitor_get_register() handler.\n> Take care to sign-extend values for 32-bit HARTs.\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> target/riscv/internals.h | 3 +++\n> target/riscv/cpu.c | 1 +\n> target/riscv/monitor.c | 11 +++++++----\n> 3 files changed, 11 insertions(+), 4 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=j4D2oTBK;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvlyl4pLrz1yCv\n\tfor ; Tue, 14 Apr 2026 10:49:02 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCRxC-0007CR-U9; Mon, 13 Apr 2026 20:48:34 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCRx9-0007BW-Nq\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:48:32 -0400","from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wCRx8-0007YY-AI\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:48:31 -0400","by mail-pj1-x102c.google.com with SMTP id\n 98e67ed59e1d1-358ed696623so2175223a91.0\n for ; Mon, 13 Apr 2026 17:48:28 -0700 (PDT)","from ?IPV6:2401:d002:dc0f:2100:377f:61ec:6edd:e205?\n ([2401:d002:dc0f:2100:377f:61ec:6edd:e205])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35fc2bc5575sm634015a91.3.2026.04.13.17.48.21\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 13 Apr 2026 17:48:27 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776127708; x=1776732508; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=WkvlF6qPczmnYeE3GYMCHsrp99mpkagfHrJUEXOYIZg=;\n b=j4D2oTBKnXJFFKh9SkdUI3nSS2vJIASJc/bAaIqHiqeDb930zJPbPpyeQ7gPb8iYMY\n 2lZuFdTDVlPa0fdBslyVivYs3Wn0zQYt7CqKmMC6RyZREJnqzZhHVO+ueqXZ7mjVq5JU\n P/brkWt+kO21h520+KUnOKdGjLQNpWbq2P8mpqLeKnvQpyio09jNDyD/sIUmSZdcqv8i\n vKOeNg/Q7PjLth1oV7feF3inwRkF4hyFqJgIdA7PeS7+z/XHU0WmSVI5GicksP2o+U+S\n NaushbwkoxsYEgfDisRLyrKLvKL+xgUT6kYMxlN/ENLnVdD0jdOMLQ6uSJaPauSFe2LR\n 139Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776127708; x=1776732508;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=WkvlF6qPczmnYeE3GYMCHsrp99mpkagfHrJUEXOYIZg=;\n b=pekEsWpg7MFSEOC7QENbmJHLjGQDrBWA6x4stP2p4vtC9j4UbCjsT7+9+gX42+xJw8\n rYGfxDPCWyuXLTpgxi5/fH7dnDgZ2FQtXAenBJcva9XipwNrUmPwsprjGE8SpwSfUJop\n hhM9dU43zSMd2wn50PxhITrn0kjljT+vThAxT3DQeG4IK7ypr0tDIJj1KKBwJn1vuY3X\n JjDHB0Jy2CoRNsohcqNWjx1JosEYGJbp5fPmY/intiHjt3J7EbTbPDHF9cauIq00Jxr4\n KoaJvHX3kHr54Rm2AzrFKv8nn1vmDD+IzxAsY+yhQRqYyQK4vU6BvtR1nZ2+tHOg5Rtb\n TQhg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/9mDtu7Wgh1VOtAfrNB+BJ2Qg9vLZkvFnroaP56Vp2qtRvaU8rL+V87xq34utXo7bGHXatTYko4R91@nongnu.org","X-Gm-Message-State":"AOJu0YyZkUi+lKDReZi0LagjtQ38DHydng5Wtl8FnNKreiVM+idTw+Mg\n 4ru3ZsjaKjxZvIHVVxzbzgp8U6luiegJ0whoDNUdOGzGDQhIAWDfnCRYHqrs1GFrwXk=","X-Gm-Gg":"AeBDieuBh46G/oUEiZenSsBC/j2NhNLgefOGlizVEYjVk4/HtOE3tix8qO/PTZJ4kJv\n LdOA2f3s5wVk8r27Ba/pKGtws2wktBA3M7p75pWU3JaKomiTuqHrErq6WqeOjh+f4z0YQiVytMX\n 5DlmYILrvWohpPIaYcb70/ufePKlUcr9YW8Jbv3xSjHeHRnqVMwKncfJ4cKw3iqWz0OOY3FQvIV\n /B3QBJSZZj6YytGdJadf2vuP+Bre7PdIHzPx8hY5EoTwdC4mJWMJ/CAWXWiWP8BtUxUkgzZB8Pn\n CrW9qUfVX6tYibb5N8R047G5gnRJ4ZKZdPqe5H18vUutRJlBSedmzVCfRlOHGWl2osktFQlem98\n 4L1NkBVYZKLd83NQGhM6pskgTW5J4/JypLj8aIselQrwWaPkS1bJy8O0b0Z9GpC/SZ0U+tMhNku\n W9B8bSVXS+idoATJgFRcisAtztgQgvUqkehNqaKjMVbuEDqaKwVyFf5+6PGwtc404q0CYqXKS3q\n cFUaz6RhZZjWA==","X-Received":"by 2002:a17:90a:d403:b0:35d:9560:3efc with SMTP id\n 98e67ed59e1d1-35e427e6277mr13965107a91.14.1776127707746;\n Mon, 13 Apr 2026 17:48:27 -0700 (PDT)","Message-ID":"<3fc005b6-c4c6-47ec-944d-42b7d63e9d16@linaro.org>","Date":"Tue, 14 Apr 2026 10:48:12 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 16/27] target/riscv: Register target_get_monitor_def in\n SysemuCPUOps","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"Pierrick Bouvier ,\n Markus Armbruster ,\n \"Dr. David Alan Gilbert\" ,\n Paolo Bonzini , Palmer Dabbelt ,\n Alistair Francis , Weiwei Li\n ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , qemu-riscv@nongnu.org","References":"<20260414003001.97571-1-philmd@linaro.org>\n <20260414003001.97571-17-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260414003001.97571-17-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::102c;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]