[{"id":3676990,"web_url":"http://patchwork.ozlabs.org/comment/3676990/","msgid":"","list_archive_url":null,"date":"2026-04-14T00:45:36","subject":"Re: [PATCH v3 03/27] monitor: Restrict monitor_set_cpu() method scope","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/14/26 10:29, Philippe Mathieu-Daudé wrote:\n> As mentioned in commit 755f196898e (\"qapi: Convert the cpu\n> command\") 15 years ago, the monitor_set_cpu() method is a\n> temporary bridge between QMP -> HMP and shouldn't be used\n> elsewhere. Make its scope internal to monitor/.\n> \n> Signed-off-by: Philippe Mathieu-Daudé\n> ---\n> include/monitor/monitor.h | 1 -\n> monitor/monitor-internal.h | 1 +\n> 2 files changed, 1 insertion(+), 1 deletion(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=nlJ/sPy8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvlvB5kNfz1yCv\n\tfor ; Tue, 14 Apr 2026 10:45:58 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCRuW-00064n-74; Mon, 13 Apr 2026 20:45:48 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCRuV-00064Y-9f\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:45:47 -0400","from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wCRuT-0006w8-G0\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:45:47 -0400","by mail-pj1-x102c.google.com with SMTP id\n 98e67ed59e1d1-35691a231a7so3224783a91.3\n for ; Mon, 13 Apr 2026 17:45:44 -0700 (PDT)","from ?IPV6:2401:d002:dc0f:2100:377f:61ec:6edd:e205?\n ([2401:d002:dc0f:2100:377f:61ec:6edd:e205])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35fc6f67d76sm203884a91.9.2026.04.13.17.45.39\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 13 Apr 2026 17:45:43 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776127544; x=1776732344; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=VoCslziiPwaWRtUKpDtrC+VAakxSfNwHcngSk47IUZU=;\n b=nlJ/sPy81UCRUTYlG1xNnzNUbvMziO+iPH0CX1Qh5QVj6Nzbf+l9BIWjtEUnF2jNL+\n driimBkNPsVijXNEbDWPSQNovGyL2rzdsNOe9lDoFPo88TSCw5CDVUjAiNynpiJzrf4W\n R/Tcwpb1XzCEhQ1/ivtbpj3AnRQNQkiBGXaqVqCgB+cPWHnNvMAgH7jTjYL60OcXdwT9\n M+hY15cCEOdIxE7vl099i3iExTZ+SylDhtekJdSHgDxtCZApDYMeccgyau8MCef1XEpo\n eJguzE8s0eFnztscD3nTB0Ec/+GhXOvJoQic9EibBEjCbwvRzzMeoocYEireHRMwoOJJ\n peOw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776127544; x=1776732344;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=VoCslziiPwaWRtUKpDtrC+VAakxSfNwHcngSk47IUZU=;\n b=NcKrm6ofK4xrhnneTHn5OQyVTFnJZ2YjLuuHoyS3SuSeWvUlnqldZgAQ7Nx2FCEEvU\n sqxBdzj8+2pFVnUnSPpcRHFigccX+hjKbw08cLgTgvX26CRwDCwiGUPbUcGcCqVlgZAf\n MwYiqtOaCTu2Ei8bMn9/tkDjNDRxJjWbH2LkPTn3Aell4gU/mjezdY05O+H4OLrDE+4f\n ylUm7aKtb6uQCgc5Lm/SzBPhTMtJXDIBdqcaU8Dv7R8kB5bxmfG2zPSkE1djF3MYnBBO\n Yf4iK2Ddz4l42SrLy/RYeEzM5YfJiyWH11nEFyxrp9EWWwfF/RFuu3SiaVF4J0yv9h6S\n dqAQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/vUlwRIZASdnDz3pdcyrL5rLK0fPozrxySsekgtK5xKBNniNxip6n0HC+O9WQPa6Js/qnQ2jMAPbEB@nongnu.org","X-Gm-Message-State":"AOJu0Ywy/zCNi8qzWvq2do3Gs4NHAzplkadrckf8WdAyCQSJTS/NDQOa\n n0NqTFO+Vt/kLr1DoZfRqI3fQHJkeAJMjRH6t3eCZMUSnaJoesScQMrA86NbgK5v1WE=","X-Gm-Gg":"AeBDieuXNq+YIqLGceOKKMS1L/DBSFh/47rlIZBdsH2PV07TZl6D3CxQ9e+7r0dG7b+\n TW7PIqHD+TcsO2qGARe4ZlO6h7yBrsXiFoHB0rRlv3jpFj2rHl8WFSHgpt72JH7sAjhSDS662r2\n JSs+TTY6d8dKx7lz7UBLtMGzI+NG1JbI4hH7HECm/nbMPCh1AACsuSOZ0VWAUANNjh0n9HOzhad\n JaWqOmNSP0pyIM/ReJyHR9mxJDWYvU1aEPlqHFqtGrpWvDctCdSPOWSy/yNB+rkpWd1FVFh6W3Y\n aBjDT/Upr7ElmZfl8kGLryejQVQSPpX2x1JfPegFYjxNq5RaS8O9vByJXXW6C79YVfOLNtwO7pp\n 3DVY75zaxF8X1zqwKJu+I+ma36deUjesRv6S5LYqUuqn8Vna/yaAxM1wfv1hBKrdZcGQWdwew/E\n ckc3L+6FDHTyvVyHDrJwc7dQ99YCnujitjlY/44ma78SK7qXMokcGAg6RaYxxNUj2I+zYmDbonX\n +1P4ztv9oIfsA==","X-Received":"by 2002:a17:90b:4c8e:b0:35b:9ab6:1d4a with SMTP id\n 98e67ed59e1d1-35e4280ebc7mr15683526a91.18.1776127543578;\n Mon, 13 Apr 2026 17:45:43 -0700 (PDT)","Message-ID":"","Date":"Tue, 14 Apr 2026 10:45:36 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 03/27] monitor: Restrict monitor_set_cpu() method scope","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"Pierrick Bouvier ,\n Markus Armbruster ,\n \"Dr. David Alan Gilbert\" ,\n Paolo Bonzini ","References":"<20260414003001.97571-1-philmd@linaro.org>\n <20260414003001.97571-4-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260414003001.97571-4-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::102c;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]