[{"id":3676935,"web_url":"http://patchwork.ozlabs.org/comment/3676935/","msgid":"","list_archive_url":null,"date":"2026-04-13T21:30:52","subject":"Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix infinite recursion\n in ice_cfg_tx_topo via ice_init_dev_hw","submitter":{"id":70275,"url":"http://patchwork.ozlabs.org/api/people/70275/","name":"Paul Menzel","email":"pmenzel@molgen.mpg.de"},"content":"Dear Petr,\n\n\nThank you very much for your patch.\n\nAm 13.04.26 um 21:14 schrieb Petr Oros:\n> On certain E810 configurations where firmware supports Tx scheduler\n> topology switching (tx_sched_topo_comp_mode_en), ice_cfg_tx_topo()\n> may need to apply a new 5-layer or 9-layer topology from the DDP\n> package. If the AQ command to set the topology fails (e.g. due to\n> invalid DDP data or firmware limitations), the global configuration\n> lock must still be cleared via a CORER reset.\n> \n> Commit 86aae43f21cf (\"ice: don't leave device non-functional if Tx\n> scheduler config fails\") correctly fixed this by refactoring\n> ice_cfg_tx_topo() to always trigger CORER after acquiring the global\n> lock and re-initialize hardware via ice_init_hw() afterwards.\n> \n> However, commit 8a37f9e2ff40 (\"ice: move ice_deinit_dev() to the end\n> of deinit paths\") later moved ice_init_dev_hw() into ice_init_hw(),\n> breaking the reinit path introduced by 86aae43f21cf. This creates an\n> infinite recursive call chain:\n> \n> ice_init_hw()\n> ice_init_dev_hw()\n> ice_cfg_tx_topo() # topology change needed\n> ice_deinit_hw()\n> ice_init_hw() # reinit after CORER\n> ice_init_dev_hw() # recurse\n> ice_cfg_tx_topo()\n> ... # stack overflow\n> \n> Fix by moving ice_init_dev_hw() back out of ice_init_hw() and calling\n> it explicitly from ice_probe() and ice_devlink_reinit_up(). The third\n> caller, ice_cfg_tx_topo(), intentionally does not need ice_init_dev_hw()\n> during its reinit, it only needs the core HW reinitialization. This\n> breaks the recursion cleanly without adding flags or guards.\n> \n> The deinit ordering changes from commit 8a37f9e2ff40 (\"ice: move\n> ice_deinit_dev() to the end of deinit paths\") which fixed slow rmmod\n> are preserved, only the init-side placement of ice_init_dev_hw() is\n> reverted.\n> \n> Fixes: 8a37f9e2ff40 (\"ice: move ice_deinit_dev() to the end of deinit paths\")\n> Signed-off-by: Petr Oros \n> ---\n> drivers/net/ethernet/intel/ice/devlink/devlink.c | 2 ++\n> drivers/net/ethernet/intel/ice/ice_common.c | 2 --\n> drivers/net/ethernet/intel/ice/ice_main.c | 2 ++\n> 3 files changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/net/ethernet/intel/ice/devlink/devlink.c b/drivers/net/ethernet/intel/ice/devlink/devlink.c\n> index 6144cee8034d77..641d6e289d5ce6 100644\n> --- a/drivers/net/ethernet/intel/ice/devlink/devlink.c\n> +++ b/drivers/net/ethernet/intel/ice/devlink/devlink.c\n> @@ -1245,6 +1245,8 @@ static int ice_devlink_reinit_up(struct ice_pf *pf)\n> \t\treturn err;\n> \t}\n> \n> +\tice_init_dev_hw(pf);\n> +\n> \t/* load MSI-X values */\n> \tice_set_min_max_msix(pf);\n> \n> diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c\n> index ce11fea122d03e..b617a6bff89134 100644\n> --- a/drivers/net/ethernet/intel/ice/ice_common.c\n> +++ b/drivers/net/ethernet/intel/ice/ice_common.c\n> @@ -1126,8 +1126,6 @@ int ice_init_hw(struct ice_hw *hw)\n> \tif (status)\n> \t\tgoto err_unroll_fltr_mgmt_struct;\n> \n> -\tice_init_dev_hw(hw->back);\n> -\n> \tmutex_init(&hw->tnl_lock);\n> \tice_init_chk_recipe_reuse_support(hw);\n> \n> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\n> index e2a5534819d194..a27be29f9bbbfc 100644\n> --- a/drivers/net/ethernet/intel/ice/ice_main.c\n> +++ b/drivers/net/ethernet/intel/ice/ice_main.c\n> @@ -5314,6 +5314,8 @@ ice_probe(struct pci_dev *pdev, const struct pci_device_id __always_unused *ent)\n> \t\treturn err;\n> \t}\n> \n> +\tice_init_dev_hw(pf);\n> +\n> \tadapter = ice_adapter_get(pdev);\n> \tif (IS_ERR(adapter)) {\n> \t\terr = PTR_ERR(adapter);\n\nReviewed-by: Paul Menzel \n\n\nKind regards,\n\nPaul","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=lrIY0/+g;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvgbH6H0wz1yD4\n\tfor ; Tue, 14 Apr 2026 07:31:55 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 98F31840E8;\n\tMon, 13 Apr 2026 21:31:53 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id V7WbNRVIFIuC; Mon, 13 Apr 2026 21:31:51 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 858A2840E6;\n\tMon, 13 Apr 2026 21:31:51 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists1.osuosl.org (Postfix) with ESMTP id 2210E237\n for ; Mon, 13 Apr 2026 21:31:50 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id F2DCA4064F\n for ; Mon, 13 Apr 2026 21:31:49 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id KbWcb8BGkx7H for ;\n Mon, 13 Apr 2026 21:31:48 +0000 (UTC)","from mx3.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 934B4401BB\n for ; Mon, 13 Apr 2026 21:31:46 +0000 (UTC)","from [192.168.0.192] (ip5f5af789.dynamic.kabel-deutschland.de\n [95.90.247.137])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested) (Authenticated sender: pmenzel)\n by mx.molgen.mpg.de (Postfix) with ESMTPSA id 05AB94C2C37F0B;\n Mon, 13 Apr 2026 23:30:53 +0200 (CEST)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 858A2840E6","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 934B4401BB"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776115911;\n\tbh=zm1KPSFYhD0z+7uHzo71WIFaLNZKaTdbV2flW+Oe/ZM=;\n\th=Date:To:Cc:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=lrIY0/+g8kAz+j4RDm6knqUGzKv/Yixn0+avCT9pXAsLfjZWJxZegRAFBjp5DV3qg\n\t T6u/Jf8ZDHSDFlKENFXio9iWF9UUStPrK5DRIyEA+ibTso30s/y7IpDi8TtBbvPG1P\n\t dGxcHI74U/O+U30Wxfr1TH+1kOvHA2H6A2VmiY5zTS90Hc22WcIDngPaKabT+p8zfA\n\t 2MO1GjT9azBkdtpoIYSIFNmG3bVnWCBNb0zDMIN4PZqjvQ0ORvW+z4ORvPXk4ywyvT\n\t RkIPwRgRIrWTT8rtOUYkxtuwFfJjM1XJMoCzYRLOO9J+tSwZ3+NWmoFQx+RBzrLIwS\n\t ebnb87MD7HeCw==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=141.14.17.11;\n helo=mx3.molgen.mpg.de; envelope-from=pmenzel@molgen.mpg.de;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 934B4401BB","Message-ID":"","Date":"Mon, 13 Apr 2026 23:30:52 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","To":"Petr Oros ","Cc":"netdev@vger.kernel.org,\n Michal Swiatkowski ,\n Paul Greenwalt ,\n Daniel Zahka ,\n Przemek Kitszel ,\n Nikolay Aleksandrov , Eric Dumazet\n , linux-kernel@vger.kernel.org,\n Aleksandr Loktionov ,\n Andrew Lunn , Tony Nguyen\n , Dave Ertman ,\n jacob.e.keller@intel.com, Jakub Kicinski ,\n Paolo Abeni , \"David S. Miller\" ,\n intel-wired-lan@lists.osuosl.org","References":"<20260413191420.3524013-1-poros@redhat.com>","Content-Language":"en-US","From":"Paul Menzel ","In-Reply-To":"<20260413191420.3524013-1-poros@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-Mailman-Original-Authentication-Results":"smtp2.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=molgen.mpg.de","Subject":"Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix infinite recursion\n in ice_cfg_tx_topo via ice_init_dev_hw","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3676979,"web_url":"http://patchwork.ozlabs.org/comment/3676979/","msgid":"<356d6a30-fced-4b64-b54d-b69aeb169758@intel.com>","list_archive_url":null,"date":"2026-04-13T23:43:58","subject":"Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix infinite recursion\n in ice_cfg_tx_topo via ice_init_dev_hw","submitter":{"id":9784,"url":"http://patchwork.ozlabs.org/api/people/9784/","name":"Jacob Keller","email":"jacob.e.keller@intel.com"},"content":"On 4/13/2026 12:14 PM, Petr Oros wrote:\n> On certain E810 configurations where firmware supports Tx scheduler\n> topology switching (tx_sched_topo_comp_mode_en), ice_cfg_tx_topo()\n> may need to apply a new 5-layer or 9-layer topology from the DDP\n> package. If the AQ command to set the topology fails (e.g. due to\n> invalid DDP data or firmware limitations), the global configuration\n> lock must still be cleared via a CORER reset.\n> \n> Commit 86aae43f21cf (\"ice: don't leave device non-functional if Tx\n> scheduler config fails\") correctly fixed this by refactoring\n> ice_cfg_tx_topo() to always trigger CORER after acquiring the global\n> lock and re-initialize hardware via ice_init_hw() afterwards.\n> \n> However, commit 8a37f9e2ff40 (\"ice: move ice_deinit_dev() to the end\n> of deinit paths\") later moved ice_init_dev_hw() into ice_init_hw(),\n> breaking the reinit path introduced by 86aae43f21cf. This creates an\n> infinite recursive call chain:\n> \n> ice_init_hw()\n> ice_init_dev_hw()\n> ice_cfg_tx_topo() # topology change needed\n> ice_deinit_hw()\n> ice_init_hw() # reinit after CORER\n> ice_init_dev_hw() # recurse\n> ice_cfg_tx_topo()\n> ... # stack overflow\n> \n\nOof, ya thats not good. I guess this only happens if the topology needs\nto change, so it wouldn't affect many systems where we had already\nchanged the topology before hand on the old driver.\n\n> Fix by moving ice_init_dev_hw() back out of ice_init_hw() and calling\n> it explicitly from ice_probe() and ice_devlink_reinit_up(). The third\n> caller, ice_cfg_tx_topo(), intentionally does not need ice_init_dev_hw()\n> during its reinit, it only needs the core HW reinitialization. This\n> breaks the recursion cleanly without adding flags or guards.\n> \n> The deinit ordering changes from commit 8a37f9e2ff40 (\"ice: move\n> ice_deinit_dev() to the end of deinit paths\") which fixed slow rmmod\n> are preserved, only the init-side placement of ice_init_dev_hw() is\n> reverted.\n> \n> Fixes: 8a37f9e2ff40 (\"ice: move ice_deinit_dev() to the end of deinit paths\")\n> Signed-off-by: Petr Oros \n\nThe fix looks correct to me, and definitely the most elegant.\n\nReviewed-by: Jacob Keller ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=704DhEPF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvkWz2nh2z1xtJ\n\tfor ; Tue, 14 Apr 2026 09:44:15 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id C29AC42779;\n\tMon, 13 Apr 2026 23:44:12 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id UN9MW50fCYe7; Mon, 13 Apr 2026 23:44:11 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 4133E42771;\n\tMon, 13 Apr 2026 23:44:11 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id B087A237\n for ; Mon, 13 Apr 2026 23:44:09 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id A23D340073\n for ; Mon, 13 Apr 2026 23:44:09 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id pwbMXd3PrAaT for ;\n Mon, 13 Apr 2026 23:44:09 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.12])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 98F9A40028\n for ; Mon, 13 Apr 2026 23:44:07 +0000 (UTC)","from fmviesa010.fm.intel.com ([10.60.135.150])\n by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 16:44:07 -0700","from fmsmsx903.amr.corp.intel.com ([10.18.126.92])\n by fmviesa010.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 16:44:07 -0700","from FMSMSX903.amr.corp.intel.com (10.18.126.92) by\n fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Mon, 13 Apr 2026 16:44:06 -0700","from fmsedg901.ED.cps.intel.com (10.1.192.143) by\n FMSMSX903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Mon, 13 Apr 2026 16:44:06 -0700","from PH8PR06CU001.outbound.protection.outlook.com (40.107.209.19) by\n edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Mon, 13 Apr 2026 16:44:05 -0700","from DS0PR11MB7579.namprd11.prod.outlook.com (2603:10b6:8:14d::5) by\n SA3PR11MB7980.namprd11.prod.outlook.com (2603:10b6:806:2fc::11) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9791.33; Mon, 13 Apr\n 2026 23:44:02 +0000","from DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e]) by DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e%5]) with mapi id 15.20.9818.014; Mon, 13 Apr 2026\n 23:44:02 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4133E42771","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 98F9A40028"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776123851;\n\tbh=3dDB3ec9f6DtKJDn1LvAtaeidcnATxYbgWyEYrGgv4A=;\n\th=Date:To:CC:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=704DhEPF22mttQYj1TG+NtD2UtMByGroJlcwZDclS+ZWhMYArlPJ8EAWWd8Wbf4WW\n\t SslzufbaEJIUa6puoS3bdFhhqYZsctmds58S682P4doN+4SxGhM0MIuRLUUb/qbe3W\n\t tGQE+31fLKmdVeoxpun9tnjCC60C/Gz60soeuUwMeo4Rsy0wQkDhshWk3KZVTBXaUn\n\t 3IMcmPIZihoGlTFHqrSZNl/LEgaDLPzFaHjdFI2zIYlX5MDs9Paq2NNGgIrHxw+ETV\n\t V0abd53oviDFRYsvRGmtFvAuVL/eKZXR/3Rw2pAbl57C+dXwpH74C+cJf0VHWSd9vW\n\t RWhJeOhms9MOw==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.12;\n helo=mgamail.intel.com; envelope-from=jacob.e.keller@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 98F9A40028","X-CSE-ConnectionGUID":["SdJeDlPxQ8qzDR63wQQuFw==","WNDrxVQJTvSZG8Dk3KaCxQ=="],"X-CSE-MsgGUID":["G7VR8wseSpGnrZbN4UNgvg==","TlhfwWG0QEuUUCbBznDY/w=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11758\"; a=\"80956650\"","E=Sophos;i=\"6.23,178,1770624000\"; d=\"scan'208\";a=\"80956650\"","E=Sophos;i=\"6.23,178,1770624000\"; d=\"scan'208\";a=\"225620473\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=T7EyuHYdQ4fTbdpnsx3dTluqeHkrb1RztTnBAP7Gzxq7NbLLdqzYRMbrDm0hKQPsAmY39kQHY1Pvh/JblVKvzvNBJdWR9d5Krb2w/3Iwd0ZouGCCO/Ba7ouB43T+594sC3FviVO247WaE3dj4XuaIzVpfyEeeducCvVqO6XNfzm71gDy3+7ghKld2dnCBMpVsy+wSoSNomJdAjEkAs4Am2pk9xwhPhSt3IMRDwy2AHJxd6m97/dpmA4+ru9vP3bcSaxS4IflrB1ZAZOyDOatiRvOGP9hGSqwbMWmp9Fcb4zLN1L/1WaF/JN0lBCneptAdx8ijq0cjMLKSIITvNgq5Q==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=3dDB3ec9f6DtKJDn1LvAtaeidcnATxYbgWyEYrGgv4A=;\n b=eSHKwsh7ttPgv0qr9PFsgLdZU1FgumttgmiBOYUeiY5yCIfLHHvA3vmK6wmtgig4jdyXJDklIDLWHjCruhdE6cHv75OeJyDoOBU4s9WahBJbmD3xfNfD5NcdxTPJmPUoeoCj0wcKjd76zdrND0SgqYqbuWTSL4uSnWbZiYlim+UvkdJRltfyTbJOTa9GwsZ6fYN+x+mYnBeqxh8rSZpFlrM2t8P8vq2H+w/L1SuhfgjgIbDjyBsNzSoGmAJoEJ3mroMbq6KF7Irzao57UR42pMi5jaajGHx62aO5/BoFiJd1CLjTgv/Tp3vpnUxqLw3SEDt8DF4SQOFkZuwfVfu3FA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","Message-ID":"<356d6a30-fced-4b64-b54d-b69aeb169758@intel.com>","Date":"Mon, 13 Apr 2026 16:43:58 -0700","User-Agent":"Mozilla Thunderbird","To":"Petr Oros , ","CC":"Tony Nguyen , Przemek Kitszel\n , Andrew Lunn , \"David\n S. Miller\" , Eric Dumazet , \"Jakub\n Kicinski\" , Paolo Abeni , \"Aleksandr\n Loktionov\" , Nikolay Aleksandrov\n , Daniel Zahka , Paul Greenwalt\n , Dave Ertman , \"Michal\n Swiatkowski\" ,\n , ","References":"<20260413191420.3524013-1-poros@redhat.com>","Content-Language":"en-US","From":"Jacob Keller ","In-Reply-To":"<20260413191420.3524013-1-poros@redhat.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"MW4PR03CA0207.namprd03.prod.outlook.com\n (2603:10b6:303:b8::32) To DS0PR11MB7579.namprd11.prod.outlook.com\n (2603:10b6:8:14d::5)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS0PR11MB7579:EE_|SA3PR11MB7980:EE_","X-MS-Office365-Filtering-Correlation-Id":"bf808bda-1626-40de-addb-08de99b68a26","X-LD-Processed":"46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|366016|1800799024|7416014|376014|22082099003|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n H4D2/lz5uiejBo8MxmXCO9XR97/4HAJYYrN/qYxzJoSvT5jTVXj2G2lbKqmYlLXpQFEJtOt6y7TygzK0L5TCrZHS5Af3XRaFDIMC8yDFUQHo2qQrr12nsQYiSMmikdoow389Gs7sfzpo1OGDl4suE57Gqzmm0d1E0fTDhk5w1TEKo1cAWlbXmg3zEGsosQo8UP+lYf7alLIIKZCeUZReSoc7SAJlPmzzcZXZIHNd4OwSrW1IYy3+Pakqs3H6udzrIHYVxW0qsoRfDpxQ2zMKt1yKww9/p45U9C2/tslPl+wmN/GMYu4ii17rwPGBaN+EixR48vOhWii6LfqDCIrxT7RFSVuySsI/n4Rctvylyw0ZNsn0morJfTWcR/eNsAwLwhUlPLtboCcm4w4gUyicFu9F4wmoE4wCucqkqkoCjbw5M/JYHmj9UXZ66jb55ZWMp7R9ovf7150lcef0zaq5ZNugkFeaoXOAYKaVet//Wan2IPQZ3W5+fAiAzjSk7Hy7I44oyjW9KxKdmI/moquDc9TAtTJcDbh5DLmbmEIT8YmbLCM9VlOXGi8IChxXqgXdvZ2R5fQICuBKR8Q6tRo841t+DlQWeVeMa+Zib69wNTiHXiqcAQfU1UeXBf/MyPPJ5VylrLW1jadkBI2FQh2v/8nQdqkAwc5JDnwfo3ai1k1lkBk8SEHz1OaXG9vCEf/QJpXfJh36K8aKA9tdIrSd6SYjAZZK/hOwZm0lV6ymDQI=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DS0PR11MB7579.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(366016)(1800799024)(7416014)(376014)(22082099003)(18002099003)(56012099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?JRYrE9IoWKSRG+2rRzK9Wqfoob/G?=\n\t=?utf-8?q?qaw/QBXpAwRyt2J9EGIwyDQUJrBel57gtS70pYqJmaKL/GonE+eTP5bHpclbq15mp?=\n\t=?utf-8?q?x8dhJ8tirRkmYFiaDYWsvhjSig1+3bopbrTAOuca12aepp+DEsnXmHZI8qMhwjHzd?=\n\t=?utf-8?q?TTd+F/tYE1SB///m3CmrpXMf049LdAiL91F92Ww7xVQfYy3U6TGdveyXxH9dUXx6v?=\n\t=?utf-8?q?eayj8nfivMpN/rpgG6Ebtz5XO20h8lCZYf/LM6pwWgNn7gFrNOQcdQUPgattE9naY?=\n\t=?utf-8?q?T0kVDv5F08/KZbXPnqBCufPm2Zbn9laFDb92TB1UrD0bRNVr4mrMyvPKXurgiTmfY?=\n\t=?utf-8?q?lXdHVf18V8UEQ+4PU/5J5mYEHIAoF8v5/EDSH9UbXnfKL2Y0chghhVH7lCKKGY42l?=\n\t=?utf-8?q?0SY00S7zjWNhD9tu+aIeAYG+jxPK/Pti6V5BBTXWFVMGvzseZt/7tmOV42itO0rrw?=\n\t=?utf-8?q?RIDzje5m/Fpz1iYEoQx7eHJaw9PyqVREn99Cagys7lBxvf/fwUM0By8oSWaSDBpnN?=\n\t=?utf-8?q?gWInjPjq6AxgTG26oJmPPYThxoZm+uIwpiI0QL7qdkqAvz54EwgdnzlzM8MxL/TWS?=\n\t=?utf-8?q?UtuTgvvtl8VXORiKOJNyYxMvPawc2P6ruj3bOmTxBGtkf8XzMVtfiR/0SXozimhdx?=\n\t=?utf-8?q?kYgh0/A0vd8duaWxfSmoFaoE9gFrBzzQspM/RxelIs9ljIiBDJ4QpslA5TJKW2l+e?=\n\t=?utf-8?q?Jitay/+yGPWNVNZUv9EwL1NLcdA5+y8L5Lft3gAwVpFeSANNJiyq/I1FCa0X3BHZk?=\n\t=?utf-8?q?lXfEd20X/kzoHJ9XdulED/bpVfNzW5XhdJn7pq78lbtKHSxb9BcL0UZ8h+ZfgDAGS?=\n\t=?utf-8?q?haDOIVwrSgPosjDFJJQ17qohY//10HHH4QVyz+WWGNpSdzu13cokbh2zwxUb7skK9?=\n\t=?utf-8?q?asocgs4Rk8DYZOk0xIsZnIGdArnLvv2PjaToTtIM0mN/A3Tg912dO3npdPpPl8kTt?=\n\t=?utf-8?q?zYFVBX8Byqrv9lRL3yxIlsBwTstRprt/7WEqea09ZMEuVQU5To+09tjYFZm5tHlIP?=\n\t=?utf-8?q?vq4OdnYTN7y8LiNZgy952TzoXgTYXSLFGePZuAxaNqUrLYEoOsnJ5O9CAsOopO3W9?=\n\t=?utf-8?q?JlToULkDqzQqpI0Ruyje2mWf13Mt5qdqoz+McZO6ztp39d0pLdfBd+EnTc8hGveit?=\n\t=?utf-8?q?NV7wjDyDudIZds4/ZnxkQP4oFA0cBxsGF7o/AJeVKN75N4PgcCNEl+Xte0epaIUD6?=\n\t=?utf-8?q?cXZfBhbOA79OLfZDVMwtocQ/b14wy7pOazUtHvFBYmzdK0IkXh3Wp65QSIZmnD9+V?=\n\t=?utf-8?q?1qRCKie4ELxjMt4q8hFiBf6a2s+jgXkIr60P736Pfnn3m3KNQmxBXaPfZAP4Z3jN+?=\n\t=?utf-8?q?0mYMm9smm/HW+GCMDpvPhUL1HqXeM2/AvGSNrE7IKSySmcBNSwR/TIdMh2Wx+pvm3?=\n\t=?utf-8?q?DyS1nlx68rDddHLk9OKxgejlMa2Wv+u6RLtI/6ChcippQLG6FoAJA4y42GvOzHPir?=\n\t=?utf-8?q?PILgQ+N1sF9x9zvsa8n9ZVezh6rDQk9znFzN1C65BH1l+Z3X31TRQQPuCfOfqGZyx?=\n\t=?utf-8?q?kLNDKkpjSC6K3Wr5tZo04EEBRSlpuKi4WGoNeR/axqloTnpZcb1jxgezpJ3nYp5Cl?=\n\t=?utf-8?q?G3ENdq6497eb72/JVjIFJj1XDoT0WXqSb7wO/DeQBXKeDoWY9MfaMrlOUm6CvB2bW?=\n\t=?utf-8?q?wx7jTvVYaT5rXw0iFwqamv+AhlCnhemA=3D=3D?=","X-Exchange-RoutingPolicyChecked":"\n O/iGFFXh7Ox/TTUrqAxdKoPrWM3D/QkfKqs7KTeMbH1xEgVZ8fmeeHJiC5IPqLEb03s7JOmrTV2mSYxdR2D1oulshUf5AVfjS14lgT5oBRZsfMmmZPWvV0eUthjEOPmVzGysOcjgPZQs19BjgXJJc5nqA+CkZXwNSPk9y6Lc0yjrLv+aI18B2a0WgLuB2pTRvf188B4dzMSsKWGAprxVBV8C8yEGVS7VqFKWmwDzVEsP7KXol5TcZiFlA5363owywJUlqi9J411f92AA5YqXlA91oVrplV1OPnI003FtuXMdo9I8RHUiDXtbTxFLPATHTGszsD50gUT8+s8hmj1DLg==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n bf808bda-1626-40de-addb-08de99b68a26","X-MS-Exchange-CrossTenant-AuthSource":"DS0PR11MB7579.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"13 Apr 2026 23:44:01.9936 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n wylWtinuGaPM3ENoK1j4nvJ4BtnOtyY/+HmNQtGoBJxX5F/EPLBRpW6FGbSZgKoDmnemmaNPsok6X/cJTjlK0fd+bOk2cHxBDhPEZrFRBq4=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"SA3PR11MB7980","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776123849; x=1807659849;\n h=message-id:date:subject:to:cc:references:from:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=gyidXkzJ5HtA7gaANWL2odA04ZqLTZ8+0+CqBa5hL7I=;\n b=EQv695a/5Cv4nMdKX5Y85ze9BQnCcEMwv9ANnzbCGcOnbTu2KJjfPEl7\n LfBaeo93ZkGZYMPI3g8sU2oXMf/RkLhif/Y+9lwmzb5if2Pb208G3Dyzc\n P4knbRuFLKIYh/OxXyilt4gLhO3S3EzsCJuR8IdNfDbHNevCFyfKojEix\n 9UIjfwbGYmobJga2nhUIAkf3JXrjMLCzj3UWwP5pDiW0FSjmkrJHsYMn3\n 0O0Rii1fTo0idyFhGLIWVYO376QAfd0snEGYX2gZtZCer7E/h3YDM7Tg7\n HssZQW4Su2dIFOMZNCAcuPyssj2H03M7p8zHn7zUSooFr7WT117SQDr97\n A==;","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=EQv695a/","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix infinite recursion\n in ice_cfg_tx_topo via ice_init_dev_hw","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3677072,"web_url":"http://patchwork.ozlabs.org/comment/3677072/","msgid":"","list_archive_url":null,"date":"2026-04-14T08:43:47","subject":"Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix infinite recursion\n in ice_cfg_tx_topo via ice_init_dev_hw","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/people/75597/","name":"Loktionov, Aleksandr","email":"aleksandr.loktionov@intel.com"},"content":"> -----Original Message-----\n> From: Petr Oros \n> Sent: Monday, April 13, 2026 9:14 PM\n> To: netdev@vger.kernel.org\n> Cc: Oros, Petr ; Nguyen, Anthony L\n> ; Kitszel, Przemyslaw\n> ; Andrew Lunn ;\n> David S. Miller ; Eric Dumazet\n> ; Jakub Kicinski ; Paolo Abeni\n> ; Loktionov, Aleksandr\n> ; Nikolay Aleksandrov\n> ; Daniel Zahka ;\n> Greenwalt, Paul ; Ertman, David M\n> ; Michal Swiatkowski\n> ; Keller, Jacob E\n> ; intel-wired-lan@lists.osuosl.org; linux-\n> kernel@vger.kernel.org\n> Subject: [PATCH iwl-net] ice: fix infinite recursion in\n> ice_cfg_tx_topo via ice_init_dev_hw\n> \n> On certain E810 configurations where firmware supports Tx scheduler\n> topology switching (tx_sched_topo_comp_mode_en), ice_cfg_tx_topo() may\n> need to apply a new 5-layer or 9-layer topology from the DDP package.\n> If the AQ command to set the topology fails (e.g. due to invalid DDP\n> data or firmware limitations), the global configuration lock must\n> still be cleared via a CORER reset.\n> \n> Commit 86aae43f21cf (\"ice: don't leave device non-functional if Tx\n> scheduler config fails\") correctly fixed this by refactoring\n> ice_cfg_tx_topo() to always trigger CORER after acquiring the global\n> lock and re-initialize hardware via ice_init_hw() afterwards.\n> \n> However, commit 8a37f9e2ff40 (\"ice: move ice_deinit_dev() to the end\n> of deinit paths\") later moved ice_init_dev_hw() into ice_init_hw(),\n> breaking the reinit path introduced by 86aae43f21cf. This creates an\n> infinite recursive call chain:\n> \n> ice_init_hw()\n> ice_init_dev_hw()\n> ice_cfg_tx_topo() # topology change needed\n> ice_deinit_hw()\n> ice_init_hw() # reinit after CORER\n> ice_init_dev_hw() # recurse\n> ice_cfg_tx_topo()\n> ... # stack overflow\n> \n> Fix by moving ice_init_dev_hw() back out of ice_init_hw() and calling\n> it explicitly from ice_probe() and ice_devlink_reinit_up(). The third\n> caller, ice_cfg_tx_topo(), intentionally does not need\n> ice_init_dev_hw() during its reinit, it only needs the core HW\n> reinitialization. This breaks the recursion cleanly without adding\n> flags or guards.\n> \n> The deinit ordering changes from commit 8a37f9e2ff40 (\"ice: move\n> ice_deinit_dev() to the end of deinit paths\") which fixed slow rmmod\n> are preserved, only the init-side placement of ice_init_dev_hw() is\n> reverted.\n> \n> Fixes: 8a37f9e2ff40 (\"ice: move ice_deinit_dev() to the end of deinit\n> paths\")\n> Signed-off-by: Petr Oros \n> ---\n> drivers/net/ethernet/intel/ice/devlink/devlink.c | 2 ++\n> drivers/net/ethernet/intel/ice/ice_common.c | 2 --\n> drivers/net/ethernet/intel/ice/ice_main.c | 2 ++\n> 3 files changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/net/ethernet/intel/ice/devlink/devlink.c\n> b/drivers/net/ethernet/intel/ice/devlink/devlink.c\n> index 6144cee8034d77..641d6e289d5ce6 100644\n> --- a/drivers/net/ethernet/intel/ice/devlink/devlink.c\n> +++ b/drivers/net/ethernet/intel/ice/devlink/devlink.c\n> @@ -1245,6 +1245,8 @@ static int ice_devlink_reinit_up(struct ice_pf\n> *pf)\n> \t\treturn err;\n> \t}\n> \n> +\tice_init_dev_hw(pf);\n> +\n> \t/* load MSI-X values */\n> \tice_set_min_max_msix(pf);\n> \n> diff --git a/drivers/net/ethernet/intel/ice/ice_common.c\n> b/drivers/net/ethernet/intel/ice/ice_common.c\n> index ce11fea122d03e..b617a6bff89134 100644\n> --- a/drivers/net/ethernet/intel/ice/ice_common.c\n> +++ b/drivers/net/ethernet/intel/ice/ice_common.c\n> @@ -1126,8 +1126,6 @@ int ice_init_hw(struct ice_hw *hw)\n> \tif (status)\n> \t\tgoto err_unroll_fltr_mgmt_struct;\n> \n> -\tice_init_dev_hw(hw->back);\n> -\n> \tmutex_init(&hw->tnl_lock);\n> \tice_init_chk_recipe_reuse_support(hw);\n> \n> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c\n> b/drivers/net/ethernet/intel/ice/ice_main.c\n> index e2a5534819d194..a27be29f9bbbfc 100644\n> --- a/drivers/net/ethernet/intel/ice/ice_main.c\n> +++ b/drivers/net/ethernet/intel/ice/ice_main.c\n> @@ -5314,6 +5314,8 @@ ice_probe(struct pci_dev *pdev, const struct\n> pci_device_id __always_unused *ent)\n> \t\treturn err;\n> \t}\n> \n> +\tice_init_dev_hw(pf);\n> +\n> \tadapter = ice_adapter_get(pdev);\n> \tif (IS_ERR(adapter)) {\n> \t\terr = PTR_ERR(adapter);\n> --\n> 2.52.0\n\nReviewed-by: Aleksandr Loktionov ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=cjoLUoSN;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvyVq3Rmwz1yDF\n\tfor ; Tue, 14 Apr 2026 18:44:03 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id C9EFE40789;\n\tTue, 14 Apr 2026 08:44:01 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 1tqrE1fGjk42; Tue, 14 Apr 2026 08:44:01 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 066AF4076A;\n\tTue, 14 Apr 2026 08:44:01 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id F1E97237\n for ; Tue, 14 Apr 2026 08:43:59 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id D9EF461CB3\n for ; Tue, 14 Apr 2026 08:43:59 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 9orTJ0Mt6AKB for ;\n Tue, 14 Apr 2026 08:43:58 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.16])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 5F5F761C76\n for ; Tue, 14 Apr 2026 08:43:58 +0000 (UTC)","from orviesa009.jf.intel.com ([10.64.159.149])\n by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Apr 2026 01:43:57 -0700","from orsmsx903.amr.corp.intel.com ([10.22.229.25])\n by orviesa009.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Apr 2026 01:43:56 -0700","from ORSMSX902.amr.corp.intel.com (10.22.229.24) by\n ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Tue, 14 Apr 2026 01:43:56 -0700","from ORSEDG903.ED.cps.intel.com (10.7.248.13) by\n ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Tue, 14 Apr 2026 01:43:56 -0700","from SJ2PR03CU001.outbound.protection.outlook.com (52.101.43.58) by\n edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Tue, 14 Apr 2026 01:43:56 -0700","from IA3PR11MB8986.namprd11.prod.outlook.com (2603:10b6:208:577::21)\n by MW6PR11MB8338.namprd11.prod.outlook.com (2603:10b6:303:247::7)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr\n 2026 08:43:48 +0000","from IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c]) by IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c%5]) with mapi id 15.20.9745.012; Tue, 14 Apr 2026\n 08:43:48 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 066AF4076A","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5F5F761C76"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776156241;\n\tbh=CfW4NY60C/bwnQ9pjdUE8de3J2gv2SSpYE+GGz1lwKQ=;\n\th=From:To:Date:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=cjoLUoSN2/ik1Jd4ZvBEn3nQqdU0VGNtG5HsIRGqO0i9VM78L1sA4rc5eAqzs5wk5\n\t Z0XkUeUTUMENLEqpfUmhw/XQrYz5yiocxzumfqRSN06wVSFrJ4Z5/DkouScqcP7l/h\n\t Llm3Kk01BQ2bJkkqhhNjKJyoa2tgd4ZGCflGTK42LA/Tk1AXsccrnrfiOehl9HfrLY\n\t s2uPGG5jzrOQvtSFClmTMYvQjIONReg2XPWtCVINQVhkgkEMKr8bMV+tLXNJtSz7eB\n\t JLjOnQJ/0elJv0ster4ooyxlPm+xV3wSCaAp5zoLoqSr2BS9R8vXHbVjaUoNKgBzqt\n\t NlS1+GBi3SDKQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.16;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 5F5F761C76","X-CSE-ConnectionGUID":["Ii2/7IGlSNmEZDTSdxBgBg==","ooa4Jz3KTCuBge13RT01Ew=="],"X-CSE-MsgGUID":["h1aB1raSQXOah85dG84Oug==","1KUhvPf7RgmyDJoV5wotTA=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11758\"; a=\"64642159\"","E=Sophos;i=\"6.23,179,1770624000\"; d=\"scan'208\";a=\"64642159\"","E=Sophos;i=\"6.23,179,1770624000\"; d=\"scan'208\";a=\"229909177\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=YHo4ZaT1AkNzY7QffBprxXnxDceQITboaAqNyx8c8h7Hz4a68ORBI3/3AaOdqSfUmzBrGZKv67/YBDUDg/fzXiOjXWz75rI6tWXjHfaRMeR/wGWa5UUd47x55FXZDjnMMh3ra2vQCr2NUvFgxi1sypJNEL/BzWTnBWiT6rF+0nKDQw7zmN6va2o0h1BdytdU54nao8AAgjbhG8W7U+ucYR2M6+ilXGYAAqMuL3hLTVtqabEpJwQC9ylwApYqXKkdtpY07m7YiyEfXOLUf7xXVDcK9qw6SD3dcyYCb+qwGEv/XJCxRaaj0McgLEsh/4nwVsh+MUap1FKWnNyJwd/8fg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=CfW4NY60C/bwnQ9pjdUE8de3J2gv2SSpYE+GGz1lwKQ=;\n b=MCiCzJwGomgeaguKSViCiFIIdNZF5wB+5BVpqZedUS4tBvcUDUnSZrlfNC9CriACVfXdv1YIMz6nSm+PCtUVP6m5dMBclmEqiXWIMdBBslsVpwulrve3ALmclRRZsCNlRLP/E1MmfhAv2xPaBSbT7KDCodEd+JBJvDf9NfiE608BiDjAO7EBMzIgk4TW2qhdj+PPH23OQ5WQJmPzp0MqQn1o16FdPIZ/LHX+8ZMtKDqxeVAUUZjocnGlQ7TD1FuLGcHXHbRvJ1/HcvZbqvviLCnUbscj3FEFn1nuicsqosOitSa5Cm5Pjz/9B/lSzU7NYHEP6YfsO4rS0LH5VKUFKg==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","From":"\"Loktionov, Aleksandr\" ","To":"\"Oros, Petr\" , \"netdev@vger.kernel.org\"\n ","Thread-Topic":"[PATCH iwl-net] ice: fix infinite recursion in ice_cfg_tx_topo\n via ice_init_dev_hw","Thread-Index":"AQHcy3nU1atNAwqxf0yC9yKd/4co+bXePnfQ","Date":"Tue, 14 Apr 2026 08:43:47 +0000","Message-ID":"\n ","References":"<20260413191420.3524013-1-poros@redhat.com>","In-Reply-To":"<20260413191420.3524013-1-poros@redhat.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"IA3PR11MB8986:EE_|MW6PR11MB8338:EE_","x-ms-office365-filtering-correlation-id":"8cadec66-7ae1-4579-cf01-08de9a01f201","x-ld-processed":"46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|1800799024|366016|7416014|376014|38070700021|22082099003|56012099003|18002099003;","x-microsoft-antispam-message-info":"\n hr2sFXfm3whRROyQMhXC0Qd1rErL9lVomsERYwMJQ5E1KsUFapdN8GW+q1Pxv0k8srX1JsMetOjcF59l4uLzebOLMmBCmNX0Zgu7H8oOuMiX68f+v3gDHtLCo43kwwAiLV/eJxMVoC9J3731F+3f4LqcW08aHI62cEy3AOEFTjBr/odpu/SR9xKR/kxaFA/L99zd8a9L9GF/qWS/MPslnstGlKxINQyCHOuXVZPSWGZqTVo8skVHP4YphvrRuwd0qXI84vyVF1W1vvLwHqlBpgBlGf+LfMO9q0p504An2Zxv5ZpchcnUf46XKTw4hmVtgRi/5miQY2SBgMEtpWrCaTYliMxQU+8AcQ/DJDvJ7zFp3kMJzdyvkxdABv7U8vMwCFJeNG9fiVSK8QCoFLnS7VsesqHnBhl+sH57sc3sbzU8bSCQEGRwFxza7Z70vg5qGDIusBoyKycLTJCG87VD9FzFCdGJWEw3h4FH4Gzmz3dCcAlP081+pcK7FBSFe9IHk/qXnID4OAhAL/ri4rROkK8ad56hRkIR8T6nHwYtvHHG3Q9i/N4V3IRSzkVuNWndPJyRkK+eRRdL0DAE1vh5PoXvv3YHIQJKjsUubTS8ZRuvpp82mPR3pAPbZr2/88EpIWD6NOc6fI7EIcqqes7hyfMGMXCRZnr9K5W1AnbjkhH6XAijtZH3CKE2/G0W5cARu89norN0Mc4Ibwl0S8QVD5SmS0X2CHoMUfnHg9NssW02rIFA7jYboORBSdv2yAbhhVwj0MK2Jdc9vVDdzJDnYStz8yzJUTOyKK2YZVoJZ54=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:IA3PR11MB8986.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(1800799024)(366016)(7416014)(376014)(38070700021)(22082099003)(56012099003)(18002099003);\n DIR:OUT; SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"\n y0WcHoVH31KkrxCBYmu2ouMkiyB6aV7iHYY+Q26beHkdCutZ8raumgFtPCrvnSHUgfcnqObp+0y8ML4A1hWen1d9TtTMhF7WHTLBhifJ2A1/CNIz0C8ajFRXg7sTP8yB88SY5TUxCBSTw9HLmWJjgmPkxIeUsZZSoTEoCtfwEV1pUyoZWdkmIfgNFkyRTiKeziZ1/BdGqpE9yhhuF8VGSdSLqBRfXurQSI5Zlo26UgHrA/JuwdWcKbV/3mbbVfFxaK67XEpudFPbwmk2ivIKsS7VbrSngVMAi76obr1/I2NZflp+NI2t9FIue8Tl2h2ot41uWpiJiSfQ0NbhGP5MJPMVp/nNK5TzOYmepuCm8EvW++Ejs/mbICxqjNGVj1tNbPA9Otb0lL7LQaKb55oKY/WWuj6DHl/4/LWk/ivWNltxCrsALrXMoeMgeUPDbHS+SQpApin50SyjS/nRZXa5qEr5QDm1HCJvi1r1+cqeoC3lhImBtu05Q+byKLuiFkSKbqElvYdKnP8ofrcQg3PySjfqXeMI5JEGQZcGFSeJbsqg/RzTywNhNyCOPHMAGgQTkZeQV2d+ZNWI9bVM9T3I1OEeU6KLz7k8uo3o67+4XniChqJoIxFJyjA4dpppBrDqkTHNzouErvSzteUMVVvRMixSAc5eINXxBHgKnMbtrrnXGlF/JiqvB1z2hoTPdLn0XbG4xp/4uzFHiZ67DzNiBAK4B4d2bg3PJVL4+qpWNorvvi15S/SLVf1iY57OVJD0EYRAJbJ6r1wb+76gtByvXo3XifHiRPPrlbYk3kUeh74Ry3sc8ya/t5EaDXIab00uDPVg/tzBbkFasslke+7OV4NitojKEMLHNrwuCIXyXjeTnoI/XoCj3w3KKTDSl8fEu1uUJ9F2hwLXfbp4nODW3nAWx+vPh5QUNt+JCLBgK9hqaiQeq5OqvWMv99GM+330DxNelCIETf4pfmOsZtGFtmb04RwPGjR2duIGdyuNTNvG9nfTQLMGiU2ofd55FobjYdFA2kbFJNTHH21wEvHFwq7wt9G97m58lf35Lt2ccBWmYPQVeuWAsRkH0HJPSrngDyoswVkYF6TqG7ljNVYX46kH1tLp3oS9Y00fnxBiBtMkPmJ622sOymyfz8xlbGPkXCtvVKK2M6atMejU95k194nzLukq3J1AkEEgU3dHVULrAAv/qUlcMQ+wktY6HngCQcIQrEJf5BOpc0olhJZvms1nfs9oAJ8eyWemKgsZxumm+xqVQDdVu2iKtjLHbmLx0pZeUhv7OsnAmB51qUjS6xmZ41LfL4CkIOxiJ/ju6o1DcjusMQZZH/22DlBAd44LLnJrYHXw0SfjqITsPHrVvfDbPhnR7Qc7KFLyimb35erX5StfYN/N6vJu4P1QPEormONkI52l83OYhFIPuAip3Gvit3r9XpIVs0jhwhQgIPDzC4JroCnjxonlORf9rzNxL3ebdI2siA1vBgFwKjFdmjeSKe/igbsyzdZTR7stzcxg8hU6aFEeTolE5JrHIQ/VaIdb/ZdZCETM+ABCVArCfEeaaqJabiUo3SmNiHuL3RwPnLERhxyGHXtJO1wP2bwG9Ev5NZrNKcH71bmQaJ+iVRzk8AOHwcOiL6h25q91jpI4+17SGPGVEShYE5lyoKfPF6sCJC9Rk64ZBWJ0xrEN/SYOy01J7GsCl6Bp9Sr0anOr/xAGlY1qjJ3l6Kmagr49zxbDHMjN1q3jb4PxjzWJkF+6yv7scfCb6KDIroflUrY=","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-Exchange-RoutingPolicyChecked":"\n kFBNBAgHGkQm4QzeVEw3CMWuhu3zkdmSgdznj06Uj2LaUoBg234z9DaR7OENHhjgocjg93fRDjZX8z2pXJnwMniYzJdzMFfT70Gkt7rZ29fawBKUeGTa03ISyMEnMa5lIXVp3QQjgx1tUfAJsGTNMSZsP+v88fNwriowCpvTz+9lzFtY0453oI7PmTQpDWRlHsockMW+vIXGJDjFvgakXdQO1k1TyZgLXEQVBxtEY8I+lrQrFXIUOtWrfbYkasGESMOMpV50qaJ5l8BE9YbRzhlgKcscpr4obKkjzDrsg5f0Umvcq4EUaPwiiggNSkazRu0FS1xfkIS/Kcg2wTPuWg==","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"IA3PR11MB8986.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 8cadec66-7ae1-4579-cf01-08de9a01f201","X-MS-Exchange-CrossTenant-originalarrivaltime":"14 Apr 2026 08:43:47.8793 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n 2Qn+nDSo2xtUX02E8DtT76C4va0BZ3vlZgqhQk4w295r2OzXKBbgLMOlffv76WSEYS8kh57WrBGPp0/H/DQAFLMtmqKXfqSYSvAiOnAlEKo=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MW6PR11MB8338","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776156238; x=1807692238;\n h=from:to:cc:subject:date:message-id:references:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=fHIiyIfhGsjWE136KA+gBZFOTc1+ui6fC5JwxbH/xog=;\n b=OxgJaPoLNIWL3Iae7+vdiC2NW/PZ/ccQk4F69hF8uPDI8O8VHBoNCjzY\n OZHBVlp1PzP8cFNB7XHEqwAJlsG0GHoigew/FI2nv7yUGDmd/WhtlWLtW\n r2kjDwN5qttjcQi2rMaqPFHrWFhMQ/KGHNh8NVYrsqTYrS+a9Y9x1qSWG\n tzVKgH3rsQObE+aKipElrGZcuq0M1g1P53HQZQS9YayJ/R152BRfx3T0Q\n EEcuXcboDIKzPukYKFUhcs6IQ9fZYzTz/ztTG0k5Ym2O14kQYPKFOznZa\n 1ImH0F10b+sTt4z9WyDazR9kDv9Qxg7AIibySObezgTaiI441wI6gCDom\n Q==;","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=OxgJaPoL","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix infinite recursion\n in ice_cfg_tx_topo via ice_init_dev_hw","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Michal Swiatkowski , \"Greenwalt,\n Paul\" , Daniel Zahka ,\n \"Kitszel, Przemyslaw\" , Nikolay\n Aleksandrov , Eric Dumazet ,\n \"linux-kernel@vger.kernel.org\" ,\n Andrew Lunn , \"Nguyen,\n Anthony L\" , \"Ertman,\n David M\" , \"Keller,\n Jacob E\" , Jakub\n Kicinski , Paolo Abeni , \"David\n S. Miller\" ,\n \"intel-wired-lan@lists.osuosl.org\" ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3677760,"web_url":"http://patchwork.ozlabs.org/comment/3677760/","msgid":"<20260415163003.GP772670@horms.kernel.org>","list_archive_url":null,"date":"2026-04-15T16:30:03","subject":"Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix infinite recursion\n in ice_cfg_tx_topo via ice_init_dev_hw","submitter":{"id":82748,"url":"http://patchwork.ozlabs.org/api/people/82748/","name":"Simon Horman","email":"horms@kernel.org"},"content":"On Mon, Apr 13, 2026 at 09:14:20PM +0200, Petr Oros wrote:\n> On certain E810 configurations where firmware supports Tx scheduler\n> topology switching (tx_sched_topo_comp_mode_en), ice_cfg_tx_topo()\n> may need to apply a new 5-layer or 9-layer topology from the DDP\n> package. If the AQ command to set the topology fails (e.g. due to\n> invalid DDP data or firmware limitations), the global configuration\n> lock must still be cleared via a CORER reset.\n> \n> Commit 86aae43f21cf (\"ice: don't leave device non-functional if Tx\n> scheduler config fails\") correctly fixed this by refactoring\n> ice_cfg_tx_topo() to always trigger CORER after acquiring the global\n> lock and re-initialize hardware via ice_init_hw() afterwards.\n> \n> However, commit 8a37f9e2ff40 (\"ice: move ice_deinit_dev() to the end\n> of deinit paths\") later moved ice_init_dev_hw() into ice_init_hw(),\n> breaking the reinit path introduced by 86aae43f21cf. This creates an\n> infinite recursive call chain:\n> \n> ice_init_hw()\n> ice_init_dev_hw()\n> ice_cfg_tx_topo() # topology change needed\n> ice_deinit_hw()\n> ice_init_hw() # reinit after CORER\n> ice_init_dev_hw() # recurse\n> ice_cfg_tx_topo()\n> ... # stack overflow\n> \n> Fix by moving ice_init_dev_hw() back out of ice_init_hw() and calling\n> it explicitly from ice_probe() and ice_devlink_reinit_up(). The third\n> caller, ice_cfg_tx_topo(), intentionally does not need ice_init_dev_hw()\n> during its reinit, it only needs the core HW reinitialization. This\n> breaks the recursion cleanly without adding flags or guards.\n> \n> The deinit ordering changes from commit 8a37f9e2ff40 (\"ice: move\n> ice_deinit_dev() to the end of deinit paths\") which fixed slow rmmod\n> are preserved, only the init-side placement of ice_init_dev_hw() is\n> reverted.\n> \n> Fixes: 8a37f9e2ff40 (\"ice: move ice_deinit_dev() to the end of deinit paths\")\n> Signed-off-by: Petr Oros \n\nHi Petr,\n\nI don't intended to delay this patch.\nBut could you follow-up by looking over the AI generated\nreview of this patch on sashiko.dev?\n\nThanks!","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=81i5YBX6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwmpK05G6z1yHM\n\tfor ; Thu, 16 Apr 2026 02:30:17 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 39E2180CA8;\n\tWed, 15 Apr 2026 16:30:15 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id WEPRAxckTaT3; Wed, 15 Apr 2026 16:30:13 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id B561780C93;\n\tWed, 15 Apr 2026 16:30:13 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 7D455375\n for ; Wed, 15 Apr 2026 16:30:12 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 638EF402BB\n for ; Wed, 15 Apr 2026 16:30:12 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id B5uvkGytOAu8 for ;\n Wed, 15 Apr 2026 16:30:11 +0000 (UTC)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 86E3E402AE\n for ; Wed, 15 Apr 2026 16:30:11 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by tor.source.kernel.org (Postfix) with ESMTP id B5328600AE;\n Wed, 15 Apr 2026 16:30:09 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 17446C19424;\n Wed, 15 Apr 2026 16:30:05 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org B561780C93","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 86E3E402AE"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776270613;\n\tbh=G1fnCBFOTz/a0YjDGgfv3ZYvqKBOgOLHiSmFptchnCA=;\n\th=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=81i5YBX6+M6wKkj1w/V6QylHKclMX+8ewYttgCNaURQ+mOc2o987UMZrv26PpngCy\n\t eHMGtcFO5w4hj6JOGUywejwE5wpcHweIx7s01tEnNvLQ0sjyVMnJnIOGcjBRJaaC1c\n\t ovjAeBhc315/t3h0mM4H8gq2N0su9EI6//hPHlPNDDN5j3vslAKxNb9FfhHOqIngmJ\n\t Z0JarwtAgpnaKDfkUI4zbSsD/B6PR8IurZUyGRMNUMaXSGHhBsjWq561jvXyrUL8UT\n\t md2NH6StRfRKHWFJDuz0k5JAfW0Xy2cm2NtzNuulQ4ZFOqJbeuUTRJQ8ZhmUJ4UbAZ\n\t NGEzbjFNzujSQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254;\n helo=tor.source.kernel.org; envelope-from=horms@kernel.org;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 86E3E402AE","Date":"Wed, 15 Apr 2026 17:30:03 +0100","From":"Simon Horman ","To":"Petr Oros ","Cc":"netdev@vger.kernel.org, Tony Nguyen ,\n Przemek Kitszel ,\n Andrew Lunn ,\n \"David S. Miller\" ,\n Eric Dumazet ,\n Jakub Kicinski , Paolo Abeni ,\n Aleksandr Loktionov ,\n Nikolay Aleksandrov ,\n Daniel Zahka ,\n Paul Greenwalt ,\n Dave Ertman ,\n Michal Swiatkowski ,\n jacob.e.keller@intel.com, intel-wired-lan@lists.osuosl.org,\n linux-kernel@vger.kernel.org","Message-ID":"<20260415163003.GP772670@horms.kernel.org>","References":"<20260413191420.3524013-1-poros@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260413191420.3524013-1-poros@redhat.com>","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1776270609;\n bh=fniF0iwOu4pkgMWiGbwhBeBWmR/o5IjyUb8gyW4Vgwk=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=g9PWKMrZi+xJ6h43sHHkddcGBm1Iy9E5DBTRIBFEGOR+WHCVpS5B5vj0RrJIdg3iv\n qzyWhNuvYFH0oCv3WGTyA1gYhd8ZBjKxNf4ieil6zB1s9DH0XxAIjVvIxoei9XZKOo\n olShtrjMVb29k+8BNnhLP5xlxFl4MNJxF05gG2tlffmF0ezLeZpBsZX3wU4m+pZ4Bi\n tKMvN5KAbT/apig496Wy0mrM70R14brxktFLHqryduHmfLl81zvPgmv1tPoOTs6EYi\n F2II7AuwqcrlPtGW4KYV85yLrhE6WbtBLljgzOCJdkou4RuSv8GdOoRib5x4ke5cfa\n goyP4i4nZ46YQ==","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=g9PWKMrZ"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix infinite recursion\n in ice_cfg_tx_topo via ice_init_dev_hw","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3677823,"web_url":"http://patchwork.ozlabs.org/comment/3677823/","msgid":"","list_archive_url":null,"date":"2026-04-15T21:22:08","subject":"Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix infinite recursion\n in ice_cfg_tx_topo via ice_init_dev_hw","submitter":{"id":9784,"url":"http://patchwork.ozlabs.org/api/people/9784/","name":"Jacob Keller","email":"jacob.e.keller@intel.com"},"content":"On 4/15/2026 9:30 AM, Simon Horman wrote:\n> On Mon, Apr 13, 2026 at 09:14:20PM +0200, Petr Oros wrote:\n>> On certain E810 configurations where firmware supports Tx scheduler\n>> topology switching (tx_sched_topo_comp_mode_en), ice_cfg_tx_topo()\n>> may need to apply a new 5-layer or 9-layer topology from the DDP\n>> package. If the AQ command to set the topology fails (e.g. due to\n>> invalid DDP data or firmware limitations), the global configuration\n>> lock must still be cleared via a CORER reset.\n>>\n>> Commit 86aae43f21cf (\"ice: don't leave device non-functional if Tx\n>> scheduler config fails\") correctly fixed this by refactoring\n>> ice_cfg_tx_topo() to always trigger CORER after acquiring the global\n>> lock and re-initialize hardware via ice_init_hw() afterwards.\n>>\n>> However, commit 8a37f9e2ff40 (\"ice: move ice_deinit_dev() to the end\n>> of deinit paths\") later moved ice_init_dev_hw() into ice_init_hw(),\n>> breaking the reinit path introduced by 86aae43f21cf. This creates an\n>> infinite recursive call chain:\n>>\n>> ice_init_hw()\n>> ice_init_dev_hw()\n>> ice_cfg_tx_topo() # topology change needed\n>> ice_deinit_hw()\n>> ice_init_hw() # reinit after CORER\n>> ice_init_dev_hw() # recurse\n>> ice_cfg_tx_topo()\n>> ... # stack overflow\n>>\n>> Fix by moving ice_init_dev_hw() back out of ice_init_hw() and calling\n>> it explicitly from ice_probe() and ice_devlink_reinit_up(). The third\n>> caller, ice_cfg_tx_topo(), intentionally does not need ice_init_dev_hw()\n>> during its reinit, it only needs the core HW reinitialization. This\n>> breaks the recursion cleanly without adding flags or guards.\n>>\n>> The deinit ordering changes from commit 8a37f9e2ff40 (\"ice: move\n>> ice_deinit_dev() to the end of deinit paths\") which fixed slow rmmod\n>> are preserved, only the init-side placement of ice_init_dev_hw() is\n>> reverted.\n>>\n>> Fixes: 8a37f9e2ff40 (\"ice: move ice_deinit_dev() to the end of deinit paths\")\n>> Signed-off-by: Petr Oros \n> \n> Hi Petr,\n> \n> I don't intended to delay this patch.\n> But could you follow-up by looking over the AI generated\n> review of this patch on sashiko.dev?\n> \n> Thanks!\n\nI'll take a look as well. I recently included this fix in Intel Wired\nLAN update last night, so hopefully nothing too problematic...\n\nSashiko says:\n\n> While this code wasn't introduced by this patch, the restructuring makes it\n> more visible: can this cause a use-after-free if the nested hardware\n> initialization fails?\n> If ice_cfg_tx_topo() triggers a topology change, it performs a CORER reset\n> followed by an unroll (ice_deinit_hw) and re-initialization (ice_init_hw). If\n> that nested ice_init_hw() fails, its unroll path frees hw->port_info and\n> destroys control queues and mutexes.\n> Because ice_init_dev_hw() returns void, it swallows the -ENODEV error and\n> falls back to safe mode. This allows ice_probe() to proceed with an unrolled\n> and freed hardware struct, which would result in a use-after-free when memory\n> like hw->port_info is accessed later.\n> Should ice_init_dev_hw() be updated to return an error code so the caller can\n> abort the probe when base hardware unrolls occur?\n\nI think this suggestion might be good. We fail in probe if ice_init_hw()\nfails regardless of \"safe\" mode, so having init_dev_hw() also fail if\nthe reinit fails makes some sense to me...\n\nThanks,\nJake","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=hKhZc1JJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwvHP75f1z1yHP\n\tfor ; Thu, 16 Apr 2026 07:22:25 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 51CF7605C8;\n\tWed, 15 Apr 2026 21:22:23 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Ad8I5DthuTlP; Wed, 15 Apr 2026 21:22:22 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 8B15E605C5;\n\tWed, 15 Apr 2026 21:22:22 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id 413D92CF\n for ; Wed, 15 Apr 2026 21:22:21 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 26B05605C5\n for ; Wed, 15 Apr 2026 21:22:21 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 1PiQn2--pY3s for ;\n Wed, 15 Apr 2026 21:22:20 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.14])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 4808A605C4\n for ; Wed, 15 Apr 2026 21:22:19 +0000 (UTC)","from orviesa007.jf.intel.com ([10.64.159.147])\n by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Apr 2026 14:22:19 -0700","from fmsmsx901.amr.corp.intel.com ([10.18.126.90])\n by orviesa007.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Apr 2026 14:22:18 -0700","from FMSMSX903.amr.corp.intel.com (10.18.126.92) by\n fmsmsx901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Wed, 15 Apr 2026 14:22:18 -0700","from fmsedg901.ED.cps.intel.com (10.1.192.143) by\n FMSMSX903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Wed, 15 Apr 2026 14:22:18 -0700","from SA9PR02CU001.outbound.protection.outlook.com (40.93.196.29) by\n edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Wed, 15 Apr 2026 14:22:18 -0700","from DS0PR11MB7579.namprd11.prod.outlook.com (2603:10b6:8:14d::5) by\n IA1PR11MB6097.namprd11.prod.outlook.com (2603:10b6:208:3d7::17) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.17; Wed, 15 Apr\n 2026 21:22:12 +0000","from DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e]) by DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e%5]) with mapi id 15.20.9818.014; Wed, 15 Apr 2026\n 21:22:12 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8B15E605C5","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 4808A605C4"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776288142;\n\tbh=N6K2llWY0tTWh5edTDllDCI3R8w761wbame1M1c04yo=;\n\th=Date:To:CC:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=hKhZc1JJH0rQBj9nDD0nru3L8iKqk7g2uxtt+ar7dSDRWXK7V//hFec+JjB21W5w6\n\t J6MZMalmdU9QZwADdTR0eUB9elNzV/bTzqGPR36zVF6h3lUyjaeu4aYoazDV/Mww75\n\t e5exlZh9NFncCjdDUxNu3o9EnEeLYSYUI7oRd1Z6Q2iyNDOT+Ey4pV17rbBk+2CNJv\n\t eC2nRsACtpJ/5oy6Y8vM1bFToeshn/3S7mhyzDb5iPIJ/gSGenCHyEzvVwM9ZgSN2g\n\t /ss57wRQ+qH8OiB3jpuRe6uUYzp2GnKFFNeMiFcoRA0zVePGlT11/VbQ0gjRdEP7lG\n\t vK57UCkS9v3Hw==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.14;\n helo=mgamail.intel.com; envelope-from=jacob.e.keller@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 4808A605C4","X-CSE-ConnectionGUID":["DIH9H8gbQAqwlVSguGjc5g==","atfk6SrkSYqRrhkECvLkXw=="],"X-CSE-MsgGUID":["2+Fup/FtRHCUlxv14ujmTw==","rzvhxu93QHmxrIdwl/Funw=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11760\"; a=\"81152271\"","E=Sophos;i=\"6.23,181,1770624000\"; d=\"scan'208\";a=\"81152271\"","E=Sophos;i=\"6.23,181,1770624000\"; d=\"scan'208\";a=\"230776787\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=bUhHNIWfR+rJOYqp61BO9++ddoAz+ylz041Mmtzi829ScGRqtZqh/PAoJC0QWsEJEXwVPI/4QpJLk85SPZcXcTVGV2gugXVQY0DqX8KlJvxyxDR04BVMJsHTCxkrnQjSqOxlAxdv++TVoxMTeZENTuVDxqikZsdSrLDEUYhtSm3unYl7nrlqSMk7nbOXC38OoaAC0hBtFGAV3csXg24VsdHnOXKCHQQa4WZuc1b0poDRaP2nKz81F6luIUcIM+cz6B4g6mg5Ubru83Te4y4MjfBUJIiQ0mHoIGxXfl29qFH6nFZkTGY8th5Nh8IOvHIzsuAWUaeSyLfMdSH6YtUuaw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=N6K2llWY0tTWh5edTDllDCI3R8w761wbame1M1c04yo=;\n b=dUgeyMf8yOmaMQyCOZPWhhYTuSbrlh1bAbkMJxC0Y0eaReLrSDmIBy1L+CB6oPJzLfTW2Wazr940XP+DIxMV0w1VwU1hRmyz5RjosnljRWeMQVH/8tYDg5bV8olpoAbvuEXFzJT12QVLzlPCZNNxUp/ff5ZBmYjnnzxsM77dHPu7xGlC6ziZhYKUO1+s0RSTY/duOWHxMVqUn3VewvKxkfw4OFH0nvFEzGULojYnIbpc+xEuCWJaZDXKN8btR2do8gNhjwhI89c3538E9i/uu4jNZig4dQRVcYw1GcGzUFdwHy5p5Sz7a7xESpakmSmaT6PxbwD0Z9/HbLYky6kTWQ==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","Message-ID":"","Date":"Wed, 15 Apr 2026 14:22:08 -0700","User-Agent":"Mozilla Thunderbird","To":"Simon Horman , Petr Oros ","CC":", Tony Nguyen ,\n Przemek Kitszel , Andrew Lunn\n , \"David S. Miller\" , \"Eric\n Dumazet\" , Jakub Kicinski , Paolo Abeni\n , Aleksandr Loktionov ,\n Nikolay Aleksandrov , Daniel Zahka\n , Paul Greenwalt , \"Dave\n Ertman\" , Michal Swiatkowski\n , ,\n ","References":"<20260413191420.3524013-1-poros@redhat.com>\n <20260415163003.GP772670@horms.kernel.org>","Content-Language":"en-US","From":"Jacob Keller ","In-Reply-To":"<20260415163003.GP772670@horms.kernel.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"MW4PR04CA0194.namprd04.prod.outlook.com\n (2603:10b6:303:86::19) To DS0PR11MB7579.namprd11.prod.outlook.com\n (2603:10b6:8:14d::5)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS0PR11MB7579:EE_|IA1PR11MB6097:EE_","X-MS-Office365-Filtering-Correlation-Id":"a36f2c02-89f2-47d4-2140-08de9b350ed7","X-LD-Processed":"46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|1800799024|366016|7416014|376014|18002099003|22082099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n hZRx34OqINIDKOE2lrEqITWLY4BnsncLBycGNbrNByANY4W9SZ6KZGSb/2m+kUCwZ2OIEXN1wyZ6cbV4FkkBZbe2JOVY49wp8Z60J7PB3kR3Ppti6zKS62mqF2Lz/iocxPVYkYKyxZsULRfP3PmPO1dDn4uO9KkORJtduKj/06zwaJBTVHN1rbyRETtEVyQgUpCdc9ax37eM74f16mNSxv1yvU0JfjydIdsAVpAvVTIYt/U7ovxXluvNpIhmnnMejqktgmqeppqM1NBS65T2XXjxoMhy8ZkFFrRw7HeRpjE9y1j45nEhnScpB2tnQPb0yXfo+JLBb47F+4BYEZvd3ctvbeqU0RpFf/jZ/vIs00NBlvdij4MWGumJ/YZy+sORbPSBvcr02qElBZw7i4qpVcw6me8wFcmo3ckJsUGnxs8BG5E0jA0RbQt4xiHyUp28LxhGF8B8MI2QuTl7WeweTqPeVQGFQmBROUHHVfGZeng13a9lalugTYHF61nS54bMwzUi2Ux/LTYX1xJnXpNfeSDL93hzwvULlHmAnN5FbfgfWipaMSueMoWRjSt/LCFIj3UxpFLX5duOR023KoJD0Q9QMN2I8o0sHS4a1ed+0LEGXwmQ7+6CUAM00TQeG4N84Ph4ucTB5iiF8NOKtD5M7+LC1/obNrn988yWxmIO80AfS6YS/4u8ORcI8PjC2qNuc0mdf8qoTAHXISSqWcQpOBnQGsReIpm1oqtx05GEtVo=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DS0PR11MB7579.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(1800799024)(366016)(7416014)(376014)(18002099003)(22082099003)(56012099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?jRbNR7GRJ/g9HusedKei/9nZ1IRc?=\n\t=?utf-8?q?Wh+4EcShsBW+uTD0CQPPPcXi7oSr93lxDEkm6vpo4Kr/Fmab6E/q/+d+yeOldu+Pj?=\n\t=?utf-8?q?1UASEFPpHl7tq+gCXCOOa85mN/22iSEycfR1OWRHxSKUEJzL0pe2EHSIsPQaWOnip?=\n\t=?utf-8?q?QfAPlUrQgBPOxfuRX5iMI0tse2GsoJ0wew3F9cQgwlGBTPd7IwKPrfS+UI0YP3gVX?=\n\t=?utf-8?q?iU9f8jDMgFU3A/DScWbMAaFr76x97FQkX9NBkScF8Dg62hrG34SJzko98iNbk8CvJ?=\n\t=?utf-8?q?KfcHFeCv4F4b8bnI22VqJCkW/tRPTnXCqCQ2dvhmJ77oLqWSQEjzqi2BaZ5uMif5t?=\n\t=?utf-8?q?vgClp5YCIraO1ykEXsPNfPYu8KsdX9RVWH1+hjuW3Or+pSacqxrl7KletFWrK0OCH?=\n\t=?utf-8?q?PNvdi8Etli34vLMZAiW/wNHayyZ7/soZJMSFOlCwEXScUJxxSPhlEV65yaIoH61k/?=\n\t=?utf-8?q?wxAMhzfAUEog+7guHWB32OMamVDzXx7KDA5vfXt9Jqdb9HDN042giEhT62VhTQqC8?=\n\t=?utf-8?q?+lFSCt4pUl/fdAAmZug94tCS0JDVxBFsDaVWTQO8WsERhxKryBVJcr0NUFcigagor?=\n\t=?utf-8?q?a7XYqAT7yHpS8vkbto3CZskc5P3IVK/h/B4ObEtZ6P0kPOFStHt7IPGLDuD6HsjMY?=\n\t=?utf-8?q?FqAxE5IZXzThHAMYGACFej07930zUKkWQbl++FvvlyrGJUhT7ReH5zd+/jHv4TgJA?=\n\t=?utf-8?q?hTp2bYeFj4JshgjkY1jKAlniWeyET4nEeibAB/Zp5gAV1VtWPUvKnAidLmW7LrDbq?=\n\t=?utf-8?q?EnSg50GRqnL8pYeQxL6agksTYvyZYjwQ1tI20Cbf6fumiT/ISJLVj81mQnIEFmz2z?=\n\t=?utf-8?q?BU5QzveEJCiaJmqXvNRbDyZBvvcd6IJC5kApc1p1uQvZQxaxpjFy1oHxo3VSuA1CM?=\n\t=?utf-8?q?LroRf3fxSgDUSeyaxeZ+fJGTj68Bgxq7gBiXs6FYtDsBxYPCI0c9sdCjG0FIotEwt?=\n\t=?utf-8?q?/SqDokv9WS1ejOH0pBmNZodiSBk062cK/OerFFGTs4mqr2/Z8oOT+yROZEW4I/HVu?=\n\t=?utf-8?q?X92eMww5OJN02ow2UcIjEfTUIpHVljPj/ai/hE8cJmtGN2dKgCH7SQS3yN7NNCC6n?=\n\t=?utf-8?q?9zcOBOy3KjAuHboeU8SScztM5Ww9uva/ycO+ep6Ks4zE3T2BnJl/dsMXIaumnATSQ?=\n\t=?utf-8?q?37Cw6qXtay5TTiU5J6M3akMGJAGO+jMNqE4Vznba1q60CXVGxXYkY4PLMxp2c2k5b?=\n\t=?utf-8?q?Jx+4kDgwQeh60bojI6i5bT6HZFHptQqQRwQEOrrQQnTzxF2k+NPcxdj90A95Hn3E2?=\n\t=?utf-8?q?Mm74Bz/nksMfQsVv0IowR/s7JB+BducikacFBvB0EBur79tNcVKtwhYXv+Fi7x+Ly?=\n\t=?utf-8?q?k0dAINVHAxuvXmWwSXd4izc8A0JO51DpkevLr9MH3SPgtizYr6fBtkDFMwB/JGYo0?=\n\t=?utf-8?q?nXTRET+oziftczwXOpF9mGfbpFdkIiyjGN3tI5uMuc0pm2E9/Qd7J8u+ifHfl4t7W?=\n\t=?utf-8?q?ZpFNQOBp9+7hbM1oddOKVdT/MK3PeoosjrV6ou6dZzg4Q4U5OcmfcJVAwat7Ieou3?=\n\t=?utf-8?q?pPtimtPfJzFuZUhSmnF72eaXbozoA5uuWj7egKGVtlaMPwofKBTzGYmBGSFt2YqhC?=\n\t=?utf-8?q?uyMQH+yKk/vt4XsbVKsV3+SWti6lY/e12wKTflwlYDRctQkGBbSLrk9eaEOanOqxS?=\n\t=?utf-8?q?SDOw8HV6uOyayxisEvZHP0q1POpTFT5RP2+Z/5EZheNzuYJq8zjz0=3D?=","X-Exchange-RoutingPolicyChecked":"\n Ob3UcFLjqZoGyEK/idlYnrumRLDW135w9drnm0169tzO/EQ6awNYQzMhNmCKWjKY6ct58HsAa3ek56omYmnnfOtciVns8L1Tx8csQNslkVPKB7Amd22Xn0W03ffeyFIgUBg5Ogv7YxAtYe+l2/noqAg8T1eIvxm863ruqPq2LnuMSFrJUAfe4ZxVeuhlL/yUZ0OcVSFPfwnD6CL5g4IMy8WV05T6N02TCV5jSeq2mP/olnJI/nYE6L8yRPjnBS2jyytYn/k3WeRAOITIfQUl6pAuA75YmdoodtTP750zskZzMmoe6BnF4vYFc/y5qnpWOgA5DCJM6mul+J2jtYGAkQ==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n a36f2c02-89f2-47d4-2140-08de9b350ed7","X-MS-Exchange-CrossTenant-AuthSource":"DS0PR11MB7579.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"15 Apr 2026 21:22:12.0931 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n ySspo5xDq9md/HDrJa0kXsdo6tDc34quqyW8oxm+PBRnvvTz0fx6h4jAGcX8lASyChay3OyQecFOpuiVtTtWQB7d9KWGrJEoCTquevAw2NQ=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"IA1PR11MB6097","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776288140; x=1807824140;\n h=message-id:date:subject:to:cc:references:from:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=wOGIyK7IiwHlM6WYHbn/I6t6QUpO+YOjlB9YY6+9sB0=;\n b=av8AzkPbu3XZ9QMWIn0BnDbD/WjRyxrJghyRcqDF05DM7b4aGYy15Hco\n OtEaH89ShO1bzWTAm4MKzdeF7w0uXbvq4jJIgbO/waA2hmTWHQauDkXJ9\n yjTcqBIZHRRnk1RbmU7lfY1s1bjkYY9bg9v/EUnQMA09FOEtbkL7rvrr9\n yYKtyq15N+q/lps2eyxZNPpXGAbvPCYcx+xHAibqSw38pQBwhbecOf+am\n yI2/PQ2RWkQ2X6kFo90sHoTN2VrqCNAea7yivVrjdwHcl3KjkYxofqg3b\n w2JAsJGtrR9VSBihg68gto1JBcS/iJJsWZ44XdKwR/kuTPF3ZAeeXY8j0\n A==;","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=av8AzkPb","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix infinite recursion\n in ice_cfg_tx_topo via ice_init_dev_hw","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3677824,"web_url":"http://patchwork.ozlabs.org/comment/3677824/","msgid":"<363a062f-4e73-4492-adef-98687b53f5b1@intel.com>","list_archive_url":null,"date":"2026-04-15T21:23:52","subject":"Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix infinite recursion\n in ice_cfg_tx_topo via ice_init_dev_hw","submitter":{"id":9784,"url":"http://patchwork.ozlabs.org/api/people/9784/","name":"Jacob Keller","email":"jacob.e.keller@intel.com"},"content":"On 4/15/2026 2:22 PM, Jacob Keller wrote:\n> I'll take a look as well. I recently included this fix in Intel Wired\n> LAN update last night, so hopefully nothing too problematic...\n> \n\nCorrection, and I need more caffeine: I think I had considered including\nthis fix but didn't quite make the cut last night when sending.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=th/NOYNQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwvKP0pycz1yHP\n\tfor ; Thu, 16 Apr 2026 07:24:09 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 7B5CD605C7;\n\tWed, 15 Apr 2026 21:24:07 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 1qEzEAPrck6b; Wed, 15 Apr 2026 21:24:05 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id B08A6605C5;\n\tWed, 15 Apr 2026 21:24:05 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id 1F8FA2CF\n for ; Wed, 15 Apr 2026 21:24:04 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 10F0A605C5\n for ; Wed, 15 Apr 2026 21:24:04 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Gd9mG0xmIkkh for ;\n Wed, 15 Apr 2026 21:24:03 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.14])\n by smtp3.osuosl.org (Postfix) with ESMTPS id D9C09605C4\n for ; Wed, 15 Apr 2026 21:24:02 +0000 (UTC)","from orviesa007.jf.intel.com ([10.64.159.147])\n by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Apr 2026 14:24:02 -0700","from fmsmsx901.amr.corp.intel.com ([10.18.126.90])\n by orviesa007.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Apr 2026 14:24:02 -0700","from FMSMSX903.amr.corp.intel.com (10.18.126.92) by\n fmsmsx901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Wed, 15 Apr 2026 14:24:01 -0700","from fmsedg901.ED.cps.intel.com (10.1.192.143) by\n FMSMSX903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Wed, 15 Apr 2026 14:24:01 -0700","from SA9PR02CU001.outbound.protection.outlook.com (40.93.196.58) by\n edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Wed, 15 Apr 2026 14:24:00 -0700","from DS0PR11MB7579.namprd11.prod.outlook.com (2603:10b6:8:14d::5) by\n IA1PR11MB6097.namprd11.prod.outlook.com (2603:10b6:208:3d7::17) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.17; Wed, 15 Apr\n 2026 21:23:56 +0000","from DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e]) by DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e%5]) with mapi id 15.20.9818.014; Wed, 15 Apr 2026\n 21:23:56 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org B08A6605C5","OpenDKIM Filter v2.11.0 smtp3.osuosl.org D9C09605C4"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776288245;\n\tbh=4aeY6KNeuZkjQ86ehcQ577perAhKwLIgsVl3aRyb2Yw=;\n\th=Date:From:To:CC:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=th/NOYNQKmyyhP6TWbwdrvfMmVsXBsfaEsCXrIsbC1KqFFJSDMp6ijok3oAlPGi5X\n\t Ga4S6dxmg2m/JSCayhos5CEd3R2alyWc296uQzlGHSdC+4cP2bIod8FZllvm/EeqN0\n\t PtoviUvqkVZM0NsQ4k9xdYsJAUtyrolUgwDtwbwjG6aQb/OqnLEgqCauBDEHSTjZiK\n\t 3IBdccdf1y5+/e/+d1rXRN5Y+/vxpr0LJK72j6DCAfZGrKDTGrMTwVcBj5xyGXh+YF\n\t n2fEqRYSGKNgEk6FE2tmKhynW7bedKYFqyybU36Pgev1G8MesMOe6CguHySg7UPF3I\n\t q4zWr3tIyCQgA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.14;\n helo=mgamail.intel.com; envelope-from=jacob.e.keller@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org D9C09605C4","X-CSE-ConnectionGUID":["hKQBpOvTTGqB2oF2JK3GDw==","GPI58w7DRcei/tfUEhK4JA=="],"X-CSE-MsgGUID":["qbIvYBvSRi2d+lCJwD+Uyw==","zYDc6/gtRVW7TCU/LGF+9Q=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11760\"; a=\"81152424\"","E=Sophos;i=\"6.23,181,1770624000\"; d=\"scan'208\";a=\"81152424\"","E=Sophos;i=\"6.23,181,1770624000\"; d=\"scan'208\";a=\"230777224\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=IoFCYkptTsc0SerPlYXY1/nqWKoWuB72IHXXwt26/6plR+yHIuRHOuJ2l0QSEHkKf09Ae7DnkMBBtWUTAar4/H0jb2WK034o3179yZLg2AMlOH1egpdtjKnGYzEbE2kAcgA1jMd9nYc+Gqu+FI+pM9wQhcIqIdiwQSmnWoSGfqX/IXCqowTPmjTqNkeO53bUJ5o6tKGAfeXNmgtFJubV3XaniOIp74JdfjOLITiMY1HMSZPQRza0yz43w44IxVC+ubDc7hu7iscCESaslE1asTDHO/R/BtxifOiE0rIomiOIbLTfC5hHkleSdmdDW9s8RXFSTpJQk0+s6Gc32tPRWw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=4aeY6KNeuZkjQ86ehcQ577perAhKwLIgsVl3aRyb2Yw=;\n b=Imyvia/G4wJCdQUe6cWST7hOh9R3ydsbdDT8U+qw0DCWCDc/OTGRCHGY9WVjoIY9gT/2Z/bEjUB7J4oVgy/Xp2yVlxDUdkdlxHCNmEpgfQacy5HhackY31IwnBqR1Gl6sMnXoj9Td49bdr6wSHSR7aJiTnjQesB/DFg7BVAW8KJguSfpvpn5UgrZvfJW8cQ+wAH82/gh4IfTrshfeE+xbrFetU/+jND97ntXRrd+4Kcgd27B8aymx1T89Nxhwqud21O8BaWTljyijXHU+sGyieXceAayt6m7smDuBkcUpZzbg7+Rgl1INn5gyYkGQQxsIrLtLnCbCbY7ypa4rDVMOA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","Message-ID":"<363a062f-4e73-4492-adef-98687b53f5b1@intel.com>","Date":"Wed, 15 Apr 2026 14:23:52 -0700","User-Agent":"Mozilla Thunderbird","From":"Jacob Keller ","To":"Simon Horman , Petr Oros ","CC":", Tony Nguyen ,\n Przemek Kitszel , Andrew Lunn\n , \"David S. Miller\" , \"Eric\n Dumazet\" , Jakub Kicinski , Paolo Abeni\n , Aleksandr Loktionov ,\n Nikolay Aleksandrov , Daniel Zahka\n , Paul Greenwalt , \"Dave\n Ertman\" , Michal Swiatkowski\n , ,\n ","References":"<20260413191420.3524013-1-poros@redhat.com>\n <20260415163003.GP772670@horms.kernel.org>\n ","Content-Language":"en-US","In-Reply-To":"","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"MW4PR04CA0195.namprd04.prod.outlook.com\n (2603:10b6:303:86::20) To DS0PR11MB7579.namprd11.prod.outlook.com\n (2603:10b6:8:14d::5)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS0PR11MB7579:EE_|IA1PR11MB6097:EE_","X-MS-Office365-Filtering-Correlation-Id":"b2b85555-e6f9-40e9-1587-08de9b354cd7","X-LD-Processed":"46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|1800799024|366016|7416014|376014|22082099003|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n ZXeAnMaH7g5Gk6F0lWXdO0EX0YPaKPnIQB3B7h8a4PKChYXzRO19wYs8EBzTZlekQV7N7btGuCu5QHTKv91H4BRJdubKITQHAvgioJYYYVmBO8hNEQcLT0vmJLX6byU2nB4+FIxpk4ClEUyxdZbxOkUCvl840kkJU3cke6wleX8qndfdH19lPp0czAisWlW9c2E/68GX3cUMOpv+R5kOC9HeqY68CFYMlZi3gqpJhdR6RFjlFIm17yLmpCp+giKcOUvJ1Y/5ApYYj4PxXRkgzxmvBWBgAQc+igCsqbOE2kFgKHFkx+Zkyc+aA0bVNgkGZZnblzmmqCHxtJG4pbL1y4vJaTdAomy6Zb+/Ae3GMX9V/RBCArwyqIASmP746li4mLgy388zLLi+/rYz6+onlMytmnfBqRqVjjVmoKwqde9xnQa7PvpjkIRNJAK/eeQeFlD45PkUwHuaRuFsZ6Lynv9b6AAAQ0Y9zNbdG9JTIoqr+miJQ2NffZY0MQT+1igvWMkoh8Gl6e6QDZNMBeQOFDM7gkdeWp4mAQhMIJT+OtRcA98akp57680Hx/DFVDm9+oZ3mzc3XBp+5EYaN/E27KNjXUbWq3tzf7WSLuqZ7D+MlMfeTkObC+hKLjeSDl0n8R5N2sBZqOqEi4PFiszUs840uRkhrMkV5xZvZ2r6VQ+9HbXx2mD0DElJoR5nZdG1FXzdHiT+ZrCLXq24cNbtRDRuNVajWcklLQsu0JEX9W8=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DS0PR11MB7579.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(1800799024)(366016)(7416014)(376014)(22082099003)(18002099003)(56012099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?8N4unHDFIEEwUSggn6kH0qyK4Swk?=\n\t=?utf-8?q?hdhDKvgi3QNpFXSvaDEZnLiA/acLk402tUeJkPmYErwUTas5pg/yjll5l2yrOWyFm?=\n\t=?utf-8?q?MU7iFAYY29CdKJzVJ4n4VIJ4pdPVpGJecxup8g+2H2BgTS9GRVoR2QLvl9Ct9/2rf?=\n\t=?utf-8?q?2TDKXIeTqJLCCr58xT3WpnEeq8RqENjo0Nbgne6nHbERRcmfBEkHbsCm5RoxlipUQ?=\n\t=?utf-8?q?yjOsjDqUtQp7dGjaVptec+tlMaAqcH748QxLY0MTusLHeugoI4dmwSPC+m5hpA5TX?=\n\t=?utf-8?q?ON3tB3NlDbfdXOgruv1JIw39RTBglDZ2nGsqRJlQzWNY/UsYH0HjW/kwI4xyP/9QF?=\n\t=?utf-8?q?1RAcCb4JF6kJBmF3q2Rnl2ktOtJd7CD5Xlz2TCVEYpuN/kmrn+GodwsdP30rO/TCT?=\n\t=?utf-8?q?OnDcLoupStWYKwIqeJjbrzfsevxUx0KT+gPgjal2mMHmkbNUDcqJBEgljAdakOM1Q?=\n\t=?utf-8?q?3nSGmv6UEZ16+HIPFlMC47eIt9zMvV8vGc2nM1z9nJR08U8GGVPS+XTkywxRwGDF2?=\n\t=?utf-8?q?ZLQBTQkjp/fmmf6N2fErXk1SK7JmnLZ2Trn+RoA+iFeTlzYxBvVuDP3CIBm0gxewG?=\n\t=?utf-8?q?GaxDz1FQFB4Ilw7NETDRYnkGdEWuiJIhHrn+ResZpTMyD6I6h3dKgNLPCMXmCcbSW?=\n\t=?utf-8?q?RdKo+BJMDcJ9QaUqEOtxSohKqbKvSyuagMoJfUo5fPx0EZaA94tNRCnr819fR8mgT?=\n\t=?utf-8?q?WjpSQmx2bi7pdzCoJ882dbALJPKFZqAbzOYDcpymukIgFAzbrqqdom6lnjk0hQ63Z?=\n\t=?utf-8?q?skQzZe6IDmwbn/SQ1lDEt2eyK91hf3ESRYexWQHN0O8COPJq+WMFWiejB5XytSMmU?=\n\t=?utf-8?q?cd8t8jsu9mTc+eycFQrcphWVCSGykvVZXz12zdrUdiPtjoC8vNq89Kt5KPVCnPw+D?=\n\t=?utf-8?q?jU43rcecd31oKDYTqB46Ar5K26Z9SwTLIt+FsW50w83JPSKRvSEzOEWRBaaXSrwoo?=\n\t=?utf-8?q?wx3O8D5VG+sO7VPeMm1dzYqRZ1M18tXu0Zmb5TftCCapneQeRaIojNbOuONZw82kz?=\n\t=?utf-8?q?zAXvT9ehHKp8xvoNcHY6zmQIw8thOHZX5YQs+nz883+okYtj0GZM/7j8r+NrKLMHR?=\n\t=?utf-8?q?mYLeNpv+i1D9+QA/g42f/mST5kCDKAJCBMXV12L81SQVdyhqOxmK5ZiF1hWuvIQqG?=\n\t=?utf-8?q?O9SVeRYUiHvhqaNafWg3U2uT+fZhjd8My/cqGKikObInvVvfh5fNtKRT+FSIsgNI6?=\n\t=?utf-8?q?4MzbSOLqo6pY5+7GK80TeCRGg279GAs+dDMHYkcHfgEtZF57dGXE/6KXeGyDWI6/M?=\n\t=?utf-8?q?savljrbgDb7IAX/y6EQ+4+nYxZnykAaA7cO2pVYYIv/s31JmGme7UTloFmQPrRx6e?=\n\t=?utf-8?q?BH+RP1Faz87g4Ic5Md267q5u8PdOi8n1PKBBEkW7xpmerHA/+PtIOTK6jgZRgrr7H?=\n\t=?utf-8?q?SRE3TkTtCi2OVkmvjD1G465tvimcV4NbS/ZJrh/1bMphyIa/FwEMvEL1C324ge4wb?=\n\t=?utf-8?q?Wy5bKD8HXQtXVb/SRavDwaF+uiUwrFzq0w7i3w+h3jZCm4cX2JPlLnIOS2dOAZgmQ?=\n\t=?utf-8?q?7D8y0AOCgKNNsrmp5u5qElNJWXYKk5qa6hAwUWh5YvGD5DD8nuCMmVnEvQEzE+2J8?=\n\t=?utf-8?q?ibq/WI/inGRkhuXFk5KJ6bqhlE8rzuZcCZGo6kQKTcogreR9CoFqvIMJAUMNp0kZM?=\n\t=?utf-8?q?ANdiR+jripGhZo9zcW4YSUgg1PGysWtB/3rNEJGdVEJwZHyTI36DA=3D?=","X-Exchange-RoutingPolicyChecked":"\n T3roxbFIWS62CFG+SyUDFEwxUY+b6m24IlXc8RDb1eQfT2xMWyeC7LA8ImGaBkAwYNcUXmTIBOL85L2hw7KABEetGkZJI14gDEB1qOZJabdyUoMYxC16K+KOUju4S964jHdofUnOQDnF0adQXcZBFix9Vsi8xy2YBrkUjUk30/bHJldY905V8U0+ztmpA75axG/f/mvGzDJLiwLFf6nsXKXonRBvFcAk3+QOpkmZ9naXUPE8vno/eRWERnPqP9spLuCdsRHsw2llhlpiFGJpF3omn1V3EywWi8yDPLzv2rn4pLAGuFeiq9b4z9l2Bn5LF63Ft0H087YLmSjfBHi+LQ==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n b2b85555-e6f9-40e9-1587-08de9b354cd7","X-MS-Exchange-CrossTenant-AuthSource":"DS0PR11MB7579.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"15 Apr 2026 21:23:55.9634 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n xJ4f++2aM6TtKY2fqPtVM13ihrfHF/lBl2B55GveakwWPEPonh4d6BtubwImCXJ8EM4GRY+8qtT6hTQYbZZ+x4vp7pgjNhcz928DZqBJlVI=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"IA1PR11MB6097","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776288243; x=1807824243;\n h=message-id:date:subject:from:to:cc:references:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=x6u0aG0d1yadygxVcRtRmsGrmT+rIuIgWc5+l+gSzm0=;\n b=aMjSR2NPG/DXGJf0oTftoyZddJRA6G6FqZzJhIgDZW4WN8XPtvcfsC2Z\n +Q21VXrGlPDWbHBroDsT4XpVY2NS6kzRSdPyb+xiLQ+Fnn/eNACjKDPCi\n QKq1aef3ru+NTyj/SLZv+n2Ukb1ApYlIrHZV/62ZRUFEjVlfr17c+vHEg\n kt4TwA27KDTs6XK2FqdbHB6doTi36c7t/ACjFu++fzp0fm6a1O4K3jvfK\n agfdn7wqP0ok4GRSZnnczI65ARKTsItq65Hjh6tJfjiTfoIOvllyz94Yi\n A4TXBnNxQ2NygNJtveYt0A5bmv65+PCo1tIg9SMQbB25LlHaxaOJPhmVS\n w==;","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp3.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=aMjSR2NP","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix infinite recursion\n in ice_cfg_tx_topo via ice_init_dev_hw","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3677932,"web_url":"http://patchwork.ozlabs.org/comment/3677932/","msgid":"","list_archive_url":null,"date":"2026-04-16T04:36:35","subject":"Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix infinite recursion\n in ice_cfg_tx_topo via ice_init_dev_hw","submitter":{"id":85252,"url":"http://patchwork.ozlabs.org/api/people/85252/","name":"Przemek Kitszel","email":"przemyslaw.kitszel@intel.com"},"content":"On 4/15/26 23:22, Jacob Keller wrote:\n> On 4/15/2026 9:30 AM, Simon Horman wrote:\n>> On Mon, Apr 13, 2026 at 09:14:20PM +0200, Petr Oros wrote:\n>>> On certain E810 configurations where firmware supports Tx scheduler\n>>> topology switching (tx_sched_topo_comp_mode_en), ice_cfg_tx_topo()\n>>> may need to apply a new 5-layer or 9-layer topology from the DDP\n>>> package. If the AQ command to set the topology fails (e.g. due to\n>>> invalid DDP data or firmware limitations), the global configuration\n>>> lock must still be cleared via a CORER reset.\n>>>\n>>> Commit 86aae43f21cf (\"ice: don't leave device non-functional if Tx\n>>> scheduler config fails\") correctly fixed this by refactoring\n>>> ice_cfg_tx_topo() to always trigger CORER after acquiring the global\n>>> lock and re-initialize hardware via ice_init_hw() afterwards.\n>>>\n>>> However, commit 8a37f9e2ff40 (\"ice: move ice_deinit_dev() to the end\n>>> of deinit paths\") later moved ice_init_dev_hw() into ice_init_hw(),\n>>> breaking the reinit path introduced by 86aae43f21cf. This creates an\n>>> infinite recursive call chain:\n>>>\n>>> ice_init_hw()\n>>> ice_init_dev_hw()\n>>> ice_cfg_tx_topo() # topology change needed\n>>> ice_deinit_hw()\n>>> ice_init_hw() # reinit after CORER\n>>> ice_init_dev_hw() # recurse\n>>> ice_cfg_tx_topo()\n>>> ... # stack overflow\n>>>\n>>> Fix by moving ice_init_dev_hw() back out of ice_init_hw() and calling\n>>> it explicitly from ice_probe() and ice_devlink_reinit_up(). The third\n>>> caller, ice_cfg_tx_topo(), intentionally does not need ice_init_dev_hw()\n\nice_cfg_tx_topo() stops calling ice_init_dev_hw(), that is the real\nchange that patch does, OK\n\n>>> during its reinit, it only needs the core HW reinitialization. This\n>>> breaks the recursion cleanly without adding flags or guards.\n>>>\n>>> The deinit ordering changes from commit 8a37f9e2ff40 (\"ice: move\n>>> ice_deinit_dev() to the end of deinit paths\") which fixed slow rmmod\n>>> are preserved, only the init-side placement of ice_init_dev_hw() is\n>>> reverted.\n>>>\n>>> Fixes: 8a37f9e2ff40 (\"ice: move ice_deinit_dev() to the end of deinit paths\")\n>>> Signed-off-by: Petr Oros \n>>\n>> Hi Petr,\n>>\n>> I don't intended to delay this patch.\n>> But could you follow-up by looking over the AI generated\n>> review of this patch on sashiko.dev?\n>>\n>> Thanks!\n> \n> I'll take a look as well. I recently included this fix in Intel Wired\n> LAN update last night, so hopefully nothing too problematic...\n> \n> Sashiko says:\n> \n>> While this code wasn't introduced by this patch, the restructuring makes it\n>> more visible: can this cause a use-after-free if the nested hardware\n>> initialization fails?\n>> If ice_cfg_tx_topo() triggers a topology change, it performs a CORER reset\n>> followed by an unroll (ice_deinit_hw) and re-initialization (ice_init_hw). If\n>> that nested ice_init_hw() fails, its unroll path frees hw->port_info and\n>> destroys control queues and mutexes.\n\nhere is a talk about \"prerequisite for the problem\"\n\n>> Because ice_init_dev_hw() returns void, it swallows the -ENODEV error and\n\nand here is about code that Petr just removes, IOW, does not apply\n\n\nPlausible sounding comments, yeah, I hope we will not drown in the sea\nof AI content :(\n\nfor the patch:\nI have tested that it does not break my test suite (it was me to start\ntouching ice_init_hw() and friends), and both code and human written\ncommit message looks good,\n\nReviewed-by: Przemek Kitszel \n\nthank you for fixing the code after me!","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=HBu64hW/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx4wv3rw2z1yDF\n\tfor ; Thu, 16 Apr 2026 14:37:01 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 9877980786;\n\tThu, 16 Apr 2026 04:36:58 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 69IFZ7b091wf; Thu, 16 Apr 2026 04:36:56 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 9F50B80784;\n\tThu, 16 Apr 2026 04:36:56 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists1.osuosl.org (Postfix) with ESMTP id 03C4B775\n for ; Thu, 16 Apr 2026 04:36:55 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 008FD4015A\n for ; Thu, 16 Apr 2026 04:36:55 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id qxWm9eb24Pym for ;\n Thu, 16 Apr 2026 04:36:54 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.21])\n by smtp2.osuosl.org (Postfix) with ESMTPS id A27CD40148\n for ; Thu, 16 Apr 2026 04:36:52 +0000 (UTC)","from fmviesa009.fm.intel.com ([10.60.135.149])\n by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Apr 2026 21:36:53 -0700","from orsmsx902.amr.corp.intel.com ([10.22.229.24])\n by fmviesa009.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Apr 2026 21:36:51 -0700","from ORSMSX901.amr.corp.intel.com (10.22.229.23) by\n ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Wed, 15 Apr 2026 21:36:51 -0700","from ORSEDG902.ED.cps.intel.com (10.7.248.12) by\n ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Wed, 15 Apr 2026 21:36:51 -0700","from BN8PR05CU002.outbound.protection.outlook.com (52.101.57.36) by\n edgegateway.intel.com (134.134.137.112) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Wed, 15 Apr 2026 21:36:50 -0700","from MN6PR11MB8102.namprd11.prod.outlook.com (2603:10b6:208:46d::9)\n by SN7PR11MB6680.namprd11.prod.outlook.com (2603:10b6:806:268::10)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.21; Thu, 16 Apr\n 2026 04:36:42 +0000","from MN6PR11MB8102.namprd11.prod.outlook.com\n ([fe80::8d98:e538:8d7:6311]) by MN6PR11MB8102.namprd11.prod.outlook.com\n ([fe80::8d98:e538:8d7:6311%5]) with mapi id 15.20.9818.017; Thu, 16 Apr 2026\n 04:36:41 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9F50B80784","OpenDKIM Filter v2.11.0 smtp2.osuosl.org A27CD40148"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776314216;\n\tbh=hbQhn9BdombBSdotYhOov2EOlI0v3fjoo0MgyOn0/OU=;\n\th=Date:To:CC:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=HBu64hW/Azfj2nT2Xll2qXG2AvFuaaHPJ2UhAqRWXQORQYhdXxrpfczxQHfAg8/z8\n\t AJdLGtG5OlWRWjwahLv/ixRY09KkJK9tdWyVcxfTgsAtWtyQpYJFEyIJnMvV+0ESDU\n\t JEu+v54R0z7MlV1Mtubokqh1SImtf8cpdizlKuVALrHhe81iBnZ8ugdnF335ZacdZF\n\t hUWTlYTc8qONYVLvQsEJ9BjgN/yEwnk8wTopfpqlmALHk70vNPhXzFB1lhqQZUfxQy\n\t rMSaZX49bXTE95cLz1z8yvLZaGPujctqazJrCK1spFT+fa4HWv1IKkHgWC3j3T2lT9\n\t Al097O7TP74zg==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.21;\n helo=mgamail.intel.com; envelope-from=przemyslaw.kitszel@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org A27CD40148","X-CSE-ConnectionGUID":["zrejScbXSQ2E/8/gMpIH4g==","OePc8m2LQzGEfgSb7UNbwA=="],"X-CSE-MsgGUID":["GVvlqFoMRK2STkvRpHgR7A==","3HVm+8NSQLi3Or+I8+rDrQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11760\"; a=\"77178929\"","E=Sophos;i=\"6.23,181,1770624000\"; d=\"scan'208\";a=\"77178929\"","E=Sophos;i=\"6.23,181,1770624000\"; d=\"scan'208\";a=\"224109151\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=GqqKIudQEI+JyoCKXTc01wvgtqpLsd5G8UZXQPNjvMaRlWRa3cTBB4RiCHmJkX4NbLdh4HBazArbX5w40CmGPw+KfhDOIqgPPkt1Npp5rp42+DP7XVSt+Xy130WCqQKYenJvljGbRRrRl1sVS9wC2ho7DOpE9+pJ+nNM4O4nll6Tn/CGAYYjWdwnwPOxCNv6JxYFL+8gnUWkBcaOcflLIIAZLp5f58XIsO+EXwh2zwHrfkfQ1F2cdAXdAu67W2ok0lUJdDMw9M6Pv/VnkvWpg2n70Lp6RjEKXlwwK4ekDoIj1DKrLxS6HNRCVuI3avyc4yAuSAsplCSIkP4W2pCitQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=hbQhn9BdombBSdotYhOov2EOlI0v3fjoo0MgyOn0/OU=;\n b=lj/GILd8wLikGTCwdlk8S/8NSgwKx+khkAA1x2sIT0PAzXxJCOPyB+hYluNpPbmY8Mgl4WStd6atcBBWCGztDQfA/mz6vxV2yBrDdgm5yE9PJrwvQU35Hfp/QmU9nSWWHW4zstxpf23EdDPlWRGwtNa5r8P0ci1+oEBQO/gEiP0+StCl5JMklOiApltfj/mmwshZYenRhgtRA8o1SzFMXLjSjAX00OOR0avTpV0b2Y2HXEQG5YU16G4+Y+JIwyzoXKzRmrEikbdjZhVmQANT1LfyUz5CacfbWWbIXNbIUQ1pAA1ww9coIFrTmxU4drja1Pn0ygBPoOtnKorzwIm+wQ==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","Message-ID":"","Date":"Thu, 16 Apr 2026 06:36:35 +0200","User-Agent":"Mozilla Thunderbird","To":"Jacob Keller , Simon Horman ,\n Petr Oros ","CC":", Tony Nguyen ,\n \"Andrew Lunn\" , \"David S. Miller\"\n , \"Eric Dumazet\" , Jakub Kicinski\n , Paolo Abeni , Aleksandr Loktionov\n , Nikolay Aleksandrov ,\n Daniel Zahka , Paul Greenwalt\n , \"Dave Ertman\" , Michal\n Swiatkowski ,\n , ","References":"<20260413191420.3524013-1-poros@redhat.com>\n <20260415163003.GP772670@horms.kernel.org>\n ","From":"Przemek Kitszel ","Content-Language":"en-US","In-Reply-To":"","Content-Type":"text/plain; charset=\"UTF-8\"; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"DU7P189CA0030.EURP189.PROD.OUTLOOK.COM\n (2603:10a6:10:552::34) To MN6PR11MB8102.namprd11.prod.outlook.com\n (2603:10b6:208:46d::9)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"MN6PR11MB8102:EE_|SN7PR11MB6680:EE_","X-MS-Office365-Filtering-Correlation-Id":"c4ff6377-04a6-4eca-0d8f-08de9b71c144","X-LD-Processed":"46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|366016|376014|7416014|1800799024|18002099003|56012099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n EwChHBu816CvSH5SEoZrWZvH5XmL9EfE6ouirHn33IMwUn/53ZObrL1cXdzAGIQyrLH6DekH/pv7UpTpwHfwdQj55/7KU3oXSNOEHSOkFR3WqEvPJTSZU++q7lsf8VVxGLaDjbMgDMlHzOXMkUhJxKv1t09xX8Wn0trgajF9JfHDcA/NK20B4RwNDYo/v7POui2x/LSpZjwhBNxKgwvz5XknV8Hou5lYH1N6vY3dggNGiXnsyvYo9IY2FT0YiAYAgcaIT9e0LSDnLwSDmIYZDtwhiqC/jDUy1QgZj3aBIQ/BXuapUciKXek7K42ta6sikq1moy/peCvIo8NTMYqch4/JXqT6mgC7oOZ0Hje0Mk0sSZxMJpnDCHXxaLNXf/Hb97S7a72+U1ztm85Ja1X6/AeKXtBl4N2hj60mUj3AnT1zZdLxN8zDPZAPrvNBTHHHDr8mK6Uvu0+UaxtRLXmx04UFkyTTX5cyyziwcXDORQHcbzz3lVMN8B+CuAxWh+YqJK8buWsT/7y/PTRMWd/ztX+1qy0Mxhcn0rgQyKqhqm9poedWwXjtbKjrwUl0bxI01+P8IBxCmhDWoJEetT5lPqwJAdtW2q+MKtEJ81CSU4m90dxCv7+ZcYd1mjsuB2gjbDCAsTYfsHD3bK5WZoFQQ+4K4vZf/zoFLNT3wXdQTx5LZ40XlNEQk9c8oF8cg+z5HTnYsiY8U8cUPDTvydu8nsuoi+5SP3luutl+iA8KTBU=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:MN6PR11MB8102.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(366016)(376014)(7416014)(1800799024)(18002099003)(56012099003)(22082099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?VkU+amna2j6FyJFTlRJQMqaVKItV?=\n\t=?utf-8?q?9eIrQ7hoYZxExLYzXTbNMIDVQbZNYd5l37vYfO/uCowthaJs4NEc+p1zuNdmo35FV?=\n\t=?utf-8?q?F6lItuIIjPgZQ5XRF1eDcp2ZBwttUIZM8aWTEcMBmyfYvkW5QHU+jl3DTljO+LzmJ?=\n\t=?utf-8?q?PXQlDxud0ZHCslKIJ4RGqq1/Yjsq1vZrV/gj6dUPqCgI+l9QFeq0Jz7rbPwb8Cxp5?=\n\t=?utf-8?q?ohO4Vjn6uNfvrhVv5P41NfaCYBd6XSoR2/iHkgtgcRonuBGj4gb87yMErXwrfZgh8?=\n\t=?utf-8?q?TQAmKs0h+TdRLLumWuaymUh1p9cdcONliM1jzWF1uk3bFmCw3jwEQhAT4/6AOkQzq?=\n\t=?utf-8?q?CsliqiJ2GinvFEz0T9waJynKjdKiw7+Fyf6UsszHGHJMXa5147azxY1dZl9o7UMFF?=\n\t=?utf-8?q?i+xbndcCmIuipddOuflawip836AZUI6BZNjUN3Pxa8aikpVU7aDyC6kVuxkdetpVa?=\n\t=?utf-8?q?OUpvpnTcfUu22K0a0QXmhXrE3kGgwqgplNigIqrXrCNRcnb7q/DN6PvNS7ljekAaD?=\n\t=?utf-8?q?Y46bQohYbRD28HDjRmw1NRCBYAcDMx6r129f54BF79j1FLT3U7D8MrGM0Vz52DVyU?=\n\t=?utf-8?q?c7ccSqid0RpxcsWfn1zZHWNTRF+L7/zpeqgthrGgd2yqAr3E4hHU1qNOu8ViZ7Mej?=\n\t=?utf-8?q?E5Y7gz3JJeRapQHBqv0JgIm2jw44KoTLD28wKxO6sctMkDZ3Mwm1ZRzs0TqdfrusK?=\n\t=?utf-8?q?kVx0D+1MQ+9c3nQN5FLCr5PD4sM9hycAuXN7o83prrjkUXQ7bbP8xHi5zJ3FZzvif?=\n\t=?utf-8?q?C9kytfLyLaPw9TUNwu8VzlSBoIpqX3R180oUN8L+gaQbSNDuBNHEykdmSuiKqK156?=\n\t=?utf-8?q?nlevyatfpDQdxn3k8KBETLO9fVmaRHNxQ1Bgy5wgy8kcThDhiJNEOZ8PZpHwPcmth?=\n\t=?utf-8?q?O+jWwtysPyEsbfQECNgr4CHuJFrc5p5tNtq5Kiru5oq/NC2jjjHRmyk+aCL80hl1R?=\n\t=?utf-8?q?XOethb+VN8xI74tVy4WnMLF/ZC3Rqof0AmFkigNjUJNNZ2Miwh9ssEhhYHLTSXCxz?=\n\t=?utf-8?q?sF7RwHr9vQQ9txOU2am+fHmlFWr8i1mB5IWIuaRNIxXuEmpzLmy0c5gTZQlBamD6v?=\n\t=?utf-8?q?Bi/lrCTUqBc9Q6xuS25WxbkklUj/hv8InBlLm8LakZcZXX2sL6mz1lTI3fi5vV0gR?=\n\t=?utf-8?q?f9bl48sd7nUmmHonlDQ3l9XxLImk3x5u1YAI4YUzIywxA45zxFfGlAL8dMytAV2wO?=\n\t=?utf-8?q?m3L4ZyONYz1H4MBpuFbjWMMATzvWCqqq48UW6PlVVJtcd8vTIP9LW8MfGIwv2oOxL?=\n\t=?utf-8?q?tCrUNbu1po4jUQOuKs+ok71Hhe0EezvBZo/ZhMEV5U6UsTqVZCORzqiiXOX+/yPiM?=\n\t=?utf-8?q?ST09OjKZ2x4HRGTZdF10GwK88lHkoiVQPDw6Au6tqHEf8RJbnCJiLKkc2Tg7nXSRS?=\n\t=?utf-8?q?GTBIHuTzc6N+89VdmrNYVdyHYUEa+Q4TVrXHb6OQsHEpL6E9skQrYHQa4YXloq5Iv?=\n\t=?utf-8?q?oZIqGIg0ETYKU68Pt1KjKld3PRhkEgkKhLwTF1O4HKiuOtVdBz/+HwXOTNSQ9STsd?=\n\t=?utf-8?q?KZpH2BE+TFFLEFv66SPkQH6DdEeJ7/mzurRUfqePmu+gnu6SxplIQD+WqGR2HCz8r?=\n\t=?utf-8?q?4P480uQJHlEJePrlCO/GA6JLvt/HqaPFoyuD8Hn7hfplbfYtqgQlWmZambiIZm6w1?=\n\t=?utf-8?q?7N78/TXaTnWCWOzzj3uybQI56VV8M0hs6BDQ15w221A/+8IhMyfHo=3D?=","X-Exchange-RoutingPolicyChecked":"\n uDUwW0/f3u7kIwYPHrGsL9Bmt/6ErD0GZIbp97pEyWw46HFah5G3DAobIzX4cBIV/c0+ANanrA95DcHJr1fd3NkC2HxZevHtiEa8pBZLzoHv57RfUd6aAm51w9B+6mKHeqU+OOBJ/7i+H1QN8tY0gksiyuXE8IFtQ1fneaQY9IonU0hLWIa7NsTa0grL5LbmIikxMXe5yvWuVRyVDSiShOY6vItlB32bU8Sp9nDagxqYCXlLfDQ1HKUHh7GBO1uIXS8EabHNp05GutRueY6oLHqsaA9HWFt7P2GaZz9jmfo4lh8K2drEQJ9DgAFFkrW8LhUSDyydqZebw751huuJ5Q==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n c4ff6377-04a6-4eca-0d8f-08de9b71c144","X-MS-Exchange-CrossTenant-AuthSource":"MN6PR11MB8102.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"16 Apr 2026 04:36:41.7243 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n 5vTEAD20NTMph4GM8davWnOlS8RpvaMn8JNXa7/wMSiZfbc2UUTlx5B3T6o1+qhKbFTXLaaekG6AtRgPeu2ZvcXdCgG8EEs0cmGpJ99EVJA=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"SN7PR11MB6680","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776314214; x=1807850214;\n h=message-id:date:subject:to:cc:references:from:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=ZZfEeLrTwrmrEypYMBXIiZOfObfp0ImwWfwaFXWwZKg=;\n b=W7MCROA0JnwzBWV2hMYrHra7PtOwavd1tZ0dqUj+n6Vd8/8185B2wDu0\n J1dTaUq5H53s3R1ifIt2PUOXrFh3CBzSRNkRIUY7U1Hkc0fms770QlKie\n TUoWvsSQuRjMN4gVcg+9vTfoDj8p4m52tvs4LPKj0o5oejRy/xxG836OR\n s5zDq4U+DgdPem3ystn6VUtSM33OM4TSOe3OXx8Lc/Vf1kzATKED/v/4c\n uOC2fx2aspVaCvsRXXSeDhTN268Yk2vnIC9d4UgRnTt3E56+q6vdOh9Ky\n VHoj5Ysdg2wL1m7QCEzCieLM4tTpPiLs8La8Gl2kG9eL7/BAygeOhPVfn\n Q==;","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=W7MCROA0","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix infinite recursion\n in ice_cfg_tx_topo via ice_init_dev_hw","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]