[{"id":3679047,"web_url":"http://patchwork.ozlabs.org/comment/3679047/","msgid":"","list_archive_url":null,"date":"2026-04-19T01:35:28","subject":"Re: [PATCH 2/8] smb: client: compress: fix bad encoding on last LZ77\n flag","submitter":{"id":510,"url":"http://patchwork.ozlabs.org/api/people/510/","name":"Steve French","email":"smfrench@gmail.com"},"content":"merged into cifs-2.6.git for-next\n\nOn Mon, Apr 13, 2026 at 2:07 PM Enzo Matsumiya wrote:\n>\n> End-of-stream flag could lead to UB because of int promotion\n> (overwriting signed bit).\n>\n> Fix it by changing operand from '1' to '1UL'.\n>\n> Signed-off-by: Enzo Matsumiya \n> ---\n> fs/smb/client/compress/lz77.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/fs/smb/client/compress/lz77.c b/fs/smb/client/compress/lz77.c\n> index 16c7d8f3ef17..c1e7fada6e61 100644\n> --- a/fs/smb/client/compress/lz77.c\n> +++ b/fs/smb/client/compress/lz77.c\n> @@ -216,7 +216,7 @@ noinline int lz77_compress(const void *src, u32 slen, void *dst, u32 *dlen)\n> }\n>\n> flag <<= (32 - flag_count);\n> - flag |= (1 << (32 - flag_count)) - 1;\n> + flag |= (1UL << (32 - flag_count)) - 1;\n> lz77_write32(flag_pos, flag);\n>\n> *dlen = dstp - dst;\n> --\n> 2.53.0\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=ElNK8775;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10908-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"ElNK8775\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=209.85.219.50","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fyrmN23rDz1yDF\n\tfor ; Sun, 19 Apr 2026 11:35:48 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id D27823025E57\n\tfor ; Sun, 19 Apr 2026 01:35:44 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 88F5E202C5C;\n\tSun, 19 Apr 2026 01:35:42 +0000 (UTC)","from mail-qv1-f50.google.com (mail-qv1-f50.google.com\n [209.85.219.50])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 3417F13D503\n\tfor ; Sun, 19 Apr 2026 01:35:41 +0000 (UTC)","by mail-qv1-f50.google.com with SMTP id\n 6a1803df08f44-8acb09ddbf6so29996586d6.2\n for ;\n Sat, 18 Apr 2026 18:35:40 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776562542; cv=pass;\n b=PNvx3ounD+v8D3AtXS7yApao0VUKPVsuyLELuB/uTZqSBYlKL6iweI6c5qUBGLEMktd1P+U9DC+I8uDnTwQ/MWHm4aFulzLvh6FSmN0+VerRiAWvejuEzcCskkJrNGfMUM3GdENNe1gzqcfWM65UnJCDRt6ILgyntjDVpR4NXc0=","i=1; a=rsa-sha256; t=1776562540; cv=none;\n d=google.com; s=arc-20240605;\n b=R+Fi0eybBCh/OJAgcd2dPRWBoiiAPacW1Jp3cTRvJYl7q3e6pYvU8e8iFjzUYmsBA1\n GgBnw0saUAJ1UBTJAxAu5duZxxYwQ6ofFHYPVnfuk0j6h1ThXVZi6ehUK+YsBZWeM8+P\n ztBw15iHdqTlfHUhgmCrFyLJ8c6I+U+ixOJZrJWXjsK7qFDmp8WIrQyotUF6q9OEW702\n 2/Le+0oy1T3IB5piBMwSigNoGB9ZLJJZLwzuurd6HaR2TqQd4sf5DaucICcGUApVf42E\n FgUhHQbWRIOGaVmQNer8rU2/RO1T7t+IhX8jUoXIGp4MnPcYRCJV9A5KitaCf+Ymy6Hd\n 5pFw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776562542; c=relaxed/simple;\n\tbh=lcvIlPsdDcCuLZWc5L72DnCt7HcsGssFjaoId6Fn1Kg=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=BWTn5VN7GFRnFLrsuZeJHQo0DN/kzPySESDRoMDdkLBR0DcIuSm3hHmd0A9y12hQCBV+CElR3zSXbAb5mcYom3M3ZdReWFyz7cQfOgh8DeDdg1NW++vEyshaPGaYWOKD6w/d8AunpGPuN6n4dRNBiWkUx24cS4UffiX4Et1qkRA=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=JzFn1DdpqAIgX9exE4IN6lU5puwoTwb7tv/UGHT/WFw=;\n fh=ifo8ct5CYa+Yz0DKbCP++JDsJFnUFyyZGythcxLZy8g=;\n b=P5VdgolgaYRRqxNw2QIG0oygQnwtbv/t0rNeW4wuGR4fom0pDMFkGdC3hyPBWEKyqY\n 9w2wUcNxSLhlvShRETjaTy9+yUzl0DOUskMZySJNCxufmqtxq/bk18WuAYls9FDOW59l\n Jh+L82V91HfBp+xBFcSJza1c1OlHQt0EbDFMcK3xxfbPPshlKzfrM+a13l+eci+EZa1O\n O2anx2cLqQCEldCesgl1jqUGehsN+HM12+jsY5yG+IGu29c1UBCx06eUCfp/sHvBbL/a\n 2yb3zFADK2jnnq/muEe4G68BWhwCTlOmQsX/Pm/Dwpa11AYRXDtud2b7N8VFOLvXFgGa\n HdRw==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=ElNK8775; arc=pass smtp.client-ip=209.85.219.50","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776562540; x=1777167340;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=JzFn1DdpqAIgX9exE4IN6lU5puwoTwb7tv/UGHT/WFw=;\n b=ElNK8775+vE1GayVmOhQPKdfukX/B2ghToMheh3GPFaYHe53yoge+X5bpKxmVTFf5i\n R/OFF2vQdjATjX+XWJbhE/CIECsftzmLLiHKeaIhoAF8YDV8U/uMF7T89P0dWe2eGMDm\n OXqaPPAXksjcuj6J2yBxAtFOHxvu1tgbttShWL5eiUDUsh9u4GoN5ioyO2Ckq5i56ZvJ\n XdetULMUVjmZNs8lXadfVNtV2Qjq4kAgqj2BTHEnyrU4F2iAYPrdyxOROpK6fp+6odig\n oxIf1uIc2sUhf/cji1rD0GgwnXQjokcqvgsFOKn6qw9Kl2FGs5dgCzeSOWwL9eK5PAhI\n oZzg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776562540; x=1777167340;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=JzFn1DdpqAIgX9exE4IN6lU5puwoTwb7tv/UGHT/WFw=;\n b=FK7ulHBcozIfhEl0oZkUmVn2k1gx7gWt42p1jkr4N9OdVBEHaa9xjqJIOBPz+ZP8Q+\n z5iTVrjiAPp6EISIdjfJPm0WwVmmdvjqas6l0bFJ/OsYkIRRcvvneDllhPivOOCpmpit\n q4NU3fA62o6WJreqHq+doGhk6phBBt9BpIzFVH4gXnklKT/jZzXJ2mstH4tEhpQ7bE12\n hESVvkYblGtWEmYeCCGBJP9tBbLmBgS3eCPEuG5ulOPhmsjda3XZRPem4VIJtxM498nz\n mASlBIQbRqbsqcyvFHmcJuFXGAK7QhCNPaIr15Ac2ZNP2OkBMpHcxfPmnRhNElSk1d1Y\n wB/w==","X-Gm-Message-State":"AOJu0YzQhUgTLRJYwp0V5/NvyGf3KWw/rUUZBI4JcU3YnlE/QHg9zOID\n\tT3XT6bcFH2nTwY626IlKdiJ6KDLFO7G0DsSqeBp9zNc4n+ViCgC2dIZrr5J8vDhLL/AodFRu1Mn\n\tnP0vyYDsz9VLxDPjuG1gjQJbTpeCygXU=","X-Gm-Gg":"AeBDieu20joXC8lhPD9cmPa3PDrEbF2j1FAgkL2W4O0o84gGyZ4I/BjPkyqxZw8sLfD\n\tONJUesN5TXqCnGEbYomAE5NcKSor3bRKWAP2xsMJVBNVzF9m7CmpE2C1qZqFMUQcWMlWZDOhNqH\n\tQa56C6QZy3bNMa9O5B4XkwvHOVekPSz0MVnwNDSL4i3oItSOtc/zxtYqmGoK9EcDxd5tgk1ozPl\n\tF9ghMXwamgswQltXvNxrqZkwUwkHqL60SRplk6Aj+A2shNSTOqpXFF0JmFHZ22fP4hI59ultFNq\n\tdzk8czMIds1MjbTOPTDmVyoGrLxK3brzs1PZ560chEtPaSdL86b8QHXGVb3UpkkGULssVn9CpWM\n\tgQ/ZdIOFxlodynUiAjCMCmDORhOElVOsxcsUXaigf/0rTaObJ//U7qC57aCo5+Dx5v7Nomq5o7Q\n\tgigFEpKnNSoTpO7TNmLf21qzqeM8h3g99Q","X-Received":"by 2002:a05:622a:5c1b:b0:509:211e:3624 with SMTP id\n d75a77b69052e-50e36823dd8mr150373111cf.4.1776562540198; Sat, 18 Apr 2026\n 18:35:40 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260413190713.283939-1-ematsumiya@suse.de>\n <20260413190713.283939-2-ematsumiya@suse.de>","In-Reply-To":"<20260413190713.283939-2-ematsumiya@suse.de>","From":"Steve French ","Date":"Sat, 18 Apr 2026 20:35:28 -0500","X-Gm-Features":"AQROBzCh3ngMuytDfslPqCPObOzGbcADmlfRZo-czjwEzV_sXYcHxWz2NCLWtAI","Message-ID":"\n ","Subject":"Re: [PATCH 2/8] smb: client: compress: fix bad encoding on last LZ77\n flag","To":"Enzo Matsumiya ","Cc":"linux-cifs@vger.kernel.org, pc@manguebit.com, ronniesahlberg@gmail.com,\n\tsprasad@microsoft.com, tom@talpey.com, bharathsm@microsoft.com,\n\thenrique.carvalho@suse.com","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]