[{"id":3676941,"web_url":"http://patchwork.ozlabs.org/comment/3676941/","msgid":"<86d2bfb2-6943-4030-822a-07637adfae9c@linaro.org>","list_archive_url":null,"date":"2026-04-13T22:12:29","subject":"Re: [PATCH 3/5] bsd-user: Conditionally use old system calls","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 13/4/26 17:31, Warner Losh wrote:\n> sbrk and sstk have been deprecated in FreeBSD for a while now, only\n> support them if the version of FreeBSD we're compiling on does. They've\n> returned not supported for a while anyway, so no net change.\n> \n> Signed-off-by: Warner Losh \n> ---\n> bsd-user/bsd-mem.h | 2 ++\n> bsd-user/freebsd/os-syscall.c | 4 ++++\n> bsd-user/freebsd/strace.list | 4 ++++\n> 3 files changed, 10 insertions(+)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=M47JjwnM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvhVd2vT5z1xtJ\n\tfor ; Tue, 14 Apr 2026 08:12:55 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCPWI-0002HB-1r; Mon, 13 Apr 2026 18:12:38 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wCPWE-0002Gs-Er\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 18:12:34 -0400","from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wCPWC-0000aQ-Mj\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 18:12:34 -0400","by mail-wr1-x42f.google.com with SMTP id\n ffacd0b85a97d-43d04fc3bf2so2976421f8f.3\n for ; Mon, 13 Apr 2026 15:12:32 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d63e5062fsm34937030f8f.31.2026.04.13.15.12.29\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 13 Apr 2026 15:12:30 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776118351; x=1776723151; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=2zcHNNSKvC8rWAGslRgprodHcm0VUiUbvnzD4QAf5lM=;\n b=M47JjwnMoKWwIRQ2QUmcwsat3B1n/LfflBhQFjzDXDHgk+jNyaumFAOfKy4hua81cN\n RxjVlnn6G++J3R6Lu82S9nBm3auD/gv5AjkNSODb2sLBlMCexfiIeH4cTheiDd1ROG/x\n zCWKVHun1yAqR+B56p2FP6D5ZNK1/HY/3r38akKqd5uF1YbexLU+CG6QtuyaQJuIJ6dd\n N+//iLAQjn+oRMjUcoasZUMNn9bkcbNK6pGOeXbjNLm1YVPgM/D+UWTOKxTJAaPx6/KI\n vRUrsmju5HUCOAuBGZ1/XlxFM+VfdO64Hz+eNb3fBLaGShOxxXN5Teu7ET6SfPPPoDuO\n DrGg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776118351; x=1776723151;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=2zcHNNSKvC8rWAGslRgprodHcm0VUiUbvnzD4QAf5lM=;\n b=V62y6ElkbXrj1n0Ev9GWmoW0f+6wtwxeS6f+byuCTTyiezTWUgYHwRkxN6aE7CuZ2M\n SG4//m4VQBTStg1af9DXXtmUo2T0VIp2JE8g9iMSx/afbSj/Q/638BvywT8NZR4+gQwR\n 63w3eNF/iFfK1eP3LRxKEfXdFtE5pjg8mGiPUwWdTeL6XDPtTj3dBovIjJcS/2cahlJ0\n kT3q0HLpAMt57yf7lhAdpv+RiJAwaswPwLYVWZaoaQAgTc0cIyIbL7cMdsPGjbxADCYq\n udLucGSsBoL/z0/fGlv1nauC9P6mvyVWrN8DNQ+m2Isf6Byno2yusA2O/O82tCMOZSSS\n Yonw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/MzjCZHJq7kQxQbb7JRke9AloC2t7/Mvwn0KwUvZ+QQj5iaiDzQSDDvdLjxe6CryA/Ki7WJa/jwen9@nongnu.org","X-Gm-Message-State":"AOJu0Yx5N52tzHWiEyo0ajpOOjWW3+DG7tnBkvln+ileOV/7oR1PSLEE\n DHSKGHba6Vrp0Lv7Xfy6eCtgDF7jzA5dApT/pH0Kkj+4M13Heq6SYWciCUCZxAAylp4=","X-Gm-Gg":"AeBDies+s9n58CFmSRvqk0RqOztK+D8DaQaH3rPAC3ih9qnvsMjaAfeVwvxVoS8Hgvo\n 2fhgEYxASJyPZJrrpLYxe9ySQD/yyY/kEQBt4edjYuJjaN83o0e3NAqBnDmlFWWdd2JYBAMIVjY\n MiAAkAbFaaGc88lSlXuASVoKgAQcb5shGOxPQQ+nzIsE8nmSg75xetwqbKjM7wfkNPFYbCK9o+2\n cANRB+MByTH/pXZkGA8md0i2m+1oaMtY+mS9AP7DmP8HPpylZ5rFKQbVvjKVXD9QjNNnLZqFsa0\n ePUNPKkhCGWCM0lOPYiNjHIbFQXoC450Lr03MaaXAIG+LMJn+ySJkjMr2+WK/91BEZwY/gxUmH7\n J6MKPSF2DSwERKWh2ycpPWn0hXL+45P2aGyYt+Q95GB2QWm/lPeSDR0/CzeLTU09XE7xHYrDyBC\n FxJeGlDf0V5lBXgbxTMYkPeB6IRiCgyqjx1O8TYXxd5jHIPx82/hrptl1j24GgEEsvxsRmkD2VS\n Sk+","X-Received":"by 2002:a05:6000:144e:b0:43d:c95b:c46f with SMTP id\n ffacd0b85a97d-43dc95bc595mr1669561f8f.38.1776118350912;\n Mon, 13 Apr 2026 15:12:30 -0700 (PDT)","Message-ID":"<86d2bfb2-6943-4030-822a-07637adfae9c@linaro.org>","Date":"Tue, 14 Apr 2026 00:12:29 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 3/5] bsd-user: Conditionally use old system calls","Content-Language":"en-US","To":"Warner Losh , qemu-devel@nongnu.org","Cc":"Kyle Evans , Paolo Bonzini ,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","References":"<20260413-syscall-nr-v1-0-f70408d042ea@bsdimp.com>\n <20260413-syscall-nr-v1-3-f70408d042ea@bsdimp.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260413-syscall-nr-v1-3-f70408d042ea@bsdimp.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::42f;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3677060,"web_url":"http://patchwork.ozlabs.org/comment/3677060/","msgid":"","list_archive_url":null,"date":"2026-04-14T08:13:37","subject":"Re: [PATCH 3/5] bsd-user: Conditionally use old system calls","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Mon, Apr 13, 2026 at 09:31:45AM -0600, Warner Losh wrote:\n> sbrk and sstk have been deprecated in FreeBSD for a while now, only\n> support them if the version of FreeBSD we're compiling on does. They've\n> returned not supported for a while anyway, so no net change.\n\nWhat versions of FreeBSD still have these syscalls ?\n\nPer out policy we only aim to support the 2 most recent major\nversions of distros:\n\n https://www.qemu.org/docs/master/about/build-platforms.html\n\nSo for FreeBSD that means 14.x and 15.x series are all that you\nneed to retain code support for. Any code for older versions\ncan be entirely dropped at any convenient time.\n\n> \n> Signed-off-by: Warner Losh \n> ---\n> bsd-user/bsd-mem.h | 2 ++\n> bsd-user/freebsd/os-syscall.c | 4 ++++\n> bsd-user/freebsd/strace.list | 4 ++++\n> 3 files changed, 10 insertions(+)\n> \n> diff --git a/bsd-user/bsd-mem.h b/bsd-user/bsd-mem.h\n> index a118e57260..a20b703053 100644\n> --- a/bsd-user/bsd-mem.h\n> +++ b/bsd-user/bsd-mem.h\n> @@ -440,6 +440,7 @@ static inline abi_long do_bsd_vadvise(void)\n> return -TARGET_EINVAL;\n> }\n> \n> +#ifdef TARGET_FREEBSD_NR_sbrk\n> static inline abi_long do_bsd_sbrk(void)\n> {\n> /* see sys_sbrk() in vm_mmap.c */\n> @@ -451,5 +452,6 @@ static inline abi_long do_bsd_sstk(void)\n> /* see sys_sstk() in vm_mmap.c */\n> return -TARGET_EOPNOTSUPP;\n> }\n> +#endif\n> \n> #endif /* BSD_USER_BSD_MEM_H */\n> diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c\n> index 85e5db19a3..ff6cbfc481 100644\n> --- a/bsd-user/freebsd/os-syscall.c\n> +++ b/bsd-user/freebsd/os-syscall.c\n> @@ -918,13 +918,17 @@ static abi_long freebsd_syscall(void *cpu_env, int num, abi_long arg1,\n> ret = do_bsd_vadvise();\n> break;\n> \n> +#ifdef TARGET_FREEBSD_NR_sbrk\n> case TARGET_FREEBSD_NR_sbrk:\n> ret = do_bsd_sbrk();\n> break;\n> +#endif\n> \n> +#ifdef TARGET_FREEBSD_NR_sstk\n> case TARGET_FREEBSD_NR_sstk:\n> ret = do_bsd_sstk();\n> break;\n> +#endif\n> \n> /*\n> * Misc\n> diff --git a/bsd-user/freebsd/strace.list b/bsd-user/freebsd/strace.list\n> index 275d2dbe27..d7f61f480e 100644\n> --- a/bsd-user/freebsd/strace.list\n> +++ b/bsd-user/freebsd/strace.list\n> @@ -194,7 +194,9 @@\n> { TARGET_FREEBSD_NR_rfork, \"rfork\", NULL, NULL, NULL },\n> { TARGET_FREEBSD_NR_rmdir, \"rmdir\", NULL, NULL, NULL },\n> { TARGET_FREEBSD_NR_rtprio_thread, \"rtprio_thread\", \"%s(%d, %d, %p)\", NULL, NULL },\n> +#ifdef TARGET_FREEBSD_NR_sbrk\n> { TARGET_FREEBSD_NR_sbrk, \"sbrk\", NULL, NULL, NULL },\n> +#endif\n> { TARGET_FREEBSD_NR_sched_get_priority_max, \"sched_get_priority_max\", NULL, NULL, NULL },\n> { TARGET_FREEBSD_NR_sched_get_priority_min, \"sched_get_priority_min\", NULL, NULL, NULL },\n> { TARGET_FREEBSD_NR_sched_yield, \"sched_yield\", NULL, NULL, NULL },\n> @@ -234,7 +236,9 @@\n> { TARGET_FREEBSD_NR_sigsuspend, \"sigsuspend\", NULL, NULL, NULL },\n> { TARGET_FREEBSD_NR_socket, \"socket\", \"%s(%d,%d,%d)\", NULL, NULL },\n> { TARGET_FREEBSD_NR_socketpair, \"socketpair\", NULL, NULL, NULL },\n> +#ifdef TARGET_FREEBSD_NR_sstk\n> { TARGET_FREEBSD_NR_sstk, \"sstk\", NULL, NULL, NULL },\n> +#endif\n> { TARGET_FREEBSD_NR_freebsd11_stat, \"freebsd11_stat\", \"%s(\\\"%s\\\",%p)\", NULL, NULL },\n> { TARGET_FREEBSD_NR_freebsd11_statfs, \"freebsd11_statfs\", \"%s(\\\"%s\\\",%p)\", NULL, NULL },\n> { TARGET_FREEBSD_NR_symlink, \"symlink\", \"%s(\\\"%s\\\",\\\"%s\\\")\", NULL, NULL },\n> \n> -- \n> 2.52.0\n> \n\nWith regards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=XGtbqbbF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvxvM6DS5z1yDF\n\tfor ; Tue, 14 Apr 2026 18:16:46 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCYuu-00045t-CU; Tue, 14 Apr 2026 04:14:40 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCYu7-0003mJ-PY\n for qemu-devel@nongnu.org; Tue, 14 Apr 2026 04:13:51 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCYu5-0008Fw-3H\n for qemu-devel@nongnu.org; Tue, 14 Apr 2026 04:13:51 -0400","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-465-nJEKJD2SP1qdsBWRt499Bw-1; Tue,\n 14 Apr 2026 04:13:43 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 1CFC71956080; Tue, 14 Apr 2026 08:13:42 +0000 (UTC)","from redhat.com (headnet01.pony-001.prod.iad2.dc.redhat.com\n [10.2.32.101])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 2F641195608E; Tue, 14 Apr 2026 08:13:39 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776154426;\n h=from:from:reply-to:reply-to:subject:subject:date:date:\n message-id:message-id:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type:in-reply-to:in-reply-to: references:references;\n bh=CnPCsOuEwZhwJzSLwvDfGSm8D4tXLMEr74zD7KNkV7o=;\n b=XGtbqbbF9sgCYXg7ZRuCbp4FlaA/Wu/fnFF7T6fcc8XesoxFALO19kDJyUdmkFKU5pTU4q\n JnAJCvs5yvqBfQbXYnNPz5qD1P3Mi9yXRBTzCWLqcI/t04DIOs6DHZYUDVDnLxB9hbDoxy\n t0DHBP+wXQDFUY8O/NINOqxcjDUaryM=","X-MC-Unique":"nJEKJD2SP1qdsBWRt499Bw-1","X-Mimecast-MFC-AGG-ID":"nJEKJD2SP1qdsBWRt499Bw_1776154422","Date":"Tue, 14 Apr 2026 09:13:37 +0100","From":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","To":"Warner Losh ","Cc":"qemu-devel@nongnu.org, Kyle Evans ,\n Paolo Bonzini ,\n =?utf-8?q?Marc-Andr=C3=A9?= Lureau , Philippe\n\t=?utf-8?q?Mathieu-Daud=C3=A9?= ","Subject":"Re: [PATCH 3/5] bsd-user: Conditionally use old system calls","Message-ID":"","References":"<20260413-syscall-nr-v1-0-f70408d042ea@bsdimp.com>\n <20260413-syscall-nr-v1-3-f70408d042ea@bsdimp.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260413-syscall-nr-v1-3-f70408d042ea@bsdimp.com>","User-Agent":"Mutt/2.2.14 (2025-02-20)","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"7","X-Spam_score":"0.7","X-Spam_bar":"/","X-Spam_report":"(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3677217,"web_url":"http://patchwork.ozlabs.org/comment/3677217/","msgid":"","list_archive_url":null,"date":"2026-04-14T13:56:55","subject":"Re: [PATCH 3/5] bsd-user: Conditionally use old system calls","submitter":{"id":1896,"url":"http://patchwork.ozlabs.org/api/people/1896/","name":"Warner Losh","email":"imp@bsdimp.com"},"content":"On Tue, Apr 14, 2026 at 2:13 AM Daniel P. Berrangé \nwrote:\n\n> On Mon, Apr 13, 2026 at 09:31:45AM -0600, Warner Losh wrote:\n> > sbrk and sstk have been deprecated in FreeBSD for a while now, only\n> > support them if the version of FreeBSD we're compiling on does. They've\n> > returned not supported for a while anyway, so no net change.\n>\n> What versions of FreeBSD still have these syscalls ?\n>\n\nNone. They were marked OBSOL in 4.4BSD. I don't even know why\nthere was code to implement them in the first place.\n\nIn fact, digging deeper, 4.3-Reno returns not supported. 4.3-Tahoe had\nthem stubbed out as blank (no error, but did nothing), like 4.3BSD and\n4.2BSD did before it. It wasn't in 4.1BSD.\n\n\n> Per out policy we only aim to support the 2 most recent major\n> versions of distros:\n>\n> https://www.qemu.org/docs/master/about/build-platforms.html\n>\n> So for FreeBSD that means 14.x and 15.x series are all that you\n> need to retain code support for. Any code for older versions\n> can be entirely dropped at any convenient time.\n>\n\nTrue. I'll do that since it is clearly an echo of the past of what might\nhave been, that never, ever was. I just #ifdef'd them because I wasn't\nsure, but now I am...\n\nWarner\n\n\n> >\n> > Signed-off-by: Warner Losh \n> > ---\n> > bsd-user/bsd-mem.h | 2 ++\n> > bsd-user/freebsd/os-syscall.c | 4 ++++\n> > bsd-user/freebsd/strace.list | 4 ++++\n> > 3 files changed, 10 insertions(+)\n> >\n> > diff --git a/bsd-user/bsd-mem.h b/bsd-user/bsd-mem.h\n> > index a118e57260..a20b703053 100644\n> > --- a/bsd-user/bsd-mem.h\n> > +++ b/bsd-user/bsd-mem.h\n> > @@ -440,6 +440,7 @@ static inline abi_long do_bsd_vadvise(void)\n> > return -TARGET_EINVAL;\n> > }\n> >\n> > +#ifdef TARGET_FREEBSD_NR_sbrk\n> > static inline abi_long do_bsd_sbrk(void)\n> > {\n> > /* see sys_sbrk() in vm_mmap.c */\n> > @@ -451,5 +452,6 @@ static inline abi_long do_bsd_sstk(void)\n> > /* see sys_sstk() in vm_mmap.c */\n> > return -TARGET_EOPNOTSUPP;\n> > }\n> > +#endif\n> >\n> > #endif /* BSD_USER_BSD_MEM_H */\n> > diff --git a/bsd-user/freebsd/os-syscall.c\n> b/bsd-user/freebsd/os-syscall.c\n> > index 85e5db19a3..ff6cbfc481 100644\n> > --- a/bsd-user/freebsd/os-syscall.c\n> > +++ b/bsd-user/freebsd/os-syscall.c\n> > @@ -918,13 +918,17 @@ static abi_long freebsd_syscall(void *cpu_env, int\n> num, abi_long arg1,\n> > ret = do_bsd_vadvise();\n> > break;\n> >\n> > +#ifdef TARGET_FREEBSD_NR_sbrk\n> > case TARGET_FREEBSD_NR_sbrk:\n> > ret = do_bsd_sbrk();\n> > break;\n> > +#endif\n> >\n> > +#ifdef TARGET_FREEBSD_NR_sstk\n> > case TARGET_FREEBSD_NR_sstk:\n> > ret = do_bsd_sstk();\n> > break;\n> > +#endif\n> >\n> > /*\n> > * Misc\n> > diff --git a/bsd-user/freebsd/strace.list b/bsd-user/freebsd/strace.list\n> > index 275d2dbe27..d7f61f480e 100644\n> > --- a/bsd-user/freebsd/strace.list\n> > +++ b/bsd-user/freebsd/strace.list\n> > @@ -194,7 +194,9 @@\n> > { TARGET_FREEBSD_NR_rfork, \"rfork\", NULL, NULL, NULL },\n> > { TARGET_FREEBSD_NR_rmdir, \"rmdir\", NULL, NULL, NULL },\n> > { TARGET_FREEBSD_NR_rtprio_thread, \"rtprio_thread\", \"%s(%d, %d, %p)\",\n> NULL, NULL },\n> > +#ifdef TARGET_FREEBSD_NR_sbrk\n> > { TARGET_FREEBSD_NR_sbrk, \"sbrk\", NULL, NULL, NULL },\n> > +#endif\n> > { TARGET_FREEBSD_NR_sched_get_priority_max, \"sched_get_priority_max\",\n> NULL, NULL, NULL },\n> > { TARGET_FREEBSD_NR_sched_get_priority_min, \"sched_get_priority_min\",\n> NULL, NULL, NULL },\n> > { TARGET_FREEBSD_NR_sched_yield, \"sched_yield\", NULL, NULL, NULL },\n> > @@ -234,7 +236,9 @@\n> > { TARGET_FREEBSD_NR_sigsuspend, \"sigsuspend\", NULL, NULL, NULL },\n> > { TARGET_FREEBSD_NR_socket, \"socket\", \"%s(%d,%d,%d)\", NULL, NULL },\n> > { TARGET_FREEBSD_NR_socketpair, \"socketpair\", NULL, NULL, NULL },\n> > +#ifdef TARGET_FREEBSD_NR_sstk\n> > { TARGET_FREEBSD_NR_sstk, \"sstk\", NULL, NULL, NULL },\n> > +#endif\n> > { TARGET_FREEBSD_NR_freebsd11_stat, \"freebsd11_stat\", \"%s(\\\"%s\\\",%p)\",\n> NULL, NULL },\n> > { TARGET_FREEBSD_NR_freebsd11_statfs, \"freebsd11_statfs\",\n> \"%s(\\\"%s\\\",%p)\", NULL, NULL },\n> > { TARGET_FREEBSD_NR_symlink, \"symlink\", \"%s(\\\"%s\\\",\\\"%s\\\")\", NULL, NULL\n> },\n> >\n> > --\n> > 2.52.0\n> >\n>\n> With regards,\n> Daniel\n> --\n> |: https://berrange.com ~~ https://hachyderm.io/@berrange :|\n> |: https://libvirt.org ~~ https://entangle-photo.org :|\n> |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bsdimp-com.20251104.gappssmtp.com\n header.i=@bsdimp-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=b4ID5/fU;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw5Sf5nkRz1xtJ\n\tfor ; Tue, 14 Apr 2026 23:57:38 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCeGS-0004B1-2S; Tue, 14 Apr 2026 09:57:16 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wCeGP-0004AN-Lc\n for qemu-devel@nongnu.org; Tue, 14 Apr 2026 09:57:13 -0400","from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wCeGL-0001vW-RG\n for qemu-devel@nongnu.org; Tue, 14 Apr 2026 09:57:13 -0400","by mail-pj1-x1031.google.com with SMTP id\n 98e67ed59e1d1-358ed696623so2461242a91.0\n for ; Tue, 14 Apr 2026 06:57:09 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1776175028; cv=none;\n d=google.com; s=arc-20240605;\n b=QLogO74Mg1XkSCRMhMXGom3K3w+5SbfwzlbM/p4OP9DHDuHBIoqaes8XPGSAnos/3R\n vtOr1nOG7pHZqx4xlMxXqdhvweuBVCdhN8YTQjtTvLywjXKrtO3VGriogj0ke/FUmRSi\n mGLiHO58+MIHwOoxFEc6u2isfy46Go7yDYMGp2cPZoA7SzDCHf4QQmIegcR+eAKHKECw\n T3D2HsCzKtiTM8Mux/YSA+3V/dMVK2JHiMUUGT+eaU9ZSX7CX7zv0C89j9yJ/Bo1psgV\n rO/DtDnwFw8BYP2sphviqAWjaNPrRUxKSYN7qEijXAipdro9v6/uLCku1Yv5EdpkSlhQ\n m+TQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=RtBZyzbBkln5G4M6t9DIJpY3Su3ba/JxieaX6d73v9M=;\n fh=zLnaIXgodYFBfAy2HucWE6FDGaJ6z3LdlBRHxnJ8p2k=;\n b=gDlzYB7HkoSX3CV4lhd88cinTCLj1ITKvBRmFvyu9nHP87NqYtK8hx+eLbsM1Fvr6f\n +8PEv7WxGz1FOyJrfB+EuPuGQGRH0pUohZQlesaKD81x1oXymMmYMLcFv6FVllHN1Vu2\n +WiZZV7jzcJBz0kcTOmcqmSWYGmWYLsIv5Ra/Ktae5I1vy9Nv33lZtWAC5KYWKoldH71\n 7FaI7JOilf+MXQzwS9OeYYw3DO2lBdce/80M/JqHbq7HJ9HFW0yZZc6QD4KM5XYVVptP\n zXqxz7WLXtb20cSm/stMtKmwomQ5LnqlSf6qMeXrak2H0U+6t7t6o1X+qByHqFroYmCS\n x1SQ==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=bsdimp-com.20251104.gappssmtp.com; s=20251104; t=1776175028; x=1776779828;\n darn=nongnu.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=RtBZyzbBkln5G4M6t9DIJpY3Su3ba/JxieaX6d73v9M=;\n b=b4ID5/fU4dW8cGwGkaKWHwZblt+vnbBXer+L7IDCEx2H5CtR/Gyp/KPGs79E6kBCFl\n hFQtkrTOSUWvKK2zt/cGErJakGHLY4LY+b74EoNTpbpTNzk6K1MYKEr+v1opbo/w7lPB\n 3sTOvwhEYY0cUcVNZyM83zAueVSxvLKi3ZW4L6IIrhSYJETGZ1mm8xKxgxpXpsQkxgYo\n ClGYrvIVc3uznLfxlLY6K/s487d0UMJmBmvsdBFlxRYWCJx+HgTHZvVbrBCkSEDvcq4y\n PvXZcwzbRISuYGTPUZkgxdPRZUin5GAypTVGg7WEkjCk3ss1mI8HXAt84puRh/ht3V64\n 4Ibg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776175028; x=1776779828;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=RtBZyzbBkln5G4M6t9DIJpY3Su3ba/JxieaX6d73v9M=;\n b=AGZl5Y8KKzuORVcH2SjRifbZ0ryREIdc/NllWJpK63mXFt50YkrYqdGHmsv0t22S+Z\n C49Xpl/JpQaPBIjKr52YOztktNx3GndWj7qHOzTnePI4udCyx01kWHMddD4WknlgU3a/\n xZtiGqq2HHuyLxCPJGKRS8zWPRylDxx0MnG14dFo+rat3QLvkQT1ADw2hf7rQGDglHrx\n p62osw0hgl6OAghyReJv8l+ZJPldeV4wNkbtONaJob+exOJKEUh72uG0M8oRAXzinst2\n xGsmKqkknxBwf5tqitjxnBNyExRFr1kYI4tzme56apKj7py2yiNR9eV7KUXKgA5Olxmu\n ghvA==","X-Gm-Message-State":"AOJu0Ywn4E8T04zNHTJbz2YoQN0mPyMNFr4uj2OpC8Y78qqF1c8LDWJc\n zN6vtLfjGcJoQlAUEpz0PJ1HD90oS3vmpRHko3k1/5zdUmE+cT7yMVuoIuMK0467w9N65Ko3zn3\n g6sWPbQ92ORacMySUIysj2DS7FQtHAKWwckSTrSBgWA==","X-Gm-Gg":"AeBDieutcWb8U2DaBeD9j5u42znTyyXSn0j3MjWThcA9je+w4qCKlec0Kst9uoC+Sm4\n CdPxf3tRB8OJF+1goudWu5KPESjZKzimjksJjEoC58RX80ntDeWKXuoqiOi9h5skLLAXllKvthG\n KP5JCjFJCaj4gJRbaackBGysmHMBpGzoZKtpRv5jq2JdAza/UxUCoqJB4RXEDy148LUBD/ICfFu\n ZtRLgUK+b2I9hWBWWPvqA/1X8GGjvDld2JZZQJh5JS2q4DleE3F3YL9tO2mE4jBy9yptzkMpYLT\n +/+Da92pLVsggvphzpotharWgTeDaoH5u8/iNA==","X-Received":"by 2002:a17:90a:c883:b0:35e:5ae3:298a with SMTP id\n 98e67ed59e1d1-35e5ae32a85mr10066239a91.18.1776175027797; Tue, 14 Apr 2026\n 06:57:07 -0700 (PDT)","MIME-Version":"1.0","References":"<20260413-syscall-nr-v1-0-f70408d042ea@bsdimp.com>\n <20260413-syscall-nr-v1-3-f70408d042ea@bsdimp.com>\n ","In-Reply-To":"","From":"Warner Losh ","Date":"Tue, 14 Apr 2026 07:56:55 -0600","X-Gm-Features":"AQROBzABPqdnCgGqPknplscbAj8RwI0GWImXJyLoNT5zucX6nm5d2JCtukVwMl4","Message-ID":"\n ","Subject":"Re: [PATCH 3/5] bsd-user: Conditionally use old system calls","To":"=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","Cc":"qemu-devel@nongnu.org, Kyle Evans ,\n Paolo Bonzini ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Content-Type":"multipart/alternative; boundary=\"000000000000976998064f6bf95f\"","Received-SPF":"none client-ip=2607:f8b0:4864:20::1031;\n envelope-from=wlosh@bsdimp.com; helo=mail-pj1-x1031.google.com","X-Spam_score_int":"-18","X-Spam_score":"-1.9","X-Spam_bar":"-","X-Spam_report":"(-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001,\n SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]