[{"id":3678073,"web_url":"http://patchwork.ozlabs.org/comment/3678073/","msgid":"","list_archive_url":null,"date":"2026-04-16T10:14:12","subject":"Re: [PATCH v2] misc: microchip: pci1xxxx: fix IRQ vector leak in\n gp_aux_bus_probe()","submitter":{"id":91722,"url":"http://patchwork.ozlabs.org/api/people/91722/","name":"Guangshuo Li","email":"lgs201920130244@gmail.com"},"content":"Hi,\n\nOn Mon, 13 Apr 2026 at 22:40, Guangshuo Li wrote:\n>\n> gp_aux_bus_probe() allocates IRQ vectors with pci_alloc_irq_vectors()\n> before initializing and adding the second auxiliary device.\n>\n> When pci_irq_vector(), auxiliary_device_init() or auxiliary_device_add()\n> for the second auxiliary device fails, the function unwinds the auxiliary\n> devices and ida allocations, but leaves the allocated IRQ vectors behind.\n>\n> The issue was identified by a static analysis tool I developed and\n> confirmed by manual review. Add a dedicated error path to call\n> pci_free_irq_vectors() after IRQ vectors have been allocated\n> successfully.\n>\n> Fixes: 393fc2f5948f (\"misc: microchip: pci1xxxx: load auxiliary bus driver for the PIO function in the multi-function endpoint of pci1xxxx device.\")\n> Cc: stable@vger.kernel.org\n> Signed-off-by: Guangshuo Li \n> ---\n> v2:\n> - note that the issue was identified by my static analysis tool\n> - and confirmed by manual review\n>\n> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c | 7 +++++--\n> 1 file changed, 5 insertions(+), 2 deletions(-)\n>\n> diff --git a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c\n> index 34c9be437432..5e1f99a35100 100644\n> --- a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c\n> +++ b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c\n> @@ -93,14 +93,14 @@ static int gp_aux_bus_probe(struct pci_dev *pdev, const struct pci_device_id *id\n>\n> retval = pci_irq_vector(pdev, 0);\n> if (retval < 0)\n> - goto err_aux_dev_init_1;\n> + goto err_irq_vectors;\n>\n> pdev->irq = retval;\n> aux_bus->aux_device_wrapper[1]->gp_aux_data.irq_num = pdev->irq;\n>\n> retval = auxiliary_device_init(&aux_bus->aux_device_wrapper[1]->aux_dev);\n> if (retval < 0)\n> - goto err_aux_dev_init_1;\n> + goto err_irq_vectors;\n>\n> retval = auxiliary_device_add(&aux_bus->aux_device_wrapper[1]->aux_dev);\n> if (retval)\n> @@ -113,6 +113,9 @@ static int gp_aux_bus_probe(struct pci_dev *pdev, const struct pci_device_id *id\n>\n> err_aux_dev_add_1:\n> auxiliary_device_uninit(&aux_bus->aux_device_wrapper[1]->aux_dev);\n> +\n> +err_irq_vectors:\n> + pci_free_irq_vectors(pdev);\n> goto err_aux_dev_add_0;\n>\n> err_aux_dev_init_1:\n> --\n> 2.43.0\n>\n\nI re-checked this issue on our side and found that my previous\nanalysis was incorrect. This patch is therefore not needed.\n\nI'll drop this patch.\n\nSorry for the noise, and thanks.\n\nGuangshuo","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=GQ8fs2p/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35192-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"GQ8fs2p/\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=74.125.224.41","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxDRc1jPkz1yDF\n\tfor ; Thu, 16 Apr 2026 20:15:40 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id E8B12307BB26\n\tfor ; Thu, 16 Apr 2026 10:14:28 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B59E639E178;\n\tThu, 16 Apr 2026 10:14:28 +0000 (UTC)","from mail-yx1-f41.google.com (mail-yx1-f41.google.com\n [74.125.224.41])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F61939C007\n\tfor ; Thu, 16 Apr 2026 10:14:27 +0000 (UTC)","by mail-yx1-f41.google.com with SMTP id\n 956f58d0204a3-6530287803cso235350d50.1\n for ;\n Thu, 16 Apr 2026 03:14:27 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776334468; cv=pass;\n b=ur3zSZ9LHXQ8z+UqiINUG9rtmZ6+MPVdDxsn0aYv+ETBaeYJ5Jkp7sPKRWP8V5XcZd+RtUNLE/4jUBXibkmkpgPdU5SPfgoVfXseHfoFSoueUsAbjH70+rRbCP5OexI3bBtJvWugGF1yh4ZsUsotN0yyZAtlI4VyFAR5KH8q0rw=","i=1; a=rsa-sha256; t=1776334466; cv=none;\n d=google.com; s=arc-20240605;\n b=jIsl8xvZ+HJIeEokA2tD332ZBWpWsImJumyAfb8pg5iTwGg/m0IhrM7j1zzgFkHP/j\n sr42kkgIcBRifYU8cr1Hqm1M+t6UPOX1Xqqlu6zYueV2I1lSpC02I52acaXhKYB7w4OR\n Qvdco91BYCY9cOQyFdXvE8rWemixjo7nL99fh0xeq+i4SjIWN/V4Xrp1k2ZaRwvpOpkV\n yOfPjXV0TMh2aKItEjXMNSPw4HbXqs9UF8Jz9dCwupcg7XMnJJX0emkfsBiBbdt0tfYZ\n K67M97KLZewRJ2TBtOrp9Nj2s6OUSKfpH6E9LAiG6U3H6a8z9b0n9/HWQKwBewHNyexU\n YRDQ=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776334468; c=relaxed/simple;\n\tbh=omyk2QDaBscrlxBpLHNewuJklMUvM2h9mNwfbrOeZEU=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Content-Type;\n b=OpYhsDUj5gnNno8fvBVLtRZ7YQCd988e3vJD+0mErbWQQQ4Ol8lm1At/4n6O3qOVIXsJHcFyHw1tmkw/92bbJQoz9snWsQvuc/bGNs6J7LmzXul/bSMc/3w/g/SgFqyOZblaJS3UmA4sz67TR+G03HUyRk1uA3VEng4/Kym7p2U=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=to:subject:message-id:date:from:in-reply-to:references:mime-version\n :dkim-signature;\n bh=n1rjmbekfBau2Htq8B+TCJW49W+rgbnu1bxSBFHQQuc=;\n fh=zmgO3K6pj0BROhxpN/4noSAx+fNZHKVydltAqygeFiQ=;\n b=EXWuINUj+nuZKZEIm8KbeceF2OCs3YAz8AKyiKpmH7nefZhvyYJkFwajF6UaH5yn+c\n rFep6sXoBxTlx8hTP+K4/iF4qli0FYln5UhE7vgXQ8UQWA4E+FEBuyEKOk+drSkMBCCk\n Yc23hK1ah+1WEW5EyDkguPc9jO4B7OLVsTqbsUStzCJVvAyYASVPpK/MX1VR/4ZnHjwI\n JKWKhfShvQwayiLqocKf3sFLOaGkRkfODaHW6cxgQSVdbAoiycepa44ufrRsrAKYqR48\n IRn9BW65bZnMAN0gj47+alF67c0I4SNF1bHN/1Wgv9dPc8L4X6bNwIDjw/OveJs7xVd/\n 9UnQ==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=GQ8fs2p/; arc=pass smtp.client-ip=74.125.224.41","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776334466; x=1776939266;\n darn=vger.kernel.org;\n h=to:subject:message-id:date:from:in-reply-to:references:mime-version\n :from:to:cc:subject:date:message-id:reply-to;\n bh=n1rjmbekfBau2Htq8B+TCJW49W+rgbnu1bxSBFHQQuc=;\n b=GQ8fs2p/h4bjE2J+uZXFtxG//+/i2ippk/rSm6kua/Rj8Jde4V2zEBgT+RVGDfzuVY\n 3q3KSgks6TidJhCOwt7FSC5ce5DXY1jhU491Saq6Le3LmmFKy077uxCLWSP2W69SGmp4\n gM6RFX0D4DbjjW26fVTojHtUD/EQ9aL37ZXf/yM+XnLcjMSBACYLnBbgwDm7TUXOdo0p\n rJUABHH3P4Hid7WxW15K3cqbVW+E3kTDG1t4zx75hobepXLzGu7ubSDHuXJMf8+UtMTw\n aGx9f5wPFG7NpI+9NQh+OkkekDcnXydm8hZT48/QeibGTZ+P3FPdoLN2UNIU8G0uR1il\n MAnw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776334466; x=1776939266;\n h=to:subject:message-id:date:from:in-reply-to:references:mime-version\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=n1rjmbekfBau2Htq8B+TCJW49W+rgbnu1bxSBFHQQuc=;\n b=Fp3kbeoAyRUgpSkeZi/6FDoXZhLxoM3kmXNt4m/QmUUv6wPjs0bEzlH3ffjCIuthRM\n 5uyJaifKYdIOLVGfvjyTYTWWk+C0MiGvynh+y7auOwF2asvKhYKaxBe02dqr58CrWYt9\n oM0wLHvCciNGTE4a3SDeUdzpq4mwvHeuhNPv15R6TMZURun8dZBF2sQ3FnYJqPi3qZIp\n mMJ27I1E8lmAcNVKB7rXF7OdzyWk1duU2dVNpJ4DKjNLpEsYuyXrPyzKKV3/SZj0tHbn\n ZcefODlNOFn+7h9eF9E5MCfY3BHxgmwWCI96tWIGb5Qa486omuI6VHWrEhvAKA3c22IF\n q9sA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/OtJrG4umVVOOKhb9ayNa1fhR09Nz1Xxj2w2M2PgAg5X5clploPR1EmM7mgDTP2imMV/xIi6M3r5jI@vger.kernel.org","X-Gm-Message-State":"AOJu0YxMsIOEWWSn9KgiAElVAD+yqYrn/GoRLbco+PPiwQrc5lGjlmYr\n\t9L8P1kEQ7sSLOp8ylqeP860TCx1VOTkEOFbQA5npd7ucXbuPzt4Bx89AFyAK6fZQegGv2IzbBuG\n\tz/RafoR7esecsEFbjHoM1L7NStPsJRHs=","X-Gm-Gg":"AeBDiev+EI+7EudQAOpHVGb+a4ohrvKDFWs2TQRg5b3xelc2f0qDHnXuQHsFYgru0Xb\n\tNV69MwTH38empWvJjJiwgsUxCA47OFnz6T69sIzu5KyE3iJ3Mj5BK5SiSu7qXY8CSMnJ+TL4VGN\n\tAzw3xb2W4eDwyfgjH0/dQZNcBgj12MqVP8l8Owh1JOecMkq0jp0umJjBsuFXuR3UuE5weQ6EtAl\n\thp8Nyw/JarW075sdemfpQ5KGCbpxSFLXh2e/n7pVY2JY3/t+JKzVA8BdXplSyqK0tYcLz0yoeCd\n\tuD0jKoDHvNHVV+PrDqi5","X-Received":"by 2002:a05:690e:1507:b0:64e:a1d0:1142 with SMTP id\n 956f58d0204a3-65198aed930mr19836431d50.30.1776334466309; Thu, 16 Apr 2026\n 03:14:26 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260413144012.3009310-1-lgs201920130244@gmail.com>","In-Reply-To":"<20260413144012.3009310-1-lgs201920130244@gmail.com>","From":"Guangshuo Li ","Date":"Thu, 16 Apr 2026 18:14:12 +0800","X-Gm-Features":"AQROBzCnBVXTwlIwINOlLEsUngN0_VDTNq_XueRkOnBrN1R_ctNxWasBKhCqXEg","Message-ID":"\n ","Subject":"Re: [PATCH v2] misc: microchip: pci1xxxx: fix IRQ vector leak in\n gp_aux_bus_probe()","To":"\"Vaibhaav Ram T.L\" ,\n\tKumaravel Thiagarajan ,\n Arnd Bergmann ,\n\tGreg Kroah-Hartman , linux-gpio@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\""}}]