[{"id":3679224,"web_url":"http://patchwork.ozlabs.org/comment/3679224/","msgid":"","list_archive_url":null,"date":"2026-04-20T05:51:44","subject":"\n Re: [PATCH v3] gpu: host1x: Fix device reference leak in\n host1x_device_parse_dt() error path","submitter":{"id":26499,"url":"http://patchwork.ozlabs.org/api/people/26499/","name":"Mikko Perttunen","email":"mperttunen@nvidia.com"},"content":"On Monday, April 13, 2026 11:15 PM Guangshuo Li wrote:\n> After device_initialize(), the embedded struct device in struct\n> host1x_device should be released through the device core with\n> put_device().\n> \n> In host1x_device_add(), if host1x_device_parse_dt() fails, the current\n> error path frees the object directly with kfree(device). That bypasses\n> the normal device lifetime handling and leaks the reference held on the\n> embedded struct device.\n> \n> The issue was identified by a static analysis tool I developed and\n> confirmed by manual review.\n> \n> Fix this by using put_device() in the host1x_device_parse_dt() failure\n> path.\n> \n> Fixes: f4c5cf88fbd50 (\"gpu: host1x: Provide a proper struct bus_type\")\n> Cc: stable@vger.kernel.org\n> Signed-off-by: Guangshuo Li \n> ---\n> v3:\n> - note that the issue was identified by my static analysis tool\n> - and confirmed by manual review\n> \n> v2:\n> - add Cc: stable@vger.kernel.org\n> \n> drivers/gpu/host1x/bus.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/drivers/gpu/host1x/bus.c b/drivers/gpu/host1x/bus.c\n> index 63fe037c3b65..e3ac85848aec 100644\n> --- a/drivers/gpu/host1x/bus.c\n> +++ b/drivers/gpu/host1x/bus.c\n> @@ -452,7 +452,7 @@ static int host1x_device_add(struct host1x *host1x,\n> \n> \terr = host1x_device_parse_dt(device, driver);\n> \tif (err < 0) {\n> -\t\tkfree(device);\n> +\t\tput_device(&device->dev);\n> \t\treturn err;\n> \t}\n> \n> -- \n> 2.43.0\n> \n> \n\nThanks!\n\nAcked-by: Mikko Perttunen ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=F7tQaBIF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13801-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"F7tQaBIF\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.43.28","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzZPX1pVDz1yCv\n\tfor ; Mon, 20 Apr 2026 15:52:00 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id D00F130054E6\n\tfor ; Mon, 20 Apr 2026 05:51:56 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 5C72135C190;\n\tMon, 20 Apr 2026 05:51:55 +0000 (UTC)","from SJ2PR03CU001.outbound.protection.outlook.com\n (mail-westusazon11012028.outbound.protection.outlook.com [52.101.43.28])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id EC7DC212D7C;\n\tMon, 20 Apr 2026 05:51:53 +0000 (UTC)","from SJ2PR12MB9161.namprd12.prod.outlook.com (2603:10b6:a03:566::20)\n by SA0PR12MB4400.namprd12.prod.outlook.com (2603:10b6:806:95::13) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.8; Mon, 20 Apr\n 2026 05:51:48 +0000","from SJ2PR12MB9161.namprd12.prod.outlook.com\n ([fe80::d9d1:8c49:a703:b017]) by SJ2PR12MB9161.namprd12.prod.outlook.com\n ([fe80::d9d1:8c49:a703:b017%4]) with mapi id 15.20.9846.014; Mon, 20 Apr 2026\n 05:51:48 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776664315; cv=fail;\n b=FSbP09Rz5va8nSXvywkPYrKiyoG+x1a5EjX1jhUpHV+nRw9R/8T8ZENXWln+Rs2uANPavqGFQRlCltgBUOqqIQ7l9FbeLSFaXBJpxtTybO5IPlvEm3P+iK2ZghBkmF5ZC5NVILQWSlox+fuXA2zuxIe6kX8043K0cSOTMn9Xr0A=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=q432No9jC1qR/wf5+Rb5LX8PS6art09Vks6C3gAgNb+VhKyPdRZxVuyUshUpSy+BYXaE69IjH8iCdVAUu757LGnJKh1jqKg9zuzm9a8YTJTDhQXT1N7zMpVPv3szgUgXBtolHCJ1f5QCdW6ry4+6EGmBOPUAAbWq585NHaR6K0jjxbz2MFt0mnWbx4yX+7v55X96Nub353PqvnolOwGwmF+gSDA+egIMcZeP8qAS9PoGLm6AV/+t6ddS2UDwTyeZAZ7YiLDXDmF0xXF0H0+QtO7IBcNgjYyb6isHpcEL9fK3DbAPKoTLXt6xLQCJmCt6JTSvic5loZQhZTvO3+OBag=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776664315; c=relaxed/simple;\n\tbh=7bxpEpxZap3SOL3i0lY81uBMrPBsY+aYu8Xl8PIcmW8=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t Content-Type:MIME-Version;\n b=Z7Zxo6RGlxVlxWXc+THs5K18qCVtDySbrGhx7lnbIysKIpOqvPvhC/eRLJv0ORuotvxCGoXOpKGIMBzG3jnD70/I1K/e171rNEoMFVVIWQAkDpVtQErvxcNHBZFPCXYa2Aw4MwZbO4393k7iVLNDmycYoQDWVId67NIHUnzugnA=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=1Y/ADa8KsblnM7f3Ps5D/ZJiejn2227RCdtIvJlgYUI=;\n b=MntYWhxFaSDMQJmWpY7v1f9cOMXEGVvAKi69txyv8iDdT+BiJ2nGcazHP6Jr+kT4qSjtJiBBknArqOHhN/waa4SL1DfY6pCvVnBv/EBllYVgo1cucCWLA1hTwvsBH5eJzdzWKwFrW5ovneIXp0gy7F59WsvGLhqsi6SPi41ix5JoPld6+CCFQnymVpMholxUhQB7WfSxjMB3HYTNqdMn0Tmd27bM8Qeg620W9oQQU2qPMuOxI5oh0yJrpEAP2WnRttsskmq6hQ0Dhsgpwcp0Dmx5Pj+Rez/1tu/YK44rJX+4OB7gVpui35LhQxJD1bplWlimoPi8AQeRgBR93wls0g=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=F7tQaBIF; arc=fail smtp.client-ip=52.101.43.28","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=1Y/ADa8KsblnM7f3Ps5D/ZJiejn2227RCdtIvJlgYUI=;\n b=F7tQaBIFU0T1NtiJS3Bvd6IGYTptOTdNSrSBEWniqDCkHYNaJ3N6+ErFHy7PBuDvbIukobYmWUe+os3S0d/65h+0+hAE0mRLv8jUkMoKwosOVFhq4CBK0vKvERbPZDY6++XUDSmU72khOiiWM9vT5KNFBXUrmybchdG5x5sXIFshkxPW78LUUcDC7gZ7oajQNqh9TBt++uJ5en2LRUVe86ojaLgO4JBvQHNioRA82a5miXlfJ2dhzHoo4JkzcnzjF0pY6/rMQL4KrRuNISC68o+H0B2a2M6ir/XH0kBfqK/CjxdGqlsLci9yalEfWKjZlFnGX+lN9kiQTMRssYXYUw==","From":"Mikko Perttunen ","To":"Thierry Reding ,\n David Airlie , Simona Vetter ,\n Mark Zhang , Sean Paul ,\n dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,\n linux-kernel@vger.kernel.org, Guangshuo Li ","Cc":"Guangshuo Li , stable@vger.kernel.org","Subject":"\n Re: [PATCH v3] gpu: host1x: Fix device reference leak in\n host1x_device_parse_dt() error path","Date":"Mon, 20 Apr 2026 14:51:44 +0900","Message-ID":"","In-Reply-To":"<20260413141526.2961841-1-lgs201920130244@gmail.com>","References":"<20260413141526.2961841-1-lgs201920130244@gmail.com>","Content-Transfer-Encoding":"quoted-printable","Content-Type":"text/plain; charset=\"utf-8\"","X-ClientProxiedBy":"TYCP301CA0039.JPNP301.PROD.OUTLOOK.COM\n (2603:1096:400:380::16) To LV3PR12MB9166.namprd12.prod.outlook.com\n (2603:10b6:408:19c::13)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"SJ2PR12MB9161:EE_|SA0PR12MB4400:EE_","X-MS-Office365-Filtering-Correlation-Id":"a3643925-8fc9-4aef-5b40-08de9ea0e8fd","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|10070799003|366016|376014|1800799024|56012099003|22082099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n\trWTFJMVKl7XSjocAOFb2KHhicLZot51TI3rjKANKLStx2oZTO+XG/ncpv1irFfzfpHefhemoYa8FRBwMB3Hve5AzQPN+2kEadxssf/+F2dYzjiH6O9YXt62PXNia+9kcZK7DtHPLrBbOxvWJ7+rdQFa8vRrtjTXv6X7N649+GabJpvhkTdZNh0BqrXuW66ErgHp5yRFFQ7y3dkLK57MWGK1dYZvki+4X8oaa40Vsi0XCHViRNrzgEfP+jfp2Y0g4hsL6vZRC6Oysiul6YfoxfUQtkAh1BqMTgQzQ9hnUVeHOGJxIJYTMNULW85WQSkoK1Wlw+HR3cU3eeZ9BY6ujNraMqQDARgO7O2pKNE8HJe7Mt8l8ksqEi6CwbQtJI4+rIlCDW9pBbVdAoNlAwylJv4yuUjHmbsuEXYqk6TxVXMIeCfJ+1TT20KpidFTaq8VNJWBwU4RyMkJtawYSMHMF1wmvQsU3xVhnS8eGtvOh6/o6as6eW498EiYAch3+o5qwqnGG6mJFeY8RCL4xLPanwkSW/py66ydysV1041cLLgme9eAefYBZtWDyVmZzo6Ki5fSqtNGcQ8FYXxZP7uRtQlaTi5fFzjxqACUui+LNI6NVwadt3Aw3SrzuL9xtNIQAmrNVKKlUHLvIuTBWmvXkIdaLUpYyaZKS6up4/fbZc5G8X2VbTv3c/gLDAm9d9X71WkQWb+/iXWZn+f9JgmLG+7TAMtSIK0FvGD32DhmvB0E=","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR12MB9161.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(366016)(376014)(1800799024)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"2","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?DFN37hvchtJ0NJnqkYBMFPi8w1HT?=\n\t=?utf-8?q?qKemBB8v5kydYPeJyH7lNWQE+TV+j4B+Z423ydSIcpCpdnaagtUh43GuFkOgXkDgt?=\n\t=?utf-8?q?y66aojEinm1YDEVje2hFOpIGPgt09Qxq5IAHzNabclHcnCTJz6J14xZaGl4taUczs?=\n\t=?utf-8?q?KLPCvEr1XTxTXKRW/VTHwE7+sk4/HZsV0a91Occ46tXm3tNth9xWGGisBk67P1f1P?=\n\t=?utf-8?q?WX7lnZ8NGSzwUY5rIWQIhR7EYSdmXoO6w5mQQGzYh22OlDBzELD7n8xsVDEQo6i2m?=\n\t=?utf-8?q?mBXX+QZjZ3nHnkHNTNkLC79s/5pCGwvXL4JI2aJMzlcjjxjDu1ly+IvvwGPEPyYdM?=\n\t=?utf-8?q?9E4eipLhtmEc5UU5EAiUoCgw1+PfvI0tkqI6u0z6EepQdtiu2KDMadrufl43bnT6A?=\n\t=?utf-8?q?ZDXMZXkgWzvMWlNQ+NYYn5kmb4FtbZXMSUe6w6VGKzVnP94fW5ikNEO+ICoT2JKgq?=\n\t=?utf-8?q?izpPK8oBLJvui5JYcIU+ynNnSpb5sY5eb9LYPkHd7FsxmlprqoU8uti4vpL0wuN3j?=\n\t=?utf-8?q?EJSQYHaqDgbY8e+q7DaT5XSvAxuCAIVVhoM1/LDaOSuVvG9rspk/a8XUxa+4ZxUZ5?=\n\t=?utf-8?q?utItqJkhIC3LWo1sxhtYeJVCpxzNRMmZv/iXkol8eTArrit4AvEbZu6Gdh/v/eNdd?=\n\t=?utf-8?q?IuM0FCKUNqp8utRpvR8ha6gP65+kG/IZxgPkmU77G/oubbY482rJLlT3uO+YfgZsm?=\n\t=?utf-8?q?5BXHdh2fmN+OTROnvDBOZrHVdr872pwJPOFl5Ihd+5nxPUtBx7viWL0lFArlu7Gx7?=\n\t=?utf-8?q?lpkQyLJty7Nelm4lSi4zJ8Cz/J+Gww6w590Ul/lipRIbdMqkCTUXxnWM98SwlK2kv?=\n\t=?utf-8?q?SEZ87BrY03YorG6an5xFJkPtTHoylUEkaw3HH9l5u2kuWLU1M0u/kpJD4Tr1bl2PJ?=\n\t=?utf-8?q?KK+n7UTSOXTmneMGskMzcDa+HzlHryaR1vguh2P83MyKPJR5lLmI6ksko6yGXonw4?=\n\t=?utf-8?q?duX70RKux2U/NWw2UI+B343C3TcrGh7eeJu8dpy+9HiVjcgAUD1/4XfEY01iBS9IF?=\n\t=?utf-8?q?EZAdpsXknuOepfns8GIwjcpylPfM8yGliTmUs7EiWhHOnWup/ZGF14gwaptA0dBjU?=\n\t=?utf-8?q?z+V5g1hPTUeEdptK6nafz17tImsqv3OoLWuVkw3LN7PYN7sLnY5dJwecw9Cof84Q3?=\n\t=?utf-8?q?Lu2qYFI56zPSRiM0zSsFENEYEZPPdPaqtStpfru8d2yr6OsxIp0G3gECeRSVyISHN?=\n\t=?utf-8?q?hWCGvFIrbQUhItnw+cf1q/T3PLaPzUqYkK6xvEdXx9O2AKfoFicfBybMFDhib9/A7?=\n\t=?utf-8?q?FsxktBFboLUWY5tdhtMuMTLmx8cxgCfKuwNZY0Eh2ZMQGWX8JAWZ9b3iKDysEJnk5?=\n\t=?utf-8?q?O0zxgvGika3149cF+m7PFruKQ9s/kNZb0XDnhDLMSHRXwIAyJGoEjkO93xpgu3evK?=\n\t=?utf-8?q?o/IQf27vTPbSi8gWXr96zNuw9Dsf7ASI+F5sDl+35HLwVaaUmeQQbMUR6ChF2Zcys?=\n\t=?utf-8?q?QyNVLAF1F5xUDU8yrNPPiCpv+q1+uM7QlCKAn0fdgzpRk0ZV1Q1gAYo12wWR7iyW0?=\n\t=?utf-8?q?iZQvIG0eZ9gdR9wIvrs//x8sBSrP5SE9v7se0aPMCri+G7c9GcM/WDzsN3PJ1hLUH?=\n\t=?utf-8?q?gOS1U51bTZdLSUuECxIY8hoJMB3PBwponE6+n5zW+XzmdGujhBM1SRqg+FyxMtbNf?=\n\t=?utf-8?q?YPHt31DxN3c3993a3cQhEb17i0V/0WdM5qDvVBHdsvklYLXOAGIfQpU3oVJoal2P9?=\n\t=?utf-8?q?jRXvHIoYgZrBLocYk?=","X-MS-Exchange-AntiSpam-MessageData-1":"avCA5Ehi/MMwgw==","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n a3643925-8fc9-4aef-5b40-08de9ea0e8fd","X-MS-Exchange-CrossTenant-AuthSource":"LV3PR12MB9166.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"20 Apr 2026 05:51:48.3985\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n 4hH89JUVVi/fj1BHGyKUJj7eP/Q8OaUyyua0XEv57av9pDbEeHa6FHVa+pVCK0yV1FQz7Qz0c3M3YW+Q9D23XQ==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"SA0PR12MB4400"}}]