[{"id":3677297,"web_url":"http://patchwork.ozlabs.org/comment/3677297/","msgid":"<878qapzg2y.fsf@suse.de>","list_archive_url":null,"date":"2026-04-14T16:01:25","subject":"Re: [PATCH v3 4/4] tests/unit: add pread/pwrite _all tests for io\n channel file","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/people/85343/","name":"Fabiano Rosas","email":"farosas@suse.de"},"content":"Junjie Cao <junjie.cao@intel.com> writes:\n\n> Add unit tests for the new qio_channel_pread{v,}_all{,_eof}() and\n> qio_channel_pwrite{v,}_all() APIs.\n>\n> The basic tests write data to a file channel, then read it back at\n> various offsets using both the single-buffer and iovec variants to\n> make sure the round-trip produces identical content.  The _eof tests\n> verify all three return cases -- full read (1), clean EOF (0), and\n> partial-then-EOF (-1 with error set) -- and check that the strict\n> wrappers (preadv_all / pread_all) treat a clean EOF as an error.\n>\n> All tests are guarded by CONFIG_PREADV since the underlying channel\n> methods require preadv(2).\n>\n> Signed-off-by: Junjie Cao <junjie.cao@intel.com>\n> ---\n>  tests/unit/test-io-channel-file.c | 207 ++++++++++++++++++++++++++++++\n>  1 file changed, 207 insertions(+)\n>\n> diff --git a/tests/unit/test-io-channel-file.c b/tests/unit/test-io-channel-file.c\n> index 1977006ce9..b597350dca 100644\n> --- a/tests/unit/test-io-channel-file.c\n> +++ b/tests/unit/test-io-channel-file.c\n> @@ -102,6 +102,203 @@ static void test_io_channel_fd(void)\n>  }\n>  \n>  \n> +#ifdef CONFIG_PREADV\n> +static void test_io_channel_pread_all(void)\n> +{\n> +    QIOChannel *ioc;\n> +    char write_buf[] = \"Hello World, pread_all\";\n> +    char read_buf[sizeof(write_buf)] = {0};\n> +    int ret;\n> +\n> +    unlink(TEST_FILE);\n> +    ioc = QIO_CHANNEL(qio_channel_file_new_path(\n> +                          TEST_FILE,\n> +                          O_RDWR | O_CREAT | O_TRUNC | O_BINARY,\n> +                          TEST_MASK,\n> +                          &error_abort));\n> +\n> +    ret = qio_channel_pwrite_all(ioc, write_buf, sizeof(write_buf),\n> +                                 0, &error_abort);\n> +    g_assert_cmpint(ret, ==, 0);\n> +\n> +    /* Read back at offset 0 */\n> +    ret = qio_channel_pread_all(ioc, read_buf, sizeof(read_buf),\n> +                                0, &error_abort);\n> +    g_assert_cmpint(ret, ==, 0);\n> +    g_assert_cmpmem(write_buf, sizeof(write_buf),\n> +                    read_buf, sizeof(read_buf));\n> +\n> +    /* Read at a non-zero offset */\n> +    memset(read_buf, 0, sizeof(read_buf));\n> +    ret = qio_channel_pread_all(ioc, read_buf, sizeof(write_buf) - 7,\n> +                                7, &error_abort);\n> +    g_assert_cmpint(ret, ==, 0);\n> +    g_assert_cmpmem(write_buf + 7, sizeof(write_buf) - 7,\n> +                    read_buf, sizeof(write_buf) - 7);\n> +\n> +    unlink(TEST_FILE);\n> +    object_unref(OBJECT(ioc));\n> +}\n> +\n> +static void test_io_channel_preadv_all(void)\n> +{\n> +    QIOChannel *ioc;\n> +    char write_buf[256];\n> +    char read_buf[256] = {0};\n> +    struct iovec write_iov[2];\n> +    struct iovec read_iov[2];\n> +    int ret;\n> +    size_t i;\n> +\n> +    for (i = 0; i < sizeof(write_buf); i++) {\n> +        write_buf[i] = i & 0xff;\n> +    }\n> +\n> +    unlink(TEST_FILE);\n> +    ioc = QIO_CHANNEL(qio_channel_file_new_path(\n> +                          TEST_FILE,\n> +                          O_RDWR | O_CREAT | O_TRUNC | O_BINARY,\n> +                          TEST_MASK,\n> +                          &error_abort));\n> +\n> +    /* Write using pwritev_all with 2 iovecs */\n> +    write_iov[0].iov_base = write_buf;\n> +    write_iov[0].iov_len = 128;\n> +    write_iov[1].iov_base = write_buf + 128;\n> +    write_iov[1].iov_len = 128;\n> +    ret = qio_channel_pwritev_all(ioc, write_iov, 2, 0, &error_abort);\n> +    g_assert_cmpint(ret, ==, 0);\n> +\n> +    /* Read back using preadv_all with 2 iovecs */\n> +    read_iov[0].iov_base = read_buf;\n> +    read_iov[0].iov_len = 128;\n> +    read_iov[1].iov_base = read_buf + 128;\n> +    read_iov[1].iov_len = 128;\n> +    ret = qio_channel_preadv_all(ioc, read_iov, 2, 0, &error_abort);\n> +    g_assert_cmpint(ret, ==, 0);\n> +\n> +    g_assert_cmpmem(write_buf, sizeof(write_buf),\n> +                    read_buf, sizeof(read_buf));\n> +\n> +    /* Read at non-zero offset with preadv_all */\n> +    memset(read_buf, 0, sizeof(read_buf));\n> +    read_iov[0].iov_base = read_buf;\n> +    read_iov[0].iov_len = 64;\n> +    read_iov[1].iov_base = read_buf + 64;\n> +    read_iov[1].iov_len = 64;\n> +    ret = qio_channel_preadv_all(ioc, read_iov, 2, 128, &error_abort);\n> +    g_assert_cmpint(ret, ==, 0);\n> +\n> +    g_assert_cmpmem(write_buf + 128, 128,\n> +                    read_buf, 128);\n> +\n> +    unlink(TEST_FILE);\n> +    object_unref(OBJECT(ioc));\n> +}\n> +\n> +static void test_io_channel_preadv_all_eof(void)\n> +{\n> +    QIOChannel *ioc;\n> +    char write_buf[] = \"Hello World, preadv_all_eof\";\n> +    char read_buf[sizeof(write_buf)] = {0};\n> +    struct iovec iov;\n> +    int ret;\n> +    Error *err = NULL;\n> +\n> +    unlink(TEST_FILE);\n> +    ioc = QIO_CHANNEL(qio_channel_file_new_path(\n> +                          TEST_FILE,\n> +                          O_RDWR | O_CREAT | O_TRUNC | O_BINARY,\n> +                          TEST_MASK,\n> +                          &error_abort));\n> +\n> +    ret = qio_channel_pwrite_all(ioc, write_buf, sizeof(write_buf),\n> +                                 0, &error_abort);\n> +    g_assert_cmpint(ret, ==, 0);\n> +\n> +    /* Full read succeeds: should return 1 */\n> +    iov.iov_base = read_buf;\n> +    iov.iov_len = sizeof(read_buf);\n> +    ret = qio_channel_preadv_all_eof(ioc, &iov, 1, 0, &error_abort);\n> +    g_assert_cmpint(ret, ==, 1);\n> +    g_assert_cmpmem(write_buf, sizeof(write_buf),\n> +                    read_buf, sizeof(read_buf));\n> +\n> +    /* Clean EOF: offset at file end, should return 0 */\n> +    iov.iov_base = read_buf;\n> +    iov.iov_len = 1;\n> +    ret = qio_channel_preadv_all_eof(ioc, &iov, 1,\n> +                                     sizeof(write_buf), &err);\n> +    g_assert_cmpint(ret, ==, 0);\n> +    g_assert_null(err);\n> +\n> +    /* Partial EOF: start before end, request extends past */\n> +    iov.iov_base = read_buf;\n> +    iov.iov_len = 8;\n> +    ret = qio_channel_preadv_all_eof(ioc, &iov, 1,\n> +                                     sizeof(write_buf) - 4, &err);\n> +    g_assert_cmpint(ret, ==, -1);\n> +    g_assert_nonnull(err);\n> +    error_free(err);\n> +    err = NULL;\n> +\n> +    /* Strict wrapper (preadv_all) treats clean EOF as error */\n> +    iov.iov_base = read_buf;\n> +    iov.iov_len = 1;\n> +    ret = qio_channel_preadv_all(ioc, &iov, 1,\n> +                                 sizeof(write_buf), &err);\n> +    g_assert_cmpint(ret, ==, -1);\n> +    g_assert_nonnull(err);\n> +    error_free(err);\n> +\n> +    unlink(TEST_FILE);\n> +    object_unref(OBJECT(ioc));\n> +}\n> +\n> +static void test_io_channel_pread_all_eof(void)\n> +{\n> +    QIOChannel *ioc;\n> +    char write_buf[] = \"Hello World, pread_all_eof\";\n> +    char read_buf[sizeof(write_buf)] = {0};\n> +    int ret;\n> +    Error *err = NULL;\n> +\n> +    unlink(TEST_FILE);\n> +    ioc = QIO_CHANNEL(qio_channel_file_new_path(\n> +                          TEST_FILE,\n> +                          O_RDWR | O_CREAT | O_TRUNC | O_BINARY,\n> +                          TEST_MASK,\n> +                          &error_abort));\n> +\n> +    ret = qio_channel_pwrite_all(ioc, write_buf, sizeof(write_buf),\n> +                                 0, &error_abort);\n> +    g_assert_cmpint(ret, ==, 0);\n> +\n> +    /* Full read succeeds: should return 1 */\n> +    ret = qio_channel_pread_all_eof(ioc, read_buf, sizeof(read_buf),\n> +                                    0, &error_abort);\n> +    g_assert_cmpint(ret, ==, 1);\n> +    g_assert_cmpmem(write_buf, sizeof(write_buf),\n> +                    read_buf, sizeof(read_buf));\n> +\n> +    /* Clean EOF: should return 0 */\n> +    ret = qio_channel_pread_all_eof(ioc, read_buf, 1,\n> +                                    sizeof(write_buf), &err);\n> +    g_assert_cmpint(ret, ==, 0);\n> +    g_assert_null(err);\n> +\n> +    /* Partial EOF: should return -1 */\n> +    ret = qio_channel_pread_all_eof(ioc, read_buf, 8,\n> +                                    sizeof(write_buf) - 4, &err);\n> +    g_assert_cmpint(ret, ==, -1);\n> +    g_assert_nonnull(err);\n> +    error_free(err);\n> +\n> +    unlink(TEST_FILE);\n> +    object_unref(OBJECT(ioc));\n> +}\n> +#endif /* CONFIG_PREADV */\n> +\n>  #ifndef _WIN32\n>  static void test_io_channel_pipe(bool async)\n>  {\n> @@ -147,6 +344,16 @@ int main(int argc, char **argv)\n>      g_test_add_func(\"/io/channel/file\", test_io_channel_file);\n>      g_test_add_func(\"/io/channel/file/rdwr\", test_io_channel_file_rdwr);\n>      g_test_add_func(\"/io/channel/file/fd\", test_io_channel_fd);\n> +#ifdef CONFIG_PREADV\n> +    g_test_add_func(\"/io/channel/file/pread-all\",\n> +                    test_io_channel_pread_all);\n> +    g_test_add_func(\"/io/channel/file/preadv-all\",\n> +                    test_io_channel_preadv_all);\n> +    g_test_add_func(\"/io/channel/file/preadv-all-eof\",\n> +                    test_io_channel_preadv_all_eof);\n> +    g_test_add_func(\"/io/channel/file/pread-all-eof\",\n> +                    test_io_channel_pread_all_eof);\n> +#endif\n>  #ifndef _WIN32\n>      g_test_add_func(\"/io/channel/pipe/sync\", test_io_channel_pipe_sync);\n>      g_test_add_func(\"/io/channel/pipe/async\", test_io_channel_pipe_async);\n\nReviewed-by: Fabiano Rosas <farosas@suse.de>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=SCQ84fmY;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=eXEbFRIs;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=0BBrL6eH;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=5vrE03RI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n\tnone"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw8GF4PsQz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 15 Apr 2026 02:03:47 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wCgE1-0002G0-QE; Tue, 14 Apr 2026 12:02:57 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1wCgCt-0001qo-5k\n for qemu-devel@nongnu.org; Tue, 14 Apr 2026 12:01:49 -0400","from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1wCgCq-0002A4-TB\n for qemu-devel@nongnu.org; Tue, 14 Apr 2026 12:01:42 -0400","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 32EC76A923;\n Tue, 14 Apr 2026 16:01:32 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C70DA4B517;\n Tue, 14 Apr 2026 16:01:31 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id ztKmJdtk3mnwWQAAD6G6ig\n (envelope-from <farosas@suse.de>); Tue, 14 Apr 2026 16:01:31 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776182497;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=5epeZS7gQeyZI3GRPRjJA/MQs5JuJpdcBe4fP0KydaA=;\n b=SCQ84fmY2pQp+p2UhL1viBq43aUKiJBjf5IIkUkHbCN/MFuSX2Fg6oZ+MRAsvS6bKnzt5H\n cK1CklwTI4oK2fDOffGJGbuReZy/8+wnEdFgtJGQMohocL4kF0mcsYNHW3Kb1IHII382mK\n FqHbM8RtArN5rciuXBJJrI9MJFf+Mbk=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776182497;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=5epeZS7gQeyZI3GRPRjJA/MQs5JuJpdcBe4fP0KydaA=;\n b=eXEbFRIsAjTKAtbYDDeyZ1MxkrewT3gNAEiGojXVh0Q77Ib3GEyM2nlwaimAbh04HuPz8b\n E52unbQDOmRWnsDQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776182492;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=5epeZS7gQeyZI3GRPRjJA/MQs5JuJpdcBe4fP0KydaA=;\n b=0BBrL6eH11YKW7GLzh/FYm9hZZ9NE/svCjEJCJo3YJDlPCv3PrvnaHJ4lEjK3IYs4ujCSG\n H6R+nP1C9yi1I9SytO/F/TJjMlSVXhL+C27vmESa0+sBX7JpYAIWMYbGF+O9947nXgGbJx\n dk8PYA70GJm8WnS4pBTYfj0TP0TbSEk=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776182492;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=5epeZS7gQeyZI3GRPRjJA/MQs5JuJpdcBe4fP0KydaA=;\n b=5vrE03RIuhRkB3ybv7T2SZ3hCDK0HZhbOJ8CgTCO6MrZol5oZqSQOxI2mN3HMhMmm3GHCx\n Hbd1yr3QThHk/4Ag=="],"From":"Fabiano Rosas <farosas@suse.de>","To":"Junjie Cao <junjie.cao@intel.com>, qemu-devel@nongnu.org","Cc":"berrange@redhat.com, peterx@redhat.com, junjie.cao@intel.com","Subject":"Re: [PATCH v3 4/4] tests/unit: add pread/pwrite _all tests for io\n channel file","In-Reply-To":"<20260413214549.926435-5-junjie.cao@intel.com>","References":"<20260413214549.926435-1-junjie.cao@intel.com>\n <20260413214549.926435-5-junjie.cao@intel.com>","Date":"Tue, 14 Apr 2026 13:01:25 -0300","Message-ID":"<878qapzg2y.fsf@suse.de>","MIME-Version":"1.0","Content-Type":"text/plain","X-Spamd-Result":"default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; RCVD_TLS_ALL(0.00)[];\n MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[];\n TO_DN_SOME(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n MID_RHS_MATCH_FROM(0.00)[];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[5];\n FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n RCVD_COUNT_TWO(0.00)[2];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid, suse.de:email, intel.com:email,\n imap1.dmz-prg2.suse.org:helo]","X-Spam-Score":"-4.30","Received-SPF":"pass client-ip=2a07:de40:b251:101:10:150:64:1;\n envelope-from=farosas@suse.de; helo=smtp-out1.suse.de","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]