[{"id":3677560,"web_url":"http://patchwork.ozlabs.org/comment/3677560/","msgid":"<4yzeebhaojygexo2ori5xpwyjpldag66vkoywnnrcs2ncjoght@bjiaqfz6koeo>","date":"2026-04-15T09:38:28","subject":"Re: [PATCH v2] bus: fsl-mc: Fix refcount leak in fsl_mc_device_add()\n error path","submitter":{"id":74646,"url":"http://patchwork.ozlabs.org/api/people/74646/","name":"Ioana Ciornei","email":"ioana.ciornei@nxp.com"},"content":"On Mon, Apr 13, 2026 at 09:43:44PM +0800, Guangshuo Li wrote:\n> After device_initialize(), the lifetime of the embedded struct device\n> is expected to be managed through the device core reference counting.\n> \n> In fsl_mc_device_add(), all failures after device_initialize() jump to\n> error_cleanup_dev, where mc_dev and its associated resources are freed\n> directly instead of releasing the device reference with\n> put_device(&mc_dev->dev). This bypasses the normal device lifetime\n> rules and may leave the reference count of the embedded struct device\n> unbalanced, resulting in a refcount leak.\n> \n> The issue was identified by a static analysis tool I developed and\n> confirmed by manual review.\n> \n> Fix this by using put_device(&mc_dev->dev) in the error path and let\n> fsl_mc_device_release() handle the final cleanup.\n> \n> Fixes: bbf9d17d9875 (\"staging: fsl-mc: Freescale Management Complex (fsl-mc) bus driver\")\n> Cc: stable@vger.kernel.org\n> Signed-off-by: Guangshuo Li \n> ---\n> v2:\n> - note that the issue was identified by my static analysis tool\n> - and confirmed by manual review\n> \n> drivers/bus/fsl-mc/fsl-mc-bus.c | 6 +-----\n> 1 file changed, 1 insertion(+), 5 deletions(-)\n> \n> diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c\n> index 25845c04e562..6d132144ce25 100644\n> --- a/drivers/bus/fsl-mc/fsl-mc-bus.c\n> +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c\n> @@ -905,11 +905,7 @@ int fsl_mc_device_add(struct fsl_mc_obj_desc *obj_desc,\n> \treturn 0;\n> \n> error_cleanup_dev:\n> -\tkfree(mc_dev->regions);\n> -\tif (mc_bus)\n> -\t\tkfree(mc_bus);\n> -\telse\n> -\t\tkfree(mc_dev);\n> +\tput_device(&mc_dev->dev);\n> \n> \treturn error;\n> }\n> -- \n> 2.43.0\n>\n\nWasn't this issue already fixed by the following commit?\n\n commit 52f527d0916bcdd7621a0c9e7e599b133294d495 (tag: soc_fsl-6.20-1)\n Author: Haoxiang Li \n Date: Sat Jan 24 18:20:54 2026 +0800\n\n bus: fsl-mc: fix an error handling in fsl_mc_device_add()\n\n In fsl_mc_device_add(), device_initialize() is called first.\n put_device() should be called to drop the reference if error\n occurs. And other resources would be released via put_device\n -> fsl_mc_device_release. So remove redundant kfree() in\n error handling path.\n\n Fixes: bbf9d17d9875 (\"staging: fsl-mc: Freescale Management Complex (fsl-mc) bus driver\")\n Cc: stable@vger.kernel.org\n Reported-by: Dan Carpenter \n Closes: https://lore.kernel.org/all/b767348e-d89c-416e-acea-1ebbff3bea20@stanley.mountain/\n Signed-off-by: Su Hui \n Suggested-by: Christophe Leroy (CS GROUP) \n Signed-off-by: Haoxiang Li \n Reviewed-by: Ioana Ciornei \n Link: https://lore.kernel.org/r/20260124102054.1613093-1-lihaoxiang@isrc.iscas.ac.cn\n Signed-off-by: Christophe Leroy (CS GROUP) \n\n\nWhat tree are you using?\n\nIoana","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256\n header.s=selector1 header.b=iOdZEXsF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19760-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=pass smtp.remote-ip=\"2a01:111:f403:c20a::7\" arc.chain=microsoft.com","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=nxp.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256\n header.s=selector1 header.b=iOdZEXsF;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=permerror (SPF Permanent Error: Void lookup limit of 2 exceeded)\n smtp.mailfrom=nxp.com (client-ip=2a01:111:f403:c20a::7;\n helo=pa4pr04cu001.outbound.protection.outlook.com;\n envelope-from=ioana.ciornei@nxp.com; receiver=lists.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nxp.com;"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwbgx3vsMz1yCv\n\tfor ; Wed, 15 Apr 2026 19:39:07 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fwbgp0Gwgz2yvh;\n\tWed, 15 Apr 2026 19:39:02 +1000 (AEST)","from PA4PR04CU001.outbound.protection.outlook.com\n (mail-francecentralazlp170130007.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c20a::7])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange secp256r1 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fwbgm2BVMz2yrM\n\tfor ; Wed, 15 Apr 2026 19:38:59 +1000 (AEST)","from VI0PR04MB11503.eurprd04.prod.outlook.com\n (2603:10a6:800:2c7::16) by AM8PR04MB7300.eurprd04.prod.outlook.com\n (2603:10a6:20b:1c7::12) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Wed, 15 Apr\n 2026 09:38:33 +0000","from VI0PR04MB11503.eurprd04.prod.outlook.com\n ([fe80::cbe9:4c03:71b6:359f]) by VI0PR04MB11503.eurprd04.prod.outlook.com\n ([fe80::cbe9:4c03:71b6:359f%6]) with mapi id 15.20.9769.046; Wed, 15 Apr 2026\n 09:38:32 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776245941;\n\tcv=pass;\n b=H9PcvcvELiico/miaWus0qxDCKdC04VIpk05jF/cMa8NAyFPsCp6e2bFpSCgzxZ29ZdeOViv0rWcJ0xAzDoWGyBjGHQ7f7yPwmuDyTrcLRdMaIxu+5cnR9DYaLBEfT9ZyNTKw6L7aR4bSOmke8u442mYVnGDmn3m+Yo85mFY7q5iG/kLzaBKVztDj8I3UULL2QGQSHovAVcLRocl/3YWIe5kUzqiq2yST4y08p5+lBZbhg3GvL5P/8sDP7PF9/E9JnN4ztqCPOM2PfcrDuoCCrn2JFXYteu//IXmUXNtEmf0IfyhcKFw216zKth1beKBRZmTGxu/LZVcR5wRSTMNgw==","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=oTVLmXZaGzntrwRYUA19xPmlMWhUP+HCHX9VmfuooX8UIZWxvIYg+RLuvOxZEN3VqdqA7mqOJEUOCzjOQ2gRj3LUMk+4DAgk5M6Nj+HWzcamixQw0h7Ngsny/xXwt88pCy9if8UOj+fQdzwjs1aVt+1fERMtWk2Z5is7U14kjoylWMxvWSwJ4sMvTv9RTlcA5XKJR9dMsRcnNZt50fiOVQ13VzkrD8ziffk2UKjHLPj4QwrUlk3Pio4ZoeCizbYoYXKFb2qmACzFYOd4sTicU7AbO3mVdqf0ObbYvnAO4aEQIfiE+3WP0hVjiYGiL1X5W9htU842vUOhDUrkIlFEgA=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776245941; c=relaxed/relaxed;\n\tbh=6IaXVMdfy1aeMdV068wD7+q2JUwFFXYx7S3bdpT8DhM=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:Content-Type:\n\t Content-Disposition:In-Reply-To:MIME-Version;\n b=IikUWR8an+gWbOg1Yx+a7GIQzsgVa3bf8PBlnNs0t2D1t8SvfRrh5cOH9SWiMUVMacvD46lFCYlI2x51GXrLF46bR8hSf57bPz/Wg25MaHJHT3r+9Obha1QJBicksZnRqa7ya9D7BphcMExP+or5C12NRgWPqAv3W2aJ7Me2LvTMw+tcU/AL1j0GX+cDXcFaeFvQEF5S9NXEIz6uMXq4rU6Yy2wOo6I17aJ6bgja3fdnRq0GQUH0Ve6UkeyrJK0OI6DXFCQNFgGwZinS5YU7BvUIPOhvo+/Y4T6ih9BERRP9aiphNVhV/dd0qBlMUvx8IpZwlOS/sbAglvHrIYd5mw==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=6IaXVMdfy1aeMdV068wD7+q2JUwFFXYx7S3bdpT8DhM=;\n b=ByVjQyt0TcrtwGAmTeaFMqIvbe9y/WZoCXrRIXNCz2KfQCp8Fj0TCjY8O1nH9ldyXb+jekbz8bx6P+0jXsXcQ3K8GAgkTGozdFduEHaPup+7eaFdbhlSPamaUweg5hEt7ylviECY93i91v98IE+q0oxg7djKQ/WhZpotuJTIiLBGJBgFeVFFPPH+epVW3orMzOr0nCK5TPipFX1zOVRWtpJfH3y2F4JiWXEty40Cs/WF9f6cm3KjLc2lP6hiOi0DX8KW8IybthZ3vF30Gpawbqbue0+A/qmRALiQDP+9VYz+95MhxF6s1AojUQX2HfxkW6IVuBCxy/Yp59As42JMlQ=="],"ARC-Authentication-Results":["i=2; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=nxp.com; dkim=pass (2048-bit key;\n unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256\n header.s=selector1 header.b=iOdZEXsF; dkim-atps=neutral;\n spf=permerror (client-ip=2a01:111:f403:c20a::7;\n helo=pa4pr04cu001.outbound.protection.outlook.com;\n envelope-from=ioana.ciornei@nxp.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=nxp.com","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass\n header.d=nxp.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=6IaXVMdfy1aeMdV068wD7+q2JUwFFXYx7S3bdpT8DhM=;\n b=iOdZEXsFe4xHl4XBmMy/aaZGQGIFJLLOtinvk79GhvUUgm2/3T3nOO++KMaCaYrxe8Ikeu6JJMn/0JaBuW+FYe1mVPwYqmYFFESQDpVJVRStHgo04eAvoP2iKOzAm/fuxrNpugTlPG5Rq0NVxfleyGutYMDqdJ/qKe35N6yWy1zdfJSwbJRtEWL1IlczK0PaPtfwDT19URjhvna2Xj15pW0Tk7hbIwDjoTuImIdV6wJ8L9FiHy1ow67xIGHv1sET7Waj3duykGd32SYr/h7e00J+AlsNaa4Hbn284oGBzVserB4R48hwMbDT41CuQ0eXU0bpZGHQxXI8FS4TMg6cTg==","Date":"Wed, 15 Apr 2026 12:38:28 +0300","From":"Ioana Ciornei ","To":"Guangshuo Li ","Cc":"Stuart Yoder ,\n\tGreg Kroah-Hartman ,\n Alexander Graf ,\n\t\"J. German Rivera\" ,\n linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,\n\tstable@vger.kernel.org","Subject":"Re: [PATCH v2] bus: fsl-mc: Fix refcount leak in fsl_mc_device_add()\n error path","Message-ID":"<4yzeebhaojygexo2ori5xpwyjpldag66vkoywnnrcs2ncjoght@bjiaqfz6koeo>","References":"<20260413134345.2855417-1-lgs201920130244@gmail.com>","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260413134345.2855417-1-lgs201920130244@gmail.com>","X-ClientProxiedBy":"AS4P190CA0002.EURP190.PROD.OUTLOOK.COM\n (2603:10a6:20b:5de::11) To VI0PR04MB11503.eurprd04.prod.outlook.com\n (2603:10a6:800:2c7::16)","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"VI0PR04MB11503:EE_|AM8PR04MB7300:EE_","X-MS-Office365-Filtering-Correlation-Id":"6af04951-fac2-4540-d49e-08de9ad2c245","X-LD-Processed":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n BCL:0;ARA:13230040|376014|19092799006|1800799024|366016|18002099003|22082099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n gvA5mhk0OWpmVrTTXub1B6GxeeYW2YgW2w74FoKQfWyGmm8rRvtugSWwQQyWjINTebEBAmOuFdPCHrLXDfvmY4nt2NzdFpL0M2k0dIWVPq30IKG3IhkN0GuMTGy9Pmccl0RzelmkcUC16OpCwKohQWzvbOUI6e7Q1VhnQklxtcEto5s+bKXbqTnLfQE0g3da0dbO9DmTEqQwesdqxY3ImV4UaK543AzwCMGMbWOdSP52BySk71AHGbuLjxbd5oGicGvq/Bb5a8NqgMTCA8W9/sUNt8Lm988vG1vOq4J//LNHUl5WVB6lyv6IxKq5z1+JJUl+GWF4fAJnmrdTOWZ2Al7BY/oVr9+a5gYyQWggBd8i5NNA9jT8X0kBc/Bhkqh0m3z2ducoi5yq0ziTSDrGeNPgGM9A/zBAXEHt//44WlYAVnEA9atxV+cLt2Lq5vtMi7LsG/+/j92f+L0GXJdBDJB01AN2O+p0iwoJGPlvnO0Dry0stN0gquyH1vET+H31fCswVmA1JyvIkU/e+tBC+CpDld34DQPoI+UEalrIR/bezZ+cBNs+4h0BpR/2wttW1jHURqXyUX1RQPL8DM07IHXhyJIB6LHFdXYeonFYogXutK16K+xJnwGX4B8PF2JNq97P269GVxa5L6NrrwmKQDvJSR7SI5awfU8y+J03mVwbuWTS5h+DkudiAl48NOFiVkJz6ZvAqYQMuiTpJtN+D0AHGAVX9TfqzLiktQg1R0ycfyDe48c4kHQf3ofTCmNb","X-Forefront-Antispam-Report":"\n CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR04MB11503.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(19092799006)(1800799024)(366016)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n 5zddRclJLM+lrN3mkVMxfuztVXdn5XPbCE/b6rgCpRL405MGynAvgvqMChGNs9DY5Tev+AOUecYkzbyBlctOY2pg79Px7+g4U9QlodvN4UUuiFs7JKQuk5CqaakeKH/bfGRfutmyr2ajpoa7zxgqdFoyPuPRHUjaf/ll9o3IpJ0yt4drZEX3hYKuK4HcOOQheD8fL2mLFNHBExPgc0OglZlvST/etrQn/7k6XYTTMQh7gaYJmoRS5LUnUdOrfGOM3j3qXYZIrTgjTaKtd/gGMGjuWfFdhY480j3uonHrAKW9k+TnOuJfv2nIRQrT9FjJzcUhQtjqdrdW5U8Wq+j748DM6j1VcXWkc1ZZfDnPea0pYAz3x6Sb/gX0MtTv87vSpp+NPT7EvzJvRjlI4wOvmbN3ICxGmAcNCAxRe3cQ1ybruYTN1VtBnjs84VCY+Q0aTcoAGoSBPKThCUp0fimX9pjg2lZwVqd1+nVDi2C/BO3OEM1Ju7p7oXUBEY+Mik+SxY1m0nmoq7FkApZHkT74pyKSCXaUyLHUzD2ZGVXGLgro6CXRBDRgZxbTip2TyTSpqrC9rrQOb8VMIOhjYIkWx0UftEu7BvQNw+ytf3czwEkzxhlKDIjlktCHK9ifZdsfuChVXTodRAe7WtegRlF2IYXUODEUMhlUH9bbIerm6I4wqETSWQBSNy0Bqe9IQZzMZyWa75HZwqW1tATvP2yHpe/H1UHJEbooBigqPIMH3iwW58OSQSpnvLPxZEzqVE4xE2/LR5GOSnqME5QiEDeQeezZwrPYpxMgEpXguJ01cSDAL9xV7/znOFZ6u8VMLFGA6a9HaGU0kLTSkPtSdyfQdh+eO1/ubSRiOc2US3y1vCFjPs5VWuLsZZlzthtHBBhMb5nW7l0BAUNjCHflVLNXr9ADtp/zwtZalzMeRY70u5N/SJzgM0mDJQEJQO67nyKFfZoLS94NDG1rHjrMitKKsCq7XQeDw3v+6EwpP19o6sa3KSeQg3Xaowz66lNJk367Z7zb/aMXF+n7KIvESG8hRKEg5QE5gyk5v8LCNkodVa6Gf3TeV3MsmtqIbKhWyiNukcxGwclyrqpDnpDiKmpikc3orPrXQkKIYX7ARnk7yXCTnjqSrrcI6/GwzKPsuXw8suoStVNEFt9Y9qokE/otp/Am43wh9ZJwfWoRCAwcUW0m6qpTEtHMf/PUGvnDXC7B3BzAavndPdrjIU3Gw/+53aapk4EVY4GVLHn9jGzByabgZ+CWTbqU9t1ScloAQbGphm9PtEAlNHmwMDsM4+nRbyPcqYLdSBfDYU1tcGASy8kgeYpYhiXZon/ZD8TmJ/xl4L5dqETypABPjbm8qc2Bbj9birvgMwwhCG5Ad6XBl9vzxlE9Nd3JXO2wzhPiI+EbP3mhBLpA3ICK4b3nBAELjC9GX4/N9z2ihcHwsC1VEW3TVij1V5z4xhxOGeeo2uVlgM+Lmu/x4twCqle6zjL4A8o5NcIsQV+vf1+elTICwL1cFvYp2CHjuSEFbeAZ/eleXFNBbR7ZOIr9aM2WDkDcOfcHhdpbQBoU/o1c6Si9B7BrbbQOZLU19ZtAFgmGL4pa5QgnNEL+6zHQCu5nmUcANiQNvvNFB3mcq5XRSR+gDToovT6Y4Lcq94l5UxhKxXm5unxE3OgWIQQwx+r8nG9NZBULxrW39h10zAJi6oCSETUJJfDhvWQPx7389i8fExgNINa94q4nSiraEyr/xtjzpw==","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 6af04951-fac2-4540-d49e-08de9ad2c245","X-MS-Exchange-CrossTenant-AuthSource":"VI0PR04MB11503.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"15 Apr 2026 09:38:32.8185\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n VSwKRaBcsZGNjfKis6DsW1MLu6KySOlp+/5/gPtD+Ds2p149XPvZjD7k0PM/cQCPF80EEmymFAGW415n48HzGQ==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AM8PR04MB7300","X-Spam-Status":"No, score=0.8 required=3.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,\n\tRCVD_IN_DNSWL_NONE,SPF_HELO_PASS,T_SPF_PERMERROR autolearn=disabled\n\tversion=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3677589,"web_url":"http://patchwork.ozlabs.org/comment/3677589/","msgid":"","date":"2026-04-15T10:39:00","subject":"Re: [PATCH v2] bus: fsl-mc: Fix refcount leak in fsl_mc_device_add()\n error path","submitter":{"id":91722,"url":"http://patchwork.ozlabs.org/api/people/91722/","name":"Guangshuo Li","email":"lgs201920130244@gmail.com"},"content":"Hi Ioana,\n\nThanks for reviewing.\n\nOn Wed, 15 Apr 2026 at 17:38, Ioana Ciornei wrote:\n>\n> What tree are you using?\n>\n> Ioana\n\nI was using v6.19-rc8-214-ge7aa57247700 when I found this issue.\n\nFrom the commit you pointed out, it seems the problem has already been\nfixed upstream. Sorry for the duplicate report, and thanks again for\ncatching this.\n\nBest regards,\nGuangshuo","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=bstkquvC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19762-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=pass smtp.remote-ip=\"2607:f8b0:4864:20::b133\" arc.chain=google.com","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=bstkquvC;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com\n (client-ip=2607:f8b0:4864:20::b133; helo=mail-yx1-xb133.google.com;\n envelope-from=lgs201920130244@gmail.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwd1N0DtJz1yCv\n\tfor ; Wed, 15 Apr 2026 20:39:19 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fwd1L25sSz2yvY;\n\tWed, 15 Apr 2026 20:39:18 +1000 (AEST)","from mail-yx1-xb133.google.com (mail-yx1-xb133.google.com\n [IPv6:2607:f8b0:4864:20::b133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fwd1K0nBcz2yvG\n\tfor ; Wed, 15 Apr 2026 20:39:16 +1000 (AEST)","by mail-yx1-xb133.google.com with SMTP id\n 956f58d0204a3-65006c99d38so6781929d50.3\n for ;\n Wed, 15 Apr 2026 03:39:16 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776249558;\n\tcv=pass;\n b=C2fSaWqslr1wlfNUMz21WUPevXqFqnMFt/c3tuRb962Ngs7kG7XI4qE9Y5hCmkD0ZnXGkROnmPXu1+eLiG2nKgBP4WN877oflZsQ26J3Dln1Hy0VyP8Drik+uRT6w0PKL9EJK2ETiyggR67NI3b7OjlKD3Z48XRx+TuaYiClw14wnAs3M77zcRSjWNilxWScRCfhpga1n7J6G6qRrqew9T7LJXXkP91U/8697CC8TWxwHNF2pRoiPnsdHwKzHzv9w/pyO7euBcEvDnxiAFpS8QNGpH/hfYH+Aae1wrTc2I370raHVAHNS2dnD2+cl0lpFka2IVYDWJXhujgC+M19Cw==","i=1; a=rsa-sha256; t=1776249554; cv=none;\n d=google.com; s=arc-20240605;\n b=Lg0Zt6R9tlyQiw0n3WGDF6IKAioSZiXuMwYE1+2LKn0SWbX2QqRPTu5aNpu3Q/rKCq\n ztUmM7qBwTMHryxgF6jG3bKatk/eYvUM8h0n/10zfpFDiLzVUJL/UaNEYK2qAu4cO2+j\n UCBuJW8douMs6wZXs1p9KuN0RArqO7X6kJJ02g+bA+6syyjsqWKpczMrEEVUd3F8UHOo\n uWNgOh1ioYsX+fuuhi4K1wSlWgnsuVj6TaOOqQZwC/XrqUIn29zq+TUmFApQyURR/FxJ\n st1Zwpm/HdKSkOihZCZRONVV5SOcjvc9/MhCjtpcsfpk6YXMOBgEPNEPCIqfPZO5PbvV\n 9NNg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776249558; c=relaxed/relaxed;\n\tbh=GfVO3mataKPZTl+zZ7bVK67m7nflCt2vlvwElWHXQpg=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=nTUrHXq1own8MidrSf+MdNNmSeBLOOhw+45q0qDi4F/qoVik3e/mEl1wEj1kP7SF8hFeO1xzdCN7LTjx4tqqXWpsSX0MWW97SpTqP4Kzb6BI8g0kSBIGnCtyliqRaaT3OKW8y5oLakuIMBfQ7mMBFhjcGc72N6Yh9bOBIpmj+YCZ/SMWV7f1hlxZb/1dWbth3Lt50cULgFCLnmS0q1VhuJP4GtwlToUXv8TKv4nofgnNng5+gnot88hFiha6wN6HbnS9UEUE7QY46J4xUgPUTT18WlmAmYKITgFhEMD2E1n7K31vH4AeJR105TNJ+jpt4cimzTBFm8AcqtvxLxS9KQ==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=GfVO3mataKPZTl+zZ7bVK67m7nflCt2vlvwElWHXQpg=;\n fh=PC+rGgqj3dAu6BMShtr7yx27lRaP0ya52hWZy+pMCJ4=;\n b=Np878qRDNhmsu3EIzw52Xxgs+xMeH/aQj2iy/Q1FV7ilGDIrpyUYHrexg02uHiplaU\n QA0PMPxp4zGntFoBnOHWyAK1JofLIUrhF8plvEQF9rutBuDa1Tfqz8VPNVLnBfjp027Z\n cLl7scd3urrh42wxNmhsSsS7dB7yXBGNmPjr4QVhvIyMQ48U+79LdidZ+pD+75C6CD6M\n kUEft2fr8xRc9WFO8OIAoBCYyQrZAETPC6iPoXbtLGtC/mjepHzWIDEl7lk9O8Z+mawc\n oK4I5cOV9uUi+JjEryk0v9EWJYl28hZ/SGwUxPpskexnZPvLBzEVvIbYj1e58loDC91P\n fdgg==;\n darn=lists.ozlabs.org"],"ARC-Authentication-Results":["i=2; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=bstkquvC; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::b133; helo=mail-yx1-xb133.google.com;\n envelope-from=lgs201920130244@gmail.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776249554; x=1776854354;\n darn=lists.ozlabs.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=GfVO3mataKPZTl+zZ7bVK67m7nflCt2vlvwElWHXQpg=;\n b=bstkquvCT9gf97G0C8lio92Yd/Nl372n/gr+0clEA0YJHosZdO+NbLyM1I02MeUhC6\n 8oncpsgqvCNQauq4x4nSJKH9mVMebwIFX/OSnwQSXmnny7RIs1ZylUGmUkDIt+ySyG+O\n ZdDDJ75n1wRbybnT3976TgGr5W2QIAhVk8ALFLIvaQtcwK+lypfilDxHci7m8aHFFrqP\n yG/9amTMrAMrH4CN16PRzNrqnlGBJ4KzXVMhDaMMbRusUPtjYCvhVCB2tmPO8kktbXzH\n yNPjEj09Ot6TlHPkDN3H8gxdOLJOpsSpcGCn4dxT6UqUrQwDOLPrifuB+h+/d0dQR7+A\n PCmw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776249554; x=1776854354;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=GfVO3mataKPZTl+zZ7bVK67m7nflCt2vlvwElWHXQpg=;\n b=EIMTNm7h27thzNHxxtVUWmpy4oyy1ETQkX8aYMZuISnCH2vxgLKP358K00PfEoz3HI\n TfczjU/or8O0b1GvZCOJafrpAVjL+tvh3yQuxBS/6iDuHG89PAnb8lmQMT8HSE/vmHLn\n dKukszAPLCO0m/PEWda2C9/hzTHycrS9tWgVzUcdist98Bh/abASpqyUXqSeoaz8sgd3\n 6d4xF1B8Vnga1OjFDxxmKqzjLA3Cv/nAyeLpco5uDdZIkIhP+0XCM39neRHRZgkkPcs/\n NfAwI7EyNcpjh+x23qk1NlW0+AcCdAvp2zU7/xHF17P+NEkEzpHxh1BlPzb7ZuORNboi\n uc1Q==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9H2BzT6PWtAbVIBMW812mo09epBU9xD4VC7qQL/pMt9X30gwKV53tlB72FSiJy+X2oLB8Ba20NWLSD5G4=@lists.ozlabs.org","X-Gm-Message-State":"AOJu0Yw29497EMxiKjs77xnLtuB5F4N1sxED6Gmko+zFgnK1i499Rbeu\n\t95ZN7Uc5/BxVbEmb2Iw0vlYrhuPvISpKyWdF82JrlCvf4O+oxJ3brCSykbtZDL/z2Efx20ETJ78\n\tGlJt5BlTgXyRJB3jKq+7baZfdb7w9f1c=","X-Gm-Gg":"AeBDiesYn/ht/DG7QgQRqzl2v9exEw1FcMN4wMnDsgvtbee4H98OmnFRpTroCGWfArn\n\tUyFO0kysOshe5DPBlb/endGbyfIaweSDZRohDjYGAc49Bg7ALSR/KnikPcI2BNnic6NvmdqTixq\n\tot2LqafkQM4eiJXcddrv9nT5sW9gh0iKIOftda2TiOviGKvfcn9NDnirQWn9x/I9bVeXyiMIPMH\n\twOQeFYMEt9Qq0tww7bjubxKt5hquOkt7G5ur2b/0fBrYlqz/8itQWwgsCv2SrWVnXolwGy0OgtQ\n\tu+NN6+k4UaWhRbC7NaScYow/QKa88A4=","X-Received":"by 2002:a05:690e:1404:b0:651:d2ff:dc6c with SMTP id\n 956f58d0204a3-651d2ffef9amr9116210d50.68.1776249554088; Wed, 15 Apr 2026\n 03:39:14 -0700 (PDT)","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","References":"<20260413134345.2855417-1-lgs201920130244@gmail.com>\n <4yzeebhaojygexo2ori5xpwyjpldag66vkoywnnrcs2ncjoght@bjiaqfz6koeo>","In-Reply-To":"<4yzeebhaojygexo2ori5xpwyjpldag66vkoywnnrcs2ncjoght@bjiaqfz6koeo>","From":"Guangshuo Li ","Date":"Wed, 15 Apr 2026 18:39:00 +0800","X-Gm-Features":"AQROBzCMM7yF1lbVtFjb7fumcuxkzR_jd819BKirInIUv9EulL0NA_j9prMl11s","Message-ID":"\n ","Subject":"Re: [PATCH v2] bus: fsl-mc: Fix refcount leak in fsl_mc_device_add()\n error path","To":"Ioana Ciornei ","Cc":"Stuart Yoder ,\n\tGreg Kroah-Hartman ,\n Alexander Graf ,\n\t\"J. German Rivera\" ,\n linuxppc-dev@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org, stable@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-Spam-Status":"No, score=0.4 required=3.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n\tFREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,FROM_LOCAL_DIGITS,\n\tFROM_LOCAL_HEX,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]