[{"id":3677069,"web_url":"http://patchwork.ozlabs.org/comment/3677069/","msgid":"","list_archive_url":null,"date":"2026-04-14T08:39:03","subject":"Re: [PATCH v1 2/3] pinctrl: qcom: lpass-lpi: Fix GPIO register access\n helper return types","submitter":{"id":89450,"url":"http://patchwork.ozlabs.org/api/people/89450/","name":"Konrad Dybcio","email":"konrad.dybcio@oss.qualcomm.com"},"content":"On 4/13/26 2:22 PM, Ajay Kumar Nandam wrote:\n> The LPI GPIO register access helpers previously returned the value from\n> ioread32(), even though their return type was int. This mixes data\n> return with status and is inconsistent with common kernel helper\n> conventions.\n> \n> Rework lpi_gpio_read() and lpi_gpio_write() to return an int status and\n> use output parameters to pass register values. Update all callers to\n> match the new helper interface.\n\nlpi_gpio_read/write() can never fail, let's just make _read() return\na u32 and _write() a void\n\nKonrad","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=Fh05gK9Z;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=gSHfdmQJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35133-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"Fh05gK9Z\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"gSHfdmQJ\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.168.131","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvyRC3mDdz1xtJ\n\tfor ; Tue, 14 Apr 2026 18:40:55 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 9CB55301963B\n\tfor ; Tue, 14 Apr 2026 08:39:13 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E34AC3B7777;\n\tTue, 14 Apr 2026 08:39:09 +0000 (UTC)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n [205.220.168.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 14C70271A94\n\tfor ; Tue, 14 Apr 2026 08:39:08 +0000 (UTC)","from pps.filterd (m0279862.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63E6b8xq366050\n\tfor ; Tue, 14 Apr 2026 08:39:07 GMT","from mail-qt1-f200.google.com (mail-qt1-f200.google.com\n [209.85.160.200])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dh870su9p-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ; Tue, 14 Apr 2026 08:39:07 +0000 (GMT)","by mail-qt1-f200.google.com with SMTP id\n d75a77b69052e-50d8c183c2eso50474611cf.0\n for ;\n Tue, 14 Apr 2026 01:39:07 -0700 (PDT)","from [192.168.119.254] (078088045245.garwolin.vectranet.pl.\n [78.88.45.245])\n by smtp.gmail.com with ESMTPSA id\n 4fb4d7f45d1cf-671d70c9656sm350209a12.31.2026.04.14.01.39.04\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 14 Apr 2026 01:39:05 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776155949; cv=none;\n b=DdwZUxPJCIJUSU2HcNboDuKi9U+ChN5OHhpuoCB1G5GLUSV9uQBwMxTDwkKVahC6bPnG35WCIbYtvklwlfDbyxOMfEeUbJiOmzFbP6F8bLmV3k1W5sOkXpzaI2pkoIqneI/7ZErdCRUiPiGYvjjLBpSjL4m4qaoeGEoFQp3dhGo=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776155949; c=relaxed/simple;\n\tbh=2OM0Bj5MdJC/WW/lvYXymofwjCsnlyzXjNUwgtvtWvo=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=pNQknixPp/7nEpOhdhUV6vHC3sQQdgrH7xrCpkSp9MzLi3zqqWrYIrEr1zGW4+HPwXamGTir1V2CFTkvCzrJpJxsU+ARSHADCi04fKnu95TzJtH36mPIGfX+Z8I2taRgTkMQzpFKYPPs/AdvF6eG49L9Xww9V9nyMvo6+hM9zgI=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=Fh05gK9Z;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=gSHfdmQJ; arc=none smtp.client-ip=205.220.168.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\tOHglZFOx9lNBJSLn5k6IqHh65sPfy2JLY48LcxRXXXs=; b=Fh05gK9ZTOAAKx+N\n\t+HIRuU5AzjaBQoWUKfh0GyjyiP61ilvHbjrbM2OCdc7BdRZEdMFWCNUHaxzfai9C\n\tMkowhfReTY55qoq3HMIeKgaKOLeicZiYOmQ1QmLJ5O3y1KqyBed77oWAzGIxTDmL\n\tNHa1s8E1J4WQmVyOml6cFUpwnwDissCHfq5i9A77BLhn8v44WrikSLbkxoKev87Q\n\t2mHKROmeD5kAr68V6jkh/vqSeM3uq4aBrkVOxILa/Xjn0GK5cirNUpvEFBD8g4Kv\n\teGlPN1X8fwenm3+kOczaUhFsWSJCdB8B6okOl8cp68Z8QaMYnQa0jOqt1s8Y9V5T\n\teYMNMA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1776155946; x=1776760746;\n darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=OHglZFOx9lNBJSLn5k6IqHh65sPfy2JLY48LcxRXXXs=;\n b=gSHfdmQJKyVlkOKZv+c1qLaip7VEzFlSEY5iOR8d/HPxmJSDQGNuwPRPJjfHeCWETI\n J1M2zuOxjlxTER3MCoAjdAD2g/LTG2wPjKyvX1RFuViG3yfY8SSNK4o/ZQQL+gClRZI0\n 68jOp93Cm8Y/kpyZoEejsMGsPuxQ/FAIXknkl6QlmQOmV578SaoetkoLCqwPz7ZaHGhJ\n LzPXRUhkKRz1sQbX+ukgB0D/7N4Dq++lQVPGN/S8J9dHNCUSAMpp9ceUtuVD2yU+1CN4\n M16DwnvJOQYbOz0b20676IFplfRGCcQ5lhi7P/7NqayxXvNwWujdywo7m/fIR1Yf9YYv\n Dj4w=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776155946; x=1776760746;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=OHglZFOx9lNBJSLn5k6IqHh65sPfy2JLY48LcxRXXXs=;\n b=mkbSyfgzAMKSEU2O3xFdqR14sk4tRHtG9ql3niNScH3ZkwaMyaULD250o8y4xaJxqF\n 23dh0H6yCzz/9nkcqp/oKJtro4j0QrTRVkk21N2Ff5a84ZidQiZs7+DRz9jQ/0YJGCAX\n iNYEp2YCZHOhdfdUhMBX003TIPthl/gzXPJlV/Etvmven6GRBdFJKZyzhBUka6Nh9GB2\n vzQWYx+7fBsbIkmYVnWUo6jzndtDd36OaV0w1OLTxdg9x9xznsS+99/DHzGd66rjmmkp\n 4cac2ksK5kOmhb4+yTqQD+mj27iTnLTXMYMuLeA3ptwgcRr2f30nUTJ12Qegv5xsGB+6\n QAjA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/SzSCupYflfe0FZFaWrO1g4a5GVXc6Q1TR/gjma2hGDzz42BLRQEB/w0YQ6SpjZtsMGykHWgepYxrx@vger.kernel.org","X-Gm-Message-State":"AOJu0YwauTqo+xlZ++6I5rxlqw2/8yA58YbQ0xuyL5RPb08dZMUcbxM5\n\t4fKI1FYp5U81YjYIyzGQsg/KutQxsEJSNdtuUgtAtI74LbvmAGAGelzipAZSemvd2OsXWPOd5XL\n\tRbQBLmimaiaHqFsqJ31WmiwlGJfsXKwlpal4nmvslYLqy0D2XK1TtPIuHYbO7wb4d","X-Gm-Gg":"AeBDiesec+AlLWdtXHx4OOh6n6DJz/attEm9pQqq+Zf3UqVwtXG9MKR8SYZs6CU49qS\n\t6wVUM5EOvZ4O/3ljm5WFrL1E0x2fCfFbuVlMa+GjYs+K2pxPF5EnZYOmGqGtY+vJz3aj9LLd5MA\n\tQU0P3b4KYjDBt2NTHQ3CI2fVtDv/2+XAfA/2hihEu/52aiVwMgRfi551kZ7fu+/f39JDJlQnRok\n\tKAjkqaHf4h3BnljcoPcRPcFuwGSb9oznCItGi0O5w1opODUaNER523yqXl0Xz5+FkbhkKgPoKNl\n\tOGeCOBM+2O0eXSr/zqeo7x+4WPJxF9LbLLNKpArAfmwfzksMazOj0kQKLSBesgxfAE0HVHes+xx\n\t7Ov9Vyt62ZaI5b63lZffCZfT8fFEAyui3ZkPVmsUFXRea1uZsKc5pyVbopMb8dbSHpf1zbNl9nm\n\t/+4XNVDTUj3LIFvw==","X-Received":["by 2002:a05:620a:1721:b0:8cf:d68a:9a96 with SMTP id\n af79cd13be357-8ddceab5d14mr1619129085a.4.1776155946517;\n Tue, 14 Apr 2026 01:39:06 -0700 (PDT)","by 2002:a05:620a:1721:b0:8cf:d68a:9a96 with SMTP id\n af79cd13be357-8ddceab5d14mr1619126885a.4.1776155946105;\n Tue, 14 Apr 2026 01:39:06 -0700 (PDT)"],"Message-ID":"","Date":"Tue, 14 Apr 2026 10:39:03 +0200","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 2/3] pinctrl: qcom: lpass-lpi: Fix GPIO register access\n helper return types","To":"Ajay Kumar Nandam ,\n Bjorn Andersson ,\n Linus Walleij ","Cc":"linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,\n linux-kernel@vger.kernel.org, srinivas.kandagatla@oss.qualcomm.com","References":"<20260413122233.375945-1-ajay.nandam@oss.qualcomm.com>\n <20260413122233.375945-3-ajay.nandam@oss.qualcomm.com>","Content-Language":"en-US","From":"Konrad Dybcio ","In-Reply-To":"<20260413122233.375945-3-ajay.nandam@oss.qualcomm.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Authority-Analysis":"v=2.4 cv=C9vZDwP+ c=1 sm=1 tr=0 ts=69ddfd2b cx=c_pps\n a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22\n a=lehnMraD3ed_Nmqd2dEA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10\n a=uxP6HrT_eTzRwkO_Te1X:22","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDE0MDA3OSBTYWx0ZWRfXy4/80f3U+cyP\n /sZgXiEJIWqXssronO3Ltafdrop+j0mf9Go0FHsPphxUHXj3NLwOmnZOR++wTzZngDCjZPZTllf\n kGPaCRSCrq+ZYYgI7yIlMhu/MzuVwRFvl8jbyoHD1G9+xbHNIAgUvfx99dXHOHWSkY6zZ1VVzVL\n GP6owssd3FqAYKauXGM/cgpCKi/xaHbF1bL5MTz60LCZ1UEewz7hvwNdoyk9nQy5BBslgmdb4mz\n /ogM4Ys2DYYSW/rDdBP5U1LZs2Bn40knQ6+wgb81vPlHi3JiLYdnx/O9+JjWktCE0dSy6L2pgnt\n AAy0bO2CWb0fugXIZDsF7m/kUEGR0iOW6rnlTcvsg4dD1NzVnCdOZESQciyI3MFjo+MfSz/91SW\n eetMZlIEqwvy6BIhdMnf96zpcKLwjDYwGEsFfRVUQ8IogqLFSO7YXO0Fd/vJZP31PJIA7rrLjw/\n U60EDr4rkxOoRN8pzMg==","X-Proofpoint-GUID":"80uQHqm-89fuoTxfKd-kBNxuetCMFtEi","X-Proofpoint-ORIG-GUID":"80uQHqm-89fuoTxfKd-kBNxuetCMFtEi","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-14_02,2026-04-13_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 suspectscore=0 clxscore=1015 malwarescore=0\n lowpriorityscore=0 phishscore=0 bulkscore=0 spamscore=0 impostorscore=0\n adultscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000\n definitions=main-2604140079"}}]