[{"id":3677404,"web_url":"http://patchwork.ozlabs.org/comment/3677404/","msgid":"<5da15f31-e9af-4f8d-82fd-eac29a6d98f6@intel.com>","list_archive_url":null,"date":"2026-04-14T21:02:58","subject":"Re: [Intel-wired-lan] [PATCH v2] dpf: fix UAF and double free in\n idpf_plug_vport_aux_dev() error path","submitter":{"id":9784,"url":"http://patchwork.ozlabs.org/api/people/9784/","name":"Jacob Keller","email":"jacob.e.keller@intel.com"},"content":"On 4/13/2026 4:20 AM, Guangshuo Li wrote:\n> If auxiliary_device_add() fails, idpf_plug_vport_aux_dev() calls\n> auxiliary_device_uninit(adev), whose release callback\n> idpf_vport_adev_release() frees the containing\n> struct iidc_rdma_vport_auxiliary_dev.\n> \n> The current error path then accesses adev->id and later frees iadev\n> again, which may lead to a use-after-free and double free.\n> \n> The issue was identified by a static analysis tool I developed and\n> confirmed by manual review.\n> \n> Fix it by storing the allocated auxiliary device id in a local\n> variable and avoiding direct freeing of iadev after\n> auxiliary_device_uninit().\n> \n> Fixes: be91128c579c (\"idpf: implement RDMA vport auxiliary dev create, init, and destroy\")\n> Cc: stable@vger.kernel.org\n> Signed-off-by: Guangshuo Li \n> ---\n\nThis doesn't look right. The commit message analysis seems to match this\nfix from Greg KH:\n\nhttps://lore.kernel.org/intel-wired-lan/2026041432-tapestry-condition-22ff@gregkh/\n\nBut the changes do not make any sense to me. It looks like a poorly done\nAI-generated \"fix\" which is not correct. Greg's version does look like\nit properly resolves this.\n\n> v2:\n> - note that the issue was identified by my static analysis tool\n> - and confirmed by manual review\n> \n\nWhat even is this change log?? I see that version was sent and everyone\nelse was sane enough to just silently reject or ignore the v1...\n\n> drivers/net/ethernet/intel/idpf/idpf_idc.c | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n> \n> diff --git a/drivers/net/ethernet/intel/idpf/idpf_idc.c b/drivers/net/ethernet/intel/idpf/idpf_idc.c\n> index 6dad0593f7f2..2a18907643fc 100644\n> --- a/drivers/net/ethernet/intel/idpf/idpf_idc.c\n> +++ b/drivers/net/ethernet/intel/idpf/idpf_idc.c\n> @@ -59,6 +59,7 @@ static int idpf_plug_vport_aux_dev(struct iidc_rdma_core_dev_info *cdev_info,\n> \tchar name[IDPF_IDC_MAX_ADEV_NAME_LEN];\n> \tstruct auxiliary_device *adev;\n> \tint ret;\n> +\tint adev_id;\n> \n\nYou create a local variable here...\n\n> \tiadev = kzalloc(sizeof(*iadev), GFP_KERNEL);\n> \tif (!iadev)\n> @@ -74,11 +75,14 @@ static int idpf_plug_vport_aux_dev(struct iidc_rdma_core_dev_info *cdev_info,\n> \t\tgoto err_ida_alloc;\n> \t}\n> \tadev->id = ret;\n> +\tadev->id = adev_id;\n\nadev_is is never initialized, so you assign a random garbage\nuninitialized value. This is obviously wrong and will lead to worse\nerrors than the failed cleanup.\n\nI'm rejecting this patch in favor of the clearly appropriate fix from Greg.\n\n> \tadev->dev.release = idpf_vport_adev_release;\n> \tadev->dev.parent = &cdev_info->pdev->dev;\n> \tsprintf(name, \"%04x.rdma.vdev\", cdev_info->pdev->vendor);\n> \tadev->name = name;\n> \n> +\t/* iadev is owned by the auxiliary device */\n> +\tiadev = NULL;> \tret = auxiliary_device_init(adev);\n> \tif (ret)\n> \t\tgoto err_aux_dev_init;\n> @@ -92,7 +96,7 @@ static int idpf_plug_vport_aux_dev(struct iidc_rdma_core_dev_info *cdev_info,\n> err_aux_dev_add:\n> \tauxiliary_device_uninit(adev);\n> err_aux_dev_init:\n> -\tida_free(&idpf_idc_ida, adev->id);\n> +\tida_free(&idpf_idc_ida, adev_id);\n> err_ida_alloc:\n> \tvdev_info->adev = NULL;\n> \tkfree(iadev);","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=NUWK1zt2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwGvj2dZsz1yCv\n\tfor ; Wed, 15 Apr 2026 07:03:13 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id BFF6442D10;\n\tTue, 14 Apr 2026 21:03:11 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id yqrij5fufYZI; Tue, 14 Apr 2026 21:03:10 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 4F41C42D0F;\n\tTue, 14 Apr 2026 21:03:10 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id F271B283\n for ; Tue, 14 Apr 2026 21:03:08 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id E3F8F42D0E\n for ; Tue, 14 Apr 2026 21:03:08 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 4sdtOJMv260I for ;\n Tue, 14 Apr 2026 21:03:08 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.18])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 5F37242D08\n for ; Tue, 14 Apr 2026 21:03:06 +0000 (UTC)","from orviesa002.jf.intel.com ([10.64.159.142])\n by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Apr 2026 14:03:05 -0700","from orsmsx903.amr.corp.intel.com ([10.22.229.25])\n by orviesa002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Apr 2026 14:03:06 -0700","from ORSMSX903.amr.corp.intel.com (10.22.229.25) by\n ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Tue, 14 Apr 2026 14:03:05 -0700","from ORSEDG903.ED.cps.intel.com (10.7.248.13) by\n ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Tue, 14 Apr 2026 14:03:05 -0700","from SJ2PR03CU001.outbound.protection.outlook.com (52.101.43.27) by\n edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Tue, 14 Apr 2026 14:03:04 -0700","from DS0PR11MB7579.namprd11.prod.outlook.com (2603:10b6:8:14d::5) by\n CH3PR11MB8658.namprd11.prod.outlook.com (2603:10b6:610:1c5::17) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr\n 2026 21:03:02 +0000","from DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e]) by DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e%5]) with mapi id 15.20.9818.014; Tue, 14 Apr 2026\n 21:03:02 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4F41C42D0F","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 5F37242D08"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776200590;\n\tbh=p73F1o8clvF1p9PJoD0uwapdSO+HkUJq5T1zZnLrCvM=;\n\th=Date:To:CC:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=NUWK1zt2f01NdI+nldOdB4r09N5gejyoaswzKeR71+mC/VXkpKS8pgV8hk/Tkdawq\n\t 0B0L0GPPKgE1R3RR5Wvtd3ZxE5meH9A2M72NUYCfJRixJCb5WRZiGMZtGhM66lnCM/\n\t TIwIVVpv71KJ3bAvEoITxhVleIuXpqMZnsWuwZkY+8NVuNhR2HQYbQtsLpq9iROpcv\n\t ceJYIscpsP4ixxIU6vTRkkkp+oCv8abMhQrGQRgq8hL+hHtawsCH89e8uUKd3OQsJt\n\t tsDzYIZmpVuAZGzZSTSox0iJOsXPzL/w4OCFiu7FlXSSuMpfunq8g219RC5sap+Pf0\n\t LooxBJ0bkSByQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.18;\n helo=mgamail.intel.com; envelope-from=jacob.e.keller@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 5F37242D08","X-CSE-ConnectionGUID":["ttzPQWbrSRWS/HUSR4prJA==","FgoeFK4LQrC/TiIQ8upybg=="],"X-CSE-MsgGUID":["oMxA+GUyQvGdOeVIuN8zzg==","BHpd7nr7T8KabEy/6YHRaw=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11759\"; a=\"77194707\"","E=Sophos;i=\"6.23,179,1770624000\"; d=\"scan'208\";a=\"77194707\"","E=Sophos;i=\"6.23,179,1770624000\"; d=\"scan'208\";a=\"260632776\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=AHnDmRx10dh+YjCO67L9mi/z5Md0DyACiVlVPe5gPVE8tqEzJK56/dClsQUgSaPrZNBevFXiu1p0QDV9hK4r8QBcLlCBkdEvIP20grvd260bbWzR33JNqcSfqUjUhQi3ABrANr88y4bfI52/K/HddXkL1BUQXg7R8Gzsr7YTrpJ4itMAyP1ILDNpHzqc6MQL5m7kT6HhGkyEziEQvk4GfIfcODOhSKjBUZVGsWlNWarDxxv2kgZftqH3CgGY1o8R+7D7EIGCtmc7vXpZIWCyk8ZvqhYH/kq3GltuaR1cDU9o+nvflbL8l38PQUSghM+48H9torDolqtAxBlaA+VPnw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=p73F1o8clvF1p9PJoD0uwapdSO+HkUJq5T1zZnLrCvM=;\n b=fSsMAhxl5k/7A9uP2GbwIHJwVLYiOQmE8Clsh0TeKQYwhzyLXnUtutSaUZis9ZhGwqLnwHd2vzBwy07nKlTd9e8N3+sVZi10s0pYWUjvTGC5CDprfcoRjGDHUowysVjamPYZHown+p02vCPmGruz/F/hBE85iWIjOSZIWLpQ7xggSJ/e9LbipB5chupz84Z5QEQzbT6tSCoWfW8t99J0LxNiBvGn/e3wUhv5BbhSsoDDe+5csP0FnXv0BtbxOdrCKiUEpXmTH6VtrX4MQPanC1jOt2ctnVUXShUE8w5fzPskobCvS2SMqHECSLmsCT7amhhJekbuWE/FGAc4EaLt+g==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","Message-ID":"<5da15f31-e9af-4f8d-82fd-eac29a6d98f6@intel.com>","Date":"Tue, 14 Apr 2026 14:02:58 -0700","User-Agent":"Mozilla Thunderbird","To":"Guangshuo Li , Tony Nguyen\n , Przemek Kitszel ,\n Andrew Lunn , \"David S. Miller\" ,\n Eric Dumazet , Jakub Kicinski , \"Paolo\n Abeni\" , Joshua Hay , \"Tatyana\n Nikolova\" , Madhu Chittim\n , ,\n , , Greg Kroah-Hartman\n ","CC":"","References":"<20260413112030.2694563-1-lgs201920130244@gmail.com>","Content-Language":"en-US","From":"Jacob Keller ","In-Reply-To":"<20260413112030.2694563-1-lgs201920130244@gmail.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"MW4PR04CA0255.namprd04.prod.outlook.com\n (2603:10b6:303:88::20) To DS0PR11MB7579.namprd11.prod.outlook.com\n (2603:10b6:8:14d::5)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS0PR11MB7579:EE_|CH3PR11MB8658:EE_","X-MS-Office365-Filtering-Correlation-Id":"c2481b5e-2ce6-44f7-83a0-08de9a693779","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|376014|7416014|1800799024|366016|921020|18002099003|22082099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n qS5insaIkmYDNB8nSlc1SMNMJEP3QLtokZQqCKL0ZjzKJoYUrn8BTM1WMj2Vuoo1PHo+xDPOfGfntYQR2dRMiQeH30IXwVGnXv9biMgCevyA2OSG7URcsOPM3XfWcvQpKz7xf9wwEOiUd5m38/EzX39W23KJdynaEOMlKbqSL+Dg5Ix+XmIRP6g/7389E//UR1hMMbio+OetFpVWASX7DLdGJBd5jp19OtlMbbUip5w8xyuMUCBWAi+TMkx1/pvaXg4lCxQ3Bnr/hvThQsjIZWHFWUJQ0NPczZeqYYy9LpmsT897i+R2D4J5yx1pCnJJXNv/uOY2ilgjNxNWh69rMWonAYLS0PUa1JE5hLgchiXRXYoq4/yQ7xiwoSSk4mtYVWaJacaVz+I9y2lgg4ELp6Y5XD+Dsp8VDGTDeOfNB6szlxFUanyL6ZP34SRx8XrfyXHSoXK6JbUmmqVhYNNC9yFxztJlhoWfUHIi1O/mMr6WZQT0s/AKokg3k60UPv1F/bBware42JECjMfeJWTu1LbOSmaGwYBK1FfElbNuZQSHkaSS1mht8sK/sgmv+9Kldr3j3PQYlL1knd9hVjsyTBlQHDSWfEl4ARbl8daiLT6cGuKiHhmlqFIv8bPLmTUywoWmYZb63jcz/GnTiu/vMMViiJR0GOutX9B7+3bibAQzqCqwR2z/sMkP2YY2J2yWP4fLJbW3ARHUEz21D8w/9FZbDeoRGomlP96jrwFT8vF5svLsl1uj7MFoQt4T82ofT9U/EWDxJ5PDFGEZ90902JdtJjl8D5P8fJ2LqLaahww=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DS0PR11MB7579.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(7416014)(1800799024)(366016)(921020)(18002099003)(22082099003)(56012099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?+4w+DKI0oLnMK/J0W29K2POJezMt?=\n\t=?utf-8?q?kjWINUNhWteJoyDCZfcBesE+6ZTbXwM0bYZ9PsdotGxyExkEJgWHJSK2tT0QyhX1Y?=\n\t=?utf-8?q?apQNQOnVOIWiOdvGzEMNbOmVNCqjt6sir6b86edjZ96wCuZVXISKrK7L0gIdNvo8M?=\n\t=?utf-8?q?NMu1f5I0wE2Q3FiCSPUQJi5JS9YGePNI7l7s1S4cKyHD0AshWD/f3eM/+am4RXiEP?=\n\t=?utf-8?q?l7iZbcZdg5oFh/6caBijPiSqJEA1N/gerRSquFROBl/kACCHxhDJbneND6XeP27fj?=\n\t=?utf-8?q?Wxb2O6wXiSTDHKNpdw+iLhPkZJ2WlcLojvPrFynNh6tRLFokatdQW9zRbOj107HRO?=\n\t=?utf-8?q?4NPo5C11/DvuLm1g6S4UIgC1tey+pQ3LWRRHEKJOKy7sPgKTnqWOJiA5jDdNYhzUc?=\n\t=?utf-8?q?QDrRe9gFZ/LsGzChkDaQeMl1moeCnJcT/o5Y0LUoSheOujMb+squBDSROB+lGQ9aG?=\n\t=?utf-8?q?1qqsbzDhNmSLNgDny/BL1h4YZRq7ewtvK3CAtCPnEPzRO3GzVvg0rDJMFHgQMjiuN?=\n\t=?utf-8?q?SiN0jqmupwsqVxFt725xTB9IxxxND71XqF1GAURGBk4I3Z/s/CaRF30jmDRo/dHs9?=\n\t=?utf-8?q?waKuej8cgw5ETIWQpD/M7DVWSmBpbbQZfZqNzQkJdCOD09J+ucBXpM/67o3cfLGjm?=\n\t=?utf-8?q?2risf3IIiFYwaRR3oeEfjx/vhmS8ZzNUe5sB3nsNiqiFmZTWivWYgfvrDUnFTAc9X?=\n\t=?utf-8?q?66rjq5tKrUm07nufTott7FCJdxGYtPxvMHHpjY0oTonp5eYSNeBgJ/U5TlsSrF4Yw?=\n\t=?utf-8?q?39de9zXXWrWUrdTuG7RMr7EtMkqLgvbc65o76gOPAAEew/EC/T57WGvWKTizpEgTq?=\n\t=?utf-8?q?4utzjoAxlmBf/QaIha25SfYjqfclfDggKBIPXCUsH4w9U4M4D/gLwNz6HS5Dt6awJ?=\n\t=?utf-8?q?3bXCJSTgy6+kQOuJq7AhNG5/Yu3P9IxzFxGoDetZd5WmGbxdrACY51FAc2mCPlSPi?=\n\t=?utf-8?q?cUc+ZdDS01oSeCbNBR2K5kGLTcBea0U2V3byMaNU09yQbVGhXzOKTDorsgiF/p8oq?=\n\t=?utf-8?q?QZR5Km1VlFfCWXl7EQeUntDxdPJJfawxZ566qJukOEl2Eq5LveXGa7btfEUA8YAL9?=\n\t=?utf-8?q?vPwSr+bv3CN1RTbhQS0Hyn47jRwrEGInh4lLGowPYp2ZMyUoG7N0X4B5ArTgjIJk0?=\n\t=?utf-8?q?tx4NHno9r+NXySqit1KKZqETo8Hce7BY+aVl7QIFDoPnXv9v5X33crpSsYfDoLdFs?=\n\t=?utf-8?q?bfFGfebDDxaY8ulxv6R/saXfzFpgxmD2MgfYht8w5wkj5XUFaW5cvzltVJGAT6vPw?=\n\t=?utf-8?q?8+4ioYbRvT1UtHFRgmYEE0thuAfILPoJ2btXNXgVURGQ1hWEz5+zGfDgseD/15cbK?=\n\t=?utf-8?q?V+favvjLPiUmcwD+t5bWzw/VqMuWkB4IOFQ+ohw6akZtrUZYoaaZHBE14JVQg7Gej?=\n\t=?utf-8?q?wkm3Wcx7iI0OeXyR+chiGJYlyFV+Rlu2yuTg9LKOuEXZHrG2hzGZXrbFW+8IO/7hs?=\n\t=?utf-8?q?HPw6OZ4qj2F8wwCfK5F9GJtVBuYm3I4teX5MZ5z8wIwcNdg0ebrFrFPlpttlLYRtL?=\n\t=?utf-8?q?alKOA+S2VZ83dXaCKu8ksOqoKEbTNGsP7Y1AgbIGm86GowtfHkmhQYP6+hT60aJAy?=\n\t=?utf-8?q?XiYSDgxeNl28IQKqYeHq7DZtK17b+1H9cnWuGmuBehgAtVoAtM3Y9PhswLlcY7sH5?=\n\t=?utf-8?q?kTGrLsMiWhiWoC2N7DtxwL00dvF4rdfsDNawu0jYI5k13N++hHqCg=3D?=","X-Exchange-RoutingPolicyChecked":"\n YW059cB8GqwoG+T96PlU+2WuBIIMVLjw4GBgHfkLdhpdSOeWNAdRS8v3gkC0JPazx/r8b0WXBgrhbdWLOl7eETeT/paFbVP5X7qnyi9ZgJmpkloOxPQN0Kgn5qiVSiQy6xQpL2TgxOCS1B1Vx2rcuLq+CYb87Oeu9aPv6414q5vh2bXz4FYIJjdYCjKUvnmgCHX3E6UOAdAREfo+wX+R0XLhxX9otgGg2qr1Hg/rNdkKDr/DzpBGlS6H4YSd3Fn/a4X0B4iHzFH26kgStnY5JEa4i7ZMSgP0qa2x1j+kGXCiWPDxma6834V0qGJXvYCLE5cEr0pmT3PLs3RumF/Rfg==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n c2481b5e-2ce6-44f7-83a0-08de9a693779","X-MS-Exchange-CrossTenant-AuthSource":"DS0PR11MB7579.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"14 Apr 2026 21:03:02.7868 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n MLcCT+11G5KDd35WDtTf8t9qBFpnDAF5yqihXWmtyg2Cf4cCoHaHMKoXjp0uFQB6ODaLrtzQX6hkbBZjuGpO+4bRukWCQRfVZIQjZ7YWm7E=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CH3PR11MB8658","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776200587; x=1807736587;\n h=message-id:date:subject:to:cc:references:from:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=jg5tIUx+gg4fBvYc08Y92aXxrwu3eWi+dP3pAh7MVwI=;\n b=IJ1ThKaBkmPrx8/KnjvE7Ex1p62CUA1cBC2/Mn4zHWPDyEq5k7CVaCM3\n YvYvFozzcx0f1TXjh1PRf3Ayfkjn+p3RVdna3wcEnRLyDzMacgBBjvMHV\n 013U9G+xM4wIjsbx30D6wsfj1jH8kvYI20DK5gCqnouGYK/6HJNtSgL/v\n Jj9KEFuBN0KMVYyWnLG13poe0RI74cou1H1nkYhpv3AW7yslR3sJ84F6c\n Bh3HVLg1hEwMQc0boDZ0GrLE3UBzxb4cUNT827gaVPdUxdwAW+SMSw0yu\n a7a6UyrAYLcsMLkdlHNk/UDcRPbn9kjQNRJq39Fm8A5coBPS5lD9geQz/\n w==;","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=IJ1ThKaB","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH v2] dpf: fix UAF and double free in\n idpf_plug_vport_aux_dev() error path","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3677435,"web_url":"http://patchwork.ozlabs.org/comment/3677435/","msgid":"","list_archive_url":null,"date":"2026-04-15T01:47:50","subject":"Re: [Intel-wired-lan] [PATCH v2] dpf: fix UAF and double free in\n idpf_plug_vport_aux_dev() error path","submitter":{"id":91722,"url":"http://patchwork.ozlabs.org/api/people/91722/","name":"Guangshuo Li","email":"lgs201920130244@gmail.com"},"content":"Hi Jacob,\n\nThanks for reviewing.\n\nOn Wed, 15 Apr 2026 at 05:03, Jacob Keller wrote:\n>\n>\n> This doesn't look right. The commit message analysis seems to match this\n> fix from Greg KH:\n>\n> https://lore.kernel.org/intel-wired-lan/2026041432-tapestry-condition-22ff@gregkh/\n>\n> But the changes do not make any sense to me. It looks like a poorly done\n> AI-generated \"fix\" which is not correct. Greg's version does look like\n> it properly resolves this.\n>\n> > v2:\n> > - note that the issue was identified by my static analysis tool\n> > - and confirmed by manual review\n> >\n>\n> What even is this change log?? I see that version was sent and everyone\n> else was sane enough to just silently reject or ignore the v1...\n>\n> > drivers/net/ethernet/intel/idpf/idpf_idc.c | 6 +++++-\n> > 1 file changed, 5 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/drivers/net/ethernet/intel/idpf/idpf_idc.c b/drivers/net/ethernet/intel/idpf/idpf_idc.c\n> > index 6dad0593f7f2..2a18907643fc 100644\n> > --- a/drivers/net/ethernet/intel/idpf/idpf_idc.c\n> > +++ b/drivers/net/ethernet/intel/idpf/idpf_idc.c\n> > @@ -59,6 +59,7 @@ static int idpf_plug_vport_aux_dev(struct iidc_rdma_core_dev_info *cdev_info,\n> > char name[IDPF_IDC_MAX_ADEV_NAME_LEN];\n> > struct auxiliary_device *adev;\n> > int ret;\n> > + int adev_id;\n> >\n>\n> You create a local variable here...\n>\n> > iadev = kzalloc(sizeof(*iadev), GFP_KERNEL);\n> > if (!iadev)\n> > @@ -74,11 +75,14 @@ static int idpf_plug_vport_aux_dev(struct iidc_rdma_core_dev_info *cdev_info,\n> > goto err_ida_alloc;\n> > }\n> > adev->id = ret;\n> > + adev->id = adev_id;\n>\n> adev_is is never initialized, so you assign a random garbage\n> uninitialized value. This is obviously wrong and will lead to worse\n> errors than the failed cleanup.\n>\n> I'm rejecting this patch in favor of the clearly appropriate fix from Greg.\n>\n> > adev->dev.release = idpf_vport_adev_release;\n> > adev->dev.parent = &cdev_info->pdev->dev;\n> > sprintf(name, \"%04x.rdma.vdev\", cdev_info->pdev->vendor);\n> > adev->name = name;\n> >\n> > + /* iadev is owned by the auxiliary device */\n> > + iadev = NULL;> ret = auxiliary_device_init(adev);\n> > if (ret)\n> > goto err_aux_dev_init;\n> > @@ -92,7 +96,7 @@ static int idpf_plug_vport_aux_dev(struct iidc_rdma_core_dev_info *cdev_info,\n> > err_aux_dev_add:\n> > auxiliary_device_uninit(adev);\n> > err_aux_dev_init:\n> > - ida_free(&idpf_idc_ida, adev->id);\n> > + ida_free(&idpf_idc_ida, adev_id);\n> > err_ida_alloc:\n> > vdev_info->adev = NULL;\n> > kfree(iadev);\n>\n\nYou are right that the v2 patch as sent is incomplete. That was my\nmistake when preparing/sending v2: it accidentally dropped the adev_id\n= ret; assignment, which made that version incorrect.\n\nFor reference, the original v1 patch is here:\n\nhttps://lkml.org/lkml/2026/3/21/421\n\nIn v1, adev_id was assigned from ret before use, so I believe that\nparticular uninitialized-variable issue was introduced in the v2\nposting.\n\nSorry for the confusion caused by the broken v2 posting.\n\nThanks,\nGuangshuo","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=S9tBe48g;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwPDc3w3lz1yHc\n\tfor ; Wed, 15 Apr 2026 11:48:15 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 9C64642EC6;\n\tWed, 15 Apr 2026 01:48:13 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id BWBEiG2CegxW; Wed, 15 Apr 2026 01:48:12 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id C24BD42EC7;\n\tWed, 15 Apr 2026 01:48:12 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id 91AD0375\n for ; Wed, 15 Apr 2026 01:48:11 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 8EE9784F76\n for ; Wed, 15 Apr 2026 01:48:11 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id nwL7g6TU9lN3 for ;\n Wed, 15 Apr 2026 01:48:11 +0000 (UTC)","from mail-yx1-xb133.google.com (mail-yx1-xb133.google.com\n [IPv6:2607:f8b0:4864:20::b133])\n by smtp1.osuosl.org (Postfix) with ESMTPS id B33E184F75\n for ; Wed, 15 Apr 2026 01:48:10 +0000 (UTC)","by mail-yx1-xb133.google.com with SMTP id\n 956f58d0204a3-650789b22e3so7101441d50.1\n for ; Tue, 14 Apr 2026 18:48:10 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org C24BD42EC7","OpenDKIM Filter v2.11.0 smtp1.osuosl.org B33E184F75"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776217692;\n\tbh=37f+UWexUmjb2nKwNdsKiYaV71EelvYBwijtZJ1ZH4I=;\n\th=References:In-Reply-To:From:Date:To:Cc:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=S9tBe48geBt2t/8KHVj4HaE2stqARyilKyN671HLSGhyCbxY1xaI57xK77mNAMVMB\n\t 0jE9minzU+BJEbbPtqMxHYomTyFBujNFKStrtLMst14pbpcVJLv1FFxDhWglBte3Pq\n\t msEe3f/TyyVgMdfg0ENnt5NELqxPv2MtdKcqJVe6K8N5rpyCeXXX0fYhDoLKyOb558\n\t KI1Zm194DSv+MILDpDZYXzmIPGaW9CD3x6Naam/6kkcjUgYKjoursbD54Lrg7/uXdU\n\t 17KPjY5JzdiQPeTAwGSkcyBTFTPKyadVk3OPxzVD3faee8yN4mBKM/p3zMCWD3nLQU\n\t fjrgRs+s37zZg==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::b133; helo=mail-yx1-xb133.google.com;\n envelope-from=lgs201920130244@gmail.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org B33E184F75","ARC-Seal":"i=1; a=rsa-sha256; t=1776217689; cv=none;\n d=google.com; s=arc-20240605;\n b=KMOy0VUbJZYLIsVqwOzfZX9aiqWB8OjT+pfEaowHf/JmA/l77FPlPRDdBN5av/2DRU\n eWtQrs4t++MgN8DdSpjYFsw8zSKoXvRLWx29JiFBjjQy9Ea3KvjOYkjqlouA2QPDzXFS\n DjhiV7ERMgc3bmpS6jIXhIkzYAHcqjkY2Mn52aNI/ICfWEbypulgBC7vX0WEvtgGosCD\n fxMTddTlmy8OP5/gqHIHCCSlymdIGTKxeG2UkkOgGhrcxToqSKvh7wWz+61IxuA8Tjs+\n X0CGU5qj67NVcS4/MtxWYm41MG4z/1j0iLSgmL1lhuY47CS5ZPK6qmUaoDJLNk8BCCHC\n x5+g==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=37f+UWexUmjb2nKwNdsKiYaV71EelvYBwijtZJ1ZH4I=;\n fh=e4bTkvXBGAyUqScwiXtVy+PoJDAU3V5Y0TBaPVVGmkc=;\n b=OZYtOHVQFr++V5y/6fI9wqXzNOEAN/ZvalElFOmtU8uEZrgkMtYVe7kQ/J6ryrbvlr\n 4dmK+wHvXPIo3OsCQ382QYCtYaDuk0Lx4+wKwmFj8VoaFRXEQgdTnuHmIGiTHStxLESX\n h4eaBZXsPh3doTnI7n0RmGoh3qix63J+FLr1Rbfl4FTxpOfAVdJKPURdWjzz1YI/Ddrb\n xU4voBFZJ6HtT309hDMcLrY7m6V1Hz8lPoVWtTqY2k4iXYTIWBx+3gYsIthnbKZ51WGW\n BnDew6xybUajc5CfOGa/vGXLOzCXe+jres8cbBiO+1zZ4fErtV7yWt7LHfkAAKT9/0eb\n hD0w==; darn=lists.osuosl.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776217689; x=1776822489;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=37f+UWexUmjb2nKwNdsKiYaV71EelvYBwijtZJ1ZH4I=;\n b=cK5a6XmHIMQJemqAcNYJft9qStDNipc79j+5g6bQ3dtrpGF+lTCyjTgj9MC9msxLlh\n mhlO3cs+BsuRXWSQH+9R6MDRO9jbyxQSHH3IzOKeOpbPjxsKgMM8fKj2xKCEkGGuLh24\n wATBiZ6F2UQwQCTMZ51ZY+F8VWs1+0Ftm7HR8FH9omFDBVpgiM2wHgtaNz0zKTTEyyCn\n NjhZ5K8hzq8y1YDvMeOjS70GRJAdvRgKPoeK8rHBATGN8CMmKh7DmroPJHLl6b4HvqZT\n 3fNbWINxs4zwMTGTiIbomgqu62nR+ZgQE9tKoWh9ZQDhdCPfemoJZiKQjZW6x3dCjq66\n AoDQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9vcM0vJ3KJHLoMj6ZvSzLnxaSzaQH+LxwLRepFzVDvaCMzLJhKVGhznL7h/vpBOeWuBdeOnc0/TfHfb/yirPI=@lists.osuosl.org","X-Gm-Message-State":"AOJu0YyEfA9uiEE1z8r1FPReQtxsgW612tXDGSSwgqlhKN46TTbW299V\n 1CRheSWwoh13QN7CabTlRc0H8cnpV7uFDP8AHTdEIAGN5GJ81NqduU5kDx8F1VsAgTbQNruLs11\n TAZNzjXwmpyyCfxe9wR0jLvwstkJXawI=","X-Gm-Gg":"AeBDievJqQYpduPj+PWZngydhPfjIICsgTkldTBUMSun/pAyi7u6i0LbqIIkzNuArUW\n WnUHkEhjx1molptkdMqGftEqrqR565hwbHMHcGY39RsbI9KM5qxvUT9Rljq/+CUBBO/fXCFImW9\n cRWacfWLHBP3mOLS/Xe4v9UCa6bamDT9qMJ+IoxQIAsTB+dngc+4YiaGxYMD1uO8eeaYoqupQ/C\n rhI5rK/JVkrVtOz8NCBOkEXL0MaowdRJB856bvb41SYJQKFShLlqBT7QgS/BTYY/dK0FsReNe24\n XAaJ4JLTzBg5ZXNnt43jjRep96wvXnQ=","X-Received":"by 2002:a05:690e:c4e:b0:651:c203:4c47 with SMTP id\n 956f58d0204a3-651c203521emr12060568d50.35.1776217689415; Tue, 14 Apr 2026\n 18:48:09 -0700 (PDT)","MIME-Version":"1.0","References":"<20260413112030.2694563-1-lgs201920130244@gmail.com>\n <5da15f31-e9af-4f8d-82fd-eac29a6d98f6@intel.com>","In-Reply-To":"<5da15f31-e9af-4f8d-82fd-eac29a6d98f6@intel.com>","From":"Guangshuo Li ","Date":"Wed, 15 Apr 2026 09:47:50 +0800","X-Gm-Features":"AQROBzCCUNU9uahs4IXfUesDYaPErWVj8Mz6N5ygwqO9C1cJWWLC0UM8TIXIpcE","Message-ID":"\n ","To":"Jacob Keller ","Cc":"Tony Nguyen ,\n Przemek Kitszel ,\n Andrew Lunn ,\n \"David S. Miller\" , Eric Dumazet ,\n Jakub Kicinski , Paolo Abeni ,\n Joshua Hay ,\n Tatyana Nikolova ,\n Madhu Chittim ,\n intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org,\n Greg Kroah-Hartman ,\n stable@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776217689; x=1776822489; darn=lists.osuosl.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=37f+UWexUmjb2nKwNdsKiYaV71EelvYBwijtZJ1ZH4I=;\n b=reG4d1yYQcn7Mqerf42OWxMDjI4ij9d+nvGWkRVw4E79jOqc+mkVifvvch6VvE3F62\n JpTRZi2roGMy+jIjPVvAOtqhPKRVcwGsgnYUr/P9XUtsnYhqSv2hWJim4LJzNXKoB/a2\n 3GkA6yAMYzbHDEf+cLn5NEqVylqWk7GGige4KvdcJpMlCr1ao/Qpdzi/SeJmlquoWT/9\n MODQTgMdn2fTGx94KL/GEk3IUnOyBoqSMQIArv/mgob75VfCq4kxxLdy5o0YrBN2soAn\n /U4qk2sJK2F7cijFKhsBVhNXJMHOvHQ4nZMn1SX+41h/grAEndBY/Uy1YR+Y9IQdbu34\n rLwA==","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=gmail.com","smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.a=rsa-sha256 header.s=20251104 header.b=reG4d1yY"],"Subject":"Re: [Intel-wired-lan] [PATCH v2] dpf: fix UAF and double free in\n idpf_plug_vport_aux_dev() error path","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3677469,"web_url":"http://patchwork.ozlabs.org/comment/3677469/","msgid":"<143881d9-02d5-42be-bf77-9fe9e8353c06@intel.com>","list_archive_url":null,"date":"2026-04-15T05:37:35","subject":"Re: [Intel-wired-lan] [PATCH v2] dpf: fix UAF and double free in\n idpf_plug_vport_aux_dev() error path","submitter":{"id":9784,"url":"http://patchwork.ozlabs.org/api/people/9784/","name":"Jacob Keller","email":"jacob.e.keller@intel.com"},"content":"On 4/14/2026 6:47 PM, Guangshuo Li wrote:\n> Hi Jacob,\n> \n> Thanks for reviewing.\n> \n> On Wed, 15 Apr 2026 at 05:03, Jacob Keller wrote:\n>>\n>>\n>> This doesn't look right. The commit message analysis seems to match this\n>> fix from Greg KH:\n>>\n>> https://lore.kernel.org/intel-wired-lan/2026041432-tapestry-condition-22ff@gregkh/\n>>\n>> But the changes do not make any sense to me. It looks like a poorly done\n>> AI-generated \"fix\" which is not correct. Greg's version does look like\n>> it properly resolves this.\n>>\n>>> v2:\n>>> - note that the issue was identified by my static analysis tool\n>>> - and confirmed by manual review\n>>>\n>>\n>> What even is this change log?? I see that version was sent and everyone\n>> else was sane enough to just silently reject or ignore the v1...\n>>\n>>> drivers/net/ethernet/intel/idpf/idpf_idc.c | 6 +++++-\n>>> 1 file changed, 5 insertions(+), 1 deletion(-)\n>>>\n>>> diff --git a/drivers/net/ethernet/intel/idpf/idpf_idc.c b/drivers/net/ethernet/intel/idpf/idpf_idc.c\n>>> index 6dad0593f7f2..2a18907643fc 100644\n>>> --- a/drivers/net/ethernet/intel/idpf/idpf_idc.c\n>>> +++ b/drivers/net/ethernet/intel/idpf/idpf_idc.c\n>>> @@ -59,6 +59,7 @@ static int idpf_plug_vport_aux_dev(struct iidc_rdma_core_dev_info *cdev_info,\n>>> char name[IDPF_IDC_MAX_ADEV_NAME_LEN];\n>>> struct auxiliary_device *adev;\n>>> int ret;\n>>> + int adev_id;\n>>>\n>>\n>> You create a local variable here...\n>>\n>>> iadev = kzalloc(sizeof(*iadev), GFP_KERNEL);\n>>> if (!iadev)\n>>> @@ -74,11 +75,14 @@ static int idpf_plug_vport_aux_dev(struct iidc_rdma_core_dev_info *cdev_info,\n>>> goto err_ida_alloc;\n>>> }\n>>> adev->id = ret;\n>>> + adev->id = adev_id;\n>>\n>> adev_is is never initialized, so you assign a random garbage\n>> uninitialized value. This is obviously wrong and will lead to worse\n>> errors than the failed cleanup.\n>>\n>> I'm rejecting this patch in favor of the clearly appropriate fix from Greg.\n>>\n>>> adev->dev.release = idpf_vport_adev_release;\n>>> adev->dev.parent = &cdev_info->pdev->dev;\n>>> sprintf(name, \"%04x.rdma.vdev\", cdev_info->pdev->vendor);\n>>> adev->name = name;\n>>>\n>>> + /* iadev is owned by the auxiliary device */\n>>> + iadev = NULL;> ret = auxiliary_device_init(adev);\n>>> if (ret)\n>>> goto err_aux_dev_init;\n>>> @@ -92,7 +96,7 @@ static int idpf_plug_vport_aux_dev(struct iidc_rdma_core_dev_info *cdev_info,\n>>> err_aux_dev_add:\n>>> auxiliary_device_uninit(adev);\n>>> err_aux_dev_init:\n>>> - ida_free(&idpf_idc_ida, adev->id);\n>>> + ida_free(&idpf_idc_ida, adev_id);\n>>> err_ida_alloc:\n>>> vdev_info->adev = NULL;\n>>> kfree(iadev);\n>>\n> \n> You are right that the v2 patch as sent is incomplete. That was my\n> mistake when preparing/sending v2: it accidentally dropped the adev_id\n> = ret; assignment, which made that version incorrect.\n> \n> For reference, the original v1 patch is here:\n> \n> https://lkml.org/lkml/2026/3/21/421\n> \n> In v1, adev_id was assigned from ret before use, so I believe that\n> particular uninitialized-variable issue was introduced in the v2\n> posting.\n> \n> Sorry for the confusion caused by the broken v2 posting.\n\nNo problem. I had missed the other version, which explains my confusion.\nStill, to my eyes, the fix looks to be an equivalent fix as one\nsubmitted by GregKH:\n\nhttps://lore.kernel.org/intel-wired-lan/2026041116-retail-bagginess-250f@gregkh/\n\nDo you agree this is effectively a different fix for the same problem?\nOr is there really two different double-free issues here that both need\npatching? I haven't been able to fully convince my self either way, but\nI am leaning on this being one problem, and I think Gregs solution feels\nsimpler to understand.\n\nThanks,\nJake\n\n> \n> Thanks,\n> Guangshuo","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=DeiQYn8N;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwVKV1Yjnz1yCv\n\tfor ; Wed, 15 Apr 2026 15:37:49 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id AFFB06F6F6;\n\tWed, 15 Apr 2026 05:37:47 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id HUSp9CUI5-F0; Wed, 15 Apr 2026 05:37:46 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 9EA996F6F3;\n\tWed, 15 Apr 2026 05:37:46 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 6F519283\n for ; Wed, 15 Apr 2026 05:37:45 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 55195447BF\n for ; Wed, 15 Apr 2026 05:37:45 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id WSYXliSJ0rXs for ;\n Wed, 15 Apr 2026 05:37:44 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.13])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 4F30F44352\n for ; Wed, 15 Apr 2026 05:37:43 +0000 (UTC)","from fmviesa007.fm.intel.com ([10.60.135.147])\n by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Apr 2026 22:37:43 -0700","from orsmsx901.amr.corp.intel.com ([10.22.229.23])\n by fmviesa007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Apr 2026 22:37:43 -0700","from ORSMSX902.amr.corp.intel.com (10.22.229.24) by\n ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Tue, 14 Apr 2026 22:37:42 -0700","from ORSEDG901.ED.cps.intel.com (10.7.248.11) by\n ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Tue, 14 Apr 2026 22:37:42 -0700","from CH5PR02CU005.outbound.protection.outlook.com (40.107.200.52) by\n edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Tue, 14 Apr 2026 22:37:41 -0700","from DS0PR11MB7579.namprd11.prod.outlook.com (2603:10b6:8:14d::5) by\n DM4PR11MB6165.namprd11.prod.outlook.com (2603:10b6:8:ae::8) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9791.34; Wed, 15 Apr 2026 05:37:38 +0000","from DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e]) by DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e%5]) with mapi id 15.20.9818.014; Wed, 15 Apr 2026\n 05:37:38 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9EA996F6F3","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4F30F44352"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776231466;\n\tbh=8zDSG9nLNcI1lfOqvBjcDv4QXYxPuGsIQIASUpC4qqY=;\n\th=Date:To:CC:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=DeiQYn8NDfbL1NyDWUfJ4tmpgLSIX5rcmNdqTTtt8tVYMVP5fbCiSBZeIa2LwK8P0\n\t PcACo4SDFxM6wKU7HY1/M0bEj5THHV3PYgW4AaNaqlIQ776VGM5RL0O17uwyINcLru\n\t rMJFdg24SiV1Kfap0J+Aq3+1wGxbSda/zQtwuQmAzgLDT3Bglzw7vWldiEGugS3u1y\n\t PIAFlY5IYmrKSGKTKX65VD0z0Ue7S3j9ij1W/iGTAxc/W6COPbNY8+9p5k6rmmpsWt\n\t YjRpEJQLCbGJ5FZ/jZFvhYLaBqHpKfAVzu4L1kcqwceKffeWeDMplFi6ccoMRdnWT9\n\t Mp3FKnCxbPczg==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.13;\n helo=mgamail.intel.com; envelope-from=jacob.e.keller@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 4F30F44352","X-CSE-ConnectionGUID":["fUpvSLOqTfeUf/9VPOfxLA==","I6oQ9m/wRZy8v9wF/TjXbw=="],"X-CSE-MsgGUID":["gLzJbjh6Tge/035srLd2Yg==","M3V1HlQ6S5qQA1kGURwEZA=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11759\"; a=\"88278185\"","E=Sophos;i=\"6.23,179,1770624000\"; d=\"scan'208\";a=\"88278185\"","E=Sophos;i=\"6.23,179,1770624000\"; d=\"scan'208\";a=\"227128653\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=CLemUKm7MUiEiM0V9eZxIiG4sVj2tM0z+E7Uz/yNKDY3FgIhjZLV9fyylVaTARXEWHbsUtRTOAqX2QB6Qr7K2LCT2UIVXi+is1CYSZapWtrU1s4ZoEJm1esdnMba2SQkaR4ktNVF++rHdO602qoKJLbGZ62dVaumCp6dKDZh3OeHbF1jcvRLOP3FLbJw5+R55dAQdTg5qvafRhc7ejIbN78CO4PZe3n2fQFUxP+OPLxag/AT8/Gor7H4rjzR6t3Uc/1A00ZSV8vUQ0Dp+8K4oUjb0r+3GVnNjVb3eOJFSS6OdypAgmrm+D3p8ZsOPCklhdn37KorpLsAgfPfaKlYbA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=8zDSG9nLNcI1lfOqvBjcDv4QXYxPuGsIQIASUpC4qqY=;\n b=bLz/yk6+9ptoEi4wmdkGe0851EilHINYVyLt1Wd2eF/XgFBAQ2p12MlPxXH+lfHo5JA9/XqZTqvnsVkrJ2ki6L7Z1kq50ps3xs6OjTxZt5GKNxgeYaaXDCgvNoiX+hSO40rJJz0tLwd6pSSVH8kHgS6hH2eOYcT7G7p8YGYlafG02PtBtnWv10lfEtK784hqo3rqRKvOLZLPlp5je/BBpFaaFY9Tt5QUAfIB2+u3NpS4GtRQ9FQ+md7dCBCox8MDYGvyZs9cDL9oip1W/QYLGICG3+Lhcb5FTUvG7qC16fnQnkjGdP7epCXFU8iljsCm3kUuq2CQwbvJGc5Ra49c+g==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","Message-ID":"<143881d9-02d5-42be-bf77-9fe9e8353c06@intel.com>","Date":"Tue, 14 Apr 2026 22:37:35 -0700","User-Agent":"Mozilla Thunderbird","To":"Guangshuo Li ","CC":"Tony Nguyen , Przemek Kitszel\n , Andrew Lunn , \"David\n S. Miller\" , Eric Dumazet , \"Jakub\n Kicinski\" , Paolo Abeni , Joshua Hay\n , Tatyana Nikolova ,\n Madhu Chittim , ,\n , , Greg Kroah-Hartman\n , ","References":"<20260413112030.2694563-1-lgs201920130244@gmail.com>\n <5da15f31-e9af-4f8d-82fd-eac29a6d98f6@intel.com>\n ","Content-Language":"en-US","From":"Jacob Keller ","In-Reply-To":"\n ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"MW4PR03CA0008.namprd03.prod.outlook.com\n (2603:10b6:303:8f::13) To DS0PR11MB7579.namprd11.prod.outlook.com\n (2603:10b6:8:14d::5)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS0PR11MB7579:EE_|DM4PR11MB6165:EE_","X-MS-Office365-Filtering-Correlation-Id":"c516553c-d5aa-490c-030c-08de9ab11ae1","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|376014|1800799024|7416014|366016|18002099003|56012099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n bRvWixvwUCyTo/q/9+Uz25lMUR4fXUHvjdGlBq7a9gJGTKKcjbuBKe3kbvCUEbvADOm63J3EYysiWub0k+LLCEFBO66b0jNktk/tICKYS5YIlULkO0maOkDA/1RcDbUAWhk0af0MMwIwcYP8H+DpVU2lAk6k6lQgRbCZ8HSo0hq/xtMHPQFWZlk2dKxWdJGmJPPq5GGTZNHDOM9To5DCpRIs01QHLG8TX7WDLUhz7KgZakf+22jWfnfCg3RKsL9fVoRpg8WP0dIXXk4vnFPkCDon3MuNn0yibDIFx1q4rusYNhhTW3GPGQ/UpgCv0czH1o/oQM/DFcGE2VzkdTCnG+af5OBlsRuIAO7CmZNiIRMObEvVlm/nDJx6zf3Vh/2qc5cy0NoVNX/IaRiR6ERQV22EdHgtmBSpjH/8GxUZLxZCtyfw9FfMBIiJBsdIuZyuhZSdm5H5kBQO7CoSdH93ASJbN2wT1W9JppCNp7CZflVwKM/FvNJwYsB2Yw0a8FWdVVBGIay1pLIO45IWDUnH/Jbr2XmTm3rvMWF7KEqim/NlhMgHNgEdLm1f6fD8/RP9hB3Joi+H3Qa84Vpy9wx/JHA296/Hl+H05Qmza4I+3HO5rYMNRRnZ1g0N+OEqmnqgCS9wCPinxNDQVg7RKFSp7JwA/2BgYlGgDhmAsTcvSX51cYl6ttw1Bg/oIjg8qFLw","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DS0PR11MB7579.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(1800799024)(7416014)(366016)(18002099003)(56012099003)(22082099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?K6w12LsxO97Bj3c97tFUODSLDUrP?=\n\t=?utf-8?q?iIwJuUHWi9lEb/1BeMyy8DFJg4X16OVYkj1MBUJEIwqpOjs+RfwTHSLLlWgg5hSJD?=\n\t=?utf-8?q?3pIAHu11/OlZSswN7O4fL2t8rN6rdddmwNIo0HibnKCnOhQy/wMVe79ODbzCu7a2P?=\n\t=?utf-8?q?u4SmVqQyZMZwS/AqwB+bNaF9WhD7pAo2qPlbXk7GGSRMViGIR67gfsXd/NrB/KMBw?=\n\t=?utf-8?q?UlXM6047lgAAIhEVtfTHrkdob7+l8eEU0/9ft98FsI++gfRHM+eXuLbf7wp0jjtlU?=\n\t=?utf-8?q?FZ3Qcim5AX7J+cErDvbXqYt3K5q3yjfXtFPGMAWecgCwuNQkF3m2xnaN1QuQuT8kT?=\n\t=?utf-8?q?X8Kj9cCINA7KK9WNbDdCSYxCjdvZHcTvy4c4mdh7tsn2I+vY91XLMptpKQL4Qjhi+?=\n\t=?utf-8?q?vVlgPjEa06VFtG8LXCRvIIgdmkZNsLFq8jKC+4KQh7RjEckml4+IyDS8FEINOuwKZ?=\n\t=?utf-8?q?pV4HZ2FzNrDFOAU41+w9GrUR2MHVZ/3hk4XG7szRgyCeL3FaTK5fEQ90+oEcuiuZn?=\n\t=?utf-8?q?jMM51PjrJCnw0KWQ3KTwXjeF6mYeks35vPaVtmTesiPEyPwoi0OuqznSOmu86yYET?=\n\t=?utf-8?q?cRA9nHvxRt3F9lVBy4Mw1tJA1vN0zrk+ZZt4PLUuTyAFpKnM/aMhr1XIsLS2eY5gY?=\n\t=?utf-8?q?p+6vsH589hv2vG5p1i4OQk/8VPVua/lep35k1gabm79x9POf9y0hzEStGTGpWzTmq?=\n\t=?utf-8?q?lRqFz1GxGiwdorCz9bHGnh/ObbT9MPV9wudqULrvMWCTXlSmjTJhVnML+bfO45ME3?=\n\t=?utf-8?q?pcsqwcoPZWFesKdR+Oy0zaDu7Uuzt+09M+A7sa8QTX+wWf6i4lqeFzwOMv/tomLms?=\n\t=?utf-8?q?W2W6m/0aPF6nlnLJd5KqKnBiT5q1nQaweJbRP2aSEzA6pPGiqhVVOu2MkIUhCkTg8?=\n\t=?utf-8?q?yp/WtxCQXfNGE75Ocf0rgw063xnhpjJT1CLY7ItE7JeE8Stm/G07Fw2Hgab/Y36II?=\n\t=?utf-8?q?XQrOic27jlopKbwTb2a7m4kUS3vN6LXfTx3sQzC1+zJn8KNMQJXl3X8hSLxply8xk?=\n\t=?utf-8?q?wzc0knG2jslrm5onLhcmbBjQSeuIFVWmPyS5X3txURln2SdVikbcC9vywQ2/HhRSW?=\n\t=?utf-8?q?bm02PPW0s7sVZICXWNt9Huj2qcMmMvDVdCv0JRtGRfw88a5v1VSDrgZ/u4U+iRI6B?=\n\t=?utf-8?q?TG/XAd8HP4WeOFhERuq7DWGsILHQrWN3QVIJ8VnSBLfCpXewjo3psYdamC54gv3o2?=\n\t=?utf-8?q?HJc3bvBRM/8SZUyAQ1gQNo+dyB+vRgoU8zdwyfGc5sV+PVyii5oCQuACg9kqQATgh?=\n\t=?utf-8?q?jgStAASxvw/0iQl70jK70qJiFgZqj+oLrfuU1RmJZDTBXfp+zxixSBOwyTRulPHd7?=\n\t=?utf-8?q?fikv5F5s1P940jseUDK3EbIasn1E4K8XZzFrjZ07r9c++qjWi1Trm5YnFm4tiK+WF?=\n\t=?utf-8?q?Hc/GESKPuaRfeZYpptMGfrzfVXIpz5Rk1VFq6GiIxnpzYt7oLT3ZpM+Ug5nyAqHll?=\n\t=?utf-8?q?JPzKm5o1HBvRE2lWTJ/gd/+r3zs05IrjuieSq8L1xBryacnTFzeUCO4Lr3y2x/HW4?=\n\t=?utf-8?q?r40K9Ka2R+fmq6JQsyzvA+aKiKT5+/neH3l+hJESNfAjxn4zCA8yIQPVimqa5x0Dn?=\n\t=?utf-8?q?/5mOexm+YzH3F2q6b+voI0ncejgnaSlqUNznkWJKxltsa/ssIv1HsJ3hrJ5q/Ic5x?=\n\t=?utf-8?q?Xt7JG54BjrBHkkT+BRuCezecWfxosdDA=3D=3D?=","X-Exchange-RoutingPolicyChecked":"\n t9DiD0Uygu8XXll8UIxHZ3lrgyQdkGPDFBoHTpSdKA+1Lmckn2bQgoQstwG0umcs7VTF60CdyCpq8e5G/fI5nHuV+rfwRdIziH5Kr5d9xYt9Pq0K8C9gqBXAUSpnZYxnrmbMTbS2V+5Dg9dJTJPXWF4mReMr2/bdNldXDuWF9MIiUh+Db7IOuOhiOWnrW2iUEkBvv1ThDkdx4kp40hit0U7kb3zcd1v8TwlIDhVxM6Npu54W/WfYXNKc6Dy31uIwSJDb2/kVfN2153ryxnpMECZ0LIL8Nz5Irf3icwCieSSytG9F7JzljANzNRc/HPZMibRQ7I2o3vo3CSycoRZ/qQ==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n c516553c-d5aa-490c-030c-08de9ab11ae1","X-MS-Exchange-CrossTenant-AuthSource":"DS0PR11MB7579.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"15 Apr 2026 05:37:38.5738 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n 5Dz7dExczYf2AaMAlTLYqeB2Enx+7e9v4Qhkye2DHSjA3/u2/G+LbVPHaeRjnymuyC6IMJFY223eLrA+0L8AmgYjZEy8CJjSLMNDPZdggu0=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DM4PR11MB6165","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776231464; x=1807767464;\n h=message-id:date:subject:to:cc:references:from:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=FnFUR3OLejkPf7awXM9eia4WuNBl1W5um2jrCCW6mPc=;\n b=ef7teomWk5v1b7FkQoFGtLP8qQf8aeWVlmCKxD/pcjwf5gqScpf8wMzO\n c4dUFLnUFNs91p1bkELBv0HvyEY8qLxPsotznAEE5+xkmup6a7vIR3jeY\n OWYpS7foxWb9xHF7dvg2ndWE5bt2mLVce98nK82A39Jv69qLXjD9V5bBu\n X9wUjjWg+cnsbfsCsWJuO1H9urqz2xE7cVBP2JnX0BPj+4ymMoeZM0z3f\n 475oJEyVoUTsHHXyYamh5BYd/VQDvR1pMSBLfxTX5EN0CpWbMcuThv/79\n /4oQ8ufPd7WnwheIAlxJsMiibnW/SLDYqc3eyCNJPheNfcnzboYEyIr5w\n w==;","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=ef7teomW","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH v2] dpf: fix UAF and double free in\n idpf_plug_vport_aux_dev() error path","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3677479,"web_url":"http://patchwork.ozlabs.org/comment/3677479/","msgid":"","list_archive_url":null,"date":"2026-04-15T06:33:16","subject":"Re: [Intel-wired-lan] [PATCH v2] dpf: fix UAF and double free in\n idpf_plug_vport_aux_dev() error path","submitter":{"id":91722,"url":"http://patchwork.ozlabs.org/api/people/91722/","name":"Guangshuo Li","email":"lgs201920130244@gmail.com"},"content":"Hi Jacob,\n\nThanks for reviewing.\n\nOn Wed, 15 Apr 2026 at 13:37, Jacob Keller wrote:\n>\n> No problem. I had missed the other version, which explains my confusion.\n> Still, to my eyes, the fix looks to be an equivalent fix as one\n> submitted by GregKH:\n>\n> https://lore.kernel.org/intel-wired-lan/2026041116-retail-bagginess-250f@gregkh/\n>\n> Do you agree this is effectively a different fix for the same problem?\n> Or is there really two different double-free issues here that both need\n> patching? I haven't been able to fully convince my self either way, but\n> I am leaning on this being one problem, and I think Gregs solution feels\n> simpler to understand.\n>\n> Thanks,\n> Jake\n>\n> >\n> > Thanks,\n> > Guangshuo\n>\nYes, I agree Greg's patch addresses the same underlying issue.\n\nFor the other path in `idpf_plug_core_aux_dev()`, I had also\npreviously sent a fix, for reference:\n\nv1:\nhttps://lkml.org/lkml/2026/3/18/1822\n\nv2:\nhttps://lkml.org/lkml/2026/3/19/1285\n\nThe v2 for the core path was posted after discussion on the list and\nincorporated the feedback I received there.\n\nSo my understanding is that Greg's patch covers the same class of\nissue in both places, while I had sent them as separate fixes.\n\nThanks,\nGuangshuo","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=Ns2U/cid;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwWYt69rQz1yDF\n\tfor ; Wed, 15 Apr 2026 16:33:36 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id B68A246F1F;\n\tWed, 15 Apr 2026 06:33:34 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 0bXALpM-pkIq; Wed, 15 Apr 2026 06:33:32 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 8048946E3A;\n\tWed, 15 Apr 2026 06:33:32 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 7F547237\n for ; Wed, 15 Apr 2026 06:33:31 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 718D846E3A\n for ; Wed, 15 Apr 2026 06:33:31 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id r92fcv5u_CpM for ;\n Wed, 15 Apr 2026 06:33:30 +0000 (UTC)","from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com\n [IPv6:2607:f8b0:4864:20::112d])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 9925A46D76\n for ; Wed, 15 Apr 2026 06:33:30 +0000 (UTC)","by mail-yw1-x112d.google.com with SMTP id\n 00721157ae682-79a2ee65171so82180127b3.2\n for ; Tue, 14 Apr 2026 23:33:30 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 8048946E3A","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9925A46D76"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776234812;\n\tbh=I/YGk6diE6DwfvFh1WTj1ikmEooEeeXvUwgqkLXnYMI=;\n\th=References:In-Reply-To:From:Date:To:Cc:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=Ns2U/cidrX5spoN2LoNHc1Um+0cUpmbpvaJTUPzQ6i9czcOrXuSUKm67AR0lqHwJX\n\t VUcVIPOvGKTIFAsLUZGeG71khe58D3WsAjnCyJ8KflsFAl7VAuMQ5mLlCxcL4V2Png\n\t kY3S2EIK029P0xef/3I7crGoSrLz6TbxHe8/QRGdQMdsrzJorafOgFA56xK5YeK9U8\n\t pzUL3D7PSUqezaIfNX9xG9jzVrr0G6yfwdf8bgNlsxc+kVUxFV6aKPTmmszgWhY0iK\n\t foRMVJSNKTYrbizFL9arYGF9wyrhAd9rbII1nCdUaa3Ys4mCzhmkQ2BmgOavS90+2M\n\t PqXl77qZ8jLzg==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::112d; helo=mail-yw1-x112d.google.com;\n envelope-from=lgs201920130244@gmail.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 9925A46D76","ARC-Seal":"i=1; a=rsa-sha256; t=1776234809; cv=none;\n d=google.com; s=arc-20240605;\n b=kkqU6izo6tyeRBdeQARRNPcEC8WhlAfrF+NMvyDJo5Ubn32m+NOrudnTUAr02IEe2O\n AIQa5OyQgDL4d5nRvsymIJ1tLnuwC9pqly4IkyDWOaIe2VVp/IqgZh9DvaBlAOChRlpz\n Kt2O78CShcr3ONlYuqYF/WFGucg6icoI3FT6CSgWaupAUqDp2Xb459VjX8daR0ecgozh\n y5MZ5918+Bwwod4XtwxVoWH/v/sfYj9pIuZ+sMuJx+fogjTszqrW8h5gFNRF6Y2q3EBs\n UHkP1WaNusQaYleMml9rRk5QKAtKJevEqDIlV/982kyqafflNO2D9mSO5IrarjWvmf9Q\n Uw0A==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=I/YGk6diE6DwfvFh1WTj1ikmEooEeeXvUwgqkLXnYMI=;\n fh=jGdmTWXC61bbSDQjU9EKqXPWJ2N1ELzlytsEVhxHf/A=;\n b=GBauUw5pvywdBDP1YjOiQ5085UoTnSg4FASbk/QwYDswTPF8DH1aW3Oa9Id/cu3A6E\n Vx9HhLaLPhN+H2mVzVBtCjYZWkKLryXo2TZNvv8WkxKndI23XOCpiFZAFuBKgrNJD+fp\n tW/RUgBWcHUfWjQ0TuqLF6KjZfILfXjgSlg9Up2Wi3PpSwUCxMKpQMoTu29Sbvdn3eeC\n mEvFrIPU6ZMqBNmiAaJFLto7ZcF2Qse1XqAW4qS2DkyqLeU5Xk7dPaB6PsXrqYO50J80\n QU5D98e76BrldpWoSEPyZNLpcEmtIgZ/LopDinOhdQHDRGIuCj6fvgbE7j8xJ4o3ZhuR\n aP4w==; darn=lists.osuosl.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776234809; x=1776839609;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=I/YGk6diE6DwfvFh1WTj1ikmEooEeeXvUwgqkLXnYMI=;\n b=tKhA5XaXn+lNF16TW/eBE0IWftQ2fO9lgo3rzBwNmk2B/O8d4OEecSIgag3FZ/FXjJ\n 6DLDMebZhadnAVK7oaVunXcRvb7nhXee/jWT45UAxYyYA9hcnYbo0h4+kt6Le8WMifBA\n WpKZBQOchVtrdnlgBC7VLv0K58moyuwFz8SqRjSv2Spy5xx8FMuHqnKLDLbgW4woTHbP\n pPwJLLIdod7jZMGTM5H1hh7LAx2k8oROWVrlZ7tMsxLbphZxtYXzvay2MdDNQJDXic7n\n OM7IzmM51RucGgjs9C13wkRpZMsiKpuo+SMSV2lcyWp8bAuRoE7xtIjPSRhSrvgt706P\n 9iRA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/OQXpJ1pemkBEx07wkrxYFtZEYCoajI684/v47JEx82oJO1YwiwqFwi0VFw12srpfkeA6XKAYseqW9l4k9uh4=@lists.osuosl.org","X-Gm-Message-State":"AOJu0YzJD/5ApnD4CWrSxVaq7rta3Xvd9BuyH67e2iB5QTuPHEejtVT8\n IzWJExg2kpjWAF7b/EpXxeSu0+fFFHhaU6LC4G/Yh9sc6/vF1oHSsodoA2P0CZDrL8SV5bc0Gq3\n gvjFE23DAU1/xppg8yoGANQNQis41SpQ=","X-Gm-Gg":"AeBDietzTrD9fuBiiCZ60VjYfuwh2Asmc0j8XrRHvF0WMj777ids6uJXYWhsNGyXLXw\n 031RRoP/nOHYdMaZR3xaFjMfIdhKV8U9wqrTf0tm4o7SEYK/Us2BjEjTCuYXJ71I6lzbiGV2Go9\n 4W7zcJFeCOPnkHqQL/2MfvvdPKXUVgINshk7/DfcfLhZcINi9FtITLl+sdZIk3wFV3zJuxH6+Kf\n 0mVDKEx7Fql7GF/l2CrtW3xPxnNx1ceq7FGugTQ0gP+FMBModJ9TbB8NHaAJ4bTW3IQ6Oofo8lg\n tlFDOaLch+lyF0fmxPT665Xtyfbt","X-Received":"by 2002:a05:690e:14ca:b0:652:ddea:11f1 with SMTP id\n 956f58d0204a3-652ddea24a2mr2317961d50.30.1776234809273; Tue, 14 Apr 2026\n 23:33:29 -0700 (PDT)","MIME-Version":"1.0","References":"<20260413112030.2694563-1-lgs201920130244@gmail.com>\n <5da15f31-e9af-4f8d-82fd-eac29a6d98f6@intel.com>\n \n <143881d9-02d5-42be-bf77-9fe9e8353c06@intel.com>","In-Reply-To":"<143881d9-02d5-42be-bf77-9fe9e8353c06@intel.com>","From":"Guangshuo Li ","Date":"Wed, 15 Apr 2026 14:33:16 +0800","X-Gm-Features":"AQROBzB0J22GUf7_6jCosTMhAtK8yiANwxMUFPDIVG2xrZyTeQWs76gB0isBNRQ","Message-ID":"\n ","To":"Jacob Keller ","Cc":"Tony Nguyen ,\n Przemek Kitszel ,\n Andrew Lunn ,\n \"David S. Miller\" , Eric Dumazet ,\n Jakub Kicinski , Paolo Abeni ,\n Joshua Hay ,\n Tatyana Nikolova ,\n Madhu Chittim ,\n intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org,\n Greg Kroah-Hartman ,\n stable@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776234809; x=1776839609; darn=lists.osuosl.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=I/YGk6diE6DwfvFh1WTj1ikmEooEeeXvUwgqkLXnYMI=;\n b=SmshSWcSiJ8TVoqVRXMIkiiwO7DBMF8+StoXK6V7bomx5Fvatm+TN2k2mwBflwFbnH\n Y4CEmoq/gzCEGS6GbXP6TJokhAMYRw+cr6dxNzkRRurBHIHvypztbEDRMXzNsCm6b2A0\n AqkEwFSk93PNFfArv4e1EpifzKFk4UO4LOqLm/Hul2a+3PzYHQLCPNhkrTsaTZUJkzki\n JjsyUj/txF584Rme3uZ+JNlqtINbx4F0w5FSv9Vy+Xx94qtV4v+q7Za1woJv6rtPJlNz\n R/sIQdsSihUzBQOXd8YPvSVmVGhldo+nugbSo7u9fcG4n1WLZRbCypOpi23fVIu9/gh0\n vR7A==","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=gmail.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=SmshSWcS"],"Subject":"Re: [Intel-wired-lan] [PATCH v2] dpf: fix UAF and double free in\n idpf_plug_vport_aux_dev() error path","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]