[{"id":3676817,"web_url":"http://patchwork.ozlabs.org/comment/3676817/","msgid":"","list_archive_url":null,"date":"2026-04-13T15:03:25","subject":"Re: [PATCH v4 4/6] virtio: cmd: Depend on VIRTIO_BLK","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 2026-04-13T09:22:34, Daniel Palmer wrote:\n> virtio: cmd: Depend on VIRTIO_BLK\n>\n> The virtio command is calling virtio blk functions but currently\n> depends on CONFIG_VIRTIO only. This means disabling CONFIG_VIRTIO_BLK\n> causes the final link to fail.\n>\n> Since CONFIG_VIRTIO_BLK depends on CONFIG_VIRTIO switch to depending\n> on just CONFIG_VIRTIO_BLK\n>\n> Signed-off-by: Daniel Palmer \n>\n> cmd/Kconfig | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=mQqpWEMm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"mQqpWEMm\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvVzW5sLvz1yDF\n\tfor ; Tue, 14 Apr 2026 01:03:51 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 0DA7883DC9;\n\tMon, 13 Apr 2026 17:03:49 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 1CFF8839D5; Mon, 13 Apr 2026 17:03:48 +0200 (CEST)","from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com\n [IPv6:2607:f8b0:4864:20::42d])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id A09F3839D5\n for ; Mon, 13 Apr 2026 17:03:45 +0200 (CEST)","by mail-pf1-x42d.google.com with SMTP id\n d2e1a72fcca58-82f22ec4501so774553b3a.0\n for ; Mon, 13 Apr 2026 08:03:45 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776092624; cv=none;\n d=google.com; s=arc-20240605;\n b=afda+IDr1IiTCbhYSCQiA3jkAZlKVcH1uaJnVOulvu8W3WBM3l9d9HIrS1u7BIU3qK\n szMS78TbT5l8LGe6OwUdF9c1QQoXrW6ctyRg22r1ue8N2F7LEDDYnVPTtDRh63eZs0wN\n buatObcSFscxCS39ujvjhIeJl/+IVOZh+w9ehtxMHtmT45aJrVFL/wS+nny0vzxXLb3a\n +BUJrNC1v9K3P/iBBGHcqK25v+BOm6kGxo23g/5vM54wKUsO+5XKkBIr43owdTDibgAR\n RDHkPo3XdL3C6JU7OGSTTDqehC/xIsWs+Vybv3Bv3OhcHvQFLLBU7xwuAPzsgtj+09K4\n aGbg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=5gbOlESjYBS+cHxUT+Nf5GjE/th44PvB8VJjnh086Bk=;\n fh=COzWXKRY3hNFOd79u2uwJyzfoPBPX/816DBFSpwBslw=;\n b=WdHYw7Jj0Dbtax4ttQYnhxDckVqw1BxBg1aggBX6RbycOIh0jglzGZJRbY8/YQEEiu\n MpMZiXv1+SdecVh36ARNIzEms5jMZVKL+ouM+uiHSjY+5Ykw1fdtlu0hEM3wgxZCnn77\n yBimnDGeuWJJlMqxj8N1GKjagPBOYnIptTUW8HvsrOmoku1IHOT/joL5bH19CFO1v1E+\n 102I8BFemQfi+VDfHS3oqZfMq6sMdfkcTkzoP9W14dQg7d/A59jHzrS9RRcSvQJ1BBxB\n 1XHkEdXdPQnzyDi2nbwFiToI2xp9ISJc/7BefE7qyUm9gMEWojF3QuG9/Q060VvUQuJH\n jlXw==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776092624; x=1776697424; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=5gbOlESjYBS+cHxUT+Nf5GjE/th44PvB8VJjnh086Bk=;\n b=mQqpWEMmv0V7RMh+VKk251f0ITY4A/Cckhh11HbcVX5iCJ2liCeaDwCLW6LQleUmAc\n BBBBssNlDxvhy9kqN86dbIQngh7rdFtpjulMEQHMyrLHt/vlubWGYrqJDL/RQVaKOV9U\n QNED0S2z2AQYlwNz2QulSMdHoTSS8nIPmmILw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776092624; x=1776697424;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=5gbOlESjYBS+cHxUT+Nf5GjE/th44PvB8VJjnh086Bk=;\n b=Sl3yszIJrPzeIRddtRhgIhh08CIkG6Jmj5HMyfHaFho9ejZaaScWKWl1fwcqbwtgP9\n jHO4axBzQ5UCF4SB0KLolrR0DfUiSMq5p2Ej5RfIlNlHA3nVPCPkjb0Li8rEcV5+RHXA\n nVLhN3089lVQqfXABhtQkEiuB5YyrlDoY5h2GvNVsNALf5YIhJJ4DgOigWg7zLfPQjC3\n FfCDHVupwkzKXtxSqFIuUMklHjIp5w5Yv4ilUvaKbni0HcbgNEMzgIvYcIWWLChCeYVb\n rVBskL2WpNVrta0/fi2u7+YJLRtPGoxIKuoiJnmj7Omr3ovyvlJt/aNDaEGFe3WzBg10\n I+NQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9Y7EwO2+C6W4odsJYspnUeNBTYiFen1TF3xOWLGGHp9K7Iu6tiy9KX4+biCocpoIUb89IbQHY=@lists.denx.de","X-Gm-Message-State":"AOJu0YzqKcSjrecDo7N8xtdcCX3Qb66cW2YQWndh4zc5wJmG/Os0fqsy\n NrnxMrE1GV4+Qd9vRrBkRSNNuUEYxXjwBRAv6v6tDiZiWAIIGnK4p6Y4fwwSp2fTJwqSQKpADfk\n 5HG+kqPAUnHw0kv1mtabzezfyuWj2yiWNLlJh9aoh","X-Gm-Gg":"AeBDiesq4k6HclbsV+Qj8gaaUeWE25k6ZS5VYMbr0njayBaYvhY4f/Bi9Q1WD40xfMz\n jKgqxV0eA7jDU4NURJ9F7evwqedECblYioShz8+PhlMZPj2Fj7FnxC5lRHh5pPQUxvRhPGF1HPd\n XcWZIJvl29t5Z/9E4T8vs/7L5KEcG69W5Lr0e2iUHVDT7N9gKSBa7vL3ZD8pN2Q5NMAKQJhZxbJ\n 4/HeRyCuyH2nfK06jlkU2NuGE7iGL+jhYIZi0EJQNGUBdO33qsPystVlAjmql1DBLB5TW27aBD9\n 2Z5Z5g==","X-Received":"by 2002:a05:6a00:4511:b0:82c:d7c4:4c69 with SMTP id\n d2e1a72fcca58-82f0c25e146mr11883468b3a.3.1776092623839; Mon, 13 Apr 2026\n 08:03:43 -0700 (PDT)","MIME-Version":"1.0","References":"<20260413092240.3719260-1-daniel@thingy.jp>\n <20260413092240.3719260-5-daniel@thingy.jp>","In-Reply-To":"<20260413092240.3719260-5-daniel@thingy.jp>","From":"Simon Glass ","Date":"Mon, 13 Apr 2026 09:03:25 -0600","X-Gm-Features":"AQROBzCdNO7LoMa0H2MQVbm4_i9DjmMe2ewvaCXnUAegHFFLmvYV5DKpayA2LAE","Message-ID":"\n ","Subject":"Re: [PATCH v4 4/6] virtio: cmd: Depend on VIRTIO_BLK","To":"daniel@thingy.jp","Cc":"visitorckw@gmail.com, angelo@kernel-space.org, bmeng.cn@gmail.com,\n sjg@chromium.org, u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3677370,"web_url":"http://patchwork.ozlabs.org/comment/3677370/","msgid":"<20260414192300.GN41863@bill-the-cat>","list_archive_url":null,"date":"2026-04-14T19:23:00","subject":"Re: [PATCH v4 4/6] virtio: cmd: Depend on VIRTIO_BLK","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Mon, Apr 13, 2026 at 06:22:38PM +0900, Daniel Palmer wrote:\n\n> The virtio command is calling virtio blk functions but currently\n> depends on CONFIG_VIRTIO only. This means disabling CONFIG_VIRTIO_BLK\n> causes the final link to fail.\n> \n> Since CONFIG_VIRTIO_BLK depends on CONFIG_VIRTIO switch to depending\n> on just CONFIG_VIRTIO_BLK\n> \n> Signed-off-by: Daniel Palmer \n\nReviewed-by: Tom Rini ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256\n header.s=google header.b=MJ3/U+Ad;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com\n header.b=\"MJ3/U+Ad\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com","phobos.denx.de;\n spf=pass smtp.mailfrom=trini@konsulko.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwDhK2J9vz1yCv\n\tfor ; Wed, 15 Apr 2026 05:23:12 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 05C6E841CD;\n\tTue, 14 Apr 2026 21:23:10 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 1B2868421E; Tue, 14 Apr 2026 21:23:09 +0200 (CEST)","from mail-ot1-x330.google.com (mail-ot1-x330.google.com\n [IPv6:2607:f8b0:4864:20::330])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E3E4680086\n for ; Tue, 14 Apr 2026 21:23:05 +0200 (CEST)","by mail-ot1-x330.google.com with SMTP id\n 46e09a7af769-7dbb6c072f1so5513814a34.2\n for ; Tue, 14 Apr 2026 12:23:05 -0700 (PDT)","from bill-the-cat (fixed-189-203-106-235.totalplay.net.\n [189.203.106.235]) by smtp.gmail.com with ESMTPSA id\n 46e09a7af769-7dc3959099fsm8680484a34.9.2026.04.14.12.23.02\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 14 Apr 2026 12:23:02 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=konsulko.com; s=google; t=1776194584; x=1776799384; darn=lists.denx.de;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=/Snp4KJmF4JmJdmdPscmWpvyS6Wd5mT9ZExYJ1soyMU=;\n b=MJ3/U+AdoJQ4H6Pa01vWETF28IQPCZTD1DUtf8OlpzERXsg7VeIdb8IStcZp41Z5SW\n SDIlqEFPsANZX4CpVwZ7AAORgdZ9XQI/bQovHttRC/QQ1JteM47nAym2N7zM4sI/89bU\n PqzXScY3Vl4AuhmWqovFkW+YPu6bPEbtT9KXQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776194584; x=1776799384;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=/Snp4KJmF4JmJdmdPscmWpvyS6Wd5mT9ZExYJ1soyMU=;\n b=GNfs94IXqTJhV1iW3vYNinBVIF7xn0zX1mtQqlcU15dsemlQFocZxCkqnA05GFUPwr\n 8QCWic7BSL3J7g7hk797q+ut9s4hhyZxGvPQGjgPndiUaw0DkbD//3GsSBrFXqWvXuwK\n QDBkGr2IwHDdDXpbhzALOY2EPYKdN05+tf07QnAm0Z4jHpmFkqpPdkHNyu5ED92/mRIG\n ot2XJZAWM/J4U7F+hygYlZl30AXVMMbbnwcQC21OVztliYeU1oSbrcyZQh56bZ/jPP7M\n vj9w214sYgpwNR7sMdk8INH425Jo5hGhO6NmrJ1VFT9aTmzFfc3xZQcNzYtz9Vk8jvcV\n r4aQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/7qlPAflZCD10ML+dfTX2XLvb6ZWpREWAiq5foyV5zj9FiSU2bWc6Xos+iTRZSd3jmLX1QLE8=@lists.denx.de","X-Gm-Message-State":"AOJu0Yx8GSvJ9ndxK6+7f3++ujPc872QUi9eKcHjMXR3/djoFMA4w2Ai\n LMkmb9SUDBAI0XutaYnu/pQICaXWn3suPPEYZ1COtLg+O+5UOnY7sl4/36glafX0Iv8=","X-Gm-Gg":"AeBDieuaYV/5ZmX7o9U9xKNBuaBJvZYQfBNl87ZUZ05FL21gROaoGE21acYtF7IBVsV\n Bi840j/+eteSYImtHyu3+dILZuhZ6sWgrZlWctv56Xjmbsx+50dLr5acG8OUJf8ciV7a572tECy\n CNKysSVb7cbLgwrKyTAmdM24QoFWS3kxX69B3VlxN2KqrR5t+02X+mUZCZnCedU2pC4kA+wTFG/\n imKF1v8Bm6t2H9jL0tJ4izqLGV9PJyW2b5mi/z/ZZHKubDSfmpxMlDSn84OJ7lEaX7xoy59VY6u\n kmX3xcvclGL4w5sCASzu6WcXfstTSa3FyGwvbzfcgUBA1qLdlUNz/y3eTVDX86vCVygR4wXTLqs\n WbFUa8OUAeAfSXo5m9Izq2KByhGRE6bWW3Ko1cfppmEGylp3XriPVUm5R2GNvey3X/ui1/cMfQA\n TRSVbXnI7/fho+OPEqBQDYi8I/Se7y4V7Oj0ieBxn+d3+AZ5C3V1WrUsJaARxUL5rQ0r4JPZs7G\n bI7zuUHV9p1U+rviHmmoYK0P2XYH0ccPtYkpEiYMaLoEZ2ghlxF6QiLt+aw3w==","X-Received":"by 2002:a05:6830:358e:b0:7d7:fbe5:e9be with SMTP id\n 46e09a7af769-7dc27e0f792mr11853395a34.20.1776194583543;\n Tue, 14 Apr 2026 12:23:03 -0700 (PDT)","Date":"Tue, 14 Apr 2026 13:23:00 -0600","From":"Tom Rini ","To":"Daniel Palmer ","Cc":"visitorckw@gmail.com, angelo@kernel-space.org, bmeng.cn@gmail.com,\n sjg@chromium.org, u-boot@lists.denx.de","Subject":"Re: [PATCH v4 4/6] virtio: cmd: Depend on VIRTIO_BLK","Message-ID":"<20260414192300.GN41863@bill-the-cat>","References":"<20260413092240.3719260-1-daniel@thingy.jp>\n <20260413092240.3719260-5-daniel@thingy.jp>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n protocol=\"application/pgp-signature\"; boundary=\"AmbPdUT/rinLToVr\"","Content-Disposition":"inline","In-Reply-To":"<20260413092240.3719260-5-daniel@thingy.jp>","X-Clacks-Overhead":"GNU Terry Pratchett","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]