[{"id":3676597,"web_url":"http://patchwork.ozlabs.org/comment/3676597/","msgid":"","list_archive_url":null,"date":"2026-04-13T09:33:17","subject":"Re: [PATCH for-11.0] accel/kvm: return early from kvm_irqchip_create\n if kvm does not support irqchip","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On Mon, 13 Apr 2026 at 10:01, Ani Sinha wrote:\n>\n> During refactoring of kvm_irqchip_create(), the refactored code was returning\n> early from do_kvm_irqchip_create() function if the required capabilities were\n> not present in KVM. This was not translating to an early return from\n> kvm_irqchip_create() as was the case before refactoring. This is because,\n> do_kvm_irqchip_create() did not have a means to notify the caller of the lack\n> of kvm capabilities. Fix this by making do_notify_irqchip_create() return\n> EOPNOTSUPP error when required capabilities are absent and then the caller\n> can check the return code and return early.\n>\n> Fixes: 98884e0cc1 (\"accel/kvm: add changes required to support KVM VM file descriptor change\")\n> Reported-by: Misbah Anjum N \n> Reported-by: Gautam Menghani \n> Suggested-by: Fabiano Rosas \n> Suggested-by: Harsh Prateek Bora \n> Signed-off-by: Ani Sinha \n> ---\n> accel/kvm/kvm-all.c | 11 ++++++++---\n> 1 file changed, 8 insertions(+), 3 deletions(-)\n>\n> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c\n> index 774499d34f..92af42503b 100644\n> --- a/accel/kvm/kvm-all.c\n> +++ b/accel/kvm/kvm-all.c\n> @@ -2575,7 +2575,7 @@ void kvm_irqchip_set_qemuirq_gsi(KVMState *s, qemu_irq irq, int gsi)\n> g_hash_table_insert(s->gsimap, irq, GINT_TO_POINTER(gsi));\n> }\n>\n> -static void do_kvm_irqchip_create(KVMState *s)\n> +static int do_kvm_irqchip_create(KVMState *s)\n> {\n> int ret;\n> if (kvm_check_extension(s, KVM_CAP_IRQCHIP)) {\n> @@ -2587,7 +2587,7 @@ static void do_kvm_irqchip_create(KVMState *s)\n> exit(1);\n> }\n> } else {\n> - return;\n> + return -EOPNOTSUPP;\n> }\n>\n> if (kvm_check_extension(s, KVM_CAP_IRQFD) <= 0) {\n\nThis function confuses me. With this patch it can do three things:\n * report an error and exit(1)\n * return success\n * return a failure code\n\nWhat is the difference between the cases where we exit and\nwhere we return the error code? The commit message says we\nreturn an error \"when required capabilities are absent\", but\nwe do the error-exit for e.g. \"KVM_CAP_IRQFD not present\", which\nsounds like \"required capabilities are absent\" to me...\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=fuS8rQ6x;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvMgc2VwFz1yDG\n\tfor ; Mon, 13 Apr 2026 19:34:35 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCDfo-0007CB-2f; Mon, 13 Apr 2026 05:33:40 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCDfk-0007Ba-Mc\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 05:33:37 -0400","from mail-yx1-xb136.google.com ([2607:f8b0:4864:20::b136])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wCDff-0005Xq-H1\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 05:33:36 -0400","by mail-yx1-xb136.google.com with SMTP id\n 956f58d0204a3-651cfaa21e6so450573d50.0\n for ; Mon, 13 Apr 2026 02:33:30 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1776072810; cv=none;\n d=google.com; s=arc-20240605;\n b=cJy0Me9qIYcm6bqfr/QOkfjLPAwGudZF32JDqVyzktlhsNwwIx/mfwA2Ktgx/WyN9N\n oNjr5msR4d9yQkgwTAiKokgxJFeNUailss/EVJgAmA06s9ySbSuoo3UExtPZiUZp0NO8\n ODyvvOn/oiTDZjIihTAn9rB1Tpro1O0sZdX6qrdTupK/Uf99nVPU40kMC6LOAfRqzqab\n 51YDgG0XahxwN6QZmjGdRXOzxtkyqUlm/mbucx8Jg0APfFzwJK2dwnqa5cNnb3EbD4ln\n n4mRVYr3hnCd3Rc/0miST3DOPlNTyFKR8SsDT52YXnoqH945vYZ7XD55nmxnx7GCjqiZ\n 5Fqg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=0XI9DbHYUkGehlX0OcWQ888vFtJXew82enKuyuQHRk0=;\n fh=q+92S+8ZWXLl9eg/tdbobV+jDbNbyjbR8mwSpqPZ/ZE=;\n b=TOOGvRs2N0EwU+RQLCGl+Eyh4D8/L832tw73vb/9yt+c66AIOB0d7etCuv6pfzpfBo\n J/pIb62i2TRy3IxS9QCnS4Bs0THpT13uDABKv8t0qaTJ5nb1nCFnNTKuKhAkG14d4Chi\n JBOq3gEsk56yOfZjlnBeiBl/urqJjdNVFFbtrhoq2r1yDLUO3ZI1lgaXeFHN7InYBSQB\n stDMDVNsAt0q7EX7z6U8ioCmOu0xXP62NVEpbuoXdi7D8VOZey7OXJrCRaGxq3sf+1fc\n cPc8sJgjV+sBxdPZ/WbmNuN9r2XAGR9uV2puLMJemT2UzwhMljkx7xLwlYR5j2f3V/63\n Y1DQ==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776072810; x=1776677610; darn=nongnu.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=0XI9DbHYUkGehlX0OcWQ888vFtJXew82enKuyuQHRk0=;\n b=fuS8rQ6xH4QSaZb0dK2pZoGjVLM1ZJnvnwWsNtA0pQqMn5kLOyRQwc2OTa4zlcuqen\n N6VF+KZDQUVg8lXrOHVTIO5tMJVETGzilhLRiCdBLBfibI8kLEpKeUz3HZgq27mbKRGE\n /Ts0cf6K6CVaqTmWC+QEXG/jwGDIhprfSYKfikEyYnGVVeL+n4NAhSo1WqN4FkY6vDpw\n i1XuFE7aukieoQC+GbL++Q/KZK1X8A9EfQTgCi3qovj+1ONfPAJVWAgTYqIsnPkSqa0V\n n0YqLnlkK0LSvyf+O7phubaCqm0pn4bj2ExYsFGR0SRypFv/AXe+IUDH4F0w8+ztrh+0\n QZcw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776072810; x=1776677610;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=0XI9DbHYUkGehlX0OcWQ888vFtJXew82enKuyuQHRk0=;\n b=dPGw4p+SOEQJB6xgJWjFgokph1mjKVhIsmV8c+eoegYp9UwvH24okoyWONwC462tmJ\n MRswEVpXTlzD/VdPGkD8rKJganJit/RyQD74iVX+Wcs6QWjN6zKFIKiy+UsEFisyzenK\n V2Uf65plC+jq5mc5LkuSiu29QgjMnVn6k5q2/ze6mbfGcSY+6ZoHynugkwNJhpKLAtl5\n U/ck34aMpglp2dC4k3VhRYPnt6UpuPdvWVBMcQshOcDm+2RM7xBgbZR3LEVOiYBVCfrs\n G4VIyUBfOn7Cavla42W4CxdvQdGiyEKSWX+PM6JrzU8q5ADEKh476Spu0F4yVvmc3YL3\n x8fw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9lFQIZwzZZYbuskegYoEGYGyiqY/Q2mfY3Hz4l8abWil7X8bM6Cb/pDItwt35MExeNR8jRZ70sKCuY@nongnu.org","X-Gm-Message-State":"AOJu0YyZpiFELI3xYBzonMXPuiUX29pWGeKM6grQv/8kPJ5tyAWUhzW3\n 7BRaTLnnaBIAIAadujsmziOP4dJCQSXZfDPq2P0mtKihHwGT7E8qqsgstnW7Rb1HfoO/yVSd8qe\n jTvIy+kcAwOx8SUuGoSCpDZEb/RD6fXPGTbnXz/i4Yw==","X-Gm-Gg":"AeBDievVYA0naDAq71s3Ctj0SK1AOg8dz872FZPKlnUugSIcJASchrbBAi/6l0Rq0lC\n SBJkYwxM4ZLjpwhf/uPrU1Dj/fIrzkMXtdwOE7Hp50KnNA1bftYgUUWykn9ENXVGoiVWLtpT9v8\n BQtcA8Scb0QKMp5CuuDuqx7zgbVWSFsX7O4qb2+n3uMEu3Hrxe5rOYBgB0Aixv2+IIU3s3IIkyI\n XVrP0Z2I9mZOgm65lpz/kiYWkNaYbBy9/RoB/v33pZao7NETK09F41x5fy02LZf8TjMTT0U96hd\n PdvX4T7Adp2G6+7wuBSfMe1UIlBEGRkSa40zpt8L0qDd2bg2/d6hHTo19IqbHUMEbCSALUmYJFe\n lYw==","X-Received":"by 2002:a05:690e:1341:b0:650:ece:89fd with SMTP id\n 956f58d0204a3-6518721b5b9mr12869286d50.27.1776072809671; Mon, 13 Apr 2026\n 02:33:29 -0700 (PDT)","MIME-Version":"1.0","References":"<20260413090010.60339-1-anisinha@redhat.com>","In-Reply-To":"<20260413090010.60339-1-anisinha@redhat.com>","From":"Peter Maydell ","Date":"Mon, 13 Apr 2026 10:33:17 +0100","X-Gm-Features":"AQROBzCPNQstYoD5bOM-E3AUU_4dEQnR2dcVMuHGo-eva1X-zovzQPwiUKgqIfo","Message-ID":"\n ","Subject":"Re: [PATCH for-11.0] accel/kvm: return early from kvm_irqchip_create\n if kvm does not support irqchip","To":"Ani Sinha ","Cc":"Paolo Bonzini ,\n Misbah Anjum N ,\n Gautam Menghani , Fabiano Rosas ,\n Harsh Prateek Bora , kvm@vger.kernel.org,\n qemu-devel@nongnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Received-SPF":"pass client-ip=2607:f8b0:4864:20::b136;\n envelope-from=peter.maydell@linaro.org; helo=mail-yx1-xb136.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3676609,"web_url":"http://patchwork.ozlabs.org/comment/3676609/","msgid":"","list_archive_url":null,"date":"2026-04-13T09:47:09","subject":"Re: [PATCH for-11.0] accel/kvm: return early from kvm_irqchip_create\n if kvm does not support irqchip","submitter":{"id":86030,"url":"http://patchwork.ozlabs.org/api/people/86030/","name":"Ani Sinha","email":"anisinha@redhat.com"},"content":"> On 13 Apr 2026, at 3:03 PM, Peter Maydell wrote:\n> \n> On Mon, 13 Apr 2026 at 10:01, Ani Sinha wrote:\n>> \n>> During refactoring of kvm_irqchip_create(), the refactored code was returning\n>> early from do_kvm_irqchip_create() function if the required capabilities were\n>> not present in KVM. This was not translating to an early return from\n>> kvm_irqchip_create() as was the case before refactoring. This is because,\n>> do_kvm_irqchip_create() did not have a means to notify the caller of the lack\n>> of kvm capabilities. Fix this by making do_notify_irqchip_create() return\n>> EOPNOTSUPP error when required capabilities are absent and then the caller\n>> can check the return code and return early.\n>> \n>> Fixes: 98884e0cc1 (\"accel/kvm: add changes required to support KVM VM file descriptor change\")\n>> Reported-by: Misbah Anjum N \n>> Reported-by: Gautam Menghani \n>> Suggested-by: Fabiano Rosas \n>> Suggested-by: Harsh Prateek Bora \n>> Signed-off-by: Ani Sinha \n>> ---\n>> accel/kvm/kvm-all.c | 11 ++++++++---\n>> 1 file changed, 8 insertions(+), 3 deletions(-)\n>> \n>> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c\n>> index 774499d34f..92af42503b 100644\n>> --- a/accel/kvm/kvm-all.c\n>> +++ b/accel/kvm/kvm-all.c\n>> @@ -2575,7 +2575,7 @@ void kvm_irqchip_set_qemuirq_gsi(KVMState *s, qemu_irq irq, int gsi)\n>> g_hash_table_insert(s->gsimap, irq, GINT_TO_POINTER(gsi));\n>> }\n>> \n>> -static void do_kvm_irqchip_create(KVMState *s)\n>> +static int do_kvm_irqchip_create(KVMState *s)\n>> {\n>> int ret;\n>> if (kvm_check_extension(s, KVM_CAP_IRQCHIP)) {\n>> @@ -2587,7 +2587,7 @@ static void do_kvm_irqchip_create(KVMState *s)\n>> exit(1);\n>> }\n>> } else {\n>> - return;\n>> + return -EOPNOTSUPP;\n>> }\n>> \n>> if (kvm_check_extension(s, KVM_CAP_IRQFD) <= 0) {\n> \n> This function confuses me. With this patch it can do three things:\n> * report an error and exit(1)\n> * return success\n> * return a failure code\n> \n> What is the difference between the cases where we exit and\n> where we return the error code? The commit message says we\n> return an error \"when required capabilities are absent\", but\n> we do the error-exit for e.g. \"KVM_CAP_IRQFD not present\", which\n> sounds like \"required capabilities are absent\" to me...\n\nI think it should be an assertion there. That is instead of exit(1) we should have had\n\nassert(kvm_check_extension(s, KVM_CAP_IRQFD));\n\nThat is you can’t have KVM_CAP_IRQCHIP cap and not have KVM_CAP_IRQFD . That is how I understand it.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=IL78LQOo;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=rS3QYm1v;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvMzN4DjWz1xtJ\n\tfor ; Mon, 13 Apr 2026 19:48:14 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCDtG-00010t-Jp; Mon, 13 Apr 2026 05:47:34 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCDtE-00010Q-Ez\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 05:47:32 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCDtC-0000E5-EL\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 05:47:32 -0400","from mail-pg1-f198.google.com (mail-pg1-f198.google.com\n [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-684-lo6Y6kLuOmSnI8w6tEd08A-1; Mon, 13 Apr 2026 05:47:27 -0400","by mail-pg1-f198.google.com with SMTP id\n 41be03b00d2f7-c76cb2dce57so2530352a12.1\n for ; Mon, 13 Apr 2026 02:47:26 -0700 (PDT)","from smtpclient.apple ([122.163.114.34])\n by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c7921a12adasm9453700a12.26.2026.04.13.02.47.22\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Mon, 13 Apr 2026 02:47:25 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776073648;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=vFPS6fRPR8ifQZYJmpMES4Pv/Kh+VEGwYZnf74bIzfc=;\n b=IL78LQOoPDTDc9xN3ksDeBweh9FsNQPfxzmk33jTcuD71eH4Z6wdkI0NZlnotMNNnqMJqe\n LJIZcybDF4HjnOH50RlDaOyVDyTxD9UZKdv3RS0/DxaE5BaZAs7NYL3L5oq1+8+o/iHBSc\n He8emBm5CySdbnc7+I9vMaGQ6O4tp3s=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776073646; x=1776678446; darn=nongnu.org;\n h=to:references:message-id:content-transfer-encoding:cc:date\n :in-reply-to:from:subject:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=vFPS6fRPR8ifQZYJmpMES4Pv/Kh+VEGwYZnf74bIzfc=;\n b=rS3QYm1vLnGt/bYd34QwFT96iWUz//5mWxB6ZFzuFmLmeq8jIw9r2e2W2HLA1bDDpk\n OcOm9nbEW0yX/Jyb3tWKkm61EbCXsB3pgs7AR/+QyxnAXFUp/WtZ13x8NzQRi9fx43Ga\n xRaw+4JoF7VQHa3OKlb0lg4lOHEHjzasOx7zpBXjmgaqPOSnPAik2r34VJ698vyu4w7b\n V94niWGkxm0XY9lwm/6o6UWi0pqS+aCJH3MS4CvHPI4ta4i0rAkE/c8YnFJ/q+4dGnOv\n b/PsYmWljMNkDsrmzCPxMWVvTB3F9hTIeQzNJxs+40fmzEziuTsw+K/KNYK5HgUpbuiY\n p8ow=="],"X-MC-Unique":"lo6Y6kLuOmSnI8w6tEd08A-1","X-Mimecast-MFC-AGG-ID":"lo6Y6kLuOmSnI8w6tEd08A_1776073646","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776073646; x=1776678446;\n h=to:references:message-id:content-transfer-encoding:cc:date\n :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state\n :from:to:cc:subject:date:message-id:reply-to;\n bh=vFPS6fRPR8ifQZYJmpMES4Pv/Kh+VEGwYZnf74bIzfc=;\n b=S94vZmCepnmwtWpM2rp78eseLZ5dUeipL/fPSl4XqQvZgHuXhQcv1suHCl4ghdq5if\n 93rSqARyC5fdrr36rI+FiiXXOOPxd6DwJtUL56ZtLxuWTCcuGJZ5KQrwPShryvJ2MllU\n XhKb73FQ1xLFBEvVVZWvf1+KSkx5X+wGVwVsHOaMR63Ast905AcvqZPzxG5DEN+R+nZk\n SKQ8O2tg/vlj3j0AxYmZLU4gQEBk9IAa9hISvQfEz8exAqlvBk0lNPMM9n4AoWt/+QHj\n O7LpqxlMyO5pqCt5bkZpffPfGoO6f1G6tpbglF9yh7vHih6fL/agsB6y2YDCUB25DrH7\n gTag==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9bh4iuibRPYcVh7vt7D/KSE0zmkIsKbSMwT9u8sQabcUjDMzxP48WEf8x1nR1Wr4K3WxC8qawFGy0e@nongnu.org","X-Gm-Message-State":"AOJu0YwJ5b09lZA7Fb1j+mybFq52vwFRvpOP342ZQS/mTa7eoN98re51\n L6wxQZcyngr/AyYWzx9yv/0J8qdpdNiyFMsdUtJpAyGEF9uz3IITTYYfOIami35dF9mSqWa/wNH\n h+Wwkdn/72X/alYXmUB4e8u9C5FHDHk/Wqve5fMUpSDMDevPrE3Xw5nsn","X-Gm-Gg":"AeBDieuqtDwhJZ8IhBHVccIF8Lt1oP1sR1qsjngmPy3BGIg5QEdgIZibSxibbkMnVdO\n eN1kEJ882mdrHrMa7IEMcWQVhG+02I3gaEdIT+GT91ofPC2ebjVNLo1CC8GISwc35Ne6T7aBcyt\n gZGpaCZ4d9plBVTrWMhLvVYTLMrSzTX+xpu8SVLdvNM76IbqBQs04kYYtGiU5aQwfUvDxZWuJlI\n xXmYT1fND7qiSS0Yd2jWw2wfa2we2yA9rtCkBsS7HxrkdTajGmU/LDxISmb23obpILc0BGvb5qS\n p6WRykyKL037X9n09GlNX0YUwe8p3dmVzqaLuWx1TPQg4yCbjN12w1cKQNJX4AQmCejOK5mDdUr\n G9TmKVtrrUDwu0o5i2yaiXm55tC2JAdlyH/nOVQwuTExpr0Ymzt2vrtlmx5gXakjQdPLwkAr7Ay\n o=","X-Received":["by 2002:a05:6a21:9991:b0:39b:ce4a:f397 with SMTP id\n adf61e73a8af0-39fe3d0eca5mr14334536637.18.1776073646003;\n Mon, 13 Apr 2026 02:47:26 -0700 (PDT)","by 2002:a05:6a21:9991:b0:39b:ce4a:f397 with SMTP id\n adf61e73a8af0-39fe3d0eca5mr14334511637.18.1776073645547;\n Mon, 13 Apr 2026 02:47:25 -0700 (PDT)"],"Content-Type":"text/plain;\n\tcharset=utf-8","Mime-Version":"1.0 (Mac OS X Mail 16.0 \\(3864.500.181\\))","Subject":"Re: [PATCH for-11.0] accel/kvm: return early from kvm_irqchip_create\n if kvm does not support irqchip","From":"Ani Sinha ","In-Reply-To":"\n ","Date":"Mon, 13 Apr 2026 15:17:09 +0530","Cc":"Paolo Bonzini ,\n Misbah Anjum N ,\n Gautam Menghani , Fabiano Rosas ,\n Harsh Prateek Bora , kvm@vger.kernel.org,\n qemu-devel ","Content-Transfer-Encoding":"quoted-printable","Message-Id":"","References":"<20260413090010.60339-1-anisinha@redhat.com>\n ","To":"Peter Maydell ","X-Mailer":"Apple Mail (2.3864.500.181)","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=anisinha@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3676698,"web_url":"http://patchwork.ozlabs.org/comment/3676698/","msgid":"","list_archive_url":null,"date":"2026-04-13T12:10:03","subject":"Re: [PATCH for-11.0] accel/kvm: return early from kvm_irqchip_create\n if kvm does not support irqchip","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On Mon, 13 Apr 2026 at 10:01, Ani Sinha wrote:\n>\n> During refactoring of kvm_irqchip_create(), the refactored code was returning\n> early from do_kvm_irqchip_create() function if the required capabilities were\n> not present in KVM. This was not translating to an early return from\n> kvm_irqchip_create() as was the case before refactoring. This is because,\n> do_kvm_irqchip_create() did not have a means to notify the caller of the lack\n> of kvm capabilities. Fix this by making do_notify_irqchip_create() return\n> EOPNOTSUPP error when required capabilities are absent and then the caller\n> can check the return code and return early.\n\nAs a fix intended for 11.0 at this point in the release cycle,\nit would be helpful if the commit message stated what the\nuser-visible consqeuences of this bug are. That helps in\nidentifying whether this really does need to go into 11.0\n(i.e. whether it is release-critical).\n\n> Fixes: 98884e0cc1 (\"accel/kvm: add changes required to support KVM VM file descriptor change\")\n> Reported-by: Misbah Anjum N \n> Reported-by: Gautam Menghani \n> Suggested-by: Fabiano Rosas \n> Suggested-by: Harsh Prateek Bora \n> Signed-off-by: Ani Sinha \n\nReviewed-by: Peter Maydell \n\nas the minimal fix for the logic-bug introduced by 98884e0cc1.\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=n3kwoOSL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvR881rPzz1y2d\n\tfor ; Mon, 13 Apr 2026 22:11:02 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCG7R-0001Ft-Uq; Mon, 13 Apr 2026 08:10:21 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCG7O-0001FU-2r\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 08:10:18 -0400","from mail-yx1-xb135.google.com ([2607:f8b0:4864:20::b135])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wCG7M-0006zo-Hp\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 08:10:17 -0400","by mail-yx1-xb135.google.com with SMTP id\n 956f58d0204a3-6501418152cso3830095d50.0\n for ; Mon, 13 Apr 2026 05:10:15 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1776082215; cv=none;\n d=google.com; s=arc-20240605;\n b=goLQOt/ocWYyhzj67w+MPqRRpFV9xMZ0VWaNFHdqn4fI9VeBH9gY3C2epqcH2gYjbh\n ZWSR4MwwZT7MU6phrC+r7EaBujc92GuuEGMwuGWF3RS1+r+KxHgJ2PX5mBrXisgM8NUA\n 8T2iG0B34JevT1a1wmwUc0nZvD1vPEFnWBCenqc0/X3bwVwOAIp9070YIPxhQg6/g2ya\n yzIlkAVJKZ+G/wPMVWYw/up1loQ6bguNWz1HRZ9wwaX8vN4hBbw/S6hL85RwLvsZc9O4\n Q5wNQ32fXA68tySOKPc6BztUWSW4G6bxGztVsbhCXsDHPXhQqAIcE0MhwH17FmvO1ZEZ\n y47A==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=d0l7uKyUGAFvL6R4w6MO2qwL5tFfxbP6Pv5jSvZFfDc=;\n fh=nuDyw2AaQVMu/z3gTSY9tFXBGNPo8PzzGimxbuSOXjs=;\n b=ii8M3a/HBAbIuathslgOjOZoxna+1BOOG0JYHOde49s3SMdkOj/SnIhdUKRjJHLkE4\n Gw+MTZnauvreYT04MAzd1KYYxsLXqL4oAfi+/+P14uMfqmPWy0DRHv5nd3MKh90HTB98\n V27OSjxySPRSP37SV2XPcwVFmwAEDma26AmO4QI1h/eP70t1lyiUpX0V1kdBx3ho2XfV\n /HzoXeF/Nm1QrdJF+++HBUoRMndZbBBN6LA9WvOodgYpoK6ixCqv1nbpgkbQg9mhMD8t\n sBRTqabv8KcJdRswntrxRW7RAZ7BvmAcqN1SH5hEpWjGT0S7eZSojwUQM3ceU62pheRh\n tKug==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776082215; x=1776687015; darn=nongnu.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=d0l7uKyUGAFvL6R4w6MO2qwL5tFfxbP6Pv5jSvZFfDc=;\n b=n3kwoOSLWhsngl6TEgT5hSdUK+BeW2EDPVDoT6vPlSKrPabolu+hUUQEoXEtER+X7y\n VRh0EP/HR3NtID0GyRKDfveTZjjoq2TMIgC77J9XBgJQjiby22qQvxl0yI+XOl37PhVj\n ghTx9U1tODFZa/iN3aunAlfAr4vnRFg+ylILMJNAmIWxVWv80Imax8KnmhFSk/e9z7CM\n voqM7OIa5OMbS8SX4ujPGMmD5XK30wilV/TM4STyMTnkLIY2BCz1G9tPqKu6ZHsRqe0N\n Rr5x/H6lJAnP9f61TXUMhf/gKeDVrAtvIhLiwWBki5R24GmD50VTA1RkqMS0BS5qB7Xu\n /avw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776082215; x=1776687015;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=d0l7uKyUGAFvL6R4w6MO2qwL5tFfxbP6Pv5jSvZFfDc=;\n b=LC4genpPt6XjiqoWhZgPQrN7D3R6/YspvuQmBxSCVP3ojtMsJjoo5FQuNaqu/mdZNe\n kReRBtH1DvZUFXtGbJo1lISpkpRk4Y6gyWuSl8sgv87ulFKZuYOYUb40PcNAqXrUL9+p\n ylGc2sl6M/0Z4RGImZwETNVULAnZasGnRfzvDBkcs5V7FT+ZLDtY2Blp5xxqyv+rvx7l\n I7m0FwiTOkT9UhT1VXIEhP8d5rsz56Cv4qdmo7VRrw7qc3a7208dvJFO2sCkqRTxkw4W\n G9PDojx8Id/TGwhY6nSUq3iA+vn2ZKoC9JlQEquKhf7PCmZqsZAs/OWgHgQLvaaHWGF4\n CIEg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+NCwbcwZKa7FHa56Cf5d5bpJ0vJjVF5aiqG3QvEIWND4WwBu0YzbwoKojLNbC1SKmokIM6FaEd3Y7i@nongnu.org","X-Gm-Message-State":"AOJu0YxcrZ1QuPE6vZja99PqVoRW+ivpaOwfVUBrT02vEkgQK3GLDisQ\n DkqKEVhFRezGNxpuu0G7xpe4mvSSiG+cJbE7hoIGPrGAtenq1qlzV963RPeXm3fYyMEgqAbmamk\n QE266s49XGyoE8v3f6n5EF7FxWfkXj1+nJLZepS6+cw==","X-Gm-Gg":"AeBDietPq5WNnSX51YULrtuNNtX22Qg41w5PrFEGvO6Cq820A3ETVFMszyjqwUWg3fV\n vPteUkrNhfZYkmkbIM240RevFfKSlSSPyuUfZY30wmUmQ6gOfGuuTr1TbYqgT1cEZe3UeM3tmxR\n UZo+F6NkwZ/jsYh0fW8fVBd/nZFaWa2mDkG79WJFrzfNtGC+GwcsVXgELebvyPDYOKn0aSInHci\n U4tSyOqX8AJYvBXZYnJeLORUFNJ/rzH+bFw2R4oZ9HoBYdNWfSZ2fsD3OmdM9PI1AhszBftDONB\n kcfk2Yg/Uz16VCiYAit9/4sv/qlLVlQwJiXYDqzIJfruelCRA+7m2s2kEfJ8gSIPP68=","X-Received":"by 2002:a05:690e:4841:b0:650:211f:1d4 with SMTP id\n 956f58d0204a3-65198b82095mr8882405d50.47.1776082214947; Mon, 13 Apr 2026\n 05:10:14 -0700 (PDT)","MIME-Version":"1.0","References":"<20260413090010.60339-1-anisinha@redhat.com>","In-Reply-To":"<20260413090010.60339-1-anisinha@redhat.com>","From":"Peter Maydell ","Date":"Mon, 13 Apr 2026 13:10:03 +0100","X-Gm-Features":"AQROBzBUIwljeF7bsJTwC19zV3JnLe8AM7zwfh_wplD60WBQv9RPuRuBSo4bXGw","Message-ID":"\n ","Subject":"Re: [PATCH for-11.0] accel/kvm: return early from kvm_irqchip_create\n if kvm does not support irqchip","To":"Ani Sinha ","Cc":"Paolo Bonzini ,\n Misbah Anjum N ,\n Gautam Menghani , Fabiano Rosas ,\n Harsh Prateek Bora , kvm@vger.kernel.org,\n qemu-devel@nongnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Received-SPF":"pass client-ip=2607:f8b0:4864:20::b135;\n envelope-from=peter.maydell@linaro.org; helo=mail-yx1-xb135.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3676703,"web_url":"http://patchwork.ozlabs.org/comment/3676703/","msgid":"<1974E499-C3D2-4A3C-A5B9-89961751F23E@redhat.com>","list_archive_url":null,"date":"2026-04-13T12:20:04","subject":"Re: [PATCH for-11.0] accel/kvm: return early from kvm_irqchip_create\n if kvm does not support irqchip","submitter":{"id":86030,"url":"http://patchwork.ozlabs.org/api/people/86030/","name":"Ani Sinha","email":"anisinha@redhat.com"},"content":"> On 13 Apr 2026, at 5:40 PM, Peter Maydell wrote:\n> \n> On Mon, 13 Apr 2026 at 10:01, Ani Sinha wrote:\n>> \n>> During refactoring of kvm_irqchip_create(), the refactored code was returning\n>> early from do_kvm_irqchip_create() function if the required capabilities were\n>> not present in KVM. This was not translating to an early return from\n>> kvm_irqchip_create() as was the case before refactoring. This is because,\n>> do_kvm_irqchip_create() did not have a means to notify the caller of the lack\n>> of kvm capabilities. Fix this by making do_notify_irqchip_create() return\n>> EOPNOTSUPP error when required capabilities are absent and then the caller\n>> can check the return code and return early.\n> \n> As a fix intended for 11.0 at this point in the release cycle,\n> it would be helpful if the commit message stated what the\n> user-visible consqeuences of this bug are.\n\nOk I would appreciate if you can add this line in the commit log before putting it in CI:\n\n“Due to this regression, all KVM guests on PPC 64 hang immediately during startup\"\n\nOr if you prefer, I can spin up a new version with the updated commit message.\n\n> That helps in\n> identifying whether this really does need to go into 11.0\n> (i.e. whether it is release-critical).\n> \n>> Fixes: 98884e0cc1 (\"accel/kvm: add changes required to support KVM VM file descriptor change\")\n>> Reported-by: Misbah Anjum N \n>> Reported-by: Gautam Menghani \n>> Suggested-by: Fabiano Rosas \n>> Suggested-by: Harsh Prateek Bora \n>> Signed-off-by: Ani Sinha \n> \n> Reviewed-by: Peter Maydell \n> \n> as the minimal fix for the logic-bug introduced by 98884e0cc1.\n> \n> thanks\n> -- PMM\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=cb5jht3G;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=NkxntGOV;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvRMw3JKbz1yDF\n\tfor ; Mon, 13 Apr 2026 22:21:16 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCGHI-0004Ui-4w; Mon, 13 Apr 2026 08:20:32 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCGHF-0004UR-BV\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 08:20:29 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCGHB-0000VM-Hh\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 08:20:27 -0400","from mail-pl1-f197.google.com (mail-pl1-f197.google.com\n [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-638-E1uUgcQYNQ-vwI3LbmprZA-1; Mon, 13 Apr 2026 08:20:21 -0400","by mail-pl1-f197.google.com with SMTP id\n d9443c01a7336-2b2ed279eedso8308775ad.0\n for ; Mon, 13 Apr 2026 05:20:21 -0700 (PDT)","from smtpclient.apple ([122.163.114.34])\n by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c7922de0626sm10683181a12.13.2026.04.13.05.20.16\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Mon, 13 Apr 2026 05:20:19 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776082824;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=sg+50Q8sxRR1Aj/0H7R8h6PT06l8kVwGZNKTmLDU/uw=;\n b=cb5jht3GepqEY6CUkzUDO2z2AZxi9FDT4RIFrceHfetK02vfb2mkrvqp9mhdeh0d4AOkKE\n Pg1e1qWAgb1I0NIztodk+mfGEsy1P7ctwDGlwUF83GJZ7aBGY79WUdTmKxuXOqmj3pGxFP\n 4M4W2SJByWNKobNyhca68w48WGRpTzI=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776082820; x=1776687620; darn=nongnu.org;\n h=to:references:message-id:content-transfer-encoding:cc:date\n :in-reply-to:from:subject:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=sg+50Q8sxRR1Aj/0H7R8h6PT06l8kVwGZNKTmLDU/uw=;\n b=NkxntGOVzeb+KRqKbr/PZxqpzbof8Kx63ebL2cyKe1JnM4a02gS3ssxalfmJ0+ZVaP\n laz5mTXJMDDZX6KSP6E8Vo+F5PFGe6A1ChRCaQYBUuhsQ5h2AoI7jhrBGROf7UwnLGtZ\n pEaMSMWdAdUqMIfMgCt6fD0cT5aoVSZ/0iEb9/H3w1eOpy2Es4l6M5WOwYVDEcrrbXhr\n RCyWLHplzbZMzHbQL0+keaF1Oh+bcTZDyfMtJvtdPPaui0rVVbTafv2SUTARZOTuhToU\n 2X9LwEO6bT9ijytB7RoaNt7bTNQ5PKhig4dCekOPmdNKXpMtd8ZUeVnSrTvteB6rDI7L\n G7Gw=="],"X-MC-Unique":"E1uUgcQYNQ-vwI3LbmprZA-1","X-Mimecast-MFC-AGG-ID":"E1uUgcQYNQ-vwI3LbmprZA_1776082820","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776082820; x=1776687620;\n h=to:references:message-id:content-transfer-encoding:cc:date\n :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state\n :from:to:cc:subject:date:message-id:reply-to;\n bh=sg+50Q8sxRR1Aj/0H7R8h6PT06l8kVwGZNKTmLDU/uw=;\n b=oTjr/FCQD/H1id3frRfczpV3Yt+7Uo18z5bHg+7sfhSOV2wrafaUfSZ7OFLFEBwyVW\n VxRQTmtviptQrrdjAZedGOvSI6MtAnDl+CAwb6dAuxfsp0dOVWc1N1N89rf/xW/Td1Do\n B4qCRH6gCvqpoyeeMbBMDlngHd4RwoaC+LhJdFFsC8GrAB3M7497XjMKv8NM7atoLebt\n fCOSjDktF82MAdC1yKG4qRX/ggO/GJoKoneLS8CJ9HkxzNGlWglC/Xf/7UETnt455Ieo\n n5E+AC7XJdc4V+T5y7/mE2EtVrcySFFjplPnCiibNYi1EYnaH/MbIKUtaXnmCr/5tAhq\n Uwvg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/sz3Xq4F3f1SelJ7PAgcN/IcLQVeFpMElF+pS3RJgf7sln9a89uscLkl1IXgzobeeHYIlOxRsVMrqG@nongnu.org","X-Gm-Message-State":"AOJu0YxPFddOmT6rLS7fTbXerIiylik2q4UuzoyGYvdE7apgvHYk5YS3\n 4VzqQQwsSJ2eqEng4MIFjROxnbr/k6Ekjx8jjfoNxvi1A8airIJEh3BHFFKSmDbSV3Li3WwJ5A1\n PuMgxUtAzHUL90JnD0T3Gar5N4/raqiwZJAQuipJytHx1ciO2et+8/oybCMK5nIF3","X-Gm-Gg":"AeBDietp3QpmPj2gse/txgSGvR9OyuwIzSm7d6GLa/U3u+LXR9bi45jMZV7ED9+xJ+D\n dSPDzkz6iN4y/NfIiWfGOj4EgSX54QejV/MDBTIF41K4WrNwYsMenJvpROOb19BnpWpXlTm+YIA\n dfKywlxxsBNG0bKpYu8fozYGBtlMDh/vYxbShXbkvdTuahkt/yojLP9657oBD7zEGJx0gyKgLQd\n aCOyTw+JsPm0ZQaWEAm9mqEWNukyXeVHPOvaCHr/e4jT48lKWRf+ll7Gonhnrz3oIyi/5BXHpae\n Fk1YB6/bpUH1ZLLccEMrOXOBne1i09vnjBT9MExk0WYoTPqzaEINgkYmRuStUXqzsGtdOL3YLZ7\n Tg+GuAY0L7evuMFXtmwMjz3lx3ApoBZBL82CqIhQIUdD1iryCLPnc3ToGj1Qk5Dog2qYbF8wIO/\n 4=","X-Received":["by 2002:a05:6a20:748b:b0:38e:9220:ebbe with SMTP id\n adf61e73a8af0-39fe3d616a7mr14231524637.23.1776082820017;\n Mon, 13 Apr 2026 05:20:20 -0700 (PDT)","by 2002:a05:6a20:748b:b0:38e:9220:ebbe with SMTP id\n adf61e73a8af0-39fe3d616a7mr14231494637.23.1776082819551;\n Mon, 13 Apr 2026 05:20:19 -0700 (PDT)"],"Content-Type":"text/plain;\n\tcharset=utf-8","Mime-Version":"1.0 (Mac OS X Mail 16.0 \\(3864.500.181\\))","Subject":"Re: [PATCH for-11.0] accel/kvm: return early from kvm_irqchip_create\n if kvm does not support irqchip","From":"Ani Sinha ","In-Reply-To":"\n ","Date":"Mon, 13 Apr 2026 17:50:04 +0530","Cc":"Paolo Bonzini ,\n Misbah Anjum N ,\n Gautam Menghani , Fabiano Rosas ,\n Harsh Prateek Bora , kvm@vger.kernel.org,\n qemu-devel ","Content-Transfer-Encoding":"quoted-printable","Message-Id":"<1974E499-C3D2-4A3C-A5B9-89961751F23E@redhat.com>","References":"<20260413090010.60339-1-anisinha@redhat.com>\n ","To":"Peter Maydell ","X-Mailer":"Apple Mail (2.3864.500.181)","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=anisinha@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3676856,"web_url":"http://patchwork.ozlabs.org/comment/3676856/","msgid":"","list_archive_url":null,"date":"2026-04-13T17:09:37","subject":"Re: [PATCH for-11.0] accel/kvm: return early from kvm_irqchip_create\n if kvm does not support irqchip","submitter":{"id":90528,"url":"http://patchwork.ozlabs.org/api/people/90528/","name":"Misbah Anjum N","email":"misanjum@linux.ibm.com"},"content":"Hi Ani,\nI've tested the v1 patch: [PATCH for-11.0] accel/kvm: return early from \nkvm_irqchip_create if kvm does not support irqchip, on PowerPC machine \nand it resolves the boot hang issue seen when booting KVM guest with >1 \nsmp value.\n\nRegression Details:\nCommit 98884e0cc1 (\"accel/kvm: add changes required to support KVM VM \nfile descriptor change\") led to a regression which caused KVM guests on \nppc64le to hang indefinitely during boot when SMP was configured. Single \nvCPU guests booted successfully, but any configuration with more than \none vCPU would hang.\nThe hang occurred at bql_lock() in qemu_default_main() \n(system/main.c:49), where the system would become completely \nunresponsive after successfully completing qemu_system_reset().\nReference: \nhttps://lists.nongnu.org/archive/html/qemu-ppc/2026-03/msg00035.html\n\nTest Environment:\n- Host Arch: ppc64le\n- Host and Guest OS: Fedora 42\n- Machine Type: pseries with KVM acceleration\n- QEMU: Latest master with this patch applied\n\nTest Results:\nAll the following SMP topologies now boot successfully:\n\nSingle and simple multi-CPU:\n- -smp 1\n- -smp 2\n- -smp 4\n- -smp 32\n\nVarious socket/core/thread combinations (8 vCPUs):\n- -smp 8,sockets=8,cores=1,threads=1\n- -smp 8,sockets=1,cores=8,threads=1\n- -smp 8,sockets=1,cores=1,threads=8\n- -smp 8,sockets=2,cores=4,threads=1\n- -smp 8,sockets=1,cores=4,threads=2\n- -smp 8,sockets=2,cores=1,threads=4\n- -smp 8,sockets=2,cores=2,threads=2\n\nHigher vCPU count:\n- -smp 16,sockets=2,cores=4,threads=2\n- -smp 32,sockets=1,cores=8,threads=4\n\nTested-by: Misbah Anjum N \n\nThanks,\nMisbah Anjum N \n\nOn 2026-04-13 14:30, Ani Sinha wrote:\n> During refactoring of kvm_irqchip_create(), the refactored code was \n> returning\n> early from do_kvm_irqchip_create() function if the required \n> capabilities were\n> not present in KVM. This was not translating to an early return from\n> kvm_irqchip_create() as was the case before refactoring. This is \n> because,\n> do_kvm_irqchip_create() did not have a means to notify the caller of \n> the lack\n> of kvm capabilities. Fix this by making do_notify_irqchip_create() \n> return\n> EOPNOTSUPP error when required capabilities are absent and then the \n> caller\n> can check the return code and return early.\n> \n> Fixes: 98884e0cc1 (\"accel/kvm: add changes required to support KVM VM\n> file descriptor change\")\n> Reported-by: Misbah Anjum N \n> Reported-by: Gautam Menghani \n> Suggested-by: Fabiano Rosas \n> Suggested-by: Harsh Prateek Bora \n> Signed-off-by: Ani Sinha \n> ---\n> accel/kvm/kvm-all.c | 11 ++++++++---\n> 1 file changed, 8 insertions(+), 3 deletions(-)\n> \n> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c\n> index 774499d34f..92af42503b 100644\n> --- a/accel/kvm/kvm-all.c\n> +++ b/accel/kvm/kvm-all.c\n> @@ -2575,7 +2575,7 @@ void kvm_irqchip_set_qemuirq_gsi(KVMState *s,\n> qemu_irq irq, int gsi)\n> g_hash_table_insert(s->gsimap, irq, GINT_TO_POINTER(gsi));\n> }\n> \n> -static void do_kvm_irqchip_create(KVMState *s)\n> +static int do_kvm_irqchip_create(KVMState *s)\n> {\n> int ret;\n> if (kvm_check_extension(s, KVM_CAP_IRQCHIP)) {\n> @@ -2587,7 +2587,7 @@ static void do_kvm_irqchip_create(KVMState *s)\n> exit(1);\n> }\n> } else {\n> - return;\n> + return -EOPNOTSUPP;\n> }\n> \n> if (kvm_check_extension(s, KVM_CAP_IRQFD) <= 0) {\n> @@ -2610,13 +2610,17 @@ static void do_kvm_irqchip_create(KVMState *s)\n> fprintf(stderr, \"Create kernel irqchip failed: %s\\n\", \n> strerror(-ret));\n> exit(1);\n> }\n> +\n> + return 0;\n> }\n> \n> static void kvm_irqchip_create(KVMState *s)\n> {\n> assert(s->kernel_irqchip_split != ON_OFF_AUTO_AUTO);\n> \n> - do_kvm_irqchip_create(s);\n> + if (do_kvm_irqchip_create(s) < 0) {\n> + return;\n> + }\n> kvm_kernel_irqchip = true;\n> /* If we have an in-kernel IRQ chip then we must have asynchronous\n> * interrupt delivery (though the reverse is not necessarily true)\n> @@ -2835,6 +2839,7 @@ static int kvm_reset_vmfd(MachineState *ms)\n> }\n> \n> if (s->kernel_irqchip_allowed) {\n> + /* ignore return from this function */\n> do_kvm_irqchip_create(s);\n> }","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=bbLICQD5;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvYnn4tJWz1xtJ\n\tfor ; Tue, 14 Apr 2026 03:10:37 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCKnJ-00080G-S3; Mon, 13 Apr 2026 13:09:53 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCKnG-0007zR-Sj; Mon, 13 Apr 2026 13:09:50 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCKnD-0001j1-Fw; Mon, 13 Apr 2026 13:09:50 -0400","from pps.filterd (m0360072.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63DAZo7O2032997; Mon, 13 Apr 2026 17:09:41 GMT","from ppma21.wdc07v.mail.ibm.com\n (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dfdxx0cgn-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Mon, 13 Apr 2026 17:09:40 +0000 (GMT)","from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 63DCshLc003514;\n Mon, 13 Apr 2026 17:09:40 GMT","from smtprelay03.wdc07v.mail.ibm.com ([172.16.1.70])\n by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dg1mn630r-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Mon, 13 Apr 2026 17:09:40 +0000","from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com\n [10.39.53.230])\n by smtprelay03.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63DH9DAR56623426\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Mon, 13 Apr 2026 17:09:13 GMT","from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id DC7B65805D;\n Mon, 13 Apr 2026 17:09:38 +0000 (GMT)","from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 242B558054;\n Mon, 13 Apr 2026 17:09:38 +0000 (GMT)","from ltc.linux.ibm.com (unknown [9.5.196.140])\n by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Mon, 13 Apr 2026 17:09:38 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=pp1; bh=jvkv1E\n hOM9FjUKEgFLeZl8Kti3qQYiTZqztepQsUBs8=; b=bbLICQD58duJcama1Y40HF\n BsyxfGmIvwtjciTzAouk4xIdOn3ufHagO2FFwNibK1+t53DSnrd9IZ5mVAyQ+CsF\n lO0PRbY3HwOefFxtDj/yPswqkOpjy50wFQzlkWVNKt+ffu30PdrxK8qmpWd/6HyS\n KOO2vjkDU4ZoWUy35hAxGTKd+87e0oHdZ5UBcAN/dj3dA1hlWHQgICnJ4KpBVmKv\n 2cLPW/gfoPWhOQDLBC56fwe912SlQ5Hfln26OJZKylEYvno2pLCEVOSAN25prjHe\n iugm+J0UEPK6+wxrS1y0VTZVFWmKHNLLzk+sQ8GPXkU7AS670X12EAVuxZH48oMw\n ==","MIME-Version":"1.0","Date":"Mon, 13 Apr 2026 22:39:37 +0530","From":"Misbah Anjum N ","To":"Ani Sinha , Pbonzini ,\n peter.maydell@linaro.org, Harshpb ","Cc":"Gautam Menghani , Fabiano Rosas ,\n Harsh Prateek Bora , kvm@vger.kernel.org, Qemu Devel\n , Qemu Ppc ","Subject":"Re: [PATCH for-11.0] accel/kvm: return early from kvm_irqchip_create\n if kvm does not support irqchip","In-Reply-To":"<20260413090010.60339-1-anisinha@redhat.com>","References":"<20260413090010.60339-1-anisinha@redhat.com>","Message-ID":"","X-Sender":"misanjum@linux.ibm.com","Organization":"IBM","Content-Type":"text/plain; charset=US-ASCII;\n format=flowed","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDEzMDE2NSBTYWx0ZWRfXyw05g0Jv+net\n eYbLEPhpxtNeeiy5ZHJF1ZmXZI6hnx8CzmKVUVAYJYhwt70Ipoe+gnnMfOXosviA8sfbiBmhtuq\n SsbG140BfLr9KicYuvCMbEX62paaR/AbILqo96DRcNyBhzhKtkkgVJxhU3d9Gg0kQET+enc2nbs\n owFiAe0t0EKxqL6rYvAzsF6c9rlEucN5Temn20wTecdpU7r6ynuh1OZkEGvlF1hcpb6B69T+oyf\n klPViGv0QkODw0N8o8xMyOcdJVohHDqy4INDYfl1hNRAurHdjtS1aOyBLGcrZ3DBPAkmJy2sOKe\n qWnkvpV5XOBmpbAEMwtzqStgrCNPvVAofvHB2iUgaSuj30PgsvchWi59JXsyg2SN5/0zO/C55RN\n ZxSj0P1QEdAnoxwivMXruABiXZbQicnFxVeKuYTOcc2UG2acdF/qR3lO3zuFIM9BFCWRjk6aoY4\n owE36j8QUMkNdq7iKxQ==","X-Proofpoint-ORIG-GUID":"RR-QX_Ye8Rkbetis9C7Xq27ImKT7O_1t","X-Authority-Analysis":"v=2.4 cv=TId1jVla c=1 sm=1 tr=0 ts=69dd2354 cx=c_pps\n a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17\n a=kj9zAlcOel0A:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=69wJf7TsAAAA:8\n a=VnNF1IyMAAAA:8 a=20KFwNOVAAAA:8 a=ErzlIeVuY194znd37YUA:9 a=CjuIK1q_8ugA:10\n a=Fg1AiH1G6rFz08G2ETeA:22","X-Proofpoint-GUID":"RR-QX_Ye8Rkbetis9C7Xq27ImKT7O_1t","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-13_03,2026-04-13_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n bulkscore=0 malwarescore=0 spamscore=0 adultscore=0 phishscore=0\n suspectscore=0 priorityscore=1501 impostorscore=0 clxscore=1011\n lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000\n definitions=main-2604130165","Received-SPF":"pass client-ip=148.163.158.5;\n envelope-from=misanjum@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]