[{"id":3676752,"web_url":"http://patchwork.ozlabs.org/comment/3676752/","msgid":"","list_archive_url":null,"date":"2026-04-13T13:35:22","subject":"Re: [PATCH] cmd: mmc: allow 'mmc rst-function' to show the current\n value","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Rasmus,\n\nOn 2026-04-13T08:13:22, Rasmus Villemoes wrote:\n> cmd: mmc: allow 'mmc rst-function' to show the current value\n>\n> Extend the 'mmc rst-function' subcommand so that lacking a value to\n> set, it simply prints the current value, and its interpretation.\n>\n> Signed-off-by: Rasmus Villemoes \n>\n> cmd/mmc.c | 36 +++++++++++++++++++++++++++---------\n> doc/usage/cmd/mmc.rst | 4 ++--\n> 2 files changed, 29 insertions(+), 11 deletions(-)\n\n> diff --git a/cmd/mmc.c b/cmd/mmc.c\n> @@ -1032,6 +1026,30 @@ static int do_mmc_rst_func(...)\n> + switch (ext_csd[EXT_CSD_RST_N_FUNCTION]) {\n> + case 0x0: puts(\"(temporarily disabled)\\n\"); break;\n> + case 0x1: puts(\"(permanently enabled)\\n\"); break;\n> + case 0x2: puts(\"(permanently disabled)\\n\"); break;\n> + default: puts(\"(unknown)\\n\");\n> + }\n\nWe normally put case/default on their own line, as elsewhere in this file.\n\nI'd even suggest putting this code in its own function.\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=QLq3WXEs;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"QLq3WXEs\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvT253fq5z1yDG\n\tfor ; Mon, 13 Apr 2026 23:35:57 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id BA25A839DF;\n\tMon, 13 Apr 2026 15:35:48 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 4275783DC9; Mon, 13 Apr 2026 15:35:47 +0200 (CEST)","from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com\n [IPv6:2607:f8b0:4864:20::52a])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 05B11839D5\n for ; Mon, 13 Apr 2026 15:35:45 +0200 (CEST)","by mail-pg1-x52a.google.com with SMTP id\n 41be03b00d2f7-c6e2355739dso1969327a12.2\n for ; Mon, 13 Apr 2026 06:35:44 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776087343; cv=none;\n d=google.com; s=arc-20240605;\n b=UnIqlQiSlb98+Lu39H7Fw5e0t5z2LofTjuoTAsOlNuSfiXqylayFbKT3Kjj2Epmrbz\n jKBCyvbqv1qSAe7Ahv9tzFo7APQ9s4z94xeHLQ5sQvsK98Y/ZqQj/hkGCyNiL0KbCvtS\n VB8XQFPFkyxEDeseD8kqQqZ/MmwWDuJKaR43aDwUyKiKemi9WOI6ytnADPTWluPsDl2N\n hryhYiATgns5MCAHneUuHFffuI06Fl9W9PGxxMB6lEWIOP65zu+j5Hhzt9ZGAAudHjtG\n IdjcbYggYChtj0hfSStrNe52hMOaWMzFfkAQESeBtgbLob7QqNn5s5C94zZOom979KME\n FTjQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=Z7ZzCNClvuGhPxwPhk06oJNAdC7Deo6tl10wkKnHgps=;\n fh=ZvTOplTg/Tb064jHRbjjpY73JyZzsX6EywF5EPWG8TY=;\n b=iZvrjRZg+Za+bHWv71qARwXnLsdwXSeZgpZtJpM2CbF+R6SSm3Mt6C0WKyp6URMn51\n 01iBs0aLTkHbycM33eq6rgaxRD/LkQ7094O0qtlAS/45sYTbp6q9W1+TNo4Ttbj+e4iI\n sMUry6UfSNjK5hvSJ4hQBN8eVa/szDIG23Ifpg3Fj092ibRpTi4u/LJvHEUKsE1WoPN4\n iYw7y/G7KDmJsZBYi2mOKyt4wgeuTZLrpFnnoBQ8p+Arlrr4VXhoLYhNUEApWixX52rF\n fWKdX8B6e6O2GoJhcESJFq9JaI0DC9ZL+kecSEXjSKLuil9+XFHQV+bJPe3lsSsIRPlc\n 4VkQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776087343; x=1776692143; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=Z7ZzCNClvuGhPxwPhk06oJNAdC7Deo6tl10wkKnHgps=;\n b=QLq3WXEsgHlrJjukk4zmpTCG6t1DfCQB6Q7h8boJqbHls6k5kSM2KQhinNZr+Q6ZH4\n AVQkHdOzJ5g2W1yX7y8rSXAzAMM3ufLvG7OP2rITHSq0AujStKYsXl/HPL18dg5HuuHT\n OUusBetMvelwAbH/NGZ/MHv4STpDqhd8ZCreg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776087343; x=1776692143;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Z7ZzCNClvuGhPxwPhk06oJNAdC7Deo6tl10wkKnHgps=;\n b=YDgCsKyrzMzgSBEtIZcnWiHREnJDFHKWM7X4MQSKiQAudL8id8TPGlQUpAWWWQps3Q\n euGPgWBlrIjm1GwRQlABPWu5AFbTNv5Bkb+NoTqFlwIwLYaOs0iMzdIKmollB0m/eEjx\n Be7mksCZww7j613tOFygU3HJ6sLImIP55YZfszFZ8hq0mjnM/tD3BJSDL+5uA3OlTYcj\n aD2utm65XrjJ099yKngoNB0vle1pEyGG2lHI6Hmmv7BKGXHiG33gKq3rq1Krj0+9nsZ+\n LKKqTb3llvWANIwX2Zjdv+e/uE7EiKGb+VmNNf+WKL5T4wMQWvkgRAVv9T2l0WnV79ZU\n flCg==","X-Gm-Message-State":"AOJu0Ywwbuk2s4fXsu98UWHL3103CNb4jvUMRFNsSkVMwM0Vcy3mGDd5\n UlWKQhOqGW+B+o7Ea2QVG9Mr/YnEGJZ9wVSCexr1SQOkhy9vblsX4FxCqysVh0Tssa8UyKrC1rc\n duC+4paL+hiJsNcZOMQXcjza054nxgnqhpWtqVJfO","X-Gm-Gg":"AeBDiet24GVpUVJY/k1eg/HwQw+hag3XOoLzl0JKmR/90Sshq7S2yPCjn/q6NVLpXKB\n vEr2ERAzQpDOpFildSzCi0VGxc+7j0RTOnds808GLfuWFmPbgiagf0JDDmOiIWhx8nZakEZj4VJ\n zEWcww5yVtDHEF4pH4VTam3COBdwqFWMRnopnLr9ZKNBEobr9NOk8NHH3eQxtcBGHU8o3ycXgPT\n ZtnQ9f1N6BYsXYX6lUZuS2+hHamkeMInmVOh6/fgf1Kd0mwJOXa62eQKUwUXXhR+6hCiAPuihpP\n mez6fOTZTdRBFa6B","X-Received":"by 2002:a05:6a00:1bcd:b0:82c:24d5:63e6 with SMTP id\n d2e1a72fcca58-82f0c169049mr13084199b3a.15.1776087343472; Mon, 13 Apr 2026\n 06:35:43 -0700 (PDT)","MIME-Version":"1.0","References":"<20260413081322.2226374-1-ravi@prevas.dk>","In-Reply-To":"<20260413081322.2226374-1-ravi@prevas.dk>","From":"Simon Glass ","Date":"Mon, 13 Apr 2026 07:35:22 -0600","X-Gm-Features":"AQROBzAXxe7JioZZJ7ozhD_1BGaI7FEq003X9j_VMpx7kfk_KBJSoj2FttCBJTE","Message-ID":"\n ","Subject":"Re: [PATCH] cmd: mmc: allow 'mmc rst-function' to show the current\n value","To":"ravi@prevas.dk","Cc":"u-boot@lists.denx.de, Peng Fan ,\n Tom Rini , Jaehoon Chung ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]