[{"id":3677077,"web_url":"http://patchwork.ozlabs.org/comment/3677077/","msgid":"<01cee873-23d7-43f5-96eb-29826d1c157c@linux.intel.com>","list_archive_url":null,"date":"2026-04-14T08:55:35","subject":"Re: [Intel-wired-lan] [PATCH iwl-net v2] e1000e: Unroll PTP in\n probe error handling","submitter":{"id":88401,"url":"http://patchwork.ozlabs.org/api/people/88401/","name":"Dawid Osuchowski","email":"dawid.osuchowski@linux.intel.com"},"content":"On 2026-04-13 2:03 AM, Matt Vollrath wrote:\n\nHey Matt,\n\nThanks for the patch!\n\nApologies but it seems I didn't explain fully where the changelog should \ngo, same goes for the Cc: stable as it should be inserted into the \ncommit msg as a tag, see example below.\n\n> If probe fails after registering the PTP clock and its delayed work,\n> these resources must be released.\n> \n> This was not an issue until a 2016 fix moved the e1000e_ptp_init() call\n> before the jump to err_register.\n> \n> Fixes: aa524b66c5ef (\"e1000e: don't modify SYSTIM registers during SIOCSHWTSTAMP ioctl\")\n> Signed-off-by: Matt Vollrath \n> Tested-by: Avigail Dahan \n> ---\n\nChangelog should go _here_, not below the:","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=eJMJYacP;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvymL4pgWz1xtJ\n\tfor ; Tue, 14 Apr 2026 18:55:46 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 9301161CD9;\n\tTue, 14 Apr 2026 08:55:44 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id y04yLUP4xfe6; Tue, 14 Apr 2026 08:55:42 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id B4167608C7;\n\tTue, 14 Apr 2026 08:55:42 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists1.osuosl.org (Postfix) with ESMTP id 7063E283\n for ; Tue, 14 Apr 2026 08:55:41 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 6149A403B9\n for ; Tue, 14 Apr 2026 08:55:41 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ew8xyKjSTj3a for ;\n Tue, 14 Apr 2026 08:55:40 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.13])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 66F9240191\n for ; Tue, 14 Apr 2026 08:55:39 +0000 (UTC)","from fmviesa009.fm.intel.com ([10.60.135.149])\n by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Apr 2026 01:55:40 -0700","from avbakuno-mobl.ccr.corp.intel.com (HELO [10.246.16.61])\n ([10.246.16.61])\n by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Apr 2026 01:55:37 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org B4167608C7","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 66F9240191"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776156942;\n\tbh=rzFrTzoq0HnCZHcVlEeNBgHotPSPhdkKZmBWoRPrbOg=;\n\th=Date:To:Cc:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=eJMJYacP4ByzmhjB6CcML5F2+m+iUCjf9yNJnAUsLcKpakVY1510DPUp2cf36sxB2\n\t Rqpg0rRU98/ZY90GoSc8fCLO/enYt+cnNn+wy8+RbJAAAy8IcG7eRoP9TvEze4shEt\n\t N2OUwDooCuK979DyXMGIW/sfLKvLfqb18OPSuOef+A+zBERl+D8VjiZC3wpCUa7ONG\n\t n2Yy3M5H7hrh+xd5fj5cEIBF1mxtQ8TjUcgnJrlKE9ej6nZD55fgb+zitxQ1QjAyom\n\t 2tgC93tlUDcpfoP5ylAPmTB79HFGiyCbaW4XRS0Muo/3WLeaiJcbcBKlmf+AWrOJqC\n\t mkb3J+75S63yQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.13;\n helo=mgamail.intel.com; envelope-from=dawid.osuchowski@linux.intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 66F9240191","X-CSE-ConnectionGUID":["d+9770hPRLuuXx7to+YLZw==","rfAdmeYfT7OQFopcDKEkiA=="],"X-CSE-MsgGUID":["PZ+rTnQJTFO2NzzXwVA5AA==","Aoc23v+fREy3t9eodGYHEQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11758\"; a=\"88186418\"","E=Sophos;i=\"6.23,179,1770624000\"; d=\"scan'208\";a=\"88186418\"","E=Sophos;i=\"6.23,179,1770624000\"; d=\"scan'208\";a=\"223535662\""],"X-ExtLoop1":"1","Message-ID":"<01cee873-23d7-43f5-96eb-29826d1c157c@linux.intel.com>","Date":"Tue, 14 Apr 2026 10:55:35 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","To":"Matt Vollrath , intel-wired-lan@osuosl.org","Cc":"stable@vger.kernel.org, Avigail Dahan ","References":"<20260413000325.33379-1-tactii@gmail.com>","Content-Language":"pl, en-US","From":"Dawid Osuchowski ","Organization":"Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298\n Gdansk - KRS 101882 - NIP 957-07-52-316","In-Reply-To":"<20260413000325.33379-1-tactii@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776156941; x=1807692941;\n h=message-id:date:mime-version:subject:to:cc:references:\n from:in-reply-to:content-transfer-encoding;\n bh=kudLCTIITmlAZjTqgthhq39P8xFZprhHZarcmmvo6PU=;\n b=cWkG0Mt7cdFFEvQcCH004TenPRNAgqdAm3aPHelXIa6YTlN0O7cXaH8p\n +e9eeuIybEhuIkekaXSfKrJuDWe3iND6MAyA5ueTHLjo2XLI6trwe2XRh\n 6QWaFQLFM3hOBDOdKsWWHzwZeE0KZcZtMmlS68aDPOtSu8181EiETRbt3\n bcG7TPsc0MpgBKd4zKi2M6FrtCZ6nBoL3n32wJENYYV0fsaPE5KuWfBlC\n QtmV5JubuHJqA0xrKZPT3t5McgCKbMJKDGhs4V/DpsyaXYMJNCgI+K/Ll\n u1gFQu08ikVXpmhY7ewdTkFRWcLqmX78+uGwmpBDQt6x0GjEYrHbZlRI0\n w==;","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=linux.intel.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=cWkG0Mt7"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-net v2] e1000e: Unroll PTP in\n probe error handling","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3677322,"web_url":"http://patchwork.ozlabs.org/comment/3677322/","msgid":"<950488da-4776-44cf-8756-ecb717de5d38@gmail.com>","list_archive_url":null,"date":"2026-04-14T17:16:13","subject":"Re: [Intel-wired-lan] [PATCH iwl-net v2] e1000e: Unroll PTP in\n probe error handling","submitter":{"id":92679,"url":"http://patchwork.ozlabs.org/api/people/92679/","name":"Matt Vollrath","email":"tactii@gmail.com"},"content":"On 4/14/26 04:55, Dawid Osuchowski wrote:\n> Apologies but it seems I didn't explain fully where the changelog should go, same goes for the Cc: stable as it should be inserted into the commit msg as a tag, see example below.\n\nThanks Dawid, I had figured out the changelog after sending this by looking at other patches, but didn't see anyone else adding the Cc tag.\nmv","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=z0+JCUsW;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw9t10Wrdz1yCv\n\tfor ; Wed, 15 Apr 2026 03:16:22 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 658B684CAE;\n\tTue, 14 Apr 2026 17:16:20 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 6Y9r3xaURrYV; Tue, 14 Apr 2026 17:16:19 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 9D33284CA0;\n\tTue, 14 Apr 2026 17:16:19 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id CCE02375\n for ; Tue, 14 Apr 2026 17:16:17 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id B29C742C2A\n for ; Tue, 14 Apr 2026 17:16:17 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id htuNfWii2ago for ;\n Tue, 14 Apr 2026 17:16:17 +0000 (UTC)","from mail-dl1-x122b.google.com (mail-dl1-x122b.google.com\n [IPv6:2607:f8b0:4864:20::122b])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 08DE142C24\n for ; Tue, 14 Apr 2026 17:16:16 +0000 (UTC)","by mail-dl1-x122b.google.com with SMTP id\n a92af1059eb24-12732165d1eso16358331c88.1\n for ; Tue, 14 Apr 2026 10:16:16 -0700 (PDT)","from ?IPV6:2600:6c5c:6b00:ba4::23? ([2600:6c5c:6b00:ba4::23])\n by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2d80acca4c5sm17167382eec.19.2026.04.14.10.16.14\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 14 Apr 2026 10:16:15 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9D33284CA0","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 08DE142C24"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776186979;\n\tbh=a34u5VYi+HH6ZgXfKa2GQcL1piGR6fblTlJ80ZzRtvM=;\n\th=Date:To:Cc:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=z0+JCUsWADIRW/N8OEWzptK12usyzgEXGezdULuZxJ/EFClf5oGxMyqU/hQQm/8Yi\n\t r+fMdb+vRESoaNZI8WnPw0fG4ShOJ2kVoP17QrJXj10XSRtSKojUrO9/ijmKPgNTGO\n\t EPCoA1pyQm6jUHXZ9r3eJXWaOtV7oD4MybngVhui8BqoHufSgU5QSxPi0+RDVV5tV/\n\t Y8qQTIJCXCEiK81+JXASFZwoR/5faBHrtuG4HtR28m7jzO7vOffn0ZFrrDJB6BiagS\n\t kTb27JmBf+YG84REgoary38j1ECT9smMc+dzSDOMgpgOjrPoUf12sTv16OAqMpcu8h\n\t AwsBKcxvplyxA==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::122b; helo=mail-dl1-x122b.google.com;\n envelope-from=tactii@gmail.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 08DE142C24","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776186976; x=1776791776;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=a34u5VYi+HH6ZgXfKa2GQcL1piGR6fblTlJ80ZzRtvM=;\n b=BVPHGJbBInmoGcKrtopWeTHSj4kKBEqF5s4+IUmihCHlUBwetRsq7pyXDKEuAr1Ss7\n rN8wHoCmobn3a+l17pHiXD/N7r7j3xBmwRx7HRqoGJcQ0a2o4xlWoO2uJvcppmGSbdq1\n 45cjOKNdXOaE3cZsFuZ4BmAUFoRE8bB4BhK6rRA5Bx6uczYwet+JbZVFuYm+So6HVufw\n lTM9R8TYyPz2c/n7AxAJmZQdJ5u6rskesrM3F9keBK8Uy/Z41CudC0JXTRWDK7J7fzwK\n tvmZyJsKe8w3+ffYq71FoR8QDyrucqmUo6mZoNFYCueeB4cnpUBnlVkynwuqOVK1GCZU\n P2gw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8WLmhj5xeWBR7baei6nq4TDmAcL3FednFmb+f5G6FOpZvH1UOSLTBPXVMXMKz8BHmHFaqRS2lgrtsVRQgjpaQ=@osuosl.org","X-Gm-Message-State":"AOJu0YwowQIFW98qSuGYKzvT38JTp/DuCG/nxJ2GaQiJ2jvO3Q4QLJr9\n jji6SkPIz8QCy2/eqtdkhc0R4/+q2K481EMOEZ1MlJuqtFOym861eBkEiXWxY+cab4c=","X-Gm-Gg":"AeBDievt2r8s+8ez0c6PTm0V1BlFRq+XnCbFSXQAHw+SrIdPfnLS/T+4Gd0SscxRFdf\n B5dvTqejTdKUDuUsc3YVNZnpUjz2EFsAMNs63XeIlhXVhAHCHDIMubcpno/KKAC0K/JJtXFSajy\n VMiFc1rVnYkq/zZanQm3fEXyS4rKt1h+o99Vs0B2QLWpZFdcjW6kCX3iYuGxqV8ui/N7+rnXPuO\n 3dmfo2FAhu2CLhMn7rs5iqjW2U3LIYqNv28N28ixgnWfKEyA+jGPO6auJXdRvC8tMoRdjDPEdUO\n U/bIBSpTvHTynAAoXNSXk+pFMOnWYJoD3cb15Vj/EW2NCT35vQkrDnkG+qH7Fo9NTYWbpggK6Q4\n T0oxx5cxYMgbYHmQE99nCwt9qWk4oKcBBPR9eEG9XKEouzcKZlHdlMylDEo8JZKJ/7wA9eKI8fq\n YSOlFVhQfOhzRiNdx4HYuO3TXC","X-Received":"by 2002:a05:7300:7313:b0:2d8:b2e1:20cf with SMTP id\n 5a478bee46e88-2d8b2e122fbmr5869059eec.10.1776186975660;\n Tue, 14 Apr 2026 10:16:15 -0700 (PDT)","Message-ID":"<950488da-4776-44cf-8756-ecb717de5d38@gmail.com>","Date":"Tue, 14 Apr 2026 13:16:13 -0400","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","To":"Dawid Osuchowski ,\n intel-wired-lan@osuosl.org","Cc":"stable@vger.kernel.org, Avigail Dahan ","References":"<20260413000325.33379-1-tactii@gmail.com>\n <01cee873-23d7-43f5-96eb-29826d1c157c@linux.intel.com>","Content-Language":"en-US","From":"Matt Vollrath ","In-Reply-To":"<01cee873-23d7-43f5-96eb-29826d1c157c@linux.intel.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776186976; x=1776791776; darn=osuosl.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=a34u5VYi+HH6ZgXfKa2GQcL1piGR6fblTlJ80ZzRtvM=;\n b=F7lnOdSOhRLj8z0qscdsC27XfGvr9von2DwaPC2EOzf/1lJgcPKTE/hjLiuRwPXLLD\n yRjGabCrPqHrynsyMuUQHvJK7DSyw8emzPiBT4OVqC02ReZRNxo1BQCEl9nPBkLfj4ab\n RO5Em6pxlbwC/duOP4wzMDgc2cawk1U0nQQaxfT1YJAqsaxehEvDsTGujoe/5nU/gkBA\n Pt6X/q368N3LU65+y74+WmjUAwyg0MEw+QL0VtwfqVb0XoSuQx2u3PRrbril1JOUS+v8\n hqKsIyaVKFKsvoE6OQTYr5PwMWwl+4OqtmiIVgHYdiLdakP3N46pwUa1A3V4dOOs9sCK\n B45A==","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=gmail.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.a=rsa-sha256 header.s=20251104 header.b=F7lnOdSO"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-net v2] e1000e: Unroll PTP in\n probe error handling","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]